| 33d2055e594177b27360f84e0631b26d74a55a9b |
|
22-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
GM: some header cleanup
gm.h includes sk_tool_utils.h but does not use it.
The bulk of this CL makes each gm that uses sk_tool_utils include it.
sk_tool_utils.h also provided SkRandom and SkTDArray,
so a couple GMs add those headers too.
Change-Id: Ieb2a7c542f0ca89c3223f744fc11b0ff37af36c1
Reviewed-on: https://skia-review.googlesource.com/10014
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/gm/mixedtextblobs.cpp
|
| 37283c28aa5bea2204c18956e74f83b238d7a891 |
|
13-Sep-2016 |
fmalita <fmalita@chromium.org> |
Use sk_sp text blob APIs
SkTextBlobBuilder::build() -> make()
SkAutoTUnref<const SkTextBlob> -> sk_sp<SkTextBlob>
drawTextBlob(const SkTextBlob*) -> drawTextBlob(const sk_sp<SkTextBlob>&)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335493005
Review-Url: https://codereview.chromium.org/2335493005
/external/skia/gm/mixedtextblobs.cpp
|
| dbfd7ab10883f173f5c1b653a233e18dc6142002 |
|
01-Sep-2016 |
mtklein <mtklein@chromium.org> |
Replace a lot of 'static const' with 'constexpr' or 'const'.
'static const' means, there must be at most one of these, and initialize it at
compile time if possible or runtime if necessary. This leads to unexpected
code execution, and TSAN* will complain about races on the guard variables.
Generally 'constexpr' or 'const' are better choices. Neither can cause races:
they're either intialized at compile time (constexpr) or intialized each time
independently (const).
This CL prefers constexpr where possible, and uses const where not. It even
prefers constexpr over const where they don't make a difference... I want to have
lots of examples of constexpr for people to see and mimic.
The scoped-to-class static has nothing to do with any of this, and is not changed.
* Not yet on the bots, which use an older TSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005
Review-Url: https://codereview.chromium.org/2300623005
/external/skia/gm/mixedtextblobs.cpp
|
| 13b9c95295f4c5732e34574789e721a6bc08f7b4 |
|
12-May-2016 |
bungeman <bungeman@google.com> |
Move SkTypeface to sk_sp.
Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933393002
Review-Url: https://codereview.chromium.org/1933393002
/external/skia/gm/mixedtextblobs.cpp
|
| 9a9a7b29e5e5916a7b6453cd124ca437f14b9da4 |
|
12-May-2016 |
scroggo <scroggo@google.com> |
Revert of Move SkTypeface to sk_sp. (patchset #5 id:80001 of https://codereview.chromium.org/1933393002/ )
Reason for revert:
fontmgr_iterAndroid failing to draw emoji. E.g. https://gold.skia.org/search2?blame=6296da736fbf40aae881650c239420f64e576c3f&unt=true&head=true&query=source_type%3Dgm
Original issue's description:
> Move SkTypeface to sk_sp.
>
> Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
TBR=reed@google.com,fmalita@chromium.org,tomhudson@google.com,bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1974783002
/external/skia/gm/mixedtextblobs.cpp
|
| 6296da736fbf40aae881650c239420f64e576c3f |
|
11-May-2016 |
bungeman <bungeman@google.com> |
Move SkTypeface to sk_sp.
Review-Url: https://codereview.chromium.org/1933393002
/external/skia/gm/mixedtextblobs.cpp
|
| 385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
/external/skia/gm/mixedtextblobs.cpp
|
| 20dac8856594aa633c8c7562304c865864f666ff |
|
24-Jul-2015 |
joshualitt <joshualitt@chromium.org> |
mixed text blobs really draws LCD
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1261483002
/external/skia/gm/mixedtextblobs.cpp
|
| 1818acb6a4b11cd9a1d44ce5dde77452502a9796 |
|
24-Jul-2015 |
caryclark <caryclark@google.com> |
rename portable_typeface_always to portable_typeface
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1257773002
/external/skia/gm/mixedtextblobs.cpp
|
| 3b0f98ee17e02aae4e1e1e9fa65d3c56104dd9c7 |
|
23-Jul-2015 |
caryclark <caryclark@google.com> |
fix typeface leak
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/1239303003
/external/skia/gm/mixedtextblobs.cpp
|
| e59524dff5421309a80ecdad6993032b991aae38 |
|
21-Jul-2015 |
caryclark <caryclark@google.com> |
make mixedtextblobs gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1250753004
/external/skia/gm/mixedtextblobs.cpp
|
| c3dcb67f07173af1c17771965ab7254910d52ef3 |
|
21-Jul-2015 |
caryclark <caryclark@google.com> |
make color emoji gm portable
R=bungeman@google.com
Review URL: https://codereview.chromium.org/1248703004
/external/skia/gm/mixedtextblobs.cpp
|
| 34d7288b19920bfb98a6eb280a906840aac51879 |
|
22-Jun-2015 |
jvanverth <jvanverth@google.com> |
Change large glyph check back to > threshold.
Using >= misses some Chromium test cases that are still
being rendered as paths.
BUG=chromium:467569
Review URL: https://codereview.chromium.org/1202433002
/external/skia/gm/mixedtextblobs.cpp
|
| 3ffa126066542590dc7430514a1174e49191b875 |
|
30-Apr-2015 |
bungeman <bungeman@google.com> |
Move resource fonts to common location.
Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/1120823002
/external/skia/gm/mixedtextblobs.cpp
|
| 9e36c1a9306f052331550dab4728b9875127bfb5 |
|
14-Apr-2015 |
joshualitt <joshualitt@chromium.org> |
Start canonicalizing color for all A8 textblobs
BUG=skia:
Review URL: https://codereview.chromium.org/1076593002
/external/skia/gm/mixedtextblobs.cpp
|
| eef5b3eb12d5aaf55f43762110af250c79cb0a45 |
|
03-Apr-2015 |
joshualitt <joshualitt@chromium.org> |
BUG=skia:
Review URL: https://codereview.chromium.org/1031423002
/external/skia/gm/mixedtextblobs.cpp
|