| 2b46f3eff9cebe900080a1c56d2d542df7377a27 |
|
02-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
Revert "Use inline storage for SkEdgeBuilder."
This reverts commit be32a432af7aab06ab1457cec35789da85b40bbe.
Reason for revert: Google3 stacks are smaller than you might hope. "the frame size of 25584 bytes is larger than 16384 bytes; see http://go/big_stack_frame"
Original change's description:
> Use inline storage for SkEdgeBuilder.
>
> Change-Id: I06d9ee759a366d6c2c11341e15e671f5a1f87ae7
> Reviewed-on: https://skia-review.googlesource.com/9164
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
>
TBR=herb@google.com,liyuqian@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I496e37754977c598f3cf30c7a0fbc4954a58152c
Reviewed-on: https://skia-review.googlesource.com/9181
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkEdgeBuilder.cpp
|
| be32a432af7aab06ab1457cec35789da85b40bbe |
|
02-Mar-2017 |
Herb Derby <herb@google.com> |
Use inline storage for SkEdgeBuilder.
Change-Id: I06d9ee759a366d6c2c11341e15e671f5a1f87ae7
Reviewed-on: https://skia-review.googlesource.com/9164
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 4b1b04d8ecb3dd8c67d9e1724e7a1898a51dbf32 |
|
01-Mar-2017 |
Herb Derby <herb@google.com> |
Use SkArenaAlloc in SkEdgeBuilder.
Change-Id: Ie3557469d018b857dc6fb4543d367fcd8768f0b7
Reviewed-on: https://skia-review.googlesource.com/9115
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 5baafa8ff1b7e2fa0bd0c3d3733f47656fcc6277 |
|
26-Jan-2017 |
Mike Reed <reed@google.com> |
extend clipper for lines, for uniformity, and so curves can call itself with lines
BUG=skia:
Change-Id: Id8c1fba6fcd2496802d3d17afe3f5c91bf5dfc33
Reviewed-on: https://skia-review.googlesource.com/7621
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 451ceba3544fa1ff810378f1e9a47c7d20f48a9f |
|
07-Nov-2016 |
liyuqian <liyuqian@google.com> |
Combine analytic edges with tolerance
If not, we sometimes would end up with only one edge for a convex path. That
either triggers SkASSERT(count >= 2) failure in debug build or SIGSEGV in
release build. After the change, we should return 0 edges for such a path
because everything is totally combined.
Note that this change also makes the SkAnalyticEdge's CombineVertical function
behave more similarly to SkEdge's CombineVertical function: SkEdge only
compares fFirstY and fLastY which are integer values, which is equivalent to
setting our tolerance to SK_Fixed1 (our current tolerance is 0x100, 1/256 of
SK_Fixed1). And this is intentional.
BUG=chrome:662914
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477373002
Review-Url: https://codereview.chromium.org/2477373002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 38911a7cb53474575e1cd1cb545902b50ee00889 |
|
04-Oct-2016 |
liyuqian <liyuqian@google.com> |
Resubmit issue 2221103002 to fix the iOS build by declaring the flag in
SkCommonFlags.h
TBR=reed@google.com,caryclark@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393643002
Review-Url: https://codereview.chromium.org/2393643002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| d36baa7a4a5ae3cc94cc4a45379f55658f80c0a6 |
|
04-Oct-2016 |
stephana <stephana@google.com> |
Revert of Analytic AntiAlias for Convex Shapes (patchset #14 id:260001 of https://codereview.chromium.org/2221103002/ )
Reason for revert:
Breaks iOS build.
Original issue's description:
> Implement AnalyticAA for convex shapes.
>
> Design doc: go/analyticAA
>
> A performance test can be found here: https://docs.google.com/a/google.com/spreadsheets/d/1n9LSjFzrQzx0hovFddWey0GSMXNRjl1oFuSypMlHWZk/edit?usp=sharing
>
> Our best case is filling big triangles, which according to our experiment has ~2.9x speedup. Our worst case is filling small ovals/circles, which has a ~1.06x slowdown.
>
> To see how our new algorithm changes the DM images, see: https://x20web.corp.google.com/~liyuqian/dmdiff/index.html
> The most significant changes are in convexpaths and analytic_antialias_convex
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221103002
>
> Committed: https://skia.googlesource.com/skia/+/7795822807478143120c33228b68d2ab3918af2c
TBR=reed@google.com,caryclark@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2388213003
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 7795822807478143120c33228b68d2ab3918af2c |
|
04-Oct-2016 |
liyuqian <liyuqian@google.com> |
Implement AnalyticAA for convex shapes.
Design doc: go/analyticAA
A performance test can be found here: https://docs.google.com/a/google.com/spreadsheets/d/1n9LSjFzrQzx0hovFddWey0GSMXNRjl1oFuSypMlHWZk/edit?usp=sharing
Our best case is filling big triangles, which according to our experiment has ~2.9x speedup. Our worst case is filling small ovals/circles, which has a ~1.06x slowdown.
To see how our new algorithm changes the DM images, see: https://x20web.corp.google.com/~liyuqian/dmdiff/index.html
The most significant changes are in convexpaths and analytic_antialias_convex
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221103002
Review-Url: https://codereview.chromium.org/2221103002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002
Review URL: https://codereview.chromium.org/1842753002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| a7b16858d51b5d9b7981087cadb1ff764632bf14 |
|
18-Feb-2016 |
caryclark <caryclark@google.com> |
remove legacy flags
R=fmalita@chromium.org
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707383002
Review URL: https://codereview.chromium.org/1707383002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| afd25f703d9bbc9cd80b03b63b30abd14db4911d |
|
30-Jan-2016 |
caryclark <caryclark@google.com> |
combine vertical overlapping edges
Paths outside clips, and sometimes paths inside clips, devolve
to multiple adjacent or overlapping vertical edges. Combine
these edges when possible to reduce the overall edge count.
R=reed@google.com
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1654433002
Review URL: https://codereview.chromium.org/1654433002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| e053ca4380713a5b9e6a31119a1bdd6d529208aa |
|
19-Mar-2015 |
reed <reed@chromium.org> |
remove unused clip parameter to SkEdge::setClip
BUG=skia:
Review URL: https://codereview.chromium.org/1019183002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 31223e0cb74f47f63b094520a9830c525b72fe87 |
|
09-Feb-2015 |
reed <reed@google.com> |
cull edges that are to the right of the clip
BUG=skia:
Review URL: https://codereview.chromium.org/913503002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 01d3319b67b1ad404006a0026803efc1573f4570 |
|
07-Feb-2015 |
reed <reed@google.com> |
Faster edge re-sort
For now, disable dropping trailing edges
This reverts commit 0692c5f2c1df7d1b66c62025200dd666f9ecd311.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/882733004
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 0692c5f2c1df7d1b66c62025200dd666f9ecd311 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Revert of Faster edge re-sort, drop trailing edges (patchset #2 id:20001 of https://codereview.chromium.org/907623002/)
Reason for revert:
still layout failures
Original issue's description:
> Faster edge re-sort, drop trailing edges
>
> (patchset #4 id:60001 of https://codereview.chromium.org/891613003/)"
>
> This reverts commit c319d075eab86cacfd7aba27859b72bbf8fc0a64.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2322115952c15c72a623837879cac1f85894b1b6
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/886503010
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 2322115952c15c72a623837879cac1f85894b1b6 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Faster edge re-sort, drop trailing edges
(patchset #4 id:60001 of https://codereview.chromium.org/891613003/)"
This reverts commit c319d075eab86cacfd7aba27859b72bbf8fc0a64.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/907623002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| c319d075eab86cacfd7aba27859b72bbf8fc0a64 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Revert of faster edge re-sort, drop trailing edges (patchset #4 id:60001 of https://codereview.chromium.org/891613003/)
Reason for revert:
may be breaking layouttests...
Original issue's description:
> faster edge re-sort, drop trailing edges
>
> 1. drop edges that are wholly on the right (in the non-convex walker)
> 2. scan and swap once, instead of swapping as we go during re-sort
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/38f1c00772539dcbeccbfa3c45d94bdc4acf3518
TBR=caryclark@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/910493002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 38f1c00772539dcbeccbfa3c45d94bdc4acf3518 |
|
06-Feb-2015 |
reed <reed@google.com> |
faster edge re-sort, drop trailing edges
1. drop edges that are wholly on the right (in the non-convex walker)
2. scan and swap once, instead of swapping as we go during re-sort
BUG=skia:
Review URL: https://codereview.chromium.org/891613003
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 3f4e045b4f8b97d189162d17c85b8410e083a3af |
|
06-Jan-2015 |
reed <reed@google.com> |
fixes for conics
- use std tolerance in edgebuilder, since the path has not been scaled-up to its super-sample size (that happens in the builder methods.
- off-by-1 fix for pathops when using the output of the conicquadder
BUG=skia:
Review URL: https://codereview.chromium.org/837023002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 220f926d9d4b38a9018c922c095847bbd261f583 |
|
17-Dec-2014 |
reed <reed@google.com> |
use conics
BUG=skia:
Review URL: https://codereview.chromium.org/455043002
/external/skia/src/core/SkEdgeBuilder.cpp
|
| a8c7f7702fb4bbedb615031bc653c5cd161a038e |
|
24-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix (some) 64bit warnings -- size_t -> int
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/147053003
git-svn-id: http://skia.googlecode.com/svn/trunk@13178 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 01efe139af523702361bd917a1e33a6af3f014b6 |
|
12-Jun-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove leftover printf
git-svn-id: http://skia.googlecode.com/svn/trunk@9552 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 26da7f00aedba107d4b3e382283034e265db09b6 |
|
01-Jun-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9387 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 277c3f87656c44e0a651ed0dd56efa16c0ab07b4 |
|
31-May-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bump picture version since SkPath has changed (conics)
enable conics in SkPath
git-svn-id: http://skia.googlecode.com/svn/trunk@9370 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| fa2f2a48f6822b88ab895fece1998af549c16ebe |
|
30-May-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "add asserts to point<-->verb helpers"
This reverts commit b4775ac7b55802e87231768f002e4b42f233b0aa.
git-svn-id: http://skia.googlecode.com/svn/trunk@9347 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 7950a9eba71f65365d88021680a16f245ad3fa68 |
|
30-May-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add asserts to point<-->verb helpers
patch from issue 16153005
BUG=
Review URL: https://codereview.chromium.org/16195004
git-svn-id: http://skia.googlecode.com/svn/trunk@9344 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| e16efc1882ab34a0bb3ae361a2d37f840044cf87 |
|
26-Jan-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 |
|
23-Aug-2012 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/)
This CL is part I of IV (I broke down the 1280 files into 4 CLs).
Review URL: https://codereview.appspot.com/6485054
git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| b6a2ba7b483a164a59ec0ded0795590329eab923 |
|
02-Aug-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
create inline version of setLine that assumes no clip. 10% faster for dashing gms
Review URL: https://codereview.appspot.com/6455078
git-svn-id: http://skia.googlecode.com/svn/trunk@4920 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| c8d640b1788822a8697816b645c327383a1d1f20 |
|
02-Aug-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
special-case edge-building for polygons (paths with only lines)
makes the dashing bench faster (from 13.4 -> 11.5 ticks)
Review URL: https://codereview.appspot.com/6449080
git-svn-id: http://skia.googlecode.com/svn/trunk@4916 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 4a3b714d73e585a3985d614600c6b79d5c8b1f1e |
|
16-May-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Iter::next takes a bool (defaults to true for now) if we want to consume degenerates.
path-filling and stroking pass false, as they already are written to handle
small segments (and it makes next() run 2x faster if you pass false).
Review URL: https://codereview.appspot.com/6214049
git-svn-id: http://skia.googlecode.com/svn/trunk@3974 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 0c00f21fee3f5cfa3aa7e5d46ff94cb8cf340451 |
|
28-Dec-2011 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkDEBUGFAIL to clean up use of SkASSERT(!"text");
catch a couple of latent SkASSERT("text") bugs.
http://codereview.appspot.com/5504090/
git-svn-id: http://skia.googlecode.com/svn/trunk@2926 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e |
|
28-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Automatic update of all copyright notices to reflect new license terms.
I have manually examined all of these diffs and restored a few files that
seem to require manual adjustment.
The following files still need to be modified manually, in a separate CL:
android_sample/SampleApp/AndroidManifest.xml
android_sample/SampleApp/res/layout/layout.xml
android_sample/SampleApp/res/menu/sample.xml
android_sample/SampleApp/res/values/strings.xml
android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java
android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java
experimental/CiCarbonSampleMain.c
experimental/CocoaDebugger/main.m
experimental/FileReaderApp/main.m
experimental/SimpleCocoaApp/main.m
experimental/iOSSampleApp/Shared/SkAlertPrompt.h
experimental/iOSSampleApp/Shared/SkAlertPrompt.m
experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig
experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig
experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig
gpu/src/android/GrGLDefaultInterface_android.cpp
gyp/common.gypi
gyp_skia
include/ports/SkHarfBuzzFont.h
include/views/SkOSWindow_wxwidgets.h
make.bat
make.py
src/opts/memset.arm.S
src/opts/memset16_neon.S
src/opts/memset32_neon.S
src/opts/opts_check_arm.cpp
src/ports/SkDebug_brew.cpp
src/ports/SkMemory_brew.cpp
src/ports/SkOSFile_brew.cpp
src/ports/SkXMLParser_empty.cpp
src/utils/ios/SkImageDecoder_iOS.mm
src/utils/ios/SkOSFile_iOS.mm
src/utils/ios/SkStream_NSData.mm
tests/FillPathTest.cpp
Review URL: http://codereview.appspot.com/4816058
git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|
| 909994fbae0ffb532f42feac8859f8d86bbf64de |
|
18-Nov-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
new scanconversion technique
This technique geometrically clips all segments against the clip bounds,
ensuring that we never send a value to the edgelist that might overflow in
fixedpoint.
Current disabled in SkScan_Path.cpp by a #define. There are a few minor pixel
differences between this and the old technique, as found by the gm tool, so
at the moment this new code is off by default.
git-svn-id: http://skia.googlecode.com/svn/trunk@432 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkEdgeBuilder.cpp
|