History log of /external/skia/src/core/SkImageGenerator.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
4447b64a88ea141161fca772c2fec28b6141bbc3 03-Mar-2017 Robert Phillips <robertphillips@google.com> Switch SkImageGenerator over to generating GrTextureProxies

It does not seem irrational for generateTexture to always receive a valid GrContext. lockAsBitmap can do as it pleases.

This is split out of: https://skia-review.googlesource.com/c/8823/ (Remove GrFragmentProcessor-derived class' GrTexture-based ctors)

Change-Id: I8aebc813a8a3a7d694b7369c2c9810e2164fe16e
Reviewed-on: https://skia-review.googlesource.com/9191
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkImageGenerator.cpp
22eb2f1aa09b0fb27c199c2cc96cd74b2098d502 22-Feb-2017 Mike Reed <reed@google.com> remove guard for SkImageGenerator api

BUG=skia:

Change-Id: I0c01fbf935be5d933aa2ef67a0fb2edba4941fa7
Reviewed-on: https://skia-review.googlesource.com/8835
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkImageGenerator.cpp
185130c643f0f6b20dcf14c200074748be282a7e 15-Feb-2017 Mike Reed <reed@google.com> return and take SkImageGenerator as unique_ptr

BUG=skia:

Change-Id: I4bc11042dd1dbf1eabd40af206027bc65acc3186
Reviewed-on: https://skia-review.googlesource.com/8444
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkImageGenerator.cpp
26e573c7ef17b96bb91c1e8dec86ca14efa6d0fb 15-Feb-2017 Mike Reed <reed@google.com> removed unused code around scaled generators

BUG=skia:

Change-Id: I9e042cd9343e0f29032f84ee17b4b316214ec693
Reviewed-on: https://skia-review.googlesource.com/8403
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkImageGenerator.cpp
5cbc7b913b16adf5d153ccb5febfd53369c653f3 17-Dec-2016 Mike Reed <reed@google.com> simplify generatescaledpixels

BUG=skia:

Change-Id: Ia1f975d8ca088a552258fd70d3333683a88bbb5f
Reviewed-on: https://skia-review.googlesource.com/6234
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkImageGenerator.cpp
d85dd53e288ed5d979e5393085ab894187383a09 15-Dec-2016 Brian Osman <brianosman@google.com> Shrink the SkImageGenerator API

generateBitmap was used in one test, so it's easily converted to
tryGenerateBitmap. Then, all calls to tryGenerateBitmap supplied
an image info, so we don't need it to be optional.

BUG=skia:

Change-Id: I19e8f9da7e442a2d37af68b029b5ec85228766f7
Reviewed-on: https://skia-review.googlesource.com/6149
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkImageGenerator.cpp
222e9ad98be456c1aa5ef7be38a7ea11a3e3a7f1 14-Dec-2016 Brian Osman <brianosman@google.com> Make picture backed images sRGB by default

This adds support for playing back a picture image in a different
color space. This is currently limited to just the original space
(sRGB) or legacy mode. I think the best next step is to make them
fully flexible (playing back in the destination surface's space),
but that's going to involve changes to caching logic. I'd like to
keep that separate.

BUG=skia:

Change-Id: I15e6d44e977328b06a4da008ff7b2ed88d851a0b
Reviewed-on: https://skia-review.googlesource.com/5777
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkImageGenerator.cpp
c87f99ef0649a525471971c4edd8b57fc0f7ef3c 09-Dec-2016 Brian Osman <brianosman@google.com> Make subset param to texture generation API non-optional

We were always already supplying this, makes it simpler

BUG=skia:

Change-Id: I36ac35205df5ab2a0fb7ec26e83ddb1547154816
Reviewed-on: https://skia-review.googlesource.com/5778
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkImageGenerator.cpp
df8599ac246515b4e7ea8ed0285e4b416b8bc570 08-Dec-2016 Mike Reed <reed@google.com> remove SK_SUPPORT_LEGACY_REFENCODEDDATA_NOCTX flag

BUG=skia:

Change-Id: I51b7778db8b596b2633b6be9488af984cee2af70
Reviewed-on: https://skia-review.googlesource.com/5713
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkImageGenerator.cpp
ca79535dcb36ab3691eadc8664b687f4cd8a56b5 16-Nov-2016 Florin Malita <fmalita@chromium.org> External SkImageGenerator API

Introduce an SkImageGenerator API to support the implementation of
externally-managed image decode and scale caches.

BUG=skia:5806
R=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4720

Change-Id: Ibfe37af5471f78f28f88f9d5e80938882be1a344
Reviewed-on: https://skia-review.googlesource.com/4720
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkImageGenerator.cpp
704cd32e4a92d6c3eae6bfae4adcc20126bf4437 07-Nov-2016 Hal Canary <halcanary@google.com> src/core: s/SkAutoTUnref/sk_sp/g

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4492

Change-Id: I753ad01b03e891221965252e3befe280d09cdb9f
Reviewed-on: https://skia-review.googlesource.com/4492
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkImageGenerator.cpp
95167758572eca33008dce3e8bebe2a7656a06c9 02-May-2016 aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com> Enable generating SkImage with the same uniqueID in SkImageGenerator subclass

Enable reusing uniqueID when instantiating SkImageGenerator subclasses enables
using uniqueID in client code to cache generated bitmaps with no need to keep
the reference to SkImageGenerator.

This is a bug fix for out of memory cause in chromium and 100% CPU usage
described in issue 165750#13:
- cache uses SkImage::uniqueID() to cache decoded bitmaps.
- every animation loop creates new SkImage instances.
- after decoding, bitmap copies are added to cache, filling it up with
duplicates of previous loops frames.

BUG=165750

Blink patch that depends on this:
https://codereview.chromium.org/1925533003/
"High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations."

Review-Url: https://codereview.chromium.org/1928403002
/external/skia/src/core/SkImageGenerator.cpp
4984c3c95f18eda44492a2126c9958e447f2cca8 10-Mar-2016 msarett <msarett@google.com> Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002

Committed: https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

Review URL: https://codereview.chromium.org/1716523002
/external/skia/src/core/SkImageGenerator.cpp
1590f3b32890f6455b30494308633177b54db347 07-Mar-2016 msarett <msarett@google.com> Revert of Update Skia's YUV API (patchset #5 id:160001 of https://codereview.chromium.org/1716523002/ )

Reason for revert:
Blimp failures with manual roll in Chrome.

Original issue's description:
> Update Skia's YUV API
>
> We should match the recently designed API in SkCodec.
> https://codereview.chromium.org/1549473003/
>
> This requires changes in Chromium as well.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002
>
> Committed: https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

TBR=scroggo@google.com,reed@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1775493002
/external/skia/src/core/SkImageGenerator.cpp
095d31c8a0eeb5d491febf064bc3c8a44e22b94f 07-Mar-2016 msarett <msarett@google.com> Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002

Review URL: https://codereview.chromium.org/1716523002
/external/skia/src/core/SkImageGenerator.cpp
05dd251e5e135626d170b9e77eb64729bd482169 05-Jan-2016 reed <reed@google.com> take gr-context parameter to refEncoded, indicating a desire for only gpu-specific formats

Prime motivator:
- we always call refEncoded on the generator when trying to upload
- we call it *before* we ask for raster or YUV
- for blink, this call can be very slow, as they have to cons-up their SkData the first time (and grab a mutex to do it)
- this parameter will indicate to them that we're only interested in gpu formats, which they will know if they have.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556333004

Review URL: https://codereview.chromium.org/1556333004
/external/skia/src/core/SkImageGenerator.cpp
7850eb2f357c215b2e2c50bf16d6c6df38c7967f 02-Dec-2015 reed <reed@google.com> API to support native scaling by image-generator

BUG=skia:

Review URL: https://codereview.chromium.org/1396323007
/external/skia/src/core/SkImageGenerator.cpp
6950de6c4166fabb35e6c756fc009e0cf1c47819 07-Nov-2015 halcanary <halcanary@google.com> Comments Style: s/skbug.com/bug.skia.org/
DOCS_PREVIEW= https://skia.org/?cl=1432503003

Review URL: https://codereview.chromium.org/1432503003
/external/skia/src/core/SkImageGenerator.cpp
5f5527fb46664297fbeb575033886a757eb44147 15-Oct-2015 bsalomon <bsalomon@google.com> Remove params from Cacherator_GrTextureMaker

Review URL: https://codereview.chromium.org/1403313003
/external/skia/src/core/SkImageGenerator.cpp
afa95e270c64c9777647b6c58b796750ced57c39 12-Oct-2015 bsalomon <bsalomon@google.com> Remove image usage type enum. Use GrTextureParams instead.

BUG=skia:

Review URL: https://codereview.chromium.org/1404433002
/external/skia/src/core/SkImageGenerator.cpp
4b3d3bebda80be611ea79ec63a92d632c0375f20 17-Sep-2015 reed <reed@google.com> use allocator (if present) when we allocate our cache bitmap

Remove some bogus tests on the cache, as they are not thread-reliable. Running w/ discardable these are racy.

BUG=532981

Review URL: https://codereview.chromium.org/1351453004
/external/skia/src/core/SkImageGenerator.cpp
4d5b67637bf79dceff23d3ba95ee7ff6f1e77966 13-Sep-2015 reed <reed@chromium.org> formalize generate->bitmap

just move block of code to expose it

BUG=skia:4328
TBR=

Review URL: https://codereview.chromium.org/1334033004
/external/skia/src/core/SkImageGenerator.cpp
96fcdcc219d2a0d3579719b84b28bede76efba64 27-Aug-2015 halcanary <halcanary@google.com> Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkImageGenerator.cpp
935d6cfaa78b6be75c9fcc596805f0f9b8da972e 18-Aug-2015 reed <reed@google.com> Add subsets to SkImageGenerator and SkImageCacherator
... to support subsets in SkImage!

BUG=skia:

Review URL: https://codereview.chromium.org/1301633002
/external/skia/src/core/SkImageGenerator.cpp
8f34372f7e97482e5e61ab298b7edaa008ba2f4c 13-Aug-2015 reed <reed@google.com> Extend SkImageGenerator to support natively generated GrTextures. As part of this, added uniqueID() to the generator, and made it be in the same namespace is bitmaps, pixelrefs, images.

To do this, create SkImageCacherator, which wraps a generator and provides an
interface to get a cached answer for either the raster or texture output of
the generator.

BUG=skia:

Review URL: https://codereview.chromium.org/1291803002
/external/skia/src/core/SkImageGenerator.cpp
ef004e1b49ce6ad488ea4444c0eb896ef37c1242 30-Jul-2015 scroggo <scroggo@chromium.org> Remove SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS

Now that Chrome no longer depends on it, remove dead code.

Review URL: https://codereview.chromium.org/1263013002
/external/skia/src/core/SkImageGenerator.cpp
d7c05bfd7c81a835a78b4163026a4dfa573faa89 09-Jul-2015 reed <reed@google.com> remove getter for imagegenerator factory, update test

BUG=skia:

Review URL: https://codereview.chromium.org/1223413002
/external/skia/src/core/SkImageGenerator.cpp
1c84634454aa78fb26f23875b86a243aa4596c59 09-Jul-2015 reed <reed@google.com> add runtime option to provide data->imagegenerator factory

BUG=skia:

Review URL: https://codereview.chromium.org/1229933003
/external/skia/src/core/SkImageGenerator.cpp
5315fd4761a3c510dfff834a84e71e4c471951f9 09-Jul-2015 scroggo <scroggo@chromium.org> Remove SkImageGenerator pieces only for SkCodec.

Follow up to the split between SkImageGenerator and SkCodec. Now that
SkCodec does not inherit from SkImageGenerator, SkImageGenerator no
longer needs Options or Result, which were added for SkCodec. Remove
them, but keep them behind a flag, since Chromium has its own
subclasses of SkImageGenerator which assume the old signature for
onGetPixels.

Review URL: https://codereview.chromium.org/1226023003
/external/skia/src/core/SkImageGenerator.cpp
e582a5a89102dde5c5bda4654cb07eca1da8efcd 23-Jun-2015 reed <reed@google.com> remove SK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS

BUG=skia:

Review URL: https://codereview.chromium.org/1201233002
/external/skia/src/core/SkImageGenerator.cpp
d1290843c364dda7691817f3bb52aadee8391acf 05-May-2015 reed <reed@google.com> remove dead code behind BOOL_ONGETINFO

need this to land in chrome first https://codereview.chromium.org/1125573002

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1123473004
/external/skia/src/core/SkImageGenerator.cpp
2fcbcea3a402411e7cfa46dfface41687f3f6437 20-Mar-2015 reed <reed@chromium.org> change default impl to facilitate transition in blink/chrome

BUG=skia:
TBR=

need deps roll to see if this works... since skia can no longer build/test in this legacy mode.

Review URL: https://codereview.chromium.org/1026923002
/external/skia/src/core/SkImageGenerator.cpp
3ef71e343bf075888fb50892350390b4dd47de24 19-Mar-2015 reed <reed@google.com> guarded change to SkImageGenerator to make getInfo() const

BUG=skia:

Review URL: https://codereview.chromium.org/1017293002
/external/skia/src/core/SkImageGenerator.cpp
9552662e9fee5eb0ef435e52ab9db505d7ebe4ad 17-Mar-2015 scroggo <scroggo@google.com> Option for SkCodec to treat dst as all zeroes.

This recreates SkImageDecoder's feature to skip writing zeroes for
SkCodec.

Review URL: https://codereview.chromium.org/980903002
/external/skia/src/core/SkImageGenerator.cpp
87fa631969e0bdbee3c0845aa2b9bf35b9b82eb0 20-Feb-2015 scroggo <scroggo@google.com> Rename onGetPixelsEnum back to onGetPixels.

Replace the old signature of onGetPixels (return bool) to return an
enum (Result). Remove onGetPixelsEnum.

Add a define for onGetPixelsEnum to onGetPixels. This is for staging
in Chromium, where some implementations override onGetPixelsEnum.

Add the define in skia_for_chromium_defines. Remove
SK_SUPPORT_LEGACY_IMAGE_GENERATOR_RETURN, which is no longer needed by
Chromium.

BUG=skia:3257

Review URL: https://codereview.chromium.org/939113002
/external/skia/src/core/SkImageGenerator.cpp
efe513b6fea7196dc72c1d49b365c5c28e939012 13-Feb-2015 scroggo <scroggo@google.com> Fix conversion from enum to bool error.

Needed for the DEPS roll.

TBR=jvanverth@google.com

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/921293002
/external/skia/src/core/SkImageGenerator.cpp
0864908ca50049d3d907fc5c3749bc8a436b4738 13-Feb-2015 scroggo <scroggo@google.com> Make SkImageGenerator::getPixels() return an enum.

The new enum describes the nature of the failure. This is in
preparation for writing a replacement for SkImageDecoder, which will
use this interface.

Update the comments for getPixels() to specify what it means to pass
an SkImageInfo with a different size.

Make SkImageGenerator Noncopyable.

Leave onGetYUV8Planes alone, since we have separate discussions
regarding modifying that API.

Make callers of SkImageDecoder consistently handle kPartialSuccess.
Previously, some callers considered it a failure, and others considered
it a success.

BUG=skia:3257

Review URL: https://codereview.chromium.org/919693002
/external/skia/src/core/SkImageGenerator.cpp
7874dc8e717036f97f14f87daa9431d6f611e467 30-Sep-2014 reed <reed@chromium.org> remove obsolete code for SK_SUPPORT_LEGACY_IMAGEGENERATORAPI

BUG=skia:
R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/613933002
/external/skia/src/core/SkImageGenerator.cpp
abaef86f2b37d8a939506a2076da07f6db456951 13-Sep-2014 rileya <rileya@chromium.org> Add support for the Rec601 YUV color space to GrYUVtoRGBEffect.

R=bsalomon@google.com, senorblanco@chromium.org, sugoi@chromium.org, reed@google.com

Author: rileya@chromium.org

Review URL: https://codereview.chromium.org/516463005
/external/skia/src/core/SkImageGenerator.cpp
49f085dddff10473b6ebf832a974288300224e60 05-Sep-2014 bsalomon <bsalomon@google.com> "NULL !=" = NULL

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/544233002
/external/skia/src/core/SkImageGenerator.cpp
518d83dbc1c899e316e8c896af5defb58b83120f 21-Jul-2014 sugoi <sugoi@chromium.org> Skia side RGB to YUV gpu conversion

This code is the one that's currently working in my local chromium build. A few things still need to be addressed and I'll highlight these directly in the code.

BUG=skia:
R=reed@google.com, bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com, halcanary@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/374743003
/external/skia/src/core/SkImageGenerator.cpp
5744bbee6fa65f9d532587b6539fa0f104dda98b 29-May-2014 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> move SkImageGenerator.cpp from src/images to src/core

git-svn-id: http://skia.googlecode.com/svn/trunk@14973 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkImageGenerator.cpp