| 3b65598bceb65736486db27ed49a56d787032747 |
|
07-Mar-2017 |
Brian Osman <brianosman@google.com> |
Make SkGr.h private and remove unused functions
BUG=skia:
Change-Id: I6699d00c5412ed9d9bf14b032a08b06b1c766bce
Reviewed-on: https://skia-review.googlesource.com/9398
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| cb30bb2cb727e276792812c6390547dba474c831 |
|
12-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Remove GrFragmentProcessor::computeInvariantOutput
Change-Id: If475730103052c6097eb91be06808fb723b70bf8
Reviewed-on: https://skia-review.googlesource.com/8330
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 83e939bcb79790f5ae3b28c398fbcf034675a6e5 |
|
07-Feb-2017 |
Herb Derby <herb@google.com> |
Use SkArenaAlloc in the SkAutoBlitterChoose code.
- Added default implementation of onMakeContext to support use in android.
Searches for uses:
"public SkShader" package:^chromium$ -file:^src/third_party/skia
package:^aosp.* "public SkShader" -file:external/skia -file:.*third_party/skia
package:^android$ "public SkShader" -file:external/skia -file:.*third_party/skia
... shows that no subclass overrides onCreateContext.
TBR=reed@google.com
TBR=mtklein@google.com
Change-Id: I8bd5f57a79534574e344b165d31dccee41c31767
Reviewed-on: https://skia-review.googlesource.com/8140
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| dd8b72ae7319598cfc1024901e860c52f06e6ae1 |
|
07-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code."
This reverts commit 2b57b7f7a7fc97db57f190b5a8ebcf68e177ee2d.
Reason for revert: Android compile failing
Original change's description:
> Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code.
>
>
> TBR=reed@google.com
> Change-Id: Iefb044bf7657fbf982f23aa91a3f4d013ce2c626
> Reviewed-on: https://skia-review.googlesource.com/7786
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
>
TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Id09c35377dddae0811d998b7d0c34c422325a5bc
Reviewed-on: https://skia-review.googlesource.com/8129
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 2b57b7f7a7fc97db57f190b5a8ebcf68e177ee2d |
|
06-Feb-2017 |
Herb Derby <herb@google.com> |
Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code.
TBR=reed@google.com
Change-Id: Iefb044bf7657fbf982f23aa91a3f4d013ce2c626
Reviewed-on: https://skia-review.googlesource.com/7786
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 587e08f361ee3e775a6bbc6dca761dbba82e422c |
|
27-Jan-2017 |
Brian Salomon <bsalomon@google.com> |
Revert "Revert "Start of rewrite of GrFragmentProcessor optimizations.""
This reverts commit 052fd5158f7f85e478a9f87c45fecaacf7d0f5f3.
Disables the test (of unused code) until platform-specific issues are addressed.
Change-Id: I7aa23a07954fccf382aa07d28afcbffb0bebcd6d
Reviewed-on: https://skia-review.googlesource.com/7656
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 052fd5158f7f85e478a9f87c45fecaacf7d0f5f3 |
|
27-Jan-2017 |
Ethan Nicholas <ethannicholas@google.com> |
Revert "Start of rewrite of GrFragmentProcessor optimizations."
This reverts commit 85eb4226a4cd8c10a0e3f3ba2f3a60efbb2dd61b.
Reason for revert: test failures on Windows, e.g. https://chromium-swarm.appspot.com/task?id=33f9527484414110&refresh=10
Original change's description:
> Start of rewrite of GrFragmentProcessor optimizations.
>
> This adds a replacement for computeInvariantOutput buts does not use it yet. The replacement allows for three types of optimizations:
>
> * known input color -> known output color for GrFP elimination
> * tracking of whether all color processors modulate their input for the "tweak alpha" optimziation
> * opaqueness tracking
>
> This loses some of the generality of computInvariantOutput. It does not track the known output status of individual color components (other than opaque alpha). It does not track whether GrFragmentProcessors read their input color. It doesn't allow a processor that will receive non-constant output to advertise that it produces a constant output. These could probably be added back in the unlikely case that they prove valuable.
>
> Unlike computeInvariantOutput the optimizations are decided at instantiation time and constant colors are expressed as GrColor4f rather than GrColor.
>
> Change-Id: I684d3f9050693dde2d28154fa695e049ed8cf61a
> Reviewed-on: https://skia-review.googlesource.com/7481
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
>
TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I2390df257456013fa74137cb5d7b5a93820c291e
Reviewed-on: https://skia-review.googlesource.com/7652
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 85eb4226a4cd8c10a0e3f3ba2f3a60efbb2dd61b |
|
26-Jan-2017 |
Brian Salomon <bsalomon@google.com> |
Start of rewrite of GrFragmentProcessor optimizations.
This adds a replacement for computeInvariantOutput buts does not use it yet. The replacement allows for three types of optimizations:
* known input color -> known output color for GrFP elimination
* tracking of whether all color processors modulate their input for the "tweak alpha" optimziation
* opaqueness tracking
This loses some of the generality of computInvariantOutput. It does not track the known output status of individual color components (other than opaque alpha). It does not track whether GrFragmentProcessors read their input color. It doesn't allow a processor that will receive non-constant output to advertise that it produces a constant output. These could probably be added back in the unlikely case that they prove valuable.
Unlike computeInvariantOutput the optimizations are decided at instantiation time and constant colors are expressed as GrColor4f rather than GrColor.
Change-Id: I684d3f9050693dde2d28154fa695e049ed8cf61a
Reviewed-on: https://skia-review.googlesource.com/7481
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 94efbf51f5a88d9e8aa961d3fbe38c5e335d6108 |
|
29-Nov-2016 |
Brian Salomon <bsalomon@google.com> |
Merge GrGLSLCaps into GrShaderCaps
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5121
Change-Id: If8d13638f80f42161cbc766a2666c5789e5772c8
Reviewed-on: https://skia-review.googlesource.com/5121
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| 0bbecb21ab82b3d742c491780bcc2e74be03efed |
|
17-Nov-2016 |
Brian Salomon <bsalomon@google.com> |
Rename GrTextureAccess to GrProcessor::TextureSampler.
Renames vars and methods that used the work "access" to refer to this type.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4931
Change-Id: Ibcf488fbd445c5119fc13d190544cd98981bdbee
Reviewed-on: https://skia-review.googlesource.com/4931
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/src/core/SkLightingShader.cpp
|
| e54c75f351c775201049743c506d7a508d0fef91 |
|
13-Oct-2016 |
Mike Klein <mtklein@chromium.org> |
remove SkError
It has not caught on.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3321
Change-Id: Ib2ee4ef99bc89c8f4b7504e42a9d7d9dfc483015
Reviewed-on: https://skia-review.googlesource.com/3321
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkLightingShader.cpp
|
| a8eabc4a2a5559a1410fdbb348f967cd1554b325 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moved ambient lights out of SkLight's light array
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002
Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686
Review-Url: https://codereview.chromium.org/2287553002
/external/skia/src/core/SkLightingShader.cpp
|
| 84cddf6fa7a2ee4a8163f99c9238d5fba6b49566 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Moved ambient lights out of SkLight's light array (patchset #7 id:120001 of https://codereview.chromium.org/2287553002/ )
Reason for revert:
Made Deigo's GM miss their ambient lights
Original issue's description:
> Moved ambient lights out of SkLight's light array
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002
>
> Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686
TBR=robertphillips@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2291663002
/external/skia/src/core/SkLightingShader.cpp
|
| 8f98f0aa2d3f7571a890b916c7c4b5ee831e9686 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moved ambient lights out of SkLight's light array
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002
Review-Url: https://codereview.chromium.org/2287553002
/external/skia/src/core/SkLightingShader.cpp
|
| 6ad75d10eb2462e614f2b7cba293144a7e91a842 |
|
15-Aug-2016 |
dvonbeck <dvonbeck@google.com> |
LightingFP now supports multiple directional lights
BUG=skia:5518
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004
Review-Url: https://codereview.chromium.org/2239933004
/external/skia/src/core/SkLightingShader.cpp
|
| 772b5ee446d7545eec4ca7d6dc9d75461e2a9c38 |
|
12-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Added PointLights to SkLights::Light
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237493002
Review-Url: https://codereview.chromium.org/2237493002
/external/skia/src/core/SkLightingShader.cpp
|
| f621ff49a288978c272d5ae069a6a1c04c74642b |
|
08-Aug-2016 |
dvonbeck <dvonbeck@google.com> |
Fixed comment about SkLightingShader::Context memory handling
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225093002
Review-Url: https://codereview.chromium.org/2225093002
/external/skia/src/core/SkLightingShader.cpp
|
| 9d65bb4795d14990daf08fba5a3de9404df4b913 |
|
02-Aug-2016 |
dvonbeck <dvonbeck@google.com> |
Fixed ambient lighting calculations on SkLightingShader
BUG=skia:5520
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003
Review-Url: https://codereview.chromium.org/2202233003
/external/skia/src/core/SkLightingShader.cpp
|
| 839345d63466a4209a0985654ec033624821fd78 |
|
22-Jul-2016 |
brianosman <brianosman@google.com> |
Bundle SkShader::asFragmentProcessor arguments in a struct
The signature of this thing keeps changing (and is about to change again).
This just makes maintenance much easier.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175563003
Review-Url: https://codereview.chromium.org/2175563003
/external/skia/src/core/SkLightingShader.cpp
|
| 95302da19d8b0a3bcd9d9be0e79f486760787f09 |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
Review-Url: https://codereview.chromium.org/2146073003
/external/skia/src/core/SkLightingShader.cpp
|
| 33d325890e549c113a258248002246b46e8040b2 |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ )
Reason for revert:
Decided to re-wait for a final LGTM.
Already found a bug in variable naming to fix.
Original issue's description:
> Creating framework for drawShadowedPicture
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
>
> Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2167223002
/external/skia/src/core/SkLightingShader.cpp
|
| 0ae097d116f4332be02a135ffc99c162473dee6a |
|
21-Jul-2016 |
vjiaoblack <vjiaoblack@google.com> |
Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
Review-Url: https://codereview.chromium.org/2146073003
/external/skia/src/core/SkLightingShader.cpp
|
| c526da94e4f2dc0c8521099dad2118c5d6b8da4a |
|
20-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
SkLS now accepting nullptr for diffuse shader and normal source, now accurately handling alpha
This CL's base is the CL for taking in a diffuse shader into SkLS on the API side: https://codereview.chromium.org/2064153002
BUG=skia:5502,skia:5517
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2132113002
Review-Url: https://codereview.chromium.org/2132113002
/external/skia/src/core/SkLightingShader.cpp
|
| 6af677ff8f549751352847ceefda4538236c8a20 |
|
11-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
Changed SkLightingShader API to take in a shader as color source
This CL's base is the CL for the same modification, but in the implementation side: https://codereview.chromium.org/2062703003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002
Review-Url: https://codereview.chromium.org/2064153002
/external/skia/src/core/SkLightingShader.cpp
|
| e6347ad7459a52f42241fd5c48638725d9f11b40 |
|
10-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader
Will not run until after landing https://codereview.chromium.org/2106893003/
This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003
Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8
Review-Url: https://codereview.chromium.org/2062703003
/external/skia/src/core/SkLightingShader.cpp
|
| 0e56972e5f69f75cf098fec10687f128430c13e6 |
|
08-Jul-2016 |
rmistry <rmistry@google.com> |
Revert of Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader (patchset #11 id:200001 of https://codereview.chromium.org/2062703003/ )
Reason for revert:
Causing the Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind builder to fail.
Started failing at this build:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/1214
Snippet from build log:
==3016== Invalid read of size 4
==3016== at 0xCD1901: GrFragmentProcessor::registerChildProcessor(sk_sp<GrFragmentProcessor>) (SkTArray.h:163)
==3016== by 0xA58B47: _Z10sk_make_spI11NormalMapFPI5sk_spI19GrFragmentProcessorERK8SkMatrixEES1_IT_EDpOT0_ (SkNormalSource.cpp:84)
==3016== by 0xA582E8: NormalMapSourceImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkNormalSource.cpp:187)
==3016== by 0xA0ADB5: SkLightingShaderImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkLightingShader.cpp:268)
==3016== by 0xDA17E6: skpaint_to_grpaint_impl(GrContext*, SkPaint const&, SkMatrix const&, sk_sp<GrFragmentProcessor>*, SkXfermode::Mode*, bool, bool, GrPaint*) (SkGr.cpp:552)
==3016== by 0xDA4532: SkPaintToGrPaint(GrContext*, SkPaint const&, SkMatrix const&, bool, GrPaint*) (SkGr.cpp:668)
==3016== by 0xD99B51: SkGpuDevice::drawRect(SkDraw const&, SkRect const&, SkPaint const&) (SkGpuDevice.cpp:534)
==3016== by 0x9DDB1C: SkCanvas::onDrawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:2148)
==3016== by 0x9DBF40: SkCanvas::drawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:1919)
==3016== by 0x8D2A55: skiagm::LightingShaderGM::onDraw(SkCanvas*) (lightingshader.cpp:110)
==3016== by 0x625659: skiagm::GM::drawContent(SkCanvas*) (gm.cpp:32)
==3016== by 0x6256AD: skiagm::GM::draw(SkCanvas*) (gm.cpp:24)
==3016== by 0x61B747: DM::GMSrc::draw(SkCanvas*) const (DMSrcSink.cpp:61)
==3016== by 0x61F37B: DM::GPUSink::draw(DM::Src const&, SkBitmap*, SkWStream*, SkString*) const (DMSrcSink.cpp:1115)
==3016== by 0x619261: dm_main() (DM.cpp:1016)
==3016== by 0x619841: main (DM.cpp:1409)
==3016== Address 0xf4 is not stack'd, malloc'd or (recently) free'd
==3016==
Caught signal 11 [Segmentation fault], was running:
gpu gm lightingshader
Original issue's description:
> Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader
>
> Will not run until after landing https://codereview.chromium.org/2106893003/
>
> This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003
>
> Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8
TBR=egdaniel@google.com,robertphillips@google.com,dvonbeck@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
NOTRY=true
Review-Url: https://codereview.chromium.org/2137513002
/external/skia/src/core/SkLightingShader.cpp
|
| 3f58cd0eb8bf4499c4f179aa6111d7e005809df8 |
|
07-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader
Will not run until after landing https://codereview.chromium.org/2106893003/
This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003
Review-Url: https://codereview.chromium.org/2062703003
/external/skia/src/core/SkLightingShader.cpp
|
| 5b794fad18344e8dbb840be49d1bc66ebe754b31 |
|
06-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
API change to allow for NormalSource selection at the user level.
This CL's base is the CL for CPU handling: https://codereview.chromium.org/2050773002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2063793002
Review-Url: https://codereview.chromium.org/2063793002
/external/skia/src/core/SkLightingShader.cpp
|
| 12c4fc2579017a162668db077e8067512fd968ca |
|
27-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
SkLightingShader normal vector CPU computation refactor.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
What this CL includes:
- A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
Committed: https://skia.googlesource.com/skia/+/790a70118327a129cb6b48fabe80f4e184c1e67c
Review-Url: https://codereview.chromium.org/2050773002
/external/skia/src/core/SkLightingShader.cpp
|
| 2c80711f90a5dafe3b726bc6562b1e769702c34b |
|
27-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
Revert of Refactoring of CPU NormalMap handling out into its own class (patchset #13 id:240001 of https://codereview.chromium.org/2050773002/ )
Reason for revert:
GMs are crashing on Windows Test trybots
Original issue's description:
> SkLightingShader normal vector CPU computation refactor.
>
> The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
>
> This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
>
> What this CL includes:
>
> - A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
>
> Committed: https://skia.googlesource.com/skia/+/790a70118327a129cb6b48fabe80f4e184c1e67c
TBR=egdaniel@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2101653002
/external/skia/src/core/SkLightingShader.cpp
|
| 790a70118327a129cb6b48fabe80f4e184c1e67c |
|
27-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
SkLightingShader normal vector CPU computation refactor.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
What this CL includes:
- A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
Review-Url: https://codereview.chromium.org/2050773002
/external/skia/src/core/SkLightingShader.cpp
|
| 8811e40850ac3310c17fe8cdaffe72817a5e317d |
|
16-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
Refactoring of GPU NormalMap handling out into its own class.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
What this CL includes:
- Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP.
- Encapsulates this new fragment processor on a new class NormalMapSource.
- Created a NormalSource abstraction that will interface with SkLightingShader.
- Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002
Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da
Committed: https://skia.googlesource.com/skia/+/a7d1e2a57aef2aa4913d4380646d60bbab761318
Review-Url: https://codereview.chromium.org/2043393002
/external/skia/src/core/SkLightingShader.cpp
|
| 4132de7069b0088665af52ffea3a42b055f51b79 |
|
15-Jun-2016 |
egdaniel <egdaniel@google.com> |
Revert of Refactoring of GPU NormalMap handling out into its own class (patchset #9 id:160001 of https://codereview.chromium.org/2043393002/ )
Reason for revert:
break deps roll
Original issue's description:
> Refactoring of GPU NormalMap handling out into its own class.
>
> The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
>
> What this CL includes:
>
> - Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP.
>
> - Encapsulates this new fragment processor on a new class NormalMapSource.
>
> - Created a NormalSource abstraction that will interface with SkLightingShader.
>
> - Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002
>
> Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da
> Committed: https://skia.googlesource.com/skia/+/a7d1e2a57aef2aa4913d4380646d60bbab761318
TBR=reed@google.com,dvonbeck@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2068983005
/external/skia/src/core/SkLightingShader.cpp
|
| a7d1e2a57aef2aa4913d4380646d60bbab761318 |
|
15-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
Refactoring of GPU NormalMap handling out into its own class.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
What this CL includes:
- Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP.
- Encapsulates this new fragment processor on a new class NormalMapSource.
- Created a NormalSource abstraction that will interface with SkLightingShader.
- Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002
Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da
Review-Url: https://codereview.chromium.org/2043393002
/external/skia/src/core/SkLightingShader.cpp
|
| da743935fa0aba854a96654a474454b09e5488e8 |
|
15-Jun-2016 |
egdaniel <egdaniel@google.com> |
Revert of Refactoring of GPU NormalMap handling out into its own class (patchset #7 id:120001 of https://codereview.chromium.org/2043393002/ )
Reason for revert:
Breaking build and deps roll. Need to move include of SkBitmapProcShader in SkLightingShader.cpp from gpu include list to general list.
Original issue's description:
> Refactoring of GPU NormalMap handling out into its own class.
>
> The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
>
> What this CL includes:
>
> - Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP.
>
> - Encapsulates this new fragment processor on a new class NormalMapSource.
>
> - Created a NormalSource abstraction that will interface with SkLightingShader.
>
> - Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002
>
> Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da
TBR=reed@google.com,dvonbeck@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2062133004
/external/skia/src/core/SkLightingShader.cpp
|
| 87b0dd00cf9409c5fc990f5d0bb7c0df837f08da |
|
14-Jun-2016 |
dvonbeck <dvonbeck@google.com> |
Refactoring of GPU NormalMap handling out into its own class.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
What this CL includes:
- Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP.
- Encapsulates this new fragment processor on a new class NormalMapSource.
- Created a NormalSource abstraction that will interface with SkLightingShader.
- Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002
Review-Url: https://codereview.chromium.org/2043393002
/external/skia/src/core/SkLightingShader.cpp
|
| 6644d9353f3f0c09914385fd762e073f98d54205 |
|
10-Jun-2016 |
reed <reed@google.com> |
respect srgb gamma when building mips
Proposed policy:
- If the target is *legacy* (e.g. L32/PMColor) ignore gamma
- If the target is S32/F16 respect gamma
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029373004
Review-Url: https://codereview.chromium.org/2029373004
/external/skia/src/core/SkLightingShader.cpp
|
| 06ca8ec87cf6fab57cadd043a5ac18c4154a4129 |
|
09-Jun-2016 |
bungeman <bungeman@google.com> |
sk_sp for Ganesh.
Convert use of GrFragmentProcessor, GrGeometryProcessor, and
GrXPFactory to sk_sp. This clarifies ownership and should
reduce reference count churn by moving ownership.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041113004
Review-Url: https://codereview.chromium.org/2041113004
/external/skia/src/core/SkLightingShader.cpp
|
| 982eb7f377a0c771345276558072deb2fcea0d3e |
|
06-Jun-2016 |
brianosman <brianosman@google.com> |
Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2037413002
Review-Url: https://codereview.chromium.org/2037413002
/external/skia/src/core/SkLightingShader.cpp
|
| 862dae548a8ef40804bc9146d5c7b9f360efa960 |
|
04-Jun-2016 |
robertphillips <robertphillips@google.com> |
Add ability to rotate light direction in drawLitAtlas Sample slide
As requested by Greg.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2032263004
Review-Url: https://codereview.chromium.org/2032263004
/external/skia/src/core/SkLightingShader.cpp
|
| 71e055279336096f92d63c5c855641b4b31d6a54 |
|
31-May-2016 |
robertphillips <robertphillips@google.com> |
Make use of new SkLights class
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2026763002
Review-Url: https://codereview.chromium.org/2026763002
/external/skia/src/core/SkLightingShader.cpp
|
| 3f6f76f98b6b37d17d1492791ff0feb1b7586bd6 |
|
11-Apr-2016 |
cdalton <cdalton@nvidia.com> |
Rename EmitArgs::fSamplers to fTexSamplers
Renames fSamplers to fTexSamplers in GrProcessor EmitArgs, and renames
GrGLSLTextureSampler to GrGLSLSampler. This will allow us to add a
second array of buffer samplers.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862373003
Review URL: https://codereview.chromium.org/1862373003
/external/skia/src/core/SkLightingShader.cpp
|
| 0576aa9c0722bba358a27f80cc134ea2cd4ca2c9 |
|
08-Apr-2016 |
mtklein <mtklein@chromium.org> |
Serialize invNormRotation in SkLightingShader.
This fixes a serialize-8888 / 8888 GM mismatch.
This requires a picture bump so we know not to bother trying to read the
invNormRotation vector from older .SKPs. Any chance no one's ever made
one?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870443002
Just bumping the picture version.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1870443002
/external/skia/src/core/SkLightingShader.cpp
|
| 60c9b58b3214b0154c931656e91e39b230e987d8 |
|
03-Apr-2016 |
reed <reed@google.com> |
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002
Review URL: https://codereview.chromium.org/1855733002
/external/skia/src/core/SkLightingShader.cpp
|
| 9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002
Review URL: https://codereview.chromium.org/1842753002
/external/skia/src/core/SkLightingShader.cpp
|
| fe63045f075165b1be5d3e7fc5c710021d85f53b |
|
25-Mar-2016 |
reed <reed@google.com> |
move setshader to sk_sp, re-using SK_SUPPORT_LEGACY_CREATESHADER_PTR
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829303002
Review URL: https://codereview.chromium.org/1829303002
/external/skia/src/core/SkLightingShader.cpp
|
| a0cee5f30e9254187a6bb943e6b8a9296214c353 |
|
04-Mar-2016 |
reed <reed@google.com> |
remove align16 calls in skhader context sizes. will handle this elsewhere as needed
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768433003
TBR=
basically reverts previous CL, but keeps the create --> onCreate change
Review URL: https://codereview.chromium.org/1768433003
/external/skia/src/core/SkLightingShader.cpp
|
| 773ceda51ca120b686ba2d1aff1b6d5173143be0 |
|
04-Mar-2016 |
reed <reed@google.com> |
Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )"
This reverts commit e38bcaf24b00066e167e03a5ac63cf828914d747.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763973002
TBR=
Review URL: https://codereview.chromium.org/1763973002
/external/skia/src/core/SkLightingShader.cpp
|
| e38bcaf24b00066e167e03a5ac63cf828914d747 |
|
03-Mar-2016 |
halcanary <halcanary@google.com> |
Revert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )
Reason for revert:
Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm:
....
FYI: loaded 23439 distinct uninteresting hashes from 23439 lines
Skipping config gpu: Don't understand 'gpu'.
Skipping config msaa16: Don't understand 'msaa16'.
168400 srcs * 7 sinks + 481 tests == 1179281 tasks
0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak
565 gm xfermodes2
565 gm xfermodes
565 gm xfermodeimagefilter
565 gm xfermodes3
565 gm verylarge_picture_image
c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108:
fatal error: ""(0 == ((size) & 15))""
step returned non-zero exit code: 3
@@@STEP_FAILURE@@@
Original issue's description:
> enforce 16byte alignment in shader contexts
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004
>
> Committed: https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96
TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1759323002
/external/skia/src/core/SkLightingShader.cpp
|
| d812fb458807245daa812adb7af0733cf5b54d96 |
|
03-Mar-2016 |
reed <reed@google.com> |
enforce 16byte alignment in shader contexts
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004
Review URL: https://codereview.chromium.org/1759653004
/external/skia/src/core/SkLightingShader.cpp
|
| 05a5647efed7fcbcc5bd1efa445a6a3ab445a6c3 |
|
02-Mar-2016 |
reed <reed@google.com> |
fission bitmapprocstate
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753903002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1753903002
/external/skia/src/core/SkLightingShader.cpp
|
| 8d9f2e474ac9d175c28079357b022d31408e2fe4 |
|
22-Feb-2016 |
fmalita <fmalita@chromium.org> |
Add ContextRec param to SkShader::contextSize()
To facilitate upcoming context selection changes.
R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002
Review URL: https://codereview.chromium.org/1720933002
/external/skia/src/core/SkLightingShader.cpp
|
| 5e58ceea8569f0d90ff7e3daf5de2def50407212 |
|
11-Feb-2016 |
cdalton <cdalton@nvidia.com> |
Add GrShaderFlags enum
Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684063006
Review URL: https://codereview.chromium.org/1684063006
/external/skia/src/core/SkLightingShader.cpp
|
| 7ea439b2203855db97330b25945b87dd4b170b8b |
|
03-Dec-2015 |
egdaniel <egdaniel@google.com> |
Create GLSLUniformHandler class for gpu backend
BUG=skia:
Review URL: https://codereview.chromium.org/1490283004
/external/skia/src/core/SkLightingShader.cpp
|
| 4ca2e6034365ad280ec64473f7f1d72ebd8335e4 |
|
18-Nov-2015 |
egdaniel <egdaniel@google.com> |
Add ShaderBuilders to EmitArgs and remove gettings from ProgBuilder.
BUG=skia:
Review URL: https://codereview.chromium.org/1457543003
/external/skia/src/core/SkLightingShader.cpp
|
| 57d3b039c635945e1dc2fcbac3462ed8bfedb068 |
|
13-Nov-2015 |
egdaniel <egdaniel@google.com> |
Rename some processor functions from GL to GLSL
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1443743002
/external/skia/src/core/SkLightingShader.cpp
|
| 64c4728c70001ed074fecf5c4e083781987b12e9 |
|
13-Nov-2015 |
egdaniel <egdaniel@google.com> |
Make all GrFragmentProcessors GL independent.
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1434313002
/external/skia/src/core/SkLightingShader.cpp
|
| 2d721d33aad192cc8a7a1321504b39bdca2a57ce |
|
11-Nov-2015 |
egdaniel <egdaniel@google.com> |
Move all ShaderBuilder files to GLSL
BUG=skia:
Review URL: https://codereview.chromium.org/1438003003
/external/skia/src/core/SkLightingShader.cpp
|
| 574a4c153d8a3f42b2806848f5c23cbf55e18bbb |
|
02-Nov-2015 |
egdaniel <egdaniel@google.com> |
Move shader compiling to ProgramBuilder and various ShaderBuilder cleanups.
An additional positive of this CL is that GrGLShaderBuilder is now GL independent besides GrGLProgramBuilder
BUG=skia:
Review URL: https://codereview.chromium.org/1431433003
/external/skia/src/core/SkLightingShader.cpp
|
| 7dc4bd06fca73a97dcf3ad4a7425597160f1edfc |
|
29-Oct-2015 |
egdaniel <egdaniel@google.com> |
Remove GrGLProcessor and create GrGLSLTextureSampler class.
Part ??? of separating glsl and gl
BUG=skia:
Review URL: https://codereview.chromium.org/1425013003
/external/skia/src/core/SkLightingShader.cpp
|
| 018fb62d12d1febf121fe265da5b6117b86a6541 |
|
28-Oct-2015 |
egdaniel <egdaniel@google.com> |
Create GLSL base class for ProgramDataManager
BUG=skia:
Review URL: https://codereview.chromium.org/1428543003
/external/skia/src/core/SkLightingShader.cpp
|
| afa95e270c64c9777647b6c58b796750ced57c39 |
|
12-Oct-2015 |
bsalomon <bsalomon@google.com> |
Remove image usage type enum. Use GrTextureParams instead.
BUG=skia:
Review URL: https://codereview.chromium.org/1404433002
/external/skia/src/core/SkLightingShader.cpp
|
| f276ac5c16d39a2b877300d760041f0291bb5ec9 |
|
09-Oct-2015 |
bsalomon <bsalomon@google.com> |
Move functions from SkGr to SkGrPriv.h
Review URL: https://codereview.chromium.org/1397123002
/external/skia/src/core/SkLightingShader.cpp
|
| 4a339529612a43871d021877e58698e067d6c4cd |
|
06-Oct-2015 |
bsalomon <bsalomon@google.com> |
Bye bye processor data manager.
Review URL: https://codereview.chromium.org/1388113002
/external/skia/src/core/SkLightingShader.cpp
|
| f1b7a1d82860e106ed7d3e0e876419e65783fb84 |
|
28-Sep-2015 |
bsalomon <bsalomon@google.com> |
Make skpaint->grpaint flow work for composing draws (verts and atlas)
One side effect is that the SkShader's (or implicit shader's) fragment processor is responsible for the transition from an unpremul paint color to a premul color.
Review URL: https://codereview.chromium.org/1348583002
/external/skia/src/core/SkLightingShader.cpp
|
| 87ba62e67c9ed0c453754a5341255829075c8e22 |
|
22-Sep-2015 |
bsalomon <bsalomon@google.com> |
Replace GrExtractAlphaFragmentProcessor with DstIn compose processor
Review URL: https://codereview.chromium.org/1347943003
/external/skia/src/core/SkLightingShader.cpp
|
| 7a4d84755801db35a4d5fc231278089b228e8c57 |
|
15-Sep-2015 |
reed <reed@google.com> |
use SkBitmapProvider for shader-context
BUG=skia:
Review URL: https://codereview.chromium.org/1343123005
/external/skia/src/core/SkLightingShader.cpp
|
| c21b09eec91c9e263cb0b88467ea44e348ed4962 |
|
29-Aug-2015 |
bsalomon <bsalomon@google.com> |
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa
Review URL: https://codereview.chromium.org/1316513002
/external/skia/src/core/SkLightingShader.cpp
|
| a511e6ad1042093bea5b015c22a920313fc57c0b |
|
29-Aug-2015 |
rmistry <rmistry@google.com> |
Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (patchset #8 id:140001 of https://codereview.chromium.org/1316513002/ )
Reason for revert:
Primary suspect in failing DEPS rolls:
* https://codereview.chromium.org/1315753006
* https://codereview.chromium.org/1308323006
* https://codereview.chromium.org/1320903004
Primary suspect because the failing win bots did not fail in https://codereview.chromium.org/1315753005
Original issue's description:
> Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
>
> Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa
TBR=joshualitt@google.com,wangyix@google.com,robertphillips@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1313573005
/external/skia/src/core/SkLightingShader.cpp
|
| ecfdc251be71f3d634e76afdd6375bf55fc061aa |
|
28-Aug-2015 |
bsalomon <bsalomon@google.com> |
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
Review URL: https://codereview.chromium.org/1316513002
/external/skia/src/core/SkLightingShader.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkLightingShader.cpp
|
| 385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
/external/skia/src/core/SkLightingShader.cpp
|
| 6ec8b7cee7a8016ee8871faab58424ea7786c879 |
|
25-Aug-2015 |
robertphillips <robertphillips@google.com> |
Speculative valgrind fix
I wasn't able to repro locally but it seems like it has to be this.
Review URL: https://codereview.chromium.org/1309653003
/external/skia/src/core/SkLightingShader.cpp
|
| 2f0dbc761a626473c19db7de561c7072b12953c5 |
|
20-Aug-2015 |
robertphillips <robertphillips@google.com> |
Update SkLightingShader to support rotation
This also:
makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps.
adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class).
Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call)
Committed: https://skia.googlesource.com/skia/+/45b59ed6e4e231814dbdb9f707b3d2a7ee50de84
Review URL: https://codereview.chromium.org/1291783003
/external/skia/src/core/SkLightingShader.cpp
|
| f7d602a458f156723ec1a086f0fd132b1a9cc0e8 |
|
19-Aug-2015 |
robertphillips <robertphillips@google.com> |
Revert "Update SkLightingShader to support rotation"
This reverts commit 45b59ed6e4e231814dbdb9f707b3d2a7ee50de84.
TBR=herb@google.com
Review URL: https://codereview.chromium.org/1304673002
/external/skia/src/core/SkLightingShader.cpp
|
| 45b59ed6e4e231814dbdb9f707b3d2a7ee50de84 |
|
19-Aug-2015 |
robertphillips <robertphillips@google.com> |
Update SkLightingShader to support rotation
This also:
makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps.
adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class).
Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call)
Review URL: https://codereview.chromium.org/1291783003
/external/skia/src/core/SkLightingShader.cpp
|