84dd85793560769e9628d0a767cb50a4234c572a |
|
09-Mar-2017 |
Mike Reed <reed@google.com> |
make GrPaint.h private -- IWYU prerequisit: https://codereview.chromium.org/2743533002/ BUG=skia: Change-Id: I8c2f34a6df165744ddeaeabb562cd6d6a9679b6a Reviewed-on: https://skia-review.googlesource.com/9461 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
185130c643f0f6b20dcf14c200074748be282a7e |
|
15-Feb-2017 |
Mike Reed <reed@google.com> |
return and take SkImageGenerator as unique_ptr BUG=skia: Change-Id: I4bc11042dd1dbf1eabd40af206027bc65acc3186 Reviewed-on: https://skia-review.googlesource.com/8444 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
9df70bb74db8294283e8d2d8e20c95d290d2a34d |
|
14-Feb-2017 |
Matt Sarett <msarett@google.com> |
Picture backed images must have a bit depth and color space Enforce that picture backed images created by the public API must have a non-null SkColorSpace. SkPictureShader uses a private call to get around this restriction. BUG=skia: Change-Id: I2fc11a8ffe583035d09e83abf40b827fbf575321 Reviewed-on: https://skia-review.googlesource.com/8415 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
54be5c928604b52270bf218d910883e1aba3b226 |
|
11-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "More non-invertible shader local matrix guards" This reverts commit 368af4605db18f7197ed3289d2ebdc93bbb5879b. Reason for revert: checking to see if this is breaking the Chrome DEPS roll Original change's description: > More non-invertible shader local matrix guards > > Change-Id: Ida9a300420ff1d883e617cdaadb80e88c99ad226 > Reviewed-on: https://skia-review.googlesource.com/8333 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=brianosman@google.com,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id0a771342b9be27c85d91f511d814297b8c3e0b8 Reviewed-on: https://skia-review.googlesource.com/8345 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
368af4605db18f7197ed3289d2ebdc93bbb5879b |
|
10-Feb-2017 |
Florin Malita <fmalita@chromium.org> |
More non-invertible shader local matrix guards Change-Id: Ida9a300420ff1d883e617cdaadb80e88c99ad226 Reviewed-on: https://skia-review.googlesource.com/8333 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/src/core/SkPictureShader.cpp
|
83e939bcb79790f5ae3b28c398fbcf034675a6e5 |
|
07-Feb-2017 |
Herb Derby <herb@google.com> |
Use SkArenaAlloc in the SkAutoBlitterChoose code. - Added default implementation of onMakeContext to support use in android. Searches for uses: "public SkShader" package:^chromium$ -file:^src/third_party/skia package:^aosp.* "public SkShader" -file:external/skia -file:.*third_party/skia package:^android$ "public SkShader" -file:external/skia -file:.*third_party/skia ... shows that no subclass overrides onCreateContext. TBR=reed@google.com TBR=mtklein@google.com Change-Id: I8bd5f57a79534574e344b165d31dccee41c31767 Reviewed-on: https://skia-review.googlesource.com/8140 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
dd8b72ae7319598cfc1024901e860c52f06e6ae1 |
|
07-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code." This reverts commit 2b57b7f7a7fc97db57f190b5a8ebcf68e177ee2d. Reason for revert: Android compile failing Original change's description: > Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code. > > > TBR=reed@google.com > Change-Id: Iefb044bf7657fbf982f23aa91a3f4d013ce2c626 > Reviewed-on: https://skia-review.googlesource.com/7786 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Reviewed-by: Herb Derby <herb@google.com> > Commit-Queue: Herb Derby <herb@google.com> > TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id09c35377dddae0811d998b7d0c34c422325a5bc Reviewed-on: https://skia-review.googlesource.com/8129 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
2b57b7f7a7fc97db57f190b5a8ebcf68e177ee2d |
|
06-Feb-2017 |
Herb Derby <herb@google.com> |
Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code. TBR=reed@google.com Change-Id: Iefb044bf7657fbf982f23aa91a3f4d013ce2c626 Reviewed-on: https://skia-review.googlesource.com/7786 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
a99b6ceff92183b424634f2e7276b9ea1d59e69d |
|
04-Feb-2017 |
Mike Reed <reed@google.com> |
start removing uses of SkScalarMul BUG=skia:6197 Change-Id: Ic444c7ee4ca547f483dc8232dcacd6d4ba87d913 Reviewed-on: https://skia-review.googlesource.com/8041 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
8d2fb470729b7a9987aec8c5354ca7a4940ae3be |
|
30-Jan-2017 |
Yuqian Li <liyuqian@google.com> |
Implement onAppendStages for SkPictureShader BUG=skia: Change-Id: Ibc525a666f17fed1d987c0316b1963ebed7de343 Reviewed-on: https://skia-review.googlesource.com/7739 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkPictureShader.cpp
|
e94255d456ad86e045e0c3aeab57395566cf49a5 |
|
09-Jan-2017 |
Matt Sarett <msarett@google.com> |
Specify bit depth and color space in SkImage::MakeFromPicture() BUG=skia: Change-Id: I1d2a2b1f97557fc3e7ca6c2bdad6329f7760dbd2 Reviewed-on: https://skia-review.googlesource.com/6685 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
138ea97c1acaed4b968540220724dd5bf671e8db |
|
16-Dec-2016 |
Brian Osman <brianosman@google.com> |
Add color space to picture image as a creation parameter This gives a picture image a preferred "native" color space, which facilitates caching and other things. BUG=skia: Change-Id: I95988c14d17f96d7d870b3d1c3b723c36e2c170d Reviewed-on: https://skia-review.googlesource.com/6158 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
61624f0c716b576706659750d87b6956f4c15722 |
|
09-Dec-2016 |
Brian Osman <brianosman@google.com> |
Plumb dst color space in many places, rather than "mode" This is less to type in most cases, and gives us more information (for things like picture-backed images, where we need to know all about the destination surface). Additionally, strip out the plumbing entirely for bitmap sources, where we don't need to know anything. BUG=skia: Change-Id: I4deff6c7c345fcf62eb08b2aff0560adae4313da Reviewed-on: https://skia-review.googlesource.com/5748 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
7b8400dad2f82dcc6ed3c7cc1707ebaf85f04840 |
|
08-Nov-2016 |
Brian Osman <brianosman@google.com> |
Rename SkSourceGammaTreatment to SkDestinationSurfaceColorMode This is much more explicit about what that type represents (are we in legacy mode or not), which also makes it suitable for other (upcoming) usage. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4529 Change-Id: Iacb397c34e7765f1ca86c0195bc622b2be4d9acf Reviewed-on: https://skia-review.googlesource.com/4529 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
704cd32e4a92d6c3eae6bfae4adcc20126bf4437 |
|
07-Nov-2016 |
Hal Canary <halcanary@google.com> |
src/core: s/SkAutoTUnref/sk_sp/g BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4492 Change-Id: I753ad01b03e891221965252e3befe280d09cdb9f Reviewed-on: https://skia-review.googlesource.com/4492 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/src/core/SkPictureShader.cpp
|
c9a9ca934b936512a486674cfe06fd1c132b4723 |
|
12-Oct-2016 |
fmalita <fmalita@chromium.org> |
Fix double-accounting of SkPictureShader bitmap memory The pixels RAM is accounted via SkImageGenerator/SkImageCacherator, we don't need to report it as part of SkPictureShader's BitmapShaderRec. R=reed@google.com BUG=chromium:619929 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415673002 Review-Url: https://codereview.chromium.org/2415673002
/external/skia/src/core/SkPictureShader.cpp
|
1638c0deea80e4a580fe43babeb04279dd163e98 |
|
25-Jul-2016 |
brianosman <brianosman@google.com> |
Add destination color space to AsFPArgs. Eliminates last XFORMTODO. This is going to be needed in many more places as I finish connecting the dots. Even better - I'd like to switch to a world where SkColorSpace != nullptr is the only signal we use for gamma-correct rendering, so I can eliminate SkSourceGammaTreatment and SkSurfaceProps::isGammaCorrect. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180503002 Review-Url: https://codereview.chromium.org/2180503002
/external/skia/src/core/SkPictureShader.cpp
|
839345d63466a4209a0985654ec033624821fd78 |
|
22-Jul-2016 |
brianosman <brianosman@google.com> |
Bundle SkShader::asFragmentProcessor arguments in a struct The signature of this thing keeps changing (and is about to change again). This just makes maintenance much easier. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175563003 Review-Url: https://codereview.chromium.org/2175563003
/external/skia/src/core/SkPictureShader.cpp
|
06ca8ec87cf6fab57cadd043a5ac18c4154a4129 |
|
09-Jun-2016 |
bungeman <bungeman@google.com> |
sk_sp for Ganesh. Convert use of GrFragmentProcessor, GrGeometryProcessor, and GrXPFactory to sk_sp. This clarifies ownership and should reduce reference count churn by moving ownership. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041113004 Review-Url: https://codereview.chromium.org/2041113004
/external/skia/src/core/SkPictureShader.cpp
|
982eb7f377a0c771345276558072deb2fcea0d3e |
|
06-Jun-2016 |
brianosman <brianosman@google.com> |
Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2037413002 Review-Url: https://codereview.chromium.org/2037413002
/external/skia/src/core/SkPictureShader.cpp
|
60c9b58b3214b0154c931656e91e39b230e987d8 |
|
03-Apr-2016 |
reed <reed@google.com> |
change flattenable factory to return sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002 Review URL: https://codereview.chromium.org/1855733002
/external/skia/src/core/SkPictureShader.cpp
|
ca2622ba051829fed5f30facd74c5b41cd4b931c |
|
18-Mar-2016 |
reed <reed@google.com> |
return pictures as sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811703002 Review URL: https://codereview.chromium.org/1811703002
/external/skia/src/core/SkPictureShader.cpp
|
7fb4f8bd031eda87e1da9bc0f749968c0e872e6f |
|
11-Mar-2016 |
reed <reed@google.com> |
Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ )" Fix was to call get() instead of release() when passing the sp to a bare-ptr method. This reverts commit e683c56115a210b5993df9294260bb147b408bfa. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1789443002 TBR= Review URL: https://codereview.chromium.org/1789443002
/external/skia/src/core/SkPictureShader.cpp
|
e683c56115a210b5993df9294260bb147b408bfa |
|
11-Mar-2016 |
robertphillips <robertphillips@google.com> |
Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ ) Reason for revert: Experimental revert to try to clear up ASAN failures Original issue's description: > add Make variations to return SkImage by sk_sp > > some internal call-sites update, but not. Will follow-up in future to complete that. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778393002 > > Committed: https://skia.googlesource.com/skia/+/bd73ffb83022f1f6b1997e2a91c049949e88a8a2 TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1783063002
/external/skia/src/core/SkPictureShader.cpp
|
bd73ffb83022f1f6b1997e2a91c049949e88a8a2 |
|
10-Mar-2016 |
reed <reed@google.com> |
add Make variations to return SkImage by sk_sp some internal call-sites update, but not. Will follow-up in future to complete that. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778393002 Review URL: https://codereview.chromium.org/1778393002
/external/skia/src/core/SkPictureShader.cpp
|
5671c5b9124f17d33bc14b6d347cdc6fe5d19dc8 |
|
09-Mar-2016 |
reed <reed@google.com> |
SkImage now has makeShader to return sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1785473002 Review URL: https://codereview.chromium.org/1785473002
/external/skia/src/core/SkPictureShader.cpp
|
8a21c9fe7f5fef9e87115defef27bd7218419f28 |
|
09-Mar-2016 |
reed <reed@google.com> |
use Make instead of Create to return a shared shader Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002 Review URL: https://codereview.chromium.org/1772463002
/external/skia/src/core/SkPictureShader.cpp
|
a0cee5f30e9254187a6bb943e6b8a9296214c353 |
|
04-Mar-2016 |
reed <reed@google.com> |
remove align16 calls in skhader context sizes. will handle this elsewhere as needed BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768433003 TBR= basically reverts previous CL, but keeps the create --> onCreate change Review URL: https://codereview.chromium.org/1768433003
/external/skia/src/core/SkPictureShader.cpp
|
773ceda51ca120b686ba2d1aff1b6d5173143be0 |
|
04-Mar-2016 |
reed <reed@google.com> |
Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )" This reverts commit e38bcaf24b00066e167e03a5ac63cf828914d747. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763973002 TBR= Review URL: https://codereview.chromium.org/1763973002
/external/skia/src/core/SkPictureShader.cpp
|
e38bcaf24b00066e167e03a5ac63cf828914d747 |
|
03-Mar-2016 |
halcanary <halcanary@google.com> |
Revert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ ) Reason for revert: Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm: .... FYI: loaded 23439 distinct uninteresting hashes from 23439 lines Skipping config gpu: Don't understand 'gpu'. Skipping config msaa16: Don't understand 'msaa16'. 168400 srcs * 7 sinks + 481 tests == 1179281 tasks 0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak 565 gm xfermodes2 565 gm xfermodes 565 gm xfermodeimagefilter 565 gm xfermodes3 565 gm verylarge_picture_image c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108: fatal error: ""(0 == ((size) & 15))"" step returned non-zero exit code: 3 @@@STEP_FAILURE@@@ Original issue's description: > enforce 16byte alignment in shader contexts > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004 > > Committed: https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96 TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1759323002
/external/skia/src/core/SkPictureShader.cpp
|
d812fb458807245daa812adb7af0733cf5b54d96 |
|
03-Mar-2016 |
reed <reed@google.com> |
enforce 16byte alignment in shader contexts BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004 Review URL: https://codereview.chromium.org/1759653004
/external/skia/src/core/SkPictureShader.cpp
|
85c6f9849ed72f859680e93e7d24e3f61ff280f9 |
|
29-Feb-2016 |
fmalita <fmalita@chromium.org> |
Use enclosing int rect for picture shader tiles To avoid rounding to zero for very small tiles. BUG=chromium:590447 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749763002 Review URL: https://codereview.chromium.org/1749763002
/external/skia/src/core/SkPictureShader.cpp
|
8d9f2e474ac9d175c28079357b022d31408e2fe4 |
|
22-Feb-2016 |
fmalita <fmalita@chromium.org> |
Add ContextRec param to SkShader::contextSize() To facilitate upcoming context selection changes. R=reed@google.com,mtklein@google.com,herb@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002 Review URL: https://codereview.chromium.org/1720933002
/external/skia/src/core/SkPictureShader.cpp
|
40bed64ff0f2dc842f01a0e8ad85c0cec9fab4b5 |
|
01-Feb-2016 |
fmalita <fmalita@chromium.org> |
SkPictureShader cleanup Minor cleanup following http://crrev.com/1405103003. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1652943002 Review URL: https://codereview.chromium.org/1652943002
/external/skia/src/core/SkPictureShader.cpp
|
1b46a573656ec057eac300b34d1deff8526a559e |
|
01-Feb-2016 |
fmalita <fmalita@chromium.org> |
Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d Review URL: https://codereview.chromium.org/1405103003
/external/skia/src/core/SkPictureShader.cpp
|
0152cc3819291841298013d2b5515a61e974e41f |
|
04-Jan-2016 |
caryclark <caryclark@google.com> |
remove 565 effects shaders This removes the 565 optimization for radial, linear, sweep, and picture shaders. The optimization gets little real-world use and has a reasonable fallback. This also permits removing the square root table for the radial gradient case. R=reed@google.com BUG=skia:1947 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553103003 Review URL: https://codereview.chromium.org/1553103003
/external/skia/src/core/SkPictureShader.cpp
|
b4a20767ee129ba47cee42e61252a9faec09c3a6 |
|
21-Oct-2015 |
caryclark <caryclark@google.com> |
Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (patchset #3 id:40001 of https://codereview.chromium.org/1405103003/ ) Reason for revert: Test to see if patch fixes Nexus 6. Original issue's description: > Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader > > Use an SkImage generator/shader instead. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1407043008
/external/skia/src/core/SkPictureShader.cpp
|
fa694ad067976a5b713eec0b6f92ba5efeb0aa9d |
|
16-Oct-2015 |
fmalita <fmalita@chromium.org> |
Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Review URL: https://codereview.chromium.org/1405103003
/external/skia/src/core/SkPictureShader.cpp
|
f469fc0e0f04197f19c94c26801ba6888c6329dc |
|
15-Oct-2015 |
ericrk <ericrk@chromium.org> |
Fix floating point data loss in SkPictureShader SkPictureShader had an invalid use of SkMax32 on two SkScalars which ended up converting the result to an integer which caused us to lose necessary floating point data. BUG=473166 Review URL: https://codereview.chromium.org/1401743004
/external/skia/src/core/SkPictureShader.cpp
|
4a339529612a43871d021877e58698e067d6c4cd |
|
06-Oct-2015 |
bsalomon <bsalomon@google.com> |
Bye bye processor data manager. Review URL: https://codereview.chromium.org/1388113002
/external/skia/src/core/SkPictureShader.cpp
|
25a5b0dd0c9e94d508b8a9f4de1f977e63775bd1 |
|
28-Sep-2015 |
robertphillips <robertphillips@google.com> |
Revert of SkImage-backed SkPictureShader (patchset #4 id:60001 of https://codereview.chromium.org/1343153003/ ) Reason for revert: This CL appears to be breaking the pictureshader, pictureshadertile and tiled_picture_shader GMs on the iPad4 and the N7. The artifact is black rectangles. Original issue's description: > SkImage-backed SkPictureShader > > Instead of using an explicit image generator + SkBitmap + bitmap shader, > switch to the shiny new SkImage/image generator/image shader. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1374763003
/external/skia/src/core/SkPictureShader.cpp
|
97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d |
|
26-Sep-2015 |
fmalita <fmalita@chromium.org> |
SkImage-backed SkPictureShader Instead of using an explicit image generator + SkBitmap + bitmap shader, switch to the shiny new SkImage/image generator/image shader. R=reed@google.com Review URL: https://codereview.chromium.org/1343153003
/external/skia/src/core/SkPictureShader.cpp
|
d114645d931d4e95a938597a45a270f211273c17 |
|
25-Sep-2015 |
reed <reed@google.com> |
SkInstallDiscardablePixelRef is deprecated, enforce that No functionality change, just a renaming. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1372593002
/external/skia/src/core/SkPictureShader.cpp
|
44c3128bd892d32f797810d93ef1ed392e0b902d |
|
03-Sep-2015 |
robertphillips <robertphillips@google.com> |
Clean up some lint complaints BUG=skia:4287 Review URL: https://codereview.chromium.org/1327943003
/external/skia/src/core/SkPictureShader.cpp
|
ddc4b46c340d4572e1c29e97d5a85b4d76b9c577 |
|
01-Sep-2015 |
fmalita <fmalita@chromium.org> |
Image generator-backed SkPictureShader A respin of http://crrev.com/866773002 R=reed@google.com Review URL: https://codereview.chromium.org/1323863002
/external/skia/src/core/SkPictureShader.cpp
|
c21b09eec91c9e263cb0b88467ea44e348ed4962 |
|
29-Aug-2015 |
bsalomon <bsalomon@google.com> |
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa Review URL: https://codereview.chromium.org/1316513002
/external/skia/src/core/SkPictureShader.cpp
|
a511e6ad1042093bea5b015c22a920313fc57c0b |
|
29-Aug-2015 |
rmistry <rmistry@google.com> |
Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (patchset #8 id:140001 of https://codereview.chromium.org/1316513002/ ) Reason for revert: Primary suspect in failing DEPS rolls: * https://codereview.chromium.org/1315753006 * https://codereview.chromium.org/1308323006 * https://codereview.chromium.org/1320903004 Primary suspect because the failing win bots did not fail in https://codereview.chromium.org/1315753005 Original issue's description: > Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* > > Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa TBR=joshualitt@google.com,wangyix@google.com,robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1313573005
/external/skia/src/core/SkPictureShader.cpp
|
ecfdc251be71f3d634e76afdd6375bf55fc061aa |
|
28-Aug-2015 |
bsalomon <bsalomon@google.com> |
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* Review URL: https://codereview.chromium.org/1316513002
/external/skia/src/core/SkPictureShader.cpp
|
96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkPictureShader.cpp
|
385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete DOCS_PREVIEW= https://skia.org/?cl=1316123003 Review URL: https://codereview.chromium.org/1316123003
/external/skia/src/core/SkPictureShader.cpp
|
216b643fc77e754a3fabbb0ed397e7cf55d1954d |
|
19-Aug-2015 |
reed <reed@google.com> |
private iterator to visit all resource cache entries BUG=skia: TBR= Review URL: https://codereview.chromium.org/1271033002
/external/skia/src/core/SkPictureShader.cpp
|
f5822825ec2d5dd24ab476fdd42db2a6573f9756 |
|
19-Aug-2015 |
reed <reed@google.com> |
change asABitmap to isABitmap on shader BUG=skia: TBR= Review URL: https://codereview.chromium.org/1287263005
/external/skia/src/core/SkPictureShader.cpp
|
9cc1775e7230579ad15345bdcb59fa517c17f870 |
|
09-Jul-2015 |
joshualitt <joshualitt@chromium.org> |
rename GrShaderDataManager -> GrProcessorDataManager BUG=skia: Review URL: https://codereview.chromium.org/1228683002
/external/skia/src/core/SkPictureShader.cpp
|
8ca93e7c733ab064c8a9e03715ac405ae739cf51 |
|
08-Jul-2015 |
joshualitt <joshualitt@chromium.org> |
Initial CL to create dummy GrShaderDataManager and thread it through TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1225673007
/external/skia/src/core/SkPictureShader.cpp
|
446ee67fda73b11281b8e28a68edec811347c0c5 |
|
16-Jun-2015 |
hendrikw <hendrikw@chromium.org> |
skia: Add runtime option to disable picture IO security precautions Replaced the compile time file IO security setting with a runtime setting. Unfortunately the setting is global. Review URL: https://codereview.chromium.org/1183853003
/external/skia/src/core/SkPictureShader.cpp
|
762286309545c8a1e4bbc05dcd1fe3085d2a1f47 |
|
29-May-2015 |
bsalomon <bsalomon@google.com> |
Add direct getter for GrCaps to GrContext. TBR=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99 Review URL: https://codereview.chromium.org/1149773005
/external/skia/src/core/SkPictureShader.cpp
|
084d1b61bca3b9e246cdf26377c373744ab6411c |
|
28-May-2015 |
bsalomon <bsalomon@google.com> |
Revert of Add direct getter for GrCaps to GrContext. (patchset #4 id:60001 of https://codereview.chromium.org/1149773005/) Reason for revert: Breaking Original issue's description: > Add direct getter for GrCaps to GrContext. > > TBR=joshualitt@google.com > > Committed: https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1164443002
/external/skia/src/core/SkPictureShader.cpp
|
9138c46e572085870638b6f7ad7fcdfcdf3cac99 |
|
28-May-2015 |
bsalomon <bsalomon@google.com> |
Add direct getter for GrCaps to GrContext. TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1149773005
/external/skia/src/core/SkPictureShader.cpp
|
76be9c8dc0e5306ef81c2987848088cdec7ccd3f |
|
20-May-2015 |
mtklein <mtklein@chromium.org> |
Don't serialize SkPictures in SkPictureShaders when in untrusted mode. This requires we "first" add a has-picture bool to SkPictureShader serialized format. BUG=chromium:486947, billions and billions of others. Review URL: https://codereview.chromium.org/1151663002
/external/skia/src/core/SkPictureShader.cpp
|
cfa90a1aaff2ffbb71a8597905607287856601e5 |
|
18-May-2015 |
mtklein <mtklein@chromium.org> |
Empty picture shaders should draw nothing. BUG=skia: Review URL: https://codereview.chromium.org/1142053004
/external/skia/src/core/SkPictureShader.cpp
|
80ea19ca4bdd68c1493666a5fe7e4ce9d43ded8b |
|
12-May-2015 |
reed <reed@google.com> |
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/) Reason for revert: android patched, blink has rolled Original issue's description: > Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/) > > Reason for revert: > need to wait for Blink roll (and patch android) > > Original issue's description: > > stop calling SkScalarDiv > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a > > TBR= > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1135693003
/external/skia/src/core/SkPictureShader.cpp
|
2629697933b5cc975e45d2a45c48f803fc6cbcec |
|
12-May-2015 |
reed <reed@google.com> |
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/) Reason for revert: need to wait for Blink roll (and patch android) Original issue's description: > stop calling SkScalarDiv > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1138263002
/external/skia/src/core/SkPictureShader.cpp
|
67d71c898249a7af3523b16c6a69895a63bfae0a |
|
12-May-2015 |
reed <reed@google.com> |
stop calling SkScalarDiv BUG=skia: TBR= Review URL: https://codereview.chromium.org/1135053002
/external/skia/src/core/SkPictureShader.cpp
|
88f12dbe926df806cfb5b0641f613a2e256a713b |
|
11-May-2015 |
gen.kim <gen.kim@samsung.com> |
SkPictureShader: floor scaledSize not to exceed maxTextureSize scaledSize becomes larger than maxTextureSize by zoom level because it is rounded. BUG=chromium:485916 Review URL: https://codereview.chromium.org/1129413002
/external/skia/src/core/SkPictureShader.cpp
|
b9ed8845783ec3c59b2b185d26801f251adbf68d |
|
04-May-2015 |
gen.kim <gen.kim@samsung.com> |
SkPictureShader: scale down if width or height is larger than maxTextureSize Grdient renders black because of failure onCreateTexture if one of width or height is larger than maxTextureSize with --force-gpu-rasterization. BUG=chromium:473166 Review URL: https://codereview.chromium.org/1101513004
/external/skia/src/core/SkPictureShader.cpp
|
36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/core/SkPictureShader.cpp
|
adf9990cb56ca389f37f02ac637496083b3c3cfc |
|
20-Mar-2015 |
reed <reed@google.com> |
add SkMatrix::decomposeScale BUG=skia: Review URL: https://codereview.chromium.org/1006173005
/external/skia/src/core/SkPictureShader.cpp
|
511005b2ccf060bd8ca5f078f2c0c7c7da5cc084 |
|
13-Mar-2015 |
fmalita <fmalita@chromium.org> |
Lower SkPictureShader tile size limits Let's drop this to 4M pixels - maybe it will help relieve DM pressure on mobile devices. R=reed@google.com,mtklein@google.com BUG=462348 Review URL: https://codereview.chromium.org/998423004
/external/skia/src/core/SkPictureShader.cpp
|
f47e70712b964b5360a3fec9e5e84bb594fc1f02 |
|
26-Feb-2015 |
fmalita <fmalita@chromium.org> |
Revert of Use an image generator to back SkPictureShader tiles. (patchset #4 id:60001 of https://codereview.chromium.org/866773002/) Reason for revert: TSAN troubles. Original issue's description: > Use an image generator to back SkPictureShader tiles. > > To avoid lifetime issues for tiles backed by discardable memory, use an > image generator to re-generate them on the fly. > > With this CL, we are now caching bitmap shaders wrapping discardable > pixel ref bitmaps backed by picture image generators. > > (the CL also includes some minor/unrelated SkPictureShader cleanup) > > BUG=skia:3220 > R=reed@google.com,halcanary@google.com > > Committed: https://skia.googlesource.com/skia/+/4739955e98ba86900a5bbac0e3661601427a54d4 TBR=reed@google.com,halcanary@google.com,mtklein@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3220 Review URL: https://codereview.chromium.org/956143002
/external/skia/src/core/SkPictureShader.cpp
|
7eeba2587760a0802fd2b90765b4fd0e5e895375 |
|
24-Feb-2015 |
reed <reed@chromium.org> |
Notify resource caches when pixelref genID goes stale patch from issue 954443002 at patchset 40001 (http://crrev.com/954443002#ps40001) BUG=skia: Review URL: https://codereview.chromium.org/950363002
/external/skia/src/core/SkPictureShader.cpp
|
4739955e98ba86900a5bbac0e3661601427a54d4 |
|
24-Feb-2015 |
fmalita <fmalita@chromium.org> |
Use an image generator to back SkPictureShader tiles. To avoid lifetime issues for tiles backed by discardable memory, use an image generator to re-generate them on the fly. With this CL, we are now caching bitmap shaders wrapping discardable pixel ref bitmaps backed by picture image generators. (the CL also includes some minor/unrelated SkPictureShader cleanup) BUG=skia:3220 R=reed@google.com,halcanary@google.com Review URL: https://codereview.chromium.org/866773002
/external/skia/src/core/SkPictureShader.cpp
|
9e447c08deb30b26a2101cb20b8a04aa230f09c4 |
|
15-Feb-2015 |
reed <reed@chromium.org> |
remove unneeded preroll BUG=skia: TBR=robertphilips Review URL: https://codereview.chromium.org/927443006
/external/skia/src/core/SkPictureShader.cpp
|
3d91aad293b0f68886ed48ecfa6aa75826a27da8 |
|
02-Feb-2015 |
fmalita <fmalita@chromium.org> |
Disable LCD text when rasterizing SkPictureShader tiles. BUG=chromium:453299 R=reed@google.com Review URL: https://codereview.chromium.org/884163003
/external/skia/src/core/SkPictureShader.cpp
|
96a857ef5a40b3d0751ec9ebaaa96d9f20b82b21 |
|
25-Jan-2015 |
reed <reed@chromium.org> |
initial preroll api BUG=skia: Review URL: https://codereview.chromium.org/855473002
/external/skia/src/core/SkPictureShader.cpp
|
b0878797b45f93b3bfe6084094c74affd10207df |
|
15-Jan-2015 |
fmalita <fmalita@chromium.org> |
SkPictureShader should handle negative scaling gracefully. Let's not choke on inverted tiles. BUG=chromium:447707 R=robertphillips@google.com,reed@google.com Review URL: https://codereview.chromium.org/852213002
/external/skia/src/core/SkPictureShader.cpp
|
72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases. This fixes every case where virtual and SK_OVERRIDE were on the same line, which should be the bulk of cases. We'll have to manually clean up the rest over time unless I level up in regexes. for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end BUG=skia: Review URL: https://codereview.chromium.org/806653007
/external/skia/src/core/SkPictureShader.cpp
|
5531d51ce7426bdae7563547326fcf0bf926a083 |
|
18-Dec-2014 |
joshualitt <joshualitt@chromium.org> |
remove view matrix from context BUG=skia: Review URL: https://codereview.chromium.org/808703006
/external/skia/src/core/SkPictureShader.cpp
|
04b49c31789201fbef969f5598a286187920dd56 |
|
10-Dec-2014 |
fmalita <fmalita@chromium.org> |
Don't store an SkMatrix in BitmapShaderKey. SkMatrix makes for a poor key component due to mutable/cache fields. Use its canonical scalars instead. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/792123002
/external/skia/src/core/SkPictureShader.cpp
|
387a01a6357b4ba6ff87ac57626de1cb6a3b31bf |
|
10-Dec-2014 |
fmalita <fmalita@chromium.org> |
Detect discarded SkPictureShader pixel refs. This doesn't address the more general problem, but reduces the race window significantly. BUG=440282 R=reed@google.com Review URL: https://codereview.chromium.org/787043006
/external/skia/src/core/SkPictureShader.cpp
|
a2bd24fd15378d0a25d79b4aa2d76dddc4cf564c |
|
08-Dec-2014 |
fmalita <fmalita@chromium.org> |
Tweak SkPictureShader's tile semantics. Currently, the tile offset is added when drawing the picture. This might have made a tiny bit of sense when the picture was always positioned at origin, but with a picture cull rect offset things looks really strange. For example, to specify a tile == the picture cull rect we have to pass in [-cullrect.x, -cullrect.y, cullrect.width, cullrect.height]. Yikes. (there's also a bug when not passing a tile, as we use a default tile == cullrect but don't compensate for the above oddity) This changes the semantics of the tile offset: it is now subtracted when drawing the picture tile. As a consequence, one can pass in a tile equal to the cull rect and get the expected behavior (same when not passing a tile). This will require a minor Blink change with the roll, as one client works around the current behavior: https://codereview.chromium.org/789503003 R=reed@google.com,robertphillips@google.com BUG=440046 Review URL: https://codereview.chromium.org/733203005
/external/skia/src/core/SkPictureShader.cpp
|
3f3b3d003527861dc0bd89733857576408906431 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 Review URL: https://codereview.chromium.org/769953002
/external/skia/src/core/SkPictureShader.cpp
|
6e78293ee896020104ffc4c23b565073e9a49893 |
|
01-Dec-2014 |
mtklein <mtklein@google.com> |
Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (patchset #1 id:1 of https://codereview.chromium.org/769953002/) Reason for revert: Breaks canary builds. Will reland after the Chromium change lands. Original issue's description: > Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. > > This was needed for pictures before v33, and we're now requiring v35+. > > Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/768183002
/external/skia/src/core/SkPictureShader.cpp
|
52c293547b973f7fb5de3c83f5062b07d759ab88 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Review URL: https://codereview.chromium.org/769953002
/external/skia/src/core/SkPictureShader.cpp
|
171e5b73a862418f4acd61faf8cecfbc8f58694c |
|
22-Oct-2014 |
fmalita <fmalita@chromium.org> |
SkResourceCache::Key namespace support. Add a unique-per-subclass namespace tag to make Keys from different domains comparable. Also drop the SkPictureShader cache and convert to using the global resource cache instead. R=reed@google.com,mtklein@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/668223002
/external/skia/src/core/SkPictureShader.cpp
|
23df2d693304824a2ce7ac3d988b0e48fec1c49d |
|
22-Oct-2014 |
fmalita <fmalita@chromium.org> |
Picture shader resource caching. Replace the current/naive shader caching mechanism with a more general implementation based on SkResourceCache. Caching the bitmap shader itself (as opposed to just the tile bitmap) makes for a chunkier key, but OTOH avoids allocating new shaders on cache hit. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/671683004
/external/skia/src/core/SkPictureShader.cpp
|
b0a8a377f832c59cee939ad721e1f87d378b7142 |
|
23-Sep-2014 |
joshualitt <joshualitt@chromium.org> |
Patch to create a distinct geometry processor. The vast majority of this patch is just a rename. The meat is in GrGeometryProcessor, GrProcessor, GrGL*Processor, GrProcessorStage, Gr*BackendProcessorFactory, GrProcessUnitTestFactory, and the builders BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/582963002
/external/skia/src/core/SkPictureShader.cpp
|
49f085dddff10473b6ebf832a974288300224e60 |
|
05-Sep-2014 |
bsalomon <bsalomon@google.com> |
"NULL !=" = NULL R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002
/external/skia/src/core/SkPictureShader.cpp
|
848250415eddc54075f7eb8795e8db79e749c6ab |
|
02-Sep-2014 |
reed <reed@google.com> |
make allocPixels throw on failure BUG=skia: R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/510423005
/external/skia/src/core/SkPictureShader.cpp
|
a8d7f0b13cd4c6d773fcf055fe17db75d260fa05 |
|
29-Aug-2014 |
robertphillips <robertphillips@google.com> |
Try out scalar picture sizes This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect. R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/513983002
/external/skia/src/core/SkPictureShader.cpp
|
9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187 |
|
21-Aug-2014 |
reed <reed@google.com> |
Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc). Refactoring pattern: 1. guard the existing constructor(readbuffer) with the legacy build-flag 2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL). If you're a shader subclass 1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it. R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395603002
/external/skia/src/core/SkPictureShader.cpp
|
bb204f4917aff10fcb65d29a2d96e53a9611c559 |
|
07-Aug-2014 |
fmalita <fmalita@chromium.org> |
Clamp SkPictureShader's tile size. Blink used to clamp the max size for its pattern bitmaps (several SVG pattern tests rely on/verify this behavior). This CL clamps the maximum tile area to a reasonable value (16M pixels), and scales beyond that. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/446243002
/external/skia/src/core/SkPictureShader.cpp
|
b5f7826c51af2862aebcabe61e1ba684f925e488 |
|
06-Aug-2014 |
fmalita <fmalita@chromium.org> |
Explicit tile bounds for SkPictureShader The integer picture size is not granular enough to allow precise tiling in arbitrary coordinate systems. This CL adds an optional tile bounds float rect param to control the tile size and location. (this also allows tile spacing emulation for picture shaders). R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/437393003
/external/skia/src/core/SkPictureShader.cpp
|
e8464994bbcc797b47a5ee24aa513530d2bade3b |
|
14-Jul-2014 |
robertphillips <robertphillips@google.com> |
Make SkPictureShader and SkPictureImageFilter use const SkPictures R=mtklein@google.com, reed@google.com TBR=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/390023002
/external/skia/src/core/SkPictureShader.cpp
|
1b0aa001e8f5245663965992f32df6a43cb22e2f |
|
11-Jul-2014 |
scroggo <scroggo@google.com> |
No need to cache local matrix in picture shader. Now that the local matrix cannot be changed, we no longer need to keep track of it to regenerate the bitmap shader. Depends on https://codereview.chromium.org/379323002 R=fmalita@google.com, fmalita@chromium.org Author: scroggo@google.com Review URL: https://codereview.chromium.org/387043002
/external/skia/src/core/SkPictureShader.cpp
|
83d081ae1d731b5039e99823620f5e287542ee39 |
|
08-Jul-2014 |
bsalomon <bsalomon@google.com> |
Goodbye GrEffectRef. Also, reworked some var names and comments around SkShader::asNewEffect. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/374923002
/external/skia/src/core/SkPictureShader.cpp
|
97b9ab72cd5ee0cba4692082737266376425f27c |
|
08-Jul-2014 |
bsalomon <bsalomon@google.com> |
Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. Make Sk-effect virtuals produce GrEffect* rather than GrEffectRef* Make GrEffectRef a typedef for GrEffect. Committed: https://skia.googlesource.com/skia/+/2011fe9cdfa63b83489a146cea6a724cede352c8 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/377503004
/external/skia/src/core/SkPictureShader.cpp
|
969842ac9c3825100c86c8dae88d931c06286622 |
|
08-Jul-2014 |
reed <reed@google.com> |
Revert of Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. (https://codereview.chromium.org/377503004/) Reason for revert: broke linux builders Original issue's description: > Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. > > Make Sk-effect virtuals produce GrEffect* rather than GrEffectRef* > > Make GrEffectRef a typedef for GrEffect. > > Committed: https://skia.googlesource.com/skia/+/2011fe9cdfa63b83489a146cea6a724cede352c8 R=robertphillips@google.com, bsalomon@google.com TBR=bsalomon@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/372053003
/external/skia/src/core/SkPictureShader.cpp
|
2011fe9cdfa63b83489a146cea6a724cede352c8 |
|
08-Jul-2014 |
bsalomon <bsalomon@google.com> |
Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. Make Sk-effect virtuals produce GrEffect* rather than GrEffectRef* Make GrEffectRef a typedef for GrEffect. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/377503004
/external/skia/src/core/SkPictureShader.cpp
|
9de5b514d38c5b36066bcdc14fba2f7e5196d372 |
|
10-Jun-2014 |
dandov <dandov@google.com> |
SkShader::asNewEffect Refactoring The new signature is: bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const; It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader. BUG=skia:2646 R=jvanverth@google.com, bsalomon@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/318923005
/external/skia/src/core/SkPictureShader.cpp
|
9b14f26d0f3a974f3dd626c8354e1db1cfcd322f |
|
04-Jun-2014 |
robertphillips <robertphillips@google.com> |
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004
/external/skia/src/core/SkPictureShader.cpp
|
5970f625e96cdc007c563ae72f343ae0d71719a1 |
|
12-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
re-land hide get/setLocalMatrix This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1. TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14702 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
96fb7489ba46909c3f81bb2d94755e7d4ccb5fad |
|
09-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add localmatrix parameter to shader's asNewEffect BUG=skia: R=bsalomon@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/278963002 git-svn-id: http://skia.googlecode.com/svn/trunk@14686 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
d12de02542867c7c1be32b6e02e2f5dca9fb9452 |
|
09-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/) Reason for revert: broke gms Original issue's description: > hide get/setLocalMatrix > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14675 R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/278903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14677 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
5adad325c5fcbba08f43dc35487df193fc4f9f1f |
|
09-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
hide get/setLocalMatrix BUG=skia: R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/279563002 git-svn-id: http://skia.googlecode.com/svn/trunk@14675 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
80116dcf1e1baf9817ae42d0aca51f7eabaa2880 |
|
06-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add local-matrix to shader::context BUG=skia: R=scroggo@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/263293005 git-svn-id: http://skia.googlecode.com/svn/trunk@14592 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
f03f9ff295298ff58acdeb4d7142e9736121d362 |
|
06-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
don't leak the bitmapShader BUG=skia: R=fmalita@google.com, robertphillips@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/269163004 git-svn-id: http://skia.googlecode.com/svn/trunk@14588 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
ce56d965069c1649afe14319cb239e6ad670682a |
|
05-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkShader virtual method validContext patch from issue 267923005 BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/261773005 git-svn-id: http://skia.googlecode.com/svn/trunk@14573 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
5aacfe9ffcf1849727dca6761b4a221bd4315f26 |
|
02-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove setLocalMatrix calls from picture shader GM. This makes all --skr tests pass for me. Enabling it by default in DM. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14549 R=reed@google.com, mtklein@google.com, fmalita@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/260863007 git-svn-id: http://skia.googlecode.com/svn/trunk@14551 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
c09abe66c1388c5da456c7686eab7a7928e9e9d6 |
|
02-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Remove setLocalMatrix calls from picture shader GM. (https://codereview.chromium.org/260863007/) Reason for revert: changed GM unexpectedly. will sort out and try again Original issue's description: > Remove setLocalMatrix calls from picture shader GM. > > This makes all --skr tests pass for me. Enabling it by default in DM. > > BUG=skia:2378 > > Committed: http://code.google.com/p/skia/source/detail?r=14549 R=reed@google.com, fmalita@google.com, mtklein@chromium.org TBR=fmalita@google.com, mtklein@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2378 Author: mtklein@google.com Review URL: https://codereview.chromium.org/265013003 git-svn-id: http://skia.googlecode.com/svn/trunk@14550 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
74b8cb15e4fb330e8d10856f6620e8b92b39a9ce |
|
02-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove setLocalMatrix calls from picture shader GM. This makes all --skr tests pass for me. Enabling it by default in DM. BUG=skia:2378 R=reed@google.com, mtklein@google.com, fmalita@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/260863007 git-svn-id: http://skia.googlecode.com/svn/trunk@14549 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
e901b6de3ef8dea842008a08fc81e92fb1478d61 |
|
01-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
create struct to hold all the params passed around for shader::context BUG=skia: R=scroggo@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/264843006 git-svn-id: http://skia.googlecode.com/svn/trunk@14514 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
9c9005a347e9996f357bd79591bd34f74f8bbc66 |
|
28-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move SkShader::fLocalMatrix into SkShader constructor. As a first step towards removing SkShader::setLocalMatrix, which will make SkShader thread-safe, remove calls to setLocalMatrix that happen immediately after the shader is being created. Instead, pass the matrix into the constructor or factory method. BUG=skia:1976 R=scroggo@google.com, reed@google.com, skyostil@google.com, mtklein@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/245963010 git-svn-id: http://skia.googlecode.com/svn/trunk@14401 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
87fcd950198a16211b3988610beebb5ca5bcf323 |
|
23-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/249643002/) Reason for revert: Chromium side change landed along side DEPS roll that includes r14323. Original issue's description: > Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/) > > Reason for revert: > This is blocking the DEPS roll into Chromium. Failures can be seen here: > > http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/174333 > > Original issue's description: > > Extract most of the mutable state of SkShader into a separate Context object. > > > > SkShader currently stores some state during draw calls via setContext(...). > > Move that mutable state into a separate SkShader::Context class that is > > constructed on demand for the duration of the draw. > > > > Calls to setContext() are replaced with createContext() which returns a context > > corresponding to the shader object or NULL if the parameters to createContext > > are invalid. > > > > TEST=out/Debug/dm > > BUG=skia:1976 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14216 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14323 > > TBR=scroggo@google.com,skyostil@chromium.org,tomhudson@chromium.org,senorblanco@chromium.org,reed@google.com,bungeman@google.com,dominikg@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14326 R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com, dominikg@chromium.org TBR=bungeman@google.com, dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:1976 Author: bsalomon@google.com Review URL: https://codereview.chromium.org/246403013 git-svn-id: http://skia.googlecode.com/svn/trunk@14328 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
6e5671d8c9b2d9885e351b631b1dfbb4ed403789 |
|
23-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/) Reason for revert: This is blocking the DEPS roll into Chromium. Failures can be seen here: http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/174333 Original issue's description: > Extract most of the mutable state of SkShader into a separate Context object. > > SkShader currently stores some state during draw calls via setContext(...). > Move that mutable state into a separate SkShader::Context class that is > constructed on demand for the duration of the draw. > > Calls to setContext() are replaced with createContext() which returns a context > corresponding to the shader object or NULL if the parameters to createContext > are invalid. > > TEST=out/Debug/dm > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14216 > > Committed: http://code.google.com/p/skia/source/detail?r=14323 R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com, dominikg@chromium.org TBR=bungeman@google.com, dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:1976 Author: bsalomon@google.com Review URL: https://codereview.chromium.org/249643002 git-svn-id: http://skia.googlecode.com/svn/trunk@14326 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
bc2f1dc85e458af7bdb87873e60207f9f7299e4a |
|
23-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Extract most of the mutable state of SkShader into a separate Context object. SkShader currently stores some state during draw calls via setContext(...). Move that mutable state into a separate SkShader::Context class that is constructed on demand for the duration of the draw. Calls to setContext() are replaced with createContext() which returns a context corresponding to the shader object or NULL if the parameters to createContext are invalid. TEST=out/Debug/dm BUG=skia:1976 Committed: http://code.google.com/p/skia/source/detail?r=14216 R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/207683004 git-svn-id: http://skia.googlecode.com/svn/trunk@14323 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
855e88edfafe4b3892e99f932c38fa7433b2fcbe |
|
21-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixes for SkPictureShader. Update comment in header to make it more clear that the picture should be unaltered after creating the shader. We want our shaders to be immutable, and this supports that. Make the factory return NULL if the shader would have never drawn anyway i.e. for a null picture or picture with no width/height. Addresses comments I brought up in https://codereview.chromium.org/221923007/#msg16. BUG=skia:1976 R=reed@google.com, fmalita@chromium.org, robertphillips@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/238253005 git-svn-id: http://skia.googlecode.com/svn/trunk@14288 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
53783b026a00683c1fb504127c3398dabb61ea73 |
|
17-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/) Reason for revert: Causing memory leaks in Chromium. Original issue's description: > Extract most of the mutable state of SkShader into a separate Context object. > > SkShader currently stores some state during draw calls via setContext(...). > Move that mutable state into a separate SkShader::Context class that is > constructed on demand for the duration of the draw. > > Calls to setContext() are replaced with createContext() which returns a context > corresponding to the shader object or NULL if the parameters to createContext > are invalid. > > TEST=out/Debug/dm > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14216 R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, dominikg@chromium.org TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:1976 Author: bungeman@google.com Review URL: https://codereview.chromium.org/241283003 git-svn-id: http://skia.googlecode.com/svn/trunk@14247 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
68ea91a49311562347311448450199a957590c1c |
|
17-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/240303003/) Reason for revert: This and https://codereview.chromium.org/207683004 are causing memory leaks. Original issue's description: > Fix memory leak in SkGradientShader. > > Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap. > Rename methods returning a "pre-reffed" object to indicate obligations. > > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14223 R=reed@google.com, scroggo@google.com, dominikg@chromium.org TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1976 Author: bungeman@google.com Review URL: https://codereview.chromium.org/241603002 git-svn-id: http://skia.googlecode.com/svn/trunk@14245 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
9631337be0f463ede106c5dbca69d726795f6ccf |
|
16-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix memory leak in SkGradientShader. Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap. Rename methods returning a "pre-reffed" object to indicate obligations. BUG=skia:1976 R=reed@google.com, scroggo@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/240303003 git-svn-id: http://skia.googlecode.com/svn/trunk@14223 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
001f4ed2fb62ecdc98ce2884d925de11b7516d23 |
|
16-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Extract most of the mutable state of SkShader into a separate Context object. SkShader currently stores some state during draw calls via setContext(...). Move that mutable state into a separate SkShader::Context class that is constructed on demand for the duration of the draw. Calls to setContext() are replaced with createContext() which returns a context corresponding to the shader object or NULL if the parameters to createContext are invalid. TEST=out/Debug/dm BUG=skia:1976 R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/207683004 git-svn-id: http://skia.googlecode.com/svn/trunk@14216 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
c5d9bb0f677069f62ec76373b9730e70e7352455 |
|
08-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial picture shader implementation This CL adds an SkPictureShader class to support SkPicture-based patterns. The implementation renders the picture into an SkBitmap tile and then delegates to SkBitmapProcShader for the actual operation. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=14085 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/221923007 git-svn-id: http://skia.googlecode.com/svn/trunk@14092 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
8865d09cf81bd38359421024badde36109bbf41d |
|
08-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Initial picture shader implementation (https://codereview.chromium.org/221923007/) Reason for revert: breaking the buildbots. Subsequent CL only addressed CompareGMs but GenerateGMs are also failing. Original issue's description: > Initial picture shader implementation > > This CL adds an SkPictureShader class to support SkPicture-based > patterns. > > The implementation renders the picture into an SkBitmap tile and then > delegates to SkBitmapProcShader for the actual operation. > > R=reed@google.com,robertphillips@google.com,bsalomon@google.com > > Committed: http://code.google.com/p/skia/source/detail?r=14085 R=bsalomon@google.com, reed@google.com, robertphillips@google.com, fmalita@chromium.org TBR=bsalomon@google.com, fmalita@chromium.org, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/227553010 git-svn-id: http://skia.googlecode.com/svn/trunk@14087 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|
592b2d13c9fa856ae23cf6d643a39c21216e928d |
|
08-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Initial picture shader implementation This CL adds an SkPictureShader class to support SkPicture-based patterns. The implementation renders the picture into an SkBitmap tile and then delegates to SkBitmapProcShader for the actual operation. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/221923007 git-svn-id: http://skia.googlecode.com/svn/trunk@14085 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureShader.cpp
|