| aa840647fc7f057715bce62489b96c4299385135 |
|
23-Sep-2016 |
bsalomon <bsalomon@google.com> |
Don't compute path keys for volatile paths in GrShape.
Otherwise, we will compute cache keys for internally transformed paths that don't repeat (e.g. clip paths transformed into device space with a changing view matrix).
BUG=chromium:649562
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002
Review-Url: https://codereview.chromium.org/2369513002
/external/skia/src/gpu/GrShape.cpp
|
| 0e4a466a613fa02292dfdbd8d4097fc14f191c42 |
|
21-Sep-2016 |
bsalomon <bsalomon@google.com> |
Use sk_careful_memcpy when writing optional conic weights for GrShape path data key.
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359933002
NO_DEPENDENCY_CHECKS=true
Review-Url: https://codereview.chromium.org/2359933002
/external/skia/src/gpu/GrShape.cpp
|
| 67fa4e31d885acf74514527a2cc3ed759c05d3c4 |
|
21-Sep-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape compute keys for short paths from path data instead of using the gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357643002
Review-Url: https://codereview.chromium.org/2357643002
/external/skia/src/gpu/GrShape.cpp
|
| 8eb43e5f63306a22570b977bbb69e4ec78432d24 |
|
21-Sep-2016 |
bsalomon <bsalomon@google.com> |
Stop closing filled paths in GrShape
This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
Review-Url: https://codereview.chromium.org/2355833002
/external/skia/src/gpu/GrShape.cpp
|
| e918417dc34c0856822e6955b788e962c289ca3d |
|
20-Sep-2016 |
fmalita <fmalita@google.com> |
Revert of Stop closing filled paths in GrShape (patchset #1 id:1 of https://codereview.chromium.org/2355833002/ )
Reason for revert:
Triggers msaa16 asserts: https://build.chromium.org/p/client.skia/builders/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/4236/steps/test_skia%20on%20Windows/logs/stdio
c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)"
Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running:
msaa16 svg cartman.svg
Likely culprit:
msaa16 svg cartman.svg
Original issue's description:
> Stop closing filled paths in GrShape
>
> This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
>
> Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
TBR=robertphillips@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2357713002
/external/skia/src/gpu/GrShape.cpp
|
| ad001fdc77b2dfe32c1723cb58636728dfb776d8 |
|
20-Sep-2016 |
bsalomon <bsalomon@google.com> |
Stop closing filled paths in GrShape
This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
Review-Url: https://codereview.chromium.org/2355833002
/external/skia/src/gpu/GrShape.cpp
|
| 487f8d385be2e0dcc7e46339d7bb12e4820b91c8 |
|
20-Jul-2016 |
bsalomon <bsalomon@google.com> |
Consolidate special case shape transformation logic in GrShapeTest.
Enable all tests on all geometry types.
Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
Review-Url: https://codereview.chromium.org/2157013003
/external/skia/src/gpu/GrShape.cpp
|
| 0ae36a2cebf35c68c3013383d3b640f70034be55 |
|
18-Jul-2016 |
bsalomon <bsalomon@google.com> |
In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002
Review-Url: https://codereview.chromium.org/2151313002
/external/skia/src/gpu/GrShape.cpp
|
| 0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
Review-Url: https://codereview.chromium.org/2108523002
/external/skia/src/gpu/GrShape.cpp
|
| 635df95a9a25c66959f76b4bbb594b75333ded21 |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Revert of Make lines a special case in GrShape (patchset #5 id:120001 of https://codereview.chromium.org/2108523002/ )
Reason for revert:
Assertion failures
Original issue's description:
> Make lines a special case in GrShape
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
>
> Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2109613003
/external/skia/src/gpu/GrShape.cpp
|
| c62318c748a1907649bd75382c4f4fd10533f2b3 |
|
28-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Review-Url: https://codereview.chromium.org/2108523002
/external/skia/src/gpu/GrShape.cpp
|
| 728b0f750570ada198bde4c5b4605bc1902de1d4 |
|
27-Jun-2016 |
bsalomon <bsalomon@google.com> |
Use a union inside GrShape to hold geometry
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2094023002
Review-Url: https://codereview.chromium.org/2094023002
/external/skia/src/gpu/GrShape.cpp
|
| ac5fcea9c3ec32a87bfd8cb96531e82097a1d861 |
|
23-Jun-2016 |
bsalomon <bsalomon@google.com> |
Fix Rob's nits from https://codereview.chromium.org/2085913003
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087393003
Review-Url: https://codereview.chromium.org/2087393003
/external/skia/src/gpu/GrShape.cpp
|
| a4817afe5095b67a68c907ff2e48e3e07907140c |
|
23-Jun-2016 |
bsalomon <bsalomon@google.com> |
Canonicalize path fill types for stroked paths in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085913003
Review-Url: https://codereview.chromium.org/2085913003
/external/skia/src/gpu/GrShape.cpp
|
| 93f66bc3af522fdd2a5315407ba6d3f65c13fd1c |
|
21-Jun-2016 |
bsalomon <bsalomon@google.com> |
Apply canonicalizations to path GrShapes.
The following canonicalizations of path-backed GrShapes are added:
*convex shapes are stored with even/odd (or inv even/odd) fill.
*filled paths are closed.
*dashed paths ignore inverseness of the fill
This will improve the results of queries about the geometry that will be added in a future change.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067283003
Review-Url: https://codereview.chromium.org/2067283003
/external/skia/src/gpu/GrShape.cpp
|
| 1b28c1adc1e156831d5332546e942b63fd29075b |
|
20-Jun-2016 |
bsalomon <bsalomon@google.com> |
Some simplifications of GrShape reductions/canonicalizations
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064113004
Review-Url: https://codereview.chromium.org/2064113004
/external/skia/src/gpu/GrShape.cpp
|
| fd32df716cfc787a3ac50efb293a9317a97078c5 |
|
14-Jun-2016 |
bsalomon <bsalomon@google.com> |
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003
Review-Url: https://codereview.chromium.org/2051263003
/external/skia/src/gpu/GrShape.cpp
|
| 398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc |
|
13-Jun-2016 |
bsalomon <bsalomon@google.com> |
Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
Review-Url: https://codereview.chromium.org/2055253002
/external/skia/src/gpu/GrShape.cpp
|
| 7049396b65660907af5292d899053280430d929a |
|
10-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape capable of representing inverse filled rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056523002
Review-Url: https://codereview.chromium.org/2056523002
/external/skia/src/gpu/GrShape.cpp
|
| d67238421d661ea5dfd110a8028973801a7d42a1 |
|
07-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape use the original path when path effect fails.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044793002
Review-Url: https://codereview.chromium.org/2044793002
/external/skia/src/gpu/GrShape.cpp
|
| ee295645bd91fcbe1714847c5fe5341759037cc5 |
|
06-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape track the winding direction and starting point for rrect types.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042813002
Review-Url: https://codereview.chromium.org/2042813002
/external/skia/src/gpu/GrShape.cpp
|
| 9fb420393ee1c24fc3282b7155985fa8fa7bcad4 |
|
13-May-2016 |
bsalomon <bsalomon@google.com> |
Add bounds to GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970003003
Review-Url: https://codereview.chromium.org/1970003003
/external/skia/src/gpu/GrShape.cpp
|
| 97fd2d42b97104fa32a58d7e7a5b7255913f9c9d |
|
09-May-2016 |
bsalomon <bsalomon@google.com> |
Incorporate scale into GrStyle and GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952383003
Review-Url: https://codereview.chromium.org/1952383003
/external/skia/src/gpu/GrShape.cpp
|
| 06077565b18714ff3fc0db9118e2c21f6f25243f |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Make cap only affect the keys of GrShapes that are possibly-open
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949193002
Review-Url: https://codereview.chromium.org/1949193002
/external/skia/src/gpu/GrShape.cpp
|
| d9cca4a11a30f1391b56dd53ca2c6615298e2b14 |
|
04-May-2016 |
benjaminwagner <benjaminwagner@google.com> |
Fix ASAN errors.
These errors occur when building for GPU but running dm with --nogpu. The current ASAN bots do not catch these because 1) the CPU bot compiles with skia_gpu=0 and 2) the GPU bot runs with --nocpu; whereas the new ASAN bots use the same compile for both the CPU and GPU bots.
BUG=skia:5157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953473002
Review-Url: https://codereview.chromium.org/1953473002
/external/skia/src/gpu/GrShape.cpp
|
| fb08327e592a1dd19a0c3107243ccd01f6b7f848 |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Expand GrStyle's interface.
Adds some basic getters on GrStyle as well as static const instances for fill and hairline.
Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.
Moves style key functions from GrShape to GrStyle.
Also fixes some issues with SkPath creation when applying style to GrShapes.
Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1951613002
Review-Url: https://codereview.chromium.org/1951613002
/external/skia/src/gpu/GrShape.cpp
|
| 72dc51c288169f38177c71081090581c5ff415b1 |
|
27-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002
Review URL: https://codereview.chromium.org/1922713002
/external/skia/src/gpu/GrShape.cpp
|
| 47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.cpp
|
| 82ecc5773faa0068186557f8ab2957620a7d72ea |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
test failing
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1919243002
/external/skia/src/gpu/GrShape.cpp
|
| 824e58fc6df8fc149d9675f577f7deeaba698b09 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.cpp
|
| 83af0a63b1d91c7cd4306c4bcdfb60f99b5cbb46 |
|
26-Apr-2016 |
robertphillips <robertphillips@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1918203002
/external/skia/src/gpu/GrShape.cpp
|
| c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 |
|
25-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrShape.cpp
|