| f809c1ec98854b6d0e604744a1fc5f9a4ff493be |
|
13-Jan-2017 |
Robert Phillips <robertphillips@google.com> |
Try out new refFoo pattern on GrStyle
Change-Id: Ic7f30e3730a3431adf365d729320fe50f38dcea8
Reviewed-on: https://skia-review.googlesource.com/6907
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
/external/skia/src/gpu/GrStyle.h
|
| 0ae36a2cebf35c68c3013383d3b640f70034be55 |
|
18-Jul-2016 |
bsalomon <bsalomon@google.com> |
In GrShape detect that stroked axis-aligned lines are rrects.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002
Review-Url: https://codereview.chromium.org/2151313002
/external/skia/src/gpu/GrStyle.h
|
| ee43241d72148545e4e3b75aa4338c491b39cc0c |
|
27-Jun-2016 |
bsalomon <bsalomon@google.com> |
Remove style application from GrPathRenderer subclasses
Now that GrPathRenderer is using GrShape it is possible to get a key for a path that was computed by applying style to an original path.
This improves path renderer subclass selection, particularly when a post-styled path happens to work with a simpler path renderer (e.g. it is convex). Previously a more expensive path renderer may have applied the style and rendered it (e.g. the distance field PR)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
Review-Url: https://codereview.chromium.org/2064753003
/external/skia/src/gpu/GrStyle.h
|
| 8acedde5970ce70de6d9791ffeda87a65af4ed07 |
|
24-Jun-2016 |
bsalomon <bsalomon@google.com> |
Use GrShape in GrPathRenderer.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006
Review-Url: https://codereview.chromium.org/2081383006
/external/skia/src/gpu/GrStyle.h
|
| 398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc |
|
13-Jun-2016 |
bsalomon <bsalomon@google.com> |
Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
Review-Url: https://codereview.chromium.org/2055253002
/external/skia/src/gpu/GrStyle.h
|
| ee295645bd91fcbe1714847c5fe5341759037cc5 |
|
06-Jun-2016 |
bsalomon <bsalomon@google.com> |
Make GrShape track the winding direction and starting point for rrect types.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042813002
Review-Url: https://codereview.chromium.org/2042813002
/external/skia/src/gpu/GrStyle.h
|
| 9fb420393ee1c24fc3282b7155985fa8fa7bcad4 |
|
13-May-2016 |
bsalomon <bsalomon@google.com> |
Add bounds to GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970003003
Review-Url: https://codereview.chromium.org/1970003003
/external/skia/src/gpu/GrStyle.h
|
| 6663acff010ce752e4bf778da81fa97448c9db31 |
|
10-May-2016 |
bsalomon <bsalomon@google.com> |
Replace GrStrokeInfo with GrStyle.
A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002
Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f
Review-Url: https://codereview.chromium.org/1957363002
/external/skia/src/gpu/GrStyle.h
|
| 85d9667f59d4138438427bb2cdf67992d100e1a0 |
|
10-May-2016 |
bsalomon <bsalomon@google.com> |
Revert of Replace GrStrokeInfo with GrStyle. (patchset #4 id:160001 of https://codereview.chromium.org/1957363002/ )
Reason for revert:
Breaking some bots
Original issue's description:
> Replace GrStrokeInfo with GrStyle.
>
> A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002
>
> Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f
TBR=egdaniel@google.com,robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1967513002
/external/skia/src/gpu/GrStyle.h
|
| 33595bdf4b64a745f6340338d307e806e96c587f |
|
10-May-2016 |
bsalomon <bsalomon@google.com> |
Replace GrStrokeInfo with GrStyle.
A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002
Review-Url: https://codereview.chromium.org/1957363002
/external/skia/src/gpu/GrStyle.h
|
| 97fd2d42b97104fa32a58d7e7a5b7255913f9c9d |
|
09-May-2016 |
bsalomon <bsalomon@google.com> |
Incorporate scale into GrStyle and GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952383003
Review-Url: https://codereview.chromium.org/1952383003
/external/skia/src/gpu/GrStyle.h
|
| 1a0b9ed7d8e16a8ebc34732b5e54246003921423 |
|
06-May-2016 |
bsalomon <bsalomon@google.com> |
Fix issue where GrStyle::applyToPath exited before applying stroke
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1954123002
Review-Url: https://codereview.chromium.org/1954123002
/external/skia/src/gpu/GrStyle.h
|
| f0cf355b55eec7dacaa6c8e87c736e359b3ee278 |
|
05-May-2016 |
bsalomon <bsalomon@google.com> |
Stop banning stroke-and-fill for GrStyle and add tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949943003
Review-Url: https://codereview.chromium.org/1949943003
/external/skia/src/gpu/GrStyle.h
|
| 06077565b18714ff3fc0db9118e2c21f6f25243f |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Make cap only affect the keys of GrShapes that are possibly-open
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949193002
Review-Url: https://codereview.chromium.org/1949193002
/external/skia/src/gpu/GrStyle.h
|
| d9cca4a11a30f1391b56dd53ca2c6615298e2b14 |
|
04-May-2016 |
benjaminwagner <benjaminwagner@google.com> |
Fix ASAN errors.
These errors occur when building for GPU but running dm with --nogpu. The current ASAN bots do not catch these because 1) the CPU bot compiles with skia_gpu=0 and 2) the GPU bot runs with --nocpu; whereas the new ASAN bots use the same compile for both the CPU and GPU bots.
BUG=skia:5157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953473002
Review-Url: https://codereview.chromium.org/1953473002
/external/skia/src/gpu/GrStyle.h
|
| fb08327e592a1dd19a0c3107243ccd01f6b7f848 |
|
04-May-2016 |
bsalomon <bsalomon@google.com> |
Expand GrStyle's interface.
Adds some basic getters on GrStyle as well as static const instances for fill and hairline.
Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.
Moves style key functions from GrShape to GrStyle.
Also fixes some issues with SkPath creation when applying style to GrShapes.
Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1951613002
Review-Url: https://codereview.chromium.org/1951613002
/external/skia/src/gpu/GrStyle.h
|
| 308febaebd7048041ecd3ef4487e893238119d08 |
|
03-May-2016 |
bsalomon <bsalomon@google.com> |
Revert of Make GrStyle more sk_sp savy (patchset #1 id:1 of https://codereview.chromium.org/1947543002/ )
Reason for revert:
Crashing Ubuntu/GCC bot (but not clang)
Original issue's description:
> Make GrStyle more sk_sp savy
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947543002
>
> Committed: https://skia.googlesource.com/skia/+/46db22f1cfc65a7a4f1de13d774718347362f60f
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1943973002
/external/skia/src/gpu/GrStyle.h
|
| 46db22f1cfc65a7a4f1de13d774718347362f60f |
|
03-May-2016 |
bsalomon <bsalomon@google.com> |
Make GrStyle more sk_sp savy
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947543002
Review-Url: https://codereview.chromium.org/1947543002
/external/skia/src/gpu/GrStyle.h
|
| 47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrStyle.h
|
| 82ecc5773faa0068186557f8ab2957620a7d72ea |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
test failing
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1919243002
/external/skia/src/gpu/GrStyle.h
|
| 824e58fc6df8fc149d9675f577f7deeaba698b09 |
|
26-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrStyle.h
|
| 83af0a63b1d91c7cd4306c4bcdfb60f99b5cbb46 |
|
26-Apr-2016 |
robertphillips <robertphillips@google.com> |
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1918203002
/external/skia/src/gpu/GrStyle.h
|
| c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 |
|
25-Apr-2016 |
bsalomon <bsalomon@google.com> |
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Review URL: https://codereview.chromium.org/1822723003
/external/skia/src/gpu/GrStyle.h
|