History log of /external/skia/src/gpu/vk/GrVkImage.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a3b6a551510eccf8bee95c739a1f1c7c70356608 21-Mar-2017 Greg Daniel <egdaniel@google.com> In Vulkan make sure to add barriers between write operations

BUG=skia:6396

Change-Id: I60faf6ad9095f18c64e33a0359e30239efbac79f
Reviewed-on: https://skia-review.googlesource.com/9963
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/src/gpu/vk/GrVkImage.cpp
19ff1035d3334ffa513c93edce04662bb5ead5bd 31-Aug-2016 egdaniel <egdaniel@google.com> Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298483002

Review-Url: https://codereview.chromium.org/2298483002
/external/skia/src/gpu/vk/GrVkImage.cpp
3602d4f16a01da860d16eb36fb52eb62487495cc 12-Aug-2016 egdaniel <egdaniel@google.com> Allow vulkan to upload data to testing textures with optimal layouts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242553002

Review-Url: https://codereview.chromium.org/2242553002
/external/skia/src/gpu/vk/GrVkImage.cpp
ab527a5bbfb1eae4f99a1435d349a44d00477d82 28-Jun-2016 egdaniel <egdaniel@google.com> Enable many more tests for Vulkan

BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103133002

Review-Url: https://codereview.chromium.org/2103133002
/external/skia/src/gpu/vk/GrVkImage.cpp
6b6ffc4ab6ecee9f46425a5467ef0fbebbb8c9cd 13-Jun-2016 jvanverth <jvanverth@google.com> Create free list heap for suballocation

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029763002

Review-Url: https://codereview.chromium.org/2029763002
/external/skia/src/gpu/vk/GrVkImage.cpp
1e305ba0d6a4237020d36234e9e286d3b0489401 01-Jun-2016 jvanverth <jvanverth@google.com> Add offset to memory allocations

This is setting up for suballocations within one large
allocation

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018933004
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2018933004
/external/skia/src/gpu/vk/GrVkImage.cpp
7888f780d85ced5c572f0227c16b88ed59bcffe5 17-May-2016 brianosman <brianosman@google.com> Set the "mutable format" bit on sRGB images at creation time.

This allows us to later create an image view with a linear format, for
legacy-mode non-sRGB access.

No actual API change (just a comment change in public header).

TBR=bsalomon@google.com
BUG=skia:5308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1981333004

Review-Url: https://codereview.chromium.org/1981333004
/external/skia/src/gpu/vk/GrVkImage.cpp
b2df0c2702329be6380a943d548e7377a51d8565 13-May-2016 egdaniel <egdaniel@google.com> Refactor Vulkan image, texture, RTs so that create and getter handles match.

This allows allows us to track and notify clients when either side changes
and image layout.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974983002

Review-Url: https://codereview.chromium.org/1974983002
/external/skia/src/gpu/vk/GrVkImage.cpp
50c46c7b189caf94abb79cdc125245a6c0de0b4e 06-May-2016 jvanverth <jvanverth@google.com> Clean up GrVkImage::setLayout()

Fixes issues with mipmap generation, and calculates src information
inside the routine rather than having the client do it.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950713006

Review-Url: https://codereview.chromium.org/1950713006
/external/skia/src/gpu/vk/GrVkImage.cpp
82c0558d93b15e13f5ad431eeef44055af25bbcb 03-May-2016 jvanverth <jvanverth@google.com> Set barriers and image layout changes between mipmap blits.

Also fix some issues with mipLayer counts.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1945823002

Review-Url: https://codereview.chromium.org/1945823002
/external/skia/src/gpu/vk/GrVkImage.cpp
2af0f1b014b9aabb6119bf66fac20e4cd3a8279b 03-May-2016 jvanverth <jvanverth@google.com> Apply setImageLayout() to all of a VkImage's subresources.

This also adds fLevelCount to GrVkImage::Resource, which allows
clients to wrap mipmapped textures.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943933002
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/1943933002
/external/skia/src/gpu/vk/GrVkImage.cpp
58a8d9214a70e0f6c81c88a8b0b563c06bf0f70e 21-Apr-2016 egdaniel <egdaniel@google.com> Update min Vulkan version to 1.0.8.0, and fix various bugs

With updating the SDK, the debug layers also showed multiple bugs.
I have fixed those as well in this CL. These include:

1. Incorrectly tracking the allocated descriptor sets from the descriptor pools

2. Using MemoryBarriers inside render passes.

3. Correctly setting the Stencil Image layout anytime we are using a render pass with a stencil attachment

4. Setting the correct aspect mask for Depth/Stencil in a barrier.

TBR=bsalomon@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906623002

Review URL: https://codereview.chromium.org/1906623002
/external/skia/src/gpu/vk/GrVkImage.cpp
8f1dcaa6f3cc098bd5efd2595ca20e0bc1847d10 01-Apr-2016 egdaniel <egdaniel@google.com> Update vulkan format features in caps.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847963003

Review URL: https://codereview.chromium.org/1847963003
/external/skia/src/gpu/vk/GrVkImage.cpp
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 29-Mar-2016 halcanary <halcanary@google.com> Style bikeshed - remove extraneous whitespace

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002

Review URL: https://codereview.chromium.org/1842753002
/external/skia/src/gpu/vk/GrVkImage.cpp
fe170d28d722f29ada5f1e2c6069e7d24e6a4b84 22-Mar-2016 jvanverth <jvanverth@google.com> Fix borrowed GrVkImage::Resource.

With the current system, if we wrap a given GrVkTextureInfo*, add a
command using it to the command buffer, then delete the texture, the
command buffer will unref the GrVkImage::Resource when it's done, which
will delete the VkImage and VkDeviceMemory. This subclasses
GrVkImage::Resource for those cases, and will not delete the data on
an unref.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824123002

Review URL: https://codereview.chromium.org/1824123002
/external/skia/src/gpu/vk/GrVkImage.cpp
0fcfb7525f60eabfdaf9761c75c7d4fd1b46d0c5 09-Mar-2016 jvanverth <jvanverth@google.com> Fix some issues for Linux Vulkan build

lifecycle in GrVkGpu was tagged as uninitialized before use, and err in GrVkImage as unused.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782453004

Review URL: https://codereview.chromium.org/1782453004
/external/skia/src/gpu/vk/GrVkImage.cpp
164a9f061c5186ae931cc23a3c73f32472e80ff5 22-Feb-2016 Greg Daniel <egdaniel@google.com> Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.

R=robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:4955
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002

Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f

Review URL: https://codereview.chromium.org/1718693002
/external/skia/src/gpu/vk/GrVkImage.cpp
ad3a13c4c34d300882b8f9a5fdb98ad34a9df55b 22-Feb-2016 egdaniel <egdaniel@google.com> Revert of Add vulkan files into skia repo. (patchset #2 id:20001 of https://codereview.chromium.org/1718693002/ )

Reason for revert:
breaking builds

Original issue's description:
> Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.
>
> R=robertphillips@google.com
> TBR=bsalomon@google.com
>
> BUG=skia:4955
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002
>
> Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f

TBR=robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4955

Review URL: https://codereview.chromium.org/1723503002
/external/skia/src/gpu/vk/GrVkImage.cpp
48cf268defad66f58f1aa03b4835e5583be96b2f 22-Feb-2016 Greg Daniel <egdaniel@google.com> Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.

R=robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:4955
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002

Review URL: https://codereview.chromium.org/1718693002
/external/skia/src/gpu/vk/GrVkImage.cpp