| 1e76464f87ea55a8749eb94b8e6c79638983d65a |
|
14-Oct-2016 |
Mike Klein <mtklein@chromium.org> |
Wrap SkNx types in anonymous namespace again.
This should make each compilation unit's SkNx types distinct from each other's as far as C++ cares. This keeps us from violating the One Definition Rule with different implementations for the same function.
Here's an example I like. Sk4i SkNx_cast(Sk4b) has at least 4 different sensible implementations:
- SSE2: punpcklbw xmm, zero; punpcklbw xmm, zero
- SSSE3: load mask; pshufb xmm, mask
- SSE4.1: pmovzxbd
- AVX2: vpmovzxbd
We really want all these to inline, but if for some reason they don't (Debug build, poor inliner) and they're compiled in SkOpts.cpp, SkOpts_ssse3.cpp, SkOpts_sse41.cpp, SkOpts_hsw.cpp... boom!
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3461
Change-Id: I0088ebfd7640c1b0de989738ed43c81b530dc0d9
Reviewed-on: https://skia-review.googlesource.com/3461
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/utils/SkCurveMeasure.cpp
|
| db085ab30f58928623447676c46d6bd7a8cc2255 |
|
17-Aug-2016 |
hstern <hstern@google.com> |
Fix bug in cubic derivative coefficient with missing parens
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242603002
Review-Url: https://codereview.chromium.org/2242603002
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 5a4b18c6f27fb010954e6435ddf22b85a3b84b94 |
|
11-Aug-2016 |
hstern <hstern@google.com> |
Add better bounds checks for getTime to fix perf debug assert below
Due to rounding, we request a length slightly larger than the total
length in MeasureBench. This will be fixed in a following CL and there
will be another CL adding unit tests for bounds checking and other
problems.
Revert "Revert 386ba54 and 4ab47e0 : perf debug assert."
This reverts commit 69aaa5a49a10454d573cbd8c5d980029d78ae459.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233983003
Review-Url: https://codereview.chromium.org/2233983003
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 69aaa5a49a10454d573cbd8c5d980029d78ae459 |
|
10-Aug-2016 |
halcanary <halcanary@google.com> |
Revert 386ba54 and 4ab47e0 : perf debug assert.
Revert "Refactor SkCurveMeasure to use existing eval code"
This reverts commit 4ab47e087ecfc82f070cbbaef4d9eb562d3fd163.
Revert "Fastpath lines in SkCurveMeasure"
This reverts commit 386ba540612defc7808edc28126b9b8afcf45b89.
TBR=
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233683004
Review-Url: https://codereview.chromium.org/2233683004
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 386ba540612defc7808edc28126b9b8afcf45b89 |
|
10-Aug-2016 |
hstern <hstern@google.com> |
Fastpath lines in SkCurveMeasure
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229403004
Review-Url: https://codereview.chromium.org/2229403004
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 4ab47e087ecfc82f070cbbaef4d9eb562d3fd163 |
|
10-Aug-2016 |
hstern <hstern@google.com> |
Refactor SkCurveMeasure to use existing eval code
- Use quad, cubic, conic eval code from SkGeometry.h
- Implement evaluateDerivativeLength, evaluateDerivative and evaluate switch cases for lines along with the refactor
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226973004
Review-Url: https://codereview.chromium.org/2226973004
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 80ac591f9928f36ea1dac80f34b9ad048e92ef73 |
|
10-Aug-2016 |
hstern <hstern@google.com> |
Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229893002
Review-Url: https://codereview.chromium.org/2229893002
/external/skia/src/utils/SkCurveMeasure.cpp
|
| 0446a3c8e2a5f1d525b3e0595252e64c6cd3a753 |
|
08-Aug-2016 |
hstern <hstern@google.com> |
Add initial CurveMeasure code
- This code is entirely private and is not being used by anything.
- In a future CL we will write a class that uses CurveMeasure to compute dash points. In order to determine whether CurveMeasure or PathMeasure should be faster, we need the dash info (the sum of the on/off intervals and how many there are)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187083002
Review-Url: https://codereview.chromium.org/2187083002
/external/skia/src/utils/SkCurveMeasure.cpp
|