History log of /external/skia/tools/debugger/SkDebugCanvas.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
d3b65972aad96453ff4510caa3e25a2b847c6d1e 22-Mar-2017 Brian Salomon <bsalomon@google.com> Mark overridden destructors with 'override' and remove 'virtual'

This silences a new warning in clang 5.0

Change-Id: Ieb5b75a6ffed60107c3fd16075d2ecfd515b55e8
Reviewed-on: https://skia-review.googlesource.com/10006
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/tools/debugger/SkDebugCanvas.h
fed9cfdc0216152d7fffe6d838ea7281466ffe74 17-Mar-2017 Mike Reed <reed@google.com> remove legacy virtual for vertices, only support object form

BUG=skia:6366

Change-Id: Ic422fa44a788d3488c050c6218dbfba188bb8f3e
Reviewed-on: https://skia-review.googlesource.com/9835
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
e88a1cb20e6b4c9f099070112225a88693a4630b 17-Mar-2017 Mike Reed <reed@google.com> Revert[2] "More SkVertices implementation work""

The fix was to release the array of vertices in the picturerecorder
destructor (where we also release textblobs etc.

This reverts commit 1eb3fef136bc75bd8e8ed717ec7c5d4ab26def62.

BUG=skia:

Change-Id: I3bf4acd6ad209205b0832a3cb7f94cd89dfcefc5
Reviewed-on: https://skia-review.googlesource.com/9826
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
1eb3fef136bc75bd8e8ed717ec7c5d4ab26def62 17-Mar-2017 Mike Reed <reed@google.com> Revert "More SkVertices implementation work"

This reverts commit 14583e11fd622c686993b741499060a6f3527055.

Reason for revert: leaking

Direct leak of 499104 byte(s) in 2112 object(s) allocated from:
#0 0x1e195f0 in operator new(unsigned long) (/b/swarm_slave/w/irazbR79/out/Debug/dm+0x1e195f0)
#1 0x3142b0a in SkVertices::Builder::init(SkCanvas::VertexMode, int, int, SkVertices::Sizes const&) (/b/swarm_slave/w/irazbR79/out/Debug/dm+0x3142b0a)


Original change's description:
> More SkVertices implementation work
>
> - change virtuals to take const SkVertices*, as we do for TextBobs and Images
> - override onDrawVerticesObject in recording canvases
> - deserialize raw-vertices into SkVertices object
>
> Possibly a follow-on would intercept the raw-form directly in canvas,
> and remove the virtual, and only support the object form.
>
> BUG=skia:6366
>
> Change-Id: I57a932667ccb3b3b004beb802ac3ae6898e3c6e0
> Reviewed-on: https://skia-review.googlesource.com/9633
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
>

TBR=bsalomon@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:6366

Change-Id: I40bb7a20698ef6aa0a9ef71a3d6ac4c1473e081c
Reviewed-on: https://skia-review.googlesource.com/9825
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
14583e11fd622c686993b741499060a6f3527055 16-Mar-2017 Mike Reed <reed@google.com> More SkVertices implementation work

- change virtuals to take const SkVertices*, as we do for TextBobs and Images
- override onDrawVerticesObject in recording canvases
- deserialize raw-vertices into SkVertices object

Possibly a follow-on would intercept the raw-form directly in canvas,
and remove the virtual, and only support the object form.

BUG=skia:6366

Change-Id: I57a932667ccb3b3b004beb802ac3ae6898e3c6e0
Reviewed-on: https://skia-review.googlesource.com/9633
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
199fb875c5e63c13233209e89b943c7ac7ab6665 06-Feb-2017 Brian Salomon <bsalomon@google.com> Add refcnt'ed immutable vertices class for SkCanvas::drawVertices.

Change-Id: I44a62f5efc674d0adbbf4a33690c3ded9fab3803
Reviewed-on: https://skia-review.googlesource.com/8040
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
42e8c53b3ef58f887a623b410d9783b4d4ab4921 23-Jan-2017 Mike Reed <reed@google.com> rename virtuals for clipbounds, and deprecate older bool/var-arg pattern

BUG=skia:

Change-Id: I08bcc2d0559e02838772538816b928e0716dd3aa
Reviewed-on: https://skia-review.googlesource.com/7412
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
ac42aebb7b49ef3d916da1e5a75b4c7cd4cfb119 12-Jan-2017 Stan Iliev <stani@google.com> Add support for drawImageLattice in SKIA debugger

Add support in SKIA debugger for SkCanvas.drawImageLattice calls.

Test: Tested with an SKP from android settings app.
Change-Id: I3f39f353dca8a3a2854241e7ef995d4d8c635f3e
Reviewed-on: https://skia-review.googlesource.com/6882
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
144a5c518ae921f210bdd9647c061e57d18f440c 20-Dec-2016 Brian Salomon <bsalomon@google.com> Rename batch->op in skiaserve

Change-Id: Ib831b9a6bcf4f37c0f077b26f68b1cefef81bb73
Reviewed-on: https://skia-review.googlesource.com/6351
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
c1f7774e8d327e3c98b4094c9c01d26e27013f71 09-Dec-2016 Mike Reed <reed@google.com> Revert[2] "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS"

This reverts commit a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72.

BUG=skia:

Change-Id: I717de6e5fcd4516aa684b014b1414b0f82ac2b91
Reviewed-on: https://skia-review.googlesource.com/5722
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
a129dfef2aaab0b5995cdf1ab7b2cdd41c29cf72 09-Dec-2016 Mike Reed <reed@google.com> Revert "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS"

This reverts commit 8e7432b7f98dd592e529a0c8bb038d73ebfb0478.

Reason for revert: <INSERT REASONING HERE>

external/skia/bench/../tools/android/SkAndroidSDKCanvas.h:103:36: error: C++ requires a type specifier for all declarations
void onClipRect(const SkRect&, ClipOp, ClipEdgeStyle) override;

Original change's description:
> remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS
>
>
> switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone
>
> BUG=skia:
>
> Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d
> Reviewed-on: https://skia-review.googlesource.com/5714
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
>

TBR=reed@google.com,reviews@skia.org
BUG=skia:
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: If26ea91d7464615e43c1d3d2f726e337ff56b55c
Reviewed-on: https://skia-review.googlesource.com/5721
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
8e7432b7f98dd592e529a0c8bb038d73ebfb0478 08-Dec-2016 Mike Reed <reed@google.com> remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS


switch over to SkClipOps now that SK_SUPPORT_LEGACY_CLIP_REGIONOPS is gone

BUG=skia:

Change-Id: Ifdc8b3746d508348a40cc009a4e529a1cb3c405d
Reviewed-on: https://skia-review.googlesource.com/5714
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
faba3715b8ddfaa0ce4df79bc8006e9bc7694e5b 03-Nov-2016 Mike Reed <reed@google.com> remove unused code around SK_SUPPORT_LEGACY_XFERMODE_PARAM

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4384

Change-Id: I5121acd027d935ade169ff65941f29f654a47bd0
Reviewed-on: https://skia-review.googlesource.com/4384
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
7d954ad797176afedb9262fdea4507d0fc60eb9d 28-Oct-2016 Mike Reed <reed@google.com> remove xfermode from public api

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4020

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Change-Id: I19cd056f2af778f10e8c6c2b7b2735593b43dbac
Reviewed-on: https://skia-review.googlesource.com/4020
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
c03e1c55a79f00d02ab528945425ff50cb700402 17-Oct-2016 Ben Wagner <bungeman@google.com> Re-enable overdraw mode in debugger.

Debugger is the last user of the deprecated SkPaintFilterCanvas
constructor. Stop using it and remove the constructor.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3268

Change-Id: I3e9180d48abdf86cb2c05bd8d95acabcdaa70427
Reviewed-on: https://skia-review.googlesource.com/3268
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/debugger/SkDebugCanvas.h
0f61faa7b7041efcedd1363b11b44fa97ad97448 11-Oct-2016 Mike Klein <mtklein@chromium.org> GN: windows compiles locally.

Not yet linking. Ignoring bots for now.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3200

Change-Id: Idd75033313df60844c2ba602f7845b3c52987bc2
Reviewed-on: https://skia-review.googlesource.com/3200
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/tools/debugger/SkDebugCanvas.h
73603f3c52ffd89fe9d035be827b566a0e7d3b79 20-Sep-2016 reed <reed@google.com> abstract name of clipping ops, to transtion to a more restricted set

SkRegion::Op --> SkCanvas::ClipOp (alias) --> SkClipOp

pre-CL needed in chrome : https://codereview.chromium.org/2355583002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355483002

Review-Url: https://codereview.chromium.org/2355483002
/external/skia/tools/debugger/SkDebugCanvas.h
e6f5d5623160a69e1585f5121a3695092327dfe0 25-Aug-2016 vjiaoblack <vjiaoblack@google.com> Made shadows blurry (thru implementing variance mapping)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224163005

Review-Url: https://codereview.chromium.org/2224163005
/external/skia/tools/debugger/SkDebugCanvas.h
ac3aa245acc7b469aa2f0d0078e53401d78ac8b9 19-Aug-2016 bsalomon <bsalomon@google.com> Plumb drawArc to SkDevice.

Plumbs the drawArc canvas method down to SkDevice without converting to a path. Plumbs through the various recording canvas classes.

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257023003

Review-Url: https://codereview.chromium.org/2257023003
/external/skia/tools/debugger/SkDebugCanvas.h
5bfee98c8cf59db8d71aa6672088b107f0abf8c9 22-Jul-2016 vjiaoblack <vjiaoblack@google.com> Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
Committed: https://skia.googlesource.com/skia/+/95302da19d8b0a3bcd9d9be0e79f486760787f09
Review-Url: https://codereview.chromium.org/2146073003
/external/skia/tools/debugger/SkDebugCanvas.h
95302da19d8b0a3bcd9d9be0e79f486760787f09 21-Jul-2016 vjiaoblack <vjiaoblack@google.com> Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
Review-Url: https://codereview.chromium.org/2146073003
/external/skia/tools/debugger/SkDebugCanvas.h
33d325890e549c113a258248002246b46e8040b2 21-Jul-2016 vjiaoblack <vjiaoblack@google.com> Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ )

Reason for revert:
Decided to re-wait for a final LGTM.

Already found a bug in variable naming to fix.

Original issue's description:
> Creating framework for drawShadowedPicture
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
>
> Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a

TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2167223002
/external/skia/tools/debugger/SkDebugCanvas.h
0ae097d116f4332be02a135ffc99c162473dee6a 21-Jul-2016 vjiaoblack <vjiaoblack@google.com> Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

Review-Url: https://codereview.chromium.org/2146073003
/external/skia/tools/debugger/SkDebugCanvas.h
e5de130788c8637d2f7df9ddb0241b78e04d5882 13-Jul-2016 vjiaoblack <vjiaoblack@google.com> Added the framework for having canvas/recorder/picture record depth_set's.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002

Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518
Committed: https://skia.googlesource.com/skia/+/1185d90c785f743364cc9113d7007a59af07470c
Review-Url: https://codereview.chromium.org/2127233002
/external/skia/tools/debugger/SkDebugCanvas.h
6e998e6137e6b25f047b5c5943f2b02485165e3e 13-Jul-2016 mtklein <mtklein@chromium.org> Revert "Added the framework for having canvas/recorder/picture record depth_set's."

1-click revert failed again.
This reverts commit 1185d90c785f743364cc9113d7007a59af07470c.

BUG=skia:

TBR=
NOTRY=true

Review-Url: https://codereview.chromium.org/2147963002
/external/skia/tools/debugger/SkDebugCanvas.h
1185d90c785f743364cc9113d7007a59af07470c 13-Jul-2016 vjiaoblack <vjiaoblack@google.com> Added the framework for having canvas/recorder/picture record depth_set's.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002

Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518
Review-Url: https://codereview.chromium.org/2127233002
/external/skia/tools/debugger/SkDebugCanvas.h
e504dbc092ec09c056ba3aa72693962a06d3aa4c 13-Jul-2016 mtklein <mtklein@chromium.org> Revert "Added the framework for having canvas/recorder/picture record depth_set's."

1-click revert failed.
This reverts commit 6d3fb898d5f73a82e36f11c712a633c3921ed518.

TBR=

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148543002

Review-Url: https://codereview.chromium.org/2148543002
/external/skia/tools/debugger/SkDebugCanvas.h
6d3fb898d5f73a82e36f11c712a633c3921ed518 12-Jul-2016 vjiaoblack <vjiaoblack@google.com> Added the framework for having canvas/recorder/picture record depth_set's.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002

Review-Url: https://codereview.chromium.org/2127233002
/external/skia/tools/debugger/SkDebugCanvas.h
45561a0b15fe045ba272c328684c3f7ae290785a 07-Jul-2016 reed <reed@google.com> drawTextRSXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004

Review-Url: https://codereview.chromium.org/2130643004
/external/skia/tools/debugger/SkDebugCanvas.h
97660ccbd10d83a2bb1fa88c672d17132649efef 29-Jun-2016 reed <reed@google.com> add annotations to debugger

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105113002

Review-Url: https://codereview.chromium.org/2105113002
/external/skia/tools/debugger/SkDebugCanvas.h
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 29-Mar-2016 halcanary <halcanary@google.com> Style bikeshed - remove extraneous whitespace

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002

Review URL: https://codereview.chromium.org/1842753002
/external/skia/tools/debugger/SkDebugCanvas.h
ae47aeeda09408989223291c54d12b2a98fa2b12 10-Mar-2016 joshualitt <joshualitt@chromium.org> Fix some bugs and performance issues with skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777203003

Review URL: https://codereview.chromium.org/1777203003
/external/skia/tools/debugger/SkDebugCanvas.h
46b301d2222b60dd5ab495b917dea163e8be94ef 02-Mar-2016 joshualitt <joshualitt@chromium.org> add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755563003

Review URL: https://codereview.chromium.org/1755563003
/external/skia/tools/debugger/SkDebugCanvas.h
5d5207a39e294e4e810685b2cff1d7c770e21b9c 29-Feb-2016 joshualitt <joshualitt@chromium.org> fix minor bug drawing batch bounds by default

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1746953002

Review URL: https://codereview.chromium.org/1746953002
/external/skia/tools/debugger/SkDebugCanvas.h
10d8fc29bc1605c134e98f5b58c2efb73cef6073 29-Feb-2016 joshualitt <joshualitt@chromium.org> Render batch bounds as stroke rects

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745063002

Review URL: https://codereview.chromium.org/1745063002
/external/skia/tools/debugger/SkDebugCanvas.h
6b3cf73af525fdbf6fd093304db840bb998e3dd6 17-Feb-2016 joshualitt <joshualitt@chromium.org> Add batch information to json

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002

Review URL: https://codereview.chromium.org/1705093002
/external/skia/tools/debugger/SkDebugCanvas.h
0a0520afccb9dcad9db2258c936456e69012fa34 12-Feb-2016 ethannicholas <ethannicholas@google.com> added clip visualization to skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690023004

Review URL: https://codereview.chromium.org/1690023004
/external/skia/tools/debugger/SkDebugCanvas.h
f8289d9bd1faff400728cb8e1ac0b1aa68bfbc32 11-Feb-2016 ethannicholas <ethannicholas@google.com> fixed off-by-one error in skiaserve /cmd
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683002

Review URL: https://codereview.chromium.org/1692683002
/external/skia/tools/debugger/SkDebugCanvas.h
db6a254bdcf6884db172f716966d7787e0d6f264 11-Feb-2016 joshualitt <joshualitt@chromium.org> wire up new json code in skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691773002

Review URL: https://codereview.chromium.org/1691773002
/external/skia/tools/debugger/SkDebugCanvas.h
402cd91f60bcf1a2f86f769bd02d79ace73770c9 10-Feb-2016 ethannicholas <ethannicholas@google.com> added SkDebugCanvas::toJSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684233002

Review URL: https://codereview.chromium.org/1684233002
/external/skia/tools/debugger/SkDebugCanvas.h
3cb954245cecf262d740a83913681b9fe4b41555 09-Feb-2016 ethannicholas <ethannicholas@google.com> moved debugger support files from src/utils/debugger to tools/debugger
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678893003

Review URL: https://codereview.chromium.org/1678893003
/external/skia/tools/debugger/SkDebugCanvas.h