History log of /external/toolchain-utils/crosperf/suite_runner.py
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
4e25342bd03fc8f5df7e4e4fe33649de82526730 14-Jan-2017 Manoj Gupta <manojgupta@google.com> Fix frequency pinning on crosperf.

Crosperf was pinning frequency to maximum based on cpu0
information. This does not work as intended for arm
Big-Little cores. Instead do it for each cpu based on its
own information.

BUG=chromium:680742
TEST=Tested on elm, kevin, falco, samus, peach_pit and veyron_jaq.

Change-Id: I77fc76d8f1e94563fe12b3555bf08511fdbfdc32
Reviewed-on: https://chromium-review.googlesource.com/428186
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
3fb928efb42405e386da41adf4bd674e86e23022 09-Jan-2017 Manoj Gupta <manojgupta@google.com> Fix test_that run for non-telemtry tests.

Do not add the autotest_dir argument to test_that
for non-telemetry tests.
Minor change: Remove a leftover print from download_images
unit test.

BUG: chromium:679001
TEST:crosperf unit tests
Change-Id: I0ff5365902af40097b61ae57d7c0d8d43ea308a8
Reviewed-on: https://chromium-review.googlesource.com/426073
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
70204447c3c103508f1b8e58d59a9b8f165e1c21 16-Dec-2016 Luis A. Lozano <llozano@google.com> Fix some lint warning in suite_runner*.

BUG=chromium:632113
TEST=run_tests

Change-Id: I9fe070420153f5ae175db86961c95b1686ea7c8f
Reviewed-on: https://chromium-review.googlesource.com/421107
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
c00e1d61dd82a9f9eab25e45b888b6f6966904b2 09-Nov-2016 Manoj Gupta <manojgupta@google.com> Fix crosperf crashes when running non-telemetry test on R53 or older images.

Do not call decrease wait time for non-telemetry tests.

BUG: chromium:663435
TEST:crosperf unit tests
Change-Id: Ia13eb8f258ab8fc09fdfbdb4b93a6745e06b44b1
Reviewed-on: https://chrome-internal-review.googlesource.com/303736
Commit-Ready: Manoj Gupta <manojgupta@google.com>
Tested-by: Manoj Gupta <manojgupta@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
4b133961b76c2cb8bc58f0ea2cded9e3438ffb6f 02-Nov-2016 Manoj Gupta <manojgupta@google.com> Download autotest files with crosperf and add autotest path to test_that
when running non-telemetry tests

BUG: chromium:647429
TEST:crosperf unit tests, sample experiment file that runs WebGl_Aquarium

Change-Id: I067e350fee36596ce269b954773c39a3868632aa
Reviewed-on: https://chrome-internal-review.googlesource.com/302296
Commit-Ready: Manoj Gupta <manojgupta@google.com>
Tested-by: Manoj Gupta <manojgupta@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
c39917fe61858e884d06656122cf88a8c66fd825 01-Nov-2016 Manoj Gupta <manojgupta@google.com> Update formatting of files before committing changes for autotest. No functional change.

BUG: chromium:647429
TEST: crosperf unit tests
Change-Id: I827f9ec4d00a0d8c1ae8a9930d7832289e694dc8
Reviewed-on: https://chrome-internal-review.googlesource.com/301457
Commit-Ready: Manoj Gupta <manojgupta@google.com>
Tested-by: Manoj Gupta <manojgupta@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
33da0c4d4b1186d1795dabb037de2e721b95a816 05-Oct-2016 Yunlian Jiang <yunlian@google.com> crosperf: fix the error unexpected keyword argument 'command'

BUG=none
TEST=the error is gone.

Change-Id: I8dad69d2b45ed821be0c7be77e07b33cf0663eb9
Reviewed-on: https://chrome-internal-review.googlesource.com/293515
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
9198db666212c457d231f2db6dd534d25f9bbc67 01-Oct-2016 Yunlian Jiang <yunlian@google.com> crosperf: Decrease 10 seconds delay for pagecyclers.

New telemetry adds 10 seconds delay after rendering a page.
We do not need that so this CL changes the 10 secnods delay
to 2 seconds.

BUG=None
TEST=the 10 seconds delay is changed to 2 seconds..

Change-Id: I5c835acdf4068fba1aceb0d2a5a45e7113a558d3
Reviewed-on: https://chrome-internal-review.googlesource.com/291818
Reviewed-by: Ting-Yuan Huang <laszio@google.com>
Commit-Queue: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
23e403298416d3036eab179a94d210441e69cc6e 22-Sep-2016 Caroline Tice <cmtice@google.com> Revert "[crosperf] Remove --autotest_dir arg from non-telemetry tests."

This reverts commit 70462462d54070a2440fccb506dcea2ea076cc05.

Upon further discussion I realize this is the wrong fix for this problem.

Change-Id: I7e9c94e763378e4834858acd826985c55bfcea4d
Reviewed-on: https://chrome-internal-review.googlesource.com/289636
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
70462462d54070a2440fccb506dcea2ea076cc05 16-Sep-2016 Caroline Tice <cmtice@google.com> [crosperf] Remove --autotest_dir arg from non-telemetry tests.

Some autotests that are not telemetry tests will fail if we pass
the --autotest_dir arg. This CL removes that arg from non-telemetry
tests.

BUG=chromium:647429
TEST=ran graphics_WebGLAquarium ok.

Change-Id: I00c79a6dc8cc4642b5b9dd342a92df91d0cb9c2c
Reviewed-on: https://chrome-internal-review.googlesource.com/287597
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
eff2fc1c86365c53ae228df4653524ceb6168d92 24-Feb-2016 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: fix remaining cros lint errors.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: I5566349cc97233e1ddb6d98121cd6f44e14bf0a9
Reviewed-on: https://chrome-internal-review.googlesource.com/249482
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
0d39863d8578fb1c6e7077b2c7cc5ca79edcf4dd 02-Feb-2016 Han Shen <shenhan@google.com> Fix lint for toolchain-utils.

Tested: run_tests.sh && cros lint on all the modified files.

Change-Id: Ife1e9620535f70849c58e932637b7b0f150b13ac
Reviewed-on: https://chrome-internal-review.googlesource.com/246650
Commit-Ready: Han Shen <shenhan@google.com>
Tested-by: Han Shen <shenhan@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
e7c6fbf9cfd5f45dda21f2c4742bf5a62589d2ed 16-Jan-2016 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: fix class-missing-docstring lint warnings.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: I0640cab2c8d15380badbfbc0db39e3063cc85471
Reviewed-on: https://chrome-internal-review.googlesource.com/244867
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
e57523abd8f2a5aa0b93f1248d6d969d0865781b 15-Jan-2016 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: fix module-missing-docstring lint warnings.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: Ifda134bf5f26db04551b915c189814b86e750df3
Reviewed-on: https://chrome-internal-review.googlesource.com/244866
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
3ebd06129a2d8cb9ff2301fffca77a9980989342 31-Dec-2015 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: fix docstring-leading-whitespace lint warnings.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: I5f8cb5a89faa8d7f17d7b20a2198317a6f89b6d1
Reviewed-on: https://chrome-internal-review.googlesource.com/243455
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
cbc5a2617f8d63e3319e159eab2c407952df1df9 31-Dec-2015 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: fix missing-print-function lint warnings.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: I2e0cf0d903b0ca7662132528ee6860ea8eaee83b
Reviewed-on: https://chrome-internal-review.googlesource.com/243412
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
278fc7437c8a31554903161eadfac2550507a47f 31-Dec-2015 Rahul Chaudhry <rahulchaudhry@chromium.org> toolchain-utils: apply pyformat to the source files.

BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.

Change-Id: I0cb94c77c26941fafb97cca2b9e9bb12cf4c210e
Reviewed-on: https://chrome-internal-review.googlesource.com/243411
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
f2a3ef46f75d2196a93d3ed27f4d1fcf22b54fbe 15-Dec-2015 Luis Lozano <llozano@chromium.org> Run pyformat on all the toolchain-utils files.

This gets rid of a lot of lint issues.
Ran by doing this:

for f in *.py; do echo -n "$f " ; if [ -x $f ]; then pyformat -i
--remove_trailing_comma --yapf --force_quote_type=double $f ; else
pyformat -i --remove_shebang --remove_trailing_comma --yapf
--force_quote_type=double $f ; fi ; done

BUG=chromium:567921
TEST=Ran simple crosperf run.

Change-Id: I59778835fdaa5f706d2e1765924389f9e97433d1
Reviewed-on: https://chrome-internal-review.googlesource.com/242031
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
036c9233742004aa773a374df381b1cf137484f5 10-Dec-2015 Luis Lozano <llozano@chromium.org> crosperf: RunCommand should return one type of object.

Cleaned up the interfaces for the RunCommand routines.
These were returning different types (int or tuple) depending on
the value of the return_ouput parameter.
Returning different unrelated types from a routine is bad practice.
Linter complains about this with several warnings like this:

"Attempting to unpack a non-sequence defined at line XY of
utils.command_executer"

BUG=chromium:566256
TEST=ran crosperf with a example experiment file
Ran run_tests.

Change-Id: Ibb83ab9322c87558077fc4937ef5c0686bbe5417
Reviewed-on: https://chrome-internal-review.googlesource.com/241459
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Han Shen <shenhan@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
7057cf67ba1dbdd4387f53e5fe47b43c955b1a53 10-Dec-2015 Caroline Tice <cmtice@google.com> Crosperf: Fix many broken unittests.

Apparently people have been making changes and not running the
unittests; many of the unittests were suffering from bit-rot. This
CL fixes most of the broken unittests (there are still 3 large ones
being worked on -- that will be in another CL).

BUG=chromium:567883
TEST=Verified that these unittests work now.

Change-Id: I0252a276a035894e70e04c61339cdba148c9bbfd
Reviewed-on: https://chrome-internal-review.googlesource.com/241513
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
d0b46129b0a60c84258a81d3dcce935cff6ba9c3 08-Dec-2015 Luis Lozano <llozano@chromium.org> Sort CPU frequencies before picking the highest one.

We need to sort the available frequencies before selecting
the highest one. The frequency list order changes from
board to board

BUG=chromium:564887
TEST=Verified by hand and on Jaq machine

Change-Id: Ief9ca216489fcf84b4c34688309b89be07d52c1c
Reviewed-on: https://chrome-internal-review.googlesource.com/240946
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
8df449353158325b7ce5c026c86098790cb06081 02-Dec-2015 Caroline Tice <cmtice@google.com> Make non-telemetry autotests run faster.

This CL adds some flags to the non-telemetry runs of test_that
which are already used with the telemetry tests, and which make
the autotest runs faster.

BUG=None
TEST=Tested in my directory with bvt tests.

Change-Id: I50e4bbefa9f7a66fcfff3b478386c23b17ac0ea3
Reviewed-on: https://chrome-internal-review.googlesource.com/240191
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
bd447043d50a8bc5f8cb29aee8c1933fb3e874bd 01-Oct-2015 Luis Lozano <llozano@chromium.org> Fixed several warnings reported by pylint.

Fixed most of warnings in command_executer.py.
There are a couple that are harder to fix and will require changes
in many files.
Was doing this to get an idea of how difficult would it be to
fix all the warnings in toolchain-utils directory.

BUG=None
TEST=Ran some benchmarks afterwards.

Change-Id: I11eec9e86317431b8ed7779d17e2dfae1be9f594
Reviewed-on: https://chrome-internal-review.googlesource.com/232829
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: David Sharp <dhsharp@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
45b53c5fee4c044cebd74dbbbd6119fbd51554e7 30-Sep-2015 Luis Lozano <llozano@chromium.org> Fixed some issues with signal handling and cleanup.

Fixed several issues related to signal handling and cleanup:
- Got rid of the extra process wrapper around crosperf. We now do an
"exec" to get rid of this extra process. This facilitated signal
handling.
- Found a better fix for the problem we had with ignoring
ctrl-c. Instead of creating a pipe for child process stdin, we now
create the child with setsid which has the side effect of creating the
child without a terminal associated to it (see man setsid).
- By creating the child with setsid, we also allow for easier killing of
the child and its descendants since it allows us to use killpg (see man
killpg).
- Handle SIGTERM by "converting" it into an exit call. This will make
sure the atexit routines are called and, furthermore, we can terminate
child process when you catch the "SystemExit" exception.
- With these changes, crosperf will send a SIGTERM to any cros_sdk,
test_that processes that it has started. Before, we would have left over
test_that processes that could interfere with a new test_that
invocation.

BUG=chromium:492826
BUG=chromium:470658
TEST=verified by hand signals are working. Ran toolchain suite.

Change-Id: Ibd09ff428a7b402ea2296ecf9b9a34aa5756c93f
Reviewed-on: https://chrome-internal-review.googlesource.com/232616
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
146058f65658cdf073cba7d5d12b082b2eb854f2 24-Jul-2015 cmtice <cmtice@google.com> Remove temp file that breaks telemetry.

Occasionally after running Telemetry, it will leave behind a
file in /tmp of your chroot (/tmp/telemetry@<machine_name>), which
will cause any later attempt to run telemetry on that machine to
fail, until the file is removed.

This CL checks for such a file, and if found deletes it, before
attempting to run the telemetry tests.

BUG=chromium:513875
TEST=Tested in my chroot with & without such a file.

Change-Id: I3e0a3000a1614f46f9312abddf77fd48b25334da
Reviewed-on: https://chrome-internal-review.googlesource.com/223812
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
bc2d3d13d2e1928217140a76acdf9f9917b1fa30 02-Jul-2015 Ting-Yuan Huang <laszio@google.com> Add 'run_local' to run the test harness locally.

The option 'run_local: True|False' will be passed into autotest.
For example, this is how test_that will be invoked:
test_that --arges="run_local=True ..." ...

BUG=None
TEST=Tested with the folllowing combinations.
benchmark: sunspider, smoothness.top_25_smooth
perf_args: record -e cycles,instructions / (none)

Change-Id: I7315027a7c9433d17a9f3fe54d7e8c3f480ea4f4
Reviewed-on: https://chrome-internal-review.googlesource.com/217370
Reviewed-by: Caroline Tice <cmtice@google.com>
Tested-by: Ting-Yuan Huang <laszio@google.com>
Commit-Queue: Ting-Yuan Huang <laszio@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
df76222bf1cbdbc42bb41934fb960bac8694eca4 19-May-2015 Luis Lozano <llozano@chromium.org> Added benchmark retry support.

We often get spurious failures from the benchmarks runs. This CL adds
support for a "retries" field that will automatically retry the benchmark
run by the amount specified.

BUG=None
TEST=Test by hand.

Change-Id: Ib881c40d766e67a7daf855ce9137d3e3d631f12e
Reviewed-on: https://chrome-internal-review.googlesource.com/217525
Reviewed-by: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
004bccbd890f184ea873ad6ab8260808e1e79988 21-Mar-2015 Luis Lozano <llozano@chromium.org> Use original autotest location for telemetry runs.

For telemetry benchmarks, there is not need for a board specific
version of autotest. There are no compiled tests. So it is easier to
use the "source" location of autotest. This avoid having to build
autotest for the specific board which can be time consuming.
This also fixes the problem where after doing a build, sometimes
the telemetry_Crosperf test cannot be found since there is no need
for the copy.

This does nothing regarding autotest compiled tests. These still need
to be under /build/<board>. If using downloaded image, we could also
download the auotest bits but we will probably need a new "mode" or
flag for crosperf to indicate we want to use the autotest bits that
come from the image and not the one in your chroot. So, more work is
required.

BUG=None
TEST=Tested by hand with multiple telemetry benchmarks.

Change-Id: Id669782a9612fad39326b4d820cbc8e78a8a3d0c
Reviewed-on: https://chrome-internal-review.googlesource.com/209980
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
5d7e21d72b17274a81a64a8040e1a30697e1223b 21-Mar-2015 Luis Lozano <llozano@chromium.org> Run telemetry tests with test_that fast mode.

test_that has a "fast" mode that avoids copying large syslog
data that is not used in the case of telemetry runs unless
we are using the autotest profiling functionality.

BUG=None
TEST=Tested with several telemetry benchmarks.

Change-Id: Ib90004099be9cd92b20c9fb0a5f1042068224e6d
Reviewed-on: https://chrome-internal-review.googlesource.com/209816
Reviewed-by: Caroline Tice <cmtice@google.com>
Tested-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
4f0309db0ba1f1d927d8c477afe253959180f6a7 15-Jun-2014 cmtice <cmtice@google.com> Add regression test for suite_runner.py

BUG=None
TEST=Ran regression test. Ran normal crosperf.

Change-Id: I35c5a83d691e0a2a9272422539afdc740e7828f6
Reviewed-on: https://chrome-internal-review.googlesource.com/166169
Reviewed-by: Han Shen <shenhan@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
57f71b3df9db76e45412da01511899b36db2e3fc 29-Apr-2014 cmtice <cmtice@google.com> Fix bug to now allow mounting chrome_src from inside chroot.

Crosperf was checking to see if chrome_src was inside the chroot, and
if so was not mounting it. This patch fixes that problem.

BUG=None
TEST=Tested with my new chroot (which doesn't have chrome source in
'normal' place).

Change-Id: Ide3273ca73aecffa28fa8d19a53f300eb957c29e
Reviewed-on: https://chrome-internal-review.googlesource.com/162009
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
226e3e08106dffd3086a7eee7007950a1d8ddfaf 28-Apr-2014 cmtice <cmtice@google.com> Fix small bugs with non-autotest Telemetry; other cleanups.

This CL fixes various small problems found during recent testing:
- Force show_all_results to be true for 'pure' telemetry case (the
results filtering needs the autotest results to work properly)
- Fix bug that was inserting extra 'src' into Chrome src path sometimes
- Since non-autotest Telemetry and non-Telemetry-Crosperf tests can't
handle 'perf' make it a Fatal error to call them with perf args.
- Add missing field to example experiment file.
- Add status output messages to downlaod_images.py for non-verbose logging.

BUG=None
TEST=Tested all these fixes on multiple test runs.

Change-Id: If8209356c695dc8b21f8627399a1cbd4a858df23
Reviewed-on: https://chrome-internal-review.googlesource.com/161759
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
98a53692fb946a8eac46e3e82257f540d1350c18 16-Apr-2014 cmtice <cmtice@google.com> Clean up Crosperf options and help.

Crosperf's help was completely out of date and incorrect. Fixed
that. Also, I cleaned up the options, removed some that were no
longer appropriate or not ever used, and made some options global-only.
Also removed all references to pyauto. We no longer use or run pyauto
tests.

Option changes: Completely removed outlier_range (it was not actually doing
anything), key_results_only (applied only to pyauto tests), use_test_that
(not needed now that we're not using pyauto) and md5sum (never used).
Made the following options global-only: rm_chroot_tmp, perf_args, logging_level,
show_all_results, board. Removed 'build' from global settings and made
it an image-only setting (it made no sense as a global setting).

I also adjusted the unittests to work with these changes.

BUG=None
TEST=I tested all the options in all their various positions; I tested with and
wtihout caching; and I tested local and official images. I also ran the unittests. Everything works.

Change-Id: I7653663f65c0a3363a1904c0220f1066e72c7f9d
Reviewed-on: https://chrome-internal-review.googlesource.com/160758
Reviewed-by: Bhaskar Janakiraman <bjanakiraman@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
139092449a545d4d87c06af3a6d8f3d71e42e927 11-Mar-2014 cmtice <cmtice@google.com> Add --logging_level option to crosperf.

Add --logging_level={verbose, average, quiet} option to crosperf,
optionally reducing the amount of logging output. "verbose" gives
the same output Crosperf always gave; "quiet" gives minimal output, and
"average" is in the middle. The default for now is "verbose". Doing this
also involved adding logging levels to the command_executer, and to
image_chromeos (again, with the default being "verbose").

BUG=None
TEST=Tested all three levels of logging, with and without having to
reimage the DUT. It all worked properly.

Change-Id: Icf8c9a6831fe25202adcb624c6c7e1d1a7ac25a5
Reviewed-on: https://chrome-internal-review.googlesource.com/156883
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
fd0b178bef64de689ce86c3cc471daa219bf601f 13-Feb-2014 Han Shen <shenhan@chromium.org> Use 'scaling_max_freq' when 'scaling_available_frequencies' is not available.

In recently arm images, there is no such
'scaling_available_frequencies' file, which leads failure of
crosperf. Fixed this by choosing 'scaling_max_freq'.

TEST=tested on daisy
BUG=None

Change-Id: I433e161495421c57854234fd0e7f7e54406bb9e8
Reviewed-on: https://chrome-internal-review.googlesource.com/154579
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Han Shen <shenhan@google.com>
Tested-by: Han Shen <shenhan@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
e5a746fb9ba7ddb8827f73f030bf99f798ffcf9e 25-Nov-2013 cmtice <cmtice@google.com> Add the ability to pass arguments through test_that to Telemetry's
run_benchmark.

BUG=None
TEST=I have tested this with my own crosperf, and test_that is passing the
arguments along properly. The telemetry_Crosperf autotest also needs to
be updated before this completely works.

Change-Id: Ic887380b297d966229ac21ba4e7e909e7248fcb0
Reviewed-on: https://chrome-internal-review.googlesource.com/148485
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
5f3ccbddaaf5f4a64431c9e68faf83a348ecdfdd 21-Nov-2013 cmtice <cmtice@google.com> Update report generation to check for a 'perf_measurements' file.

The latest version of telemetry_Crosperf generates a perf_measurements
file, containing the test results, rather than a keyval file. This CL
checks for perf_measurements, and reads it, if it is there. This
change is backwards compatible with the older versions of telemetry_Crosperf
that used the keyval file.

BUG=None
TEST=Tested this with the results only in a keyval file and only in a
perf_measurements file. Got acceptable test reports either way.

Change-Id: If10a62b2f7fbe89d35c1ebe789a81764c9d134e4
Reviewed-on: https://chrome-internal-review.googlesource.com/148295
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
a1d03083c46175d9a34ea3665a3b1e305607442b 23-Oct-2013 cmtice <cmtice@google.com> Accept hyphens in test names; fix profiler args string.

Updated regular expression parser to accept hyphens in the test names.
Also fixed the quotes on profiler args, for proper parsing by
test_that.

BUG=None
TEST=Ran crosperf successfully with benchmark name that had hyphen in it;
successfully ran crosperf with profiler args.

Change-Id: I4a154e390a5fabfc47e0783212fed928eb5e9873
Reviewed-on: https://chrome-internal-review.googlesource.com/146967
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
53c88e9dd49958e2b20db2e06074198c8c3768da 09-Oct-2013 Luis Lozano <llozano@chromium.org> Pin max and min frequencies on machine before running experiment.

Find out what is the highest static frequency (turbo mode is
considered a dynamic frequency) and set the min and max frequency
to the highest static. This reduces benchmark noise in particular
for some machines like daisy and lumpy i5.

BUG=None
TEST=Tested with runs of perf_v2. Verified frequencies are pinned.

Change-Id: Idd0627a0f53fa986d0ccf1da2bee53d51a5c8ccb
Reviewed-on: https://chrome-internal-review.googlesource.com/146206
Reviewed-by: Simon Que <sque@google.com>
Tested-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
/external/toolchain-utils/crosperf/suite_runner.py
f8b3a5ada4ae7c60d459fc843b1809acd7726613 25-Sep-2013 Caroline Tice <cmtice@chromium.org> Allow "." in benchmark names; Allow multiple test sets.

This fixes a few minor problems with crosperf:

1). When using run_remote_tests.sh, it adds the "--use_emerged" flag,
which is a recent requirement.
2). It updates the regular expression parsing to not mess up escaped
characters, and to allow "." in benchmark names (common in Telemetry).
3). It allows there to be multiple "sets" of benchmarks that can be
specified together, e.g. perfv2 or pagecyclers (or more in the future).

BUG=None
TEST=I've run all the various telemetry_Crosperf variations (individual
perf_v2 tests; individual telemetry page cycler tests; 'all_perf v2', and
'all_pagecyclers'.

Change-Id: Idd45caa6487780b92b8eb321b37b873978f96dca
Reviewed-on: https://chrome-internal-review.googlesource.com/145305
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
92774196e083e04b954d02f8d463998d549269eb 11-Sep-2013 Caroline Tice <cmtice@chromium.org> Update crosperf to run telemetry test via autotest.

This updates crosperf to recognize the suite 'telemetry_Crosperf',
which allows users to run telemetry performance tests via test_that
and the telemetry_Crosperf autotest. This won't be usable in general until
CL 168491 (the telemetry_Crosperf CL) gets committed.

BUG=None
TEST=Invoked telemetry tests using this change.

Note: Profilers don't quite work properly with telemetry_Crosperf yet,
but everything else does.

Change-Id: Id14edc89db79bc244496e8f6a5b614300a00be54
Reviewed-on: https://chrome-internal-review.googlesource.com/144440
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
b47bff4d3336c5fe5593a95963c0f3dc20a02f68 20-Aug-2013 Caroline Tice <cmtice@chromium.org> Make test_that available for running tests.

Add a new flag, --use_test_that=True/False, to crosperf, to allow users to
tell crosperf to use the test_that script rather than the run_remote_tests.sh
script for running their tests.

BUG=None
TEST=Tested with and without the flag, to verify that it does the right thing.

Change-Id: I1a040d23adbf364b4a47320d9fd759a2d46e6689
Reviewed-on: https://gerrit-int.chromium.org/43109
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
6aa8528c03697a1f28186c574d512c19935676a5 07-Aug-2013 Caroline Tice <cmtice@chromium.org> Fix syntax error in suite_runner.py, to allow crosperf to run "pure"
Telemetry tests.

Change-Id: Ie6073c05fdc50cf22294816b6be37811652b6827
Reviewed-on: https://gerrit-int.chromium.org/42444
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
fefa5c0174b32eb359eca91acebab772356a4473 03-Jul-2013 Yunlian Jiang <yunlian@google.com> crosperf: use run_measurement to run telemetry.

Use run_measurement instead of run_multipage_benchmark,
since run_multipage_benchmark is depreciated.

BUG=chromium:256865
TEST=None

Change-Id: I37c86b9d3ece40ff4980d53b262b657ae9e1ae0d
Reviewed-on: https://gerrit-int.chromium.org/40549
Commit-Queue: Yunlian Jiang <yunlian@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py
04dc5dc8547dbfbe524cf35ac39537346ad749bb 24-Apr-2013 Yunlian Jiang <yunlian@google.com> Adding support of telemetry to crosperf

BUG=None
TEST=run crosperf with pyauto/telemetry test with/without cache.
all pass.

Change-Id: If07ac020a9107a79d5780a58fd6dcc924d07f07f
Reviewed-on: https://gerrit-int.chromium.org/36594
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
Reviewed-on: https://gerrit-int.chromium.org/39241
Reviewed-by: Yunlian Jiang <yunlian@google.com>
/external/toolchain-utils/crosperf/suite_runner.py