History log of /external/toybox/toys/posix/find.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
86aca0458598bf68f3264b70b0eddb19ece7edd3 20-Dec-2016 Rob Landley <rob@landley.net> Add units for -atime and friends. (Also legacy -amin alias, but not in help text
because there's no -asec or -ahour.)
/external/toybox/toys/posix/find.c
3d64b0cc95c5957e53474c3e50f143c61a057104 19-Aug-2016 Rob Landley <rob@landley.net> Change xgetpwnamid/xgetgrnamid to xgetuid/xgetgid returning the id number
instead of a struct. This means it can return "12345" even if that user/group
doesn't exist in /etc/passwd and similar.

All the users were immediately dereferencing it to get pw_uid or gr_gid
anyway, so just return it directly and adjust the users. This fixes
things like "chown 12345:23456 filename".
/external/toybox/toys/posix/find.c
027a73a903af306449710ce12bc09e0e3550c6c9 04-Aug-2016 Rob Landley <rob@landley.net> Make xopen() skip stdin/stdout/stderr, add xopen_stdio() if you want stdout,
add xopenro() that takes one argument and understands "-" means stdin,
and switch over lots of users.
/external/toybox/toys/posix/find.c
76cc2e2bcddef47176dfeef59c5d4ba28880f219 12-Jul-2016 Rob Landley <rob@landley.net> Implement NOP find -noleaf
/external/toybox/toys/posix/find.c
b602f1c1513328fe91f70233c78d11d9e638982d 20-May-2016 Rob Landley <rob@landley.net> Add bufgetgrgid()
/external/toybox/toys/posix/find.c
442c1853d1556610e96e41babdfb7b706f3d2ccf 25-Apr-2016 Rob Landley <rob@landley.net> Fix find bug reported by Tom Marshall, add test for it, and while we're at it
fix two tests looking for a too-specific error message (so TEST_HOST failed).
/external/toybox/toys/posix/find.c
8d95074b7d034188af8542aaea0306d3670d71be 07-Mar-2016 Rob Landley <rob@landley.net> Cleanup pass on the dirtree infrastructure, in preparation for making rm -r
handle infinite depth. Fix docs, tweak dirtree_handle_callback() semantics,
remove dirtree_start() and don't export dirtree_handle_callback(), instead
offer dirtree_flagread(). (dirtree_read() is a wrapper around dirtree_flagread
passing 0 for flags.)
/external/toybox/toys/posix/find.c
0f11b42938f4ae32b2c80b1c0644b75e64da4ada 05-Feb-2016 Rob Landley <rob@landley.net> Another fix from Josh Gao to avoid a null pointer dereference, and
minor cleanup of previous commit.
/external/toybox/toys/posix/find.c
2fd8d1a2595ee49f01d2987b125b642b7f50ea65 04-Feb-2016 Josh Gao <jmgao@google.com> Fix segfault when `find -iname` gets no argument.
/external/toybox/toys/posix/find.c
8aee3e5b5e774e3d79951d240e08384590811ffc 01-Feb-2016 Rob Landley <rob@landley.net> Add find -delete
/external/toybox/toys/posix/find.c
192155553c01f39a774d169cb3b28dc5c7417c08 14-Jan-2016 Rob Landley <rob@landley.net> Make "find -execdir toys echo {} +" batch correctly and show topdir results.

I dunno if find -execdir should show depth-first like it's doing, bit given
that ubuntu's treating "+" and ";" the same for execdir... eh?

Also, testing "find toys tests -mindepth 2 -execdir echo {} +" against
the toybox source is easy (and why if (revert) fchdir() is needed), but
adding that to the test suite means making a nontrivial hierarchy of files
to test against (don't wanna use the project source because it's expected
to change in ways that would break the tests)... The old "real world data
vs test data" problem.
/external/toybox/toys/posix/find.c
80c6b26efd4eaf091c44c0c4b5dbaa778cfdfa8e 05-Jan-2016 Rob Landley <rob@landley.net> Work towards making "find . -execdir echo {} + -execdir ls {} +" work,
(not finished yet) plus some error message improvements.
/external/toybox/toys/posix/find.c
3d33dd80f8cb931e293d7f64c44bc357fec11120 02-Jan-2016 Rob Landley <rob@landley.net> Fix find --prune.
/external/toybox/toys/posix/find.c
aa784b09a9fbbbd571130051405edeaea7c9b510 02-Jan-2016 Rob Landley <rob@landley.net> Fix "find . -exec echo {}" segfault, and stop measuring environment space,

The segfault was spotted/fixed by Daniel K. Levy back in September, and again by
Isabella Parakiss yesterday. While we're there, remove the environment
size measurement code (the 128k limit was lifted by linux commit b6a2fea39318,
which went into 2.6.22 released July 2007).
/external/toybox/toys/posix/find.c
d336af4180542c9d526dece02d1a27232ef1ca6a 07-Dec-2015 Rob Landley <rob@landley.net> Rename dirtree->data to dirfd, and don't store symlink length in it.
/external/toybox/toys/posix/find.c
f49f291939afae44bda438bf2509c7ba20a2a78f 13-Nov-2015 Gilad Arnold <garnold@google.com> Enable matching any perm bits.

Includes tests for the new feature, and a failure case for the minimal
perms test as well.

Also some typo fixing / massaging the help text so it fits in 80
columns.
/external/toybox/toys/posix/find.c
0f3d8ee513d63282e72df37b97e35ff1a4e4d646 13-Nov-2015 Elliott Hughes <enh@google.com> Fix find -perm.

1) It read st_dev instead of st_mode.
2) It reversed the semantics of absolute vs minimal ('-' prefixed) tests.

Add tests for these, and move the "unterminated -exec" test into the "Still
fails" section because it's still dumping core for me.
/external/toybox/toys/posix/find.c
edae0b07db841e3bf8449d591971f04c9957ecbc 12-Sep-2015 Rob Landley <rob@landley.net> Fix a find segfault.

Elliott Hughes found a bug https://android-review.googlesource.com/#/c/170020/
and Daniel K. Levy worked out the problem: the user/group/newer arguments
to find weren't consuming their arguments when not checking the results of
their comparison (because an earlier test had already caused their
parenthetical group to fail). This confused the argument parsing logic
and could lead to segfaults.

I applied a different fix that reorganized the existing tests instead of
adding a new test. (Looks like a big commit but it's mostly whitespace
due to extra curly brackets changing indendentation levels.)
/external/toybox/toys/posix/find.c
b1353fb9185928249f273340c601244291e269fe 08-Sep-2015 Rob Landley <rob@landley.net> Remove prompt argument from yesno(), caller can fprintf(stderr, "blah") itself.

This fixes the build break, the change to yesno() prototype accidentally got
checked in last commit. (Oops, sorry.)
/external/toybox/toys/posix/find.c
7cc95a79a7a4ed8fb8fb3c5e1946a59c93ff335e 01-Aug-2015 Rob Landley <rob@landley.net> Move strlower() from find to lib.
/external/toybox/toys/posix/find.c
d1a577f7bd2148f29a1dff37684ea9c63024fe6e 10-Jul-2015 Greg Hackmann <ghackmann@google.com> find: add -inum option

-inum is a commonly implemented extension to search by inode number.

Linux's fs-layer tracepoints log many events in terms of inodes, so
"find -inum" is useful for mapping those events back to specific files.
/external/toybox/toys/posix/find.c
1f5f436826505df6dfabe1de9724424fc40fae23 10-May-2015 Rob Landley <rob@landley.net> Cleanups of dirtree_start() calls. (Don't need to feed in flag values, just
symfollow true/false.)
/external/toybox/toys/posix/find.c
aab9164df395a4b0878b0ad930a5ec8a806a58e9 10-May-2015 Rob Landley <rob@landley.net> Add DIRTREE_SHUTUP to disable dirtree warnings if file vanishes out from
under traversal. Pass through full flag set in dirtree_add_node(), add
dirtree_start() wrapper to provide symlink-only behavior (avoiding a lot
of DIRTREE_SYMFOLLOW*!!(logic) repeated in callers).
/external/toybox/toys/posix/find.c
33f04551f3c9a5182aabe9dfe36d6a0b88298686 21-Mar-2015 Rob Landley <rob@landley.net> Another bug from David Halls: find -exec wasn't consuming its argument when it didn't activate.

test: find . -name README -exec echo one '{}' ';' -or -exec echo two '{}' ';'
/external/toybox/toys/posix/find.c
be4048dd2509f2b9e968a4d03c06050d847971d3 12-Mar-2015 Rob Landley <rob@landley.net> Make find accept numeric uid/gid, and simplify makedevs using the new infrastructure.
/external/toybox/toys/posix/find.c
38e5485c6a8ece99aa8aac2f318f14764857ee24 03-Mar-2015 Rob Landley <rob@landley.net> On 64 bit, subtracting two pointers produces a long result. On 32 bit, it's an int. Even though long _is_ 32 bits on a 32 bit systems, gcc warns about it because reasons.

Also, the warning being that "expects int, but type is wchar_t"... no, type
is not wchar_t. Type is probably long. Specify the ACTUAL TYPE, not the random
typedef alias for it. If the translated type _did_ match, there wouldn't
be a warning! (This is why c89 promoted all arguments to int, precisely
so this wasn't a problem.)
/external/toybox/toys/posix/find.c
f6c28b6e0017ac36190ee31132721a1c9e30f2b6 22-Nov-2014 Rob Landley <rob@landley.net> As long as Android's going to require fortify, fixup the warnings it generates.
/external/toybox/toys/posix/find.c
a6336b942302b92f0b65ec35299e7667b9fcbe19 15-Sep-2014 Rob Landley <rob@landley.net> find -xdev should return mount points, just not contents.
/external/toybox/toys/posix/find.c
360d57f843f5435a75270e54583430dcb8f62546 14-Sep-2014 Rob Landley <rob@landley.net> Split xpopen() into xpopen_both(), xpopen(), and xrun() depending on whether we want to redirect both, one, or neither of stdin/stdout.
/external/toybox/toys/posix/find.c
6634e46216410161f0f56dc54b16da2de6a8f2b3 08-Sep-2014 Rob Landley <rob@landley.net> Add error test and fix memory leak, reported by Ashwini Sharma.
/external/toybox/toys/posix/find.c
c572530223ddad725e0f7606bf4b898d8f95f640 08-Aug-2014 Rob Landley <rob@landley.net> Fix -mindepth and -maxdepth to not drill down into excluded directories.

The fact other implementations don't implement "! -mindepth" doesn't mean we can't. Also, find uses +N, N, -N for everything else but this extension doesn't. Also, -depth already had a definition and this has nothing to do with that. It's a poorly thought-out extension, is what I'm saying.
/external/toybox/toys/posix/find.c
c39a337101de8613e71c5c474feb54297cce5eaa 06-Aug-2014 Rob Landley <rob@landley.net> More find bugfixes.
/external/toybox/toys/posix/find.c
5e4787ea3144364983944c38eb2a5ab2f12351bc 06-Aug-2014 Rob Landley <rob@landley.net> Rereading posix find.c page: "Specifying more than one of the mutually-exclusive options -H and -L shall not be considered an error. The last option specified shall determine the behavior of the utility."
/external/toybox/toys/posix/find.c
6804d2324ff2524cdf9ac013cb2b6b72c2295117 06-Aug-2014 Rob Landley <rob@landley.net> find.c: Posix wants loop detection.
/external/toybox/toys/posix/find.c
2c2eaba63fd42442453b1ad87fadc7d02532ea28 06-Aug-2014 Rob Landley <rob@landley.net> Building busybox from source needs find -not (a synonym for posix's "!").
/external/toybox/toys/posix/find.c
4edcd084f4782518249b888efc5d8f965bd5742e 05-Aug-2014 Rob Landley <rob@landley.net> find.c: add -mindepth, -maxdepth, and document -newer and -depth.
/external/toybox/toys/posix/find.c
60c35c486a2ea1c6ea8920c599abf992b27542c5 03-Aug-2014 Rob Landley <rob@landley.net> Implement exec -user, -group, and -newer. Enable find in defconfig.
/external/toybox/toys/posix/find.c
e686dcc30ba4505f813b9f5ccfa8ed9cf8644d3f 03-Aug-2014 Rob Landley <rob@landley.net> Unbreak find -exec.
/external/toybox/toys/posix/find.c
b3c2d1cd4ef97f200bb7b668ae4c3be06d59063c 31-Jul-2014 Rob Landley <rob@landley.net> find.c: fix -iname.
/external/toybox/toys/posix/find.c
fd14a61e941828c580bd476bb51f371f3d1ddf09 30-Jul-2014 Rob Landley <rob@landley.net> find.c: first pass at case case insensitivity and exec. (Needs more debugging.)
/external/toybox/toys/posix/find.c
a873444aa3e57d05c639c849a41a2add146f0309 19-Jul-2014 Rob Landley <rob@landley.net> Find bugfixes.

The check for -print vs -print0 was tested before I optimized out the "-" in the strcmps, and I didn't adjust the offset or retest it. (Ooops.)

Also, I wasn't clearing the ! value when descending into parentheticals, so "find . -name blah -o \! \( -stuff -o -thing \)" acted like it had a spurious second ! before -stuff inside the parentheses.
/external/toybox/toys/posix/find.c
fc7bc38af05fc882472d310a0b68648ed990ef2d 17-Jul-2014 Rob Landley <rob@landley.net> Write a new find. Not quite done, but the basics work.
/external/toybox/toys/posix/find.c