| 1b40a9a8afe0d7b2244ad8dea19e8222fec3c207 |
|
12-Oct-2015 |
Magnus Jedvert <magjed@webrtc.org> |
RefCountInterface: Make AddRef() and Release() const
This CL makes AddRef() and Release() const member methods and the refcount integer mutable. This is reasonable, because they only manage the lifetime of the object, and this is also how it's done in Chromium.
The purpose is to be able to capture a const pointer in a scoped_refptr, which is currenty impossible. The practial problem this CL solves is this:
void Foo::Bar() const {}
rtc::Callback0<void> Foo::MakeClosure() const {
return rtc::Bind(&Foo::Bar, this);
}
We currently capture |this| as const Foo*. With this CL, |this| will be captured as scoped_refptr<const Foo>.
A test is also added in bind_unittest to check this behaviour.
BUG=webrtc:5065
R=perkj@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1403683004 .
Cr-Commit-Position: refs/heads/master@{#10253}
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 4765070b8d6f024509c717c04d9b708750666927 |
|
30-May-2015 |
Miguel Casas-Sanchez <mcasas@webrtc.org> |
Rename I420VideoFrame to VideoFrame.
This is a mechanical change since it affects so many
files.
I420VideoFrame -> VideoFrame
and reformatted.
Rationale: in the next CL I420VideoFrame will
get an indication of Pixel Format (I420 for
starters) and of storage type: usually
UNOWNED, could be SHMEM, and in the near
future will be possibly TEXTURE. See
https://codereview.chromium.org/1154153003
for the change that happened in Cr.
BUG=4730, chromium:440843
R=jiayl@webrtc.org, niklas.enbom@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/52629004
Cr-Commit-Position: refs/heads/master@{#9339}
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 2056ee3e3c7683ae4b2c4b12da99c3105c4f46a9 |
|
16-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Revert "Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*."
This reverts commit r8731.
Reason for revert: Breakes Chromium FYI bots.
TBR=hbos, tommi
Review URL: https://webrtc-codereview.appspot.com/40359004
Cr-Commit-Position: refs/heads/master@{#8733}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8733 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 2dc5fa69b2baef2ece158c9e1285516087faaa53 |
|
16-Mar-2015 |
hbos@webrtc.org <hbos@webrtc.org> |
Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*.
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40299004
Cr-Commit-Position: refs/heads/master@{#8731}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8731 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 14665ff7d4024d07e58622f498b23fd980001871 |
|
04-Mar-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
Clang version changed 223108:230914
Details: https://chromium.googlesource.com/chromium/src/+/e144d30..6fdb142/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 5a7dc39277999cbfa0da053da5eacc7fee5cd307 |
|
13-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
This is a code clean up. No functional change intended.
Consolidate the enum for capturer/frame rotation we use through out the code base.
BUG=4145
R=mflodman@webrtc.org, perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39859004
Cr-Commit-Position: refs/heads/master@{#8365}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8365 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 1226e926e6104322d9b99026b98f515cb4d40fd4 |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Committed: https://code.google.com/p/webrtc/source/detail?r=8338
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8339}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8339 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| dc7b02277cc1666dfc13b636c2ecfe53b12c9d2a |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8338}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8338 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 20e8f227664a6747cea11e1fc1de4c018ebcc8e9 |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8337}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8337 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 4161715e3f7e744bc9ef3d3ae437da1e8e4de38d |
|
29-Jan-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Remove ChangeUniqueID.
This fixes a two year old TODO of deleting dead code :)
In cases where the _id or id_ member variable is being used for tracing,
I changed the member to at least be const.
It doesn't look like id's are that useful anymore so maybe the next step is to get rid of them.
BUG=
R=henrika@webrtc.org, perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37849004
Cr-Commit-Position: refs/heads/master@{#8201}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8201 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 5f93d0a140515e3b8cdd1b9a4c6f5871144e5dee |
|
20-Jan-2015 |
jlmiller@webrtc.org <jlmiller@webrtc.org> |
Update libjingle license statements at top of talk files for consistency
BUG=2133
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8105 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 0b1534c52eab79372557a6d81aaf4dd9407f55d3 |
|
15-Dec-2014 |
pkasting@chromium.org <pkasting@chromium.org> |
Use int64_t for milliseconds more often, primarily for TimeUntilNextProcess.
This fixes a variety of MSVC warnings about value truncations when implicitly
storing the 64-bit values we get back from e.g. TimeTicks in 32-bit objects, and
removes the need for a number of explicit casts.
This also moves a number of constants so they're declared right where they're used, which is easier to read and maintain, and makes some of them of integral type rather than using the "enum hack".
BUG=chromium:81439
TEST=none
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7905 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 1972ff8a6e45f7ad3fb7e4ed51dc0135c72f6c9d |
|
11-Sep-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org> |
Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions). I've removed some of
these.
This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class. Removed "virtual" in those
cases.
BUG=none
TEST=none
R=andrew@webrtc.org, henrik.lundin@webrtc.org, mallinath@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 0d34f1446a93f964cf6e221ca0ebd63935950b14 |
|
02-May-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 66033941-> 66098243
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6044 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 9cf037b83184374230c6825e4aa407cdafaba434 |
|
07-Feb-2014 |
sergeyu@chromium.org <sergeyu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 61168196
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 67ee6b9a6260fa80b83326c4b4fec8857c0e578c |
|
03-Feb-2014 |
mallinath@webrtc.org <mallinath@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 60923971
Review URL: https://webrtc-codereview.appspot.com/7909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 7433a088d2e97993266b66c102b0866aa90b4424 |
|
29-Jan-2014 |
mallinath@webrtc.org <mallinath@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 5444 "Revert 5421 "Fix deadlock on register/unregister ob..."
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.
TBR=andresp@webrtc.org
> Revert 5421 "Fix deadlock on register/unregister observer while ..."
>
> Failure to compile on Chromium Internal bots, because of API changes.
>
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
>
> You need to follow the steps mentioned in
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
>
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
>
> > Fix deadlock on register/unregister observer while there is a an going callback.
> >
> > BUG=2835
> > R=mallinath@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/7119005
>
> TBR=andresp@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7679004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 18586d38bcc90fa47f76e0bb54881dd889751167 |
|
27-Jan-2014 |
mallinath@webrtc.org <mallinath@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 5421 "Fix deadlock on register/unregister observer while ..."
Failure to compile on Chromium Internal bots, because of API changes.
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
You need to follow the steps mentioned in
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.
> Fix deadlock on register/unregister observer while there is a an going callback.
>
> BUG=2835
> R=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7119005
TBR=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 8d375c95b76263b7766b10fa38eb8b97c99e1682 |
|
24-Jan-2014 |
andresp@webrtc.org <andresp@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix deadlock on register/unregister observer while there is a an going callback.
BUG=2835
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7119005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|
| 28e20752806a492f5a6a5d343c02f9556f39b1cd |
|
10-Jul-2013 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds trunk/talk folder of revision 359 from libjingles google code to
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/media/webrtc/fakewebrtcvideocapturemodule.h
|