| 4331fcd51736b030f30c31a35c732f119b31b6fc |
|
07-Jan-2016 |
jbauch <jbauch@webrtc.org> |
Remove duplicate code in SocketDispatcher
This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.
Here the duplicate implementations are merged with only some #ifdef parts.
BUG=
Review URL: https://codereview.webrtc.org/1537273002
Cr-Commit-Position: refs/heads/master@{#11160}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 095ae15d6b9ff60357b44ed6f4997754079eff2e |
|
18-Dec-2015 |
jbauch <jbauch@webrtc.org> |
Keep listening if "accept" returns an invalid socket.
There is an issue in PhysicalSocket::Accept where the flag to continue
listening is not set in "enabled_events_" if "accept" returns an error.
This CL fixes this (initial idea by silviu.cpp@gmail.com).
BUG=webrtc:2030
Review URL: https://codereview.webrtc.org/1452903006
Cr-Commit-Position: refs/heads/master@{#11080}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 5237aaf243d29732f59557361b7a993c0a18cf0e |
|
11-Nov-2015 |
tfarina <tfarina@chromium.org> |
Convert usage of ARRAY_SIZE to arraysize.
ARRAY_SIZE is the old version of arraysize and does not cover
all the cases in C++, arraysize is a copy of Chromium's
version and thus have wider coverage.
BUG=None
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1405023016
Cr-Commit-Position: refs/heads/master@{#10594}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 20a34619080005c3b0e49d85b307113ea2b180c3 |
|
03-Nov-2015 |
tfarina <tfarina@chromium.org> |
Remove deprecated IsUnresolved() method from SocketAddress API.
This patch removes IsUnresolved() method and update the clients to use
IsUnresolvedIP() instead.
BUG=None
R=perkj@webrtc.org
TBR=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1414793006
Cr-Commit-Position: refs/heads/master@{#10487}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| a41ab9326c8f0f7eb738e5d51a239a2b9e276361 |
|
31-Oct-2015 |
tfarina <tfarina@chromium.org> |
Switch usage of _DEBUG macro to NDEBUG.
http://stackoverflow.com/a/29253284/5237416
BUG=None
R=tommi@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1429513004
Cr-Commit-Position: refs/heads/master@{#10468}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 8ac544e811439f79b2ec0c676f383ddc51ef2ed5 |
|
08-Oct-2015 |
tfarina <tfarina@chromium.org> |
Get rid of deprecated SocketAddress::IsAny() method.
This patch converts the usage of IsAny() to IsAnyIP() and removes the
deprecated method.
BUG=None
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1392153002
Cr-Commit-Position: refs/heads/master@{#10220}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 469c2c04aae3e8446ba35f482adabd42800b41e1 |
|
23-May-2015 |
Andrew MacDonald <andrew@webrtc.org> |
Make Config::default_value leak instead of having an exit-time destructor.
I wanted to use Config::Get in Chromium code, but it triggered the following
warning:
../../third_party/webrtc/common.h:89:20: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
static const T def;
^
../../third_party/webrtc/common.h:110:10: note: in instantiation of function template specialization requested here
return default_value<T>();
^
I assume we don't hit this in webrtc because the warning is disabled.
This also switches to the RTC_ prefix from the deprecated LIBJINGLE_.
Needed due to this Chromium CL:
https://codereview.chromium.org/1148843004/
R=andresp@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/53459004
Cr-Commit-Position: refs/heads/master@{#9268}
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 67186fe00cc68cbe03aa66d17fb4962458ca96d2 |
|
09-Mar-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Fix clang style warnings in webrtc/base
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| ff689be3c0c59c1be29aaa0697aa0f762566d6c6 |
|
12-Feb-2015 |
andresp@webrtc.org <andresp@webrtc.org> |
Use std::min and std::max instead of self-defined functions such as rtc::_min/_max.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35079004
Cr-Commit-Position: refs/heads/master@{#8347}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8347 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 27e5898f451f9412e57b8fca97b1932b4ed4565e |
|
07-Oct-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Explicitly unpoison FDs for MSan.
MSan doesn't handle inline assembly that's used by FD_ZERO causing a
false positive.
R=earthdok@chromium.org, henrike@webrtc.org
BUG=chromium:344505
Review URL: https://webrtc-codereview.appspot.com/25799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7388 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| f048872e915a3ee229044ec4bc541f6cbf9e4de1 |
|
13-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c |
|
13-May-2014 |
perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|
| 2c7d1b39b9374d2bc9bda4755fd4813db66a135c |
|
12-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/physicalsocketserver.cc
|