| 6f8ce060a21fcdc1c951fbf06768eb0cc0083b2f |
|
16-Nov-2015 |
kjellander <kjellander@webrtc.org> |
common_video: rename interface -> include
To avoid breaking downstream, the "interface" directories were copied
into a new "common_video/include" dir. The old headers got pragma
warnings added about deprecation (a very short deprecation since I plan
to remove them as soon downstream is updated).
The header guards are also identical to avoid mixing them up in the transition.
BUG=webrtc:5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
Review URL: https://codereview.webrtc.org/1418913006
Cr-Commit-Position: refs/heads/master@{#10659}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 91d6edef35e7275879c30ce16ecb8b6dc73c6e4a |
|
17-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to (D)CHECKs and related macros.
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.
Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.
BUG=chromium:468375
NOTRY=true
Review URL: https://codereview.webrtc.org/1335923002
Cr-Commit-Position: refs/heads/master@{#9964}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 3318f984cd7f51d24da4726665c05f5f06f82e6d |
|
26-Aug-2015 |
Magnus Jedvert <magjed@webrtc.org> |
VideoFrameBuffer: Make non-const data access explicit
VideoFrameBuffer currently has two overloaded data() functions for pixel access, one for const and one for non-const. Unfortunately, it will default to the non-const version, even when 'const scoped_refptr<VideoFrameBuffer>&' is used. This is a problem, because many subclasses use RTC_NOTREACHED() in the non-const version.
This CL makes the non-const version of data() explicit with a different, longer function name MutableData().
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1304143003 .
Cr-Commit-Position: refs/heads/master@{#9787}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| eb66e800d1f5f74ab366715d2618fbede8cf3e12 |
|
05-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Re-land "Convert native handles to buffers before encoding."
This reverts commit a67675506c9057bd9ffd4d76aae8b743343d434d.
BUG=webrtc:4081
TBR=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1158273010
Cr-Commit-Position: refs/heads/master@{#9381}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 308d163c715df7b4348a1e00bf2a6761c0adb689 |
|
02-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Revert "Convert native handles to buffers before encoding."
This reverts commit a831dc3a7d10a1fbaa258ee6b1ca6cfc7e91c5ca to unblock
rolling into Chromium.
BUG=4081
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/55549004
Cr-Commit-Position: refs/heads/master@{#9354}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| a831dc3a7d10a1fbaa258ee6b1ca6cfc7e91c5ca |
|
01-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Convert native handles to buffers before encoding.
Required to permit conversion of NV12 handles on iOS to I420 for VP8
software encoding, which blocks texture-based capture. This change
enforces that all texture-based input provides a method for converting
native handles to I420 if they are ever used with software encoders that
do not understand the native handles.
BUG=4081
R=emircan@chromium.org, glaznev@webrtc.org, hbos@webrtc.org, magjed@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, tkchin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50909005
Cr-Commit-Position: refs/heads/master@{#9347}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 9b3f56ea055934a5d5416db0386c857494410acc |
|
09-Apr-2015 |
Per <perkj@chromium.org> |
Reland "Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection.""
This reverts commit e41d774c4d0a60066866fc2d0ae48dd0e839ff23.
Original code review: https://webrtc-codereview.appspot.com/43999004/
Reason for reland: There was nothing wrong with this cl as is, but it breaks chrome compatibility. We will now reland this and fix Chrome during roll.
Patset 1: Original cl.
Patchset 2: Removed more code that is no longer needed.
R=magjed@webrtc.org, pbos@webrtc.org
TBR=mflodman@webrtc.org
BUG=1128
Review URL: https://webrtc-codereview.appspot.com/45049004
Cr-Commit-Position: refs/heads/master@{#8956}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| e41d774c4d0a60066866fc2d0ae48dd0e839ff23 |
|
07-Apr-2015 |
Per <perkj@chromium.org> |
Revert "Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection."
This reverts commit 75db8612588b4fabdf1b05f4ab145f7737093b45.
Revert "Fix build breakage in WrappedI420Buffer::native_handle()"
This reverts commit 3211934ebf7cac3e6df2cb4aacb6e47cc1cffe2b.
Reason for revert: Breaks chrome build and tests on clank, See https://codereview.chromium.org/1067803002/
BUG=1128
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43079004
Cr-Commit-Position: refs/heads/master@{#8940}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 75db8612588b4fabdf1b05f4ab145f7737093b45 |
|
07-Apr-2015 |
Per <perkj@chromium.org> |
Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection.
BUG=1128
R=magjed@webrtc.org, pbos@webrtc.org
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43999004
Cr-Commit-Position: refs/heads/master@{#8932}
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| a3209a2b27b7bf2059f8119a126a1b1be9f0377f |
|
20-Mar-2015 |
pbos@webrtc.org <pbos@webrtc.org> |
Release buffer pool in Vp8DecoderImpl::Release().
Permits reusing an external VP8DecoderImpl instance from another
VideoReceiveStream without a thread-checker DCHECK blowing up. Also
releases buffers that would've been kept in memory even though the
decoder isn't configured.
BUG=
R=magjed@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50449004
Cr-Commit-Position: refs/heads/master@{#8807}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8807 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|
| 73d763e71f5c77cac82aa65d737e64d893f190a0 |
|
17-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Add I420 buffer pool to avoid unnecessary allocations
Now when we don't use SwapFrame consistently anymore, we need to recycle allocations with a buffer pool instead. This CL adds a buffer pool class, and updates the vp8 decoder to use it. If this CL lands successfully I will update the other video producers as well.
BUG=1128
R=stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41189004
Cr-Commit-Position: refs/heads/master@{#8748}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8748 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_buffer_pool.cc
|