3c652b67468d182bd36aee4c31557621be50cc92 |
|
18-Nov-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
modules/audio_coding: Remove some codec include dirs Also clean up some include_dir entries and update the few references to them with absolute include paths instead. Finally fixed a few lint errors and invalid header guards. None of these are used downstream. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=kwiberg@webrtc.org Review URL: https://codereview.webrtc.org/1438663003 . Cr-Commit-Position: refs/heads/master@{#10700}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
dce40cf804019a9898b6ab8d8262466b697c56e0 |
|
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce use of int16_t/uint16_t. This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects. This was be reviewed and approved in pieces: https://codereview.webrtc.org/1224093003 https://codereview.webrtc.org/1224123002 https://codereview.webrtc.org/1224163002 https://codereview.webrtc.org/1225133003 https://codereview.webrtc.org/1225173002 https://codereview.webrtc.org/1227163003 https://codereview.webrtc.org/1227203003 https://codereview.webrtc.org/1227213002 https://codereview.webrtc.org/1227893002 https://codereview.webrtc.org/1228793004 https://codereview.webrtc.org/1228803003 https://codereview.webrtc.org/1228823002 https://codereview.webrtc.org/1228823003 https://codereview.webrtc.org/1228843002 https://codereview.webrtc.org/1230693002 https://codereview.webrtc.org/1231713002 The change is being landed as TBR to all the folks who reviewed the above. BUG=chromium:81439 TEST=none R=andrew@webrtc.org, pbos@webrtc.org TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher Review URL: https://codereview.webrtc.org/1230503003 . Cr-Commit-Position: refs/heads/master@{#9768}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
36b7cc32643bae0379d8102ce05dae82ecc466a1 |
|
12-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Reland "Upconvert various types to int.", neteq portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/neteq/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Review URL: https://codereview.webrtc.org/1181073002 Cr-Commit-Position: refs/heads/master@{#9427}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
b7e5054414ff524f9db81dab7917729b8c4c8bcb |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Match existing type usage better. This makes a variety of small changes to synchronize bits of code using different types, remove useless code or casts, and add explicit casts in some places previously doing implicit ones. For example: * Change a few type declarations to better match how the majority of code uses those objects. * Eliminate "< 0" check for unsigned values. * Replace "(float)sin(x)", where |x| is also a float, with "sinf(x)", and similar. * Add casts to uint32_t in many places timestamps were used and the existing code stored signed values into the unsigned objects. * Remove downcasts when the results would be passed to a larger type, e.g. calling "foo((int16_t)x)" with an int |x| when foo() takes an int instead of an int16_t. * Similarly, add casts when passing a larger type to a function taking a smaller one. * Add casts to int16_t when doing something like "int16_t = int16_t + int16_t" as the "+" operation would implicitly upconvert to int, and similar. * Use "false" instead of "0" for setting a bool. * Shift a few temp types when doing a multi-stage calculation involving typecasts, so as to put the most logical/semantically correct type possible into the temps. For example, when doing "int foo = int + int; size_t bar = (size_t)foo + size_t;", we might change |foo| to a size_t and move the cast if it makes more sense for |foo| to be represented as a size_t. BUG=none R=andrew@webrtc.org, asapersson@webrtc.org, henrika@webrtc.org, juberti@webrtc.org, kwiberg@webrtc.org TBR=andrew, asapersson, henrika Review URL: https://codereview.webrtc.org/1168753002 Cr-Commit-Position: refs/heads/master@{#9419}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
cb180976dd0e9672cde4523d87b5f4857478b5e9 |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Revert "Upconvert various types to int." This reverts commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. BUG=499241 TBR=hlundin Review URL: https://codereview.webrtc.org/1179953003 Cr-Commit-Position: refs/heads/master@{#9418}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
f045e4da43e671ae511aa1d9b6ef2968256a745d |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Prepare to convert various types to size_t. This makes some behaviorally-invariant changes to make certain code that currently only works correctly with signed types work safely regardless of the signedness of the types in question. This is preparation for a future change that will convert a variety of types to size_t. There are also some formatting changes (e.g. converting "enum hack" usage to real consts) to make it simpler to just change "int" to "size_t" in the future to change the types of those constants. BUG=none R=andrew@webrtc.org, juberti@webrtc.org, kwiberg@webrtc.org TBR=ajm Review URL: https://codereview.webrtc.org/1174813003 Cr-Commit-Position: refs/heads/master@{#9413}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
83ad33a8aed1fb00e422b6abd33c3e8942821c24 |
|
10-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none R=andrew@webrtc.org, kwiberg@webrtc.org Review URL: https://webrtc-codereview.appspot.com/54629004 Cr-Commit-Position: refs/heads/master@{#9405}
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
600587d5ac96c270612716ab76d813e0c275f98c |
|
09-Mar-2015 |
bjornv@webrtc.org <bjornv@webrtc.org> |
Refactor audio_coding/neteq: Removed usage of macro WEBRTC_SPL_16_16_RSFT The macro is defined as #define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \ (WEBRTC_SPL_MUL_16_16(a, b) >> (c)) where the latter macro is in C defined as #define WEBRTC_SPL_MUL_16_16(a, b) \ ((int32_t) (((int16_t)(a)) * ((int16_t)(b)))) (For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h) The replacement consists of - avoiding casts to int16_t if inputs already are int16_t - adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t) - minor cleanups like remove of unnecessary parentheses and style changes In addition an implicit cast from int32_t to int16_t was removed, which was a bug. BUG=3348, 3353 TESTED=Locally on Mac and trybots R=henrik.lundin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/41179004 Cr-Commit-Position: refs/heads/master@{#8653} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8653 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
e04a93bcf5e1b608c798a6a3148224b8035f0119 |
|
09-Dec-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Move the AudioDecoder interface out of NetEq It belongs with the codecs, next to the AudioEncoder interface. R=andrew@webrtc.org, henrik.lundin@webrtc.org, kjellander@webrtc.org Previously committed here: https://code.google.com/p/webrtc/source/detail?r=7798 and reverted here: https://code.google.com/p/webrtc/source/detail?r=7799 Review URL: https://webrtc-codereview.appspot.com/27309004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7839 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
3800e13a3a7031220e2d21990858d4d08581e393 |
|
03-Dec-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Revert r7798 ("Move the AudioDecoder interface out of NetEq") Apparently, it caused all sorts of problems I don't have time to straighten out right now. TBR=henrika@webrtc.org Review URL: https://webrtc-codereview.appspot.com/25289004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7799 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
00ba1a7dfd66e096ee5fb5e4e084c5565738426f |
|
03-Dec-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Move the AudioDecoder interface out of NetEq It belongs with the codecs, next to the AudioEncoder interface. R=henrik.lundin@webrtc.org, kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/27309004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7798 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
8b2058e73354e7f02cc44bc212fa58a52bb376cb |
|
06-Nov-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Remove the state_ member from AudioDecoder The subclasses that need a state pointer should declare them---with the right type, not void*, to get rid of all those casts. Two small but not quite trivial cleanups are included because they blocked the state_ removal: - AudioDecoderG722Stereo now inherits directly from AudioDecoder instead of being a subclass of AudioDecoderG722. - AudioDecoder now has a CngDecoderInstance member function, which is implemented only by AudioDecoderCng. This replaces the previous practice of calling AudioDecoder::state() and casting the result to a CNG_dec_inst*. It still isn't pretty, but now the blemish is plainly visible in the AudioDecoder class declaration. R=henrik.lundin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/24169005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7644 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
368215dacb1f632fae9892624d88fe8a76cfba8d |
|
05-Nov-2014 |
niklas.enbom@webrtc.org <niklas.enbom@webrtc.org> |
Revert 7623 "Remove the state_ member from AudioDecoder" Breaks Chrome compile: e:\b\build\slave\win_builder\build\src\third_party\webrtc\modules\audio_coding\neteq\neteq_impl.cc(131) : error C3867: 'webrtc::NetEqImpl::InsertPacketInternal': function call missing argument list; use '&webrtc::NetEqImpl::InsertPacketInternal' to create a pointer to member e:\b\build\slave\win_builder\build\src\third_party\webrtc\modules\audio_coding\neteq\neteq_impl.cc(131) : error C3861: 'LOG_FERR1': identifier not found e:\b\build\slave\win_builder\build\src\third_party\webrtc\modules\audio_coding\neteq\neteq_impl.cc(152) : error C3867: 'webrtc::NetEqImpl::InsertPacketInternal': function call missing argument list; use '&webrtc::NetEqImpl::InsertPacketInternal' to create a pointer to member e:\b\build\slave\win_builder\build\src\third_party\webrtc\modules\audio_coding\neteq\neteq_impl.cc(152) : error C3861: 'LOG_FERR1': identifier not found e:\b\build\slave\win_builder\build\src\third_party\webrtc\modules\audio_coding\neteq\neteq_impl.cc(169) : error C3867: 'webrtc::NetEqImpl::GetAudioInternal': function call missing argument list; use '&webrtc::NetEqImpl::GetAudioInternal' to create a pointer to member ... > Remove the state_ member from AudioDecoder > > The subclasses that need a state pointer should declare them---with > the right type, not void*, to get rid of all those casts. > > Two small but not quite trivial cleanups are included because they > blocked the state_ removal: > > - AudioDecoderG722Stereo now inherits directly from AudioDecoder > instead of being a subclass of AudioDecoderG722. > > - AudioDecoder now has a CngDecoderInstance member function, which > is implemented only by AudioDecoderCng. This replaces the previous > practice of calling AudioDecoder::state() and casting the result > to a CNG_dec_inst*. It still isn't pretty, but now the blemish is > plainly visible in the AudioDecoder class declaration. > > R=henrik.lundin@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/24169005 TBR=kwiberg@webrtc.org Review URL: https://webrtc-codereview.appspot.com/30879005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7629 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
9e525585fd8e99c0ca0a8b6a7c3c1e056658984e |
|
04-Nov-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Remove the state_ member from AudioDecoder The subclasses that need a state pointer should declare them---with the right type, not void*, to get rid of all those casts. Two small but not quite trivial cleanups are included because they blocked the state_ removal: - AudioDecoderG722Stereo now inherits directly from AudioDecoder instead of being a subclass of AudioDecoderG722. - AudioDecoder now has a CngDecoderInstance member function, which is implemented only by AudioDecoderCng. This replaces the previous practice of calling AudioDecoder::state() and casting the result to a CNG_dec_inst*. It still isn't pretty, but now the blemish is plainly visible in the AudioDecoder class declaration. R=henrik.lundin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/24169005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7623 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
ee0fb187a583b0c66b2c9fc8571411dca510ce7b |
|
02-Sep-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org> |
Divide-by-zero problem in NetEq's Normal::Process fixed Adding a couple of tests that tries to trigger a certain divide-by-zero issue. The tests triggered the issue, but this CL also includes a fix for this. BUG=3761 R=tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22269004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7025 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
9c55f0f957534144d2b8a64154f0a479249b34be |
|
09-Jun-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Rename neteq4 folder to neteq Keep the old neteq4/audio_decoder_unittests.isolate while waiting for a hard-coded reference to change. This CL effectively reverts r6257 "Rename neteq4 folder to neteq". BUG=2996 TBR=tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/21629004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6367 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
1b9df05c8521d1d807b08d7c00eb2f7e5b097fdf |
|
28-May-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6257 "Rename neteq4 folder to neteq" > Rename neteq4 folder to neteq > > BUG=2996 > R=turaj@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/12569005 TBR=henrik.lundin@webrtc.org Review URL: https://webrtc-codereview.appspot.com/13549004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6259 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|
a90f6d67f72359cf63b59480fa87a13aae808c03 |
|
28-May-2014 |
henrik.lundin@webrtc.org <henrik.lundin@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Rename neteq4 folder to neteq BUG=2996 R=turaj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/12569005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6257 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/neteq/normal.cc
|