History log of /external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
8c38e8b9b96d72317d6ce94c1442113b4e385dcb 26-Nov-2015 Peter Boström <pbos@webrtc.org> Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1476453002 .

Cr-Commit-Position: refs/heads/master@{#10812}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
12411ef40e08c5e28ccde54ab3418c96676ffcbc 23-Nov-2015 pbos <pbos@webrtc.org> Move ThreadWrapper to ProcessThread in base.

Also removes all virtual methods. Permits using a thread from
rtc_base_approved (namely event tracing).

BUG=webrtc:5158
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1469013002

Cr-Commit-Position: refs/heads/master@{#10760}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
98f53510b222f71fdd8b799b2f33737ceeb28c61 28-Oct-2015 Henrik Kjellander <kjellander@webrtc.org> system_wrappers: rename interface -> include

BUG=webrtc:5095
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1413333002 .

Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
4765070b8d6f024509c717c04d9b708750666927 30-May-2015 Miguel Casas-Sanchez <mcasas@webrtc.org> Rename I420VideoFrame to VideoFrame.

This is a mechanical change since it affects so many
files.
I420VideoFrame -> VideoFrame
and reformatted.

Rationale: in the next CL I420VideoFrame will
get an indication of Pixel Format (I420 for
starters) and of storage type: usually
UNOWNED, could be SHMEM, and in the near
future will be possibly TEXTURE. See
https://codereview.chromium.org/1154153003
for the change that happened in Cr.

BUG=4730, chromium:440843
R=jiayl@webrtc.org, niklas.enbom@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/52629004

Cr-Commit-Position: refs/heads/master@{#9339}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
64c0366908f7a966cbb28a4b07a810f2597a888a 08-Apr-2015 Peter Boström <pbos@webrtc.org> Revert "Revert "Split EventWrapper in twain.""

This reverts commit cf3c83e76c273309558c86fda915410f65b7a899.

Reverting EventWrapper split did not fix the issue, re-landing.

BUG=chromium:470013
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49629004

Cr-Commit-Position: refs/heads/master@{#8946}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
cf3c83e76c273309558c86fda915410f65b7a899 01-Apr-2015 Minyue <minyue@webrtc.org> Revert "Split EventWrapper in twain."

This reverts commit 9509fbfc301dd5412804ce5731afedc81480f2f8.

This is to debug a Chromium issue that WebRTC hangs if there is > 1 PeerConnection active in the browser on Win XP.

BUG=

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43019004

Cr-Commit-Position: refs/heads/master@{#8912}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
379069f676c13443398a72f7da8d118c973a0809 31-Mar-2015 Magnus Jedvert <magjed@webrtc.org> VideoRenderCallback::RenderFrame: Make I420VideoFrame& ref const.

RenderFrame should not modify the I420VideoFrame (and we don't).

This CL changes the declaration of RenderFrame from:
int32_t RenderFrame(const uint32_t streamId, I420VideoFrame& videoFrame)
to:
int32_t RenderFrame(const uint32_t streamId, const I420VideoFrame& videoFrame)

BUG=1128
R=mflodman@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/46689005

Cr-Commit-Position: refs/heads/master@{#8902}
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
9509fbfc301dd5412804ce5731afedc81480f2f8 23-Mar-2015 tommi@webrtc.org <tommi@webrtc.org> Split EventWrapper in twain.
I'm splitting the timer functions in EventWrapper into a separate interface.
- Users of the timer functions have different needs than users of a generic event
- Providing a default implementation for EventWrapper that simply uses rtc::Event.

This means that clients of WebRTC that don't use the relatively few classes, typically rendering classes, that depend on the event timer functionality, also don't pull in dependencies on multimedia timers.

R=mflodman@webrtc.org, mflodman
BUG=

Review URL: https://webrtc-codereview.appspot.com/48599004

Cr-Commit-Position: refs/heads/master@{#8833}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8833 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
38492c5b6fbb615159fa32b9cc24cd887295573b 22-Mar-2015 tommi@webrtc.org <tommi@webrtc.org> Re-land 8810 "- Add a SetPriority method to ThreadWr..."

> Revert 8810 "- Add a SetPriority method to ThreadWrapper"
> Seeing if this is causing roll issues.
>
> > - Add a SetPriority method to ThreadWrapper
> > - Remove 'priority' from CreateThread and related member variables from implementations
> > - Make supplying a name for threads, non-optional
> >
> > BUG=
> > R=magjed@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/44729004
>
> TBR=tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/48609004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50459005

Cr-Commit-Position: refs/heads/master@{#8819}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8819 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
90a1cb463092c5189b1a69837731a3395d79f61c 22-Mar-2015 tommi@webrtc.org <tommi@webrtc.org> Revert 8810 "- Add a SetPriority method to ThreadWrapper"
Seeing if this is causing roll issues.

> - Add a SetPriority method to ThreadWrapper
> - Remove 'priority' from CreateThread and related member variables from implementations
> - Make supplying a name for threads, non-optional
>
> BUG=
> R=magjed@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/44729004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48609004

Cr-Commit-Position: refs/heads/master@{#8818}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8818 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
b6817d793fa647ec77aaaaf74df82a94e46632bb 20-Mar-2015 tommi@webrtc.org <tommi@webrtc.org> - Add a SetPriority method to ThreadWrapper
- Remove 'priority' from CreateThread and related member variables from implementations
- Make supplying a name for threads, non-optional

BUG=
R=magjed@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44729004

Cr-Commit-Position: refs/heads/master@{#8810}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8810 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
361981faa86668cd9b20a2837d0b166fc024cd9b 19-Mar-2015 tommi@webrtc.org <tommi@webrtc.org> Use scoped_ptr for ThreadWrapper::CreateThread.

BUG=
R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45799004

Cr-Commit-Position: refs/heads/master@{#8794}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8794 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
2056ee3e3c7683ae4b2c4b12da99c3105c4f46a9 16-Mar-2015 magjed@webrtc.org <magjed@webrtc.org> Revert "Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*."

This reverts commit r8731.

Reason for revert: Breakes Chromium FYI bots.

TBR=hbos, tommi

Review URL: https://webrtc-codereview.appspot.com/40359004

Cr-Commit-Position: refs/heads/master@{#8733}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8733 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
2dc5fa69b2baef2ece158c9e1285516087faaa53 16-Mar-2015 hbos@webrtc.org <hbos@webrtc.org> Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*.

R=magjed@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40299004

Cr-Commit-Position: refs/heads/master@{#8731}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8731 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
86639737b83d8877abc4810100e30a8af863189d 13-Mar-2015 pbos@webrtc.org <pbos@webrtc.org> Remove thread id from ThreadWrapper::Start().

Removes ThreadPosix::InitParams and a corresponding wait for an event.
This unblocks ThreadPosix::Start which had to wait for thread scheduling
for an event to trigger on the spawned thread, giving faster Start()
calls.

BUG=4413
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43699004

Cr-Commit-Position: refs/heads/master@{#8709}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8709 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
875c97ed9dc25a8eac8075a42742863aa1b45d3e 04-Feb-2015 tommi@webrtc.org <tommi@webrtc.org> Remove SetNotAlive method from the thread class.
Also cleaning up methods with the same name in other classes that are derived from the above method.

R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41759004

Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
4161715e3f7e744bc9ef3d3ae437da1e8e4de38d 29-Jan-2015 tommi@webrtc.org <tommi@webrtc.org> Remove ChangeUniqueID.

This fixes a two year old TODO of deleting dead code :)
In cases where the _id or id_ member variable is being used for tracing,
I changed the member to at least be const.

It doesn't look like id's are that useful anymore so maybe the next step is to get rid of them.

BUG=
R=henrika@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37849004

Cr-Commit-Position: refs/heads/master@{#8201}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8201 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
4591fbd09f9cb6e83433c49a12dd8524c2806502 20-Nov-2014 pkasting@chromium.org <pkasting@chromium.org> Use size_t more consistently for packet/payload lengths.

See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
d2cf48de1adfc35cfefde04f62a607f848ca3c1d 12-Sep-2014 andresp@webrtc.org <andresp@webrtc.org> Fix mac video_render implementation on cocoa.

Hit this while playing around with all compile possibilities for issue 3770.

BUG=3770
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7166 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
57eb8586986a2c77b99124c270bc6caa11165f7f 11-Nov-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Remove ".." from include_dirs in build/common.

BUG=1662
TEST=compile on trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2332004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
fc10c5c97f51a3b4a40b03c2d9ef9f2734f7f862 17-Sep-2013 sjlee@webrtc.org <sjlee@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> This is related to https://code.google.com/p/webrtc/issues/detail?id=1341

BUG=1341
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2225004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4761 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
76945628050685a61b31c36a031e9298a0c2ccf4 29-Jul-2013 niklas.enbom@webrtc.org <niklas.enbom@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Land http://webrtc-codereview.appspot.com/1632005/

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1895004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4420 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
d900e8bea84c474696bf0219aed1353ce65ffd8e 03-Jul-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Proper spacing for end-of-namespace comments.

BUG=
R=mflodman@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1760006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
ddf94e71e524371f0cc2f6bcfed9ee5a972f11e9 10-Apr-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> WebRtc_Word32 -> int32_t in video_render/

BUG=314

Review URL: https://webrtc-codereview.appspot.com/1304006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3810 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm
9841d92b8d41356a72d5ca2b815906f581616c7d 31-Oct-2012 andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Reorganize modules/video_render.

The usual elimination of main/source etc.

Review URL: https://webrtc-codereview.appspot.com/929011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3027 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/video_render/mac/video_render_nsopengl.mm