History log of /frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
90d2dd403bc8faa421cfc6b26930e5aa69879943 02-Jun-2017 Ray Essick <essick@google.com> better manage buffer for libstagefright_soft_mpeg4enc

Existing code allocated buffer, adjusted pointer to use it, and would
adjust the pointer back when it came time to free the space. The problem
was that the adjustment was based on user-supplied values and if the
user changed those values between alloc and free (which was possible),
the code ended up free()ing the wrong address.

We fix this by keeping an extra pointer -- the unmodified allocation --
which we use for the subsequent free() calls. This makes the free()
independent of any changes to values that the user provides.

Bug: 36075363
Test: ran poc against patched nyc-mr2-dev tree
Change-Id: I7013ff5883a945c4647517b2980c76a6558f23d2
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
deba0610c89d54390c9d2d0a0f3b79fd7679779c 18-Aug-2015 Abhishek Arya <aarya@google.com> Merge "Revert "Fix compile after rI431aa2b7d30a942350ab6d105451c6b77e2f99d4"" into klp-dev
9abb7401df730b5c510f6b8dac2716a0928d9623 18-Aug-2015 Abhishek Arya <aarya@google.com> Fix compile failure after rI431aa2b7d30a942350ab6d105451c6b77e2f99d4

Bug: 20674086
Change-Id: I2ee6b7e0eabbf696c0986d08b2d759d48cb9eb7b
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
12bd1d2697f0d39f6c70f31d06f2f74c57e1d89f 18-Aug-2015 Abhishek Arya <aarya@google.com> Revert "Fix compile after rI431aa2b7d30a942350ab6d105451c6b77e2f99d4"

This reverts commit c23e3dd8af7397f023aae040c4a03dd14091cbed.

This speculative fix didn't fix the compile failure, do checking locally.

Change-Id: I1598f7208c8232ca38c0fcad17f211598591594e
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
c23e3dd8af7397f023aae040c4a03dd14091cbed 17-Aug-2015 Abhishek Arya <aarya@google.com> Fix compile after rI431aa2b7d30a942350ab6d105451c6b77e2f99d4

BUG: 20674086
Change-Id: Idaff17975b327adea65c39bdba1ab4e88789c0cd
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
b62a73b860757143d3b140b2985fdae71e18d675 03-Jun-2015 Wei Jia <wjia@google.com> libstagefright: check memory size for overflow before allocation.

Bug: 20674086
Change-Id: I431aa2b7d30a942350ab6d105451c6b77e2f99d4
(cherry picked from commit 42cccd7c8811597d56fb86afeacf6231d693dea6)
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp
59f566c4ec3dfc097ad8163523e522280b27e5c3 13-Jul-2010 James Dong <jdong@google.com> Initial check-in for software m4v_h263 encoder

Change-Id: I4b49fa5c3a5e6e21cfd2419441d98dd784046367
/frameworks/av/media/libstagefright/codecs/m4v_h263/enc/src/mp4enc_api.cpp