| ef1707027a18ed0d91a3854476db71024ae0e6da |
|
15-Sep-2016 |
I-Jui (Ray) Sung <ijsung@google.com> |
Revised ODR validation flow; added more ODR tests
Changed ODR validation logic to report errors on the tightest enclosing
type; fixed inconsistent diagnostic messages for F_odr_nested_records_2
and F_odr_nested_records_3. Also changed expected diagnostic message for
F_one_definition_rule8 for the same.
Removed unused RSExportable::equals(), as it is not used outside
RSExportType and subtypes, and is only for ODR matching. Renamed most
equals() to matchODR() for clarifying the intent and simplified the
logic in checkODR().
More ODR validation test cases: on fields and their type names including
record-typed fields and fields of built-in types, and
struct-of-array-of-structs.
Test: RsTest, CTS and slang test.py for angler_aosp-eng
Change-Id: I1703ecc0ab2995e0bfdfa1de33ea02cd63d99a7d
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| 5abbe0e9ca2508260b627ffef2bf01e2554e8357 |
|
13-Aug-2014 |
Chris Wailes <chriswailes@google.com> |
Replace the NULL macro with nullptr literal.
Change-Id: I33609969cd0d7aa55eaa83fb2c65f5faa6d55fa0
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| e639eb5caa2c386b4a60659a4929e8a6141a2cbe |
|
09-Nov-2010 |
Stephen Hines <srhines@google.com> |
Improve code style.
Change-Id: I26e043849bce2a4b41ae132fbe0c882f4a6f112f
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| 3cd3dd327445fcfa49f0e96cb2de2055bce541e9 |
|
21-Oct-2010 |
Zonr Chang <zonr@google.com> |
Bug fix: support self-referential struct type.
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| 7363d8430db732c42d392fcab47cf0e3f8eb4515 |
|
21-Oct-2010 |
Zonr Chang <zonr@google.com> |
Revert "Bug fix: support self-referential struct type."
This reverts commit af5cef07b48a678a416d554b037e0d6dbe958eb4.
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| d6f9fedf1b32c27c0bcaddd13d7b741ab5ad74b8 |
|
21-Oct-2010 |
Zonr Chang <zonr@google.com> |
Bug fix: support self-referential struct type.
/frameworks/compile/slang/slang_rs_exportable.cpp
|
| 641558f02fe6ce0ee3ae5076eb366c25e2ad5903 |
|
12-Oct-2010 |
Zonr Chang <zonr@google.com> |
Implement one-definition-rule (ODR) feature.
When compiling multiple RS files, we say two RS files A and B break ODR
iff:
1. They have at least one common struct named [S] and [S] will be reflected
to ScriptField_[S].java, and
2. [S] defined in A is not *exactly the same* (number of fields, field
type and field name) as the one defined in B.
This CL detects such error.
/frameworks/compile/slang/slang_rs_exportable.cpp
|