History log of /frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
39d6bdc92f98fd7100382d8fb5f7f7044dbcb083 01-Jun-2017 Randy Pan <zpan@google.com> Log disabled networks only

Previously a network could be logged as disabled before it has
actually reached the max failure threshold.

Bug: 62238322
Test: enter wrong password for a network, examine the bug report
Change-Id: I18db0543a74fb619041e44193198f1c8ceb36708
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
32a2c670100b84fb049f55ad5a8a300c60a48aa5 31-May-2017 Randy Pan <zpan@google.com> SavedNetworkEvaluator: ignore ephemeral networks

Ephemeral networks should be evaluted by ScoredNetworkEvaluator.
Otherwise, an ephemeral network might be chosen over a saved
network. Plus, the SaveNetworkEvaluator's scoring algorithm
is different from the ScoredNetworkEvalutor, so the result
coming out from these two evalutors can be very different.

Bug: 62197617
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I3237b4ca50dd6964dd8678011e6a9940c0ca1d0b
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
32f4de6e3cd333c657ac3aff078028a1d52600e3 10-May-2017 Randy Pan <zpan@google.com> SavedNetworkEvaluator: logging

Shorten the firmware roaming equivalent BSSID bonus scoring
string.

Bug: 36872201
Test: Build, flash and boot.
Change-Id: Iad46c50ecf30356ddf7af3a2221ae4a9f410d890
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
4de361cb58da0b0c410c8c41dc97fb87f687d270 09-May-2017 Randy Pan <zpan@google.com> SavedNetworkEvaluator: improve logging

Instead of dumping every field of ScanResult, print SSID, BSSID
and RSSI only. Shorten the scoring string as well.

Bug: 36872201
Test: Build, flash the image and examine the new log.
Change-Id: I7fb8075f0f011ca4965a92802728bf4d919fe68f
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
5213be94c3b27fff928f5f221e5951c7ede1058b 26-Apr-2017 Randy Pan <zpan@google.com> Wifi network selection logging improvement

1) Only log saved networks which are disabled. Print the disable
reason and count in a human readable fashion.
2) Log user connection preference only if it affects network
selection.

Bug: 36872201
Test: runtest.sh
Test: Flash, run connection tests and check the bug reports
Change-Id: I56df97e43ef01ff8d14e79a26bf98bb60abedee2
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
2cf3661d146e2bdd0d761028e91df775c8eabca3 14-Apr-2017 Amin Shaikh <ashaikh@google.com> Remove CURATE_SAVED_OPEN_NETWORKS

- Update SavedNetworkEvaluator to no longer reference this setting.
- Update SavedNetworkEvaluatorTest#setCandidateScanResultsForAllSavedNetworks
to ensure that candidate ScanResults are added to saved secure networks in
addition to useExternalScores saved networks and open networks

Bug: 37356724
Test: ./tests/wifitests/runtests.sh
Change-Id: I87794f339a9910fb343d1994910320efe0feafa2
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
96c4e4d724bd9e666adf177722eb7136ab340185 30-Mar-2017 Randy Pan <zpan@google.com> WifiConnectivityManager: Disable linked networks

Bug: 36786113
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I9f9294e29d8a6bb97e1822a6ffa0159a19e7a6ef
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
13fb8e99c1a793c42e102e4f16f63de02f6eeed3 29-Mar-2017 Randy Pan <zpan@google.com> Clean up saved network score calculation

1) Apply band specific RSSI saturation threshold.
2) Remove the no internet penalty since the network should have
been blacklisted because of DISABLED_NO_INTERNET.
3) Clean up a couple of line indents.

Bug: 36223866
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I9e5a9dda5ba38248ae0d6ed3ac64c46d655c4280
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
c22ad7f19888f7967edcf30080543bb632ddd68d 03-Mar-2017 Randy Pan <zpan@google.com> Same BSSID award

When firmware roaming is supported, apply the same BSSID award to
all of the BSSIDs under the same network as the currently connected
BSSID. This is under the assumption that firmware will roam to that
better BSSID.

This might save a disconnection triggered by network switch when
the score of the currently connected BSSID is lower than a network
with a different SSID, but within the currently connected network
there is a BSSID better than the currently connected BSSID.

Bug: 35642269
Test: runtest.sh
Change-Id: Ie09170d0cb11565f72e3b45b702d39c88ababba9
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
17c2a7b30e5680b11fc0073ce322ee7bc14ef2c5 03-Feb-2017 Randy Pan <zpan@google.com> Local log buffer shared by connectivity modules

Move the creation of the local log buffer for connectivity modules to
WifiInjector. Then pass it over to all the connectivity modules.
Dump the log buffer via WifiConnectivityManager.

While there, removed the null check in localLog() for all the
connectivity modules.

Bug: 35642622
Test: runtest.sh and manual test
Change-Id: I31866c6fecdd9f50061f47e34e16c701ff230a6c
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
67a4541372684c5d0a3f834f8be76bd8d29ca7ac 14-Mar-2017 Peter Qiu <zqiu@google.com> hotspot2: ignore Passpoint networks in SavedNetworkEvaluator

While there, enable the Passpoint network when it is created
by PasspointNetworkEvaluator to be more consistent.

Bug: 36218488
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I72fa55a9cb6baf71e8650e10cb54b496a7be1343
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
235642dba4359c1e68618f27c949e744765cbbcc 07-Feb-2017 Amin Shaikh <ashaikh@google.com> Move adjustCandidateWithUserSelection to WifiNetworkSelector

WifiNetworkSelector#setUserConnectChoice contains all of the logic for
favoring a user selected network over other visible networks present at
the last round on network selection. However, the logic for using this
data is contained in
SavedNetworkEvaluator#adjustCandidateWithUserSelection. This has the
side effect that RecommendedNetworkEvaluator or any new NetworkEvaluator
in the future can override the user's explicit intent to choose a
specific network. This change moves adjustCandidateWithUserSelection to
WifiNetworkSelector, fixing this bug and bringing all user connect
choice logic into the same class, WifiNetworkSelector.

Set a candidate ScanResult for every WifiConfiguration in
SavedNetworkEvaluator, regardless of whether it is externally scored.
This ensures that the user connect choice is respected if an externally
scored network is selected by a user over a secure saved network.

Bug: 34971941
Test: ./runtests.sh
Change-Id: I8730aee89dbee0ebb97161a56f00c026139ef5c9
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
2a70519406937402c761a6ce418c15e3b5598688 04-Mar-2017 Rebecca Silberstein <silberst@google.com> FrameworkFacade: add helper to ease testing

WifiController, RecommendedNetworkEvaluator and SavedNetworkEvaluator
all use ContentObservers in their implementations. The tests for these
classes started failing when a change was made to include the Context
object when registering ContentObservers. This changed caused the tests
for these methods to fail due to a mix of mocks and actual objects.
This CL adds a helper to FrameworkFacade that allow the tests to pass,
and even better, updates them to use ArgumentCaptors to get a handle on
the ContentObservers. This will allow the tests to be enhanced and
easily call the observers to test functionality for changes related to
the observers.

Bug: 35908602
Test: frameworks/base/wifi/tests/runtests.sh
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I2e4a39febf575c1335cec57b9e21e28cb3e0fffd
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
e4b4b229331da3964671606f18557b2e7f681b45 20-Jan-2017 Amin Shaikh <ashaikh@google.com> Skip open networks in SavedNetworkEvaluator.

- Only if CURATE_SAVED_OPEN_NETWORKS is enabled.

Bug: 34392914
Test: ./runtests.sh
Change-Id: I47b5848e21e0851d4e5e3a1b1f49aa8e8c876fcc
Merged-In: I47b5848e21e0851d4e5e3a1b1f49aa8e8c876fcc
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
d335557ef8c724395a39c8fdda26653c90dcc1c5 02-Dec-2016 Randy Pan <zpan@google.com> SavedNeworkEvaluator: compare networks via networkId

After the WifiConfigManager refactoring it's no longer
valid to compare networks via their WifiConfiguration
objects.

Bug: 33296226
Test: runtests.sh
Change-Id: I3cc4d734901df02c841e8ef02b2975f478190d47
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
c301f93e031e6a2c470524f98045fad771545a7e 17-Oct-2016 Roshan Pius <rpius@google.com> NetworkSelector: Remove redundant network lookup

There is no need to lookup the WifiConfiguration corresponding to the
last selected network since we're anyway only comparing the network
ID's.
This spews unnecessary error logs when there is no user selected network
set.

While there,
Change the scan result lookup log log from local log to verbose log to
prevent filling up the local log with these entries.

Bug: 32156160
Test: Compiles
Change-Id: I13d96a045e150485060b184e241418822d6dd9b7
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java
f2a46f11dd92f2820e96b1b8b69b433012d6bcef 03-Sep-2016 Randy Pan <zpan@google.com> Wifi Network Selector

Set up the layout of the new Wifi Network Selector. Add the implementation
of Save Network Evaluator and Exernally Scored Network Evaluator.

Bug: 31089538
Test: unit tests and manual tests
Merged-In: Ieb269060669df220c3d1777eb3aac3b119d4fdc1
Change-Id: Ieb269060669df220c3d1777eb3aac3b119d4fdc1
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/SavedNetworkEvaluator.java