• Home
  • History
  • Annotate
  • only in /frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/
History log of /frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3d459a1534a5885aa687ac01ebb93d0a2806ac1b 23-May-2017 Aurimas Liutikas <aurimas@google.com> Fix ProgressBarManagerTest size annotations

Mark the tests that take 2+ seconds to complete as @LargeTest

Change-Id: I33d10d41fd1afed069300d463b14cd0b50518729
rogressBarManagerTest.java
e95cc698937673f3b41f9001f03a86f4e5092c6c 16-May-2017 Dake Gu <dake@google.com> Merge "leanback: fix Drawable not updated" into oc-dev
6be5511d17efdbb935e2a025337834fc698ce723 16-May-2017 Dake Gu <dake@google.com> leanback: fix Drawable not updated

If setDrawble between onStart and enter transition
finishes, the Drawable is not scheduled to update
when LayerDrawable becomes FULL_ALPHA again.

Bug: 35669641
Test: delayDrawableChangeUntilFullAlpha
Change-Id: I53ac509d87063be5291ae946546349ae58c2e98d
ackgroundManagerTest.java
946a01cfedb6838e98d7a37e30f64c39b603893d 12-May-2017 Dake Gu <dake@google.com> Fix constant in PlaybackControlGlue Actions.

The values are ment to be constant.

Bug: N/A
Test: N/A

Change-Id: I1ba306fe02beb52f837748c5af75d0c1fffea991
laybackOverlayTestFragment.java
laybackTestFragment.java
laybackTestSupportFragment.java
0f17cc8625257f29840f3bb61c52366e052554e7 04-May-2017 Dake Gu <dake@google.com> leanback: maybe fix flaky RowsSupportFragmentTest#defaultAlignment

Seems to be a multi thread issue, the view can be temporarily detached
from RecyclerView in UI thread.

Bug: 37985204
Test: RowsSupportFragment#defaultAlignment
Change-Id: I3ac72d86f412d6e50d55650ac4fe9e96e08f4169
owsFragmentTest.java
owsSupportFragmentTest.java
c90b4456b4fa3d2b3a1ba5746a38883036103293 24-Apr-2017 Keyvan Amiri <keyvana@google.com> Merge "leanback: fix delayed data loading when HeaderFragment is disabled" into oc-dev
f89c67eeac3938f245c858774cc7c9f87fb7487d 22-Apr-2017 Dake Gu <dake@google.com> leanback: fix delayed data loading when HeaderFragment is disabled

Bug: 37580676
Test: BrowseFragmentTest#lateLoadingHeaderDisabled

Change-Id: I72443f61284ae014898e7673eaa7aa90aad70ae0
rowseFragmentTest.java
rowseFragmentTestActivity.java
rowseSupportFragmentTest.java
rowseSupportFragmentTestActivity.java
rowseTestFragment.java
rowseTestSupportFragment.java
c6c4e8e836f3608446fb472916418f9df660d46a 22-Apr-2017 Dake Gu <dake@google.com> leanback: fix DetailsFragment Tests

Remove duplicated code that causes adapter being
updated and child view become invalidate.

Bug: 37580870
Test: DetailsFragmentTest
Change-Id: Ic7ec245f1a03ac2dfb0afb0909c050ba59904b2f
etailsFragmentTest.java
etailsSupportFragmentTest.java
c807587e03e775abb23f62894ad59bfb91cfbd97 20-Apr-2017 Dake Gu <dake@google.com> leanback: fix crash late assigning Adapter that has stable ids

We cannot assign a ItemBridgeAdapter to RecyclerView
and later RowsFragment.setAdapter() to change hasStableId
to true. RecylcerView will crash.

So BaseRowsFragment have to delay the
RecyclerView.setAdapter(itemBridgeAdapter)
until app pass in a adapter.

However, this has a side effect on FocusHighlightHelper.
setupHeaderItemFocusHighlight(VerticalGridView). We no longer
guarantee the VerticalGridView will have an ItemBridgeAdapter
assigned to it in onViewCreated(). So we have to introduce
new APIs to expose getBridgeAdapter() and let FocusHighlightHelper
use ItemBridgeAdapter.

Bug: 37515649
Test: HeadersFragmentTest#disableScaleInConstructor
RowsFragmentTest#changeHasStableIdToTrueAfterViewCreated

Change-Id: I1137b81ced68a9d9a8fb13ca689882b9a39d09c7
eadersFragmentTest.java
eadersSupportFragmentTest.java
owsFragmentTest.java
owsSupportFragmentTest.java
3bcad88cbf4488e747d84893c35f2351b8f84afe 21-Mar-2017 Dake Gu <dake@google.com> leanback: new transport controls

PlaybackTransportRowPresenter is the new UX.

PlaybackTransportControlGlue extends from PlaybackGlue.
PlaybackTransportControlGlue is backed by PlayerWrapper.
PlaybackWrapper wraps underlying media player,
concrete example: MediaPlayerWrapper.

PlaybackSeekDataProvider defines the data interface that app
provides to leanback.
PlaybackUI defines seeking interaction between
PlaybackTransportControlGlue, PlaybackGlueHost and the presenter.

more:
- added progress bar support for media loading.
- fixed vertical video proportion and support video size change.

Test: PlaybackTransportControlGlueTest
PlaybackTransportRowPresenterTest.
Updated SampleVideoFragment.

Bug: 33751556

Change-Id: I1d39c6f65d04121f8cb9c25fb7ce103e32355190
etailsFragmentTest.java
etailsSupportFragmentTest.java
laybackOverlayTestFragment.java
laybackTestFragment.java
laybackTestSupportFragment.java
ideoFragmentTest.java
ideoSupportFragmentTest.java
1ae6582860b06cb81faaa2da0f6f24e13a349bc7 18-Apr-2017 Dake Gu <dake@google.com> Merge "leanback: fix ProgressBarManager not shown" into oc-dev
bd93ed2c9e5c37363034b5cfe151f0445b0bcb17 18-Apr-2017 Dake Gu <dake@google.com> Merge "leanback: fix transition test below api 21" into oc-dev
1648a30a0177f30ad78d39c01abd2c5313b97114 17-Apr-2017 Wei-Hsin Chen <wwwllllfrank@google.com> Merge "Reuse PlayBackGlueHost when switching PlayBackGlue" into oc-dev
36d8c0834a50ef9aedb7a7e821dfcac152c0ab79 15-Apr-2017 Dake Gu <dake@google.com> leanback: fix transition test below api 21

Bug: 37363544
Test: BrowseFragmentTest BrowseSupportFragmentTest
Change-Id: Icc51e66fbc7f5cdc8eac8efb6c60e5f51f7c8b73
rowseFragmentTest.java
rowseSupportFragmentTest.java
1853eab01f421268e2a1de76b660b5577260ce5d 15-Apr-2017 Dake Gu <dake@google.com> leanback: fix ProgressBarManager not shown

show() only works for the first time.

Bug: 37362000
Test: ProgressBarManagerTest
Change-Id: I82ca5d99d085baa3ace4b9a0a112d2a3b1e5bc1b
rogressBarManagerTest.java
c65ceae1251b35fbf4aa72df7b5d20e764bed9d2 12-Apr-2017 Wei-Hsin <wwwllllfrank@google.com> Reuse PlayBackGlueHost when switching PlayBackGlue

Bug: 37222175
Test: sharedGlueHost() in DetailsFragmentTest
Change-Id: Icdbbfe28c11ef456743cbd2290892e2136862c6a
etailsFragmentTest.java
etailsSupportFragmentTest.java
4ccbc343ff7e498b8fe9418cc8bd371be0d7acc5 13-Apr-2017 Dake Gu <dake@google.com> leanback: fix flaky BrowseFragmentTest

Use PollingCheck instead of sleep for Transition end.
Bug: 37286993
Test: BrowseFragmentTest

Change-Id: Iddb9a1edecfb9d81fdbe3fe9939106c98dd7197f
rowseFragmentTest.java
rowseSupportFragmentTest.java
rowseTestFragment.java
rowseTestSupportFragment.java
6828e7da34b4a86bf6fd6c28561528b5a4d14d1b 05-Apr-2017 Dake Gu <dake@google.com> resolve merge conflicts of d1dfcffe0e to oc-dev

Change-Id: Id25699322e4382605e09c195f2922287d21ed360
dec38f028e4991e352cb45f0e3c1bc85fd9b973d 04-Apr-2017 Dake Gu <dake@google.com> leanback: fix flaky tests

Dont wait activity isDestroyed() in afterTest.
And remove member mActivity from test class.

Bug: 36701683
Test: run DetailsFragmentTest multiple times on emulator
Change-Id: I0e0e037f6e85f86a1157a7640b864661cc074e4f
etailsFragmentTest.java
etailsSupportFragmentTest.java
eadersFragmentTest.java
eadersSupportFragmentTest.java
laybackFragmentTest.java
laybackOverlayFragmentTest.java
laybackSupportFragmentTest.java
owsFragmentTest.java
owsSupportFragmentTest.java
ingleFragmentTestBase.java
ingleSupportFragmentTestBase.java
erticalGridFragmentTest.java
erticalGridSupportFragmentTest.java
ideoFragmentTest.java
ideoSupportFragmentTest.java
43d43155a4d311e79ce9cd49b4519c7697d41eae 31-Mar-2017 Dake Gu <dake@google.com> Merge "DetailsFragment: support switchToVideo in onCreate" into nyc-support-25.4-dev
am: 73a205fa58

Change-Id: I0aec780f5e2ab7769115572ab8a7c2865caaba09
73a205fa5871d14d4eec51840f533174e5e89874 31-Mar-2017 Dake Gu <dake@google.com> Merge "DetailsFragment: support switchToVideo in onCreate" into nyc-support-25.4-dev
2a3ba294a5304c5c7138266f0c8ac51a5f2364ec 30-Mar-2017 Dake Gu <dake@google.com> Merge "leanback test: Logging request of creating activity" into nyc-support-25.4-dev
am: bbde4d32e5

Change-Id: I5d47ba5cbb946b12ea74544c5f0fd948f0928fda
efb4fb840a01f7c8d503c512ca908bd97e637a95 30-Mar-2017 Dake Gu <dake@google.com> leanback test: Logging request of creating activity

Dont know where the extra startActivity request comes from.

Bug 36701683
Test: DetailsFragmentTest

Change-Id: I53bf5684199956a670856a554cc4937acad2a48f
ingleFragmentTestActivity.java
ingleFragmentTestBase.java
ingleSupportFragmentTestActivity.java
ingleSupportFragmentTestBase.java
89097f67f988ebba714a95e10369665280db0c27 25-Mar-2017 Dake Gu <dake@google.com> DetailsFragment: support switchToVideo in onCreate

Allows DetailsFragment to be put in intial video mode
and skip entrance transition and enter transition.

The DetailsFragment's state model is fairly complicated
including entrance transition, enter transition and
switchToVideo call. So reworked StateMachine and based
DetailsFragment on StateMachine, remove the PF_ flags used
before.

When switchToVideo is called in DetailsFragment.onCreate,
there is no video fragment yet, but we still fade out
cover drawable and create a pending flag once the video
fragment view is created will focus on to it.

Added support in GridLayoutManager to allow slideOut() when
there is no child, and layout the first pass out of
window.

switchToVideo is not allowed with entrance transition.
once prepareEntranceTransition is called, switchToVideo will
be ignored until entrance transition is finished. On the other
hand, calling prepareEntranceTransition after switchToVideo
will be ignored.

switchToVideo will clear activity enter transitions. Once
it is called in onCreate, we do not want the activity enter
transition to run.

Test: bunch of new tests in DetailsFragmentTest for all kinds
of scenarios
Bug: 36126851

Change-Id: Ic0279331b12b1e285507dffda3ad351245c01a1b
etailsFragmentTest.java
etailsSupportFragmentTest.java
813b0740517a5b63f2c3744dfe3f011910a600b3 28-Mar-2017 Dake Gu <dake@google.com> Merge "leanback: fix item listener for preteched row" into nyc-support-25.4-dev
am: 967dfaab04

Change-Id: I97eee01bfa9eaeffddda5454ccb2e5d412a630d1
b1f50ac6f9fa8a8140873cad549efb118d0baea9 28-Mar-2017 Dake Gu <dake@google.com> leanback: fix item listener for preteched row

leanback had assumption that items on a row was bound after row is
attached to window, row gets OnItemViewClickedListener when it
is attached to window. This assumption is broken when pretch a row.
The first few items of that row is bound before row is attached to
window at that time there is no OnItemViewClickedListener on the row.

Bug: 36665531
Test: RowsFragmentTest#prefetchChildItemsBeforeAttach
Change-Id: I8a88ad955773b533ef362b6e759ce4d88aa88037
owsFragmentTest.java
owsSupportFragmentTest.java
7feeb8265ad2223ccdb396c558fc4cf71b5313a4 24-Mar-2017 Dake Gu <dake@google.com> fix DetailsFragmentTest
am: a43689a579

Change-Id: Ib65977183b28daeba5781114e9b23167ca6eabab
a43689a5797d22853aad74c4fa23539b640a8f3f 24-Mar-2017 Dake Gu <dake@google.com> fix DetailsFragmentTest

Add wait for video fragment being created.
Disable CompositeDrawable getAlpha test bellow API 21 because
CompositeDrawable calls DrawableCompat.getAlpha(firstChildDrawable)
which always returns 0 on API 17.

Bug: 36577054
Test: DetailsFragmentTest DetailsSupportFragmentTest.
Change-Id: I32f3e3db1a25835c08e9c85e3b13191d9f5992ba
etailsFragmentTest.java
etailsSupportFragmentTest.java
a207d6d23fe5e7c15e4a3dbc4832e732d884ad05 23-Mar-2017 Dake Gu <dake@google.com> Merge "leanback: make Details embedded video more useful" into nyc-support-25.4-dev
am: 41533c6ca0

Change-Id: I63f3c58ce9db27801a2c1ac21c6677167746c7e7
f87eb1d84dfee2f1be9ea326754829b1eff4967f 22-Mar-2017 Dake Gu <dake@google.com> leanback: make Details embedded video more useful

The current implementation has assumption that
the PlaybackGlue is setup during onCreate() and there
is only one PlaybackGlue allowed. The restriction
makes some use cases impossible. This CL address this
by adding more flexibility of when a PlaybackGlue can
be assigned to DetailsFragmentBackgroundController.

1. allow setupVideoPlayback() later, this allows
app add a purchase flow before playing.

2. allow setupVideoPlayback() multiple times, so
a real video can replace trailer video after
purchase flow is done.

3. Fix bug of RecyclerViewParallax not running
parallax effect when there is no item, added
a onLayoutChangeListener so that DetailsParallaxDrawable
will set correct bounds when RecyclerView is assigned
a initial size (verified by test noInitialItem)

4. new API canNavigateToVideoFragment(), this allows
app to control when DPAD_UP can navigate to videos.

5. new API switchToVideo() so that app can switch to video
UI programmatically after a purchase flow finishes.

Bug: 36126851
Test: DetailsFragmentTest DetailsSupportFragmentTest

Change-Id: I7cd4084e71b85d8fd739d30a421746312bdb086c
etailsFragmentTest.java
etailsSupportFragmentTest.java
51bde5dfa2070705a9ee1072f2f89bcd37040568 22-Mar-2017 Dake Gu <dake@google.com> Merge "Fix multiple bugs related with DetailsFragment:" into nyc-support-25.4-dev
am: 256abb7035

Change-Id: Idc97e0fea29eeba0223ba5fbaa1754a37890be3f
6525e063fbbd691a8553f4fc77f3960f93bea34d 22-Mar-2017 Dake Gu <dake@google.com> Fix multiple bugs related with DetailsFragment:

1. If onStart reinitialize the adapter, it may causes
BaseGridView.animateOut() being called when there is
no child which causes NPE in GridLayoutManager.slideOut()
2. In DetailsFragment.onStart() we should not requestFocus()
on vertical grid view if DetailsFragment already gains focus,
otherwise it will move focus out of embedded video playing.
3. remove support of DPAD_DOWN from playback to details ui.
The returning is done through BACK.
4. Fix the flaky DetailsFragment navigation tests.
5. Make PlaybackFragment internal variable package private
to remove potential generated stub method and easy to test.
6. Change DetailsFragmentTest to be "LargeTest" to skip
the TreeHug integration.

Bug: 36492114
Test: DetailsFragmentTest DetailsSupportFragmentTest

Change-Id: Ia437611c234565aa6a85709c897cdd436ff21cf9
etailsFragmentTest.java
etailsSupportFragmentTest.java
6a838617f9ad69aca1275b29249c573179fb4d98 15-Mar-2017 Aurimas Liutikas <aurimas@google.com> Disable flaky PlaybackOverlayFragmentTest#alignmentRowToBottom

Bug: 36183963
Test: None
Change-Id: I54cd9b21609a3665ab1f6ab417777345750038bf
laybackOverlayFragmentTest.java
df6f9abf613fee2af240d84ee9ea0b165c297eb8 13-Mar-2017 Aurimas Liutikas <aurimas@google.com> Disable flaky PlaybackSupportFragmentTest#alignmentRowToBottom

Bug: 36183963
Test: test no longer runs
Change-Id: I0d6d6f9b693363ce5714ba1ef75ac25b1ff1c899
laybackSupportFragmentTest.java
6bffdb74ddb0c170b7f02ced99d60de1961e38f5 13-Mar-2017 Aurimas Liutikas <aurimas@google.com> Supress PlaybackFragmentTest#alignmentRowToBottom test

PlaybackFragmentTest#alignmentRowToBottom is failing and causing presubmit
failures.

Test: test no longer runs
Change-Id: I5e384c2c5bb416dda88471c40b0d7e839b5281e8
laybackFragmentTest.java
444128e61403b8a3aa27b1e6577b6ffbacd53482 10-Mar-2017 Dake Gu <dake@google.com> Merge "leanback: Fix playback screen alignment" into nyc-support-25.4-dev
am: 0e9ccc9a9c

Change-Id: Ib814605326d3e3e69ca16aea81438a84a03355f5
5a4d3a98d681cc9042b28a923aa5a23a6b961998 09-Mar-2017 Dake Gu <dake@google.com> leanback: Fix playback screen alignment

Make playback row's bottom align to padding bottom.
Deprecate the paddingTop which isn't reliable since
playback row's height can change.

Add more test for playback fragment.

Bug: 36099789
Test: alignmentRowToBottom setupRowAndPresenterWithoutGlue
setupWithControlGlue

Change-Id: I202d31b897c2cc6ab8666842855623425ce70694
laybackFragmentTest.java
laybackOverlayFragmentTest.java
laybackOverlayTestFragment.java
laybackSupportFragmentTest.java
laybackTestFragment.java
laybackTestSupportFragment.java
ingleFragmentTestBase.java
ingleSupportFragmentTestBase.java
a72f890c0c52ea8531f39dccf48c3b06004b34c9 09-Mar-2017 Dake Gu <dake@google.com> Merge "leanback: fix initial selection of playback button" into nyc-support-25.2-dev am: 501d41cbc0 am: c39bc7d6d7
am: 9f8a37090d

Change-Id: I277e82adf3cd50d2dbe666e988c4841aa7c76dbf
3a880690aa4b202d38cd976ce7c7926caa0c8311 09-Mar-2017 Dake Gu <dake@google.com> leanback: fix initial selection of playback button

Because initially when Media is not ready we skipped
updatePlaybackState(), we have initially two buttons
thumbs up and thumbs down in the adapter.
The UI makes initially selection to #2.

And later play/ rewind / fastforward button is added when
hasValidMedia() becomes true, selection is still on
button #2.

This CL calls updateControlsButton during the setup
and add all play buttons even when media is invalid.

We no longer allow onStateChanged() to add/remove play related
actions, afaik no app is relying on this behavior.

Bug: 36071311
Test: PlaybackContrlGlueTest#testWithoutValidMedia

Change-Id: I36d9404ff8ee61d10d10f77ca6b9fdab3aa69d07
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
05944c3367279f44345963acc40674b1653f6418 08-Mar-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "A pass at fixing unchecked javac warnings."
a87809f9d13a3d39bf2202303b912019e8107c1b 07-Mar-2017 Dake Gu <dake@google.com> Reenable parallaxTest

Bug was fixed and merged

Bug: 32022097
Test: parallaxTest
Change-Id: Id39869df0b14c3de5b0b9ae0454a5d179cb71845
etailsFragmentTest.java
etailsSupportFragmentTest.java
27644c071b7fc0e1e4f91194f2a08b4aa2cf1465 05-Mar-2017 Aurimas Liutikas <aurimas@google.com> Remove unused imports in support library classes.

Test: ./gradlew assebmle assembleAndroidTest
Change-Id: I429f0abb742bfed9288f84a7d6a3208063068f23
izard/GuidedStepAttributesTestFragment.java
abc73958d264e1eed7fd401a18be1d9ede8304eb 06-Mar-2017 Aurimas Liutikas <aurimas@google.com> A pass at fixing unchecked javac warnings.

Add types where needed.
Suppress places where we intentionally skip types.

Test: ./gradlew assemble still works
Change-Id: If1350e896948c7e27c212cf7b1a94f08b9131193
estActivity.java
e2104f4b5c8e3ad63570306a25e61502dfe4c418 05-Mar-2017 Aurimas Liutikas <aurimas@google.com> Add all missing @Override annotations.

Historically, we could not add @Override for certain methods due to
using older SDKs to build support library. That is no longer the case
so we can add @Override everywhere now.

Test: ./gradlew assemble assembleAndroidTest still works
Change-Id: I85e3c1157f0e253e3eab7584189f3bf95cf030e9
rowseFragmentTest.java
rowseSupportFragmentTest.java
etailsTestFragment.java
etailsTestSupportFragment.java
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
laybackFragmentTest.java
laybackOverlayTestFragment.java
laybackSupportFragmentTest.java
laybackTestFragment.java
laybackTestSupportFragment.java
owsFragmentTest.java
owsSupportFragmentTest.java
ingleFragmentTestBase.java
ingleSupportFragmentTestBase.java
erticalGridFragmentTest.java
erticalGridSupportFragmentTest.java
67fa76d463cfa2a5e3d257cbfb89fb1e4151f5fa 24-Feb-2017 Dake Gu <dake@google.com> Re-enable DetailsFragment embedded video navigation tests

The tests fail because adapter change interrupted
animateOut(). Fixed by ag/1934686

Bug: 35399351
Bug: 32022097
Test: DetailsFragmentTest DetailsSupportFragmentTest

Change-Id: I53b6f15be18787dca0cd76abf4ca533934886b2b
etailsFragmentTest.java
etailsSupportFragmentTest.java
eef612682d0b84b7f519416e170956079801d5ff 24-Feb-2017 Chris Craik <ccraik@google.com> Merge "Fix PrefetchRegistry reset, out of bounds exceptions" into nyc-support-25.2-dev am: 9b759d3162 am: cb11905ffa
am: fbea507778

Change-Id: I9a1ae0c45008e5816036e02e464d68ab6cba7786
9b759d31624b08547293053efdaa4e41e4f10232 24-Feb-2017 Chris Craik <ccraik@google.com> Merge "Fix PrefetchRegistry reset, out of bounds exceptions" into nyc-support-25.2-dev
9d8319a04ccdb4785ca86fac3a4ff3fc6a368647 23-Feb-2017 Chris Craik <ccraik@google.com> Fix PrefetchRegistry reset, out of bounds exceptions

Bug: 35708283
Test: adb shell am instrument -w -r -e debug false -e size small android.support.v17.leanback.test/android.support.test.runner.AndroidJUnitRunner
Test: adb shell am instrument -w -r -e debug false -e size small android.support.v7.recyclerview.test/android.support.test.runner.AndroidJUnitRunner
Test: ran BrowseFragmentTest / BrowseSupportFragmentTest 5 times in a row, each

Improper reset of the prefetch registry in conjunction with partial
prefetch of invisible views was causing negative item positions to be
attempted to be loaded.

This allows us to un-@Suppress the browse fragment tests in leanback
lib tests.

Change-Id: I931b25d560c9229676cfbec4b217abcbf7e43b4b
rowseFragmentTest.java
rowseSupportFragmentTest.java
c3425074fddb15e4dc70d45a6929552181fb526d 23-Feb-2017 Dake Gu <dake@google.com> Merge "Maybe fix flaky testDetachCalledWhenDestroyFragment" into nyc-support-25.2-dev am: c24a66bc90 am: 0c43a1711c
am: 8a50370c48

Change-Id: Id65c8ac61402716929684e0b245c2e544a8a3531
c24a66bc90371631a9d9124e38ae1d19e158e966 23-Feb-2017 Dake Gu <dake@google.com> Merge "Maybe fix flaky testDetachCalledWhenDestroyFragment" into nyc-support-25.2-dev
49ffb93aafec0e9f82e72cbbb844c064f7dd668b 23-Feb-2017 Chris Craik <ccraik@google.com> Temporarily suppress Browse fragment tests am: ab6d8e6568 am: dcfbe3b89f
am: bb6a94c22b

Change-Id: I1fb7e62ba2669996682cd4825b9fb08fcd2fe367
ab6d8e656800efdb3de2595880c1fd24fd0d5d7d 23-Feb-2017 Chris Craik <ccraik@google.com> Temporarily suppress Browse fragment tests

Test: none
Bug: 35708283

Change-Id: I7c87cff9951bec650af7597f9805844a27b87bc8
rowseFragmentTest.java
rowseSupportFragmentTest.java
6f8b365afb35cda46d1c4042ce633c1177197808 23-Feb-2017 Dake Gu <dake@google.com> Maybe fix flaky testDetachCalledWhenDestroyFragment

The activity.isDestroyed() flag might be toggled before
fragment gets destroyed, changed test to wait fragment
being destroyed.

Bug: 35462054
Test: testDetachCalledWhenDestroyFragment
Change-Id: Ib6b666a8dd8becdd7e4312dfe6dc2020862ace9f
laybackFragmentTest.java
laybackSupportFragmentTest.java
laybackTestFragment.java
laybackTestSupportFragment.java
ingleFragmentTestBase.java
ingleSupportFragmentTestBase.java
cc1e4e759352cc00cfd1d7750f88d8bc8987f400 18-Feb-2017 Dake Gu <dake@google.com> Disable flaky DetailsFragment parallax and video test

Bug: 32022097
Test: DetailsFragmentTest, DetailsSupportFragmentTest
Change-Id: Iac3b7fa73a5e87a6aebad5619577bcabd1ef4b6f
etailsFragmentTest.java
etailsSupportFragmentTest.java
9c6e3b7efd131555af309968f3043878e69446af 18-Feb-2017 Dake Gu <dake@google.com> resolve merge conflicts of d27354038a to master

Change-Id: I67d5c7af137b92a0cb7b1f6988e30529319d2784
9869eb38607552105baa88a0fcba610461045eb5 16-Feb-2017 Dake Gu <dake@google.com> DetailsFragment: move navigation actions out of focusSearch

Move the showTitle and slideOut actions from focusSearch()
method to when focus actually changed.

Doing actions in focusSearch is generally a bad idea, wont work
with talkback which completely bypass the focusSearch() senario.
This is first step toward supporting talkback.

Refactored DetailsFragmentTest and added script to generate
DetailsSupportFragmentTest.
Added Test of navigation between video/rows/title using
requestFocus and DPAD.

Test: DetailsFragmentTest DetailsSupportFragmentTest
Bug: 35437018

Change-Id: I01f51c07675dc6858fbc1a83ea23921294fb48ac
etailsFragmentTest.java
etailsFragmentTestActivity.java
etailsParallaxTest.java
etailsSupportFragmentTest.java
etailsTestFragment.java
etailsTestSupportFragment.java
eadersFragmentTest.java
eadersSupportFragmentTest.java
laybackOverlayFragmentTest.java
owsFragmentTest.java
owsSupportFragmentTest.java
ingleFragmentTestActivity.java
ingleFragmentTestBase.java
ingleSupportFragmentTestActivity.java
ingleSupportFragmentTestBase.java
de39cf8662d98652c9a029dab83fccfb8fc0c773 15-Feb-2017 Dake Gu <dake@google.com> Merge "cleanup life cycle issue of PlaybackGlue in PlaybackFragment." into nyc-support-25.2-dev am: e1189fdd45 am: 262496792f
am: d898cf23cb

Change-Id: I0d537747709095f1c17ef230a074508cfcf3234e
f37579e64940bfdd642cc315f6347d60b5addd69 15-Feb-2017 Dake Gu <dake@google.com> cleanup life cycle issue of PlaybackGlue in PlaybackFragment.

onDetachedFromHost should be called in onDestroy. A PlaybackGlue
should survive onDestroyView for the case setRetainInstance(true).
When configuration change, we should not need recreate PlaybackGlue.
Add a VideoFragmentTest.

Refactoring Tests to use SingleFragmentTestBase and remove
lots of redundant test Activity classes and layout files.

Changed test mp4 to be h264 Baseline profile so it can play
on API 19.

Bug: 35364233
Test: added VideoFragmentTest VideoSupportFragmentTest

Change-Id: I93bd8cbf449ac0fea4b6b76d10dc611c538283e8
laybackControlSupportGlueTest.java
laybackFragmentTest.java
laybackOverlayFragmentTest.java
laybackOverlayTestActivity.java
laybackOverlayTestFragment.java
laybackSupportFragmentTest.java
laybackSupportTestActivity.java
laybackSupportTestFragment.java
laybackTestActivity.java
laybackTestFragment.java
laybackTestSupportFragment.java
ingleFragmentTestActivity.java
ingleFragmentTestBase.java
ingleSupportFragmentTestActivity.java
erticalGridFragmentTest.java
erticalGridSupportFragmentTest.java
ideoFragmentTest.java
ideoFragmentTestActivity.java
ideoSupportFragmentTest.java
ideoTestFragment.java
fb82bb8228e355585d4131d73e3a67b0a9c3b128 11-Feb-2017 Dake Gu <dake@google.com> Merge "Call onDetachedFromHost when closing PlaybackFragment" into nyc-support-25.2-dev am: a13aca9d17 am: 0aa1e534f3
am: 9e0b08fb9d

Change-Id: If87081aee503a524bcf7dd32da80ce45b26a73bf
d34f4eb6802453f26a0df113017bc5792fc19868 10-Feb-2017 Dake Gu <dake@google.com> Call onDetachedFromHost when closing PlaybackFragment

Fix our sample leaking MediaPlayer.

Bug 35246768
Test: PlaybackFragmentTest PlaybackGlueTest

Change-Id: I8ed0755e2ea2df3cb6b5e7a9e8d6bf9cd56495a1
laybackFragmentTest.java
60861380527324c294eb3bde83832b682672d2f5 07-Feb-2017 Dake Gu <dake@google.com> Leanback: fix late selection of BaseRowsFragment am: 514b6d101c am: ffda6b9b6f
am: 4fae16d02c

Change-Id: I42a82acc75b87f5ce41a01c1458a1ac7fbe36764
514b6d101c6b7d4b7151cf8789424bde66fab511 06-Feb-2017 Dake Gu <dake@google.com> Leanback: fix late selection of BaseRowsFragment

If view was layout before adapter gets data, mSelectedPosition
will be overwritten by onChildViewHolderSelected() event with -1.
The test was only failing on 4.4 and 5.0 because those platform
seems has extra layout pass at beginning. Added manual
requestLayout to test the situation.

Bug: 34777164
Test: RowsFragmentTest RowsSupportFragmentTest

Change-Id: I7e2c78a32a1074586024c52f4a67427393a550e6
owsFragmentTest.java
owsSupportFragmentTest.java
e746df62af14ac8ff65591723cc00e6100c56303 04-Feb-2017 Dake Gu <dake@google.com> Disable the new RowsFragmentTest am: 1d3f9193bf am: a701947d87
am: 94b1f8d976

Change-Id: Ibe43234062d25612194bdc8d6856cccb2d9183a3
1d3f9193bfe7929dec656536813f02e5ba281883 04-Feb-2017 Dake Gu <dake@google.com> Disable the new RowsFragmentTest

Still failing on nexus4 and nexus5.
Could be timing, will investigate later.

Bug: 34777164

Change-Id: I554f41f90f82540a0e9c51a49d3360e73d80a327
owsFragmentTest.java
owsSupportFragmentTest.java
a9a6ca6b28e8b13ac86d06c4c28d2cd4cd63a244 04-Feb-2017 Dake Gu <dake@google.com> Fix RowFragmentTest am: ea89ed4fd1 am: 7e790f01df
am: f1d604e866

Change-Id: Id23f4a7e05a96f0c8cc9e7f9f929dffdd60040c5
ea89ed4fd190e0b2a0fe595f2172bc649af67bf7 04-Feb-2017 Dake Gu <dake@google.com> Fix RowFragmentTest

Remove assertNull(findByPostion(0)) which is unnecessary
and depending on screen height.

Bug 34777164

Change-Id: I2728aa59a7d85236246b1f44c6d43042af930137
owsFragmentTest.java
owsSupportFragmentTest.java
d1f8db58a3100b6a6e9238425033d5a75fb7fbca 02-Feb-2017 Dake Gu <dake@google.com> resolve merge conflicts of 60b5f34d83 to master

Change-Id: I1ff2ef4837844005acba12869bfbb3fff1975ce0
50cf9ada93e50e906f20f5edf595234ada196d45 28-Jan-2017 Dake Gu <dake@google.com> Add option to allow customize HeadersFragment

To support enable/disable focus scale of HeadersFragment,
Refactored BaseRowFragment and Presenter to allow retaining
the same ItemBridgeAdapter when wrapped Adapter changes or
Presenter changes. So user can set up FocusHighlight
on the ItemBridgeAdapter without worrying it was overwritten
when recreating the ItemBridgeAdapter.
Added BrowseFragment.onCreateHeadersFragment() for user to
override HeadersFragment.

Added more test in RowsFragmentTest, Added HeadersFragmentTest.

Bug: 34777164
Test: RowsFragmentTest RowsSupportFragmentTest
HeadersFragmentTest HeadersSupportFragmentTest

Change-Id: Id3fbc9cb0b5b0a3c637d9bc789bb1104fbaa21f3
eadersFragmentTest.java
eadersSupportFragmentTest.java
owsFragmentTest.java
owsFragmentTestActivity.java
owsSupportFragmentTest.java
owsSupportFragmentTestActivity.java
owsTestFragment.java
owsTestSupportFragment.java
ingleFragmentTestActivity.java
ingleFragmentTestBase.java
ingleSupportFragmentTestActivity.java
ingleSupportFragmentTestBase.java
35232c6eaeb9b99f390cb8ef0ac83bf45fa0b3fa 01-Feb-2017 Aurimas Liutikas <aurimas@google.com> Update test sizes for all currently @SmallTest.

SmallTests are supposed to complete in <200ms, Medium in <1s, and Large in <30s.
This CL updates the size of all the SmallTest based on excecution times from
presubmit test runners.

Test: None
Bug: 34854821
Change-Id: Iec73f7b6ef63b27cd3d8b19a8e8c7a9b91ff6729
ackgroundManagerTest.java
etailsParallaxTest.java
uidedStepFragmentTest.java
istRowDataAdapterTest.java
owsSupportFragmentTest.java
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTest.java
28f32a294cf077dd4c681f24581b3eec902ec633 30-Jan-2017 Dake Gu <dake@google.com> Leanback: parallax and details video API refactoring
am: e1cde4d4ac

Change-Id: I9f1111e1e895087430cede7607aebf488c159b0e
e1cde4d4ac42a6e9e16aad2b4df970c7c7d0771c 21-Dec-2016 Dake Gu <dake@google.com> Leanback: parallax and details video API refactoring

There are too many new concpets introduced when we create
multiple building blocks around parallax. This CL tries to
get rid of some classes.

1. Remove class ParallaxSource, integrated into Parallax.
So there is no more setSource()/getSource().

2. Replace DetailsParallaxManager with DetailsParallax. It is no
longer a manager pattern but DetailsParallax is a direct
subclass of Parallax.

3. Replace DetailsBackgroundParallaxHelper with
DetailsParallaxDrawable which is a direct subclass of
CompositeDrawble. No more helper concept.

4. remove the glue creation API from DetailsFragment, those
are not necessary and app can do it on the side.

The summary of new classes:
1. Parallax, tracks multiple UI events and perform multiple
ParallaxEffects on ParallaxTargets. RecyclerViewParallax is a
subclass of Parallax that monitors RecyclerView child positions.

2. DetailsParallax is a subclass of RecyclerViewParallax,
DetailsFragment holds the DetailsParallax object and is responsible
to attach it to VerticalGridView and sync with Transition animation.
DetailsParallax is shared by both background bitmap and video.

3. Created a DetailsFragmentBackgroundController class responsible
for parallax background and embedded video playing.

Bug: 33750080
Bug: 33751156
Test: all existing leanback tests

Change-Id: Iec81a444d5d4fbeb675f16222b09b407acf007a2
etailsFragmentTest.java
etailsParallaxManagerTest.java
etailsParallaxTest.java
etailsTestFragment.java
1280c97a74d8f7ffce277030916541af96090f3f 06-Jan-2017 Dake Gu <dake@google.com> Fix ListRowDataAdapter notifyItemRemoved
am: 09cc61cbcf

Change-Id: Ib1d4f4b1151ac993423b667bd82ce7fba8a08279
09cc61cbcf87063fb5f540a1f2e6c52773ca2cb2 06-Jan-2017 Dake Gu <dake@google.com> Fix ListRowDataAdapter notifyItemRemoved

Bug: 34114032
Test: itemRangeChangeRemove
Change-Id: If9f2a7ef4d65486a5c45bc757a24c0129b3dfb11
istRowDataAdapterTest.java
ea4a7d47b3295423826ca9dfa41440b495360e48 06-Jan-2017 Dake Gu <dake@google.com> BrowseFragment: fix ListRowDataAdapter ArrayIndexOutofBound
am: 5d19666305

Change-Id: I79fe0984d24651a0a3417b089d694e8a7b03adfe
5d196663056735d8f1453ed3aeab75e8d922a159 06-Jan-2017 Dake Gu <dake@google.com> BrowseFragment: fix ListRowDataAdapter ArrayIndexOutofBound

When it re-calculate the last visible Row, it should
handle the case of visible row does not exist.

Bug: 34070375
Test: ListRowDataAdapterTest
Change-Id: I3d04d4eab3e9975c7c3527e2010f0879856e1b6d
istRowDataAdapterTest.java
ff6dae3b13293d8c2aecd1765b42413d68730cc3 04-Jan-2017 Dake Gu <dake@google.com> RowsFragment: use default alignment if setAlignment() not called am: 5083c1eeb9
am: fa32b49111

Change-Id: I89bebe8d300d4705d5316b2acbbc4de28257f4bd
5083c1eeb9cea04354f7ad4cea84a6d27ce985dd 03-Jan-2017 Dake Gu <dake@google.com> RowsFragment: use default alignment if setAlignment() not called

Some apps expects default alignment, a regression in support lib
25 will make RowsFragment rows to align to top of screen by default.

Bug 33279341
Test RowsFragmentTest RowsSupportFragmentTest

Change-Id: I2a8c78ac1c40fe6c0b12b624ab99bb6ced06a8ee
owsFragmentTest.java
owsFragmentTestActivity.java
owsSupportFragmentTest.java
owsSupportFragmentTestActivity.java
owsTestFragment.java
owsTestSupportFragment.java
1e0d6ff0ff4d23aefa73594440a84d5354ec9bc2 29-Dec-2016 Dake Gu <dake@google.com> DetailsFragment: fix regression of missing title View am: 5bcc058bb1
am: d980edc50d

Change-Id: I8e7f2c3043bc862c4b95c9926fed8ac73a126ed1
5bcc058bb1aed2e88b38009e83084554cf2cd86b 29-Dec-2016 Dake Gu <dake@google.com> DetailsFragment: fix regression of missing title View

When title view and VideoFragment both exist, title view becomes
display only. When there is no VideoFragment, user can focus
to title view and do search, that is backward compatible with
behavior in 25.0.0

Bug: 33839988
Test: SupportLeanbackDemos DetailsFragmentTest

Change-Id: I52156993914a427d52b658ea10cd815632ca4fe3
etailsFragmentTest.java
138a3b4073591eaa0c31489f869f873bd30646d1 29-Dec-2016 Keyvan Amiri <keyvana@google.com> Added missing selected listener to the new playback fragments am: 4c9758b250
am: fd7600e1c3

Change-Id: Ie87d4d660ad56d651599684f8e118172df87d0df
4c9758b25091b36c0fd55bf422188e5ac9314da4 22-Dec-2016 Keyvan Amiri <keyvana@google.com> Added missing selected listener to the new playback fragments

BaseOnItemViewSelectedListeners were missing from the new
PlaybackFragment and PlaybackSupportFragment. This listener is invoked
once the focus changes across different items of a PlaybackControlsRow or
external rows of a playback fragment.
Also created test suites for both PlaybackFragment and
PlaybackSupportFragment with selected and clicked listener tests.

Fixes: 33779048
Test: ./gradlew support-leanback-v17:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v17.leanback.app.PlaybackFragmentTest
./gradlew support-leanback-v17:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v17.leanback.app.PlaybackSupportFragmentTest

Change-Id: Ia6ee8e14b19f7ff81d8c1cfb87d8e3fca84f963c
laybackFragmentTest.java
laybackSupportFragmentTest.java
laybackSupportTestActivity.java
laybackSupportTestFragment.java
laybackTestActivity.java
laybackTestFragment.java
f3f1bb8b3c8051b74ffab1d71245e9091b3ab25e 16-Dec-2016 Dake Gu <dake@google.com> GuidedStepFragment: fix replacing actions when subActions expanded am: a51a405279
am: fe4b61187c

Change-Id: I809894051bfb622346cced88578cb88c701fcdcb
a51a405279fb81135abbb7c25ba431842582c8c8 15-Dec-2016 Dake Gu <dake@google.com> GuidedStepFragment: fix replacing actions when subActions expanded

Bug: 32858270
Test: GuidedStepFragmentTest#setActionsWhenSubActionsExpanded
Change-Id: I98ad2b08ec9199751b93727e6438c9081860f9a1
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
d0d6a4830381add2ec45edded1008dd03482b460 15-Dec-2016 Keyvan Amiri <keyvana@google.com> Fixed playback row callback not notified in updateRowMetaData am: 8f2df00092
am: e1959588e3

Change-Id: I5f39bdd7138c5ce783a4c7e4e29b9cc2af582bc9
8f2df00092bacbb31c883023b242bc5738bea36f 14-Dec-2016 Keyvan Amiri <keyvana@google.com> Fixed playback row callback not notified in updateRowMetaData

onRowChanged callback was originally called from updateRowMetaData() in
PlaybackControlGlue. After switching to the new host, this callback was
not triggered if developers didn't use the new glue host.
This resulted in the playback row UI not being updated (e.g.
progress bar missing, no updates to media title).
Now triggered onRowChanged callback for PlaybackGlueHostOld and
PlaybackSupportGlueHostOld.
Also, updated the demo app to simulate preparing a media item and
checking whether the UI is propery updated.

Change-Id: I55b14b88a2d8e9c68af34b775c4eb7a93ee84da6
Fixes: 33559090
Test: ./gradlew support-leanback-v17:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v17.leanback.app.PlaybackControlGlueTest#testOnRowChangedCallback
./gradlew support-leanback-v17:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v17.leanback.app.PlaybackControlSupportGlueTest#testOnRowChangedCallback
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
ccbf5928973bedf3a1ac50ddb7dea8b9588e92bb 08-Dec-2016 Dake Gu <dake@google.com> Fix PlaybackOverlayFragment sample not work.
am: ef05d5494f

Change-Id: Ifc4003000f810b1726ae5cffc92d548d13b2f9e4
ef05d5494fac2cc80f95d2627e1ec31615de360d 07-Dec-2016 Dake Gu <dake@google.com> Fix PlaybackOverlayFragment sample not work.

Restore the old PlaybackControlGlue code that bypass onItemViewClicked
if action is proceeded. This isn't a problem for new PlaybackControlGlue
which doesn't expose onItemViewClicked event.

Also add missing call to onCreateSecondaryActions.

Restore sample code for PlaybackOverlayFragment.

Bug: 33415386
Test: PlaybackControlGlueTest

Change-Id: Ic3747aee2adca0f056f610fb35261ef005f65fe1
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
f0ec78048f9babb4d7586425721c29d1f598a52f 23-Nov-2016 Aurimas Liutikas <aurimas@google.com> Disable flaky DetailsFragmentTest#parallaxTest.

Bug: 32022097
Test: Test no longer runs
Change-Id: Ia1f9ff628649637f5144bb11ab50567e9f0c95a0
etailsFragmentTest.java
34b46f02a89224481777e7de93d6e22e45e41e96 08-Nov-2016 Dake Gu <dake@google.com> Support parallax in transition and fix alpha performance

Add ParallaxTransition class to perform ParallaxSource.updateValues()
on every frame. DetailsFragment sets ParallaxSource as a View tag during
setup.

Changed details parallax effect to reduce overdraw, now bitmap's bottom is
matching top of details_frame, solid_color's top is matching bottom of
details_frame. Their bounds will change during enter/exit transition.

Switch details_background_view to non overlapping rendering view to avoid
creating expensive layers in alpha animation.

Bug: none
Test: DetailsFragmentTest and visually inspect SupportLeanbackDemos

Change-Id: Iaac20e6c733a0e42e5f8eeef2b912b0e26e2f606
etailsFragmentTest.java
0908efd712e79f77e0cf9307bd5c32753c855561 04-Nov-2016 Dake Gu <dake@google.com> Details Background improvement:

Add ParallaxManager.setRecyclerView() to allow create ParallaxManager
before fragment view is created. Updated sample app to setup
Parallax background/video effects in DetailsFragment.onCreate()

Add onCreateParallaxManager() for customize.

Clean up some unused code in BackgroundManager.

Bug: none
Test: SupportLeanbackDemos
Change-Id: I9945e4d893a12f4f2f48d44175d6e27a4f1d287d
etailsParallaxManagerTest.java
etailsTestFragment.java
0f0aefe1f8065909a00b86d4f70d5bfcfd202873 05-Nov-2016 Dake Gu <dake@google.com> Fix BackgroundManagerTest

onStart() might be called multiple times, should attach before
onStart or check if isAttached().

Bug: none
Test: inheritColorByNewActivity
Change-Id: Id42d2b53ffefcff6cca6067aca7330de3b97a6e3
ackgroundManagerTest.java
181c8847d5a1169e26755ed690131333b7fff7e9 28-Oct-2016 Dake Gu <dake@google.com> Rework background manager and add TestCases

1. Simplify background layerDrawable from 5 layers to 2 layers.
Especially disable the DimLayer to reduce graphics burden.
2. Made release() in onStop() a default behavior to reduce
possible memory growing.
3. Top activity will inherit background from bottom activity,
but not the other way. This fixes the problem that BrowseActivity
inherits DetailsActivity's parallax background after returns from
it.
5. Add convenient method to query selected item in BrowseFragment.
6. updated samples to handle background change in opening/closing
header fragment and reapply background when returning to the
activity (onStart)
7. Added new BackgroundManagerTest

Bug: 32415435
Test: BackgroundManagerTest

Change-Id: I93a026d3e1437c93e22cf0a2fa456d0b3e5f15b7
ackgroundManagerTest.java
estActivity.java
33745571090988658626bb853e6ea981d175c78b 28-Oct-2016 Dake Gu <dake@google.com> leanback: fix expectation of fragment lifecycle.

The new support fragment is now lazy loaded while restoring.

Bug: 32452864
Test: GuidedStepSupportFragmentTest

Change-Id: Ice0bd4d50d602cb5bfbfa2de2611dbb67104c6e1
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
2ad490fdf16accbe555e11a3a1ecdb26c9a87a66 21-Oct-2016 Dake Gu <dake@google.com> BrowseFragmentTest: Move read ops into UI thread.

To avoid read intermidate data in layout or scroll
Might fix Bug 30943877

Change-Id: If79ddf574127c7903b28760cb8cf19f92cff0b21
rowseFragmentTest.java
rowseSupportFragmentTest.java
fe552f1dd322b48aeda32ae67ad9238e601d3cc3 19-Oct-2016 Dake Gu <dake@google.com> Add more debug information for testSelectCardOnARow

Bug: 30943877
Test: BrowseFragmentTest
Change-Id: I1d51c40939b1bd59c67fd71f75e2bb931671689b
rowseFragmentTest.java
rowseSupportFragmentTest.java
16fc62b4abedcadbd422892a590199011972ef8b 19-Oct-2016 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Add checkstyle:off flag"
cc671dd3caac1d0cbf3f6999ab063c9ff1f297b2 18-Oct-2016 Dake Gu <dake@google.com> Add checkstyle:off flag

Test: None
Bug: 32243836

Change-Id: I5c28ee5b4623e25126518ceb99f17b5ee384cb76
rowseSupportFragmentTest.java
rowseSupportFragmentTestActivity.java
rowseTestSupportFragment.java
uidedStepSupportFragmentTest.java
uidedStepSupportFragmentTestActivity.java
uidedStepSupportFragmentTestBase.java
uidedStepTestSupportFragment.java
laybackControlSupportGlueTest.java
erticalGridSupportFragmentTest.java
3bd47bb01a2654f8399e89d227d40f99393b1844 18-Oct-2016 Dake Gu <dake@google.com> Add more debugging information for NPE in BrowseFragmentTest

Test: BrowseFragmentTest BrowseSupportFragmentTest
Bug: None
Change-Id: Ia9c2158f1b8a68a50e888ffe66ac3be6107461aa
rowseFragmentTest.java
rowseSupportFragmentTest.java
rowseTestFragment.java
rowseTestSupportFragment.java
erticalGridSupportFragmentTest.java
369ad7d6d14901b06406e7959e124152fdc665ef 17-Oct-2016 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Adding unit test for VideoFragment."
c22611ecee4fcc5c1ad27f4367c0c2c00368d488 17-Oct-2016 susnata <susnata@google.com> Adding unit test for VideoFragment.

Test: VideoFragmentTest
Change-Id: I684560bb5d4a09296fed30058f0cd5b437ca5187
ideoFragmentTest.java
ideoFragmentTestActivity.java
ideoTestFragment.java
8d82210fca5f250a2b370031c120376251ed2340 17-Oct-2016 Dake Gu <dake@google.com> Fix Broken DetailsFragment ParallaxTest

Bitmap bottom matches details frame bottom now.
Bug: none
Test: DetailsFragmentTest

Change-Id: I52b93124027301f9ae413120dc652b1b3a401584
etailsFragmentTest.java
6f5495baf9acf7b275839e4a1eea091781fd112b 14-Oct-2016 Susnata Basak <susnata@google.com> Merge "Adding video player to DetailsFragment."
4702556bfd15c9819a7b2af759aee0f719cd631f 11-Oct-2016 susnata <susnata@google.com> Adding video player to DetailsFragment.

Added VideoFragment for rendering videos to DetailsFragment.
Video playback will be configured by DetailsFragmentVideoHelper.
Parallax functionality will continue to be configured by
DetailsBackgroundParallaxHelper. ParallaxManager will be shared
between the helpers for running animations based on the position
of DetailsOverview view.

Updated LeanbackSupportDemo(NewDetailsFragment) sample code to
use the video player.

Test: None
Change-Id: Iaeee2caf3b7f3567e4a53ad76574db9adaa32ba0
etailsTestFragment.java
laybackOverlayTestFragment.java
439955872f652135e496c117b2aadaace9ae7274 13-Oct-2016 Dake Gu <dake@google.com> maybe fix flaky BrowseFragmentTest

close activity after test, so keys wont be sent to
wrong activity.

Change-Id: If4f52bc0d09aecbd1dab2082f024ed77c3e47ef9
rowseFragmentTest.java
rowseSupportFragmentTest.java
b50e46706ac654b071942bd7f6ba059c14c9c29a 12-Oct-2016 Dake Gu <dake@google.com> Fix flaky GridWidgetTest more

Test: testFocusToFirstItem GuidedStepFragmentTest
Bug: None

Change-Id: I815284eb38ae181b18fe229a89c66eb288b5bfb2
uidedStepFragmentTest.java
uidedStepFragmentTestBase.java
uidedStepSupportFragmentTest.java
uidedStepSupportFragmentTestBase.java
42df898f89e60afe9d45b95c8ce86e6b6fce89ce 11-Oct-2016 Dake Gu <dake@google.com> Maybe fix flaky test

fragment onDestroy might be a bit later than activity onDestroy
for finishing animation.

Bug: None
Test: GuidedStepFragmentTest
Change-Id: I7043f3bf163daeca97e34e010a775bdf78e458dc
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
38492e136b11ce9fdeed7af028c6d4eff1d7a6ac 03-Oct-2016 Dake Gu <dake@google.com> leanback: fix flaky test

Hide navigation bar too.

Bug: 31771962
Test: tested on Nexus 5 API 23

Change-Id: I259888e3461c124b79df5276a425f71af92e05d2
etailsFragmentTestActivity.java
b3034c5df0d06f3dbfa466af19b1f014967f3d75 29-Sep-2016 Dake Gu <dake@google.com> Leanback: Fix flaky tests

Test: modified
Bug: 31771962

Change-Id: Id44203e3ed696bd63d2661f0a4e67a7e3a889d1b
etailsFragmentTestActivity.java
42e7d6fafcde7bfe261dd7d8d75ee53ca0cd6790 28-Sep-2016 Aurimas Liutikas <aurimas@google.com> Replace usage of Instrumentation#runOnMainSync with ActivityTestRule#runOnUiThread.

ActivityTestRule#runOnUiThread handles exceptions correctly and thus should be used
in place of Instrumentation#runOnMainSync. This changes most of these use-cases
except for tricky cases.

Bug: 31801302
Test: ran support-design:connectedCheck and support-appcompat:connectedCheck
Change-Id: I70904aef89e6bbc2a3cff1b3be697258d666e316
rowseFragmentTest.java
rowseSupportFragmentTest.java
etailsFragmentTest.java
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
738deb3f9c75ea32dff1bf335753703e40e87f39 28-Sep-2016 Dake Gu <dake@google.com> lenaback: Fix Details parallax on different screen resolution

DetailsFragment is using absolute value for aligning overview row.
Make parallax also use absolute value.
Fix NPE in CompositeDrawable Property when get() is called before set().
Fix NPE in DetailsTestFragment delayed handler.

Test: passed unit test on API 19, API 23, API 24 with different
resolutions
Bug: 31771962

Change-Id: Id97c0649f7c851cf9906c42aa607ecc55ce4ef20
etailsFragmentTest.java
etailsTestFragment.java
754cb29c50f09a83251dd4bb633ba445b2411adb 27-Sep-2016 Aurimas Liutikas <aurimas@google.com> Switch from deprecated size annotations to new ones.

Switching from android.test.suitebuilder.annotation.*Test
to android.support.test.filters.*Test.

Bug: 30074170
Test: manual - ran small appcompat tests, they still run and pass
Change-Id: Idce58b988c8e1a809f7f5fae67e0e235159d9fc5
rowseFragmentTest.java
rowseSupportFragmentTest.java
etailsFragmentTest.java
etailsParallaxManagerTest.java
uidedStepFragmentTest.java
uidedStepSupportFragmentTest.java
istRowDataAdapterTest.java
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
laybackOverlayFragmentTest.java
erticalGridFragmentTest.java
erticalGridSupportFragmentTest.java
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTest.java
180dc4030628425a8081fe058bdc1d529c505ae8 26-Sep-2016 susnata <susnata@google.com> Revert "Revert "Refactoring DetailsBackgroundParallaxHelper.""

This reverts commit 6eebd92660979650cbde3b9d303099cff3015a23.

Test: DetailsFragmentTest, DetailsParallaxManagerTest
Change-Id: I86a3ef75b862a60f7dcef037e7d4eebcaa488785
etailsFragmentTest.java
etailsFragmentTestActivity.java
etailsParallaxManagerTest.java
etailsTestFragment.java
hotoItem.java
d28c4182e0dd46d83027fcf9e5f43aa669c7514c 26-Sep-2016 Aurimas Liutikas <aurimas@google.com> Merge "Revert "Refactoring DetailsBackgroundParallaxHelper.""
6eebd92660979650cbde3b9d303099cff3015a23 26-Sep-2016 Aurimas Liutikas <aurimas@google.com> Revert "Refactoring DetailsBackgroundParallaxHelper."

ag/1459549 broke support library test builds:
https://android-build.googleplex.com/builds/submitted/3301972/support_test_apks/latest/logs

This reverts commit d7ba0d89531101088939239bb0339658dbe6c85b.

Change-Id: Ia60f9696e2bce6952e46763c645151f0b93a126e
etailsFragmentTest.java
etailsFragmentTestActivity.java
etailsParallaxManagerTest.java
etailsTestFragment.java
hotoItem.java
2a9b6dfcc745e9ebe3697b590d7f5cdd116b0c3f 24-Sep-2016 Dake Gu <dake@google.com> Fix Crash when Fragment is removed after startEntranceTransition

Bug: 31398332
Test: VerticalGridFragmentTest.immediateRemoveFragment
VerticalGridSupportFragmentTest.immediateRemoveFragment

Change-Id: If40fa401f985e44436f9c9c62002a5d817e7413a
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
erticalGridFragmentTest.java
erticalGridSupportFragmentTest.java
9daa79a86eb2f50966ee5277b1faa03c72f6ef8c 24-Sep-2016 Susnata Basak <susnata@google.com> Merge "Refactoring DetailsBackgroundParallaxHelper."
d7ba0d89531101088939239bb0339658dbe6c85b 19-Sep-2016 susnata <susnata@google.com> Refactoring DetailsBackgroundParallaxHelper.

Test: added DetailsParallaxManagerTest and existing unit tests pass.
Change-Id: I6c06ac944da6ffc62875c03edfa6f4fb21e5fee5
etailsFragmentTest.java
etailsFragmentTestActivity.java
etailsParallaxManagerTest.java
etailsTestFragment.java
hotoItem.java
ad3fd6c48f41ef20e63da40c626b053620526ccc 21-Sep-2016 Dake Gu <dake@google.com> leanback: add test case of workaround VideoView forcing focus problem

Bug: 31002837
Test: Added

Change-Id: If24b7a131715fe4326ce42b0b8d7c36beef9b07c
laybackOverlayFragmentTest.java
laybackOverlayTestActivity.java
laybackOverlayTestFragment.java
3103f63e99d47573823957f7aa34308555873221 20-Sep-2016 Aurimas Liutikas <aurimas@google.com> Fix all operator wrapping issues in leanback library.

Test: code still compiles, there should be no code/logic changes.
Change-Id: I6e97e2ba429c323022055263540c3fb6d0003822
rowseFragmentTest.java
rowseSupportFragmentTest.java
rowseTestFragment.java
rowseTestSupportFragment.java
uidedStepFragmentTestBase.java
uidedStepSupportFragmentTestBase.java
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTest.java
def88bf62957a74d3257dd26bd50214e5ef1c610 20-Sep-2016 Dake Gu <dake@google.com> PlaybackControlGlue: MEDIA_PAUSE does not pause FF/RW am: 39d30689d7 am: 858561f9c1
am: 69f2783849

Change-Id: Idad3e6abae12d4eae3c20294118dde02d2565da7
39d30689d76388f0d025a4fc751c6b4cbe54c492 16-Sep-2016 Dake Gu <dake@google.com> PlaybackControlGlue: MEDIA_PAUSE does not pause FF/RW

Test: added
Bug: 31489271
Change-Id: Ia4af86769dfb3ccc1bdd6a5f08f9ab32f246b45a
laybackControlGlueTest.java
483c63f22a5e6de67350b20045d05930f5006daf 14-Sep-2016 Dake Gu <dake@google.com> Disable testDateRangesDMYFormat

Temporary solution for b/31348985

Change-Id: I3b05193cc73bed18bd2f66858b9452888b46a819
izard/GuidedDatePickerTest.java
9480eb4e94e429726b07eba133ffbc6450b8d795 09-Sep-2016 Alan Viverette <alanv@google.com> resolve merge conflicts of 7243922 to master

Change-Id: I34d800e77c4b1a440eb67191b4697213a2e6239e
c39d9c75590eca86a5e7e32a8824ba04a0d42e9b 25-Aug-2016 Alan Viverette <alanv@google.com> Add @RestrictTo(GROUP_ID) annotations to match @hide docs annotations

Also removes some unnecessary @hide annotations on classes that wouldn't
have shown up in docs anyway due to package/private visibility or NO_DOCS.

Bug: 27937193
Change-Id: Iab127a5a3ce57a2d61965d3cef782621eb3859f5
rowseFragmentTest.java
rowseFragmentTestActivity.java
rowseSupportFragmentTest.java
rowseSupportFragmentTestActivity.java
rowseTestFragment.java
rowseTestSupportFragment.java
tringPresenter.java
804ebd45e0287b6f421373fb6bd2a453a3acfda0 25-Aug-2016 Dake Gu <dake@google.com> fix BrowseFragmentTest static variable issue

Some short test doesn't wait the post Handler to be run. When
Handler runs, static variable SET_ADAPTER_AFTER_DATA_LOAD is
changed by another test.

Change static variable to member variable and check activity
close as well.

Bug 30943877

Change-Id: I62f317fcf22930f055d4ff52863b75ea06d448c6
rowseFragmentTestActivity.java
rowseSupportFragmentTestActivity.java
rowseTestFragment.java
rowseTestSupportFragment.java
39da5d9a905a8fecf85a26f4eb12cb016d5504a3 24-Aug-2016 susnata <susnata@google.com> Fixing NPE crash in BF. am: 35d7a6c316 am: 7f6acb9d36 am: 79d88519e4
am: bf82d63ae5

Change-Id: Ib8bb5678046d9a5f1bcd9a484d2a3b63f36d5c3d
7f6acb9d36fa124ed923bb06288a10f048ebf9b0 24-Aug-2016 susnata <susnata@google.com> Fixing NPE crash in BF.
am: 35d7a6c316

Change-Id: Iea68a90da4bd3bef70372e5d663a42dacf233c55
35d7a6c31606ed4ca38deda3cacae080a95c95c9 22-Aug-2016 susnata <susnata@google.com> Fixing NPE crash in BF.

Change-Id: I1bfb77865b6eb6e64814309ecf43e8bf1b7faa77
BugFix: 31011043
rowseFragmentTest.java
rowseFragmentTestActivity.java
rowseSupportFragmentTest.java
rowseSupportFragmentTestActivity.java
rowseTestFragment.java
rowseTestSupportFragment.java
ed4d80574b72e7094cd0af05870f75efa9a641bf 23-Aug-2016 Keyvan Amiri <keyvana@google.com> Merge "Leanback tests: Updated guidedaction tests to use the new ActivityTestRule - Added a separate test for toggling enable flag for guidedactions - broke down the subaction tests into smaller and more modular components"
64bee407bd472b4218f531b6750c4e7cffa7b5a4 23-Aug-2016 Dake Gu <dake@google.com> Fix BrowseFragmentTest
am: 61b8004f63

Change-Id: If1e48fe8316c6b6e63017b6ee8e0b3c2f89847b6
e54bb704defe5ae96d2221113bec2dec61523e0e 23-Aug-2016 Dake Gu <dake@google.com> leanback: fix NPE caused by late loading main fragment.
am: dc21f7e029

Change-Id: Iab2596f150fd3b508bea99e844797928edfe8b7a
0b168ed894445f4e128c6edb52a8797a0ee532c9 23-Aug-2016 Keyvan Amiri <keyvana@google.com> Leanback tests: Updated guidedaction tests to use the new
ActivityTestRule - Added a separate test for toggling enable
flag for guidedactions - broke down the subaction tests
into smaller and more modular components

Used the new Espresso's ActivityTestRule for GuidedActions test.
Some of the tests were running longer than 30 seconds. Broke down
enable/disable flag tests for GuidedActions into two unit tests.
Also, created separate tests for verifying subactions of different
sizes.

Bug: 30943853
Change-Id: I55822792af8058f2477685a4681b6ff1b122f20e
izard/GuidedStepAttributesTest.java
61b8004f63492071ec95305b5939947f5879dcb2 22-Aug-2016 Dake Gu <dake@google.com> Fix BrowseFragmentTest

Change-Id: I3009e1d11a2b9b38c9562daa357eb3749aeebd8d
(cherry picked from commit d89094b31b55d54d2f3b1f502b15ddbff9e878ca)
rowseFragmentTest.java
rowseSupportFragmentTest.java
dc21f7e02936d3bf1f8e69137393814cefd9846a 20-Aug-2016 Dake Gu <dake@google.com> leanback: fix NPE caused by late loading main fragment.

When main fragment is not created, pressing RIGHT will NPE.
Also fixed sendKey in test.

Bug 30943877

Change-Id: I0b38de24c06a2b13206c9eede0fda857d3ab25fb
(cherry picked from commit 489c9a861b7cde47efcd5cf6351bc9696786ae41)
rowseFragmentTest.java
rowseSupportFragmentTest.java
d89094b31b55d54d2f3b1f502b15ddbff9e878ca 22-Aug-2016 Dake Gu <dake@google.com> Fix BrowseFragmentTest

Change-Id: I3009e1d11a2b9b38c9562daa357eb3749aeebd8d
rowseFragmentTest.java
rowseSupportFragmentTest.java
4be37f97cd7708136e09e5606d3e0ac3c7636a8a 22-Aug-2016 Dake Gu <dake@google.com> Merge "leanback: fix NPE caused by late loading main fragment."
a41f8bee62d8ac4155d803132a2a4c2f274b9f3e 20-Aug-2016 Dake Gu <dake@google.com> Merge "Leanback DatePicker tests: Updated tests to use ActivityTestRule, added leap year tests and broke down test cases into smaller components"
489c9a861b7cde47efcd5cf6351bc9696786ae41 20-Aug-2016 Dake Gu <dake@google.com> leanback: fix NPE caused by late loading main fragment.

When main fragment is not created, pressing RIGHT will NPE.
Also fixed sendKey in test.

Bug 30943877

Change-Id: I0b38de24c06a2b13206c9eede0fda857d3ab25fb
rowseFragmentTest.java
rowseSupportFragmentTest.java
23cd461516e1cb7862ce49f533178460c73b678b 19-Aug-2016 Keyvan Amiri <keyvana@google.com> Leanback DatePicker tests: Updated tests to use ActivityTestRule,
added leap year tests and broke down test cases into smaller components

Added tests for transitioning from leap-year to non-leap years and vice
versa. Also, test cases should finish below 30 seconds. Broke down long
test cases into smaller modules.
Updated these tests to use Espresso's ActivityTestRule.

Bug: 30943853
Change-Id: I54950fec639818b03614568633db154fdc24fe4b
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTestActivity.java
734ed7bc9ea15c6238a089145b90fa8417f9f42d 18-Aug-2016 Dake Gu <dake@google.com> GuidedStepFragment: add tests for sub actions

Test sub actions and BACK key support.
Test finishGuidedStepFragments.

Change-Id: I7bfd56b6d75ede1833c64154284e161612c75ef3
uidedStepFragmentTest.java
uidedStepFragmentTestActivity.java
uidedStepFragmentTestBase.java
uidedStepSupportFragmentTest.java
uidedStepSupportFragmentTestActivity.java
uidedStepSupportFragmentTestBase.java
f0039c1465cd83a4f30c4f0ce24a6b15f3e26874 17-Aug-2016 Aurimas Liutikas <aurimas@google.com> resolve merge conflicts of 019c65e to master

Change-Id: I6846ffff4a5085a15c2786fbebcbd22da746f0bf
fad2335f169d36b7b6f2c0ec8ddfe6c0094c2072 16-Aug-2016 Aurimas Liutikas <aurimas@google.com> Annotate more support lib tests with size annotations.

Turns out we were not running these tests because they are not
annotated with @SmallTest, @MediumTest, or @LargeTest.

Bug: 30892341
Change-Id: I4ed870d4c1a456c1fcd446243179c005653a041d
rowseFragmentTest.java
rowseSupportFragmentTest.java
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTest.java
b8706fd99b0a3724ed8e0c4b97bf37f3cdf389da 12-Aug-2016 Dake Gu <dake@google.com> Add GuidedStepFragment tests

Including back stack test, life cycle test,
view state save/restore test.

Change-Id: I66fd8e57c8be9bb7a23170284ddd72ca860893d4
rowseSupportFragmentTest.java
rowseTestSupportFragment.java
uidedStepFragmentTest.java
uidedStepFragmentTestActivity.java
uidedStepFragmentTestBase.java
uidedStepSupportFragmentTest.java
uidedStepSupportFragmentTestActivity.java
uidedStepSupportFragmentTestBase.java
uidedStepTestFragment.java
uidedStepTestSupportFragment.java
00c679cbba786f9788451e87995daf7dac4115f1 22-Jul-2016 Dake Gu <dake@google.com> Fix broken ff/rw action text.

The FF/RW action should has "numSpeed + 1" items where the extra
first item is for start FF/RW.

Bug 30162199

Change-Id: I22840bfcfd6715daa680ed278450db1b9474ffa8
laybackControlGlueTest.java
laybackControlSupportGlueTest.java
d447d1a3819bd66e2ab8c93c6947e982feb11bf7 22-Jun-2016 susnata <susnata@google.com> Switching from ActivityInstrumentationTestCase2 to ActivityTestRule.

Leanback instrumentation tests are currently using deprecated
ActivityInstrumentationTestCase2 class. This CL replaces the deprecated
class with the recommeded approach - using ActivityTestRule.

We will have to make similar changes for other tests.

Change-Id: I647b1e5e1382f5cac96c7ccd56305ead3ffa721d
rowseFragmentTest.java
rowseSupportFragmentTest.java
rowseTestFragment.java
rowseTestSupportFragment.java
1f55c2c933d1085a097b00598aef18de029fe0d2 22-Jun-2016 susnata <susnata@google.com> Need to re-calculate size for custom adapters.

Change-Id: I45f51c22772aeda403f36b38a4abe557b0b09c7b
istRowDataAdapterTest.java
dbac8f49866ec226152849e7d3ace3e8263de1e4 15-Jun-2016 susnata <susnata@google.com> Fixing bugs in ListRowDataAdapter(multiple non-visible rows).

Change-Id: I92602af9214d3ca8522064c3ed7f372417c8a788
istRowDataAdapterTest.java
b3756c53c5be55e8c8a2f6e2cda264407be84881 08-Jun-2016 susnata <susnata@google.com> Fixing scrolling behavior in BrowseFragment.

When we have a non-visible row at the end of RowsFragment,
it tries to scroll to it, realized there's nothing to display
and then jump back to the previous element. This CL addresses
that by filtering out non-visible items from the end.

Change-Id: I45e9e70343066b008e036c7701f4f1301f7bb40c
istRowDataAdapterTest.java
7d7bf9541e0203ec67df0fe53367e2c126355b9e 07-Jun-2016 susnata <susnata@google.com> Moving Leanback unit tests.

Moving Leanback unit tests from frameworks/support/v17/tests
to frameworks/support/v17/leanback/tests.

Change-Id: I1dbfe73434a61d721f8666911c688930a8cb32cb
rowseFragmentTest.java
rowseFragmentTestActivity.java
rowseSupportFragmentTest.java
rowseSupportFragmentTestActivity.java
rowseTestFragment.java
rowseTestSupportFragment.java
tringPresenter.java
izard/GuidedDatePickerTest.java
izard/GuidedStepAttributesTest.java
izard/GuidedStepAttributesTestActivity.java
izard/GuidedStepAttributesTestFragment.java