| 9c0ad7d5adfbe51d85adcbc056b6183095d8aaed |
|
29-Nov-2016 |
Keyvan Amiri <keyvana@google.com> |
Made unfocusable views in RecyclerView visible when using key navigation
This CL handles the new scrolling strategy for unfocusble views in 2
major scenarios:
1. When using DPAD navigation, the unfocusable views that went
out-of-bounds never became visible again. This was because RV relied on
requestChildFocus callback from framework, which wasn't triggered for
unfocusable items.
2. if the scrolling distance between two consecutive focusable items
was greater than a third of a page, the scrolling got stuck.
This change increases this distance to at least one full page.
All LayoutManagers' onFocusSearchFailed are reimplemented to handle the new
logic.
Fixes: 33117253
Test: ./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.LinearLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.GridLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.StaggeredGridLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.ViewBoundsCheckTest
Change-Id: I0c4dd4ab3ee51ff99f30e1a4de11bda6920dab43
/frameworks/support/v7/recyclerview/src/android/support/v7/widget/ViewBoundsCheck.java
|
| 613079c6ece985c910852456fbff5dc9532df646 |
|
08-Feb-2017 |
Aurimas Liutikas <aurimas@google.com> |
Revert "Made unfocusable views in RecyclerView visible when using key navigation"
ag/1865310 caused tests to start flaking.
This reverts commit 530bca4dc2f96336c1169d993384b7884238d71e.
Bug: 33117253
Change-Id: I0b7522f1abc6d9574e98bc6062a407d3418c37d0
/frameworks/support/v7/recyclerview/src/android/support/v7/widget/ViewBoundsCheck.java
|
| 530bca4dc2f96336c1169d993384b7884238d71e |
|
29-Nov-2016 |
Keyvan Amiri <keyvana@google.com> |
Made unfocusable views in RecyclerView visible when using key navigation
This CL handles the new scrolling strategy for unfocusble views in 2
major scenarios:
1. When using DPAD navigation, the unfocusable views that went
out-of-bounds never became visible again. This was because RV relied on
requestChildFocus callback from framework, which wasn't triggered for
unfocusable items.
2. if the scrolling distance between two consecutive focusable items
was greater than a third of a page, the scrolling got stuck.
This change increases this distance to at least one full page.
All LayoutManagers' onFocusSearchFailed are reimplemented to handle the new
logic.
Fixes: 33117253
Test: ./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.LinearLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.GridLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.StaggeredGridLayoutManagerTest
./gradlew support-recyclerview-v7:connectedCheck
-Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.ViewBoundsCheckTest
Change-Id: I1d1fb0fa5e3d274840a1907e604749c6a1dbd447
/frameworks/support/v7/recyclerview/src/android/support/v7/widget/ViewBoundsCheck.java
|