History log of /hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5482fe026c60eb58f6f1b321fb5eb5bcb8b21e4d 01-Jun-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Revert "audiohal: Add diagnostics to investigate HAL call crashes"" into oc-dev
f811acf049b785ccce05a9fca9e01aa2031ab357 31-May-2017 Mikhail Naganov <mnaganov@google.com> Revert "audiohal: Add diagnostics to investigate HAL call crashes"

This reverts commit 6c0f76a684bc58eb10181f71d9f45c5799ca7c6a.

Since the root cause of the crash has been established, there is no need to keep this code around.

Bug: 36225019
Change-Id: I74e570e863a0cdec5d9029f1672e2e8066c246b5
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
a1d6ea4ba76c96cd613ee81eb204bc3041a219f7 09-May-2017 Kevin Rocard <krocard@google.com> Audio HAL: A speech volume outside of [0,1] is an error

Hals are supposed to received normalized volumes, between 0 and 1.
Previously volumes outside [0,1] were clamp to this range.
This clamping has the capability to hide bugs thus return an error if
such volume is received.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Iab70f9c651540ea2434d10939d28c1c842db19e0
Signed-off-by: Kevin Rocard <krocard@google.com>
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
04364edefcc39a5f620156a35209b760eb66a916 03-May-2017 Kevin Rocard <krocard@google.com> Audio HAL VTS: Sanitize setMode input

Some values of AudioMode are exposed although implementation detail.
Make sure the client can not use them.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: If513c2a06efa8a92459f0af80c63232fc63302b0
Signed-off-by: Kevin Rocard <krocard@google.com>
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
72e50e2ef1480fc3d90f0d88c7e9e3595622e75c 05-May-2017 Kevin Rocard <krocard@google.com> Audio HAL VTS: Fix style on modified files

In order to avoid style inconsistency as well as non functional
modification in following patches,
fix the style of all files modified for the fix of the VTS tests.

Patch generated with:
$ clang-format -i --style file -- <file list>

Bug: 36311550
Test: compile
Change-Id: I53dbcdabf959a6100e34a2ee4d0f951d525049cb
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
6c0f76a684bc58eb10181f71d9f45c5799ca7c6a 03-May-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Add diagnostics to investigate HAL call crashes

This is intended to clarify whether surprising zeroing out of HAL
control structures happens to a particular HAL module, or to any
HAL module at random.

Unfortunately, the crash itself can't be prevented as
audioflinger can't work around a HAL outage, and needs to be
restarted anyway.

Bug: 36225019
Test: verified that the logged string contains the information
Change-Id: I5843d89b4e5385b4ce269f72b5891ccb646daeba
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
6e81e9bb3c13d8c51fde503cf8be2bfb56e1ca1d 17-Nov-2016 Mikhail Naganov <mnaganov@google.com> Audio HAL: fixes for issues discovered after client conversion

Several issues addressed:

-- added IDevice.supportsAudioPatches to query whether
create/removeAudioPatch is actually supported by HAL;

-- IStreamOutCallback proxy needs to be owned by IStreamOut
implementation. In order for the client to reset the reference,
added method IStreamOut.clearCallback;

-- IDevice.open{Input|Output}Stream need to return a "suggested" audio
config from HAL;

-- code for converting between system/audio.h and HIDL
data structures has been moved to
android.hardware.audio.common@2.0-util library for reuse;

-- added a workaround for the issue with QC effects HAL trying to write
into the input parameters buffer, which is r/o by Binder design.

Bug: 30222631
Change-Id: I64af24d79c12d6ac3b0f87d085a821913e29237b
Test: tried using with WIP HIDL client on N5X
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
70b9a15df00a42b319279d903bf5923564920e3b 18-Nov-2016 Martijn Coenen <maco@google.com> Use newly introduced hidl_handle.

Bug: 32089785
Test: builds
Change-Id: I27c7d3945e1fe390661bf322987011a00fe9b3fe
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp
10548295023bee99108e418499aff09fe578211e 31-Oct-2016 Mikhail Naganov <mnaganov@google.com> Implement audio devices and streams HAL delegating to legacy HAL

Changes made to the .hal definition:

- introduce Effect ID returned by the IEffectsFactory that
needs to be passed to IStream.{add|remove}Effect; otherwise
it's impossible to retrieve the underlying HAL effect handle;

- change "bus address" in DeviceAddress to "string" type;

- fix signature of some methods w.r.t. returning Result;

- remove unused "struct AudioPatch".

Bug: 30222631
Test: make
Change-Id: Icb51729ef57bb2a5b0b78609735e7481bc04f95c
/hardware/interfaces/audio/2.0/default/PrimaryDevice.cpp