| 1f3014901704f3ae81538773b8a0b382945adc8d |
|
20-Jun-2014 |
Neil Fuller <nfuller@google.com> |
Unimplement Console.readPassword and remove test
ConsoleTest.test_readPassword* fails CTS tests.
Context: Under standard Android applications the
System.console() method will return null.
The Console.readPassword() method must turn off echo.
Under automated tests the ConsoleTest is exercising
a Console object with fake stdout / stdin streams to
get around the absence of a System.console().
setEcho() is hardcoded to use stdin / stdout in
the native code. Under the test runners stdin / stdout
are not connected to a TTY leading to a ENOTTY.
Under Android readPassword is unimportant. Rather than leaving
untested security-related code the password methods are being
unimplemented. It is unlikely this code has ever been used on
Android given the absence of a System Console instance.
Bug: 12491103
Change-Id: I755c014e6b53236f5bef0535be137dd721918b44
|
| b8d16154cf66c619a24449040d4576b61098e7fb |
|
13-Feb-2014 |
Narayan Kamath <narayan@google.com> |
Tidy up Console, fix ConsoleTest
- Use a more specific exception type. The use of
IOException led me to believe that the constructor
was performing i/o ops on the underlying file
descriptors. (They were not.)
- Delete a test that asserted that System.console() was
always non-null. It will be non-null only for command
line apps (tests run from vogar), and not for
"regular" android apps (tests run from CTS) because
stdin / stdout will not be TTY devices regular apps.
bug: 12490236
(cherry-picked from 7fbd82c654d1ad2348769b9340a1181abfa98fe9)
Change-Id: I8c1e37bcb21de5862dc8ea198852995a020437a7
|
| 7fbd82c654d1ad2348769b9340a1181abfa98fe9 |
|
13-Feb-2014 |
Narayan Kamath <narayan@google.com> |
Tidy up Console, fix ConsoleTest
- Use a more specific exception type. The use of
IOException led me to believe that the constructor
was performing i/o ops on the underlying file
descriptors. (They were not.)
- Delete a test that asserted that System.console() was
always non-null. It will be non-null only for command
line apps (tests run from vogar), and not for
"regular" android apps (tests run from CTS) because
stdin / stdout will not be TTY devices regular apps.
bug: 12490236
Change-Id: I8c1e37bcb21de5862dc8ea198852995a020437a7
|
| ab762bb740405d0fefcccf4a0899a234f995be13 |
|
15-Nov-2013 |
Narayan Kamath <narayan@google.com> |
Move tests from tests/api to harmony-tests. (Take 2)
This reverts commit d5e281743e55e1daa297fd8043b2d9b6e8e1bed2.
The makefile issue that caused the original build break
has been resolved.
|
| d5e281743e55e1daa297fd8043b2d9b6e8e1bed2 |
|
15-Nov-2013 |
Narayan Kamath <narayan@google.com> |
Revert "Move tests from tests/api to harmony-tests."
This reverts commit 81bf28ad31131815d0a36a43a0eca3c29aefdfcd.
Breaks build
Change-Id: I3f1562921ffe8fdbec36971dd65db398c27c92db
|
| 81bf28ad31131815d0a36a43a0eca3c29aefdfcd |
|
15-Nov-2013 |
Narayan Kamath <narayan@google.com> |
Move tests from tests/api to harmony-tests.
The vast majority of cleaned up harmony tests
are now in harmony-tests/src/test/org/apache/harmony/tests/
Change-Id: I56c2e484ff434b5618cf6751d602ae9f0db96b30
|