History log of /libcore/luni/src/test/java/libcore/java/net/MulticastSocketTest.java
Revision Date Author Comments
27604018f783bf6354a13870b3e7785edca69b5f 28-Sep-2016 Paul Duffin <paulduffin@google.com> Detect and fix resource leakages in tests

Tests that test those classes that use CloseGuard to detect
reosurce leakages are switched to use TestCaseWithRules and
ResourceLeakageDetector.getRule() to detect any resource
leakages and the leaks fixed.

A number of tests could not be fixed due to bugs in the core
classes so a new DisableResourceLeakageDetection annotation was
added as part of this change. A method annotated with that does
not perform resource leakage detection. The affected tests were
annotated with a description and a reference to an associated
bug.

This uses try-with-resources to aid in closing resources. While
that does provide some benefits it is all too easy to change the
behavior of the test unless care is taken. To avoid that it is
important not to merge it with an existing try block such as
those which follow the following pattern:
try {... fail()} catch(..) {}
Merging them could result in the test catching and ignoring
exceptions thrown during the creation of the resource which is
almost certainly not what the test was intending.

Test: Tested with vogar and CTS
Bug: 31542223
Change-Id: Id32bb40fe04eb9719d7e6cd367abb53118b21832
9a4b8aed4cbf500ffabeefd2987a0b9d9d8490c7 19-Jul-2016 Yi Kong <yikong@google.com> Import upstream change: MulticastSocket should enable IP_MULTICAST_ALL (lnx)

Upstream change:

8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx)
Reviewed-by: alanb, chegar
Contributed-by: John Zavgren <john.zavgren@oracle.com>, Chris Hegarty <chris.hegarty@oracle.com>

Bug: 29067535
Test: libcore.java.net.MulticastSocketTest
Change-Id: I0ea69fd8c9e78fa226d7720a2c359449588104a3