| d4b7449574ca69c713a3f2230cb77c68ee642700 |
|
06-Sep-2016 |
Tobias Thierer <tobiast@google.com> |
Fix 58 libcore tests that caught "expected" Exceptions but didn't fail()
There were no changes to code under test.
4 tests were fixed to not tolerate an Exception:
- libcore.java.util.CollectionsTest#test_CheckedMap_computeIfAbsent
In the case where a Map key is present, computeIfAbsent() should
not invoke the Function, so there is no return value that could
be expected to undergo a type check. The test was changed to
verify that the Function is not invoked.
- libcore.java.util.concurrent.CopyOnWriteArrayListTest#test_sort and
libcore.java.util.concurrent.CopyOnWriteArrayListTest#test_subList_sort
were sorting an already-sorted non-null list that contains no null
values. That logic was redundant and wouldn't have thrown.
- org.apache.harmony.security.tests.java.security.KeyStoreSpiTest#test_engineEntryInstanceOf
(the KeyStoreSpi documentation does not mention whether NPE is thrown;
the implementation comes from upstream and does not throw it).
54 tests were fixed by adding the missing
fail();
No attempt was made to make this failure message specific to the
exception that was expected.
Tests that weren't changed:
- SSLEngineTest.test_wrap_ByteBuffer_ByteBuffer_04() requires
investigation to determine the correct resolution.
A comment was added to the test linking to the corresponding bug.
- ThreadTest#testParkUntilWithUnderflowValue() and
OldNodeChangeEventTest.waitForEvent() were not touched since
it was not clear whether that it was relevent to the test whether
or not the exception was thrown.
- two cases in Files2Test#test_setPosixFilePermissions_NPE() are
left to a future CL
Test:
(croot; make vogar core-tests) \
&& git diff aosp/master --name-only | xargs vogar `cparg core-tests`
Change-Id: I1cd3220a06e331ff049b146b393f78879f07211a
|
| c8e3ef38e9b373dc3e98452e7a0c111aa1c57bbb |
|
15-Mar-2013 |
Kenny Root <kroot@google.com> |
Fix test since getExtendedKeyUsage doc disagrees
The documentation for X509Certificate#getExtendedKeyUsage says that it
must return an unmodifiable list. The test was testing the exact
opposite was true.
Change-Id: I0f99ed6c8f2ddcc59ce6b90b973ccabd0dce35f6
|
| 53b3020e8722394d64de6cb0be0ce03fe8c9e159 |
|
09-Feb-2013 |
Kenny Root <kroot@google.com> |
Remove invalid X509Certificate2Test tests
The "CERT_CORRECT" is actually an invalid X.509 certificate, but these
test cases are now covered in more detail by
luni/src/test/java/libcore/java/security/cert/X509CertificateTest.java
The decoding of the alternative names in the certificate look like this
via openssl command line:
X509v3 Subject Alternative Name: critical
0[..rfc@822.Name..dNSName..1.0...U.
..Organization..http://uniform.Resource.Id........*..\...
Change-Id: I41d4753b926715b093f558b41d102842e6b3a2da
|
| bcd731fc88df3806f963b2c6e19b83de5aba8d35 |
|
29-Jan-2013 |
Kenny Root <kroot@google.com> |
Add tests for CertificateFactory byte offset
Make sure that CertificateFactory ends at the place that it should when
reading an InputStream that supports mark and reset.
Change-Id: I3bc20c1e9766f80f1597908707e69d65a6c3b216
|
| beee0a569bf1077f0d3be516fed63661fcedde5c |
|
21-Dec-2012 |
Brian Carlstrom <bdc@google.com> |
Fix X509Certificate.getBasicConstraints implementation for DRLCertFactory
Change-Id: I5d1ba078b0f8f9ec8e2950e0da02481e8162a5e6
|
| 229e34b182b98e1dba15d3dc6341954986ae2b7a |
|
03-Mar-2011 |
Brian Carlstrom <bdc@google.com> |
Removing use of @tests and @Test.* annotations
Change-Id: I89243efdeebe22543c45a2166b634f40c3e78cf8
|
| f33eae7e84eb6d3b0f4e86b59605bb3de73009f3 |
|
13-May-2010 |
Elliott Hughes <enh@google.com> |
Remove all trailing whitespace from the dalvik team-maintained parts of libcore.
Gentlemen, you may now set your editors to "strip trailing whitespace"...
Change-Id: I85b2f6c80e5fbef1af6cab11789790b078c11b1b
|
| cec4dd4b1d33f78997603d0f89c0d0e56e64dbcd |
|
26-Apr-2010 |
Peter Hallam <peterhal@google.com> |
merge more modules into luni
|