| ffb419e08d7bab32ee489ec1e8e4a341d01a968a |
15-Apr-2017 |
Wenyi Wang <wenyiw@google.com> |
Fix long logging tags
- Delete unused tags, shorten the tags in use including the
tags for logging and those for adding a Fragment to
FragmentManager
Bug: 36711497
Test: none
Change-Id: Ia2fc473257eade62f0dd4cb12140be77f506baf8
(cherry picked from commit 11798d44eb59efc943ba5c78635426d3b773db19)
ggregationSuggestionEngine.java
electAccountDialogFragment.java
plitContactConfirmationDialogFragment.java
|
| eda7e560121a487c5b0e920514fa74d1867c7610 |
17-Feb-2017 |
avipul <avipul@google.com> |
Phonetic name field underlines stretch across
Test:
1. open editor
2. expand more fields
3. see phonetic name fields
4. Phonetic name fields should be aliend with rest of the name fields
Bug: 35433983
Change-Id: I19df75e6340192692f745d17ec0a99e2b1463414
(cherry picked from commit e1cf3ff6b2b9dfe499049f9605585cd6f67c8a5a)
abeledEditorView.java
tructuredNameEditorView.java
|
| efc0d3297c687391d1bbccb6ebfd019ac2705713 |
25-Mar-2017 |
Wenyi Wang <wenyiw@google.com> |
Merge "Add isLoggable checks to all verbose and debug log outputs (1/2)" into ub-contactsdialer-i-dev
am: 86903bb8e4
Change-Id: I60b8c5242c3e1adfc55c140e91be38c86e1b64e1
|
| 57a0e98eed836b72dd3dc3540b9cac029266ed7c |
25-Mar-2017 |
Wenyi Wang <wenyiw@google.com> |
Add isLoggable checks to all verbose and debug log outputs (1/2)
Bug: 6813854
Test: built apk and verified log is seen in logcat
Change-Id: Ib17cac0d2d9553276c4271221110305ab2d70a46
ontactEditorFragment.java
awContactEditorView.java
|
| 2553e422c61fb6691884cb3da2541cda1cdfbf77 |
08-Mar-2017 |
Gary Mai <garymai@google.com> |
Photo view in editor fixes
am: eec6992932
Change-Id: Ida0e586910a15920d71892325f689540d46d9416
|
| eec6992932cc1b650211402a30650c5842cc8ad8 |
07-Mar-2017 |
Gary Mai <garymai@google.com> |
Photo view in editor fixes
Use the height/width returned from getHeight and getWidth to
resize the photo view. Since it takes up all available space
initially these two values essentially function as the content
view height/width.
Test: Manually verified photo view sizing on M, N, and O with
rotation.
Also verified editor alignment in multiwindow mode on N.
One caveat is when rotating to landscape with the keyboard up on
O only, there's still a little bit of space at the bottom of the
photo view. This doesn't repro when loading initially in landscape
or rotating into landscape without the keyboard up. So the bug
isn't fixed entirely but it handles the more common cases.
Bug: 33922016
Bug: 27887505
Change-Id: I89ad06bfb07d8891c6ecb57cc7cb0452a2112385
hotoEditorView.java
|
| c37a0018ceb3eaeece6b190c90cd72ec2c2278fa |
17-Feb-2017 |
avipul <avipul@google.com> |
DO NOT MERGE Phonetic name field underlines stretch across
Test:
1. open editor
2. expand more fields
3. see phonetic name fields
4. Phonetic name fields should be aliend with rest of the name fields
Bug: 35433983
Change-Id: I19df75e6340192692f745d17ec0a99e2b1463414
(cherry picked from commit e1cf3ff6b2b9dfe499049f9605585cd6f67c8a5a)
abeledEditorView.java
tructuredNameEditorView.java
|
| bf9dddc9e9228478d1c49287271cb757d158a2f3 |
21-Feb-2017 |
avipul <avipul@google.com> |
Added preference for the display of phonetic name fields.
The new preference is available on settings page.
Users can choose to show phonetic name fields always
even when all fields are empty. By default these fields are only
displayed if they are not empty or after "More fields" is selected.
Test:
1. Tap on setting from the navigation drawer
2. Tap on "Phonetic name fields display" option
3. Select "Show always"
4. Press back and go to create new contact
5. Notice that all phonetic name fields are visible
6. Go back to settings and now choose "Hide if empty"
7. Go to create new contact
8. Notice that Phonetic name fields are not visible
9. Tap on "More Fields"
10. All phonetic name fields are visible
Bug: 22413772
Change-Id: I3c906f78fc21ce2288a1853048b593bfb850a373
indSectionView.java
|
| ad21212b197c2a789d4a55709819bea7812ea7ba |
09-Feb-2017 |
Gary Mai <garymai@google.com> |
Merge "Handle revoked permissions when resuming the app (1/2)" into ub-contactsdialer-i-dev
|
| 1e899dc127a212bfd2198fe7adba5c33eb4cd751 |
08-Feb-2017 |
Gary Mai <garymai@google.com> |
Handle revoked permissions when resuming the app (1/2)
The activities that create these fragments will request permissions
but if these fragments were created and the permissions were revoked
then Activity's super.onCreate() will recreate these fragments before
the permission activity is started, which causes a bunch of issues
since the original activity never finishes it's onCreate method so
many things aren't initialized for the fragments.
So in activities that maybe start the permission activity and have
visisble fragments, instead of returning, continue initializing
everything.
In the case of editor, not being able to select a raw contact delta
is a legit case so it should have been handled as a failure and in
general we shouldn't be attempting to bind the editors if we don't
have the permissions.
Test: Manually verified removing permissions and going back to the
app from the recent apps screen doesn't crash while viewing:
* main list
* groups view
* first level suggestions
* duplicates view
* account view
* editor
* settings
* pick group member to add view
* pick phone numbers to send to from group
* pick emails to send to from group
The behavior is permissions get requested and will go back to the
original activity (PeopleActivity with main list loaded or the
editor activity).
Bug: 34741297
Change-Id: Ie234b1f44e83372b9c0ad9658fa4a2e9b40572b0
ontactEditorFragment.java
awContactEditorView.java
|
| 8d26c0a7214cf6520a4def851afa138a133a68a2 |
08-Feb-2017 |
Walter Jang <wjang@google.com> |
DO NOT MERGE Revert "Start ContactSheet instead of QuickContacts (1/2)"
This reverts commit 581585d9ad2e7d3d4b65798acaa0fa462d30710d.
Test: see I5ad160778d29a78e965fd7cb2ded67b017f4ab9a
Bug: 32604475
Change-Id: If92ea63ed5dbd8d62e3a9f84a8fcd953fa4c9738
ontactEditorFragment.java
|
| 8bca12206d31072af65790e22fa3c3630f6b05a9 |
28-Jan-2017 |
avipul <avipul@google.com> |
Don't parse phonetic name just show show all the parts fully expanded.
Test:
Tested the following editor scenarios:
1) goto create new contact/edit existing contact
2) notice that phonetic name field is not visible
3) tap on the more fields at the bottom of the list
a) phonetic name fields are visible below name fields
4) enter value in one of these fields and tap on save
5) go back to the same contact and notice that phonetic name fields are
visible.
Bug: 34468427
Change-Id: Idba3f3915350c2bbe49dcda89e30cd756f7f7642
ditorUiUtils.java
indSectionView.java
honeticNameEditorView.java
|
| 391002fab729576f7bf74e6d1c0ff83e82d582b2 |
11-Jan-2017 |
Gary Mai <garymai@google.com> |
Merge "Focus on name field and show keyboard when inserting contact" into ub-contactsdialer-i-dev
|
| 9f691e8b1c30dcdae230daebd26da0f225f74008 |
11-Jan-2017 |
Gary Mai <garymai@google.com> |
Fix editor crash when rotating during contact insert
Remember the current account being saved to when setting state
for a new contact. Otherwise when during an insert it will never
get set unless you select a new account from the switcher dropdown.
Since it's null once the account load is finished it goes through
the set state for a new contact code path again which adds another
RawContactDelta to the list which breaks some of our assumptions
regarding the size of mState.
Test: Manually verified no crash occurs after rotation when adding
a new contact from:
* the fab
* recommendations assistant
* third party apps (dialer/messenger)
Bug: 34126254
Bug: 34131358
Change-Id: I874cc592f94584a98e54010751c557cfd3b0d389
ontactEditorFragment.java
|
| befbd85aa820ed0d33ae5a3ec4a923e250d2b2f0 |
11-Jan-2017 |
Gary Mai <garymai@google.com> |
Focus on name field and show keyboard when inserting contact
Request name field focus when it's an insert.
Test: Manually verified:
* Inserting new contact with fab has keyboard and focus on name
field
* Inserting new contact from messenger app has keyboard and
focus on name field with phone number filled in
* Editing a contact has nothing focused
* Editing a read-only contact has the name field focused but no
keyboard
Bug: 31158231
Change-Id: Iff7e0df5059f5efa038d5f794065f76e38a21288
awContactEditorView.java
|
| d8617d35fe0765451f3d5d05f01e6a43913c3697 |
04-Jan-2017 |
Marcus Hagerott <mhagerott@google.com> |
Merge changes If1b344d5,Idaffc3f0,I5a33ad27 into ub-contactsdialer-i-dev
* changes:
Remove getGroupWritableAccounts method
Replace getAccounts method with blockForWritableAccounts
Add setter for accounts in AccountsListAdapter
|
| ee3d3a503553de2699285d98bc6fe7d34699a8b0 |
22-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add setter for accounts in AccountsListAdapter
This allows the accounts to be set after the adapter has been created
which simplifies usage in cases where the accounts are loaded with a
loader.
Test: manually verify that account list is correct for default account
preference, import from .vcf and create label.
Bug 33627801
Change-Id: I5a33ad2746cff41d0251cead9a33dc53e5bf822d
electAccountDialogFragment.java
|
| f68e6d017d4e1380de7f8f628a147d728fa3ecca |
04-Jan-2017 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Fix exceptions logged when loading icons" into ub-contactsdialer-i-dev
|
| 80ab7ea6a518410594058c74f32c4b551097edbd |
03-Jan-2017 |
Marcus Hagerott <mhagerott@google.com> |
Prevent editor from closing after account is added
When the ContactEditorAccountsChangedActivity is shown (when creating
a new contact with no default account set) and a new account is added
the editor would close once an account was chosen because a new activity
instance was being created.
Test: manually verify that editor remains open after adding account
while choose account dialog is displayed
Bug 33627801
Change-Id: Icdfbceb0fc2e10619afde4fa772a2efaa21a0c5e
ontactEditorFragment.java
|
| 3cbc7482cf5eb745f9ac0b51420a295f51aa46b3 |
22-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Fix exceptions logged when loading icons
A RuntimeException was being logged at debug level (not a crash). This
was probably introduced when the icons were changed to vector drawables
in Iafea5c1bba738c57437888da999fc2909d0765fd
Test: manually observe logs while opening editor and quick contact
Change-Id: I8333d9aa86ed8580798deff58ecdcf29037c0aab
ditorUiUtils.java
|
| 8c6b5bdb3812fcbe5680fafca59d2ab9ec90d839 |
22-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add convenience methods for account loading
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Ib673838d9b041e5dc512a94bfaf47b4caf4a540f
ontactEditorFragment.java
|
| a181ca6021333cbb96ff9a6abeec9e64ea19c7f9 |
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Replace several usages for of AccountTypeManager.getAccounts
Test: Ran GoogleContactsTests
Bug 33627801
Change-Id: Ifde6c5f314558159bb468c92fa38b20a8d90bf06
ccountHeaderPresenter.java
ickRawContactDialogFragment.java
|
| fbfeaeb4f2f5039f83dcf96caa924af4084685a5 |
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Use loaded accounts for editor account prompt" into ub-contactsdialer-i-dev
|
| c40f3e945c43ff1ff90abb7fb2daf56aba315e10 |
21-Dec-2016 |
Gary Mai <garymai@google.com> |
Use support toolbar in editor to fix issues in LMP
ContactEditorActivity has to switch to AppCompatActivity, and so
does its theme.
Use support AlertDialog in editor created dialogs so it uses the
appcompat theme correctly.
Test: Manually verified look and functionality of the toolbar in
LMP and on MNC.
Verified LMP cut/copy/paste toolbar appears over the toolbar instead
of pushing it down.
Bug: 33662452
Bug: 33587478
Change-Id: Ie6f4555a237b7a10877dd0b32615120b6d789646
ancelEditDialogFragment.java
ontactEditorFragment.java
hotoSourceDialogFragment.java
uggestionEditConfirmationDialogFragment.java
|
| 807e6208d6bc4ff1a6b0b4d8900229df27077246 |
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loaded accounts for editor account prompt
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Id8bdf1d5a2a13bb526118b104bae06138f0333ac
ontactEditorFragment.java
ontactEditorUtils.java
awContactEditorView.java
|
| 56adf8347aedcd8d2fa58aecfe043534e3d1ad90 |
21-Dec-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Replace switches on resources with if-else" into ub-contactsdialer-i-dev
|
| b697ed768fb817f94524f6c3992547665df331c4 |
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Replace switches on resources with if-else
This is necessary for the project to build as an Android library which
is planned for Google3.
Test: ran GoogleContactsTests
Bug 33782320
Change-Id: I62f15486b7e976bb20a6e9c631dc8404a4170dbb
ontactEditorFragment.java
ventFieldEditorView.java
|
| 30328dbe381565e9eba39c096aaa939bb484913c |
21-Dec-2016 |
Gary Mai <garymai@google.com> |
Wrap show dialog fragment in isSafeToCommitTransactions check
The dialog fragment is shown from an onClick handler which can be
run after onSaveInstanceState is called which results in the
IllegalStateException. Our base activity classes already have a
method to check for this, so call it before attempting to show the
dialog fragment.
Also delete an unused class.
Test: N/A
Bug: 33341841
Change-Id: I1e27bd473666025251c95f8d497c71a248a5a2c8
oinSuggestedContactDialogFragment.java
|
| 4bd50d69d2b8934dbd4cbd634ad83807d9b02735 |
16-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loader for accounts in editor fragment
Test: manually remove selected account in editor and verify that
it changes to the first account in list
Bug: 33627801
Change-Id: I6554f03c207fb761f7b8d971e0f07f7416efcd72
ontactEditorFragment.java
ditorUiUtils.java
ickRawContactDialogFragment.java
awContactEditorView.java
|
| 96e7fc65257e1aab2f1fc4f7900832514f584b0f |
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Add null check before copying name fields
am: 860698b8d4
Change-Id: I4bb6db79340cb1a218739b7c3fcf5650b3beff4b
|
| 860698b8d4542a55da5ec40032a361433b525aad |
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Add null check before copying name fields
Bail if either name value delta is null. This can happen because
external read only raw contacts may not have a StructuredName, such
as the ones created by the Signal app.
User facing consequence is the name isn't auto copied for them, but
without a StructuredName type declared by the read only raw contact
there isn't a reliable way to even get something to copy.
Test: Verified editing a Signal raw contact doesn't crash the app
and the editor loads with the same behavior as if a new contact was
being created.
Bug: 33622717
Change-Id: I87b513ca9f188750f0d5e4e5f5392e419565cf4e
ontactEditorFragment.java
|
| d14743263df73d2c715bca44962a181f5ac1ae3b |
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix editor crash on rotation when no default account exists
am: c135a5d502
Change-Id: Ide3f311c0eaae6d53aa94f0d83029c599bace1a6
|
| c135a5d502130aee06ffcc11170513053396e9b0 |
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix editor crash on rotation when no default account exists
Persist the current primary account in the fragment. Normally a
default account has to be chosen before a new contact is added
but when adding a new contact from an account view, that account
is passed in through an intent extra and set as the primary for
the fragment. On rotation it's lost because reading the intent
extras only happens when saveState is null.
Also remove an unused constant.
Test: Followed repro steps in the bug and verified no crash
happens and the new contact is saved to the correct account.
Bug: 33691259
Change-Id: I12a86af907be7d11980349583fa6d44b3097de15
ontactEditorFragment.java
|
| 2b80ea02bd625c31a4d000b7041d80381f465ea9 |
19-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge changes I5e0bf85f,I3c92c80f,I39962f99 into ub-contactsdialer-i-dev
* changes:
Only broadcast account change if accounts are different
Use loader for accounts in editor account chooser
Add AccountInfo class
|
| 75895e73379aa26a3d4135c772af4ecb8a79b4c9 |
13-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add AccountInfo class
This holds the AccountWithDataSet, AccountType and AccountDisplayInfo
for an account because many usages of accounts need all three of these.
Test: manually verify that accounts in nav drawer are correct
Bug 33627801
Change-Id: I39962f9945714aa7ce48aca97f220f119a1741cd
ccountHeaderPresenter.java
|
| bd9ef3c60669d71543b3506d4959c1fe4be409dc |
15-Dec-2016 |
John Shao <johnshao@google.com> |
Standardize and replace assets with vectors
Standarize naming of vector drawables and replace png
assets with vector drawables.
Test: build and run GoogleContactsTests
manual side by side sanity check with previous version
Bug: 33251913
Change-Id: Iafea5c1bba738c57437888da999fc2909d0765fd
ontactEditorFragment.java
ditorUiUtils.java
awContactEditorView.java
extFieldsEditorView.java
|
| c2093f312f71e730e1cc4daaa305782fda394215 |
12-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Include device local accounts in AccountTypeManager
Test manually verify that device account shows up in nav drawer
when no Google account is available
Bug 33627801
Change-Id: Iaf0b73b9ec77f02b825f34eb980ab1a5ca14383b
ccountHeaderPresenter.java
|
| e7a71cbbe8929a9d8a7ca0a3b5668646d49a611a |
10-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Load accounts in background for SIM import
Test: manually verify SIM import screen displays accounts and preserve
checked state after rotation
Bug 33627801
Change-Id: Ie6545785db95febacff8c4fab2734ff7cdbb351c
ccountHeaderPresenter.java
|
| 4fe30c66c8bde1314a6e372a1456d19ac9951fea |
09-Dec-2016 |
Gary Mai <garymai@google.com> |
[DO NOT MERGE] Fix silentfeedback error
If no raw contacts were loaded return null
Bug: 33617336
Change-Id: I896ed19a28e893f8184a9c1c6dd796dc15d6d225
(cherry picked from commit cea6f3d1448e3a2832dad57339917ce878594b24)
ickRawContactLoader.java
|
| f0e140aec2f5832a517243084bea626011be9c39 |
06-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Remove some methods from AccountTypeManager
This will make it simpler to do additional refactoring.
Test: built GoogleContacts app
Bug: 32028702
Change-Id: I51939d1b841eaf250cb75e198ea561b944deff1f
ontactEditorUtils.java
|
| cea6f3d1448e3a2832dad57339917ce878594b24 |
09-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix silentfeedback error
If no raw contacts were loaded return null
Bug: 33451068
Change-Id: I896ed19a28e893f8184a9c1c6dd796dc15d6d225
ickRawContactLoader.java
|
| 1e24ae80f2ac1c661a90ee3a722ed521cbe9643f |
07-Dec-2016 |
John Shao <johnshao@google.com> |
Remove unnecessary variants causing apk bloat
We will see huge savings when string translations are removed
for values-sw600dp because there was special casing for tablets
in a error message that was too technical for normal users.
Also removes more holo assets that are now legacy.
Test: built Contacts and GoogleContacts
ran Tests
Bug: 33251913
Change-Id: Id9d3172fa4765f566dcc9832dcb6418164503aee
ontactEditorFragment.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
ggregationSuggestionEngine.java
ggregationSuggestionView.java
ancelEditDialogFragment.java
ontactEditorFragment.java
ontactEditorUtils.java
ditorAnimator.java
ditorUiUtils.java
roupMembershipView.java
oinSuggestedContactDialogFragment.java
abeledEditorView.java
hotoEditorView.java
hotoSourceDialogFragment.java
ickRawContactDialogFragment.java
awContactDeltaComparator.java
awContactEditorView.java
extFieldsEditorView.java
|
| 3f6a2444e0134b7380cdb2e13abf4bf1163336d0 |
05-Dec-2016 |
Arthur Wang <wuwang@google.com> |
Collapse res-aosp and res-icons into res folder for AOSP Contacts (1/2)
bug:31022536
Change-Id: I0434710d92027e59ccd97e27ebd09f1668346684
electAccountDialogFragment.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
ccountHeaderPresenter.java
ggregationSuggestionEngine.java
ontactEditorFragment.java
ontactEditorUtils.java
ditor.java
ditorIntents.java
ditorUiUtils.java
ventFieldEditorView.java
roupMembershipView.java
indSectionData.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
ickRawContactDialogFragment.java
ickRawContactLoader.java
awContactDeltaComparator.java
awContactEditorView.java
electAccountDialogFragment.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| 59ebb1b9ff74b384e7a6a30a0bc24a285b81e849 |
30-Nov-2016 |
Gary Mai <garymai@google.com> |
Remove linking options from the ME profile
They shouldn't be available for ME profile.
Test: Manually checked there are no buttons when viewing
the me profile linked contacts. Also verified buttons are
there when viewing a regular contact
Change-Id: Id8feb3585b015ab19004bc739494f822e9096186
ickRawContactDialogFragment.java
|
| 591a699cbba0d47acce559390c171e9ede725eef |
23-Nov-2016 |
Gary Mai <garymai@google.com> |
Right align view linked contacts buttons
Neutral buttons are aligned to the left (start) side while negative
buttons are aligned directly to the left (start) of positive buttons.
Test: Manual verified placement of buttons in normal and RTL modes.
Bug: 33103521
Change-Id: Ie6e10871865c27db80a346fd4064362fa9d7c36b
ickRawContactDialogFragment.java
|
| 39bf8e25bf182463cd718da0647c64a424f40de4 |
22-Nov-2016 |
Gary Mai <garymai@google.com> |
Ignore display name when creating aggregation uris
When all fields of a name are removed, the display name is used
to find an aggregation suggestions. Since we removed support for
editing the display name it will always be the initial value, causing
a lookup to be done for the initial name if all characters are
removed.
Test: Verified removing the name doesn't trigger a suggestion for
the initial display name.
Bug: 33050912
Change-Id: Id45ca55a3fa522048070d37965f512b1d04c12a3
ggregationSuggestionEngine.java
|
| d3869c7ab4ff85fc9e3a511ea6644be395698321 |
21-Nov-2016 |
Marcus Hagerott <mhagerott@google.com> |
Announce selected account on SIM import screen
Test
manually verify that new selection is announced immediately after
changing it
Bug 32948185
Change-Id: Ib484496a28a2c279e552a0931493ae5137a9a2ef
ccountHeaderPresenter.java
|
| 6a87ee9b9ed26eb1cbc888be758ddf4f4e0694b8 |
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Use photoId of the raw contact in aggregation engine
Previously using the wrong selection for photoId, getting the id for
the whole contact instead of the one for raw contact.
Test: Verified the correct photo shows up in aggregation popup
when the raw contacts have different photos.
Bug: 33004690
Change-Id: I989b666f5c2782e33b6b5396ac89d56841144888
ggregationSuggestionEngine.java
|
| c000d2ee0e292d9b160f65ab74ebd1258346046b |
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Add null check to Uri when getting the name to toast
When all contact details are removed from a contact when there are
no accounts (potentially if it's the device account) the contact is
fully deleted, so the Uri is null when we try to get the name to
display. Bail early and return null in this case.
Test: Verified no crash and consistent behavior with previous releases
when removing all contact info from a contact when no accounts are
present and when deleting all info from the ME profile with Google+
contacts sync turned off.
Bug: 32982336
Change-Id: I0fd236080750a5040a5c9ffd80a48a37cb1f8ae3
ontactEditorFragment.java
|
| d8f3da6a4ea4054bd47959db85657a7e01d28358 |
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Set editor activity title for talkback
The toolbar will display the correct title for visual purposes
while setting the activity title will have talkback read out
the title when entering the activity.
Test: Manually entered editor activity for
* editing an existing contact
* adding a new contact
* viewing a read-only contact
and verified talkback read the proper title.
Change-Id: I77e366073e725734aa8ac29f52bb760b5e58c02f
ontactEditorFragment.java
|
| c80cc548f84d8a817efa515015344c2487084252 |
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Merge "Use toolbar in editor" into ub-contactsdialer-h-dev
|
| 4b11232fdf9e11e73b2ffa41b40f3e153ec3912b |
18-Nov-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add description to SIM import account dropdown arrow
Also make the same change for the account chooser in the editor.
test
manually verified that drop down arrow reads out "Show more" with
talkback on
Bug 32973740
Change-Id: I4050cbf37a6ba11300262716c5a6ab7c4f8d2a99
ccountHeaderPresenter.java
awContactEditorView.java
|
| 15646ce3e2e7a7f889976dc5684ecbc3029230c2 |
17-Nov-2016 |
Gary Mai <garymai@google.com> |
Use toolbar in editor
Lets us change content description of the navigation icon a bit
easier.
When it's an X read out "Cancel button".
When it's a back arrow read out "Back button".
Left the toolbar within the activity instead of putting it in the
fragment to reduce risk/testing needed for making this change.
Test: Manually verified for the above for:
* editing a contact
* adding a new contact
* viewing a read-only contact
Bug: 32950789
Change-Id: I125728786bdf3872e141863f60d38b34e01bb757
ontactEditorFragment.java
|
| c199b72c9c84082b391aa2a9d1879111ad8653e1 |
18-Nov-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Fix rotation losing track of new group creation." into ub-contactsdialer-h-dev
|
| b2d2e421931bac790e1cae4440c46d69c88102a9 |
18-Nov-2016 |
James Laskey <laskey@google.com> |
Fix rotation losing track of new group creation.
Re-add listener when re-created and only track when group is finally
created.
Bug: 32771896
Test: Follow repro steps and verify that toast does appear.
Change-Id: Ie56585032eb62b5daf587df06eab1f9785631caa
roupMembershipView.java
|
| ef6ceb2714641eb70dcedddf6a18e6344fd7cbcc |
17-Nov-2016 |
Gary Mai <garymai@google.com> |
Update editor photo view green lines
Default photo reads "Add contact photo"
Existing photo reads "Change contact photo"
Test: Manually verified the above, including proper updates when
* adding a new photo
* removing the photo
Bug: 32976203
Bug: 32975967
Change-Id: Id10023998b177d0e5e86db1ca11bcf5dd9727a87
hotoEditorView.java
|
| 34047d2d076f5501ff958f0ef041b4e25c65bbed |
17-Nov-2016 |
Gary Mai <garymai@google.com> |
A11y bug fixes for editor
Set profile photo content description as "Contact photo" if
in read-only mode, otherwise it's still "Change photo"
Set the whole row for read-only data to be focusable so it
reads the entire thing in one go
Fix ordering of content description for account header.
Test:
Manually verified the above.
Bug:32952012
Bug:32952102
Bug:32952414
Change-Id: I845f020e805a7f715892690b59c4bc00a8435e63
hotoEditorView.java
awContactEditorView.java
|
| 04926c0145e5f0143d81265e2825415288cc94b4 |
16-Nov-2016 |
Gary Mai <garymai@google.com> |
Use photo ids in aggregation suggestions
Loading via a photo id seems to update quicker than if done by URI.
Test: manually followed repro steps in comment 4 of bug.
Verified photo always appears
Bug: 32617732
Change-Id: I94088231b30538ec584ff5fc552de1a5c6904c8a
ggregationSuggestionEngine.java
ggregationSuggestionView.java
|
| b9065ddb28a2040cabda251891be2062b5260217 |
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Implement linked contact menu option
Remove unlink option from QuickContact.
Link now appears when the contact has only one raw contact.
Otherwise a new "View linked contacts" menu option appears.
This dialog shows all linked contacts (including read-only) and
has buttons for adding another contact or unlinking all of them.
Show progress dialogs for each of these actions.
Test: Manually verified:
* View linked contacts only appears when there are more than one
raw contacts
* Link appears otherwise
* Pressing add goes to the contact picker and correctly joins the
selected contact
* Pressing unlink opens the confirmation dialog
* Canceling or dismissing the confirmation closes everything
* Unlinking from the confirmation does the unlink
* Confirmed the above with rotating on each dialog and during the
progress dialogs
Bug: 32707898
Change-Id: I39435a07fefce4276e34ba302001ff3dab352516
ontactEditorFragment.java
ditorIntents.java
ickRawContactDialogFragment.java
ickRawContactLoader.java
plitContactConfirmationDialogFragment.java
|
| 19a90b19e597dce7bdc00522e0176c2d0c6ba241 |
14-Nov-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Update SIM import UI to match designs" into ub-contactsdialer-h-dev
|
| 2219c604811264293c52d0de6d450a9d99111613 |
14-Nov-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge "Dismiss import dialog after it's clicked" into ub-contactsdialer-h-dev
|
| 7217e6986c333aebb885b0a07a0a9344ef7a814c |
10-Nov-2016 |
Marcus Hagerott <mhagerott@google.com> |
Update SIM import UI to match designs
Test
manually verify appearance of SIM import screen
Bug 32748785
Change-Id: I660d848880e6416fdb9c25f8a3c52a6597e64e0a
ccountHeaderPresenter.java
|
| c3322286a4c26e987b59296e1f33399848816313 |
11-Nov-2016 |
Wenyi Wang <wenyiw@google.com> |
Dismiss import dialog after it's clicked
- The workflow we want to fix is opening account dialog from import dialog.
- Previously, we keep import dialog around until account is chosen; this
workflow never worked well on rotation since Lollipop.
- Now, we dismiss import dialog to simplify the workflow; and since we
dismiss the import dialog, we use activity as a listener.
- SelectAccountDialogFragment is used in:
- import contacts
- create a new group
Bug: 32502787
Test: manual - verify importing contacts and creating new groups
work well after rotation when there's 0, 1, and 2+ accounts.
Change-Id: Ic8b9c3f9987aeb3867ab2100097c235088507bdb
electAccountDialogFragment.java
|
| 0a7d717330876931ea9e355e5ddd33607e3b9aa0 |
11-Nov-2016 |
John Shao <johnshao@google.com> |
Migrate from depreated Guava APIs
Objects.toStringHelper -> MoreObjects.toStringHelper
Test: built Contacts and GoogleContacts
Bug: 32827405
Change-Id: I30a15e5ad8a2568d1c12735b86ff2903a08a4be7
ggregationSuggestionEngine.java
|
| 5834df9bb18be99c3885138d93b3c093d9c2770d |
09-Nov-2016 |
Yao Lu <yaolu@google.com> |
Merge "Log Edit Raw Contacts modal (1/2)" into ub-contactsdialer-h-dev
|
| 341d10405bb9ce0e01827beec8ccfec95f901a0d |
08-Nov-2016 |
yaolu <yaolu@google.com> |
Log Edit Raw Contacts modal (1/2)
Log this modal as Enum type SHOW_RAW_CONTACT_PICKER, so that we can have
more editor events added in the future.
When user clicks edit and this modal doesn't show, log EditorEvent as
(SHOW_RAW_CONTACT_PICKER, 0);
when user clicks edit and this modal does show, log EditorEvent as
(SHOW_RAW_CONTACT_PICKER, numberRawContacts).
Bug: 32678380
Test: Manually tested the log messages when edit a contact from
1) 1 writable
2) 2 and more writable
3) 1 read-only
4) 2 read-only
5) 1 writable and 1 read only
Change-Id: I8043e31d0051815b57f5f126ea4b66be551bcb9d
ickRawContactDialogFragment.java
|
| 3a53328fe057610d44f228666c92c3c5ac2d4799 |
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Revert "Revert "Load the raw contact's photo in picker dialog""
This reverts commit 3a5f94ffdb600864dc2f29df599cbdaa80046ffc.
Roll forward with fixes.
Test: manually verified:
* contact photos load in the main list
* no crash on viewing picker dialog
Bug: 32096517
Bug: 32384257
Change-Id: I6f798787abc928f6d287cde48182f2643aad364a
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| 3a5f94ffdb600864dc2f29df599cbdaa80046ffc |
08-Nov-2016 |
Walter Jang <wjang@google.com> |
Revert "Load the raw contact's photo in picker dialog"
This reverts commit 21bdf08ac2f7e53a1fd9ee69317302b1d035169c.
Bug: 32096517
Bug: 32384257
Change-Id: I5f5f2790a394c9bf27da60b0630474eb92701e12
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| 74940e1fbed7edf7ae204a8fa8945c90b9e8e606 |
08-Nov-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Load the raw contact's photo in picker dialog" into ub-contactsdialer-h-dev
|
| 21bdf08ac2f7e53a1fd9ee69317302b1d035169c |
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Load the raw contact's photo in picker dialog
Add a photo query to get the photoId for the raw contact.
Use the photoId to get the thumbail from ContactPhotoManager.
When loading a photo from the databases, pass in an empty byte array
instead of null to indicate that there just wasn't a photo instead
of null which gets interpreted as a failure to load and so the
special BITMAP_UNAVAILABLE holder is used to prevent further
attempts at loads (see b/21423350). Since the change only converts to
empty when reading from the database, that network bug should not
reoccur.
Test:
Verified:
* all photos for aggregates which have them appear in the
picker dialog
* removals, updates, additions to photos were reflected
immediately in the picker and main lists, including
to the me profile.
Bug: 32096517
Bug: 32384257
Change-Id: Ib704f84a351490bd2e34825d9602be813aa79b9b
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| 7b75145e9b4fcd46c3cbb5678f8842934467b3aa |
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Copy display name from the correct raw contact
Save a copy of the loaded Contact.
If editing multiple read-only contacts, get the name from the
one that contributes it to the contact's display name.
Test:
Manually verified the correct behavior
Bug: 32477129
Change-Id: I6308d645b1030ed0f317aafc907db8ba762750c2
ontactEditorFragment.java
|
| 2f8005a7b1a216f4cdc0b7d2c7c577585bdbbca9 |
07-Nov-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge "Remove an unused method" into ub-contactsdialer-h-dev
|
| f08e5d10205da403d518d533999ed48c395433d9 |
07-Nov-2016 |
Wenyi Wang <wenyiw@google.com> |
Remove an unused method
Bug: 32673993
Test: see ag/1605120
Change-Id: I697c7957f0f402474bdcbff47971aa165cca5ea9
ditorIntents.java
|
| a172180513fce7670fa1b2093c72966f6a377444 |
02-Nov-2016 |
Gary Mai <garymai@google.com> |
Ignore read-only raw contacts in picker modal pt. 1
Drop read-only contacts unless the SpringboardActivity is configured
not to.
Changed to using AsyncTaskLoader that returns a RawContactsMetadata
object which has all the information needed by the picker dialog.
Ignore legacy edit URIs and send silent feedback if they are given.
Test:
Manually checked the following scenarios has the correct behavior:
* Single writable raw contact
* Multiple writable raw contacts
* 1 read-only 1 writable
* 1 read-only
* 2 read-only
* Test app usage of legacy URI
Bug: 32640214
Bug: 32240763
Change-Id: Ia3542b927ea615a2b2d07f86cdc1ff8c91f99ba6
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| 079598fa2e09c22bb672715a9559b9d8973044d5 |
03-Nov-2016 |
Gary Mai <garymai@google.com> |
UX updates to read-only view of raw contact
Use back arrow for navigation icon.
Use "view only" string for title.
Change account header per screenshot in bug.
Test:
Manually checked and verified headers/navigation icons/titles of:
* view of read-only raw contact
* edit view of writable raw contact
* add new contact
Bug: 31868376
Change-Id: I1d390f785bf4c0de90102e6a9e02477a8c19ddee
ontactEditorFragment.java
awContactEditorView.java
|
| 3107b25dcaea54943c58f984084fa9b348ea1885 |
03-Nov-2016 |
Gary Mai <garymai@google.com> |
Show "add account" dialog when it needs to appear
Don't show the dialog if the only account is not a device account.
Set the default to be the only account if it is *not* a device
account.
Test:
Manually checked:
* Removing only account and attempting to create a new account shows
dialog
* Clearing preferences shows dialog
* If dialog was canceled, verify dialog doesn't appear anymore.
* After adding a google account, (and without manually setting default)
verified adding a new contact did not show a dialog and the default was
automatically set to the only account on device.
* Having two accounts and no default shows the pick default account dialog
* Removing multiple accounts still has the same behavior as bullet 1
Bug:32555078
Change-Id: Iec664efca7e886d7376cd2aae7c5b2bdad3a8b84
ontactEditorFragment.java
ontactEditorUtils.java
|
| 68de0a5baa8601e6b39f759b036c3d8bce0189c4 |
30-Oct-2016 |
Walter Jang <wjang@google.com> |
Add getContext() to PickRawContactDialog Fragment
Test: open editor on Nexus 5 LMP
Bug: 31088704
Change-Id: I320070cdbd87c2aaa9d4bed940b78d08170da686
ickRawContactDialogFragment.java
|
| c1fa9b75f2739c184294a65aa33887c82fc46a15 |
27-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "UX update to edit linked contact modal" into ub-contactsdialer-h-dev
|
| 27e8c3a3643923dcd6b41b956b0e6067c1d92dbb |
27-Oct-2016 |
Gary Mai <garymai@google.com> |
UX update to edit linked contact modal
Remove "(read only)" string.
Remove gray from read-only accounts.
Use ViewHolder pattern.
Test:
Manual test of modal with read-only raw contact.
Bug: 32460007
Change-Id: Id4d7fd45d120e1bebe6172e324efd3d20fcd7e46
ickRawContactDialogFragment.java
|
| 678108ebb9926a79ad0d7ac4f11417dec1583d42 |
26-Oct-2016 |
Gary Mai <garymai@google.com> |
Change aggregation suggestions to be raw contacts
Each suggestion is a raw contact that belongs to the same account
of the currently edited raw contact.
Surfaced data is the raw contact's data.
Pass the current changes to the newly selected raw contact.
Remove a few unneeded methods.
Removed the join option for tapping on a suggestion since all raw
contacts selected from here will be editable.
Since QuickContact depends on the aggregation suggestion engine to
return contact level suggestions also removed everything related to
it there since it's currently disabled.
b/29216287 tracks plans bring it back but it probably won't be in the
form of using the suggestion engine to populate the card, so it felt
okay to remove the code. Layouts were left in case they can be reused
later.
Test:
Opened QuickContact
Tested the suggestions for a contact with multiple raw contacts both
in and out of the current account and made sure only ones in the
current accountwere shown.
Checked contact with raw contacts which have different names, made
sure those displayed correctly. CP2 doesn't store the alternative
versions of raw contact names so the primary one is always shown
which is a non-regression.
Bug: 32277025
Bug: 32278866
Bug: 31088704
Bug: 31704115
Change-Id: Ibd4bdaaf100ffd5524eebac300d23763bbe6a22d
ggregationSuggestionEngine.java
ggregationSuggestionView.java
ontactEditorFragment.java
ditorIntents.java
uggestionEditConfirmationDialogFragment.java
|
| f8f6f95154dc89700823813a27149210e91ce89d |
22-Oct-2016 |
John Shao <johnshao@google.com> |
Editor Insert or Edit intent helper
Add helper to start the insert or edit flow
from other places in the app.
Test: manual
Bug: 32081723
Change-Id: I3d8c2c4d4c6d25f3beae045941c10f6ba2b5f411
ditorIntents.java
|
| f5f2fd4cf938768cf97d00cb730efcfaf35d387a |
24-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "Forward intent extras to editor activity from springboard" into ub-contactsdialer-h-dev
|
| 86a0c3b21eeef77e985ad1e3e8697e34acc02f41 |
24-Oct-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Preserve SIM import checked state after rotation" into ub-contactsdialer-h-dev
|
| 5336e6ef1924162b94942cbd8f69202d553822da |
23-Oct-2016 |
Gary Mai <garymai@google.com> |
Forward intent extras to editor activity from springboard
Apply the extras once we have selected a raw contact to edit.
Test:
Selected an existing contact to add to and saw passed in
data was correctly applied.
Tested cases where editor auto loads, and picker dialog shows up.
In the case of the picker made sure that selecting any of them
would have the data passed through.
Bug: 32345528
Change-Id: I9a4088b3358ab532362c878394c657781965fb03
ontactEditorFragment.java
ickRawContactDialogFragment.java
awContactEditorView.java
|
| a4adae163d83db9226b831f8c9705914e68b5cd1 |
23-Oct-2016 |
Gary Mai <garymai@google.com> |
Update editor menu options
Remove pick ringtone and send to voice mail options.
Add Help & Feedback option.
Test:
Checked options menu when:
* Adding new contact
* Editing existing contact
* Viewing read-only contact
Checked feedback screenshots for the above
Saw Help & Feedback had articles for both adding and editing contacts.
Bug: 32339015
Bug: 32336608
Change-Id: I7f591714062fed3bd70a2e1997305b2779148f89
ontactEditorFragment.java
|
| 73b283f03cd2697ad0098711d62cd0956037952f |
22-Oct-2016 |
Marcus Hagerott <mhagerott@google.com> |
Preserve SIM import checked state after rotation
Test
Manual:
* select import from SIM in settings
* uncheck some contacts
* rotate screen
* verify that same contacts are checked after rotation
Bug 32315354
Change-Id: Iad84d308ab61d813219bdd23e158f3c5acb969e8
ccountHeaderPresenter.java
|
| db22bd6950cde01af63fec7991d7aa3aea259244 |
20-Oct-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Update logic on when raw contact picker dialog is shown" into ub-contactsdialer-h-dev
|
| 5a00de39004d298de4daee3e183add5eff17102c |
20-Oct-2016 |
Gary Mai <garymai@google.com> |
Update logic on when raw contact picker dialog is shown
Shouldn't be based on count of raw contacts, but whether writable
raw contacts exist.
Test:
Edit me profile that has 2 G+ accounts linked (where the me profile
has not already been created)
Edit an aggregate composed of 2 read-only accounts.
Edit aggregate of 1 write 1 read
Edit 1 read-only
Edit 1 write
Bug: 32289543
Bug: 31826229
Bug: 31088704
Change-Id: Ib01445b59fa9fc882a6d32d24f39917d726e6174
ontactEditorFragment.java
awContactEditorView.java
|
| 92b36e91dc520ab744f399d253d63401d8107b09 |
20-Oct-2016 |
Jim Laskey <laskey@google.com> |
Merge "Toast fixes for deletion and save" into ub-contactsdialer-h-dev
|
| e5a140a1b60854a08a0ea0dc2068e9bf7cb058e6 |
19-Oct-2016 |
James Laskey <laskey@google.com> |
Toast fixes for deletion and save
Bug: 32243988
Test: Save contact from editor in alternative display mode.
Test: Delete contact from editor in alternative display mode.
Test: Save contact from editor with only phonetic or email or company.
Test: Delete contacts from list view with default and alternative
display mode.
Change-Id: I82df2377692ea129a54a3f0f00948201d4d1411e
ontactEditorFragment.java
|
| df86ede2101d902eb95838adf4176c89d9263c89 |
19-Oct-2016 |
Walter Jang <wjang@google.com> |
Update phenotype usage for GMS V4 (1/2)
Test: see ag/1555402
Bug: 31989967
Bug: 26400050
Change-Id: I806129e8593e091e2aa120e530d588efa5a0d508
ontactEditorFragment.java
|
| c861a986867a27ce26eae118287f4ff43f72325f |
18-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "Always write current state in EditorFragment" into ub-contactsdialer-h-dev
|
| 445a7c6afe18c19fe84b204d1fe7dbe088193f7b |
17-Oct-2016 |
Gary Mai <garymai@google.com> |
Use fragment arguments in picker dialog
Test:
Rotate device while picker is up and tap on a raw contact.
Bug: 32219954
Change-Id: I6223d0ba108c784d1c9edb171f13428498e2acfe
ickRawContactDialogFragment.java
|
| 36ceb4235ed685a222af86076dcf160ba124a583 |
17-Oct-2016 |
Gary Mai <garymai@google.com> |
Always write current state in EditorFragment
When the choose default account activity dialog is shown,
mState in EditorFragment is empty, so it doesn't get written to the
out bundle. When we come back to the fragment save state exists
and null is read.
Test:
Followed repro steps in bug. Only repro'd when don't keep activities
was enabled.
Bug: 32118572
Change-Id: I80e972cf18ac1b460a849a8e5a2cc8853bac62c4
ontactEditorFragment.java
|
| ba10be290e9a1b105743784ab6cc602bbf3078d8 |
13-Oct-2016 |
Gary Mai <garymai@google.com> |
Fix regression with editing me profile
Use Profile.CONTENT_RAW_CONTACTS_URI in PickRawContactLoader
if we're loading the me profile.
Changed rendering accounts attribution to be consistent with
the duplicates view.
* Me profile -> "My local profile"
* Focus Google account -> account name
* All others -> account type display string (Google+, LinkedIn etc.)
Test:
Edit me-profile with G+ account attached
Edit me-profile without G+ account
Edit linked contact with device raw contacts
Edit linked contact with SIM raw contacts
Edit linked contact with Samsung raw contact
Bug:32113893
Change-Id: I904e64eee262d0ddf95240915911228439c2c46f
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| e5c6d9fccd5acb30c341184e2010c0b2d21c1bb0 |
13-Oct-2016 |
Walter Jang <wjang@google.com> |
Merge "Guard against null SimpleDateFormats when editing events" into ub-contactsdialer-h-dev
|
| 5f8932def1e28419908cd8ccf53129914bda82b4 |
13-Oct-2016 |
Walter Jang <wjang@google.com> |
Guard against null SimpleDateFormats when editing events
Test: manually test that event dates are formatted
correctly for google account type
Bug: 31683447
Change-Id: I3c2d240c6a44c6e6bd74c8054d8f9fe6d4c4704f
ventFieldEditorView.java
|
| 86c7576a2dd37c6490a86ec25ce223164e111f7b |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "Prevent raw contact picker dialog from flashing" into ub-contactsdialer-h-dev
|
| 8dc115b246083b00d40974fd951d9130747af070 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "Skip psuedo name mimetype during delta parse" into ub-contactsdialer-h-dev
|
| ddbeec26c383ca64d5abcf615f74b75380918df1 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Merge "Use raw contact's photo in picker dialog" into ub-contactsdialer-h-dev
|
| ac5bd644bcd2c27294a70774abfa9e24fb3d5c52 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Skip psuedo name mimetype during delta parse
Missed this in ag/1527652, an extra name field was appearing
because of it.
Test:
Hit "more fields" and see no extra name fields.
Bug: 32023197
Bug: 21758689
Change-Id: I8b8f0cd1d8556dd79162a6c723b4bd108d1ed476
awContactEditorView.java
|
| 5eda257528e45fe6ae59cca3f1178590b53662f8 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Disable delete and unlink in editor
They currently work on a Contact level, so that functionality
has been moved to QuickContact.
They'll be re-enabled once they're raw contact based.
The attached bugs are tracking that effort.
Also disable link. That also makes more sense to live in
QuickContact since you're linking another Contact.
Test:
Manual check to see those items aren't in the menu
Bug: 30771904
Bug: 31827701
Change-Id: I96ba7d10c78a157c0d1374e81ad096cec414815b
ontactEditorFragment.java
|
| ea2f357213deac0bf6a930ad26394a6ee23eacf3 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Prevent raw contact picker dialog from flashing
If the dialog is currently shown and the loader calls onLoadFinished
again, update the cursor without doing another fragment transaction.
Test:
Followed repro steps in bug, confirming that the dialog doesn't
flash in and out, along with debug log statements to confirm
it goes through the setCursor call.
Bug: 32096586
Change-Id: Ia021c66e65adb6b4e34b0d4e3a0e521a31e3086f
ickRawContactDialogFragment.java
|
| ac70468a213748842a98281a8e8331cd0f9672e7 |
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Use raw contact's photo in picker dialog
Use the letter tile for the raw contact's display name if there
is no photo set.
Test:
Used picker dialog for raw contacts with and without photos.
Bug: 31826229
Bug: 32096517
Change-Id: I9934e370c6bb0c574364807c6fa5ee2d67b9146b
ickRawContactDialogFragment.java
|
| 7a6daea69ea47c31a1b838a423e7cdaceafae753 |
11-Oct-2016 |
Gary Mai <garymai@google.com> |
Reintroduce pseudo mimetype for name
In order to have a separate edit DataKind for phonetic name
we need a pseudo mimetype for just the name as well. The pseudo
DataKinds are used to render the actual text fields while the
StructuredName mimetype DataKind is used for checking if any
thing was changed.
Test:
Unit tests
Save a new contact while entering only the phonetic name
Bug: 32023197
Bug: 21758689
Change-Id: I151b37b7be091705974e3f36770e4bb0e150a64d
indSectionView.java
|
| e7781ec0385d880054b9aff65ee3085cff4ae2b6 |
11-Oct-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Create new SIM contacts import screen." into ub-contactsdialer-h-dev
|
| 819214d472fdadf3d69cb4580e238506194ed30e |
29-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
Create new SIM contacts import screen.
This is needed since SIM import is going be surfaced more prominently via an
assistant.
Test
Automated: Ran GoogleContactsTests
Manual: verify that contacts are imported when launched from settings
Bug 31781331
Change-Id: I55ea078056038d348d5b6f05f91f5159e1ee39d3
ccountHeaderPresenter.java
|
| d7faa65c1349a7ded4d2d478822c07d024e5e792 |
03-Oct-2016 |
Gary Mai <garymai@google.com> |
Remove account selector when editing a raw contact
Keep the header, but remove the onClick drop down.
Remove the boolean for if the raw contact is read only,
and use the current state to determine if that's true.
Test:
Applied this commit on top of the spring board one and tested:
1) edit read only raw contact
2) edit writable raw contact
3) edit contact made of single read only raw contact still opens
the insert a new raw contact version
4) insert new contact
Bug: 31826229
Bug: 31088704
Change-Id: Ia8e5b0a5965b77b0c160336ce81ddac801b201ff
ontactEditorFragment.java
awContactEditorView.java
|
| 62ec0b10c0ddc00053df39aeaed1f3316116e849 |
07-Oct-2016 |
Gary Mai <garymai@google.com> |
Ensure structured name exists when creating a new delta
When I was able to repro the NPE, the RawContactDelta had the five
entries that were ensured in createNewRawContactDelta. The only
likely cause is mIntentExtras is either null or empty so
nothing is copied over and the entries are empty.
Test:
Opened the editor for a single read-only contact a bunch of times.
Bug: 31874062
Change-Id: I7f47ff766457f3daf2099344661a3f5caf92388d
ontactEditorFragment.java
|
| a6c80b378e03ebdf6b654dbdb12f2c665fe98a80 |
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Implement editor springboard activity
Have the springboard handle edit intents.
Show a dialog if the contact is made of multiple raw contacts.
Go straight to editor if:
* Single raw contact
* Given a raw contact Uri
In the case of 1 read 1 writable, we still show the dialog
since there would otherwise be no way to view what data comes
from the read only raw contact.
The springboard does not handle legacy contact Uris and will throw
an exception if one is received.
Test:
Tested these scenarios:
1) Edit a single raw contact
2) Edit a single read only raw contact
3) Edit a contact made of >2 raws
4) Add new contact
5) Edit a contact made of one read only, one writable
6) Made edits and checked if quick contact continued to update
7) The relevant edit intents from the Test app
Bug: 31826229
Bug: 31088704
Change-Id: I4c1c44accc86521efce2081744189d25f00ec541
ontactEditorFragment.java
ditorIntents.java
ickRawContactDialogFragment.java
ickRawContactLoader.java
|
| 9c1974f6f46f45a65cf17811e109c86b28cd768c |
03-Oct-2016 |
Yao Lu <yaolu@google.com> |
Merge "Add link/unlink options to QuickContact"
|
| 2de7c8e0d319b977bdaf665abbd5a8a5ed41b7bf |
26-Sep-2016 |
yaolu <yaolu@google.com> |
Add link/unlink options to QuickContact
Bug: 31122952
Test: Manually tested
1) link contact from 1 raw contact, contact from multiple raw contacts
2) unlink contact from multiple raw contacts
3) for non-editable contact, me contact, link and unlink are not shown
Change-Id: I21137ee353a65ad50e800cbb2dd013c23408a5ea
plitContactConfirmationDialogFragment.java
|
| 5c1bff2efa542ea112c3f2a1d1ed1e271c7691a7 |
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Load all groups data from editor
GroupMembershipView needs all group data to determine which group
is favorites/default, so when we load from the editor use the old
selection string.
Test:
Followed steps in bug and made sure the contact wasn't booted from
the My Contacts list, and the selected labels were updated properly.
Also tested adding multiple new labels and saving those.
Bug: 31750797
Change-Id: I84b1be6c17f2acf46efc202fb81a2c180cc2bcae
ontactEditorFragment.java
|
| 363af60ea23e5a3b945005712a16564ab69db18b |
28-Sep-2016 |
Gary Mai <garymai@google.com> |
Rename editor files
Drop the Compact prefix since we only have one editor now.
Remove KindSectionDataList since it's now unused.
Test:
Tested build
Bug: 31088704
Change-Id: Ia5ac295804a14f79d0c837b151e33aabc60aa3d0
ancelEditDialogFragment.java
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
ontactEditorFragment.java
ditorIntents.java
oinContactConfirmationDialogFragment.java
oinSuggestedContactDialogFragment.java
indSectionDataList.java
indSectionView.java
hotoEditorView.java
awContactEditorView.java
plitContactConfirmationDialogFragment.java
uggestionEditConfirmationDialogFragment.java
|
| 698cee7d410f06b0c883c11f53481bfa5b2b787a |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
Split display name into first and last
Remove all support for directly entering the display
name.
Minor fix for getting focus after text editor expands.
Test:
Tested the following editor scenarios:
1) new contact
2) edit writable raw contact
3) edit read-only raw contact (joins a new writable raw contact to it)
a) Not editing the name and saving doesn't save the new writable
raw contact
b) making edits to the name and swapping accounts saves those edits
c) swapping around a lot doesn't create multiple writable raws
4) edit aggregate w/ 1 writable and 1 read-only raw contact
5) edit aggregate w/ 2 writable raw contacts
6) swapping accounts doesn't lose entered data
Bug: 21758689
Change-Id: I8d97083ae1e0db1031ee8e4d860f65d77022a1a1
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
|
| e48746654178e9448819f86b3129fd32f539b3c9 |
26-Sep-2016 |
Gary Mai <garymai@google.com> |
Promote aggregation suggestions to all contacts
If an invisible contact is selected from the aggregation
suggestion pop-up, add it to the default "all contacts"
group.
Test:
Edited an invisible contact from the aggregation popup,
saved and checked that it appeared in the main list.
Bug: 31703249
Change-Id: Ie8ee277ad6a8c3e07d5478036f109bfa1837fac3
ggregationSuggestionEngine.java
ompactContactEditorFragment.java
|
| e405c12a914e55a321fc96a611e6da609aa5c0de |
26-Sep-2016 |
Gary Mai <garymai@google.com> |
Merge "Restrict aggregation suggestions"
|
| 220d10cd7095f5ab803ff6155d7adaa576a8c4ff |
23-Sep-2016 |
Gary Mai <garymai@google.com> |
Restrict aggregation suggestions
Only show contacts which have a raw contact that's in the same
account as the raw contact that's currently being edited.
This also implies no single read only contact will be suggested
since you can't trigger the suggestions from a read-only account.
Test:
Tested entering a name that matches another contact within the same
account shows the suggestion popup when:
1) suggested contact has only 1 writable raw contact.
2) suggested contact has multiple writable raw contacts.
3) suggested contact has a mix of writable and read only contacts.
Checked no suggested contact appears when entering a contact name
that exists in a different account
Checked the above is still true when switching between the different
accounts in the account switcher.
Bug:31704115
Bug:31088704
Change-Id: I45e36e1e61b04069af419c47669c338985eb583d
ggregationSuggestionEngine.java
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
|
| aebf3206766a05cce290245f09506adb789b6e37 |
23-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove support for custom edit activities
Test:
Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug:31682268
Bug:31088704
Change-Id: I4000b4cef0d3c7beaa05cdef51ebdf978288c80f
ompactContactEditorFragment.java
|
| a7978d5bc3fcbe62a40e59e29aebea668385a98a |
23-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
resolve merge conflicts of 949d4e8 to master
Change-Id: I399652b6a1b756a8045c1fef092d10581d56400d
|
| 949d4e88400761dac02992978f6b79997b5f0055 |
20-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
Prevent device default account from sticking.
When a Google account is added and the default is the null device account then
the default should be cleared.
Test
ran unit tests:
$ adb shell am instrument -w com.android.contacts.tests/android.test.InstrumentationTestRunner
Manual test
* Setup nexus phone with no Google account but one outlook account
* Set default to "Device"
* Create new contact and verify that editor shows "Device"
* Add Google Account
* Create new contact and verify that default account chooser is displayed
* Choose the Google account
* verify that editor shows Google Account
* Remove Google account
* verify that default account chooser is shown again when creating new contact
* Set default to Outlook account
* Add Google account
* Create new contact
* verify that account picker is not shown and editor shows outlook
Bug 31603714
Change-Id: I46c87107727a8b50117e70066a4ef4d162970e84
ccountsChangedBroadcastReceiver.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorUtils.java
|
| 581585d9ad2e7d3d4b65798acaa0fa462d30710d |
22-Sep-2016 |
Walter Jang <wjang@google.com> |
Start ContactSheet instead of QuickContacts (1/2)
Test: Manually start QuickContact and ContactSheet from
1. DefaultContactBrowseListFragment
2. Me profile (preferences)
3. Group members
4. Duplicates (with result)
5. Editor (known issue here that ContactSheet doesn't refresh)
6. Shortcuts (this one always ones QuickContact)
Bug: 31666272
Change-Id: Ia939b89fee4f18b62b3d72c87a5077cf350ded24
ompactContactEditorFragment.java
|
| 0396cf7a2b80c4cb1a63e4fdc8d60a1cf6f486f5 |
21-Sep-2016 |
Walter Jang <wjang@google.com> |
Consolidate utility methods to start QuickContact (1/2)
Test: Manually start QuickContact from
1. DefaultContactBrowseListFragment
2. Me profile (preferences)
3. Group members
4. Duplicates (with result)
5. Editor (after save)
6. Shortcuts
Bug: 31666272
Change-Id: I0ad41bdefb69bcc680488dd39e74f02b2b8a4c65
ompactContactEditorFragment.java
|
| 4e0e969b0bdfcfedfa2f09b914d323b6f116cbca |
22-Sep-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Write null into file ID when removing photo"
|
| 8d66f45f45032ddfa22290fd7cdb0eba72501a74 |
21-Sep-2016 |
Jim Laskey <laskey@google.com> |
Merge "Save contact toast shows display name"
|
| 18724188d3abe065b0a030fb2d9d5557dcb6163e |
21-Sep-2016 |
Gary Mai <garymai@google.com> |
Write null into file ID when removing photo
Writing null into the file ID of the photos value delta
'after' will prevent the editor from trying to read it after a
rotation.
Have the photo editor view hold on to the MaterialPalette so we
use the same color for the default once a photo is removed.
Test: Manual usage of removing a photo from a contact with one and
rotating.
Bug: 25978539
Change-Id: I84c4b22c4064de1d788b08921a5c0164475865af
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| b1671053e48d14f2c620f48bc5f2cd915b51a002 |
16-Sep-2016 |
James Laskey <laskey@google.com> |
Save contact toast shows display name
Bug: 29882910
Change-Id: Icdf0ea1e8c4fac9104d97de83d6ff6f5cbe59142
Test: manual tests with fresh contact (only name, only number)
Test: manual tests with updating old contact (change name)
ompactContactEditorFragment.java
|
| da20b47c2b85390a2c3772379e71203c5aab513c |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove compact photo picker code
Removed code/classes that related to selecting one of the raw
contact photos to be the photo for the aggregate contact.
After this the only way to set the aggregate contact photo is
to change the photo of one of the raw contacts.
Test:
Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
9) editing photo of a raw contact that is part of an aggregate
updates the aggregate photo
10) each raw contact had the correct photo when
we switched to it.
11) changing a photo for multiple raw contacts within
an aggregate and saving changed all of them. (the last one
changed was marked as primary)
Bug: 31088704
Change-Id: Ia704ae5c6cf81836abe6e48c83922ca1dd036d32
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
|
| 0981a5888177e85144f60684ddd80e491dba72b3 |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
Merge "Remove all List forms of KindSectionData"
|
| 4ceabed629c43cb247fd4a0faa36c09bd5ec999a |
16-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove all List forms of KindSectionData
Pick and render one raw contact delta at a time in editor.
Have the account selector always visible.
- When viewing a read only contact, header will say "Viewing"
- Otherwise it says "Saving to"
Swap between raw contact deltas when an account is selected in the
drop down
Keep menu options available even when viewing just one raw contact.
Remove some code related to photo picker.
Test:
Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
9) editing photo of a raw contact that is part of an aggregate
updates the aggregate photo
10) same with editing the name
Change-Id: Id797619e656d3a9974cc9454a3d26fee471569d5
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| 40b026f415e0ae6f7f0bd8ed711f44308e63f738 |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
resolve merge conflicts of 9fa8987 to master
Change-Id: I41e488cb0a1472233ccf9e6c26095f26920671ca
|
| 710802c3cc918a0d604d3c23ac7469f48fedf69d |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
Fix showing aggregation suggestion
Accidently broke the aggregation anchor view retrieval method.
Now returning the proper anchor view.
Test: Typing a name that would trigger the aggregation suggestion
and seeing the pop-up appear.
Bug: 31575242
Change-Id: I7e20712d89ce58106000cdcf7402aa29b279ce8a
ompactRawContactsEditorView.java
|
| 9fa8987d511857fafddadc082982aef6816c2b4f |
20-Sep-2016 |
Gary Mai <garymai@google.com> |
Don't render account name for device and sim
In the raw contact selector, ignore account name for
DeviceLocalAccountType and SimAccountType since they don't have
good renderable names.
Test:
Manually checked drop down for linked contacts that contain
Device and Sim accounts.
Bug: 31544599
Change-Id: I37db95e585077d1f2a37474705b4a5ed645804b6
ompactRawContactsEditorView.java
|
| 95130ade398017fa2e035b798e8b9607f2cf6709 |
17-Sep-2016 |
Wenyi Wang <wenyiw@google.com> |
Hide phonetic name view when phonetic name data kind is not present
Bug: 31547816
Test: manual
- follow steps to repro in bug
- also rotate screen
Change-Id: Ic7e04268e426bf1e58d8c4fa9df40fca52ed7a15
abeledEditorView.java
awContactEditorView.java
|
| 6a9817185248a30e1553fa5da5db89f081b6fcf1 |
17-Sep-2016 |
Gary Mai <garymai@google.com> |
Fix crash when switching to Samsung account in editor.
Need to clear the current sorted mimetypes when setting state,
since each account type might not support the same mimetypes.
In the case of Google -> Samsung, Samsung doesn't have SIP
addresses.
Test:
Tested switching from Google Account to Samsung account.
Bug: 31552749
Change-Id: I1504040716c1ba3929747d84940a3b2da10959e4
ompactRawContactsEditorView.java
|
| 65971d0f87dbee0b5ff93a7d64cdaab0940f56f5 |
16-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove more editor view classes
Got rid of KindSectionView and the base and read only editor views.
Moved most of the read-only editor field rendering logic to
CompactRawContactsEditorView.
Dropped the expandable functionality of the read only view.
Dropped the edit externally functionality as it doesn't look like
it's being used.
Test:
Viewed the single raw contact only view from the account list.
Bug: 31088704
Change-Id: I9ba0172f4002b2fe24cd397ea65298cf486f5873
aseRawContactEditorView.java
ompactKindSectionView.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
indSectionView.java
hotoEditorView.java
awContactReadOnlyEditorView.java
iewIdGenerator.java
|
| 98868d33107de0dd539441e80e94b856f2269057 |
14-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove multi account grouping of data in compact editor
Remove most List versions of KindSectionData and KindSectionViews,
with exception of photo section data, since we still want to show
the correct photo. In the aggregate screen with the multi account
selector, we show the photo of the aggregate in read only. Once
a raw contact is chosen to edit, we show the photo of that raw
contact.
Removed sorting that dealt with multiple accounts. Still sorting
the mimetypes.
Drop custom field data kinds until we're ready to render them.
Use for loops instead of for each where possible.
Test: Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
9) editing photo of a raw contact that is part of an aggregate
updates the aggregate photo
10) same with editing the name
Bug: 31088704
Change-Id: I39219af0bfd1ac0899b6518983be942d78bda9aa
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionData.java
|
| 410eee311c7dbaf1b29c1f034bbd317ae7d57dfb |
13-Sep-2016 |
Gary Mai <garymai@google.com> |
resolve merge conflicts of b6e28d2 to master
Change-Id: Ic8adea7525406a376b598954f33ee2642ccb1b88
|
| cc3e9a584bffc68387d77197d7a08678b9fd1847 |
12-Sep-2016 |
Gary Mai <garymai@google.com> |
Focus label edit view on click
am: f862233695
Change-Id: Id59c5f5162a9b26c335fd23d2ff5105ccfcc4dcd
|
| 5ab17a20873bea733dca47ba4cead97cd51f1354 |
12-Sep-2016 |
Gary Mai <garymai@google.com> |
Merge "Remove layout transition from photo view in editor" into ub-contactsdialer-g-dev
|
| f8622336951554047a10ab0c7dda8199970f2f8c |
09-Sep-2016 |
Gary Mai <garymai@google.com> |
Focus label edit view on click
Take focus away from previously focused fields so that the
the background view doesn't scroll up when the new label
dialog is shown.
Test:
Manual
Tested opening the create new label dialog while another
edit text had focus.
Tested canceling the dialog and committing a new label.
In the case of committing made sure the label edit view
was in the viewport so the entire popup is visible.
Bug: 29055820
Bug: 29211998
Change-Id: I45c604f9b94ab03a67bc1d5c64d98364140f931f
roupMembershipView.java
|
| b6e28d2da2a36462e0d6cb93430ee26f753a17d9 |
12-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove layout transition from photo view in editor
Test:
Tested repro steps in the bug, made sure there wasn't animation for
the photo edit view
Bug: 31403085
Change-Id: I1934a3d7c10cf9de80836ce7958aae3de4783b34
ompactRawContactsEditorView.java
|
| 2b875aab92954400c4ed058e0e9876da36d36993 |
12-Sep-2016 |
Gary Mai <garymai@google.com> |
Editor expander changes
am: 1c6298b67f
Change-Id: Ic2a545e5344bcae36a8d940d9200d1c3ce52c6a4
|
| 1c6298b67fe3f25562b50793e610334a43d6a34c |
09-Sep-2016 |
Gary Mai <garymai@google.com> |
Editor expander changes
Missed tinting the phonetic name expander in ag/1417505.
Went ahead and did some refactoring since
phonetic_name_edit_expansion_view was the same as the name_edit one
but with a different content description. Removed it since content
description should be dynamic with the state of the expander anyway.
Along that line also made accessibility improvements and fixed a bug
with the state of the icon after rotation.
Test:
Checked the color of the phonetic name expander.
Actioned the expanders with Talkback on and made sure the correct
announcements were made.
Checked state of icon after rotation was consistent.
Bug: 30160325
Bug: 31033553
Change-Id: Ia62ed1a03b4edda81815387e3bcf4f48449699e2
honeticNameEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
|
| f04c975dc39fe9b49e51c05807006c5164fbe0ba |
09-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
resolve merge conflicts of cf7f295 to master
Change-Id: I49249472948c29b97be8fe33cda8fa022d8e62f6
|
| cf7f295a05bd356ea8715ea456fbe5f6ced9d823 |
06-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
Restrict fields supported by SimAccountType
Test:
Manual test
* Create new contact using FAB
* Select SIM account
* Verify that only name and phone number are editable
* flip to landscape
* verify that name and phone number are still editable
Bug 30868406
Change-Id: Ifd067db57f64208a71191000bdee6fab1aa99767
ompactKindSectionView.java
ompactRawContactsEditorView.java
|
| 68c265862346328fe9b700cbb467b9ad7247da8f |
08-Sep-2016 |
Gary Mai <garymai@google.com> |
Format phone numbers when inserting a new contact
am: c03cfc04a8
Change-Id: Ida51773110228e025773f1b26977de72686fdcbf
|
| c03cfc04a8f66dc30360f3eb7ec876d4cae64237 |
08-Sep-2016 |
Gary Mai <garymai@google.com> |
Format phone numbers when inserting a new contact
Set formatAfterWatcherSet to true when inserting a new contact.
Test:
Tested opening and closing a contact with an unformatted number
doesn't prompt to discard changes.
Tested adding a new contact from Allo has formatted number.
Bug: 26754145
Change-Id: I82546e86aec1e901e9b508eeaf7b87cf9f28d22f
extFieldsEditorView.java
|
| f2a1fc77f697561ff31bea5a7d01c5f34120d2f4 |
07-Sep-2016 |
Gary Mai <garymai@google.com> |
Import new expand icons
am: 3e9637f91b
Change-Id: I6a134aa6c1f1ae2e574c07561e0770eb5bbd4a36
|
| 3e9637f91b3b7f985212e1c9d6d94c996c13100e |
07-Sep-2016 |
Gary Mai <garymai@google.com> |
Import new expand icons
Also update X close icons to be vector drawables, tinting
them to the proper colors where they are currently used.
Test:
Manually verified the following with Bullhead on M (MDA70B):
1. Dropdown icons in compact and full editors are 54% transparent
black.
2. X's next to edit text views are 38% transparent black.
3. X's in search and selection bar are still 54% transparent
black.
Bug: 30160325
Change-Id: Ice24a70f02141f641c389060c37bdc87b727b230
aseRawContactEditorView.java
extFieldsEditorView.java
|
| 935b56aabd5ee1562df1d16324ce8e3f51005651 |
07-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add changes lost in I467a8b4fa5cc610c3e1627f30631a55ecd6c91c1
This allows contacts to be created in a null device account without showing the
account chooser. It also shows the correct title in the action bar when viewing
device accounts.
Change-Id: I3ee096d1ed70d544fd719e930dcb49953c162eb3
ompactContactEditorFragment.java
|
| 3c1153ffe62484e83764fbed7668d52c065fa518 |
07-Sep-2016 |
Marcus Hagerott <mhagerott@google.com> |
resolve merge conflicts of fac695a to master
Change-Id: I467a8b4fa5cc610c3e1627f30631a55ecd6c91c1
|
| 668f748c7bf34a9dc2914b44d6e7d7aa7d7538a7 |
07-Sep-2016 |
Gary Mai <garymai@google.com> |
resolve merge conflicts of 46cb310 to master
Change-Id: Iae98c5320fec2e26bc692df029e483b7977dcd62
|
| fac695a36b227f5591eac064ded8e8dad3398400 |
25-Aug-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add device and SIM to AccountTypeManager
This makes these account types available throughout the app rather than
just the Nav drawer.
Test:
Added unit tests for new classes; run with:
$ adb shell am instrument -w \
com.google.android.tests/android.test.InstrumentationTestRunner
Manually on Nexus 6, LG G5 and Samsung S7 with device and SIM contacts
in CP2 by verifying "Device" and "SIM" options were available in
* nav drawer
* account list accessed by Pressing FAB without default account set
* editor account dropdown for new contact
* editor account label when editing existing contact
* picker for default account in settings
* settings customize screen account list
Bug 30867780
Change-Id: I329381ccc58d59f2e27f65a3d9dc0164fb20c971
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorUtils.java
ditorUiUtils.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 46cb310fdaddc40cc7872fa7a7514a2a00757c1c |
11-Aug-2016 |
Gary Mai <garymai@google.com> |
Show icon of account being saved to
Remove unused layouts for various account header types and simplify to
two:
One for linked contacts (editor_all_rawcontacts_account_selector) which
displays a linked chain icon and one which displays the account icon and
an optional expander icon (editor_account_header). The account icon one
is used in the single account case and when creating a new contact.
Test:
Manual usage of the new selector:
1. Single account case
2. Linked account case shows linked chain with a selector dropdown
3. Creating a new contact shows icon of account being saved to
3b. 3 but with multiple accounts so the selector is visible
3c. 3b with swapping accounts and making sure the icon updates correctly
Bug: 29455526
Change-Id: Ic7784cc6e77b934468795176ee774a5247cce9a9
aseRawContactEditorView.java
ompactRawContactsEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 7b0970fd1db1a97f1be915d66d07f4dc8499f96d |
01-Sep-2016 |
Walter Jang <wjang@google.com> |
Merge base and compact editor fragments
Base editor constants, inner classes, members,
and methods were moved to the compact fragment
unchanged except:
* isAggregationSuggestionRawContactId was unused so just
removed it.
* maybeConvertToLegacyLookupUri was moved to
ContactEditorUtils
Test: Manually tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: If3652dffef6a428aa0534ffbc639ae66601d6ab4
ancelEditDialogFragment.java
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorUtils.java
ditorIntents.java
ditorUiUtils.java
oinContactConfirmationDialogFragment.java
oinSuggestedContactDialogFragment.java
plitContactConfirmationDialogFragment.java
uggestionEditConfirmationDialogFragment.java
|
| be3305505a2e6343a5296198459e4ec4ed907c17 |
01-Sep-2016 |
Wenyi Wang <wenyiw@google.com> |
Fix editor crash in multi-window mode
Bug: 31236427
Test: manual - based on "steps to reproduce" in the bug.
Change-Id: Iea187b7b1389a9f8ebd4acfd603cf51376c22c11
ontactEditorFragment.java
|
| 8d45cdbd4e1e0b37d705fd1dca3d8f941f75e772 |
01-Sep-2016 |
Walter Jang <wjang@google.com> |
Merge base and compact editor activities (1/2)
* The ContactEditorBaseActivity.ContactEditor interface
and subinterfaces are moved w/o modification except
ununecassay modifiers (public, public final static)
were removed.
* Base class members were moved w/o only visibilty
changed to private. The ContactEditorBaseFragment.Listener
mFragmentListener implementation was unchanged.
* Base class Methods were moved directly over with only
slight changes (a few finals added). onCreate and
onBackPressed were just moved inline into the corresponding
CompactContactEditorActivity where the super method
was being invoked.
Test: Manually tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Test: Also tested that duplicate culusters are updated are after a
quick contact edit
Bug: 31088704
Change-Id: I620c345fc6339b6b0807a44bafbac3201ca7b81f
ontactEditorBaseFragment.java
|
| 55d0e7146d7c4fe5008bd664c44c25a29934fd87 |
01-Sep-2016 |
Walter Jang <wjang@google.com> |
Move SelectAccountDialogFragment from common.editor to editor
Removed the SelectAccountDialogFragment.Listener from
QuickContacts since the dialog is not displayed anymore.
It stopped being used in ag/522326 but we forgot to delete
the listener implementation.
Test: Exercised the moved dialog by: 1) creating a label and
2) import contacts from SIM on a device with more that one
writable account.
Bug: 31088704
Bug: 30759296
Change-Id: Id78b41b80556fd44adb1f20e0ba9217918d23ff3
electAccountDialogFragment.java
|
| c6405c15d1e501a711f813c9e1a4db6e9fcaa11d |
31-Aug-2016 |
Gary Mai <garymai@google.com> |
Remove account switcher from full editor
am: 127c86e70b
Change-Id: I21e4e80822f52677898ddb84c6eb42ee1e3e27f4
|
| 127c86e70b4083defdcf4907c68254006211c197 |
31-Aug-2016 |
Gary Mai <garymai@google.com> |
Remove account switcher from full editor
Was causing an NPE.
Test: Manually opened different types of raw contacts in full editor
from an LG-H860
1) read-only contact
2) phone contact (treated as read-only)
3) writable contact linked with read-only
4) 2 writable contacts linked
Bug: 31181339
Change-Id: I1dcb7b93025d92cb58a735dbb887cf99d45d1518
ontactEditorFragment.java
|
| 8bac28bebae51e53885a404cdf2dd4991000ba42 |
30-Aug-2016 |
Walter Jang <wjang@google.com> |
Remove full editor (1/2)
Test: Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I1fce2873facefa39d7b468f1deda02acc674e3e1
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
awContactEditorView.java
|
| 9a55237f705453caae1f8aa3576a9acd7596d5ec |
24-Aug-2016 |
Walter Jang <wjang@google.com> |
Change editor raw contact selector to open the compact editor
* Whe editing more than one raw contact, just show the
raw contact selector with no input fields.
Eventually we'll be displaying the raw contacts in
a list instead of a drop down.
* When a raw contact selector item is clicked, open
the compact editor instead of the full one.
* We do the same trickery that the full editor does
to render a single raw contact -- even though
ContactLoader loads the aggregate, we pass along
the raw contact ID in the Intent to start the compact
editor and ignore all the other raw contacts in the
RawContactDeltaList.
* The compact editor is updated to be able to render
read-only raw contacts.
Test: Tested the following editor scenarios:
1) new contact
2) edit writable raw contact
3) edit read-only raw contact (joins a new writable raw contact to it)
4) edit aggregate w/ 1 writable and 1 read-only raw contact
5) edit aggregate w/ 2 writable raw contacts
6) edit local me raw contact
7) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I86a7fde976af8b318c7fb3da4f74f29f08a69eef
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| 155299e727607ad397f21481d251e7f0c990c343 |
25-Aug-2016 |
Walter Jang <wjang@google.com> |
Check res IDs before setting label content descriptions
Bug 31088704
Change-Id: Ia0cbe1cee0c3b2735d4baa0a98776104b5c09e08
abeledEditorView.java
|
| 3ab1178953480c7eaaeb9d9795ca4e72646474f6 |
22-Aug-2016 |
Walter Jang <wjang@google.com> |
resolve merge conflicts of 6bb8718 to master
Change-Id: I62258095e91ad4874e403e35142fbc1cedd1b120
|
| fd64b253a9df174c497e688ad75706c63cbabbb4 |
22-Aug-2016 |
Walter Jang <wjang@google.com> |
Merge "Replace @NeededForTesting w/ proguard keep flags (1/2)" into ub-contactsdialer-g-dev
|
| 4a28965efa79c78e9e0f1144c08f87887a5e763e |
22-Aug-2016 |
John Shao <johnshao@google.com> |
Fix for LMP crash for Fragment.getContext()
Fragment.getContext() was added in API level 23 so changing
usage from getContext() to mContext and adding override to
the fragment just in case.
Bug 30601104
Change-Id: I682cb28b60ca3d4103cb41f34d331ef761cde2f2
ontactEditorBaseFragment.java
|
| 6bb8718b04da174f3642fbdcefea0fee6086db3d |
22-Aug-2016 |
Walter Jang <wjang@google.com> |
Replace @NeededForTesting w/ proguard keep flags (1/2)
* Replace -keep of entire c.a.c.common package
with individual classes
* Remove all use of @NeededForTesting annotations
(and the file itself since @VisibleForTesting
accomplishes the same thing)
Test: Ran user build ContactsTests on Nexus 5 MOB30H
Bug: 30976481
Change-Id: I8d9a4d6b3409a159a108b39c1c4837a19e2325ca
ontactEditorUtils.java
ditorUiUtils.java
|
| 41c6886cabf68370f160ccd68d173bd6a59a1a07 |
18-Aug-2016 |
John Shao <johnshao@google.com> |
Force intents to start in app wherever possible
Add class/package names wherever possible for intents that are
started within the app itself. This is to avoid the intents picker
dialog that makes the user choose which app to handle the intent.
Bug: 30601104
Change-Id: I98d3a5a5c2112f1ba0c944b37c9b6754837dfa9c
ontactEditorBaseFragment.java
ditorIntents.java
|
| a4fe1ee4eb4b73dece0f26f2e75578fef7f39fe7 |
16-Aug-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Prevent user from creating duplicate labels." into ub-contactsdialer-g-dev
|
| 186d791128b43a1e75aba879bd14bffa6fd47b7b |
10-Aug-2016 |
Gary Mai <garymai@google.com> |
Add highlight to selected item in editor dropdowns
Using the same selector background as in the nav drawer.
Bug: 28945806
Change-Id: I6711cf16c99f0f257b32c10d6a43eb1e9e7b1401
abeledEditorView.java
|
| bc66bbaf1274d4fe1a3df92690fc378e5c49b694 |
02-Aug-2016 |
Marcus Hagerott <mhagerott@google.com> |
Prevent user from creating duplicate labels.
This isn't enforced at the data layer just in the UI's that
allow editting of the group name.
Bug 28718604
Change-Id: I969b0298bd895fdbdd7f8609da05f2b801707c0a
(cherry picked from commit 8d62cd2c5c855fd5483c030c1d59e50830ce4dfc)
roupMembershipView.java
|
| b0550f0265523d836e2b6ab0bf33256413f5c558 |
09-Aug-2016 |
Gary Mai <garymai@google.com> |
UX changes for compact editor
Back button changed to X symbol.
Save checkmark changed to SAVE.
Discard changes dialog wording changed per b/28945754.
Bug:28945754
Change-Id: I767538fb69b97754765e27af49ab62d5028d9a27
ontactEditorBaseFragment.java
|
| 3cb77bbf7119749ed4854a4b981fcabcf55823be |
28-Jul-2016 |
Wenyi Wang <wenyiw@google.com> |
Fix IllegalStateException in multi-window mode
Bug 30302153
Change-Id: Ie9ca55bf9b3ddc3d1cc2aab10ebffeccc035d5f0
ompactContactEditorFragment.java
|
| f34bd4235c0ca3f1cf8b192bb572a4e463bc36ff |
30-Jul-2016 |
guanxiongliu <guanxiongliu@google.com> |
Bringing import/export dialog and edit photo dialog up to spec (1/2)
Bug:30079784
Change-Id: I7e05b5ec089ad7b612d19afe349ce52ea3b3334a
hotoSourceDialogFragment.java
|
| 6eb8e0d5d8304e5220c95a07bfd54c6a44674fdd |
21-Jul-2016 |
Gary Mai <garymai@google.com> |
[DO NOT MERGE] Contact editor RTL rendering fixes
Force LTR on an AggregationSuggestionView when the data being surfaced is
a phone number.
Don't allow full screen editing in landscape mode.
Bug: 30152819
Change-Id: I810ada236ce5f75b9923159bbfe3f1d5fd4f5faf
(cherry picked from commit 6773ea1d6a3e2e060bec193251da2d5ab057c6ae)
ggregationSuggestionView.java
extFieldsEditorView.java
|
| cfa628c4006e6122a60fafa573a472474f886fe0 |
14-Jul-2016 |
Tingting Wang <tingtingw@google.com> |
Set delete button description for editor view without type.
Current logic only sets content description for:
1) editor view with type.
2) editor view without type but has text changed on TextFieldEditorView.
This cl will fix the bug to set description for editor view without type.
BUG 29162515
BUG 29162517
Change-Id: Ieea82f8c0f288894c819cfd12800d59e57d002c6
abeledEditorView.java
|
| 541743ce471222a1eacf8a6366eebc0ee7c1e273 |
30-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Better name for local account (1/2)
Bug 29882162
Change-Id: I046b81f62dec109c3502f84ee19eae008217ae98
ditorUiUtils.java
|
| 611c435f639caa7dc8aa15e4e8919b48bf34d287 |
25-Jun-2016 |
Tingting Wang <tingtingw@google.com> |
Fix bug on full editor note view.
ValuesDelta with empty ops should not be ignored, since
all empty editor will be process in UpdateEmptyEditors() method.
BUG 29506357
Change-Id: I734e9a104ceab17d80a113d84eae34f70ac72ac2
indSectionView.java
|
| 37ad9fbba748664acfeaf058a36c221600aa62d5 |
21-Jun-2016 |
Tingting Wang <tingtingw@google.com> |
Always hide default account picker when one writable account.
BUG 25467864
Change-Id: I81fa329831a6cb3d7252702b8a68bb19ead22b85
ontactEditorUtils.java
|
| 4be1bea453eec162fe95ff124df16c39f17c96f8 |
13-Jun-2016 |
Gary Mai <garymai@google.com> |
Merge "Pass an edited result back from the editor if changes were made"
|
| 6bf22f5f573b24fa910af1a6a8ec9873ef29f081 |
11-Jun-2016 |
Xi Chen <samchen@google.com> |
Merge "No prompt is seen when new contact is saved"
|
| 250fc1699c72966a5118b9afd814ca2445628ae3 |
11-Jun-2016 |
Gary Mai <garymai@google.com> |
Pass an edited result back from the editor if changes were made
Bug: 28968298
Change-Id: I23658aad6012500535dc6e2ac5198376f0337c2e
ontactEditorBaseFragment.java
|
| 378461ea75216f566236edb5970a84c6d4e62774 |
11-Jun-2016 |
Xi Chen <samchen@google.com> |
No prompt is seen when new contact is saved
If the default account is removed and added back, the app also
saves this account as the default account.
Bug 28878992
Change-Id: I6265502bf774a32387d3ca84b8ca393071b8f620
ccountsChangedBroadcastReceiver.java
|
| 05f47b582446f420382a14f69681142296e4af0d |
03-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Check newly-created group rather than the last one
Bug 29055640
Change-Id: Id0534ea9f2a0f6f6b485a062fe6faadb15e0c124
roupMembershipView.java
|
| cb650f0a744576482c5b8bfc2756b79623dd30a2 |
12-May-2016 |
Wenyi Wang <wenyiw@google.com> |
QuickContact for multi-window mode am: caf2619708
am: af7075c5fa
* commit 'af7075c5fa04dcb82c2fc7fb07ee9e312de258c5':
QuickContact for multi-window mode
Change-Id: I49c1a8ee31dfc796dbbf27f04aa343f1cb240495
|
| caf26197087343fdc18739e20e217236ff26831e |
10-May-2016 |
Wenyi Wang <wenyiw@google.com> |
QuickContact for multi-window mode
Bug 27614994
Change-Id: Ifd875f3602b799c419c6c3b0bad4865e727a6d59
ompactPhotoEditorView.java
|
| 5663f084f36d3a144dd7b339d7ba94a37ffcbf57 |
03-May-2016 |
Wenyi Wang <wenyiw@google.com> |
Replace "Groups" with "Labels" (1/2)
- Get rid of "group" in strings and comments
- Remove unused strings related to groups
- Replace ellipse with unicode …
- Get rid of old group icon and use label icon instead
Bug 28495297
Change-Id: If14f493b74505413f9e25ec98d774594730fbe11
ditorUiUtils.java
|
| 90e74a539d92a59da8ea2994c91bac908e4ac7d4 |
30-Mar-2016 |
Tingting Wang <tingtingw@google.com> |
Merge "Using Proguard to shrink apk size." into nyc-dev
|
| 0488c3d83099c4d82f5ddc41c045bc7b7833de29 |
30-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge "Revert "Don't use file ID of the removed photo"" into nyc-dev
|
| 9deead63f39d6891385b29d8f76c07136d89699a |
28-Mar-2016 |
Tingting Wang <tingtingw@google.com> |
Using Proguard to shrink apk size.
Contacts proguard.flags change, add keep class for tests.
BUG 27314641
Change-Id: I4a169e50602ebdcea197baa54f4f887a76acdeb5
(cherry picked from commit 6035674bd506f3c9bdb49c9ce271747d7eff229e)
ontactEditorUtils.java
ditorUiUtils.java
|
| 4a39ecb7ac71e58d0a221d315f7f9d33ce6bfc2b |
29-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge "Update content description after updating primary" into nyc-dev
|
| 1d896225c06d079ea1f771ea0127248ebe1798e1 |
25-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Clear span array and set only 1 span when phone number changed
Doc https://goto.google.com/b25324025
Bug 25324025
Change-Id: I40f228efd704e956976d74b2fd8123bf8cc3f770
(cherry picked from commit 0761a0cdbef8447ef108111243279c6b5a91c2e3)
extFieldsEditorView.java
|
| d375c35c89364aa101f11fa2c2f1270742d50f9b |
29-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Update content description after updating primary
Here's what went wrong: we set content description of photos in
CompactRawContactsEditorView.getPhotos() (see ag/834274) and then
we modify "primary" before entering photo picker (see ag/854600).
We need to update content description of photos after modifying
"primary" to reflect the change in which photo is checked.
Bug 27881948
Change-Id: Iad9723c9adbeaf8396fc46c578cc4a519d9ba85a
(cherry picked from commit 5a59c26c4e43fedcd449dfae97ea435f1ce885e3)
ompactContactEditorFragment.java
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
|
| 2a4848adcae11e3ee3d5483268d251cccc043e33 |
29-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Revert "Don't use file ID of the removed photo"
This reverts commit a12ac6d6b376d5151d86a9d66c887a60fb604995.
Change-Id: I086396189653f5dd9f16ebd312d18631cae670d2
ditorUiUtils.java
|
| a07c90b6b07bfbd527dbf815d65b8ee0d28fbd6a |
07-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Revert "Hide keyboard on touching type spinner and show it after selection changed"
This reverts commit ce0413b7c8fc85a782c611c5b0b4fce1d6f40256.
Bug 25322155
Bug 27536072
Change-Id: I1667cdf9932381458f7168237d6f2b902063ee3f
abeledEditorView.java
extFieldsEditorView.java
|
| 62a2074bb3b8dc66996e9fc6a8748b999ab2b51c |
25-Feb-2016 |
Walter Jang <wjang@google.com> |
Log where quick contact was opened from (1/3)
Bug 27341012
Bug 18388581
Change-Id: I0628e9ad842ab64fc1bf6196500a64fddf465466
ontactEditorBaseFragment.java
|
| 13103cd05bf911a496fccdf84e5ea6eb0be87910 |
20-Feb-2016 |
Walter Jang <wjang@google.com> |
Don't auto format phone numbers when editor opens
The new behavior was introduced in ag/856515 to fix b/26754145
This causes contacts with phone numbers that do not have
the standard formatting to show as changed when the editor
is opened as then closed even when the user makes no edits.
Bug 26754145
Bug 27247065
Change-Id: I9ff8443844dd5d419df5c50e3664b382edbec045
extFieldsEditorView.java
|
| f8c8ac348cf217766a6626a5b7191a0de11f06d3 |
20-Feb-2016 |
Walter Jang <wjang@google.com> |
Revert "Don't pass read-only portions of RawContactDeltaList to contact save service"
This reverts commit e5bac73a8b241a43143e5780c07597cd6fa9230f.
Revert "Don't prune read only contacts in SaveService for joins and splits"
This reverts commit I717717a3c8b55315dcf3dde026af4c267f62e709.
Bug 27108237
Bug 27250533
Bug 23896510
Change-Id: If52f514c01f0d346fddc4083c710b7147761dd7d
ontactEditorBaseFragment.java
|
| cf0734b567b77bab782c533214ebe4e044a04f9c |
17-Feb-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge "Don't use file ID of the removed photo" into nyc-dev
|
| a12ac6d6b376d5151d86a9d66c887a60fb604995 |
12-Feb-2016 |
Wenyi Wang <wenyiw@google.com> |
Don't use file ID of the removed photo
Doc https://goto.google.com/removedphoto
Bug 25978539
Change-Id: I77abbc11766a570eb657a3b02ef910b3fa300f45
ditorUiUtils.java
|
| fe4f03cd0ca38e446f7690e1b5e076e65530bb37 |
14-Feb-2016 |
Wenyi Wang <wenyiw@google.com> |
Set number of columns of photo picker dynamically
We use magic number 135dp to get the number of columns.
Here's the number of columns on Nexus devices:
https://goto.google.com/devicecolumns
Bug 27181878
Change-Id: I346caf488423586655cdd2a650c0502f7ff1bb9b
ompactPhotoSelectionFragment.java
|
| 44c67ec4440d37abfe630526c77f761c84a47a94 |
04-Feb-2016 |
Sean Liu <guanxiongliu@google.com> |
Merge "Deprecating ConfirmAddDetail dialog to use full contact editor."
|
| 3d59049c39e5c3896a3d741c4f7cafbbf26c8e69 |
02-Feb-2016 |
guanxiongliu <guanxiongliu@google.com> |
Deprecating ConfirmAddDetail dialog to use full contact editor.
Bug:22851692
Bug:26754145
Change-Id: Ic8bf321a27f5e43ffb68146690d421375a6f9e33
extFieldsEditorView.java
|
| e5bac73a8b241a43143e5780c07597cd6fa9230f |
03-Feb-2016 |
Wenyi Wang <wenyiw@google.com> |
Don't pass read-only portions of RawContactDeltaList to contact save service
Bug 23896510
Change-Id: Ie50aa5c0581779c12861072ec838f26d444fb549
ontactEditorBaseFragment.java
|
| 972d093ca0c0c8479765f9b85873a6a85ae9797b |
29-Jan-2016 |
Wenyi Wang <wenyiw@google.com> |
Override primary to set check mark in photo picker
Doc at go/checkmarkinphotopicker
Bug 25092609
Change-Id: Ieca46eb4f15f125b227b138fef5b24cc3f6ce666
ompactContactEditorFragment.java
|
| c41a1e5f5f4872c3a0da5dec7671b66d9d80eb4e |
29-Jan-2016 |
Wenyi Wang <wenyiw@google.com> |
Revert "Show check mark when none is primary in photo picker"
This reverts commit bb601f2d4a7ed4db46dd87a4d451d42c666f1591.
Change-Id: Ia7a677e7f5d5a28fc45a1e3b85da52d9b1382485
ompactPhotoSelectionFragment.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| bb601f2d4a7ed4db46dd87a4d451d42c666f1591 |
14-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Show check mark when none is primary in photo picker
If there is a photo in photo picker that is marked as primary,
we will use check that photo in photo picker.
Otherwise, with this CL, we compare the photo URI passed from
QuickContact to editor with the photo URIs in photo picker to
decide where to add a check mark.
Bug: 25092609
Change-Id: I0ae77f9874a60f45dcfb305d058ade9de4fef4a4
ompactPhotoSelectionFragment.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| d1cc5fe91e96bdbea59fbc8c7561a76c60835e49 |
26-Jan-2016 |
Walter Jang <wjang@google.com> |
Try to make the cancel editing confirmation dialog less confusing
Bug 26615850
Bug 26594357
Change-Id: I651e9a056227a7149051c3f9bb55b26d24cd7fad
ancelEditDialogFragment.java
|
| 09f573b5d19ac52a19ed61da4c18d3d43a7d64ff |
21-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Backport PhoneNumberUtils methods (1/2)
Used compat methods to handle compatibility and removed a completed TODO.
Bug: 25629359
Change-Id: Iedb6fb694657f201452c28e954d08f2a71470fa6
awContactReadOnlyEditorView.java
|
| aac0e66fb100b329d6010637998849048efadca9 |
19-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Backport ContactsContract.PinnedPositions and create compat package
This class was unhidden in API level 21 and the undemote method was
added in API level 21 as well.
Bug: 25629359
Change-Id: I7eecd28338a8f14fca7b8249599c3f7eac70442c
ggregationSuggestionEngine.java
|
| b6e3ecb718dc1d849849c16f5abf1bff303419a8 |
16-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Fix NPE in getPhotos()" into ub-contactsdialer-b-dev
|
| ab36017cd9385e3180aff694939cc4280fd008eb |
15-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix NPE in getPhotos()
Avoid calling toString() on a null CharSequence.
This change affects content description used in Talkback only.
Bug: 26179572
Change-Id: Iba6f1258dbe6c5797e05e9b1aa1e07b70cc17fda
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
|
| 1f4a623084219ae9f8d7c012c0d25c63c7aae7ca |
16-Dec-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bugs when dropping down editor type list in Editor UI.(2/2)" into ub-contactsdialer-b-dev
|
| 6062cec2b36471fbc9a40c1b268a0ce88db03369 |
10-Dec-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs when dropping down editor type list in Editor UI.(2/2)
When loading editor type list from Editor, overall number should
not be checked since the editor has already been added.
For the other cases we will keep it, just like the old logic.
BUG 25929524
Change-Id: I008c2777a62c652375a9c498e53e778e9358f904
abeledEditorView.java
|
| 82b293711b38fca4a30b5bf1b1637a1280a8d861 |
12-Dec-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bug when adding an empty editor type in Editor UI." into ub-contactsdialer-b-dev
|
| 6d8c6294a5167cbdb832df07bf677a7f5bdd618c |
11-Dec-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bug when adding an empty editor type in Editor UI.
For both compact editor and full editor, using the method
in RawContactModifier to check if an empty editor type should
be inserted, since that method would check not only overall number,
but also the limit for each specific type.
BUG 22521808
Change-Id: Iefe401f26aec8d8cece4723c0486d3add6732f74
ompactKindSectionView.java
indSectionView.java
|
| dd7d456a080f48d93aa3a9f9b04da0f17a8833a7 |
08-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Catch exception in starting ContactSaveService
This CL follows ag/798285 and adds try/catch blocks for all the places
that start ContactSaveService using static methods in ContactSaveService.
Bug: 23896510
Change-Id: Ie35cf0d213386a81a662777a5b37d6f3a3fc5633
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 0e368b0a34f8e469bd57d5da5860f5f2a668c7ce |
26-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Set default account when there's only one writable account." into ub-contactsdialer-b-dev
|
| 4abdee91084b6ee89f1ef1a8b797a5a2e0272059 |
24-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Set default account when there's only one writable account.
Hiding the dialog to check with the user about default account
when adding a new contact for one writable account.
BUG 25467864
Change-Id: If97408c4205a31a17c2a5ca5a148592e678097ca
ontactEditorUtils.java
|
| fcc7dc9e271df409247b24cb3e8cdeb9017beeb5 |
19-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Copy TTS code for backporting (2/2)
Bug: 25629359
Change-Id: I0fc62440802a2b28a22dd3ec7c2c2e5410ef5b80
extFieldsEditorView.java
|
| 18fd9387ccad82da3afce5f091dc7b685aaea118 |
20-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Backport AggregationSuggestion URI builder
Bug: 25629359
Change-Id: Ie498d0a08c78ce98c46b82f9c7e6d448b119d130
ggregationSuggestionEngine.java
|
| 9bc9ba878cf7f77a2a6b3200a6ab716d13f1affc |
18-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix usage of getContext() on pre-M SDKs (2/2)
Bug: 25629359
Change-Id: Iafaa6f4e26944f6c4e37495fb8cfef946aeb0f8d
ompactContactEditorFragment.java
ompactPhotoSelectionFragment.java
|
| da258ff16a03b150e4c8004aa2be6f20c196a1ec |
17-Nov-2015 |
Walter Jang <wjang@google.com> |
Use selected photo ID as the "photo to display" lookup parameter
Don't use the photo ID passed in on the Intent to open the
editor since that will never change.
Bug 25729444
Change-Id: I84082245ac491c9481cc469d0b7342755250ec66
ompactContactEditorFragment.java
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| 62e6e4d8ed36623fc3d601438b3616e72bad0d64 |
16-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Show visible and non deleted editor view to Editor UI." into ub-contactsdialer-a-dev
|
| d482e0c41f5ebc7a11b781f6dcfbaed1f4f7ba3a |
16-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Show visible and non deleted editor view to Editor UI.
BUG 25713840
Change-Id: I0c682b6873f5dd6c286c87020a3863dea6214e21
ompactRawContactsEditorView.java
indSectionData.java
|
| 3184fc86688ca9a769072d7c4288afd5438e0c53 |
16-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Unset super primary of writable accounts photos" into ub-contactsdialer-a-dev
|
| 9086fb91b69241f53eaa09067b10797c0000891e |
16-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Unset super primary of writable accounts photos
Bug: 25714956
Change-Id: I2d24f57732b069f08a4913db20702f98b853db12
ompactRawContactsEditorView.java
|
| 6dc36b0172a79b8a310110739936ddae14234d32 |
16-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Hide Group editor if account has no groups.
BUG 25695708
Change-Id: If0ab5576287e4501a4f7b6e68ef1f40db0d629d8
ompactKindSectionView.java
roupMembershipView.java
|
| 5835795b48ca8db363436363d587190c05b5f033 |
14-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bug for exchange account editor." into ub-contactsdialer-a-dev
|
| 608d3211d95f86fd7b74f8b7558d4f1b712a1261 |
14-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bug for exchange account editor.
For exchange account contact, name field is different from the others.
First name and last name are shown instead of one display name field.
So convertion between display name and first/last name need be added.
BUG 25673410
Change-Id: I617a9e356514db9468488e00f75420f09f63da83
tructuredNameEditorView.java
|
| 42d740c24e913dc8065f2dbbfeaf598bf2fb4180 |
13-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix for undefined method
Change-Id: Ic04e7e0deb85d7a2bcdfe730fb05e80cf2b5ad42
ompactRawContactsEditorView.java
|
| 1b4ccf1ed5c6369e1b4ddde0ced9583b403e1c01 |
13-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Add editor for visible valuesDeltas
Bug: 25690715
Change-Id: Id5438976fa7e4c0d31d0fbbdd0b40df361b72668
ompactKindSectionView.java
indSectionData.java
|
| df864c7808e84ad7938af5e1b5246f1b17673326 |
13-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Show delete button only when text is not empty" into ub-contactsdialer-a-dev
|
| 228e02f29dbe84c52129ba07cd44b83bea5f2751 |
13-Nov-2015 |
Walter Jang <wjang@google.com> |
Don't return invisible values deltas from KindSectionData
Also don't cache values deltas inside KindSectionData
Bug 25431751
Change-Id: I65478e25dfa536342a75f71db48af3e22a4bead1
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionData.java
indSectionDataList.java
|
| 83e7e63a8c482a6969cd62ba5b33a6700c87efcd |
13-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Show delete button only when text is not empty
Bug: 25431751
Change-Id: I3daaaf9f1dc5353ebb799060d0ff568350db0a60
extFieldsEditorView.java
|
| ebccb965e09da01c5eee97fd3a40562bf1d9ce0f |
13-Nov-2015 |
Walter Jang <wjang@google.com> |
Ensure there is always a photo and name values deltas
* Don't hard code name mime type when trying to looking
for the entry to write
Bug 25671465
Change-Id: Ie236641a64b195350104e5771ae57b6b7f099ccc
indSectionDataList.java
|
| 71149ba5130583f74581f40190044cadf08d23ed |
11-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Fix for Talkback announcement of local contact photo in photo picker" into ub-contactsdialer-a-dev
|
| d0ac22fc7546537c55c5680e410ee4d1327df0fb |
11-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix for Talkback announcement of local contact photo in photo picker
Bug: 25498370
Change-Id: I854165e5ffa374a709b06e5c9cd8fbce24263f56
ompactPhotoSelectionFragment.java
|
| 4571858f1eb73dd02dd2e15a97af7f31c0e62822 |
11-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Suppress TYPE_VIEW_SELECTED event when pressing "more fields" in editor" into ub-contactsdialer-a-dev
|
| 843de7780921fede41dda55b2f25d490d251e0c4 |
10-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Suppress TYPE_VIEW_SELECTED event when pressing "more fields" in editor
This will get rid of the announcement of label spinners when pressing
"more fields" in editor.
Bug: 25500868
Change-Id: I15c8c928915398b815b9108e742cd460f50393c3
abeledEditorView.java
iewSelectedFilter.java
|
| 0b144564a6cf26bfa4da2b7972f580b90d7ede2c |
07-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Enable Talkback for photo picker
- When pressing a button, Talkback speaks the button text.
- When pressing a photo, Talkback speaks photo's account type,
user name, and whether the photo is checked or not.
- When double tapping a photo, Talkback speaks the account type,
user name, and that the photo is checked.
Bug: 25498370
Change-Id: Id43a220a4d5625470ff0ad1ff40a840d9c6bcd84
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
|
| 334e81b933de7c75056ace5681d9478338ca45bc |
07-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Correct content description of labels spinner and delete button in editor" into ub-contactsdialer-a-dev
|
| daf8a41b06faa010851f7391364f37a4db1e7d04 |
06-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Correct content description of labels spinner and delete button in editor
Now, pressing on the labels spinner, Talkback will say "<Kind> drop down
list"; pressing on the delete button of editor with labels, Talkback will
say "Delete <Type> <Kind>"; pressing on the delete button of editor without
labels, Talkback will say "Delete <Kind>".
Bug: 11553536
Bug: 25499016
Change-Id: Ibb57ee2226c4eea159e75c7cf901c3febd83fa82
abeledEditorView.java
|
| 9f153a02a56b9d97dc51371243c52e79fbce5813 |
06-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on RTL alignments.
1) when Quickcontact displayname is phonenumber.
2) fix alignment for "saving to" account in editor UI.
3) fix alignment for editor text in editor UI.
BUG 19209562
BUG 25513982
BUG 25514141
Change-Id: I7fba04b8a5e26ed4c3f3ccf3954cbc0639909291
extFieldsEditorView.java
|
| ef0bb49a4316c36f35d76d2aaae0e0cb558d7cc3 |
03-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bugs when reading phone number in talkback mode." into ub-contactsdialer-a-dev
|
| b6949dc7ed1b0ab47dc6a39b3ae0d42e029be2b4 |
03-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs when reading phone number in talkback mode.
1) In quick contact UI, phone number should be read out in number format.
2) In edit UI, phone number also should be read out in number format.
BUG 25447971
Change-Id: I5b2e60cd25c2585d4314996c14b126e9f2ce0470
extFieldsEditorView.java
|
| ce0413b7c8fc85a782c611c5b0b4fce1d6f40256 |
03-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Hide keyboard on touching type spinner and show it after selection changed
Bug: 25322155
Change-Id: I33eecbcaad15828a417921b893d6eb495395a15c
abeledEditorView.java
extFieldsEditorView.java
|
| b7933743dd27d537c64303e33e23a1461989f6c6 |
02-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Change accessibility message for account picker.
BUG 25324831
Change-Id: Ib20e7b2f0e581e25942b9dea993617642d813eb5
ompactRawContactsEditorView.java
|
| ae9c0662eeff7ea8a0b4855a26fda893f6fb1b2f |
30-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "String changes to Contacts App (3/3)" into ub-contactsdialer-a-dev
|
| b708f0adae06c3bac8758cfc9488c6386d864e00 |
30-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Add account type icon to account info header and change style of "Saving to"" into ub-contactsdialer-a-dev
|
| 07bc6766184d7c95724c549944633061b062d8ef |
30-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
String changes to Contacts App (3/3)
1) Delete read-only contact dialog.
2) Link and Unlink dialog title removing.
BUG 25386765
Change-Id: Icf238b27ff3928b0cc6245bb6f7b8266aaaf8d13
oinContactConfirmationDialogFragment.java
plitContactConfirmationDialogFragment.java
|
| 3e8cc3545302155fdd262ab1935029247e82254d |
29-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Add account type icon to account info header and change style of
"Saving to"
Screenshots: https://drive.google.com/a/google.com/folderview?id=0BwSNbQ_IWQd2NUFqb21MUm11WU0&usp=sharing
The changes related with "Saving to" (b/25366902) are in:
- res/layout/editor_account_selector.xml
- src/com/android/contacts/editor/CompactRawContactsEditorView.java
The changes related with account type icon (b/25189655) are in the
other files. The account type icon is added to account info header
in both full editor and read-only editor.
Bug: 25189655
Bug: 25366902
Change-Id: I4f149f639debd31296da81f6678cda8d01007ea9
ompactRawContactsEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 168331d85c5be43a816eb24fd37a2ebdbe61ac53 |
30-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
String changes to Contacts App (2/2).
1) Suggestion card help message.
2) Delete confirmation dialog.
3) Link, unlink and discard confirmation dialog.
4) All Contacts tab.
5) Place on home screen.
6) Default account dialog text.
BUG 25386765
Change-Id: I79a31ee143f38868d92c4d6f0379694462f595fb
ancelEditDialogFragment.java
oinContactConfirmationDialogFragment.java
plitContactConfirmationDialogFragment.java
|
| 0d9c24b77d319db5ecf21e92898625fdec5c1ec2 |
29-Oct-2015 |
Walter Jang <wjang@google.com> |
Warn about saving pending changes before unlinking
Also, remove unchanged new raw contacts that were
created to edit read-only contacts before unlinking.
Bug 25314004
Change-Id: Id75083456cd24fc1b06e489380614172bd370ad4
ontactEditorBaseFragment.java
plitContactConfirmationDialogFragment.java
|
| e3373dceb689209533e95a2cfbfbf1d9008ab6f6 |
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't save editor before showing join suggestions
This requires us to pass the raw contact ID of the
contact to join to both the (new) confirmation
dialog and the contact save service so that we
have it to do the join after the save completes.
Bug 25314004
Bug 21956248
Change-Id: Icdcb2165a0e599dfa3745fe8a919b208d4a48b43
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
oinContactConfirmationDialogFragment.java
|
| e394595987e288807b8c02c78d7d33e854f152b1 |
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Set read only display name as primary in fragment not view (DN 2/2)
Also, don't remove the display name from the editor input
field when checking for pending changes, instead just
skip the name mime type after detmining that the read only
display name was used and that it didn't change.
Bug 21956248
Bug 25314004
Change-Id: I9da8430206a721a52b8dad19e5eb235cb9e57fb3
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| 7be9d27563e5873f349bc1cf6ef9915b24967328 |
28-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Hide account container in compact editor." into ub-contactsdialer-a-dev
|
| 1594c6f3603e071c75294c9c430cee45ef642479 |
27-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Hide account container in compact editor.
Show account container when editing ME profile.
Hide account container when linking a writable contact with
a readonly one in editor. Also, showing unlink menu in this case.
BUG 25231329
Change-Id: Ia8cb59b93e0a3e46bcfa265d2d16518b3900204a
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| b8ab8612a80604dddbd1f87bc0b7aa5143af0ca3 |
27-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Allow G+ profile photo to be saved as ME profile.
Bug: 25282799
Change-Id: Ie3872383311b401b2e8f3a983e27fcfe592c84f7
ompactRawContactsEditorView.java
|
| 2f94e320c13d079644df5dd96caf278862b11f74 |
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't hide types when associated label is empty" into ub-contactsdialer-a-dev
|
| f7dfa54ed84dc2499a860d2dca362eca8fd78433 |
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't hide types when associated label is empty
This is causing hints to not be displayed
occassionally and is a little jarring/janky.
Bug 25035421
Change-Id: I48d3247bd0548f1a3de58953ab6895c660e07159
ompactKindSectionView.java
ditorAnimator.java
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
extFieldsEditorView.java
|
| 7ab14cbdb81cbb62c31db4102d1107d61a3823f3 |
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't skip pending check when save to account changed" into ub-contactsdialer-a-dev
|
| 13aede84cf83a9fb4bfb2f28eb77429b3b43169d |
26-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Use string "Contacts unlinked" when unlinking
Also removed the period in "Contact saved."
Bug: 25231225
Change-Id: I95908809b144911ced124ea52abe5d6cdece3774
ontactEditorBaseFragment.java
|
| 2c7fdac948e7b815ff5ef3a6989b8f1f4eeba323 |
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't skip pending check when save to account changed
Bug 25231216
Change-Id: I342a25ce52735052c2b4d5a6620581067c68762a
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 81e7fea1d73f243b95372712ea869e1fd584a0b3 |
24-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Suggested Aggregations Color and Spacing Tweaks" into ub-contactsdialer-a-dev
|
| 5368489acaadac82706ca0e678ec04d662db702e |
23-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Suggested Aggregations Color and Spacing Tweaks
In collapsed view
- modified image size, text.
In expanded view
- modified title text, help text and size,
- modified current contact photo and padding, added current contact info below contact name,
- modified suggestion photo and padding
- modified button color, and made it listen to the checkboxes
Bug: 25165935
Change-Id: I21a32c78d0bcc664693547641e0d0e8ca37a90e3
ggregationSuggestionEngine.java
|
| 2bb85d2c733b8e88da27f6bd90546fa032d4da05 |
23-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix account selector UI in Contact editor.
1) Hide the "Saving to" account container when there're both
read-only and writable contacts.
2) Add more space between name field and whatever are above it.
3) Show linked contacts selector when there's only one read-only.
BUG 25219324
Change-Id: I9229132a833400de5cb542bc5363a4e3f36c9d1a
ompactRawContactsEditorView.java
|
| df2b25c3515becc4e673316751fc2e34fd0f081e |
23-Oct-2015 |
Walter Jang <wjang@google.com> |
Prune invisible link suggestions by default
It's weird that the quick contact card and the editor
name popup show different things.
Bug 25186736
Change-Id: Iaab525926bdcbab0664c44b46ba493f145059263
ggregationSuggestionEngine.java
|
| 176d677f0604ec93613261155b9ec551a3d29158 |
23-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Hide invisible contacts in suggestion card." into ub-contactsdialer-a-dev
|
| e5e6a2acc903c94962657b3c97219bc20ec8cd6b |
23-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Hide invisible contacts in suggestion card.
Only show visible contacts in Quick contact suggestion card.
BUG 25186736
Change-Id: I56cd2d9bbd75772940d81582d2196bcbce0bf209
ggregationSuggestionEngine.java
|
| 2e569510fd85d94c699264fde71f7ae24ff2a18d |
23-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Allow "Saving to" and linked selectors to be displayed at the same time" into ub-contactsdialer-a-dev
|
| 23709545a1060e48f60e90f592c44811910e88c8 |
22-Oct-2015 |
Walter Jang <wjang@google.com> |
Allow "Saving to" and linked selectors to be displayed at the same time
Also, only show contacts that can be opened in the full editor
in the linked accounts selector.
Bug 25186290
Change-Id: Iefecb47b40160b291acdc358fad4a6c17492df07
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| 19952cdd46f67fb59b47cea43d407a682dcb91c6 |
22-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Catch transaction too large exception" into ub-contactsdialer-a-dev
|
| c47121c52b9d78c4ebad8aac4d4823d9dbc4334e |
22-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Catch transaction too large exception
Some raw contacts from WhatsApp may be very large since WhatsApp stores
duplicate data. Editing and saving the linked contact of those contacts
may cause a crash. For now, let's prevent the crash and show a toast.
Bug: 23896510
Change-Id: I0b6e94b7bb693008521c66d692c946031c6a8259
ompactContactEditorFragment.java
|
| 552a6b87a572bca7983484869035107705d8b228 |
22-Oct-2015 |
Walter Jang <wjang@google.com> |
Remove discard editor menu option
Also hide voicemail menu options for the me profile
Bug 25165475
Bug 25164540
Change-Id: I0c0dc318ac9bbe8a36656c2383091d7c9d4ce5cf
ontactEditorBaseFragment.java
|
| f5ac33af8189b223fc4ad87484981339b1654482 |
22-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Add name to rawContactDelta when editing a Me contact.
This cl will fix Me profile editor by showing its name field.
BUG 25159510
Change-Id: Ifd29528c3a9c0f017af3532a50f3b1f00d953969
indSectionDataList.java
|
| 65175dcd2e8caa5ef156c77646651d034142a9a4 |
21-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix NullPointerException in Contact Editor." into ub-contactsdialer-a-dev
|
| ac4b12f5e303647f7a6437e36be7026446d4e99f |
21-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix NullPointerException in Contact Editor.
Contacts App crashes when trying to edit a new read-only contact.
It only happenes sometimes.
Change-Id: Ib3a5d139e029d5b4ae296485ac3fa4f68f6b9881
ompactRawContactsEditorView.java
|
| bfea74f34f3c1c4ea33302c0c59635acb7b801ad |
19-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Further UI tweak of photo picker
- When photo picker is shown, the action bar title will be "Choose photo".
- Modified column width of GridView in photo picker to use entire screen
width.
- Changed the folder of all photos button to "all photos"
Bug: 24988706
Change-Id: Ia3e3ddf515c308e1cf6cdabc4c99fd7f9d983bc0
ompactContactEditorFragment.java
ompactPhotoSelectionFragment.java
|
| 82acd42c04554bd565c42e0a6674159d6887e1fe |
17-Oct-2015 |
Walter Jang <wjang@google.com> |
Choose the right contact to display in the single name field
* Also guard against there not being a primary raw contact delta
* Fix account info header when there are no accounts
Bug 25035441
Bug 23589603
Change-Id: I6ba6bd3b7377295f9522dbf0623962fb6e7af367
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionDataList.java
|
| 409541c8bb576145c831ea4c63d77db6cf3f7884 |
16-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Photo Picker Design Tweaks
Removes the camera button in the top right corner and uses two buttons to take a photo and
select a photo.
Bug: 24988706
Screenshots:
https://drive.google.com/a/google.com/folderview?id=0BwSNbQ_IWQd2RWpldXJEOFhkMW8&usp=sharing
Change-Id: I579016ad0bcfcb7a2b5407717b59ed1539f1eecc
ompactPhotoSelectionFragment.java
|
| be5e1b109ce134c7f3f45cd4fc27b69454d7ad31 |
17-Oct-2015 |
Walter Jang <wjang@google.com> |
Show "local only" account name for me profile
Bug 24988734
Change-Id: Ief827757e148d240ec74b46c1dfbb11c1c68a18c
ompactRawContactsEditorView.java
ditorUiUtils.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 9488a766fd27dfe5324205a95e9465aacc470e58 |
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Fix the account selector and linked accounts titles
Bug 24988734
Bug 23589603
Change-Id: I1032decbd7aee04efd0b61aaf39a14a54b69be6b
ompactRawContactsEditorView.java
|
| f695eb38011cf1140f73f533be726f420bc0a3fd |
16-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Editor should only show one name field.
BUG 24974860
Change-Id: Iaefd1fc42f440ca378aa4cc91b47e6688739107f
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionDataList.java
|
| 708774a560438e66f35cbb26b47fe32898b9ed15 |
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Add missing import
Change-Id: I73fe94c9ea5c4969c9e2685215b9051379fd9de6
ompactRawContactsEditorView.java
|
| fc0a90d5be5723874cb41fa704d93ce384f005c8 |
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Put back setting photo" into ub-contactsdialer-a-dev
|
| 4c9cf3ae7056b7189372973e2f04fb9e0f2c3242 |
16-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Put back setting photo
Bug: 24910349
Bug: 19697372
Bug: 23589603
Change-Id: I7789add9ae05928b0cd1e540da97dc6c0c9e7771
ompactRawContactsEditorView.java
|
| 45b86d5e83a7d6eca4abe5cdfece2e9050b1809c |
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Put back setting of photo from template
* Mistakenly remove it in ag/790426
* Also looks like we weren't setting from template it to true
after removing the photo.
* Finally, don't set super primary on the local profile
Bug 24981999
Bug 19697372
Bug 23589603
Change-Id: I3e759d5ea75e10c62108728874b771446ac61631
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
|
| e5e7aefb0c258d69e1e4dac841f3815f55c75835 |
15-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't show groups on the compact editor if there's more than 1
Bug 24980001
Bug 23589603
Change-Id: I4492c0036f826d591f59e5ab18b034afe21990ff
ompactRawContactsEditorView.java
|
| 982684009d0adce08c02b14af16cb44d7ee615e1 |
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Use the terms "Link and Unlink" instead of "Merge and separate"." into ub-contactsdialer-a-dev
|
| 838d2bab64b4bd29f8e956100c01909d08cc6279 |
14-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Avoid saving contact when user doesn't intend to do so." into ub-contactsdialer-a-dev
|
| 7394c4375bb7e0b279d813e7a73ffcb10e5825c2 |
14-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Avoid saving contact when user doesn't intend to do so.
We will not save contact when user:
1. picks a photo;
2. presses "Recent" button;
3. presses "Home" button;
Bug: 24898586
Change-Id: I40339de573ac069abffada1a6329009c3b97076c
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
|
| 5585c6ef5e8f075bdc3d514887322c6fa683f4cb |
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Use the terms "Link and Unlink" instead of "Merge and separate".
BUG 24704875
Change-Id: I466907482434c0312f8ab922cdfa5e2e82ec4637
ompactRawContactsEditorView.java
|
| c683d2273c4174c0e300ef2f4b17c77fb313da39 |
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bug when showing overflow menu in Compact editor.
Set default value for rawContact id to display alone.
BUG 24899070
Change-Id: Ibdb25080e62f669f9c466bf55e67dbbe63ff6afb
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| a0b6940902fd68241b27b32cffdd2ecf7446f919 |
13-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Raw contact drop down should keep order in Editor.
In compact editor UI, linked raw contacts drop down should keep order.
Also, the order in the comma style list should be the same as
in the drop down.
BUG 24898494
Change-Id: Ieed213388e52c5355c5e9ad33c1ee9db40696117
ompactRawContactsEditorView.java
|
| ba6c41ca6da97f56f608a9ef92617f2401f8371e |
13-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Improve raw contact editor in Contact Editor.
1) When clicking save on raw contact editor, UI should return to
the quick contact UI.
2) Remove overflow menu on raw contact editor.
BUG 24899070
Change-Id: Iae6954744294fc48fe8dba02459f647f1764c48b
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 3f18d6197a54aad10bea9c5cc2c89ca82809e793 |
08-Oct-2015 |
Walter Jang <wjang@google.com> |
Fix some photo selection fragment bugs (E18)
* Hide the photo source dialog when there is only
1 photo in the aggregate
* Fix reverting to photo selection fragment on
rotate after taking or selecting a photo
* Unset super primary on other photo valuesdeltas
after taking a new photo (also fixes full
res image not loading on quick contacts after
the editor is closed?)
* Show full resolution photos on photo selector
even if they have not yet been saved to CP2
Bug 19697372
Bug 23589603
Change-Id: Idd6966ba981d251ae713950ea2f0d2d60c7b30c0
ompactContactEditorFragment.java
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
ditorUiUtils.java
|
| 81365081af63f8a09cf10613ecd653b3b1ee7e5f |
08-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bugs on Contact editor." into ub-contactsdialer-a-dev
|
| 91cee2852497e918e9e04a6fb549c1117ed47ae0 |
07-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on Contact editor.
1) Remove primary photo checkbox in full editor. Primary photo should
be set in photo picker.
2) Remove save menu if there's only one read only contact in the full editor.
3) Add account type icon in account info when there's only one account
for a contact.
4) Return back to Compact editor after saving results in full editor.
BUG 24547289
Change-Id: I02f8ee01f7cc7d1b0b06ad338570dc4b17c55e31
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
|
| 4f5594a0437e8592b6f828f8344d3f83cbd9aad6 |
07-Oct-2015 |
Walter Jang <wjang@google.com> |
Add a name to raw contacts created to edit read-only contacts (E17)
This is a revert of the parts of ag/771915 (E5) where we changed
to moved to always showing all of the names.
Bug 24509375
Bug 23589603
Change-Id: Ief4773592233dc05b40bae8fb425d1c258d0b68f
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
indSectionData.java
indSectionDataList.java
abeledEditorView.java
tructuredNameEditorView.java
|
| cbd431df6e9c7116850249461faf9f5a9b8b89c3 |
06-Oct-2015 |
Walter Jang <wjang@google.com> |
Move finding primary/writable raw contacts to KindSectionDataList (E16)
This will help us since editing the 1) name and 2) photo, and 3) finding
the primary account used to sort editors so that new fields get added
to the primary account all do something similar to find the
ValuesDelta that changes are written too.
We can also enforce that only the same DataKind/mime-type are added
to a KindSectionDataList and passed to a KindSectionView.
Bug 24509375
Bug 23589603
Change-Id: I2fc603c3cea2fb7f10a96c8592688ccf3deef56a
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionDataList.java
|
| 655ad1a2eeb36171d5f6e407bf7704f56f5583ca |
06-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Show all merged accounts in Contact editor.
Show all merged rawContacts' accounts in Contact editor, not
just primary account.
Expand all accounts to a list.
Clicking each account (rawContact) will go to the full editor
to editor the rawContact.
BUG 24547289
Change-Id: I671a946f87b25d9393daccb600287e35826fa6eb
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorFragment.java
|
| 31a74ad969b650eb733e536569254ed3978c4f54 |
03-Oct-2015 |
Walter Jang <wjang@google.com> |
Compact editor photo picker 1/2 (E15)
* Added photo selection fragment
* Swap between editor and photo selection fragments in CompactEditorActivity
* Moved PhotoHandler (which receives callbacks from PhotoSourceDialogFragment)
from the editor fragment to CompactEditorActivity since sourcing a photo
happens now from the editor photo view and the action bar when in the
photo selection fragment is visible.
* Extract code to get a bitmap or full size photo from a ValuesDelta in
CompactEditorPhotoView and move it to EditorUtiUtils so that it can be used
on both the photo selection fragment and the photo view
Bug 19697372
Bug 23589603
Change-Id: Iecebca44f505527d0be7a3803cd1d8fd4fef65e0
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ompactPhotoSelectionFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ditorUiUtils.java
indSectionData.java
hotoSourceDialogFragment.java
|
| d675315606e8be431e6e5487e0b1cc33036a6ed7 |
02-Oct-2015 |
Walter Jang <wjang@google.com> |
Delay loading groups until compact editors are bound (E14)
Bug 24533689
Bug 23589603
Change-Id: I517b61d116f2d91237c493dc8a18f09aed9ad48a
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 2da5d2ff897741fed33b44f0f733f542aca7a3e4 |
30-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Restore birthday label after deleting an existing birthday
Once user removes a birthday editor, we update the editor at the bottom
to be "birthday".
Bug: 23959614
Change-Id: I650ac70f67e190a8e544d9010eda942694bec0fe
ompactKindSectionView.java
ventFieldEditorView.java
indSectionData.java
|
| f6ccd5094b6ed720e4f32ecf26d126e8ba3f4591 |
30-Sep-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Add suggestion card for quick contact (P2)" into ub-contactsdialer-a-dev
|
| e3a7c4f3215294b7699c2960ffe0128d3401745f |
25-Sep-2015 |
Tingting Wang <tingtingw@google.com> |
Add suggestion card for quick contact (P2)
Add a card for suggestion in quick contact, showing the
aggregation suggestions for the contact and supply merge option.
BUG 21071527
Change-Id: I7abe28c8a5fb3aac47607153f3d962271387713a
ggregationSuggestionEngine.java
|
| 7b2ec523a844b20ebec5ca0fa8ddfb92cc70cc0d |
29-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Rename phoneHasType/emailHasType
Rename phoneHasType/emailHasType to hasPhoneType/hasEmailType.
Bug:24506801
Change-Id: Ic5f01570681f97b79f124b0222b7c17e3b1d583f
awContactReadOnlyEditorView.java
|
| 1ee24ed873b91e1fe65dba2b122749fa1684e59d |
26-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't show read only names in an EditText (E13)
Bug 19110128
Bug 23589603
Change-Id: Icc958271fa5c213c98180b22d4c321dea128cb93
ompactKindSectionView.java
|
| 2ae2175d1835a945e9e3ad16a88825999ec10afd |
25-Sep-2015 |
Walter Jang <wjang@google.com> |
Put company editor field below other names (E12)
Screenshots: https://go/b22828525
Bug 22828525
Bug 23589603
Change-Id: I0ff3a18810a6cc18ac6903119b8272092b8fa411
ompactRawContactsEditorView.java
|
| 6d84a8dce6a0ce0e1aeb9dfaea8a584615fc3290 |
26-Sep-2015 |
Walter Jang <wjang@google.com> |
Merge "Update LabeledEditor text color when it becomes empty/non-empty (E11)" into ub-contactsdialer-a-dev
|
| 79658e14360a4ec75530a9dcae338f48c9d5f043 |
24-Sep-2015 |
Walter Jang <wjang@google.com> |
Remember editor expansion state on rotates (E10)
* Prompt user about discarding changes when back pressed
on editor (regressed in E5)
* Show a toast and close when no editors (i.e. input
fields) can be bound.
* Try to clarify the different behavior of
CompactSectionSectionView for names and groups.
Bug 23589603
Change-Id: If045ddb6d839574dc4109195b0d8841cd6083561
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
ditorIntents.java
roupMembershipView.java
indSectionData.java
|
| 23942c04851276160ba843ee80c9833f57a4cdcc |
25-Sep-2015 |
Walter Jang <wjang@google.com> |
Update LabeledEditor text color when it becomes empty/non-empty (E11)
Bug 23898909
Bug 23589603
Change-Id: I72cfd5b3ad3e072de14accc0ea938b2a12dada85
abeledEditorView.java
|
| 3daa9a34380f0368292f366c397c26f7e90db0df |
25-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Change ringtone behavior based on version.
Bug: 12800232
Change-Id: I9e05d737a847392c277d50a353e4d65ecd70f9a2
ontactEditorBaseFragment.java
ditorUiUtils.java
|
| f10ca15ffa550b36805d2330fc210b58601a215c |
23-Sep-2015 |
Walter Jang <wjang@google.com> |
Add group membership support to compact editor (E9)
Bug 23589603
Change-Id: I71082af35a35dc7d0658ffb671a4436f794f5b0c
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
|
| 192a01c63c836a7a6ac3e75d8cc14e764f34a42b |
23-Sep-2015 |
Walter Jang <wjang@google.com> |
Phonetic names must be displayed next to structured names (E7)
Also keep phonetic name and nickname fields together with the
structured name editor field for the same account.
Bug 23589603
Change-Id: I3298d91dcd0451576374eed2401a768bec84b8e8
ompactKindSectionView.java
ompactRawContactsEditorView.java
indSectionData.java
|
| 3e5ae0db65e842d49d047568fb5d6f331298da32 |
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Show all aggreagate contact names on the editor
Stop copying the name from read only contacts
to the new raw contact created in order to enable
editing of read only contacts. We also don't need to
match the name displayed by quick contacts.
In the new design, we are showing multiple names with
read-only accounts marked with the account type icon
and name.
Bug 23589603
Change-Id: Ifd8d18b17fc9645c15814bbb1a649a82fe246bbd
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
ditorUiUtils.java
indSectionData.java
tructuredNameEditorView.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
indSectionView.java
honeticNameEditorView.java
awContactEditorView.java
tructuredNameEditorView.java
|
| f5dfea4a5c94382a632eae5c538881f7da726a50 |
16-Sep-2015 |
Walter Jang <wjang@google.com> |
Add a multi account KindSectionView (E4)
* This allows us to treat all kinds (i.e. mime types) the
same (except for name and photo).
* We can also set the icons and add empty editors naturally
(w/o checking if the kind section is the last on in the list)
* Finally, we can also expand to the full editor in place now
Bug 23589603
Change-Id: Ibdecd8a9ef33cd1db70ffd9fd17e7883555d1fa4
ompactContactEditorFragment.java
ompactKindSectionView.java
ompactRawContactsEditorView.java
ditorUiUtils.java
indSectionView.java
extFieldsEditorView.java
|
| 363d3fd790e44b06969abbc21b5cf5ccf0e81d3f |
16-Sep-2015 |
Walter Jang <wjang@google.com> |
Only iterate through raw contact delta list once (E3)
* Also, don't treat emails and phone numbers differently
since we'll be adding a new KindSectionView for them.
* Introduced a multi account aware KindSectionData holder
object to be used by the new KindSectionView
* Moved the utility method to get the icon for each kind
from the exisitng KindSectionView to EditorUiUtils
Bug 23589603
Change-Id: I6b4858b093ce1b4a65c97b95febc61f2197db091
ompactRawContactsEditorView.java
indSectionData.java
|
| 03cea2e87a94d197eb63661fc82871aa33dd71ba |
19-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't change the default account when saving contacts (E2)
Also address some comments on ag/766424 that were given
after that CL was submitted.
Bug 23667287
Bug 23589603
Change-Id: If2a5aee5c17358278fd3b59ed56b4c5344e5ecf6
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| 708ea9e6f6f671178c0424f89e911000d4f330dc |
11-Sep-2015 |
Walter Jang <wjang@google.com> |
Add account selector to compact editor (E1)
But don't pass the account with dataset back and forth
between the compact and full editors since we will be
merging the two editors shortly.
Bug 23667287
Bug 23589603
Change-Id: I4cb6a79e6ee453cb171418b5ed317f43982dfac0
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 97a04fec29361033d49729b9ca436ff119692b93 |
18-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix IllegalStateException in onOptionsItemSelected" into ub-contactsdialer-a-dev
|
| ceb81f60667091ca9a637304b1a3874e24e5355b |
17-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Modified doPickRingtone() and onRingtonePicked() to handle silent ringtone" into ub-contactsdialer-a-dev
|
| c284bbb83c890b4c22c8028bab6540b140affaf9 |
17-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Fix IllegalStateException in onOptionsItemSelected
Check the fragment is still attached to a running activity.
Bug:24140802
Change-Id: I4dc283105c019589b47961baf49ad44cd60733c1
ontactEditorBaseFragment.java
|
| 5ed0e93814e4275362a009df1f12586bfc637cdd |
16-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Modified doPickRingtone() and onRingtonePicked() to handle silent ringtone
Bug: 12800232
Change-Id: Ic26b94b5c1b2597b20e822eaa5321f89af2a97b2
ontactEditorBaseFragment.java
|
| e11e06ac577902421996998780c41885bbc95644 |
16-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Use Long.compare to compare longs
Fix potential int overflow in comparator.
Bug:24117229
Change-Id: I8095e19ff9b853dcf3530e1cabd8dc9d8e326b0a
awContactDeltaComparator.java
|
| 8753906a4eb4223bfbdec77a5baac25b79b88434 |
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't show aggregation suggestion for new me contacts" into ub-contactsdialer-a-dev
|
| 82ed2b5380e134705f96e7e1f1586a25f8ac403f |
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't allow the me profile to be deleted
Bug 23353783
Change-Id: Ie4784ed0725497200129915d1cbb6bbb047fb278
ontactEditorBaseFragment.java
|
| 953cea238c9969fd7703fbce2bf8a915b5c38955 |
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't show aggregation suggestion for new me contacts
Bug 23353464
Change-Id: Ifb63c73b59153ff7bdc26b3f4f471d3521bed0b2
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
|
| defc69ce69b25daa4e3f41b7c7c6cbd1aa3e83ce |
26-Aug-2015 |
Walter Jang <wjang@google.com> |
Show proper label for phone only accounts
I broke the account label for phone only contacts
when I extracted the logic to set the account label
on the full editor to a utility method so that it
could also be used on the compact editor in ag/712716
Bug 22859536
Change-Id: I3e64f7f6834a1da83078cc783e04b3c2faa0702f
ompactRawContactsEditorView.java
ditorUiUtils.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 1bce8a9913b52474e07ebd57122b7b4cf1c1172b |
21-Aug-2015 |
Tingting Wang <tingtingw@google.com> |
Add setting for default account (2/2).
Modify Contact editor to get default account from "setting" part.
BUG 21932040
Change-Id: I063d19c5483b70a330a5f7c3f6533d01a154f866
ontactEditorUtils.java
|
| 03debc685e254b85df07fc9d213f17967a5fca9a |
20-Jul-2015 |
Walter Jang <wjang@google.com> |
Pass MaterialPalete colors to contact editor as ints not Parcelable
The MaterialPalette class is not public and crashes the edit contact
app selector if any third party app also has a filter for
android.intent.action.EDIT in their manifest.
Bug 22564102
Change-Id: I0926108bf83431e4c80412571062f7bc561c3de5
ompactPhotoEditorView.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| 2241783345a24acd27c52d938943b2ca76dc7329 |
09-Jul-2015 |
Walter Jang <wjang@google.com> |
Allow split of aggregate contact composed of >1 read-only contacts
Bug 22382957
Change-Id: I33f22a5ba9c55fe722601b54cecc59a173d6940b
ontactEditorBaseFragment.java
|
| 23a34d10b03e8a713a2b93980ff7f4c696aff93d |
08-Jul-2015 |
Walter Jang <wjang@google.com> |
Mark Editors as deleted when entire KindSectionViews are removed.
Regression was introduce by ag/721564
Bug 22345338
Change-Id: I21ef3e94cc20c8cc10f06084ce350b626710bbfc
ditor.java
indSectionView.java
abeledEditorView.java
hotoEditorView.java
|
| ae9c9ec49c460d34f7c649c3a3bf684fc5ef262d |
08-Jul-2015 |
Walter Jang <wjang@google.com> |
Hide all empty email and phone KindSectionViews expect the last
Bug 22331611
Change-Id: I5c4544ed3cc82982f159f7c1758a1e6cd8868c48
ompactRawContactsEditorView.java
indSectionView.java
|
| 995bb4af702a619bda3819daeeaa68c55d9e96bd |
06-Jul-2015 |
Walter Jang <wjang@google.com> |
Don't delete kind sections when there are >1 emails in the raw contact
* Also fix jank when deleting compact editor input fields
We were animating removal of input fields when there was more
than one field in the raw contact (i.e. Editor.deleteEditor)
but not when hiding entire KindViewSections
(i.e. KindSectionView.setVisibility(GONE)). When animating
KindSectionView removals, we must mark it for deletion
since we need to re-assess the number of KindSectionViews that
are visibile (in order to show icons) before the removal
animation finishes (the visibility is set to GONE at the end
of the animation).
* Prevent nicknames from being deleted
Bug 22228718
Bug 22299522
Change-Id: I28dad184c53e89f067d54675fcb3e7ebac9d971e
ompactRawContactsEditorView.java
indSectionView.java
|
| 19d985fd21c6a9652c1b642bb0b4e6903a26d2e6 |
01-Jul-2015 |
Walter Jang <wjang@google.com> |
Group non-phone and email fields together on compact editor
Bug 22228718
Change-Id: I561ee25bad95a716744ba7d74fb6b49463b029da
ompactRawContactsEditorView.java
indSectionView.java
|
| 4a9351db3c8385469bad037544d4b60d76504f5e |
30-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix showing all phone nums and emails for joined contacts
We must delete the entire KindSectionView for emails and
phone numbers for all but the last raw contact that is being
edited.
Also, icons must be updated whenever an editor housed in
a kindview is deleted since we only want to show the icon
once for all the kindviews added to the compact layout
for all the raw contacts in the delta list.
Bug 22203548
Change-Id: If12c4fc10a9c9c09cbcfb86c5bf1472d89f6b890
ompactRawContactsEditorView.java
indSectionView.java
awContactEditorView.java
|
| c7e0a98b5692eb97ffd42c343555e0b91a9d1313 |
26-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't rebuild labels when phone and emails field change
This was necessary when we using different hint colors
for groups of input fields but since that was removed
this should be safe to remove.
Bug 21662781
Change-Id: I7b9f48fed3d963cce251d6b09e705907c9cb224f
abeledEditorView.java
|
| c4cecc7e7534c7f5d887222d9e6f1a43364f7665 |
25-Jun-2015 |
Walter Jang <wjang@google.com> |
Show google account types on editor as "account" instead of "contact"
Also, missed the copy of the account type display lable setting
logic for read-only contacts in ag/712716 so replacing that with
the static utility method.
Bug 18719390
Bug 21637149
Change-Id: I112b32a25d4d3682ca8e58ef327660bd163cb273
ompactRawContactsEditorView.java
ditorUiUtils.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| 2655677440d8d8eb43a52c90504093112fe6782a |
23-Jun-2015 |
Walter Jang <wjang@google.com> |
Parsing compact editor profile photo file IDs as longs
This only appears to be affecting the ME profile photo
Bug 22010349
Change-Id: If1be0ec6b2491649ebd0d3daa95a47cb437447af
ompactPhotoEditorView.java
|
| 2d3f31c210ffc617e82e3b41fc32b54ec2a5011a |
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Show account info for inserts and read-only contact edits
Bug 21637149
Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
aseRawContactEditorView.java
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorUiUtils.java
awContactEditorView.java
|
| c90cc15b804fb00339a3b98e5c951549f9b03599 |
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Make saving a contact less confusing
* Add always visible save menu item (a checkmark icon) on both
the compact and full editors. Selecting it saves changes
and closes the editor (what back does currently).
* On the compact editor, make back perform a discard,
including warning the user if there are unsaved changes.
* On the full editor, back still saves and goes back to
the full editor. This is not ideal but it's out of
scope to not save changes between the two editors
when editing an existing contact.
Bug 19983789
Change-Id: Ie23b75978db70f2b438a824e39f0ae8fb8aa99ec
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| fa127a1c0ca95139664771edc3d5d97331c93b19 |
18-Jun-2015 |
Walter Jang <wjang@google.com> |
Allow users to edit photos for read-only contacts again
Similar to ag/711429 (for editing read-only names), we set the
photo bitmap from the read-only contact but set the newly created
(and writable) raw contact as the delta underlying the photo editor
view so that if the photo is updated by the user, the new raw
contact is set as changed and not the read-only raw contact.
Bug 21873945
Change-Id: Ibd40f3d708332fe6f87d247773b871d575d7d12e
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| 06f73a15ed812d99ea28d836b02a5538bb1200c9 |
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Ignore new raw contact display names when saving contacts
Now that we have logic to ignore the display name
we add to newly created raw contacts (when the
user wants to edit a read-only contact) when
determining whether the user made any edits,
we can enable changing the display on the compact
editor again.
Note, there is one glitch -- the name disappears
on the compact editor after you click more fields
(but only when editing read-only contacts).
Tested scenarios:
1) Edit read-only contact, more fields, back, back
No bogus contact is created and the read-only
name is displayed on both editors.
2) Edit read-only contact, change name on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the edited name is created.
3) Edit read-only contact, more fields, change name on
full editor, back, back, re-edit read-only contact,
and split
Same result as (2)
4) Edit read-only contact, add phone on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the read-only name and phone number is
created.
5) Edit read-only contact, more fields, add phone on full
editor, back, back, re-edit read-only contact, and split
Same result as (4)
Bug 21858251
Bug 21464081
Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 25f9694fcad5ce1856f5c214c4167dc58464ef4f |
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix detection of empty structured names
TextFieldEditorView.isEmpty does not do the right thing
for structured names because that methods just checks every
child of the fields ViewGroup and the view retains values
for fields that may have been erased by toggling the
name expansion. The result is that the FIELD_TURNED_EMPTY
EditorListener event is never fired.
Bug 21851290
Change-Id: Iaae3ba102a899de9dfd76d0469c9c2f1d094b0bd
tructuredNameEditorView.java
|
| 0299c1d4ff397d57dbc87d1bd453077cafbb36b7 |
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't allow read-only photos to be changed in compact editor" into mnc-dev
|
| ab50e6f5cf14e1bdb6cd3598372fefc2fa6b0b83 |
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow read-only photos to be changed in compact editor
Also don't display compact editor photos for non-editable contacts
Bug 21873945
Change-Id: I7523e9cc7f8342e546659ede6a3dd822d790a259
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| 65d3520d3cee5c3c4c4c213adf210d008c0a0409 |
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow read-only names to be changed in compact editor
Bug 21858251
Change-Id: I3a66d30123ae1a64acbd162f7991a56cf37bcc72
ompactRawContactsEditorView.java
|
| 398cd4b1fbfa7d2fabfc4addf6a156a841a5aa6a |
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred name ID into the contact editor
Bug 21870691
Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| c59de249035f7149afa39d020cd2a1b2f972ef68 |
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't set super primary name on compact editor unless it changes
Also fix the contact being loaded unnecessarily when transitioning
to the full editor.
Bug 21464081
Change-Id: Ic833f64a073898c8524892428512ce65f2f14625
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
|
| 4e1a8de3527343115669cf588b5ebf793350c257 |
12-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix bug causing a read-only default account to be set
Bug 21464081
Change-Id: I97653796b7abbab8df61060c03b0ff0222c1442c
ontactEditorBaseFragment.java
|
| 6dd0d4e8e49ccff2ed57453c0ddd0735d6ec7a40 |
09-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't initially focus any contact editor input field
Bug 21644158
Change-Id: I84d1406b4db1646dcbf059ce84a2cc7534b0bd83
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 88b0a8cc7c512c5f28dad958da276974c845355c |
08-Jun-2015 |
Walter Jang <wjang@google.com> |
Revert KindSectionView logic NOT show an empty input field
We don't need to make it optional to show an emtpy input
field since we've changed our minds on not allowing
users to add email and phone numbers on the compact editor.
Bug 21661221
Change-Id: Iec0d3a37a76c787d17922dbc184142dfca98a9de
ompactRawContactsEditorView.java
indSectionView.java
awContactEditorView.java
|
| ac679af994faece43536f1e8b2613f30c50300e1 |
01-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred photo ID into the contact editor
Bug 21498424
Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ditorIntents.java
|
| a35ef54b651d17536169bb0ba0423ca5ef2839b4 |
02-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow newly writable contact splits
It will result in an empty contact
Bug 21464081
Change-Id: I36e79b82ff7d8d3002eabfe735bccda75ee110a7
ontactEditorBaseFragment.java
|
| 83056011c9c529546e6a98817dee3be04423b3b9 |
02-Jun-2015 |
Walter Jang <wjang@google.com> |
Merge "Can add mulitple email and phones on compact editor again" into mnc-dev
|
| 3593f2379784e2d89dd6c2430f8c2b944483a1f8 |
27-May-2015 |
Walter Jang <wjang@google.com> |
Only use one hint color on contact editors
Also, use the current 25% of black color which
already follows the material guideline.
Screenshots go/b21442589
Bug 21442589
Change-Id: I82c837fd9856c2165d3264a581165eb32702d807
ontactEditorFragment.java
abeledEditorView.java
extFieldsEditorView.java
|
| 28c98b7511b4c00b47abcce83a713c9bccf1b74a |
02-Jun-2015 |
Walter Jang <wjang@google.com> |
Can add mulitple email and phones on compact editor again
Bug 21162602
Change-Id: If484b5f3a0de2d6176863c19519ed63a45aa7c1d
ompactRawContactsEditorView.java
|
| f2db7d5de84ab1d8c1ca851e2ce8eb4b58f1f834 |
27-May-2015 |
Walter Jang <wjang@google.com> |
Merge "Attach aggregation listener to super primary name field" into mnc-dev
|
| 24498d61b84caaf4205c2c87cd56d821a4770712 |
27-May-2015 |
Walter Jang <wjang@google.com> |
Merge "Distinguish between editor back button presses and framework stopage" into mnc-dev
|
| a26490b189312af2b73e56a1c9a7da974f7831c6 |
27-May-2015 |
Walter Jang <wjang@google.com> |
Attach aggregation listener to super primary name field
Bug 21435555
Change-Id: I03bb5ee5650491338192796cd8fc132af50a5ce8
ompactRawContactsEditorView.java
|
| 3e76408e47ca135c092b5eee73ae49d8697b0a10 |
22-May-2015 |
Walter Jang <wjang@google.com> |
Distinguish between editor back button presses and framework stopage
We carry whether the editor fragment is being stopped
because of a back button press or because the framework
stopped the hosting Activity all the way through the various
editor fragment callbacks and the ContactSaveService because
it is not until ContactEditorBaseActivity.onSaveFinished
where we start the next Intent -- starting it causes a
"flash" if recents is clicked and follwed by an immediate
starting of the next editor Activity, which is the bug
that was filed.
With this change, we only use the ContactSaveService
resultIntent to go back to the compact editor on back
presses. The expected behavior/tested scenarios are
described at go/b21198041
Bug 21198041
Bug 19624360
Change-Id: Ic350e12aa447cff81747e003f504f25100bd5c60
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 7bcdf5149804d766f3b3205143f78ac401fb38de |
27-May-2015 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when event type is unset
Bug:21443668
Change-Id: Ia0623a9cf9b379b882b661ab989195ba5ac91ac6
ventFieldEditorView.java
|
| 117082633dd4f358816a1daed08bdf9e5aaa8e3c |
27-May-2015 |
Walter Jang <wjang@google.com> |
Merge "Hide types when the associated (empty) edit text loses focus" into mnc-dev
|
| f5877e3eb34d3a2cf474a4087143eca9fd7c38ea |
26-May-2015 |
Walter Jang <wjang@google.com> |
Expanded name not passed to full editor for inserts
Bug 19624360
Change-Id: Ia1166655d12748129f1281b102c95c1583380d5c
tructuredNameEditorView.java
|
| f463e116e764ceb231df95b08d65f9a48a44d458 |
21-May-2015 |
Walter Jang <wjang@google.com> |
Hide types when the associated (empty) edit text loses focus
Bug 20299183
Change-Id: If6b4fa10957b52a84c0f8a77c8eeebaa220f42db
ditorAnimator.java
abeledEditorView.java
extFieldsEditorView.java
|
| 3bb7a0f2a8ec3aed48ba740810997b3f8ad1a260 |
21-May-2015 |
Walter Jang <wjang@google.com> |
1/2 Allow the keyboard to resize the compact editor layout
So we're reverting the fix submitted in ag/680795 and
preventing the landscape layout from getting messed up
by basing the photo resizing off of the display dimensions.
The reason is that adjustResize provides a better UX and
is necessary to fix the bugs related to showing and hiding
the type downdowns propertly.
Bug 20526470
Change-Id: Ia6755336cb8d1fa78142b754e5d40a45b4c50d44
ompactPhotoEditorView.java
|
| 9c28ccdec3d3371d1bcfb72323c7af66e64c06c8 |
20-May-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Remove compact PhotoActionPopup's "Remove Photo"" into mnc-dev
|
| b0afa207a16d22f5d220dd2b18db756a0d159e09 |
15-May-2015 |
Brian Attwell <brianattwell@google.com> |
Remove compact PhotoActionPopup's "Remove Photo"
The "Remove Photo" option was causing problems. I was able to do the
following:
1) Remove a photo from a read only raw contact
2) Remove a single photo from a contact with multiple photos. This
removes the current photo and arbitrarily picks another photo
to be the current photo
Killing the "Remove Photo" option removes these problems and was
suggested by UX a couple months ago.
Bug: 19697372
Change-Id: I266b4bf671216f6c1a57e3954a0387a01c0c9574
ompactContactEditorFragment.java
hotoActionPopup.java
|
| bf63a6d6a888b3e1b5fb91accf2dadaab4384539 |
05-May-2015 |
Walter Jang <wjang@google.com> |
Fix contact name passing from compact to full editor on inserts
Bug 19624360
Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
honeticNameEditorView.java
|
| 882128af0b342f13b03f78491225a89c45822699 |
13-May-2015 |
Jay Shrauner <shrauner@google.com> |
Fix NPE in onRestoreInstanceState
Bug:21117470
Change-Id: Id14fe8382bd29b4843d8dfb75edac2c2d754151c
extFieldsEditorView.java
|
| ac48ce4de74370237e8d6e862cf5e3b26aa8f763 |
28-Apr-2015 |
Walter Jang <wjang@google.com> |
Create a new temp file after contact photo is updated
So that subsequent photo selections (either take new photo
or choose new photo) add a new uri/bitmap pair to the cache.
In the full contact editor this happens when we bindEditors
is called after a photo is selected -- which leads to all
PhotoHandlers being recreated.
Bug 20562525
Change-Id: Id928dde5319928f72a1f9c1e038cf93e941824af
ompactContactEditorFragment.java
|
| a69f58fcf5c143ac7dd6421a30004d56813e321a |
02-Apr-2015 |
Walter Jang <wjang@google.com> |
Don't add compact editor fragment if it's already there
Bug 20040887
Change-Id: Ib968203e0340cd442e5652376a9e2aa7347994b1
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 1a74b7f6991e20ef3cb159c61366a0e5ca01807d |
23-Mar-2015 |
Jay Shrauner <shrauner@google.com> |
Merge "Check for empty contact lookup keys"
|
| 52913d367d53b2d1a7416ee2ff3072f67993890e |
20-Mar-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't parse extras twice when inserting contacts"
|
| 18f2e2ff824f1af19c7f7f6de7b5fa2eb2fb562e |
19-Mar-2015 |
Walter Jang <wjang@google.com> |
Don't parse extras twice when inserting contacts
This is causing phone number (and other insert data
besides name) to be rendered twice when inserting a new
contact.
Bug 19849999
Change-Id: I8d211658a2b568eba2379795ecfbaf93639bbd3f
ontactEditorBaseFragment.java
|
| 4a268d3dc9eb0fa067b1e408199ec7c969f34a25 |
17-Mar-2015 |
Walter Jang <wjang@google.com> |
Add gradient behind photo icon is contact photo is set
Bug 19732687
Change-Id: Iad82b23aedf25e3e9a9ced8d2cd30190b69240de
ompactPhotoEditorView.java
|
| ff16eea0e4d18cf2964667ce8e597780797e2b69 |
16-Mar-2015 |
Walter Jang <wjang@google.com> |
Move contact photo edit icon from ActionBar to lower right corner
Screenshots https://docs.google.com/drawings/d/1mekRSq4i3Y810Ow2tbNBDKBWl1NGmR4GLR7vlocZOxI/edit
Bug 19732687
Change-Id: I68f969eed59d925d9afd6d5c8e33ec80cbff5cfd
ompactContactEditorFragment.java
ompactPhotoEditorView.java
|
| 9d8f37e77052543c4ae07cbf8329e4ff0ddef66b |
16-Mar-2015 |
Walter Jang <wjang@google.com> |
Change compact contact edtior photo aspect ratio
To less severe 360:184/width:height
Change-Id: I72e65bd921f271cc74b8b13b27b3b99932f1beb4
Screenshots: https://docs.google.com/drawings/d/1rHxAfZg46OKhit0ccAZkxnS4QipiG_1wKZIUIcQeLyM/edit
ompactPhotoEditorView.java
|
| 261e106d87056d0c9727dd9ae436d5aadadd0762 |
13-Mar-2015 |
Walter Jang <wjang@google.com> |
Compact contact editor UI tweaks
* Move delete ActionBar icon option back into the overflow
* Move the "More fields" option back to left alignment and
give it accent color
* Make unfocused fields 25% black
* Layout/padding tweaks
- Remove the 0 bottom padding on names so that all fields
have the same spacing between each other
- Use the min edit height on the "More fields" row
so that the spacing is the same as the other fields.
Bug 19729447
Change-Id: Ia11c74c1b65f96f937d6e51ed143f5f088b41561
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ontactEditorBaseFragment.java
honeticNameEditorView.java
tructuredNameEditorView.java
|
| e320c0bcd539f9426db9b694147e845fe0e2d59d |
05-Mar-2015 |
Jay Shrauner <shrauner@google.com> |
Check for empty contact lookup keys
Bug:19588470
Change-Id: I1b0b262483a316a0a84a051e2a4225c68523e47e
ggregationSuggestionView.java
|
| ebfe75beec08f30b89de7e7251f4106a680f9ab3 |
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Update contact photo edit options after photo is changed
Change-Id: I6cb9c432e7c98a4efc4c0c1c26efb8b1971acd15
ompactContactEditorFragment.java
|
| 1573aa697284e6627c7bb74eae4c350f56780c33 |
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Re-apply tint after removing photo from compact contact editor
Change-Id: I288f5ce77c0061bb7cde38edbdfb9ac6462b3b15
ompactPhotoEditorView.java
|
| 055c66d459732973f7341331b143d7ab9974c4ed |
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixed some contact editor compiler warnings
Change-Id: I31deaeeedc4ae49da6b0326b128767785cd01852
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
indSectionView.java
hotoEditorView.java
tructuredNameEditorView.java
|
| ee4d4ae4012ef3e18e18c8e66b34797e8523f860 |
12-Mar-2015 |
Walter Jang <wjang@google.com> |
No toast when navigating back to the compact editor for existing contacts
Bug 19624360
Change-Id: Ic1b344583a453e482acb2c2911ae05eee077fb43
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
|
| 1e8801bc9bc60bdd1c95f582c460590272cfad64 |
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Pass full res contact photos between the compact and full editors
Bug 19624360
Bug 19655206
Change-Id: I590ec7ecec75a9af95b824f5db9cda8f8aeda675
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
|
| 921287ef72ca601027bf2971b0733493adde16d2 |
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixes for returning to the compact editor from the expanded one
* Don't abort the save even if there are no unsaved changed
when returning the compact from the full editor
* No need to pass the material palette on insert intents.
It does, however, need to be passed back to the compact
editor when editing an existing contact w/o a picture.
* Fix returning to the compact editor repeatedly by
removing the Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET
on compact editor intents.
* Updated StructuredNameEditorView#getDisplayName to fall
back to the display name directly from the ValuesDelta.
This is required when the name is passed to the
contact editor, and the user does not change it, in which
case it will not be written to the underlying data
structure, and thus not passed subsequent expantions.
Bug 19624360
Change-Id: Ife285f3e411a869a76fbbff4d42939c866db617c
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
tructuredNameEditorView.java
|
| a20bb7f936e902fdec2f8f0534fe058878b11a6c |
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Merge "Update compact editor photo to full res when possible"
|
| 41b3ea1c712f01164feb55455f1391564cb76dee |
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Update compact editor photo to full res when possible
Bug 19655206
Change-Id: If30c7ba83851dcc7c98fa1be4bed92e302ba8245
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| 9f9d78e41f336b77012437c8622eafeaad4b2adc |
09-Mar-2015 |
Walter Jang <wjang@google.com> |
Hide types on contact editors until associated field focused/clicked
Bug 19624274
Change-Id: I8add22fa23e395507fce60f177f4cf48bcc29191
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
extFieldsEditorView.java
|
| 5a7a23bdb698b8e741a425c9617c5e33e6314cdd |
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Return to the compact contact editor on back from the fully expanded one
Bug 19624360
Change-Id: I249f1e456a2d85c5ecd831358692d56b09ee5a5b
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
ditorIntents.java
|
| b810373530d919d89c75c86709b2bf0a3d8823aa |
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Contact editor "discard changes" should do a discard
Not a split contact!
Change-Id: I4e4edbedc73c99ef4ee1e15e8984b7cfa8f8ba37
ontactEditorBaseFragment.java
|
| 3b21027019af908d9bbbc66785172541fae764e1 |
04-Mar-2015 |
Walter Jang <wjang@google.com> |
Update compact editor photo selection logic
* Look for non-empty super primary
* Look for any non-empty photo
* Use empty super primary (or the fallback ValuesDelta)
Bug 19124091
Change-Id: I2e397600802598d8ef820b0beb9cf85538c6b7a1
ompactRawContactsEditorView.java
|
| 3eafe8fabb1d00f511bf5985ba7c6008fe1cc435 |
05-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Layout mExpansionViewContainer when not displayed"
|
| 93f22ec7bf10df0d0a785d56e07d78b60a449975 |
04-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Layout mExpansionViewContainer when not displayed
Force mExpansionViewContainer to always be laid out. This will ensure
that the whitespace on the end of mExpansionViewContainer is correct
regardless of whether an expansion view is needed or not.
This fixes the way phonetic name is displayed on exchange contacts.
This has no affect on focus contacts since both expansion views
are set to View.VISIBLE for focus contacts.
Bug: 19503535
Change-Id: I28aad309158a21a07d38a9699f82b48d72b8e7c4
extFieldsEditorView.java
|
| 3a37a1a441dcc02ad93b8ccce15dda9f70caf5e8 |
04-Mar-2015 |
Walter Jang <wjang@google.com> |
Only show 1 phonetic name (per RawContactDelta) on compact editor
Also remove the delete button on the phonetic name
to be consitent with the fully expanded editor.
Bug 19124091
Change-Id: I851943a55d81723af7ec556f4dfef6de4f3d9b5d
ompactRawContactsEditorView.java
|
| e95ce440a7dd7277fbc4eb78c3d74b85fd55af2f |
04-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Batch join contacts"
|
| d3946cae17273ed1c2fceb507990882e3f828ba9 |
03-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Batch join contacts
* Add new action to ContactSaveService to support joining more than
two contacts toghether.
* Add new dialog fragment for the join
Bug: 19549465
Change-Id: Ib0b1d5e7652e429f8e78d81dd3d98d03b3129e1e
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| f638b6f61faf9317a911a042057a33e3d9d67bef |
03-Mar-2015 |
Walter Jang <wjang@google.com> |
Supress "saved" Toasts when expanding the compact editor
Bug 19124091
Change-Id: I38a329be3f997ae93ec90810d24473f5ef800488
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
|
| c8dea5679faa5c948bee7260430b256104c74006 |
03-Mar-2015 |
Walter Jang <wjang@google.com> |
Check if optional name fields are shown when expanding to full editor
Bug 19124091
Change-Id: Ib01df1b0dd222f1c21764ba3760f1f3b765bed32
tructuredNameEditorView.java
|
| 151f3e6883e5785019f7b5083dc8baf3e305dc18 |
27-Feb-2015 |
Walter Jang <wjang@google.com> |
Try to show the "right" name on the compact contact editor
* If a super primary is set use it on the compact editor
* If a super primary is not set and the compact editor
name value is changed, set it as super primary. But
don't make an unchanged name super primary when expanding
to the full editor. Also unset super primary if
the name field becomes blank.
* On the full editor, set the last changed name to super
primary. Also unset super primary if
the name field becomes blank.
Bug 19124091
Change-Id: I1352f25f4decf31c5aeda20dbef133ce48d5d248
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorFragment.java
|
| 36d6a163bc31f76490d3bc0867a56437711bd1f7 |
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Start the fully expanded editor when "More fields" is clicked
Note, StructuredName must be handled specially on inserts when it is
passed to the fully expanded editor when creating a new contact
because normally the contact name is not overriden.
Bug 19124091
Change-Id: I1d2b383c50b42a3624a7a8c18dd3278d7c3b069d
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
tructuredNameEditorView.java
|
| d35e5eff8737e757a4179d49dfe9c7db999b4e9d |
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Get join suggestions for the compact editor name field
Also fix photo height in portrait -- made a mistake in
ag/641233.
Bug 19124091
Change-Id: I988cbcf457002bc6f0996c87a8611fca82bdf78a
ompactContactEditorFragment.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
oinSuggestedContactDialogFragment.java
abeledEditorView.java
uggestionEditConfirmationDialogFragment.java
|
| a5e4bb287ea08f895c84d5de56fcc2483386b306 |
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Use a split screen for the compact contact editor in landscape
Also renamed the compact header since we're not doing the
toolbar over the photo right now.
Bug 19124091
Change-Id: I91032e149252d635d564064a3652df4cc0233c6c
ompactHeaderView.java
ompactPhotoEditorView.java
ompactRawContactsEditorView.java
|
| 83d09b68e139f830956b448a0b7ad395de7d2f2a |
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Use default primary color when creating new contacts
Missed this case in ag/639263
Bug 19124091
Change-Id: I33ea9a5d21d65f23fa3c5b5e5405edf92714a00d
ompactHeaderView.java
|
| 0e72ce9d97e0133a5f7cc348eef363bef9395979 |
23-Feb-2015 |
Walter Jang <wjang@google.com> |
Show edit contact photo options is a dialog
* Instead of a ListPopupWindow. This is more consistent with
the behavior of the other edit contact menu options.
* Also add an option menu icon to change the photo to
make this feature more easily accessible and since
users may not realize they can click the photo to
launch the choices dialog.
Bug 19124091
Change-Id: Ia4c37b3093f39d55784323f9a6d7bcf49ee96d16
ompactContactEditorFragment.java
ompactHeaderView.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
hotoActionPopup.java
hotoSourceDialogFragment.java
|
| f46abd89a3386cbdadff99e96df826bb27f987e9 |
21-Feb-2015 |
Walter Jang <wjang@google.com> |
Apply the quick contact color to default photos in the compact editor
Bug 19124091
Change-Id: I375fc8c88ab7b1bd452fbeab0e3e6444b83be094
ompactContactEditorFragment.java
ompactHeaderView.java
ompactRawContactsEditorView.java
|
| 32d5224bc27068f34caed078baf6644810837a94 |
21-Feb-2015 |
Walter Jang <wjang@google.com> |
Merge "Hide extra empty kind editor on compact contact editor"
|
| d94574a91d3f725c96530c0d1e71d8188a9cbcf6 |
21-Feb-2015 |
Walter Jang <wjang@google.com> |
Merge "First pass on photo support for compact contact editor"
|
| 1044645b9c2050436f4f0e0c7e5b8da2931879ba |
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Hide extra empty kind editor on compact contact editor
* Also left align "More fields"
* Only show one structured name
* Be a bit smarter about the profile photo before
we have a real split screen
Bug 19124091
Change-Id: I046ea59437b035d43df045363677a3aaba0dca43
ompactHeaderView.java
ompactRawContactsEditorView.java
indSectionView.java
awContactEditorView.java
|
| 5a268c093580a9d53f310d34e30cdd712f341afa |
21-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Avoid senseless disambiguation #2/2"
|
| 3efae4aeae8715fbfcf67c56f123da49330ea01a |
18-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on photo support for compact contact editor
Only updates the primary photo for now.
Bug 19124091
Change-Id: I1886888b4cf249da4c483d570b9db6e05564518a
ompactContactEditorFragment.java
ompactHeaderView.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| b6ca272f26b47ecef8fafe94326c4d553576c521 |
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Add placeholder button for showing fully expanded contact editor
Bug 19124091
Change-Id: I8051b8df460fd0bbc30466d736c7606caaa0837c
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
|
| c6100ffd22ae176a3e84a1062d8cb92d955faef2 |
20-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Avoid senseless disambiguation #2/2
This makes having two contacts apps on the same
device tolerable.
Bug: 18777272
Change-Id: Ib75eadfb94eee2c5c8305747eddd01ba9a8b1dc4
ontactEditorBaseFragment.java
|
| e720fdeb3ef0892834d7ab9af8cc44dd9eb9be17 |
17-Feb-2015 |
Walter Jang <wjang@google.com> |
Always show email and phone fields
* This fixes showing an almost blank screen when
writing the "me" profile also when adding a new contact.
* Also fixed a bug when writing the "me" profile --
we weren't calling the RawContact.setAccountToLocal
in createNewRawContactDelta in the base editor fragment.
Bug 19124091
Change-Id: I93422047796189b4df060bfa39aa3c84ce47fa25
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
indSectionView.java
|
| b1c8762a9a398617d54c5c669359e283689e24a0 |
14-Feb-2015 |
Walter Jang <wjang@google.com> |
Fix up names on the compact contact editor
* Don't show a blank structured name if there is a non-empty
value and don't ever show more than one blank structured
name either
* Group phonetic and nicknames together instead of interleaving
with structured names and each other
* Use a KindSectionView for nicknames (for now) so that it
isn't intended so differently from everything else.
Bug 19124091
Change-Id: I50f41c0a0efb39de98a5b96c7da47b6ad6243633
ompactRawContactsEditorView.java
|
| 49ed2033f83005f92c30068ae33c3138d75e1825 |
12-Feb-2015 |
Walter Jang <wjang@google.com> |
Wire up saving edits using the compact contact editor
Also fix refreshing the edit activity data after joining
Bug 19124091
Change-Id: I161e38d9eaea89e3d090986d2b52cb6f8ee85422
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| cab3dcec1401a32aff583d946b4a9f8af954358f |
10-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on showing only non-empty field on compact edit view
Bug 19124091
Change-Id: I49660c326f5829540463295218530f0a2d0fad9d
ompactContactEditorFragment.java
ompactRawContactsEditorView.java
|
| 2d6ccf7bd5205a2c200def3501df5ddb3ca6c1c9 |
12-Feb-2015 |
Walter Jang <wjang@google.com> |
Add back discard changes dialog listener
Bug 19343391
Change-Id: I043947150800ff8f4fb7d219b39fd9f687ec2689
ontactEditorBaseFragment.java
|
| 92f8ccc1f15df787b7434224857c056721281046 |
06-Feb-2015 |
Walter Jang <wjang@google.com> |
Do setIntentExtras, on[Save|Join]Completed in base contact edit fragment
Do setGroupMetaData in the child classes since the layout will be
drastically different between the two.
Also moved a public Intent extra constant to the base.
Bug 19124091
Change-Id: Idd20ff39b91eb3584c69e406f1e3472bcb278f42
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 3e9a62449b8ca3a38b1d51019c6ea13972263bc2 |
05-Feb-2015 |
Walter Jang <wjang@google.com> |
Move suggest joins popup & activiy to BaseEditContactFragment
Bug 19124091
Change-Id: Ic5a6b8b6359dc9691cfcac2348ba895c542d05d9
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
oinSuggestedContactDialogFragment.java
uggestionEditConfirmationDialogFragment.java
|
| 1eb21f12372b31794ef5a567013c1d2d98081120 |
04-Feb-2015 |
Walter Jang <wjang@google.com> |
Move join suggestion view to base contact edit fragment
So that we can keep setEnabled logic entirely within
the base fragment.
The rest of the join suggestion functionality will be
ported to the base so it can be shared with the compact
editor in a seperate CL.
Bug 19124091
Change-Id: I4d494c9b0c2db8a6dba6d9d752d049f48848f731
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| b55107303cc46906c265582a8931172f13d684b6 |
03-Feb-2015 |
Walter Jang <wjang@google.com> |
Handle reading loaded Contact data in the base edit fragment
This reduces the number of abstract methods sub classes
must implement and also keeps us from having to duplicate
the logic to set up the new/local/me/existing RawContactData
List (mState) in all sub edit fragments.
The crux of this CL is moving the "bindEditor" methods
into the base fragment.
Also renamed the various bindEditors methods which are
mostly reading fields the loaded Contact and settting up
mState to be "setState" since we it seemed more appropriate
to reserve the name bindEditors for setting up the actual
Views.
Bug 19124091
Change-Id: Ieb4a906ac372faa20694e546caa3bcba8c6b53b4
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 505fd3ba4bfaeaa23b951736b210911e970ae775 |
03-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Don't use hidden QuickContact APIs"
|
| eda5c85e54ca3de71a9155df5f45fbf6911cb4a6 |
03-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Don't use hidden QuickContact APIs
Bug: 18777272
Change-Id: Ia3a1fe77223dfd67ff5c9d9c011253dbb7695b6a
ontactEditorBaseFragment.java
|
| 68ebd0db979f8c294d84ec639b9ae2bb34cbc2e2 |
02-Feb-2015 |
Walter Jang <wjang@google.com> |
Merge "Add edit contact menu options to compact editor"
|
| ed8f6c9744dd38e089598acfba6fb90446954e6e |
31-Jan-2015 |
Walter Jang <wjang@google.com> |
Add edit contact menu options to compact editor
* Also moved #setListener and #load from the sub contact editor
fragments to the base fragment
* Moved location of #setData in the base contact editor fragment
Bug 19124091
Change-Id: Icbe3d46e1bf60f3e79437db7bc6c05a7a95f824b
ancelEditDialogFragment.java
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
plitContactConfirmationDialogFragment.java
|
| eb8e961d523af144d457266a6228922cd6659ba4 |
02-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Don't use hidden AggregationSuggestions.builder"
|
| 532df59787a7b0b41aa3177dc1e2a073f2b8c3c3 |
02-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Don't use hidden AggregationSuggestions.builder
Bug: 18777272
Change-Id: I5f2bce6ccffdd17e783708ccc2d9b3b58926145a
ggregationSuggestionEngine.java
|
| ba59deb669cf377bedf08af53c9196db3c1cc404 |
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Move data loading and account creation to edit contact base class
While moving things from ContactEditorFragment to ContactEditorBaseFragment:
* The data loader callbacks, #onActivityCreated, #setData, and account
creation methods were not changed in any way
* For the restoration of contact editor state, one small change was made.
A new key, KEY_AUTO_ADD_TO_DEFAULT_GROUP, was added because the other
options passed in via intentExtras argument to #load are saved
so this looks like an oversight in the existing version.
Bug 19124091
Change-Id: I7973f9c5703082f6d8db53c9db22d08a230c5876
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| cf718aa47c11453925bb20f7970ca7c897f6e376 |
30-Jan-2015 |
Walter Jang <wjang@google.com> |
Re-order contact edit KEYS and state save/restore to match member order
This will make subsequent CLs which will move these to base classes
easier to read.
No KEYS or save/restore's were removed or added, except
KEY_SHOW_JOIN_SUGGESTIONS was renamed to more closely match the member that
it is backing.
Bug 19124091
Change-Id: I3557cffa37ee29fc5cd460a8e7358142c383967a
ontactEditorFragment.java
|
| 3f990ba4e35a99078d831c041290e574a320caa5 |
27-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
This reverts commit 02375f1e45ade453c56810f32d63dfe8eebe4f44.
Change-Id: Ib0129d9ba4e4351677b6979c5f720df2094bf48d
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| fb5dc6f857104c38ff49993d7498e8aa5fbc462e |
28-Jan-2015 |
Walter Jang <wjang@google.com> |
Reorder edit contact fragment members
Before (re) moving editor functionality into base classes
Bug 19124091
Change-Id: I8185b54f546f7e88893afbdeb4ff55cff3335711
ontactEditorFragment.java
|
| 92101e77238e450dedb56814cec80edc0adf79c0 |
28-Jan-2015 |
Walter Jang <wjang@google.com> |
Split EntityDeltaComparator out of contact editor fragment
Bug 19124091
Change-Id: I01ccf06bd2527ea5054843b30c100b2c7cc4a7f4
ontactEditorFragment.java
awContactDeltaComparator.java
|
| 4a1c574cd62eb7ca1e0fcc3a61e5378e5e0787fe |
27-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
Add Insert.EXTRA_{ACCOUNT,DATA_SET} to API. P #2/2
Bug: 18777272
Change-Id: I17a5b7cb4d4c5a0ba48936a6fc829acaab73f31d
ontactEditorFragment.java
|
| 02375f1e45ade453c56810f32d63dfe8eebe4f44 |
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Revert "Move some contact editor functionality into new base classes"
This reverts commit 5d1c571dbe5b4a60aec6cb81d69e9e595813268e.
Change-Id: Ia9df02198b460529c157fbee6012349b0eca0bf3
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| 5d1c571dbe5b4a60aec6cb81d69e9e595813268e |
22-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
Bug 19124091
Change-Id: I5dd0b64580026a72757025915ee59be0b7d1dcbc
ompactContactEditorFragment.java
ontactEditorBaseFragment.java
ontactEditorFragment.java
|
| bd2db2d4a756d9ca02a945f6dcf720f6bf983e0a |
22-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
AggregationSuggestions.Builder Part 2/3
Now that AggregationSuggestions.Builder is partially unhidden,
use the parts that are unhidden.
Bug: 18777272
Change-Id: I5c4066d1e933cc4ab18df06809687ee2b7eac91c
ggregationSuggestionEngine.java
|
| 67e83223e954ed54898daa5e32400dbff6d3831a |
09-Jan-2015 |
Jay Shrauner <shrauner@google.com> |
Local account handling cleanup
Clean up null account handling and update local account detection to allow
for a non-null account to represent a local account.
Bug: 18959158
Change-Id: I0d5f7acb7d9a8d1ba7b6d3a4e0b6584e3646934a
ontactEditorFragment.java
ontactEditorUtils.java
|
| c3d202ccbaf93ddd8291672027e59f549c32eee3 |
09-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
Unbundle from contacts contract part 3/3
* Remove some tests
* Move ContactsContract.Intents.UI into Contacts
* Remove references to ContactsContract.ProviderStatus.DATA1
and refactor to avoid usage of a new useless data object
Discussion: go/contacts-contact-intent-ui
Bug: 18777272
Change-Id: I9c6125cc30710e4637b38f3785608abb9928d1a2
ontactEditorFragment.java
|
| 0dd0b7de69f11c333f6ba2c2fe9c9d6eec15930e |
19-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
am 47612e5f: am 8c92be0f: am d462d3a9: Scroll to top of raw_contact on expansion
* commit '47612e5f4b04dcf5f1b27654f93aa4247094453a':
Scroll to top of raw_contact on expansion
|
| d462d3a9e9fe1ce0ff9562345a4292d45ffea46b |
17-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Scroll to top of raw_contact on expansion
User feedback: when expanding a raw_contact section in the editor,
if it doesn't scroll onto screen, then the expanded section looks
like it is empty.
Therefore, we adjust the ScrollView's scrollY upon expanding
raw_contact editors. We also do some work to make sure that
focus makes sense after expanding/collapsing.
Bug: 18004959
Change-Id: Ib20c4d971d655650eea9e378e2ffde8876e5875c
aseRawContactEditorView.java
ditorAnimator.java
|
| f140227beb6d9e78955a7676dc0dd3f793f72017 |
17-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Don't directly reference hidden View fields
Remove references to hidden view properties and fields
where 100% analogous unhidden equivalents exist.
* isLayoutRtl()
* mContext
Bug: 18777272
Change-Id: I1cc69fd846893087787f5cf340bf2a0ee6571f42
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
extFieldsEditorView.java
|
| 099046cfb5ede3a56cff494796e79d194bf81da6 |
12-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Support editable 3p accounts without nicknames
Fix a theoretical crash case.
We shouldn't assume the nickname field always exists.
All standard writable accounts have nickname fields.
But, it is possible to create an 3p account type with
an xml edit specification that omits the nickname
(I don't know if anyone does this).
Bug: 18004959
Change-Id: I9770e88891e5800ef56d2df8a0ddb8463e3e8815
awContactEditorView.java
|
| 7c8012090926070dc6bde1691341a2969996518c |
11-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
bugfix: don't show name in nickname field
Bug: 18004959
Change-Id: Ic0ba640cf83bd614c77d30bed3b02f08347b237d
awContactEditorView.java
|
| d9bf3c2ddd46dbd2a3a45b2a171c2af55fe4c8e0 |
05-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Change text colors to reflect their state" into lmp-mr1-dev
|
| d690dff231dd5a81b9bd7563838455f24e49c75c |
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Change text colors to reflect their state
The editor's text color suffered from two conflicting
problems
1) It didn't all pass GAR
2) The difference between hint text and regular text
is too subtle to differentiate at a glance
Changes
1) Once a LabeledEditorView is non-empty, the text color of
the spinner should no longer be the hint text color
2) Once an editor field is focused, all fields in the same
EditKindSection get a slightly darker color. Since the various
name editors, don't actually belong to a EditKindSection
extra work needed to be done for them.
3) Drop down lists use non hint colors
Read only editor continues to use the darker hint color.
There is no need to strongly distinquish hint colors from
non hint colors in the read only editor.
Bug: 18004959
Change-Id: Ia6b16ab882b2fcb9113c2ac880e741f62115a1f9
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 6b447ced28913da9f1961d678d957b348dc97fd7 |
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Don't save contact after deleting it" into lmp-mr1-dev
|
| afb025cfbcc1b6db48c6045a27387ce45e652a3a |
02-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "In editor, use Up button instead of Save button" into lmp-mr1-dev
|
| 99c0c8519483dd187fa0dd21cb83065966253b7f |
01-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Collapse extra raw contact editors" into lmp-mr1-dev
|
| 47b17c83b981172bda672314385eb8920753ba25 |
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Use delete icon from go/icons
Bug: 18004959
Change-Id: Ia8a5fe6006f6caf313a0f2eb044a94535c43878c
ontactEditorFragment.java
|
| 2b24602f1b6661a669762cfc810cc76f51db6e16 |
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
In editor, use Up button instead of Save button
We can't yet delete the assets from editor_custom_action_bar
since they are used inside the group editor. And we aren't 100%
certain we want to delete all the groups.
Bug: 18004959
Change-Id: Id60515d2e5bbaab98498162707581730baca2d8b
ontactEditorFragment.java
|
| daa2058979fda84a0ce22e21edd53aa049e80aa0 |
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Collapse extra raw contact editors
There are now two different header styles
1) When creating a new raw contact: if there are multiple
accounts to create the raw contact under, then show a
header with an acconut selector
2) Otherwise, show a visually distinct account header without
a drop down account selector. If there are multiple raw
contacts, this header also lets you collapse raw contacts
Typical users, who only have a single writeable account, will
never see header (1). This is fortunate, since switching between
the two header styles is a bit visually inconsistent.
Bug: 18004959
Change-Id: I133a7355a220f20b55657a6c1a51ff44665ea3b9
aseRawContactEditorView.java
ontactEditorFragment.java
ditorAnimator.java
awContactEditorView.java
awContactReadOnlyEditorView.java
|
| b4154e46dd98bcb4d85eb6fb210a048c8a7ff7aa |
25-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Don't save contact after deleting it
Bug: 18514447
Change-Id: I695aa41eb6870b7c256efb9f5eccf9e0eadefe4f
ontactEditorFragment.java
|
| 8c8cafb21cebbea33468c068efacea6c77635811 |
13-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Improve content descriptions a bit
* Don't apply content descriptions to empty images
* Content descriptions for mimetype images consistently
omit the word "section". Ie, "email" instead of "email section".
Bug: 18004959
Change-Id: I9d74b78dda7f071a0e7bdefe38eda3ad4b136fd2
indSectionView.java
|
| da71919dcd16754cb378fc664967f4b278431c70 |
12-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Material design readonly editor
The readonly edit screen is a strange beast. At most, it
only shows fields for phones, emails, photos and
names even if more data is available. This CL updates
the appearance of these fields.
Bug: 18004959
Change-Id: I25847483cef36bb4c98f4b169970344b90e63add
hotoEditorView.java
awContactReadOnlyEditorView.java
|
| 7e67082d3f7c4ab56945040c0e4617b71c7e5f0b |
08-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
New design for photo editor
The photo editor field now looks like the mocks. It includes
a RadioButton that allows users to choose which photo is
primary. This RadioButton only appears if more than one raw
contact has a photo inside the contact.
Additional changes:
-fixed non-regression that made it impossible to
set some photos as primary
-fixed non-regression that made it possible for multiple
photos to appear as primary
-I fudged with a bunch of padding values in order to
compensate for View insets and paddings. This can't always
be done perfectly, since some insets/paddings vary based
on screen-configuration. I needed to start taking fudging
with these paddings in order to make the photo editor look
consistent with the other editor fields.
This CL doesn't bother ensuring the readonly photo edit
field looks good. This will be done in a later CL.
Bug: 18004959
Change-Id: I683f3ffa8e7f8683c2c083a2b4592b2b95c58c63
ontactEditorFragment.java
ditor.java
hotoActionPopup.java
hotoEditorView.java
|
| c300521331c04767cd19dfe05ab77567514bbaa0 |
06-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Use larger photo in contact editor
Increase the size of the photo in the contact editor.
This means we can no longer rely on thumbnails. We
now need to load contact photos from Uris.
Bug: 18004959
Change-Id: Ice2099998194adad9336c5d90e9873a230ca4bd5
aseRawContactEditorView.java
ontactEditorFragment.java
hotoEditorView.java
|
| 2ebade8924bb6d2734b603938f418959cc79e2ad |
05-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Editor name fields
The mocks show all name fields collapsed into a single field.
After deeper inspection, this proved to be poor UX. Instead
we show the three name types inside a single name section.
Screenshot: go/ba_screen_captures/contacts/b18004959_edit_screen_material/name_fields.png
Bug: 18004959
Change-Id: Ic06abcd151a64746cce32832b27e8f47ec6b981d
honeticNameEditorView.java
awContactEditorView.java
tructuredNameEditorView.java
|
| 043fba637b421dcd554c634f769f0e883fb5ff8b |
30-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Material design of common edit screen fields
The normal edit screen fields, such as phone number and location,
have been updated to look like the new Material design mocks. I expect
this to be the largest CL needed to finish b/18004959.
Aspects of the Editor that haven't been touched in this CL
- readonly editor
- collapse nickname and phonetic name into StructuredNameEditorView. Then make
sure the layout is correct
- photo editor
- Material insert/delete interpolators (maybe fast_out_slow_in)
- account header
Some complicated/weird parts of the CL:
-KindSectionView no longer displays an "Add details" button. Instead
it always shows an additional empty row for each mimeType. The logic
that handles this is mostly inside #updateEmptyEditors(). A lot of code
could be deleted from RawContactEditorView because of this.
-LabeledEditorView's adapter displays TextView's inside Spinner. In order
to make the TextViews look like EditTexts, I set the EditText's background
(so the 9patch padding is used) and then later remove the background.
-Instead of keeping an expansion_view_container in every single field,
I only kept it where it was needed. As a result, I needed to add
null checks into the TextFieldsEditorView base class.
-I made an effort to reduce the depth of the view hierarchy and reduce
the use of LinearLayout weights for performance reasons, when it was
easy to do so
Bug: 18004959
Change-Id: I5934ca189b66468834faf3bb995b172ae2f90bed
ditorAnimator.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 8f9d84fffbc32b50cf3133b2340b18d0510a6c6e |
04-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Remove field when removing the only char
This allows us to make a simplifying assumption for b/18004959.
After this, we can assume that updateEmptyEditors is never called
with emptyEditors.size() > 1 and findFocus() == null.
Bug: 18004959
Bug: 18194655
Change-Id: Idaf2c64bf3d359c1aa8938150a6cda3684542d42
ventFieldEditorView.java
abeledEditorView.java
honeticNameEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
|
| 5d2e262ab3658118a12fbf6d0edab76484368c24 |
03-Nov-2014 |
Walter Jang <wjang@google.com> |
Make it easier to delete a contact
* Add delete menu item to quickcontact overflow menu
* Promote delete menu item on edit contact activity
from overflow menu to show as action
Bug 18061876
Change-Id: I3f99e1cd00151b968a157ff818bf977c0be15eb2
ontactEditorFragment.java
|
| a3e498a1d189010791f98183c1267d869f0d941b |
27-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Fix analytics in Contacts app
Remove dependencies on old analytics code.
Initialize analytics inside ContactsApplication.
Improving analytics CL #3/4
Bug: 18039620
Change-Id: I115315519ad245ff199bcf532270f56b9a2d6b61
ontactEditorFragment.java
plitContactConfirmationDialogFragment.java
|
| e4c2f549b6fe20ae65a8ae1097fabe5f22b5750d |
23-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Use analytics activities and fragments
All Contacts's activities and fragments now inherit from
analytics base classes.
Bug: 18039620
Change-Id: Ia550263640f60bc3f7daa7e85cd9f612f0dfc8a8
ontactEditorFragment.java
plitContactConfirmationDialogFragment.java
|
| f19dda97bfdef84e3f39ba069a981004a5c797b1 |
16-Sep-2014 |
Paul Soulos <psoulos@google.com> |
Disables the delete menu option on "insert or edit" actions
bug: 17468225
Change-Id: I9c26279cbedfe773d6fbd39ad49470d39ac88f2e
ontactEditorFragment.java
|
| bd127671f7fbcefb87a1b383140dee89cdb7039c |
20-Aug-2014 |
Brian Attwell <brianattwell@google.com> |
Save menu state on rotation, in contact editor
Bug: 17148558
Change-Id: I4f31ddd7a685b6bc6ea6d13e4c0d0f9be78df49a
ontactEditorFragment.java
|
| 723e2f667d8a306d48e2948d006527c718083111 |
28-Jul-2014 |
Brian Attwell <brianattwell@google.com> |
Fix for real this time.
Change-Id: I77e79da6a57d0a6d6b92807495ec66d8a137c6d7
tructuredNameEditorView.java
|
| 95d3538f51935195521cfc996a0c9f85927bc5f2 |
28-Jul-2014 |
Brian Attwell <brianattwell@google.com> |
Fix name-suffix rotation crash, for real this time
This reverts commit 97b2ccd1e32457382dd5ce7c0ee2a3ab485d8be9.
Bug: 16558948
Change-Id: I736a55c33867e7442ac55417fcb2112c3d7d641d
tructuredNameEditorView.java
|
| 81cc3b3d09d9296e521ac3454ad01c6b6c2ba71b |
23-Jul-2014 |
Brian Attwell <brianattwell@google.com> |
Contact picker: add search icon & hide searchview
Hide/unhide the SearchView when you click a seach menu item.
This is the first and more important step for b/16190113.
In a later CL, I might remove the SearchView and replace it
with the custom actionbar view created by dialer & used
in PeopleActivity.
Also merged JoinContactActivity into ContactSelectionActivity.
Bug: 16190113
Change-Id: I04bf7d22dffbf7f104362b17c9064cb386a01abe
ontactEditorFragment.java
|
| 8a6f4ade05e5a8a89d91078ef9c22944450ac8ba |
07-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Bag of QuickContact improvements
* QuickContacts open full screen when inside the Contact app
* Status bar color (aka system bar)
* Added and animated shim
* Moving code off UI thread (without these, I was seeing ~20
frames dropped from the shim animation)
* QuickContacts now acts reasonably when re-entering QuickContacts
from the edit view
Change-Id: Idafc20b62b1d04f0a9c437b3708555ec6dddedf5
ontactEditorFragment.java
|
| a513f720d2a15be6a00894c9a2812355d0643fcf |
06-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Add delete button to Edit View
When a contact is deleted, QuickContacts is told by LoaderCallbacks
that it shouldn't be visible prior to onResume().
Change-Id: I5f9c84cbfefddca3722bd1de3c5a98760547ef0a
ontactEditorFragment.java
|
| 5cc21eb9fd21c50ada1d94665560099025f9853d |
04-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Quantized edit fragment
Switched edit fragment's view to use the PeopleTheme.
After this, the default padding inside EditText changed. I set the
padding back to Holo padding.
Change-Id: Ic7ad33f4c0e6d75e6c173cc7c1689fb4651f959a
extFieldsEditorView.java
|
| d257a90e1a9a439da44a97d328c3a933d54f2cae |
04-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Move phone menu options into edit screen
Currently, these options will only supported for existing contacts.
This is what UX's mocks show.
Change-Id: I97fd58c11aea1594052945cdfd956b6eff883b7c
ontactEditorFragment.java
|
| 5a57e57c122edefbeea40a35102d53598aebfc1c |
29-May-2014 |
Jay Shrauner <shrauner@google.com> |
Fix cursor overrun in updateSuggestedContactIds
Modify loop logic in updateSuggestedContactIds so only traverses the
cursor once so we guard against trying to read values that we can no
longer move to.
Bug:15330979
Change-Id: I1161ad894ada160691f43e8fbfc2efb060f43421
ggregationSuggestionEngine.java
|
| 7039633999b3a46a87c851fa06d9168897ccc54b |
28-May-2014 |
Yorke Lee <yorkelee@google.com> |
Fix broken contacts tests
Change-Id: Ie9c803ede45b300f20a03a25d6a646cd6eb1f39e
ontactEditorUtils.java
|
| 28daa7d3e7f81e92ebc134b19ae7fe2d902aa531 |
29-May-2014 |
Ed Heyl <edheyl@google.com> |
Fix build breakage: Revert "Fix broken contacts tests"
This reverts commit 90ef577763f3ccb2d43fda1d21c62533acbbecdb.
Change-Id: If98147879e1658c3a48d04b855c033d191fec2f6
ontactEditorUtils.java
|
| 90ef577763f3ccb2d43fda1d21c62533acbbecdb |
28-May-2014 |
Yorke Lee <yorkelee@google.com> |
Fix broken contacts tests
Change-Id: I0edda45234edb7fe4e322138ad48af426133634f
ontactEditorUtils.java
|
| b8671d271e6a7c48aca785b867ef9a86c5012a85 |
15-May-2014 |
Brian Attwell <brianattwell@google.com> |
No "merge" and "seperate" actions on insert
Only show these actions for existing contacts. Not
when creating a new contact.
Change-Id: Iaf7dee665301e28841dc3c4a1bd7d5c1ce3297c5
ontactEditorFragment.java
|
| 91ae79cb54310305c2d7ff23aaee51f24c7a21b7 |
22-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
am fbc6cdd5: am 08afec7f: Merge "Move cursor to the right place when adding phonetic name"
* commit 'fbc6cdd5f9ed04f95e9d1ef565017c2208f61d20':
Move cursor to the right place when adding phonetic name
|
| fbc6cdd5f9ed04f95e9d1ef565017c2208f61d20 |
22-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
am 08afec7f: Merge "Move cursor to the right place when adding phonetic name"
* commit '08afec7f1251b6a337eda32762afd023fbe2ec95':
Move cursor to the right place when adding phonetic name
|
| c26bc592c0e9a4587512a9677bc2dd9d311b0975 |
15-Apr-2014 |
Ben Gilad <gilad@google.com> |
Fix NPE in android.graphics.BitmapFactory.decodeFile
Change-Id: Iab8db2f1ae173f44cb12cf0376e8b53768c6d069
ontactEditorFragment.java
|
| 6ba58c7dc8d63e1a6f803f9c2dd1990d80567c59 |
06-Jun-2013 |
Puneet K Jain <puneet.k.jain@intel.com> |
Move cursor to the right place when adding phonetic name
When adding the phonetic name, the Editor fails to get the focus automatically.
Change-Id: I6371508ea595b83e10a89c7a647452bd969a9d17
Signed-off-by: guojingx <guojingx.wu@intel.com>
awContactEditorView.java
|
| b00ca40641bfa0f8056edae7420b7f4cf713b5a1 |
20-Feb-2014 |
Yorke Lee <yorkelee@google.com> |
Use new ContactPhotoManager APIs for default avatars in Contacts
*Update the following uses of ContactPhotoManager.loadPhoto
and ContactPhotoManager.loadThumbnail
GroupEditorFragment
EmailAddressListAdapter
PostalAddressListAdapter
*Replace the following uses of R.drawable.ic_contact_picture_holo_light and
ContactPhotoManager.getDefaultAvatarResId with
ContactPhotoManager.getDefaultAvatarDrawableForContact
PhotoEditorView
AggregationSuggestionView
SuggestedMemberListAdapter
ConfirmAddDetailActivity
ImageViewDrawableSetter
*Protect against a null drawable in TransformableImageView()
*Add lookup fields to cursor projections in EmailAddressListAdapter
and PostalAddressListAdapter to correct construct a DefaultImageRequest
and assign LetterTileDrawables for contact photos
Bug: 13101785
Change-Id: I9c04ce81192913bf3c398a9a7a9368861bd93b59
(cherry picked from commit f677450d82e7b961fda2a18fea2ad51e88437e8b)
ggregationSuggestionView.java
hotoEditorView.java
|
| ce29a6c702318192f696787a077159cad747b4f7 |
04-Mar-2014 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix NPE in setGroupMetaData" into klp-dev
|
| fe05992e463a2e181551b2880235026870dde301 |
04-Mar-2014 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix NPE when phone number or email is null" into klp-dev
|
| 8a66abdfb9c09ba4cdd089921e9aa2934769e413 |
04-Mar-2014 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix potential NPE with null cursor" into klp-dev
|
| 583be4d812ae2f30fd0a962bd7952e8432720935 |
04-Mar-2014 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix NPE when sorting accounts lacking type" into klp-dev
|
| af7b79978693a0921437bb2c6ceec985003a2c67 |
21-Feb-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE in setGroupMetaData
Check that listView is non-null before dereferencing it. Catch case
in onClick() where popup was dismissed but mPopup wasn't cleared.
Bug:13136064
Change-Id: I8f826ae969434c4dce88c5fb506b5ed2cc9ea04b
(cherry picked from commit 9813b71d3a6a2e0baba96cda72ee55415e523166)
roupMembershipView.java
|
| d7ab82f8303c0d7943db602a01ebdbb9244222e0 |
30-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when phone number or email is null
Don't crash if phone number or email address is null; instead, skip the
entry.
Bug:12821628
Change-Id: I3f5de7926278fb54941f9cdb59e9366060d420eb
(cherry picked from commit 89095c7a4bb85a54d7e6c56322a7fcbf0b60f93e)
awContactReadOnlyEditorView.java
|
| 9b9dacbbb2353f3415fb70cc1ae8b2e9152e4ecb |
28-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix potential NPE with null cursor
Detect and handle null cursors returned from CP2 queries.
Bug:12767708
Change-Id: I1571463b80e5b85656fe119c6bc83de36be30c7f
(cherry picked from commit 13c42f4ebb1c7f31750262946ce3b390c93d5320)
ggregationSuggestionEngine.java
|
| d0dac2f45e6c5900f0f83ba228b26d041164281c |
21-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when sorting accounts lacking type
Fix NPE when accountType is null in comparator.
Bug:12661115
Change-Id: I37d8b10a48f85f6a23e5761b7bf85a5f612c7379
(cherry picked from commit d97719de77bc3758c34fe11301cf29651578e58d)
ontactEditorFragment.java
|
| a8c9337bf6ca808382d6c4401b05ddc79929e9f5 |
10-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Handle null returns from insertChild
insertChild() returns null whenever kind is null. Don't crash in these cases.
Bug:12490438
Change-Id: Idf1cd8fa9d6dfe6a2f91f3ff656663f0692f4a3f
(cherry picked from commit f54c9f2c84a88e046e29123fa65b19040e5a457b)
roupMembershipView.java
awContactEditorView.java
|
| f677450d82e7b961fda2a18fea2ad51e88437e8b |
20-Feb-2014 |
Yorke Lee <yorkelee@google.com> |
Use new ContactPhotoManager APIs for default avatars in Contacts
*Update the following uses of ContactPhotoManager.loadPhoto
and ContactPhotoManager.loadThumbnail
GroupEditorFragment
EmailAddressListAdapter
PostalAddressListAdapter
*Replace the following uses of R.drawable.ic_contact_picture_holo_light and
ContactPhotoManager.getDefaultAvatarResId with
ContactPhotoManager.getDefaultAvatarDrawableForContact
PhotoEditorView
AggregationSuggestionView
SuggestedMemberListAdapter
ConfirmAddDetailActivity
ImageViewDrawableSetter
*Protect against a null drawable in TransformableImageView()
*Add lookup fields to cursor projections in EmailAddressListAdapter
and PostalAddressListAdapter to correct construct a DefaultImageRequest
and assign LetterTileDrawables for contact photos
Bug: 13101785
Change-Id: I9c04ce81192913bf3c398a9a7a9368861bd93b59
ggregationSuggestionView.java
hotoEditorView.java
|
| 9813b71d3a6a2e0baba96cda72ee55415e523166 |
21-Feb-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE in setGroupMetaData
Check that listView is non-null before dereferencing it. Catch case
in onClick() where popup was dismissed but mPopup wasn't cleared.
Bug:13136064
Change-Id: I8f826ae969434c4dce88c5fb506b5ed2cc9ea04b
roupMembershipView.java
|
| 89095c7a4bb85a54d7e6c56322a7fcbf0b60f93e |
30-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when phone number or email is null
Don't crash if phone number or email address is null; instead, skip the
entry.
Bug:12821628
Change-Id: I3f5de7926278fb54941f9cdb59e9366060d420eb
awContactReadOnlyEditorView.java
|
| 13c42f4ebb1c7f31750262946ce3b390c93d5320 |
28-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix potential NPE with null cursor
Detect and handle null cursors returned from CP2 queries.
Bug:12767708
Change-Id: I1571463b80e5b85656fe119c6bc83de36be30c7f
ggregationSuggestionEngine.java
|
| d97719de77bc3758c34fe11301cf29651578e58d |
21-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when sorting accounts lacking type
Fix NPE when accountType is null in comparator.
Bug:12661115
Change-Id: I37d8b10a48f85f6a23e5761b7bf85a5f612c7379
ontactEditorFragment.java
|
| f54c9f2c84a88e046e29123fa65b19040e5a457b |
10-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Handle null returns from insertChild
insertChild() returns null whenever kind is null. Don't crash in these cases.
Bug:12490438
Change-Id: Idf1cd8fa9d6dfe6a2f91f3ff656663f0692f4a3f
roupMembershipView.java
awContactEditorView.java
|
| cd321f65f1e50409812976380ad1f0fdb3fa35cb |
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
aseRawContactEditorView.java
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| 637a38ec9de6b1f434d7a13105f2e747faae5107 |
14-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Make contacts photo pickers compatible with new documents UI
The old contacts photo picker code was using unguaranteed behavior
(that Intent.GET_CONTENT would support MediaStore.EXTRA_OUTPUT) and this
caused it to not work anymore with the new document picker.
This CL changes all usages of files to instead use URIs.
Also, a FileProvider has been added to Contacts, to allow us to pass in
URI pointing to our private cache in intent.setClipData with
Intent.FLAG_GRANT_WRITE_URI_PERMISSION and Intent.FLAG_GRANT_READ_URI_PERMISSION
so we no longer have to reply on the MediaStore.EXTRA_OUTPUT being parsed
and supported. The use of the FileProvider also prevents unauthorized access
to temporary files during the caching process.
Bug: 10745342
Change-Id: Iaee3d7d112dd124a2f5596c4b9704ea75d3b3419
ontactEditorFragment.java
|
| e09b991d963c8207cb4bc64ff45009dd33523e1b |
05-Sep-2013 |
Alon Albert <aalbert@google.com> |
Support QuickContacts For Extended Directories
Change-Id: If336b94955dbea9f02e4fabbd797257151fa512a
ontactEditorUtils.java
|
| cbfb11288368bca3a6e350ae880d53ffb4907b78 |
04-May-2013 |
Yorke Lee <yorkelee@google.com> |
Force LTR for phone numbers in contact details and editor
Bug 8676101
Change-Id: Ia5117c2e7dbffb5ca17e4147a20bdade500a8c92
awContactReadOnlyEditorView.java
extFieldsEditorView.java
|
| 7d3b91577f84a4f5092d28ed0f3cfe7e0df32696 |
05-Apr-2013 |
Fabrice Di Meglio <fdimeglio@google.com> |
Fix bug #7536213 UI should be mirrored for RTL languages (people, dialer, in-call)
- add start/end properties aside to left/right ones
- update Gravity to START/END
- add mirrored version of Drawables
- use android:textAlignment="viewStart" when needed on TextView
- use android:textDirection="ltr" for when needed for Phone Numbers
Change-Id: I5f5deb69e4af350b632a6592447721196bedb539
abeledEditorView.java
|
| eba2721a826e2edc78e37b2519aa5d5f06857cde |
15-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix monkey crash in RawContactEditorView
Bug: 8011818
Change-Id: I3c69f253aadfc94ee4bc7364d2943b9068efd394
awContactEditorView.java
|
| cab161cfe8819200171ce0936050834d6694730e |
17-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "Fix empty name field when adding contact from maps"
|
| 688c228b2d7cf0c812fb673451f24e7cb457d63b |
17-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix empty name field when adding contact from maps
Bug: 8026778
Change-Id: Id8ee1b7a02b2c9845258aca09f68ed9e1e4d3642
ontactEditorFragment.java
|
| 13d52b10fd720bb94ffe7a7e7ad1b37c1e06bb50 |
16-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix crash when adding a new contact
Check if mRawContacts is not null before trying to save it into
outState in onSaveInstanceState. If it is not null, save an
empty arraylist instead.
Bug: 8018115
Change-Id: I14db6bad22707b5154ffe016d2fd3b4391c13c85
ontactEditorFragment.java
|
| 44cfc56d1701629070384364416c1311b780535d |
13-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Allow read-only contacts to be editable.
- Automatically create new raw contact when editing a read-only contact.
- Refactored mState to be always initialized.
- Allow RawContactDeltaList to be instantiated with empty constructor.
Bug: 6406182
Change-Id: I7a58625485dae6957b4f9bcc446122f54551afa1
ontactEditorFragment.java
awContactEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
|
| ec6bfa0ce4a94edbafb97c7ae2b573abf2aa4a85 |
20-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Add intent to view calendar for event data item
Refactor parseDate and formatDate code in DateUtils to reduce
duplicate code.
Bug: 7876289
Change-Id: I0463c21942ab825e23146a485789795891726c3f
ventFieldEditorView.java
|
| 846a4f097daa33ab2244b4fa90a9a7a876705c90 |
28-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Merge "Add animation for expand/collapse actions in editor"
|
| ba48d21f2ab25c8ffb30198a752e5cd215553728 |
26-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Add animation for expand/collapse actions in editor
Add sliding and fade in animations for the structured names and address
editor fields that have expand/collapse actions.
Bug: 6009430
Change-Id: I005bcf4cbe9c8103fbbece506547551adf49d2ae
ditorAnimator.java
extFieldsEditorView.java
|
| 619ac169e45bf547a2cbcd8a9775bb234f45c00f |
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use single method to handle all popup.dismiss() logic.
Refactor to reduce duplicate code.
Bug: 7902358
Change-Id: I6395635eba435ef6ebe4a34125d9a310c18f7e93
roupMembershipView.java
hotoActionPopup.java
|
| 3dfcde367cc1c85e3a2af5b00c84f1ec89c76b15 |
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Merge "Close popup window before fragment is destroyed."
|
| 86625158bdc52855c37e96bf098ba7a213c810d7 |
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Close popup window before fragment is destroyed.
Bug: 5606937
Change-Id: Ibfcc2d0c110f333a6728141f77c21adfeceb7419
ontactEditorFragment.java
|
| 4b294d6c96c4865b64338e5d222ff9dc87bad5b9 |
19-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Standardize event date formatting in People app
Refactor formatDate in DateUtils to allow it to return long and short
date formats.
Use full localized dates similar to dates in Calendar in
ContactDetailFragment.
Use short localized dates only in EventFieldEditorView to avoid overflow.
Bug: 5042674
Change-Id: Iaff340046c84d7ce474757367454358c47d73a08
ventFieldEditorView.java
|
| f3c73113f0882d79aece54bc8ad467a5d0660f62 |
13-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Hide discard menu option if there are no writable raw contacts
Bug: 5174543
Change-Id: I87dd24e160df60cb92522cc91adb4e47de942331
ontactEditorFragment.java
|
| 567ca2bd186d45f5b38e60cc200c9f7d4fdd8c80 |
12-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Merge "Destroy mAggregationSuggestionEngine only on destroy"
|
| 36184f630cdb97d0a642de25f69962ef2abfedb1 |
12-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Destroy mAggregationSuggestionEngine only on destroy
Bug: 5458280
Change-Id: Ifcb6f120d6e7961703434e8d97183c6a7a70feb5
ontactEditorFragment.java
|
| 827b5d6611018497eb28a0776cb51226fb81ae23 |
07-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Don't hide organization fields on rotation if they are expanded
Keep track of whether or not organization fields are expanded so that
we can restore this property on rotation
Bug: 6009291
Change-Id: I525606c940ffa66458e689cfc6e376d8719de4d8
awContactEditorView.java
|
| 0d998e53b383fdd6689a77043a3618bbda25d665 |
07-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Merge "Refactor editor layout file dependencies out of common."
|
| ddd4e821226395fd977d87b6692f761c90d59139 |
06-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Refactor editor layout file dependencies out of common.
Editor view layout files are only needed by the Contacts app. But they were
being referenced from within AccountTypeManager and several other classes.
These references are un-necessary and would have caused too many editor
dependencies, such as the EditorView classes, to go into common.
With the refactor, many layout files can be moved back into Contacts.
Bug: 6993891
Change-Id: I146b3038f1b2273a3af2dfac3d2e86bf40bb5bd7
ditorUiUtils.java
indSectionView.java
|
| c21751ddc1a91453a37273ace9e24907bb54cc99 |
06-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Don't show Take Photo option if device has no camera
Bug: 6470740
Change-Id: I652ce8c9da89901379c876d168ba497bf1aa5836
hotoActionPopup.java
|
| c2114fd85c7ebac73abe8796d92ee4f3e507ed18 |
05-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Merge "Moving SelectAccountDialogFragment to ContactsCommon."
|
| 87c71f43c70cd970e54eecbfa4c8d79259922c5d |
05-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving SelectAccountDialogFragment to ContactsCommon.
In preparation to move ImportExportDialogFragment to common.
Also moved a few more string resources left out from previous move.
Bug: 6993891
Change-Id: I2ddb6467732c53a70bc94c4cd0c702346ccb54fe
ontactEditorFragment.java
electAccountDialogFragment.java
|
| 78253a9e7e8dc5724333fa6a61e537249adac90b |
04-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Show the current date when creating a new event.
Bug: 6460956
Change-Id: I48752c6b133cd05c49e9b418724eb905963d5d8a
ventFieldEditorView.java
|
| 738ff8623dc77dd91a1b9023861e924ba5e4c27e |
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon.
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
ggregationSuggestionEngine.java
aseRawContactEditorView.java
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| aa690d4949b8105e5bcf10569b7cf4fae36741de |
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class.
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
ggregationSuggestionEngine.java
aseRawContactEditorView.java
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| 0d5588da244d0992c3ff8f25d0875fdf95a8c644 |
27-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move AccountTypeManager to ContactsCommon.
Moving AccountTypeManager to ContactsCommon so it can be shared by Contacts
and Dialer.
Bug: 6993891
Change-Id: I9526ac7cda758290caecabfcaebe620238d8dd6b
ggregationSuggestionView.java
ontactEditorFragment.java
ontactEditorUtils.java
|
| 858fcbefa60be2167daffda19adf7a7d2e44fae0 |
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Merge "Use Objects from guava library."
|
| df237ecf94a05a5cdc5d21a4ba6fabb5bbfbbee4 |
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
am f1689e3e: am 1cd2c24a: am f5d37174: Merge "Minor changes to validateAction()." into jb-mr1.1-dev
* commit 'f1689e3e99a95c61c0874f3f5057dd35040f1d7e':
Minor changes to validateAction().
|
| ba09d4cc21d55181c1760e7994f0225939f4999d |
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use Objects from guava library.
Switch com.android.internal.util.Objects to com.google.common.base.Objects.
Bug: 6948882
Change-Id: I0adcff2e02e2dfbdfaa323ac72e0d42c1cbc979c
roupMembershipView.java
awContactEditorView.java
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
ggregationSuggestionView.java
aseRawContactEditorView.java
ontactEditorFragment.java
ontactEditorUtils.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
electAccountDialogFragment.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| e8e94423b463688951f806419dbd73e10e7bf7b4 |
13-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Minor changes to validateAction().
- Make error message more accurate.
- Change action validation to be inline instead of relying on for loop.
Bug: 7122054
Change-Id: I4d9e3e2a18659bbe5ccc0e355d1e7d97f5d38e0f
ontactEditorFragment.java
|
| 8477f7ab95ec2e70f98277f79f48495c13382321 |
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fix blank edit view after orientation change.
If an orientation change occurs before the contact data loads from the
database, the code fails to reload the data because it is checking
against saved state (which is always present on an orientation change).
This fix changes the check to look for the actual data to be present
in the saved state.
Bug: 7122054
Change-Id: I4373eca14ba447abc57493cf4c5af6b978d8b7a2
ontactEditorFragment.java
|
| 720ac2f99fc6cb4b92852a1a54ccd8c7c796c7d2 |
30-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move PhoneNumberFormatter to common.
Bug: 6993891
Change-Id: I2b617a5c57e8f51ecba193613447ec834cfcf6fe
extFieldsEditorView.java
|
| 79a6b5d3a885bc508b4b98c92a946fe12643c444 |
16-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Sharing ContactPhotoManager between dialer and people.
Move ContactPhotoManager and dependent classes to ContactsCommon so it can be
shared by dialer and people.
Bug: 6993891
Change-Id: Ib37af58718850d6d5515bbf3e46aca9fb95f9ee8
awContactReadOnlyEditorView.java
|
| cdc279de45da459b359254777a09ab630ce60fa9 |
19-Sep-2012 |
Yorke Lee <yorkelee@google.com> |
am f0aa3c9d: am 288532cd: Fix BadTokenException in ContactEditorFragment
* commit 'f0aa3c9d1fc09f25a3dbd250493d8119ce360aab':
Fix BadTokenException in ContactEditorFragment
|
| 288532cddfccdc3793dd748d1c75750e2f46cb53 |
19-Sep-2012 |
Yorke Lee <yorkelee@google.com> |
Fix BadTokenException in ContactEditorFragment
Bug: 7162486
Change-Id: I3b8fcf6cf2fd3f11368b5af643a9b69ce0890e84
ontactEditorFragment.java
|
| 47b6f70eadb118d815b4aaf5426c070bd75a38fb |
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Refactor RawContact to be parcelable.
- Re-work of RawContact to be a real data container and removed un-necessary
dependencies.
- Removed un-necessary circular dependency between RawContact and DataItem.
- Cleaned up and made DataItem more compartmentalized by removing un-related
account methods.
- Implemented Parcelable for RawContact and NamedDataItem.
Bug: 6406182
Change-Id: Icd84f34d85e1349a86e473708cc7f8fece12349f
ontactEditorFragment.java
tructuredNameEditorView.java
|
| 098f630c3dd0d993a423425e138f95dba0d7612c |
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fix blank edit view after orientation change.
If an orientation change occurs before the contact data loads from the
database, the code fails to reload the data because it is checking
against saved state (which is always present on an orientation change).
This fix changes the check to look for the actual data to be present
in the saved state.
Bug: 7122054
Change-Id: I4373eca14ba447abc57493cf4c5af6b978d8b7a2
ontactEditorFragment.java
|
| e813f5e56ddc6395c5e08e9245e2c5ad41e91724 |
23-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Guard JOIN in case the state machine gets into an erroneous state
Bug:7013287
Change-Id: Id4da1f02b00efcc02fe3ad6c277189ad96fcb67f
ontactEditorFragment.java
|
| 5671c7e7718c3285dc0391807401083986fcfd51 |
14-Aug-2012 |
Maurice Chu <mochu@google.com> |
Fix binding editors when state is null
The bindEditors() can only bind views when there is
data, so this checks for a null state and returns
immediately if null.
Bug: 6601692
Change-Id: I1abfd75ce3bffb5c96a7b5cb609c6d1686581649
ontactEditorFragment.java
|
| bc365a6107c2feec99d4fbb18e60baeea145c374 |
08-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Stop double-animating when removing the last editor. Fixes jump cuts
Bug:6009430
Change-Id: I8e0a24334a5d92bc300f4d0ff15da99f4786852c
indSectionView.java
|
| 5a7a26962cc781d675280c790789e2dea28a7b34 |
04-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Fix support for birthday on February 29th with year omitted
Bug:6260151
Change-Id: Ib78e8bfc30dd5d9554c1f82f9617f7abacb5ce78
ventFieldEditorView.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
ggregationSuggestionEngine.java
ggregationSuggestionView.java
aseRawContactEditorView.java
ontactEditorFragment.java
ontactEditorUtils.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
electAccountDialogFragment.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
ggregationSuggestionEngine.java
ggregationSuggestionView.java
aseRawContactEditorView.java
ontactEditorFragment.java
ontactEditorUtils.java
ditor.java
ditorAnimator.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoActionPopup.java
hotoEditorView.java
awContactEditorView.java
awContactReadOnlyEditorView.java
electAccountDialogFragment.java
plitContactConfirmationDialogFragment.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| 3e435f0e724cb3e88efce15f760e59b9bc08f0d3 |
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Change usages of com.google.android to com.google.common.
The people app contains usages of both com.google.android and com.google.common.
Changing code to use the later guava library since it will be needed to unbundle
the app in the future.
Change-Id: I2700126e020166ea1bbbd87c40e77428efde41f3
ggregationSuggestionEngine.java
ggregationSuggestionView.java
|
| 4bff8fb686f2ac5500109a32cca9270965c620d6 |
06-Jun-2012 |
Makoto Onuki <omakoto@google.com> |
Fix handling rotation while camera/gallery/crop is active
on contact editor.
mCurrentPhotoHandler needs to be restored after orientation change.
Bug 6610108
Change-Id: I2a2877856b8c682cce01195bbf9d80978f9ec175
ontactEditorFragment.java
|
| 36923016e40df2d252c600ad13a2b35ec14f29af |
30-May-2012 |
Maurice Chu <mochu@google.com> |
Merge "Fix regression when editing contacts" into jb-dev
|
| a2f9090cef25dfe4e13117db8c91a056a7d5f114 |
29-May-2012 |
Maurice Chu <mochu@google.com> |
Fix regression when editing contacts
Put a null pointer check when determining whether
a photo already exists.
Bug: 6574706
Change-Id: I21bdbc162910715d5792308a7cb8abdd18bf2eda
ontactEditorFragment.java
|
| 2e9ee9f15a1d928619a49ad259cdccbc8c7414dc |
25-May-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fix NPE when a view is traversed without a parent.
getViewsBelowOf() could be called on a view that has already been
removed from the view hieracrchy.
Bug: 6543741
Change-Id: Id986133598b986ea9ae66595e6adf07dc07ecfb0
ditorAnimator.java
|
| a1fa4d5db33dc4431b2bb325f3a8b7f06ab5d072 |
23-May-2012 |
Maurice Chu <mochu@google.com> |
Merge "Fix pop-up menus for photos in contact editor" into jb-dev
|
| 91004b37683c15650eccde68ff04defcf94a1c84 |
22-May-2012 |
Maurice Chu <mochu@google.com> |
Fix pop-up menus for photos in contact editor
The hasMoreThanOnePhoto() has been re-implemented to
look directly at the entity deltas to determine whether
there are more than one photo in the set of raw contacts
rather than relying on whether a photo was set in a raw
contact editor view.
Also, calls to refresh the raw contact views are made if
any changes to raw contact photos are made.
Finally, fixed a regression where the photo handler is not
set correctly so that the wrong photo handler would handle
the callback onPhotoSelected which caused a newly taken
image or chosen image from the gallery would get set to the
wrong raw contact.
Bug: 6408705
Bug: 5850397
Change-Id: I94e3872ed3e0191f1ca845de0d01525aee3a5f5f
ontactEditorFragment.java
|
| 45ee872fe7be69c6b3f0c59167eecd11af467812 |
22-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't send view notification before showing quick contact
Instead, do this in the second load. This directly affects the quick contact
startup time.
Bug 6529921
Change-Id: Ief7bda9bd32cb4be0c86c4b79efb35da812721dc
ontactEditorFragment.java
|
| 2d4632c2eb7d2dc3bb94bf64c14c471aafa67b0f |
10-May-2012 |
Maurice Chu <mochu@google.com> |
Fine-tuned enlarging of contact photos
When tapping a contact detail photo on any device, the
detail photo will attempt to expand as large as indicated
while still remaining fully on the screen and leaving some
space underneath to show the popup menu options.
If there is no photo, then there will be no expansion
although writable contacts will show a popup menu.
Bug: 6462711
Change-Id: I8f69a1c18dfa10ff0d02b9dbd3ba78043cc7eb4e
hotoActionPopup.java
|
| ebc17929007ecf12f25b8e90023766e8a083d11e |
05-May-2012 |
Josh Gargus <jjosh@google.com> |
Don't stash cropped photos in /sdcard/DCIM.
Every time we choose a new contact photo (either an existing one from
the gallery or a new one from the camera), we write the cropped image
/sdcard/DCIM. As a result, the cropped image (eventually) appears in
the gallery, is uploaded to G+, etc.
The new behavior is to write the cropped photo to a temp directory,
and to clear it when we're done with it.
Revert some of the changes from Ib7037a66; we still need to persist
properties in onSaveInstanceState() in case ContactEditorFragment is
killed while the user interacts with the camera/gallery.
Bug: 6423139
Change-Id: Icf8cb5b4824e3d8757ff483ef128527ac9132e72
ontactEditorFragment.java
|
| 85d720220cb69226f7d809df849eb1e9604b2c0f |
04-May-2012 |
Maurice Chu <mochu@google.com> |
Merge "Fixed group editing popup from contact editor" into jb-dev
|
| b03e6a266e3a4181d22e6be4f3fa0c5dd158d7e1 |
04-May-2012 |
Maurice Chu <mochu@google.com> |
Fixed group editing popup from contact editor
Removed checkbox next to the last "Create new group" option
in popup and removed square brackets in string.
After creating a new group, the view shows the popup again
with the newly create group visible and checked. This is
accomplished via a listener interface to the
GroupCreationDialogFragment. The tricky part to this is if
the user changes device orientation while the
GroupCreationDialogFragment is open. The ContactEditorFragment
will save the resource id of the RawContactEditorView (since
there can be many via joins) and the view id of the
GroupMembershipView which is the listener.
Bug: 6013015
Change-Id: Ia50a68fb6f4631995ae913182765efb24ef227ec
roupMembershipView.java
|
| 87270e1b58e669354bb1571ced686421c56deb7a |
03-May-2012 |
Josh Gargus <jjosh@google.com> |
Avoid crash when re-saving new contact with photo.
This bug was encountered when creating a new contact from Maps,
but could happen any time you:
- create a new contact
- set a contact photo, either from the gallery or a new photo
- save contact but don't leave ContactEditorFragment
(eg: "Join" cause the contact to be saved)
- edit another field
- save
The fix is to clear the list of photos-to-save after each save.
Bug: 6432438
Change-Id: I63e86bd82fd16b8177bdca741ecc7a1a90d22d18
ontactEditorFragment.java
|
| 2828c48cc4537fe981918f80297d5408bedc87b5 |
28-Apr-2012 |
Makoto Onuki <omakoto@google.com> |
Prevent passing null context to AggregationSuggestionEngine
The monkey crash suggests we're creating this object when getActivity()
returns null, meaning after the fragment is destroyed.
I couldn't really find any path that could cause it, but let's make
sure we'll never pass null.
Bug 6340106
Change-Id: I38091b46a99821065e248c811ed2f974f2f47152
ggregationSuggestionEngine.java
ontactEditorFragment.java
|
| 740552201d103b80bc49ea8a39a30536222672ea |
27-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't show triangle and on-press state if there is no action
Bug:5265514
Change-Id: Ifc1d3b765f909f0ec7cc7565b9d89de50c4a5549
ontactEditorFragment.java
hotoEditorView.java
awContactReadOnlyEditorView.java
|
| 55967b408f722a3e1d6c61f09618ddd310fb7693 |
27-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Make popup non-modal for contact aggregation suggestion.
When editing a contact's name, the aggregation-engine provides
potential contacts that the user may wish to aggregate the current
contact with. However, this popup was modal, which is bad UX.
Bug: 5438601
Change-Id: Ic8519c235af75d44cfa060f16107cd64aeef61b9
ontactEditorFragment.java
|
| 6d172800844a3f23a918a099c90c10701159bf77 |
26-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Added one flag, fixed two bugs
Bug:6009417
Bug:6009184
Change-Id: I40e495b26cda43deaddd7794a1d09bb69cc77581
roupMembershipView.java
|
| 692d46364f2f0e32fd481b977c9e16832e70de5c |
25-Apr-2012 |
Maurice Chu <mochu@google.com> |
Added help menu options to People app
This has been implemented with the idea to enable the creation of help
menu options in a standard way throughout the Android platform. One
particularly important feature is to hide the exact URL that is being
used to invoke the help pages via the browser via using vendor-specific
overlays of string resources.
Also, other standard context for the help like the preferred language and
app version code are incorporated automatically via the HelpUtils function.
Bug:6206323
Change-Id: I5a1fff4d99ac93d3a6aa05da91f465fad072cb8a
ontactEditorFragment.java
|
| 9a409d474b2b4f2e4261657f864eeb866fcb8816 |
24-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Fix an NPE in PhotoSelectionHandler. mListener was always null
- Also fixed an independent crash when replacing a photo from Details
- Also renamed mListener in ContactEditorFragment to avoid name shadowing
Bug:6387900
Change-Id: I000009c6c8d4ea4a07168f99530e4ef1f648a333
ontactEditorFragment.java
|
| e5d3f897689c8ba0f275c7679c72eacb190ae9b8 |
11-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Fix regression; once again we can apply Gallery photo to contact.
The changes to support hi-res photos in Ic0cabaa5 were not applied to
AttachPhotoActivity. This CL makes the analogous changes, and many other
cleanups besides.
In addition, applying the Gallery photo works even if the AttachPhotoActivity
is killed (eg: when selecting a contact, or when cropping the photo); this
didn't work even before the regression.
The save-contact Intent which invokes the ContactSaveService no longer
needs to specify a callback Activity (it is OK to pass null if you don't
care about getting a callback).
The subclasses of PhotoSelectionHandler have been significantly simplified,
partly by pushing common behavior to the superclass, and also by directly
accessing state in their outer class instead making their own copies.
ContactLoader.Result.getEntityDeltaList() is a new instance method that
replaces more verbose incantations.
New utility class, ContactPhotoUtils. Helps with compressing Bitmaps, and
generating temp-file names used when saving hi-res photos to a contact.
Bug: 6298601
Change-Id: I2fe90c33c9fa81716f263d82ed80c0d6f63c6a7e
ontactEditorFragment.java
hotoEditorView.java
|
| a04dc9c9ed2812af8f4466c2a5225a37d38d250e |
15-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Tweaked the input dialogs for the group name and the type
- Tweaked padding in type editor
- Made it so that OK is disabled in group editor
- Automatically show the keyboard
- Made the implementations a little more similar to each other
Change-Id: I2c1a131a7eb7ea3e306fdaa430be8945accf915b
abeledEditorView.java
|
| d91320306dc1054e063e705e08416be0d5b98edb |
15-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Use the Context of the Builder instead of the Activity's
Also I don't like fluent interfaces
Bug:6007797
Change-Id: Ia5888025ad6c89f7cd20f57f058567432c820f7a
roupMembershipView.java
|
| 764637aba745612a9fdc07adb99c615263916fa8 |
04-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Allow setting photo on otherwise-empty local contacts.
Fix bug in ContactEditorFragment where, after tapping "Done",
the contact's photo is still unset. This regression is due to
the changes to support high-res photos... now that we use a
side-channel to save the photo, the EntityDeltaList doesn't
know about the change. The fix is to also create a thumbnail
and add it to the delta-list. This allows us to avoid ugly
special-case code in the editor and save-service. The high-res
photo is still saved via the same side-channel.
Bug: 6109553
Change-Id: I59bb9885eeb0260861ee167d3b5f1c7319896488
ontactEditorFragment.java
hotoEditorView.java
|
| 11812c59ee140d62eaf3a8d826d2018767d490c5 |
30-Mar-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't move "Provide a year" around on screen anymore, center instead
- Also fixes the title when no year is used. Doesn't show year "1' anymore
Bug:6009385
Change-Id: If0a23d852112970456dc3f5c4061d5c578fff48a
ventFieldEditorView.java
|
| 6f5557e3dc3cd12182026bdfea17b15d4d9b7dfc |
21-Mar-2012 |
Josh Gargus <jjosh@google.com> |
Improve frame-rate of quick-contact opening animation.
Fix consists of putting the quick-contact into a hardware layer for
the duration of the animation.
Rename AnimationUtils to SchedulingUtils to avoid conflict with
framework class of the same name.
Bug: 6000249
Change-Id: Ie627ddb947582b7860f5bd0de30484c1d1d4f428
ditorAnimator.java
|
| 51f9c0f2f2923d14cced5096b40f017dd87b68d3 |
20-Mar-2012 |
Josh Gargus <jjosh@google.com> |
Fix jank when expanding photo in ContactDetailActivity.
The bug is caused as follows. Tapping the photo invokes a
PhotoSelectionActivity. When it initially sets the photo, a relayout
request is made, which causes a jank if the animation is already
underway.
Instead, we now wait for the layout before starting the animation.
Add new utility class with static doAfterLayout() method, since this
code was duplicated in a couple of places.
Bug: 6000382
Change-Id: Ic32a3db1f8c0be99fe0c160debede71f882c73e7
ditorAnimator.java
|
| ca87e9c598929b5b6a62da9b80d2114168e24274 |
06-Mar-2012 |
Daniel Lehmann <lehmannd@google.com> |
Added some smoother transitions to the editor
- Transition when removing a field
- Transition when pushing the "Add organization" button
- Transition for visibility of "Add xxx" when entering text
- Added pushed state on "Add organization" button
- Increased the height of "Add xxx" to match the expanded size for simple
Editors from 40dip to 48dip
Bug:6009430
Change-Id: Ia4524006b528f49d587c6277ecc98b11f77ddc0d
ditorAnimator.java
indSectionView.java
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 21ed0017276842626eae6cf40be4c32bc311e724 |
25-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Merge "Contact-editor now immediately shows proper editor for new fields."
|
| ba69014263332f2056263cddc41cc6d7cfd7b7ca |
23-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Fix empty contact
Bug:6023712
Change-Id: I0437eb5a010b392b840795d16d5b03411394b3ef
ontactEditorFragment.java
|
| f30723782e801deaf159aea2443e9507596ef11d |
23-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't re-use the SaveMode in the group editor anymore.
As we only ever use SaveMode.CLOSE, I decided to remove this entirely.
We don't support re-loading at the moment, so it seems wrong to have
code in there that pretends to be able to do it.
Also I cleaned up some Eclipse warnings, so that the side-bar has fewer
yellow lines
Change-Id: I263b716c2edc98682bd5f5d1bc2b18ede15d7ced
ontactEditorFragment.java
|
| 67713b3e6e3af70020350e2650738389f19c073e |
22-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Turn off Spinner's state management. It kicks in after our own management
Bug:6047012
Change-Id: I8019f25b194e7edf7d2cd61c679c9622d93418ff
abeledEditorView.java
|
| 28eadab78531e22a0d9fa22fbbcd61c451005890 |
22-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Fix bugs in hi-res contact support.
Serialize updated photos and restore them upon device rotation; this
addresses bug 5999990.
Also, be sure to clear updated-photo entry when the user chooses
to remove the photo; otherwise it will still be saved when the user
exits the ContactEditorFragment via Back/"Done". This wasn't yet
reported as a bug.
Bug: 5999990
Change-Id: I9a01d4b9e40fec0e764156271a292588ed1b7154
ontactEditorFragment.java
|
| 26918da1650c1ff7b6f92deb978ab976525c811a |
03-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Contact-editor now immediately shows proper editor for new fields.
Previously, when adding a new field via "Add new" or "Add another
field", an empty field appeared, but the user couldn't edit its
contents without first tapping on it. Now the approperiate editor
UI pops up immediately (eg: when you add a new "event", a date-picker
pops up).
Bug: 5070818
Change-Id: I882a8202a6a76f73f3efd24734b0e0acdbcecac0
ditor.java
ventFieldEditorView.java
indSectionView.java
hotoEditorView.java
extFieldsEditorView.java
|
| 816f682c396282f2107dd4fad77dbacd157381da |
01-Feb-2012 |
Makoto Onuki <omakoto@google.com> |
Merge "Fix proguard flags"
|
| a0290a4baab4297303cab3664c7abfd548f2e301 |
27-Jan-2012 |
Makoto Onuki <omakoto@google.com> |
Fix proguard flags
Removed problematic *ForTest and use NeededForTesting instead.
Change-Id: I61517b6ea30da2461f541ceca19f04f24f8624da
ontactEditorUtils.java
|
| e692e010ca02200087997280e7c239ebf94aa8f9 |
18-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Support for high-resolution contact photos.
Rather than getting a bitmap directly from the gallery app, with
this change we create a temporary file and request that the photo
be stored there. This avoids running into bundle size limits when
passing large, uncompressed bitmaps back from the gallery.
After reading the photo out into the Contacts app, we use the
openAssetFile API to stream the large photo data into the
Contacts Provider. Note that we do this rather than having Gallery
write directly to the provider because we have no guarantee that
the Gallery (or substitute) app has WRITE_CONTACTS permission.
In the Contact Editor, the image is not permanently stored until
the contact is saved. This avoids needing special logic to handle
the case where the contact is newly-created.
Fix bug 5907233 en passant... the vestiges of some partially-
expunged code were causing the ContentEditorFragment to not
apply a selected photo.
Bug: 5786849
Bug: 5907233
Change-Id: Ic0cabaa50c08d6a9a0b730698c92f4092192438a
ontactEditorFragment.java
hotoEditorView.java
|
| ced983d7a816256d93fdea1f81e63e4598c18875 |
10-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Better wording when choosing photo from PhotoSelectionActivity.
When there is already a photo for a contact, "Take photo" and
"Select photo from Gallery" don't sound as good as "Take new photo"
and "Select new photo from Gallery".
Bug: 5738108
Change-Id: I43e13774079695b0ecebc5d67576e2ea831706a0
ontactEditorFragment.java
hotoActionPopup.java
|
| 93a0025b87079e0d36431a2c096f96e145053a28 |
12-Jan-2012 |
Makoto Onuki <omakoto@google.com> |
Fix for crash in contact card with null group name
Also supress showing "null" on the group editor.
Bug 5698683
Bug 5847463
Change-Id: I25bf497e719e2beed4fac32a2913a65022fe8fc7
roupMembershipView.java
|
| e55faef88185628c842e0aa778d883f209323630 |
07-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix suggestions box being 1 character behind
In contact editor, the aggregation suggestions is
1 character behind because the ValuesDelta sent to
the AggergationSuggestionEngine contains a structured
name that is not fully synced with the display name.
The solution is to wait for the structured +
unstructured names to be synced before sending it
to the suggestion engine.
Bug: 5507256
Change-Id: I5f9b6da40ef7843a3b67dc9deaa2af3cbb68c477
abeledEditorView.java
tructuredNameEditorView.java
|
| 251f9aa8320964d8d9c9df4e9cdddde903765449 |
07-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
am 5b39b5c3: Merge "Fix phonetic names not being saved for Exchange contacts" into ics-mr1
* commit '5b39b5c38445e0b806e5dc63a2a2a5365bf339f6':
Fix phonetic names not being saved for Exchange contacts
|
| abe272e29bd164a4c3b50d7bb6ce8dd9ff5f02be |
06-Dec-2011 |
Josh Gargus <jjosh@google.com> |
Merge "Avoid "Add New" button following the empty date field in new contact."
|
| 223dea3e59ebd7ec41db5583a9c911d2298e8dc4 |
06-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix phonetic names not being saved for Exchange contacts
If the phonetic name does not have a short/long form
(i.e. an expansion button), then we need to call into the
superclass onFieldChanged() method as we did previous to
this CL: https://android-git.corp.google.com/g/#/c/150242/
Bug: 5703655
Change-Id: Ibb0545ab96a104457e09ee227f05aa34290a343c
honeticNameEditorView.java
|
| 260934d4a79c5749bd71a1d9e3191c44fc20c3c6 |
06-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
am 0af02581: Fix keyboard navigation between editable text fields
* commit '0af02581eecabbe234e54364bdbbd65090518d7c':
Fix keyboard navigation between editable text fields
|
| 0af02581eecabbe234e54364bdbbd65090518d7c |
06-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix keyboard navigation between editable text fields
In the contact editor, currently keyboard navigation
between editable text fields is broken. By setting
the IME options flag, the "next" button will be
offered in the IME when the user is in an editable
text field.
Bug: 5599728
Change-Id: I5eb74455148c1f58f9fba8ece2c5089d9fdc6bf3
extFieldsEditorView.java
|
| 296cca5522815fc51829203d326c335f9824f118 |
02-Dec-2011 |
Josh Gargus <jjosh@google.com> |
Avoid "Add New" button following the empty date field in new contact.
EventFieldEditorView.isEmpty() has two issues. First, it doesn't deal
properly with the placeholder text in the empty date field. Second,
it queries the text from the text field instead of from the edit-field
(i.e. from the view rather than from the model). The latter leads to a
problem when isEmpty() is called before the text-field's value has been
set. Both of these are now fixed.
Bug: 5265651
Change-Id: I8cf1a66ddfbeaca04211e227a20640556fb095b9
ventFieldEditorView.java
|
| cdba96c52b6da4a3d7b6e97f619c1281490912e7 |
30-Nov-2011 |
Josh Gargus <jjosh@google.com> |
Merge "Hide "add field" button when it's unnecessary."
|
| 6fa7384a1a5576ace18159de61af91c8b7c34dc6 |
28-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Allow adding/replacing a photo from contact card.
This involves a large refactoring of the photo handling code that
previously lived in ContactEditorFragment. The bulk of that logic
has been extracted out into PhotoSelectionHandler and
PhotoSelectionActivity classes.
As part of this change, also removed the selection highlighting when
tapping on the current tab header in multi-tab views.
Bug 5294297
Bug 5379389
Change-Id: Ic929e4b4a730d91f768a34367bb76967228ded17
ontactEditorFragment.java
hotoActionPopup.java
|
| 6ad4c72b65e752777ca9288b006f82eefa715b57 |
22-Nov-2011 |
Josh Gargus <jjosh@google.com> |
Hide "add field" button when it's unnecessary.
Modify RawContactEditorView to remove the "add field" button
when no more fields-types can be added, and replaces it if all
fields of a type are deleted. Adjust layout so that there is
still a margin even after the button is hidden.
Bug: 5104493
Change-Id: I50fb61ba9c5d212a1ceb67938d3d833aace987f1
awContactEditorView.java
|
| 19d8f4a836a835eb62e7e597cbeff19114016107 |
23-Nov-2011 |
Adam Powell <adamp@google.com> |
am eb765ac7: Fix bug 5494702 - Text editing options not visible in custom label dialog
* commit 'eb765ac75178eccf5a44a3410e21a7f88419fd84':
Fix bug 5494702 - Text editing options not visible in custom label dialog
|
| eb765ac75178eccf5a44a3410e21a7f88419fd84 |
22-Nov-2011 |
Adam Powell <adamp@google.com> |
Fix bug 5494702 - Text editing options not visible in custom label dialog
Use the correct context for creating the EditText field for use in the
custom label dialog.
Change-Id: I8c82fe53f0813aeed118c834eb208cb338fcbabb
abeledEditorView.java
|
| 7cdbe5c0b11acb6128974f593b4ede86b01f95b2 |
22-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Remove titles in simple confirmation dialogs
Bug: 5476234
Change-Id: I7970c3378860e3521b55d248968a4710d8161c04
ontactEditorFragment.java
|
| 1a7f42494dbde3c268bc0763ebd62d55d43027ae |
16-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix preservation of phonetic name on device rotation in contact editor
This fix is similar to the fix for preserving structured names
on device rotation. I644bfea2af4e759e1d7d94aa09840ed15efd079d
We basically detect whether fields are visible or not before
trying to update the underlying name.
Bug: 5600858
Change-Id: Ic455cc87fa2872441b5d2a0e7da67ffc1798ec3d
honeticNameEditorView.java
|
| d85b98628ad7434d51b4bbf7c92b41917fd234e7 |
26-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add overscroll effect to all lists
- Add list view style with overscroll = always to
all activity themes
Bug: 5279577
Change-Id: I091c9d316f2d78a41836a95a06fd56705be7150b
roupMembershipView.java
|
| 50a27b70581b0191995969c63edd1f6a3db3d1b7 |
07-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up account definition
Removed:
- DataKind.isList. Use typeOverallMax = 1 instead
- DataKind.textAppearanceResourceId. Always use medium
- EditField.isFullName. Wasn't used.
Bug 5381810
Change-Id: I5ff109c075a5edb80ff97737432c78589570a1ea
indSectionView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 131e6ac666868645b48ae6932575d85751ff57c0 |
05-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Ensure not to use "local" account when there are accounts
Bug 5409438
Change-Id: I30e72bb686ed0ccbd9c7c42d4331c4ce418efdc4
ontactEditorUtils.java
|
| 56e5d9f9f11bd188bbb577d9cb7e1919708410d9 |
05-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Merge "SelectAccountDialogFragment: Handle orientation changes"
|
| 2621c5bb7049401c8bce740005fa60bf1b304b86 |
03-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
ContactLoader: set requested URI to error/not found result
- Now both the "error" and "not found" results have the requested URI.
- NOT_FOUND is no longer a singleton; there's now "isNotFound()" method
in accordance with isError().
Bug 5350017
Bug 5201346
Change-Id: Icb9080d3885ea2217e73a59db3825984746c3eb3
ontactEditorFragment.java
|
| 52d5545e61a2410df979eff4fc8f9f566b263799 |
29-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Merge "Avoid showing error if contact removed on save."
|
| 36d24d7ede42a252c82c4aa783b2231c5e2eea79 |
26-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Avoid showing error if contact removed on save.
Because removing all data from a local contact can actually cause
the raw contact and contact to be deleted, we need to track that
case so that the caller does not consider the lack of a lookup
URI to be an error.
Also made "Me" header all-caps for no-profile case.
Bug 5346614
Bug 5354364
Change-Id: If1e1d67da9c14eb8782be05b2e39ece19b5ac026
ontactEditorFragment.java
|
| 77c20e8355e5bcd3f1106b87abc2b6d582f9b0bf |
28-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
SelectAccountDialogFragment: Handle orientation changes
- Put all parameters to the argument Bundle, so they won't be lost
on orientation changes.
- Removed the subdialog in ImportExportDialogFragment, which used
the argument Bundle for a different purpose. Now we put the
information needed to ImportExportDialogFragment as a sub Bundle
in the argument Bundle.
Tested all 3 uses:
- "Add new group"
- "Copy to my contacts" (Couldn't configure my device to show this dialog,
so I had to apply a local patch to test this part.)
- "Import from SD" "Import from SIM".
Also made sure other features on "Export/Import" still work, except for
pre-existing bug 5387545.
Bug 5382646
Bug 5369853
Change-Id: If7f75ee8192889dbe484874c52e1a355d6b35c6c
electAccountDialogFragment.java
|
| 6f74c0f3313cbb08ee8a8fbb79bfefc5b03fe215 |
27-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Fix account list for group editing (for master)
- Don't use contact writable account list to populate the
account picker when creating new groups, instead check for
isGroupMembershipEditable() on the account type
- Repeat the same for determining whether the "new group"
button should appear in the PeopleActivity or not
Bug: 5360120
Change-Id: Ifd2fd1cf4ea7bf02d4dcba3e9c023bd7041fab83
Original-Id: Ia1ec62eff3fe4fd5b495548218c58f238ff49788
ontactEditorFragment.java
electAccountDialogFragment.java
|
| 0afe4203bd3d2b85fc272a34700e5cdefebe3d2d |
27-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Merge "New editor flow (for master)"
|
| 1289d903e860073da571636969e9b26a08649437 |
27-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
am 7805b032: Merge "Prevent activity leak which was introduced in Ifb86c931" into ics-factoryrom
* commit '7805b03239813a4a3627ba9d66774c40c627fba8':
Prevent activity leak which was introduced in Ifb86c931
|
| 0353a24d97cc0266eb9bf0ee6c7d6821aeb1896e |
23-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
New editor flow (for master)
- Added dialog-themed activity that pops up on new contact creation
in 3 cases with a variation of message when there are:
* 0 writable accounts on the device
* 1 writable account
* 2+ writable accounts
- The dialog is displayed whenever a new account is added
to the device or the default account has been removed
- Once an account selection has been made by the user,
we store it in SharedPreferences using ContactEditorUtils
- Slight restyling of the account list adapter
Bug: 5355671
Original CL: Ib3343a5aea972b366a9df41b9419ad9561c2243d
Change-Id: I46f4c5687a5b6eaa68b55a568f0d737ad80dfc5c
ontactEditorFragment.java
|
| 42342a7e91b5076bc222802379e12b56272ca366 |
26-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Prevent activity leak which was introduced in Ifb86c931
Don't store the passed context directly, but use the app context.
Bug 5355671
Change-Id: I7cd4f4d1ee4d9364ae34407718125f65cdf67129
ontactEditorUtils.java
|
| a2aaa65357cf088ae25a9d58a4dba976ff904451 |
26-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
am 64d95bae: Merge "Utility methods for new contact editor flow" into ics-factoryrom
* commit '64d95bae817be522e576ece311fa17d88a4c627c':
Utility methods for new contact editor flow
|
| 558669dab4109afebd19eade1f95a396215fb44d |
23-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Utility methods for new contact editor flow
- shouldShowAccountChangedNotification() to see if we need to show the dialog.
- saveDefaultAndAllAccounts() should be called when saving a newly created
contact, with the account used to save it. This saves all writable accounts
and the default accounts to the preferences.
- getDefaultAccount() to get the default account.
- createAddWritableAccontIntent() to launch the account setup wizard.
- getCreatedAccount() to interpret the result from the wizard.
- Also implemented Parcelable for AccountWithDataSet, so now it can be
put in a Bundle.
Bug 5355671
Change-Id: Ifb86c931b43fa307b65756cf24cbef4350374c67
ontactEditorUtils.java
|
| c5597d5d722f723f12172599b4fc69f42b496df8 |
24-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Fix name editor data loss on rotation"
|
| 2b3ee0f34801444c7d775ce747125459f69712bb |
22-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Make third party sync adapters editable
- Already merged in factory rom branch under
https://android-git.corp.google.com/g/#/c/136996/
but marked as do not merge, so we submit it
here manually
Bug:3093621
Change-Id: If3bb34f7d29bea4bd873342232bea3c1a77bcd2a
ontactEditorFragment.java
xternalRawContactEditorView.java
awContactReadOnlyEditorView.java
|
| b05466a9349441e79fb12d60abdf669168b59593 |
22-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix name editor data loss on rotation
Bug: 5290661 Edited name for a contact not saved
When the contact editor was recreated on screen rotation the
data on the name editor was updated incorrectly.
The problem was that a change to any of the fields in the name editor
was erasing the other fields. Instead of erasing the other fields, i changed
the code to sync between the display name and structured name so that on
rotation, the data is correctly stored and retrieved.
Change-Id: I644bfea2af4e759e1d7d94aa09840ed15efd079d
tructuredNameEditorView.java
|
| 38959cf5b4689d4cdb35f037b1aab0e5e9c42a3d |
22-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
DO NOT MERGE Make third party sync adapters editable
Bug:3093621
Change-Id: If3bb34f7d29bea4bd873342232bea3c1a77bcd2a
ontactEditorFragment.java
xternalRawContactEditorView.java
awContactReadOnlyEditorView.java
|
| 64593b9772fccbbd0f4154dabc830e6f9b154dec |
22-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
am 96e87fd6: Use existence of editor as indicator whether source is editable.
* commit '96e87fd6e808e9d853263ffeb5104f3253a18639':
Use existence of editor as indicator whether source is editable.
|
| 96e87fd6e808e9d853263ffeb5104f3253a18639 |
21-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use existence of editor as indicator whether source is editable.
Bug:3093621
Change-Id: I3ba344667ce1b0f2da6847d783c0ac90f36ebd8f
ggregationSuggestionView.java
ontactEditorFragment.java
xternalRawContactEditorView.java
|
| 2ea2ebbd23320f09ed38bf22d053842cc244646c |
15-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Account header icon cut off in contact editor for local contacts
Bug: 5298440
Change-Id: I9dfe60ef1c2b81c96f9b785d734031839a62d758
xternalRawContactEditorView.java
awContactEditorView.java
|
| 3c6af944f1c2c64de3839809460b368b718a8f5a |
16-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Organization field should receive focus after selecting "Add organization"
- This is for the contact editor
Bug: 5159041
Change-Id: I75a2034df4c35a5414cbbe6785dc40b6faf21d15
awContactEditorView.java
|
| ecfc26c3f9495f1a4efed69a1582ff2b0deb2c71 |
13-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
New avatars
Bug:5074147
Change-Id: I583d22c63a7b617567c523efeed292ae1e2be7e4
ggregationSuggestionView.java
hotoEditorView.java
|
| 3252f4fab6c137a86ec7e04e64a614031c44da39 |
08-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Allow local profile editing with an existing profile"
|
| 48ed982e078de00f6be49319ccf09bbb2aaadf5e |
07-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Allow local profile editing with an existing profile
Bug: 5244792 Can not create local offline profile if
Google+ profile has already been synced in
Change-Id: Icb818098588f27bab54515d8a554fe77a08569ca
ontactEditorFragment.java
|
| 507d85177886bece6ac38870d0e4b6c4655abc55 |
08-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix misc font sizes and spacing issues
- Make contact name and status more closely spaced together
(vertically), which also helps the status to still be visible
in the extra large font accessibility case
- Use our own version of the select_dialog_item.xml so that
long dialog items (i.e. "Select photo from Gallery")
do not get cut-off on the phone (Framework can't change
the font size in their XML because it's public API)
Bug: 5255619
Change-Id: Ica6ba908b0cb143550e9cf7391524449008b20cb
hotoActionPopup.java
|
| 9db59fe67d9f2624120c718499a74eab7fea3c03 |
06-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Alignment tweaks in contact editor
- Multi-line address edit text field should now be
aligned with the spinner beside it
- Other misc alignment fixes
Bug: 5250070
Change-Id: I92b4b0d13cd1346227b95e7326a1c37ec68b066d
extFieldsEditorView.java
|
| 2d3b14ebe4421117d62b784cc37577e58c4d1a9b |
03-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix layout for read-only contacts
Bug: 5149895
Change-Id: I3c033e80bc3b34093f975641694ded291a1a96a5
xternalRawContactEditorView.java
|
| 68c03dc9166ef64d5d567835f2487e7e275fe4a2 |
02-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Fix contact editor account header"
|
| d525aee2dbea0e002f8e499b3ef1d42e503d0059 |
01-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Layout read-only contacts correctly
- remove unnecessary headers between multiple phones/emails
- modify the layout a bit
Bug: 5149895
Change-Id: I9bbccd8a68d2ffe3d0ed7bbbb8af0f93ffccc4f7
xternalRawContactEditorView.java
|
| 2cb71bd0d6096f48d9d8c6d66a753b164468abb2 |
01-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix contact editor account header
Bug: 5179920 Google+ profile should say "My Google+ profile"
Reverted default account type name changes
Flipped account name and type usage that was wrong
Vertically aligned the headers.
Change-Id: Icc279fcba5d426d1afaf32b59bec30ed5d739907
xternalRawContactEditorView.java
awContactEditorView.java
|
| ac76896f811ea35b842769cf037d577b942822f6 |
30-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Merge "Don't preload AsYouTypeFormatter"
|
| 7a8cb1c78a2841d09cdc614db83c5444b4b86c0a |
30-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Merge "Contact editor assets and redlines"
|
| b9e60280603f2fa57083c13952e4b25e2585b833 |
29-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Silently give up split action when mState is null
mState may be null if the Fragment is recreated (or in the other
strange state) by the system during split confirmation, which is
really rare for users (while it may happen during automated
testing). Avoid NPE and give up the save action silently.
Bug: 5220440
Change-Id: I40c9a29ef1f3c1a3913beb9f3a8022b00d297102
ontactEditorFragment.java
|
| e598332967106e3db63b73c701f21902d169efef |
27-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Don't preload AsYouTypeFormatter
- This took 200ms of startup time at least, and a lot more under heavy load,
especially when the flash is busy. (200ms is mostly disk I/O.)
- Instead, make sure we always use AsyncTask to create
PhoneNumberFormattingTextWatcher, which wass the only thing that uses
AsYouTypeFormatter.
- DialpadFragment already had an AsnycTask. Moved it to the new class UiUtils
and use it in TextFieldsEditorView, which is the only other callsite.
- Also improved the logging for account loading. We used to log only CPU
time, but what we really care is the actual wall time. Because
account loading involves a lot of file access (e.g. loading 3rd party
apks), only measuring CPU time is not too useful.
(In fact, on my phone, loading accounts takes only 50ms CPU time but
>500ms wall time.)
Bug 5195464
Change-Id: I2b51e864d75831bdbb9e424aa846133d49d6ef94
extFieldsEditorView.java
|
| a3e69af03dd35124941a48c3bfaea87468d66863 |
25-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor assets and redlines
Change-Id: I08c11dce7f07155a919fec9989587af5f11a3220
ontactEditorFragment.java
abeledEditorView.java
|
| 37bddc2fa266fa0378fcd85ac5047b1fb0af2dc0 |
10-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add contact detail to existing contact
- Works for phone numbers and email addresses, otherwise route
intent to full contact editor
- Contact card icon / "OK" button first saves the change and then goes
to the contact card
- Port over from GB branch, updated references to non-existent classes,
added new layout to look more like QuickContacts/contact tile,
applied to ContactSelectionActivity instead of contacts list,
added support for non-editable contacts, fix layout for phone
landscape and tablet, inflate the right editor layout based on the
DataKind instead of emedding a TextFieldEditorView
directly inside the XML, use AsyncTask instead of WeakAsyncTask
- Fixed NonPhoneActivity intent flags so that the activity results
will work correctly (will allow contact card to be launched if user
requested to do so and the cancel button in the ConfirmAddDetailActivity
returns the user to the picker)
- Fixed activity theme for NonPhoneActivity to not show a title bar
- For a contact made up of multiple raw contacts, find the first
editable contact to add it to (instead of always picking the first one
which could be non-editable).
Bug: 4295003
Change-Id: I111eaf6bbc78861c2b6a27c93086d00697869ebb
abeledEditorView.java
|
| 681f36cc7cc49be781eedc4685eda2d1b2c0444c |
26-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix header when editing a profile
Bug: 5179920 Google+ profile should say "My Google+ profile"
Added a case to change the header name when editing a profile.
The editor now gets a boolean indicating if the contact edited is a profile.
If it is a profile, the editor sets the header with "My X profile" according
to the account name.
Change-Id: I62af5011061f61a6d1d3c60845a1746c99cda04a
aseRawContactEditorView.java
ontactEditorFragment.java
xternalRawContactEditorView.java
awContactEditorView.java
|
| f9fa11c0867ec17742a1bc6b742d4a64a631962b |
26-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Don't print out bundle in ContactEditorFragment
On rotation change, we shouldn't print out the bundle because
it contains PII.
Bug: 5205563
Change-Id: I7965f4312a2769468ea17be6dadb7a988d46883a
ontactEditorFragment.java
|
| 9e7b5da669fcf92a6a627fb720749e5cb627684a |
23-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Propagate original exception when throwing load exception
Bug 5198078
Change-Id: I941dc9b96d6c58eb1912d446c3c27ec4c4c2ffef
ontactEditorFragment.java
|
| 2245870a1354df03512010e4968b144840894fb7 |
19-Aug-2011 |
Frank Sposaro <sposaro@google.com> |
Added new assets for contact editor.
Bug: 5070819
Change-Id: Id90fcf34a376f7d3d0a1dec3a0a76e4df4b5053c
ontactEditorFragment.java
|
| 05374affb551a2e3ad55a6d38f74d1463a3cd0e0 |
13-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix NPE in ExternalRawContactEditorView
state.getPrimaryEntry(StructureName.CONTENT_ITEM_TYPE) is
returning null (which is possible based on the javadoc
of the method). Hence, we need to do a null check, and
display a default name string if it is null.
Bug: 5114827
Change-Id: If9dcf7f324e9c54b6723bb6d6b5d1fd78ac2efd3
xternalRawContactEditorView.java
|
| 73fb1d01a718f8c92f1f653cf8f62f45ca244545 |
13-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Remove "suggested contacts" while editing profile"
|
| 2bbfae8f92d5c218c83a49621a4c8f98f4d7a394 |
12-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Remove "suggested contacts" while editing profile
Bug: 5155177 The "suggested contact" pop-up shouldn't
show up while editing a local profile
Added a check to remove the call to get suggestion when the contact
is the profile.
Did some cleanup and created a method for detecting if we editing
a user profile.
Change-Id: I54b3a009f9fe3dd5f899b8b903b6830e71835874
ontactEditorFragment.java
|
| 02a54ebd3185948e2c1c0f39b7718cb9abaea934 |
12-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Prevent monkey crash with aggregation suggestion popup
Bug 5153029
Change-Id: Ibcedddaf1d2b57e1399e483701fe76c50aec64dd
ontactEditorFragment.java
|
| 8ef558d147af3ea47fe67f2585fb24b97a2e1285 |
12-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Remove join/split buttons for profile"
|
| 1ba8b6fea4c3f82ded19305874e72a326612aed1 |
12-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Finish string changes
Bug: 5147284
Bug: 5144069
Bug: 5150725
Bug: 5149819
Bug: 5144900
Change-Id: Ib3495e1ef7847eb2c01d7609c1524024123c993c
ontactEditorFragment.java
|
| 9574314dd24a045761453b51244fa75a1da36f6e |
11-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
String changes
Bug: 5150725
Change-Id: I5b9cb06fe20db37f3d9af6a8e06b35277df3580f
ventFieldEditorView.java
roupMembershipView.java
|
| 03587ecd46c0a524f3cdc5ffd2959be2bc30bb34 |
11-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Remove join/split buttons for profile
Bug: 5149871 There should not be a way to Join/Split profiles
Change-Id: I4c7782d67f04fe494ed1825e631d2b8c1ae5810b
ontactEditorFragment.java
|
| 6c8c0777c823e2a2fef69299c0b36ca4a40e1fea |
08-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show popup for aggregation suggestion
- create ListPopupWindow instead of embedding Views into
the base layout.
- refrain AggregationSuggestionView from having focusable and
clickable capability, which will be automatically supplied from
ListView
- tweak layout xmls to show ListPopupWindow correctly. Include
some pixel-perfect designs
Bug: 5057400
Change-Id: I9ec8642c0864204747ee445da7ee0292171a8788
ggregationSuggestionView.java
ontactEditorFragment.java
|
| bec0e12648b7c90aab9eda5b2837faca2493e5c3 |
10-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Remove unused callback
Bug 5143491
Change-Id: I20b82551329f1beb05dc4039cf0d501fe9a9e676
ontactEditorFragment.java
|
| 4a855e176218fe39bf4b83585bc44c2d650c1a3c |
09-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Merge "Disable first name bolding"
|
| 599700fb0182a17435cc86137b5f8bd39b8581e2 |
09-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Disable first name bolding
... on
- Contact list
- Contact card
- Contact editor
Bug 5042741
Change-Id: Ife8d494c19e2daef7e59d819ded52638dc9f2b6f
extFieldsEditorView.java
|
| 1ebbd5bbe71814123b80df702b474bcd7196cbb7 |
05-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect for tablet contact editor
- Remove a bunch of files because now the tablet should
look like the phone layout
- Fix padding / margins
- Don't allow phonetic name to be deletable (it would
just clear the field) so that the structured name
and phonetic name now line up (UX decision)
- Make text in editable fields centered by
setting a specific height on the edit text field
if it's not multi-line text
Bug: 5096927
Change-Id: If5d27752d79680cd40316428c7aa9ec30af6e320
xternalRawContactEditorView.java
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| ead19c5eafee0ffb43b02a4ae75ac5244ad3f853 |
30-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Support for local profile
Bug: 5121834 Support local profile
5086184 Account name is overlapped by number of contacts
5082317 Text is chopped on the top in contact list
1. New headers were added at the top of the contact list to
present an empty local profile.
2. Clicking the empty local profile opens the editor to allow
the user to create a local profile.
3. Profiles are shown at the top of the contacts list with the
"ME" header and the number of contatcs.
4. "Add to contacts" button and the starred button were removed
from the details view when it is a profile.
5. Fixed a problem with a header view that remained when you had
a profile or was in search mode.
6. Fixed problem with contacts count apearing in search mode
Change-Id: I45615616e03a603759888d9e7169a853b3328b14
ontactEditorFragment.java
|
| fd70903236883f47b21f23b8cb49a1ccacdfcdf1 |
02-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect work for phone contact editor
- Always show account header for raw contacts
- Align text fields and titles along the left margin
- Align spinners
- Use "Add new" as the default text if there's no value
in Event or Groups field yet
- Restyle account header
- Use primary/secondary colors everywhere
- Non-editable contact fixes: remove "not editable on
this device" and replace it with a toast when the
user clicks on the header, restyle item_read_only_field
Bug: 5097095
Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
ontactEditorFragment.java
ventFieldEditorView.java
xternalRawContactEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
ggregationSuggestionEngine.java
ggregationSuggestionView.java
ontactEditorFragment.java
xternalRawContactEditorView.java
roupMembershipView.java
awContactEditorView.java
electAccountDialogFragment.java
|
| d96056c46dd7ef6f6ee4a252afbe7c5345ab6dae |
24-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Style external raw contacts editor
- For non-editable contacts on phone (no UX mocks for tablet)
- Move views around, change string / text color, remove dividers
- TODO: Make all data fields from that raw contact grayed out
Bug: 5070780
Change-Id: Ie799da2d148426dd7b1fbe2c76f0617ad2663f76
xternalRawContactEditorView.java
|
| 2293e55d550fbc9974d1185960715e59acb14a85 |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Clear field if try to delete last field in section of contact editor
- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor
Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
hotoActionPopup.java
hotoEditorView.java
extFieldsEditorView.java
|
| 398e3805b4278310250e5fd1007e2e73b9453d0f |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "Add new" strings in contact editor
- Instead of using type-specific strings like "Add new
phone number" just use "Add new" since we have labels
for kind sections now.
Change-Id: I0e386ae29330193fec18b62f3949c46e095a872c
indSectionView.java
|
| 9959f0c9a7ee91490ecc1f9023c0012855363fe8 |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "Modify action bar for contact editor"
|
| 6be61c5d351099f24904396e97d5954de7b771e1 |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "Default fields in contact editor"
|
| 41ce70d44d86b9d811e727b3bb4b44c137a189b6 |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "Organization field expands when tapped"
|
| 13cc7c59d540608a2f1c68be0a31a0560392e0ae |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Default fields in contact editor
- Remove website and notes as default fields that show when
you create a new contact
- Don't allow "Add another field" button to add fields for
sections that are already visible (i.e. if website section is
visible, then "website" won't show up in the popup menu)
- TODO: Handle the case where there are no more fields to
add, need mocks from UX
Change-Id: I3b0929ebf69c93b60220c75c0b00b72cf5b2aa83
ontactEditorFragment.java
awContactEditorView.java
|
| 9b3dfd0bc36568558bfdc32a5d4c30f2d0df5fed |
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Modify action bar for contact editor
- Use custom action bar for "Done" button (hide app icon and
get rid of "up" affordance")
- Move "Cancel" into the overflow menu and rename it to "Discard"
- Remove "delete" button from overflow menu in editor as specified
by the UX mocks b/c the user can delete the contact in the
contact card already
Change-Id: Ic389983a08a7b03fa24e7f4c1c37c95bd6c1c9fa
ontactEditorFragment.java
|
| a66642330b5c4a62c8b7ce438ccff57c3b017eb1 |
21-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Show more fields above the keyboard in contact editor
- For the phone
- Small visual fixes that will allow as many fields as
possible to be visible when the keyboard is up
* Smaller icons, fonts
* Change some colors
* Remove the "+" icon
* Make address field default to min height 1 line
instead of 3
Bug: 4382255
Change-Id: Icc665c866e4c1cfaa0ba8de7dae9a0c1cbd1b575
abeledEditorView.java
|
| 3fa75acf99f5245eae00c77086ff130b3552ceec |
21-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Organization field expands when tapped
- In order to show as many fields as possible on the
contact editor, we collapse the editor into a button
that only expands the EditText fields when tapped
(collapsing is not possible unless the user exits
the editor).
- Add an isEmpty() method on the KindSectionView
so we can distinguish between a contact with existing
organization info versus a contact who has an empty
organization field
Change-Id: Iff818c30422c96d1acf6a03cbbcfb6f17bfed106
indSectionView.java
awContactEditorView.java
|
| a94859f61c216d4e137a631995026d3ddefbbf70 |
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor fixes
- Bring back data kind titles
- "Delete" button should be invisible not gone
- Make field + spinner horizontally stacked instead of vertically
stacked on phone
- Don't show account header if editing an existing contact that
only consists of 1 raw contact
Change-Id: I7dd4bfdf273eeaccca8399d182c0a56a6e23a8c7
ontactEditorFragment.java
indSectionView.java
abeledEditorView.java
awContactEditorView.java
|
| 5649a12fe551855f00c8dbeacfc96511c2a5fb71 |
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Go to contact card after editing
- In PeopleActivity, get rid of startActivityForResult to launch editor
because the editor will take care of launching the
contact card itself (instead of relying on the PeopleActivity
in the tablet to reload the contact details)
Bug: 4769324
Change-Id: Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4
ontactEditorFragment.java
|
| 5e330ed98f1c2711b4cd3b375a1c0f76bedaf3e1 |
16-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Remove unnecessary delete buttons in contact editor
- Don't offer the delete button until the user has typed something
into the field
Change-Id: I37585565b77f3d6a06677341191bb0f0cc72e508
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
extFieldsEditorView.java
|
| a7c3d4d726b91f645431af14d8cceadd2245f4ce |
15-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Restyle contact editor header
- Move account switcher to top of editor
- Make account header always displayed (even on existing contacts)
- Take out hack for font size of structured name and just
make it text appearance large
- Align photo side by side the structured name
- Move over honeycomb style of group membership item over to
phone resouces folder
- Center "Add another field" button on the phone
Change-Id: I548edc3f1a2a0c20e83e4a28a10e110e51f8c12c
ontactEditorFragment.java
roupMembershipView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 0a2a5db3b3633883388953dc98e30c2edd7cae62 |
29-Jun-2011 |
Dave Santoro <dsantoro@google.com> |
Contacts App modifications for large photos.
Most of the work is on the provider side - essentially, the
provider will now deal with any size photo, downsizing it as
necessary to fit in a display size and thumbnail size. So
on the client we just need to pass in a larger photo to get a
hi-res display image for the contact.
Also switched a few spots to use the PHOTO_URI (with
openAssetFile) instead of PHOTO_THUMB_URI - more likely
remain.
Change-Id: I6ff8dd5453a9ff787907ab113d6e8aa6a71fcae1
ontactEditorFragment.java
|
| 623932de8c18e9b83b6fd941afe415ab2e6c730b |
09-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Fix NPE when joining contacts on the phone
Bug:4355323
Change-Id: I0183bfacaf430202234a96a8dbcb5e9949489a43
ontactEditorFragment.java
|
| 971116e466757434f4979a61d4f58ea0deac1ea4 |
05-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
New group disambiguation dialog
- Since switching accounts in the group editor is difficult
(i.e. we need to wipe all added group members when accounts
are switched), it's easier to just have an account disambig
dialog when you first create the group
- The disambig happens as a popupwindow anchored to the
action bar "New group" button if it's a wide screen
- Otherwise the disambig is a dialog that comes from
the GroupEditorFragment
Change-Id: Ibd75607b326e600c412f4bd04eb4cc72534aed72
electAccountDialogFragment.java
|
| c6b8afe730255537978f2c938cca6986cae63c34 |
23-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Group editor on tablet
- Allow autocomplete to add new members which presents
the user with suggestions from the raw_contacts table
with the same account name and type as the group
- Hook up the "new" and "edit" group buttons on the tablet
- Once the user exits the editor, update the group list
and scroll the group list to the group that was just edited
- Allow rename of groups (make the names of read-only groups
not editable)
- Allow removal of members
- Hook up the done / cancel / up / back buttons
- TODO: Be able to create a new group + add new members
in the same transaction. Then the new group editor
will allow adding members at the same time. Currently
you can only add a name to a new group. Once it's created,
then you can go and edit the membership.
- TODO: Bulk add/remove members in one transaction when the
user exits the editor. Currently it's saving the change
after you modify the membership list (even before you hit
the "Done" button in the editor).
- TODO: Add member status message and chat presence
- TODO: Add UI for non-editable groups
Change-Id: I1f32a28862c358b8bd1469666743cd240d28f80b
ontactEditorFragment.java
|
| 2aa09b9965fd22c4dd5536d0f576ac351a8eb00d |
29-Jun-2011 |
Frank Sposaro <sposaro@google.com> |
Fixed NPE Bug for joining Contacts on Tablet.
Bug: 4355323
Change-Id: Icb4802e0d2b67dc118818d98ea5e06d95dde3d25
ontactEditorFragment.java
|
| a6c8f2daa80f1816dd25237457d7f6287c6b1b7c |
15-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show the selected account first in account switcher
Bug: 4584712
Change-Id: Ib041d7aa3cca3fa8f5b4780eb7a76c5e41819b39
ontactEditorFragment.java
|
| be18de05d6f6a107c552e369bce58f51c946fde7 |
07-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add group detail fragment on tablet
- Add action bar on GroupDetailActivity, title, and subtitle
- Make everything use the groupUri instead of passing around
account name, type, group Id, and group title
- Fix some of the callback listeners between the group fragments
and group activities
- Add factory methods to ContactListFilter
Change-Id: I63066ea6eefde1e57562b6396d6dc590ed023c84
ontactEditorFragment.java
|
| 51e8d634f2d16aeaed73b6fba42d02a1c2d48b20 |
20-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Remove an unneeded function and an unused callback function
Change-Id: Icb01f50ad12d19a019da04bc27fa0d6f6ec04dfe
ontactEditorFragment.java
|
| 261cd5650d07fbc41ea8f19d4e422094612d1454 |
17-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Turn ImportExportInteraction into DialogFragment
Bug:3126133
Change-Id: I544d836b3c5d0e3c38352978d55a55e131885638
electAccountDialogFragment.java
|
| facb82e074712a3f94ac99b13c3a6ad4741fb46b |
12-May-2011 |
Dave Santoro <dsantoro@google.com> |
Merge "Modifications to bold contacts' first names."
|
| da5bf1cf60beef3de5e651a569fa544293683926 |
03-May-2011 |
Dave Santoro <dsantoro@google.com> |
Modifications to bold contacts' first names.
For lists and headers, this is calculated by using a similar technique as we
use in the list view for highlighting text when the sort order and display
order do not match - we look for the overlap point between the display name
and the alternate display name, and bold the leading or trailing part, based
on the display order.
For the edit view, we convert the display name into a structured name (via an
API extracted from the structured name editor code that calls into the provider
to handle splitting), and then bold the span corresponding to the contact's
given name.
This also fixes an issue with the alternate display order in which we weren't
honoring that preference on the contact details view.
Change-Id: I6af048725541996cb303810a56a1ad79fc276e11
tructuredNameEditorView.java
extFieldsEditorView.java
|
| 769e5fed7af619d538da66adb926eeccdc159cd9 |
11-May-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
UI fix for account selector
- don't show account info when there's just one account
- modify layout for account selector
Bug: 4184675
Change-Id: I7e5a9527a2bcb2406a1bc377b063bb262b8f12de
awContactEditorView.java
|
| d37a891cb44cd17083c06d7be693c469403d16df |
27-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Enable account switcher in contact creation
- remove account selection step before contact creation
- (phone) put account info on the right side of photos
instead of having "header" for it
-- renamed header_* ids for account stuffs as they may not be
part of header any more.
- add migration functionality to EntityModifier
- add test for it
- no optimal layout
Bug: 4184675
Change-Id: I0e777f9aa37a7c9145bd430f897f8068b0bede56
aseRawContactEditorView.java
ontactEditorFragment.java
ventFieldEditorView.java
xternalRawContactEditorView.java
honeticNameEditorView.java
awContactEditorView.java
tructuredNameEditorView.java
|
| a2d4a9652fb4db9ee222abc7a637366c6c50427c |
07-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix font sizing and spacing in editor
- Remove name labels
- Remove extra divideres
Bug:4382255
Change-Id: I59c5b91e699b7386690e6df58e58b247d3086c99
abeledEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 12a93637e406ba7f3da4db8d53cd035c2c1d6e6e |
05-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pressed state for buttons
- Delete button, expansion button, fix padding on messaging icon
Bug: 4382255
Change-Id: I5ef0a9ee760a095b4f9e0efda71c13c4b89328e6
abeledEditorView.java
extFieldsEditorView.java
|
| 2591436971bad3050c85929c8e0c5a8d48111f88 |
30-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "add field" logic
- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string
Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
ditor.java
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
hotoEditorView.java
extFieldsEditorView.java
|
| 1b22073590c1801c3e6c7bde2f4636632a049f6c |
29-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
"Add field" footer logic
- Instead of an explicit "+" button to add a new field (which
also allows adding multiple empty fields), only show a
"add field" footer to the KindSectionView if there are no
existing empty fields in the section.
- Make the whole footer a touch target and display a
custom message according to the DataKind mime type
Bug: 4363151
Change-Id: Ib7cef5ed5aaefa5b1269f95ed8fe89e7dd742f36
ditor.java
ventFieldEditorView.java
indSectionView.java
hotoEditorView.java
extFieldsEditorView.java
|
| 63ffb90935d8aec295e4a8f62af6c77dafe1899f |
27-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Refactor to inflate views from XML
- This is part 1 of getting the contact editor up to par with
the UI mocks, there are some known issues that will be fixed
in coming CLs (i.e. add button functionality)
- This way, the field editors can be vertically stacked
on the phone and horizontally stacked on the tablet.
- Get rid of duplicate labels by using the hint text in the field
or spinner as the title
Change-Id: Ia00a1a65ad0bbd7a4bc05ccb93dd1b1496bca5df
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
extFieldsEditorView.java
|
| d8e0049c4c05a55b41566e3f53d38e877a8d71d2 |
26-Apr-2011 |
Dave Santoro <dsantoro@google.com> |
Move the more-or-less button if needed.
For Exchange contacts, the more-or-less button for the address field would
overlap the delete button, making it impossible to specify a country. This
changes that logic to shunt down the move-or-less button if delete is present.
Bug 4195633.
Change-Id: I52c5be56ed51baa010026b710815f0fbfdbd9ebf
extFieldsEditorView.java
|
| e61c64a0455e6073bb4ea35631a2404ef693840f |
31-Mar-2011 |
Daniel Lehmann <lehmannd@google.com> |
am 0a8f9e9a: am a10775d6: Don\'t save the contact if the user accepts an edit-suggestion
* commit '0a8f9e9ac4b56ac3a790bf0c5fd2419611d98cc6':
Don't save the contact if the user accepts an edit-suggestion
|
| a10775d625339d168337e03de05d02f5e0a4f55d |
31-Mar-2011 |
Daniel Lehmann <lehmannd@google.com> |
Don't save the contact if the user accepts an edit-suggestion
Bug:4194346
Change-Id: I51afcea7e92ac3d2e595a72920dd4dbb59267912
ontactEditorFragment.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
ditor.java
ventFieldEditorView.java
xternalRawContactEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
honeticNameEditorView.java
hotoEditorView.java
awContactEditorView.java
tructuredNameEditorView.java
extFieldsEditorView.java
iewIdGenerator.java
|
| 60b239c24c05233bbf3f7cb45697252e15ec76cc |
08-Mar-2011 |
Daniel Lehmann <lehmannd@google.com> |
Treat empty and null strings equally. Fixes a data loss on e.g. rotation
Additionally, this will prevent the editor from going into a dirty state
on open, so pressing "Done" will not cause a save anymore if nothing has
changed
Bug:4027153
Change-Id: I0f55b75356b498588a53ad0bc91afaec3ed9434c
abeledEditorView.java
|
| 4b648485346462dc26c3a469caeae8589f5fbd58 |
04-Mar-2011 |
Daniel Lehmann <lehmannd@google.com> |
Set time zone on date formats.
Also fix Locale to use en-US for storing dates
Bug:3502565
Change-Id: Id3728de2d2f2c77ad1f27e6acbd71a91d840b3a6
ventFieldEditorView.java
|
| 1e2a0333712ed2d2cbfac633d2696e5e4572b6fb |
03-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Merge "Modernizing phonetic name support"
|
| 5ec40b04041818bc042c0671cb1a43b54f650e25 |
02-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Modernizing phonetic name support
Bug: 3497894
Change-Id: I5aaa77275bbe1921af2d7ef034d2319691f8abf7
ontactEditorFragment.java
honeticNameEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| c76c2e872b4d8deb0e8ac26e9558fa360d525fde |
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in contact editor
Bug: 3499233
Change-Id: I3dc95c4d1e16b9d764bd50a937a58c9401be07ab
ontactEditorFragment.java
|
| 83cc117f09934ab275419bc5ffc8c60a16a28fc3 |
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Using the right class loader for unmarshalling
Bug: 3497767
Change-Id: I68d54f07cd4e65843e90f8f819212798df018acd
tructuredNameEditorView.java
|
| c77f48947093d5f84b7df661a29b8b45d573cc10 |
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing parsing of intent extras for Exchange contacts
Bug: 2969875
Change-Id: Ifd7f1ba2e794ebf24626c53e5ed3a14ae9adc791
tructuredNameEditorView.java
|
| 11bb73bcdf4290ced99e3e06b1f76d4c37357aea |
26-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving name structured on expand/collapse operations
If the user does not change components of the structured
name, the expand and collapse operations in the editor
should not reparse or re-compose the name.
Bug: 3473362
Change-Id: I4fe5f0d06757b2fe098a5bd895c84108195049e9
ontactEditorFragment.java
abeledEditorView.java
tructuredNameEditorView.java
|
| eeb68a341734ded343004d4eecb585420e70605b |
25-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Posting focus request after adding a new field in the contact editor.
Also, making the contact name selected on the activity start
Bug: 3403046
Change-Id: Ic6baf9d4404237d62bca3cdabc41a14422236a3c
ontactEditorFragment.java
indSectionView.java
|
| c863b0171f2a54a0ee71b34b33034aeea2464cca |
25-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Remove confirmation dialog when cancel empty new contact
Bug: 3487518
Change-Id: I3d47b9249efd634e2ce21e6fbea19fe68f3d3ccd
ontactEditorFragment.java
|
| ce37f3017c666bcea483a75322e80d5cc1ba6f64 |
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving editor status on rotation
Bug: 3452739
Change-Id: I9127ad4b37ff2a50123cde5b4e3ae8b4021e14e9
ontactEditorFragment.java
|
| f9ca423c867ab2cd4f0d9025a95436489c41d405 |
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Simplifying status management when launching subactivities
Bug: 3460703
Change-Id: Ibeabe952b5f22f0ac9de0d0f770284535a847d62
ontactEditorFragment.java
|
| cd1b9a29458d30ec74cf94dc9945cbdb6186a68e |
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing NPE in aggregation suggestion UI
Bug: 3438193
Change-Id: I0a30d99339268e388d310720b52137022a3a44fe
ontactEditorFragment.java
|
| a9333790f027d59a2edfd4a98c0392b144577416 |
15-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Disabling aggregation suggestions while contact is being saved
Bug: 3457627
Change-Id: Id3bce3540ca83166a9c4f795c9b4aeab07d7c8ae
ggregationSuggestionView.java
ontactEditorFragment.java
|
| a011414b12955a91c8f3efe528f374654d930098 |
15-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Moving contact saving to the service
Bug: 3220304
Bug: 3452739
Change-Id: If4124096a24e5dd302feb5338efaaa8398b2cb6b
ontactEditorFragment.java
|
| 832dc0e2d0f91a28166ea51a068ebaf339e09e0d |
14-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing display of the photo action menu
Bug: 3291482
Change-Id: I61c89542541ffcdfa0efe1235b7efdb2dd1b3c44
hotoActionPopup.java
|
| 62bab31374dd66462643cbc04ebb2acece4b9b39 |
30-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing handling of single-item data kinds.
The bug was that if we had an existing row
for a single-item kind like nickname,
but that row was empty and therefore invisible,
we would allow the UI to create another,
visible row.
The fix finds that invisible row if it exists
and makes it visible thus eliminating duplication.
Bug: 3334481
Change-Id: Ic639e5ae42b485fe6830078e5043a4f10b757086
indSectionView.java
|
| 248fba273e867616b1f8973dac6ce3e5ee1ba544 |
27-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE on attaching a photo in portrait mode
Bug: 3395746
Change-Id: I631276d4777fa7ffba76ebfb87939c07c066810e
ontactEditorFragment.java
|
| 2b95e624bc35851987fb621091f20263d635d31a |
25-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing group membership item hight to 48dip
Bug: 3383867
Change-Id: Ie849084ecaf1b9c5ddb11d6313a284963511660f
roupMembershipView.java
|
| c69a9ccb6c6440127f75b51aca123afa6946474a |
24-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making Event and Group selectors look like spinners
Bug: 3383800
Change-Id: Ie460cc5d2b80dbedd962f5bf24d2ae389bdf0268
ventFieldEditorView.java
|
| 5035feeb1eaa72cfcf083e7d22d859a8ca64ebe5 |
24-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Merge "Adjusting padding and fonts in contact detail" into honeycomb
|
| ba3c2e541b17bc68ff86ed402e7ee2c0a84f7d80 |
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adjusting padding and fonts in contact detail
Change-Id: Ia7d2a01e72c38a6aa9e7a72ef380c7b5fcf149f2
roupMembershipView.java
indSectionView.java
|
| 4292dfa46123a6c0e1de9862b4d8694bfb87875a |
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing alert dialog icon.
Also fixing selector in the contact editor.
Bug: 3377396
Change-Id: I34ca2e419158fe7869ffda4679ea60fa3c5fdb00
ontactEditorFragment.java
plitContactConfirmationDialogFragment.java
|
| b18624f0cbca15e6a515316f7046ad814d54c970 |
22-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing horizontal dividers in contact editor.
Also, moving name editor up and changing
name editor font size.
Bug: 3378205
Change-Id: I3a0457d3e2e231fb58e4d46065ff8b4b692d5626
aseRawContactEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 300835057b93255412059f236b4df59c706091ed |
21-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in contact aggregation suggestions
Bug: 3374369
Change-Id: I09e387e93673ce8e767f6c0ede4e279c6fe97733
ontactEditorFragment.java
|
| 135b44c8604e375699e22594e65f0daec14f5bbe |
19-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing event and group membership from TextEdit to Button
Bug: 3362537
Change-Id: I262bb546f03a7ce40c681e0f0077f97508359a21
ventFieldEditorView.java
roupMembershipView.java
|
| dd0dee6c55ea83d541b28e90cd4ad87ffd026f68 |
19-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Treating Join request as a regular save/reload.
Bug: 3362504
Change-Id: I5b5d97ed07c25e3a349d47b812efeb113d52a685
ontactEditorFragment.java
|
| 150cf5d82bf8655fbd6934d98c4a8f374e429fb9 |
14-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in ContactEditorFragment
Bug: 3351000
Change-Id: I4c16d6e4b1e6c40caca7b94c5a4ea9e4e060e2ba
ontactEditorFragment.java
|
| a07fa5f37031e4c5cd2933de02d2db41ec153e2b |
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming AccountTypes to AccountTypeManager.
The intent is to turn it into a "system service" of sorts.
Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
ggregationSuggestionView.java
ontactEditorFragment.java
|
| b77be6d2ad06edfd8751f55043e4aa9fd9f36015 |
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing inflation levels from AccountType.
Also, fixing asynchronous update and concurrency issues.
Bug: 3140873
Change-Id: Ie9d342d23ee4a8d23405ef4145c54d7673b2cbe9
ggregationSuggestionView.java
ontactEditorFragment.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
ggregationSuggestionView.java
ontactEditorFragment.java
xternalRawContactEditorView.java
awContactEditorView.java
|
| cb08f1b2a3f2e6e21aa5d993cf44d04658316ccc |
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving custom dialog state on rotation
Bug: 3263726
Change-Id: I79ff83dfa79ad469ee6897774f1f21aebe5e0c68
abeledEditorView.java
|
| 2b3f95cc12b76523410782d4178562ce241410ef |
03-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding support for (some of) ISO 8601 date formats
Bug: 3293435
Change-Id: I1925040b92895bc8c721f18d75f22329d0ba0ac8
ventFieldEditorView.java
|
| 17e6f9d6c0dab8bb02f4f7e2f9f43f8b8449f55a |
03-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE on switching from Birthday to Anniversary event type
The code is trying to ensure that a year is provided
(which is not required for a birthday). The value
may be null or an empty string.
Bug: 3314819
Change-Id: If76731316e581addeeca9427adcf204eec7e5199
ventFieldEditorView.java
|
| fff6f07a02d3e3bbeff2ecf94a703782b71aea66 |
22-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding support for 3rd party contact editing
Change-Id: I0379f7392a23aea68d0f59a9869bb72275f5bddb
ontactEditorFragment.java
xternalRawContactEditorView.java
eadOnlyRawContactEditorView.java
|
| 73a45b4ad96b21f468dbacde0da213d190979835 |
21-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE on join contact activity.
The monkey hit Menu=>Join and then quickly Back.
By the time the async task was done and we were
ready to start the join activity, the editor activity
was already closed.
Bug: 3299389
Change-Id: Ib98f2dc9e815a123636f85972888f3b571841015
ontactEditorFragment.java
|
| 9d2bcfb40d0ee107886eb99eba13a840e944ba43 |
20-Dec-2010 |
Dianne Hackborn <hackbod@google.com> |
Update to new Loader APIs.
Change-Id: I4be23901304890e1d0237d81e6cfb3889d5b6591
ontactEditorFragment.java
|
| 4ef95cc3329b4ad9fa450e4090efaad9935d493f |
16-Dec-2010 |
Dianne Hackborn <hackbod@google.com> |
Prepare for some changes to LoaderManager/Loader.
Sorry it is a bit ugly, it is to allow this change to be
checked in prior to the first stage of the framework change
without breaking the build.
Change-Id: Ic781324da69a06ef30a0b34cd4e16d561c9c7df2
ontactEditorFragment.java
|
| 4ecb7028746a36c4febb831ba30a07d353e89e16 |
16-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making contact filter focusable
Change-Id: I6d4407074c407034db5292064091bea3c63c8189
ontactEditorFragment.java
|
| d3eedfc5f518a081d76d6b9e31a39c5adf988bc0 |
16-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding a confirmation dialog for canceling out of contact editor
Bug: 3144593
Change-Id: Icd6c9f96d9d2fd4ad84ba38711d0af874258dba5
ontactEditorFragment.java
|
| 4fa9cd0088de76d83803210b39f373cd980fd846 |
11-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in contact editor
Bug: 3276044
Change-Id: Id66492cd0e8570bbe9333e5085d65b47f42525eb
abeledEditorView.java
|
| d52121b61b71230d0f695f9d3891eaf0cbb7c549 |
10-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making aggregation suggestion engine listen to data changes
If a sync brings up a good suggestion while we are editing
the contact, it should show up.
Bug: 3184559
Change-Id: I0b14dc689cba2780d1a531b53d1e545b22e5570b
ggregationSuggestionEngine.java
|
| fa82b398f49bf8d5ae386c326f246f0e56e438b9 |
10-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Ensuring that the "plus" button is always bottom-aligned
Bug: 3273190
Change-Id: I5a41989b5362b5d14fe4b44642eee1ebb50a197f
indSectionView.java
|
| 91d8e892d549bbeba721cb434163a83bc99330a9 |
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Aligining fields in the editor
Change-Id: I7137055bf8ab61df33f6a87c8e6c8227dbee8a9f
ventFieldEditorView.java
indSectionView.java
abeledEditorView.java
extFieldsEditorView.java
|
| 63c311a278cd8ba28d6d8f3b49c0ccd4dffeb57d |
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding "Cancel" button to contact picker
Bug: 3254117
Change-Id: Id0a40fc63f2ca094c7a1a77205ada84a58c2c457
abeledEditorView.java
|
| 7d4a8dda946f5c013573e4d6601fc14c03156ba6 |
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing aggregation suggestions from showing up on rotation
Bug: 3263714
Change-Id: Ifacfb1614b609ea9768eb25c795657cd55a16cdd
abeledEditorView.java
|
| 14918c07e1cb3b5b190bec4cc9106db7adbba29f |
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing custom type dialog crash on rotation
Bug: 3263726
Change-Id: I4afd193fa97578c98785105d0465c286bd085381
abeledEditorView.java
|
| 2fcfa499dd44f62dc63636e363522354e13aa20d |
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing from PopupMenu to Spinner
Change-Id: I24d3a76479b3741f5294abfc1003a8c62e56a5d9
abeledEditorView.java
|
| 02bb1252aa990813fa9e86ad75c458acc15e6801 |
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact
Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
aseRawContactEditorView.java
ontactEditorFragment.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
hotoEditorView.java
awContactEditorView.java
extFieldsEditorView.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
ggregationSuggestionEngine.java
ggregationSuggestionView.java
aseRawContactEditorView.java
ontactEditorFragment.java
ditor.java
ventFieldEditorView.java
roupMembershipView.java
indSectionView.java
abeledEditorView.java
hotoActionPopup.java
hotoEditorView.java
awContactEditorView.java
eadOnlyRawContactEditorView.java
electAccountDialogFragment.java
plitContactConfirmationDialogFragment.java
extFieldsEditorView.java
iewIdGenerator.java
|