| cea6f3d1448e3a2832dad57339917ce878594b24 |
|
09-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix silentfeedback error
If no raw contacts were loaded return null
Bug: 33451068
Change-Id: I896ed19a28e893f8184a9c1c6dd796dc15d6d225
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| b9065ddb28a2040cabda251891be2062b5260217 |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Implement linked contact menu option
Remove unlink option from QuickContact.
Link now appears when the contact has only one raw contact.
Otherwise a new "View linked contacts" menu option appears.
This dialog shows all linked contacts (including read-only) and
has buttons for adding another contact or unlinking all of them.
Show progress dialogs for each of these actions.
Test: Manually verified:
* View linked contacts only appears when there are more than one
raw contacts
* Link appears otherwise
* Pressing add goes to the contact picker and correctly joins the
selected contact
* Pressing unlink opens the confirmation dialog
* Canceling or dismissing the confirmation closes everything
* Unlinking from the confirmation does the unlink
* Confirmed the above with rotating on each dialog and during the
progress dialogs
Bug: 32707898
Change-Id: I39435a07fefce4276e34ba302001ff3dab352516
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| 3a53328fe057610d44f228666c92c3c5ac2d4799 |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Revert "Revert "Load the raw contact's photo in picker dialog""
This reverts commit 3a5f94ffdb600864dc2f29df599cbdaa80046ffc.
Roll forward with fixes.
Test: manually verified:
* contact photos load in the main list
* no crash on viewing picker dialog
Bug: 32096517
Bug: 32384257
Change-Id: I6f798787abc928f6d287cde48182f2643aad364a
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| 3a5f94ffdb600864dc2f29df599cbdaa80046ffc |
|
08-Nov-2016 |
Walter Jang <wjang@google.com> |
Revert "Load the raw contact's photo in picker dialog"
This reverts commit 21bdf08ac2f7e53a1fd9ee69317302b1d035169c.
Bug: 32096517
Bug: 32384257
Change-Id: I5f5f2790a394c9bf27da60b0630474eb92701e12
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| 21bdf08ac2f7e53a1fd9ee69317302b1d035169c |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Load the raw contact's photo in picker dialog
Add a photo query to get the photoId for the raw contact.
Use the photoId to get the thumbail from ContactPhotoManager.
When loading a photo from the databases, pass in an empty byte array
instead of null to indicate that there just wasn't a photo instead
of null which gets interpreted as a failure to load and so the
special BITMAP_UNAVAILABLE holder is used to prevent further
attempts at loads (see b/21423350). Since the change only converts to
empty when reading from the database, that network bug should not
reoccur.
Test:
Verified:
* all photos for aggregates which have them appear in the
picker dialog
* removals, updates, additions to photos were reflected
immediately in the picker and main lists, including
to the me profile.
Bug: 32096517
Bug: 32384257
Change-Id: Ib704f84a351490bd2e34825d9602be813aa79b9b
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| a172180513fce7670fa1b2093c72966f6a377444 |
|
02-Nov-2016 |
Gary Mai <garymai@google.com> |
Ignore read-only raw contacts in picker modal pt. 1
Drop read-only contacts unless the SpringboardActivity is configured
not to.
Changed to using AsyncTaskLoader that returns a RawContactsMetadata
object which has all the information needed by the picker dialog.
Ignore legacy edit URIs and send silent feedback if they are given.
Test:
Manually checked the following scenarios has the correct behavior:
* Single writable raw contact
* Multiple writable raw contacts
* 1 read-only 1 writable
* 1 read-only
* 2 read-only
* Test app usage of legacy URI
Bug: 32640214
Bug: 32240763
Change-Id: Ia3542b927ea615a2b2d07f86cdc1ff8c91f99ba6
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| ba10be290e9a1b105743784ab6cc602bbf3078d8 |
|
13-Oct-2016 |
Gary Mai <garymai@google.com> |
Fix regression with editing me profile
Use Profile.CONTENT_RAW_CONTACTS_URI in PickRawContactLoader
if we're loading the me profile.
Changed rendering accounts attribution to be consistent with
the duplicates view.
* Me profile -> "My local profile"
* Focus Google account -> account name
* All others -> account type display string (Google+, LinkedIn etc.)
Test:
Edit me-profile with G+ account attached
Edit me-profile without G+ account
Edit linked contact with device raw contacts
Edit linked contact with SIM raw contacts
Edit linked contact with Samsung raw contact
Bug:32113893
Change-Id: I904e64eee262d0ddf95240915911228439c2c46f
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|
| a6c80b378e03ebdf6b654dbdb12f2c665fe98a80 |
|
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Implement editor springboard activity
Have the springboard handle edit intents.
Show a dialog if the contact is made of multiple raw contacts.
Go straight to editor if:
* Single raw contact
* Given a raw contact Uri
In the case of 1 read 1 writable, we still show the dialog
since there would otherwise be no way to view what data comes
from the read only raw contact.
The springboard does not handle legacy contact Uris and will throw
an exception if one is received.
Test:
Tested these scenarios:
1) Edit a single raw contact
2) Edit a single read only raw contact
3) Edit a contact made of >2 raws
4) Add new contact
5) Edit a contact made of one read only, one writable
6) Made edits and checked if quick contact continued to update
7) The relevant edit intents from the Test app
Bug: 31826229
Bug: 31088704
Change-Id: I4c1c44accc86521efce2081744189d25f00ec541
/packages/apps/Contacts/src/com/android/contacts/editor/PickRawContactLoader.java
|