History log of /packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e1557036849265afc24528be9effbe299b640bff 08-Aug-2014 Andrew Sapperstein <asapperstein@google.com> CV attachments. b/16138036.

Change-Id: I612bb54ccd2710754be03d9b4a566da544780d09
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
afaab1752ab5b507cdaad7b3619ffc1c9728368f 08-Aug-2014 Andrew Sapperstein <asapperstein@google.com> Remove above attachment promo. b/16138036.

Change-Id: I611f0f7e6eeea0247956e0f1a9f2ec3ec51c9eef
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
aa4c9941269cc7815dd80e649e24d0257f83d5d5 29-May-2014 Alex Gawley <alexg@google.com> Update Attachment Handlers.

Change-Id: Iddd3c6e6ae7ef152db8143acfe9dfcc0ab6ec7af
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
70d584e5372c46f81dc5707a76253bc9c697617d 29-Apr-2014 Jin Cao <jinyan@google.com> Properly destroy old loaders in MessageFooterView

Each MessageFooterView assumes that it only gets updates from one
corresponding attachment uri for its attachment information. However,
this can be broken if we change the underlying uri in MessageHeaderItem
without informing the footer view. When the next bind operation comes
around, MessageFooterView will see the new uri, assume that it's the old
one, and deduce that the uri hasn't changed. It will then attach a
loader to the new uri, and now it has two loaders feeding information
on two different states of the attachment list.

And this will then cause (50% of the time depends on which loader
finishes last) the view to render both the 2 attachments and 1 attachment,
and depending on which one is rendered last, the one with more attachments
will either completely cover up the other, or the one with fewer
attachments will incorrectly overlay on top.

b/14293222

Change-Id: Ia652601d26ce14e9aa0346a98dad2597e62bdbaf
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
b1f7786d52e34485d6c9f1fe50c2aa6fc38ad90b 24-Apr-2014 James Lemieux <jplemieux@google.com> Merge "Gmail does not display inline attachments nor does it offer "Show pictures" within the EML viewer" into ub-mail-master
8e1ffbf042a23824a97a9f47cfc81cf6f14603be 23-Apr-2014 James Lemieux <jplemieux@google.com> Gmail does not display inline attachments nor does it offer "Show
pictures" within the EML viewer

b/13912473

The Eml viewer (and indeed all Secure Conversation Views) now
offers "Show Pictures" to display the inline images.

Those inline attachments are also displayed as tiles at the
bottom of the Secure Conversation View so that interaction with
them is possible.

Change-Id: Ida66820c98c88b222e459aa9d2559383a3b608a0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
6ecd041cf979c95b92e41957b88bdaa26d679309 24-Apr-2014 Scott Kennedy <skennedy@google.com> Remove dead code

Change-Id: I0dc0b7e62c5653107879bab6e3f60603416db3b0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
381c322eb30c39f63a2bb82812d63262eb3c1c1c 20-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Save to drive promo. b/7659807.

Provides a space above the attachment bars to show
some additional content. Default behavior does nothing.
Hooks have been added to allow resizing of the message
footer.

Change-Id: Ib950091d176311bdb06c7c7a466223beb997a7b5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
73c0af74555120ba0d83d4430591c230448b4a14 17-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Add analytics for view clipped message. b/13172001

Change-Id: Ia728178f01dccfbce4008bac9f42c06519092aa0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
20c2082e85e87dc9c70b3d74e20ed31d3eff7364 16-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Send PLID with message instead of conversation.

Fixes b/13748439. Sending with conversation required
server-side changes and wasn't actually more memory efficient.
Arguably it would be less efficient.

Change-Id: I346d61387513e94a7387d7feaa68b3e6d2a7b2de
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
c2a89d1afcf2d5db65360b5e5bdc32e37b923c4c 14-Apr-2014 Andrew Sapperstein <asapperstein@google.com> Single message clipped view. b/2887917.

Change-Id: Iae86b18d645d30ecfb77e110f21b134aae29d26b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
4f347e811052f446c3958c76db278bcd7b39a44f 26-Feb-2014 Andy Huang <ath@google.com> allow an extra option on attachments (in bar and tile UI)

Bug: 7659807

Change-Id: I4c1294d2ba772a70139e0b37429b17bc6096cafd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
f59d01c3116dc2adde97a5b52aa6094144c2d315 20-Feb-2014 Andrew Sapperstein <asapperstein@google.com> View entire message UI.

We need the per-message plid server support,
but we are forwarding the clipped bit to
the UI and showing a button based on that
bit. Clicking that bit will open the
plid viewer for gmail. Email should be
unaffected as it does not ever return clipped as true.

b/2887917.

Change-Id: Iddb54e37cf650ca16a75fcbe69f1861becdd81b9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
865ae9ca2606d901ce33259bae5cfe71beaa18ba 11-Feb-2014 Andrew Sapperstein <asapperstein@google.com> Hide inline attachments in compose. b/12553195.

Just hides the attachments visually. They still
exist and are counted against the max attachments
size.

Change-Id: Ia8c026fa083c3a95b7bc22b1564349d455f0030a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
2a757d7b27ff54e49307316c8a993100a99fd527 04-Feb-2014 Andrew Sapperstein <asapperstein@google.com> Fix Email crash on rotation. b/12885310.

Change-Id: Id4eae8d284f60f75420d2907918621d3602f91e9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
2fd167d6131482da984768b5ee75cefa32ed3e32 28-Jan-2014 Andrew Sapperstein <asapperstein@google.com> RTL - conversation view fixes.

b/12681840 - Properly align attachment details.
b/12681242 - Message header expanded details are locale aligned.
b/12681528 - Message header title and snippet are locale aligned.
b/11989230 - Set each overlay view's layout direction.

The first three bugs were fixed by adding unicode wrapping
to a bunch of fields.

The final bug was slightly more complex. In some scenarios,
the overlay views's layout direction was not properly resolved.
But it should always be the same as its parent so we forcibly
do it now when adding new views.

Change-Id: I9e065e0deaf1958ee87d098231238f6d976e9e68
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
e307785b44deec1eb2aad5ecf83ea4b581779baa 12-Dec-2013 Andrew Sapperstein <asapperstein@google.com> Hide inline attachments from message footer.

b/5555553.
Now skips all attachments with type != STANDARD
in conversation view display. Also fixes
b/11559781.

Change-Id: I232e2d59e0605d3ab52ac382b2b96d85c72d4ad8
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
14f937408fe2451a91b44d3cd7d141347e716775 25-Jul-2013 Andrew Sapperstein <asapperstein@google.com> Conversation View UI Refresh: Cards.

Lots of changes:
New show pictures asset.
Added border as a new view type in the conversation
view to vertically separate cards. Changing its size
is TBD.
Final UI for details header (both collapsed and
expanded).
Side borders are accomplished via a new overlay layer that
is positions a view to each side of the conversation view.
Lots of dimension changes, padding and margin changes, and
other pixelpushing.

Change-Id: I4029ae46896e27fe20b005c01b8df04bb2a46c2a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
7638a1004e7c8ed7a85620243da3b051b60217e8 25-Jun-2013 Andrew Sapperstein <asapperstein@google.com> Final eml viewer cleanup.

Fixes b/9560839. Now we show the title of
the eml file and we also show an overflow
button with settings/send feedback/help.

Change-Id: I5eab245d9fd47e37b83eadcb419255939117ab39
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
bbe74aee04f669990e888095b0d6858dc1e17ce1 19-Nov-2012 Mark Wei <markwei@google.com> Refactor Attachment code. Combined AttachmentStatusLoader.Result and
Gmail.Attachment into GmailAttachment.

Renamed UIAttachment to Attachment, which still follows the UIProvider contract.
GmailAttachment extends Attachment, and contains Gmail provider specific data.

The DownloadListener in AttachmentStatusLoader will modify the cached
GmailAttachments directly, where previously we would create new Results to give
to the ConversationState.

Cancelling an Attachment download will cancel both cache and external db
entries.

Attachment download dialog will close only if state is SAVED or FAILED. This
prevents a NOT_SAVED state update from closing the dialog prematurely.

Simplify AttachmentRequest. Simplify AttachmentStatusLoader to a listener.

Bug: 7538447
Bug: 7538152
Change-Id: If6362473697e6735f1858619c7af83238d75469e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
4f24bb48ab2c3e8fbda2af1e1d8fda79e8a458e7 27-Oct-2012 Andy Huang <ath@google.com> fix one case of duplicate attachment bars

Message attachment bars were either being updated or created
based on the attachment URI. The Gmail provider changes query
params on this URI, so for now, strip the query params before
doing equality checking in this one case.

Bug: 7419739
Change-Id: Ide64278325b31f8f60d38af89c9a8b153bb0a2eb
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
014ea4c15d147794789b9c5bf4e243fa08781ad9 25-Sep-2012 Andy Huang <ath@google.com> handle sender/body changes in-place

Sending a new message updates sender string (for custom froms
and such) and the body (for elided text), after the message is
sent and synced. Avoid conversation view flashing (re-render)
in those cases by applying the changes in-place.

Sender string changes will update all dependent adapter items,
and a dataset change on the adapter re-renders all overlay
views.

Body changes are handled by sending affected IDs to JS so it can
request individual message bodies. Quoted text collapsing is
then re-applied on each new body.

Bug: 7183109
Change-Id: I630187c276ffc63448e6b457c9cd02afd452c438
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
4dabcc9f74ea5f75467f6f581d8ef7cd65c2f06e 20-Sep-2012 Paul Westbrook <pwestbro@google.com> Show progress attachment bar

Show download progress in the MessageAttachmentBar

Bug: 7194891
Change-Id: I847cfa562d5ecb48a953a7a23f8b3eed7d442251
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
8081df46ef5a7794374e41cd1836e778a2da9b31 11-Sep-2012 Paul Westbrook <pwestbro@google.com> Restore download progress dialog

Now the attachment download progress is using an DialogFragment
so the dialog correctly gets restored on orientation change

Bug: 7137689
Change-Id: I90a225f423bf75fd4dbeb464051374919a3cff62
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
d7035855c0717e4fb57c316b3a180b061fbfd76c 31-Aug-2012 Mark Wei <markwei@google.com> Fix for Preview Images In Compose Mode are Not Visible

Bug: 6679652
Change-Id: I1aa634d1e7f7c1f9189f9c1447e8f5c99c6f7585
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
b8331b4565566ca733997398e8c07a26cd2bee98 17-Jul-2012 Andy Huang <ath@google.com> wire up Quick Contacts

Also generalized telling header items whether or not a bind is
only for the sake of height measurement.

Bug: 6373134
Change-Id: I759e4fd95dca874b29a7e3b392ee83f7e7e6f760
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
de9a6e303b74556ecd2e368217ca1ef02e405c20 09-Jul-2012 Andrew Sapperstein <asapperstein@google.com> Improved performance when scrolling conversations.

Previously, every time the MessageHeaderItem was bound
to the MessageFooterView, we removed all of the internal
attachment views and set all views' visibility to GONE.

With this change, we check to see if the attachmentsListUri
has changed. If it has not, we skip the reset step described
above. That way, the only time we remove all of the views is
when the attachmentsListUri changes.

Change-Id: I93d9008f95b28a580b4e628361b0030b81e286a9
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
b334c9035e9b7a38766bb66c29da2208525d1e11 25-Jun-2012 Paul Westbrook <pwestbro@google.com> Changes to support different Log tags

Change-Id: I7121fbf7132444fc0f5c0c130373e3f2d1a3cf7a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
237129ddf57a1e25469d8990322fb7913e18ae20 15-Jun-2012 Andrew Sapperstein <asapperstein@google.com> Compose now shows images as tiled attachments.

It's still a bit buggy (notably, once the previews
do not show up after the initial attaching). Those bugs
will be fixed in the next commit but this was a good stopping point.

In order to reuse as much code as possible, the AttachmentTileGrid
was moved into com.android.mail.ui. Additionally, MessageAttachmentTile
was split into AttachmentTile and MessageAttachmentTile. AttachmentTile
is a base class that handles all of the tile interaction that is common
between the browse and compose versions. At present, this is mostly
the fetching and displaying of the preview image.

As a result, MessageAttachmentTile now derives from AttachmentTile.
MessageAttachmentTile handles the interaction specific to browsing
messages (such as opening the photo viewer, etc).
There is also new class called ComposeAttachmentTile
which derives from AttachmentTile and handles the interaction
specific to composition of messages.

The AttachmentsView in composition now contains two children in its
view hierarchy, an AttachmentTileGrid and an inner LinearLayout
that now stores the non-tiled attachments.

Change-Id: Iad85529a7b6d573060645499271860cf07877754
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
4c7d8b5f38bfa80192d457025b834c975d7d38a3 12-Jun-2012 Andrew Sapperstein <asapperstein@google.com> UI improvements to photo viewer.

Photo viewer now shows the display name of the
image. Additionally, it now has a subtitle that
contains the current number of that attachment.

Additionally, the implementation in Unified utilizes
a derived class of PhotoViewActivity that tweaks
the subtitle to display image size and adds action
items. Currently the items are visible but do not do
anything. Next commit will wire these up.

As part of refactoring to make the derived classing work
properly, a bunch of legacy code was deleted including
all of BaseFragmentActivity as its sole reason remaining
was for spoofing the ActionBar.

Finally, a small change to the cancel attachment button
was made so that it was appropriately selectable and
48dip by 48dip.

Change-Id: I5a50bd420fa23a3e7d8734b5a46a6f28198ccef4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
4aa1c1340556c646175c3d0b193be05876ad95a0 09-Jun-2012 Andrew Sapperstein <asapperstein@google.com> Non-image attachments now display as a list.

There are now two separate attachment areas in
the MessageFooterView. The AttachmentTileGrid
contains all images in the gridded tile look.
Additionally, there is a LinearLayout that contains
0 or more MessageAttachmentBars. These bars contain
a small icon, info about each attachment, and
an overflow button that contains additional options
other than the default for that attachment type.

In addition, there is now AttachmentActionHandler
that performs a lot of the interaction that both
attachment views share.

Change-Id: I60d297b7514e6ee35d23a9ec250833e886328d4d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
e4798f5d8bd07eb39bf9dac57fd2a304b53916a0 06-Jun-2012 Andrew Sapperstein <asapperstein@google.com> Reworked attachment grid to use a dp-based layout.

Instead of having a resource selection for the
number of columns (which requires
a different value for portrait and landscape as well
as every screen size), utilize a minimum dip tile size
that figures out, while measuring, the appropriate number
of columns to use and expands the tile size to fit the
entire width with that number of columns.
As a result we have only two different values
for the minimum tile size. 120dip is the default and
180dip for sw600dp. Verified that the appropriate
number of columns occurs on all Google experience
devices.

Additionally, added a header and bar for the attachments
so that the user can clearly see where attachments
begin.

Change-Id: I48b1645e1004596747c1585e44a387b1231bd661
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
f986850eb04ff614feb915e178227c4f53ca695b 31-May-2012 Andrew Sapperstein <asapperstein@google.com> Attachments now show in a grid-like view.

Currently, two per row are displayed in portrait
and three per row in landscape. Need UX decision
on how many to show for larger screen sizes.

Much of this code is taken from Contacts which
used a similar layout for favorite contacts.
That layout was taken and tweaked to suit the
attachment handling purposes.

Still need to add the appropriate interactions
for the various attachment types per UX's guidelines.
Will add that in the next CL.

Change-Id: Iad6ea716a680b1fd48f16d34de2a5bc2e87b7db5
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
2527695a1a76112be849954a717cc96f19331ffc 26-May-2012 Andrew Sapperstein <asapperstein@google.com> Showing multiple photos in the photo viewer.

Change-Id: I98388040bb7f6d195344e6edcd466ac3e8a0e66a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
d0991f7f0d0882ac58dfdb1f8eb8e2a0abd573fc 17-May-2012 Andy Huang <ath@google.com> move image decode into background thread

Fixes strict mode violations. Now it also handles arbitrarily
large full-size images, which is all EAS/IMAP may offer.

Use contentUri when thumbnailUri is not populated (as is the
case with EAS/IMAP).

Bug: 6195064
Bug: 6389109
Change-Id: Ifcc2062d35e77c0fca4e6a568488ab556ba0da08
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
c7543579c6a97c0ae3341578332f56d4d226f34c 04-Apr-2012 Andy Huang <ath@google.com> support message header collapsing

* toggle header collapse/expand
* initially render read messages collapsed
* collapse removes attachments footer and stops loader
* expand creates/reuses attachments footer, but ONLY if visible
* can (mostly) expand/collapse details
* can expand/collapse quoted text
* add lots of logging (disabled during scrolling!) to catch
strange layouts

Change-Id: I73f533c91d24ef1c05919d0a3b396f276898107a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java
f0e95c3e49c8a12009dd138d3985f5e9fb8f2754 03-Apr-2012 Andy Huang <ath@google.com> bottom-aligned attachments

Refactor attachment view logic out of MessageHeaderView into
its own view class, paired with MessageFooterItem.

Change-Id: Ic6539f52d53be0e2d23144abec1baffb9368f8cd
/packages/apps/UnifiedEmail/src/com/android/mail/browse/MessageFooterView.java