a43e1304c2cbca16d583e08b63cb4c95a37b7b87 |
|
08-May-2017 |
Jack He <siyuanh@google.com> |
eSCO: Format changes to original vendor patch (4/5) * Format changes to original vendor patch * Re-order part of SCO creation code to improve readability * Make log more concise and usefull Bug: 19540029 Test: make, HFP PTS test, testplans/86884, testplans/87103 Change-Id: Ie0199519afb30f56568c04fef728fce44a172063 (cherry picked from commit fe695a557a92053d4c44428ba08c0b8e945d4711)
/system/bt/btif/src/btif_hf.cc
|
5b9aaac278b203962e8df0edc9d331ce8dffe4bd |
|
10-Feb-2017 |
Myles Watson <mylesgw@google.com> |
eSCO: Remove BTM_WBS_INCLUDED from the stack (2/5) All of our platforms support WBS. Bug: 19540029 Test: make, HFP PTS test, testplans/86884, testplans/87103 Change-Id: I384d49f73935ebb35b17132e71c85174797c435e (cherry picked from commit 3e634d6c1e83f053005c9abdbd89e662ad81c4d4)
/system/bt/btif/src/btif_hf.cc
|
d084b7c9ac2146c97256057b22778204309134fa |
|
13-Apr-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "HFP: Disable BTRH feature" into oc-dev
|
f923eaea807cb9946d41e8f408503a478281b1ec |
|
25-Nov-2015 |
Yoshiharu Kurita <yoshiharu.x.kurita@sonymobile.com> |
HFP: Disable BTRH feature Fluoride does not notify application layer upon AT+BTRH, and always sends error response (BTRH is not supported) to remote device. That is, Fluoride does not support BTRH feature. But BTRH is enabled by default, so OK is sent to remote device by mistake before the error response is sent. This makes some carkits unstable. Bug: 29587048 Test: make, PTS test Change-Id: If1aa32291491982851ecd480c4ba8390f39a27a2 Merged-In: If1aa32291491982851ecd480c4ba8390f39a27a2 (cherry picked from commit a25ef0b60b4ca10385dac02334dc3e4e2ad23edb)
/system/bt/btif/src/btif_hf.cc
|
9cb269c25be642526c4152ed7c14158300f28969 |
|
03-Feb-2017 |
Jack He <siyuanh@google.com> |
Add support for inband ringing feature * Change HFP init API so that the HFP feature bit field depends on whether in-band ringing is supported on the device * Feature disabled by default unless system property enables it Bug: 19171297 Test: mm -j 40, HFP regression test, testplans/82144 Change-Id: Ib8ba28ac6e70eb23b2a2ad11c5805793911a4e43 (cherry picked from commit 7a9892c63bad8f8d93681fb74d5532a79387b60e)
/system/bt/btif/src/btif_hf.cc
|
c338fe868cc78fca87d3827b568b0a997f575642 |
|
01-Feb-2017 |
Marie Janssen <jamuraa@google.com> |
btif: remove logspam at higher debug levels Some CHECK macros had logs that printed the function name, which duplicated the logs in the functions outside the checks, producing too many logs. Remove some unused macros. Changes: 02-01 09:34:11.757 1259 1755 D bt_btif : get_folder_items_list_rsp 02-01 09:34:11.757 1259 1755 D bt_btif : get_folder_items_list_rsp: item_cnt: 0 len: 0 to 02-01 09:34:11.757 1259 1755 D bt_btif : get_folder_items_list_rsp: item_cnt: 0 len: 0 and similar. Test: run logcat, check that we have less duplicated logs Change-Id: Id6e57f38b34d176ed8be0c3baedfbcf55e61a9a4
/system/bt/btif/src/btif_hf.cc
|
ee96a3c60fca590d38025925c072d264e06493c4 |
|
23-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Fix asterisks in block quotes Remove double asterisks from block quotes. git grep -lP '^[*][*]' | xargs sed 's/^[*][*]/ \*/' -i Fix asterisk line lengths git grep -l '^[ /][*]\{79,\}[*/]' | \ xargs sed -i s,"^\([ /]\)[*]\([*]\{78\}\)[*]*\([*/]\)","\1\2\3", Test: mma -j32 Change-Id: Ie3fd375ac2f804cb0f53bf1314a005e85973b3d7
/system/bt/btif/src/btif_hf.cc
|
9008888d24407541aa383aa4bd363a40abbf954b |
|
16-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Fix formatting after removing defines clang-format -i --style=file bta/*/* btif/*/* include/* Test: mma -j32 Change-Id: I9ebb32f0cc5bd24a7cb2ae25699999aab5036b13
/system/bt/btif/src/btif_hf.cc
|
c75a71d9b6012c46743099b53d172ad46e6f41d2 |
|
22-Jun-2016 |
Satish Kodishala <skodisha@codeaurora.org> |
AG: CLCC response can contain non-ATD characters Test case: 1. Connect Plantronics backbeat PRO headset. 2. Initiate outgoing call from phone. 3. Accept the call from remote side and terminate call. 4. Try to redial from headset and observe Failure: AG is sending error for redial request from BT headset. Root cause: Sometimes, the number in CLCC response has "-". Repeated from the headset, the ATD string has "-" which is not allowed in the dial string for ATD and errors. Fix: * Sanitize CLCC response to only include valid ATD characters. * Accept "-" in ATD because it works for us. Change-Id: I854165c7da295f428852c829543eb4fc18455d91
/system/bt/btif/src/btif_hf.cc
|
40cde56d28ab9751ba76bded0b7ac5974c750a97 |
|
21-Oct-2016 |
Myles Watson <mylesgw@google.com> |
btif: Add do-while blocks to macros Test: mma -j32 Change-Id: Ie82465b8cef6c4f527fad13892abb365e15dad7c
/system/bt/btif/src/btif_hf.cc
|
0ff1dd71389faa77b6f42ca54525bf53344bd4e1 |
|
09-Mar-2016 |
Satish Kodishala <skodisha@codeaurora.org> |
Disable HSP profile during BT turn off Usecase: 1. Enable HSP profile only. 2. Do Network reset. 3. Connect to headset supporting HSP profile. Failure: Not able to connect to headset after network reset. Rootcause: During BT turn off, HFP profile is disabled instead of HSP profile. This led to the HSP profile registration from apps failed during turn on after network reset. Fix: Add a check to see if HFP or HSP profile is enabled during BT turn off. Test: code compilation Change-Id: Ie7bd7b546c377f4a060bc89916640035a047d086
/system/bt/btif/src/btif_hf.cc
|
f45481678af0694902b5200ba69ced4cb61d73f0 |
|
19-Oct-2016 |
Myles Watson <mylesgw@google.com> |
btif: Fixup clang-format In src/btif_sock_l2cap.cc: Move a comment before the define and run clang-format again. Fix formatting in comments that were more than 80-characters wide. Test: mma -j32 Change-Id: I17465a1425d1de9a28f0675fe65c8529359a87af
/system/bt/btif/src/btif_hf.cc
|
6bd442f543972b072ef2cbbcf2f7c91202de1045 |
|
19-Oct-2016 |
Myles Watson <mylesgw@google.com> |
btif: Apply clang-format clang-format doesn't understand block quotes of this form: /* This is not handled well ** because there are two asterisks **/ cd btif/ # Replace '**' at the beginning of the line with ' *' sed 's/^[*][*]/ \*/' -i include/* src/* test/* co/* clang-format --style=file -i src/* include/* test/* co/* Test: mma -j32 Change-Id: I2477eae5480602d5b2fee5ec89c9ed7888022341
/system/bt/btif/src/btif_hf.cc
|
d4710b90122a37d75963bbe568f60c8ba10f67ef |
|
04-Feb-2016 |
Satish Kodishala <skodisha@codeaurora.org> |
Update hf structure on phone state change only if SLC is up Usecase: 1. Enable multi-hf 2. Pair and connect A2DP to a headset(hs1). 3. Pair and connect HFP to another headset(hs2) 4. Accept call on AG 5. Disconnect hs2 by powering off headset 6. Disconnect the call 7. Power on the hs2 Failure: No A2DP playback on hs1 though music player is playing. Rootcause: When there is a call on AG, we update both hf structures about the call. However, when any headset gets disconnected, only its hf structure is cleared. After the call is ended, we don't clear hf structures since there is no hf connection. When A2DP queries for active call, we return true incorrectly since the hs1's structures are not updated when the call is ended. Fix: Update hf structures on phone state change only if SLC is connected on it. Updating both hf structures regardless of the SLC state causes hf state to indicate wrong status. Test: manual Change-Id: I487792038d97a2bac77639d7c699f49fc0b18f97
/system/bt/btif/src/btif_hf.cc
|
80d7f60680f483a71e413f2453ab20013aff5c5c |
|
02-Mar-2016 |
George Burgess IV <gbiv@google.com> |
Replace all uses of sprintf() with snprint() - sprintf() does not limit the length of the character string when writing to a buffer and may result in buffer overflow - snprintf() requires the maximum write length as a parameter. When the maximum length supported is smaller than the reserved buffer length, the call will not result in buffer overflow Bug: 31859081 Test: TestTracker/64195/3975 Change-Id: I519f8ef7b9b162fd79094f89148250d783c734c0
/system/bt/btif/src/btif_hf.cc
|
a62c5a302e54568a3d2c164a7dbef52f279512f2 |
|
26-Aug-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Cleanup and removed BTIF-related unused code * Removed field tBTIF_MEDIA_CB.av_sm_hdl, because it is never used after an assignment. * Removed the corresponding function btif_av_get_sm_handle() which is not used/needed anymore. * Declared btif_hf_is_call_idle() function in a new header file "btif_hf.h" * Removed tBTIF_STATUS, BTIF_SUCCESS and BTIF_ERROR_SRV_* error codes which are never used. * Removed duplicate conditional define of BTA_AV_CO_CP_SCMS_T * Removed unused typedef tBTA_AV_AUDIO_CODEC_INFO, and unused BTA_AV_CO_* defines and enums. Change-Id: I7bb49957fad94073d474fea6ea0d466f36df37fb
/system/bt/btif/src/btif_hf.cc
|
4de9bbcde79eb98dbfd56de292902549ac3e2bc1 |
|
29-Feb-2016 |
Mudumba Ananth <ananthm%broadcom.com@gtempaccount.com> |
HFP 1.7 profile update (1/4) -> Added AG support for HFP 1.7 version upgrade which adds new type of indicator called HF(headset) indicators. -> Added support for two new AT commands AT + BIND and AT + BIEV which have been appended to Hands-Free SLC sequence. -> Added support to propagate the above commands and their data to the upper layers. Bug: 19983867 Change-Id: I93d5b2af949f9fb99507a954e623cd0927ddc976 (cherry picked from commit e5bed64926d6ae45501617052f90932287da135b)
/system/bt/btif/src/btif_hf.cc
|
b7f64bc45dec7f7fec74ceb04874f322b9434bbf |
|
22-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
btif: standardize types, #ifs Use standard types everywhere. Use standard style for #if statements: - #if (VAR_NAME == TRUE) - #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE) Use __func__ instead of __FUNCTION__ Change-Id: Ic29d1d0b32c3ca9953752a4e5da6c28f45ec8895
/system/bt/btif/src/btif_hf.cc
|
63b0519c3f0d1c0cc523e0e9553c60fc68651acc |
|
20-May-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix misc-macro-parentheses warnings When compiled with WITH_TIDY=1, clang-tidy warns about missing parameters around macro parameters. Bug: 28705665 Change-Id: I89c23cfe6eaefae5ef3c648a7c123c0501662c13
/system/bt/btif/src/btif_hf.cc
|
713993d1784ab7c23aee1fa3cf1ab8676cc0aa69 |
|
21-Apr-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert BTIF code from C to C++ Modifications required: * added proper casting * moved variable definitions before goto statements * added 'extern "C"' markers where needed * renamed 'operator' to 'operator_name' Bug: 28485365 Change-Id: I903357967387207e678866c02e008f047f8263f6
/system/bt/btif/src/btif_hf.cc
|