| f2af1c42ccb2f642b241c2261b42d0be61d45438 |
|
13-Dec-2016 |
Jack He <siyuanh@google.com> |
Replace assert with CHECK from base/logging.h
* Replace assert with CHECK
* Remove all NDEBUG definitions
* Remove hacks for BT_LIBCHROME_NDEBUG
* Removed some removed directories from Makefile such as hcis, brcm, rpc
Coccinelle-assisted:
@@
@@
- #include "base/logging.h"
+ #include <base/logging.h>
@ assert_included @
@@
@ base_logging_included @
@@
@ depends on (assert_included && !(base_logging_included)) @
@@
- #include <assert.h>
+ #include <base/logging.h>
@ depends on (assert_included && base_logging_included) @
@@
- #include <assert.h>
@@
expression E;
@@
- assert(E);
+ CHECK(E);
And a bash script:
for file in $(find . -name "*.cc"); do
spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file
done
The following files are maually edited:
btif/src/btif_config.cc
btif/src/btif_avrcp_audio_track.cc
btif/src/btif_gatt_client.cc
osi/src/data_dispatcher.cc
osi/src/reactor.cc
osi/src/thread.cc
osi/src/fixed_queue.cc
osi/src/list.cc
osi/src/allocation_tracker.cc
osi/src/alarm.cc
osi/test/wakelock_test.cc
Bug: 31781465
Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest
Change-Id: I21dc10a45be31665e41441b75b0515ed87523988
/system/bt/osi/test/wakelock_test.cc
|
| b55040cc6448a8847490da807d2b6362aa8cb8d9 |
|
19-Oct-2016 |
Myles Watson <mylesgw@google.com> |
osi: Apply clang-format
cd osi/
clang-format -i --style=file include/*.h include/socket_utils/* src/*.cc \
src/socket_utils/* src/protos/* test/*
Test: mma -j32
Change-Id: I659e586076f1e2ec8f687cd33f441700b8d1f823
/system/bt/osi/test/wakelock_test.cc
|
| 223cecf8b6905fec65c509cf85b20edbdbd28344 |
|
08-Aug-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Separate the Alarm unit tests from testing the Wakelocks
* Simplify the AlarmTestHarnless unit test setup for Wakelocks.
Now we use wakelock_set_os_callouts() to setup local unit tests and
to keep local state whether the wakelock is acquired.
Also, removed unused timer-related setup inside AlarmTestHarnless.
* Add explicit Wakelock unit tests
Change-Id: I08bd8d457fd48ec45a8a591bd69cb08dbaf5ee7a
/system/bt/osi/test/wakelock_test.cc
|