f2af1c42ccb2f642b241c2261b42d0be61d45438 |
|
13-Dec-2016 |
Jack He <siyuanh@google.com> |
Replace assert with CHECK from base/logging.h * Replace assert with CHECK * Remove all NDEBUG definitions * Remove hacks for BT_LIBCHROME_NDEBUG * Removed some removed directories from Makefile such as hcis, brcm, rpc Coccinelle-assisted: @@ @@ - #include "base/logging.h" + #include <base/logging.h> @ assert_included @ @@ @ base_logging_included @ @@ @ depends on (assert_included && !(base_logging_included)) @ @@ - #include <assert.h> + #include <base/logging.h> @ depends on (assert_included && base_logging_included) @ @@ - #include <assert.h> @@ expression E; @@ - assert(E); + CHECK(E); And a bash script: for file in $(find . -name "*.cc"); do spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file done The following files are maually edited: btif/src/btif_config.cc btif/src/btif_avrcp_audio_track.cc btif/src/btif_gatt_client.cc osi/src/data_dispatcher.cc osi/src/reactor.cc osi/src/thread.cc osi/src/fixed_queue.cc osi/src/list.cc osi/src/allocation_tracker.cc osi/src/alarm.cc osi/test/wakelock_test.cc Bug: 31781465 Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest Change-Id: I21dc10a45be31665e41441b75b0515ed87523988
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
015834df156be6b7365ce1cf00e31ddf72f2c67b |
|
30-Sep-2016 |
Myles Watson <mylesgw@google.com> |
vendor_lib: Apply clang-format with the new config cd vendor_libs/test_vendor_lib/ clang-format ../linux/bt_vendor_linux.c -style=file -i clang-format include/* test/* src/* -style=file -i Update the style guide since clang-format help uses the -style=file option. Test: mm -j32 Change-Id: I166adfb2bb9a87fefa1242c91e5f180011caa2ad
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
3c4f59fc27e36e4489c7f7fd6e330819b16fbc4f |
|
17-Sep-2016 |
Jorge E. Moreira <jemoreira@google.com> |
test_vendor: Refactor scheduling of dual_mode_controller event handling Moved all controller actions out of read callbacks to task callbacks to avoid race conditions when modifying internal controller state. Change-Id: Ie8bb762992755db2dddb6b7bb6a4fe52ab2d0020
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
d4ff4bb2c7c6d16945456b2ba2ccdeae045e8cbd |
|
13-Jul-2016 |
Myles Watson <mylesgw@google.com> |
test_vendor: Silence packet_stream.cc Only log if Events report the wrong size. Change-Id: I3c06e94298f7341a940bb6d5106c869746bdaa78
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
b7d64b20717e3f597bb4e3881f08cb5d07fa1b02 |
|
29-Aug-2016 |
Myles Watson <mylesgw@google.com> |
test_vendor: Remove using directives from headers Change-Id: I83358cbb68b10e80e4e553a6657fcb38cfcb928f Signed-off-by: Myles Watson <mylesgw@google.com>
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
265316f78ca1077216c9d87b2de096894fdd5ee5 |
|
29-Aug-2016 |
Myles Watson <mylesgw@google.com> |
test_vendor: Remove unused extern statements It should be safe to include C header files without using extern. Change-Id: I2b562ef3f76df9f9dac69323345ed3d3610e8bc2 Signed-off-by: Myles Watson <mylesgw@google.com>
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
ea3ede2474a8980387b67bc7db2b661e7219b468 |
|
05-Aug-2016 |
Jorge E. Moreira <jemoreira@google.com> |
Using include paths relative to vendor library dir Change-Id: I6b5dfa4098cdf2eda21d3fae60729b765532c2f9
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
99195bc17fe1f7c4a7e43590d9bce550b177a931 |
|
26-May-2016 |
Myles Watson <mylesgw@google.com> |
test_vendor_lib: refactor packet constructors Make it simpler to append bytes to payloads, since that's a common operation. Change-Id: I7fc975fb999add8e1a360b91bdae869d6d7d2029 Signed-off-by: Myles Watson <mylesgw@google.com>
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
e49120d722142f593687856a71cbffadc3caa530 |
|
25-May-2016 |
Myles Watson <mylesgw@google.com> |
test_vendor_lib: run clang-format with brillo opts Change-Id: Ie2ead0a020e2358696a2f0e26f3c76a9dd29e266 Signed-off-by: Myles Watson <mylesgw@google.com>
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
6f5f0540f1557c87349d9f3378a90979c175ed1d |
|
21-Aug-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Clean up controller documentation and address style issues This upload cleans up the command documentation in the controller's header file and also fixes a few logical errors related to command status event packets. Some style fixes are also included, such as removing braces for single line conditionals to conform to remain consistent with the rest of the project. Bug: 21586676 Change-Id: Ife5e608e43c3030e76eff8ea79ce6cad0b2c10a3
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
2e00ba9b74536ce9a0d1adf78f92e6478563e49b |
|
19-Aug-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Add tests This upload adds unit tests for the packet_stream and hci_transport objects. Bug: 21586676 Change-Id: Ica99be959cdd801ea10631d31fc0f0b8ea1d8456
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
2d96c88025c80d4d7e0e341cfdbf278596340b66 |
|
03-Aug-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Add test channel for run-time input This change adds a test channel for receiving user-specified commands and data at run-time. Specifically, the channel is intended to be used for additional debugging capabilities and for fine-tuned control over the test controller. Implementation-wise, the test channel is simply another socket that the vendor manager watches on. The handling of test channel input goes through the pipeline as normal HCI data after it is received by the HciTransport. A script for building and running the test vendor library and (optionally) the test channel has been added in scripts/. Bug: 21586676 Change-Id: I55bdeedbcd81effbe009aa62a19031637374a1e6
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
2fc0eba951081bddd15a3482f2189a9125dac48a |
|
30-Jul-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Implement event loop with libbase Adds event loop functionality by handling IO in the Watcher class, HciTransport. Also fixes a bug where the vendor's file descriptor was closed early and another where an object was mistakingly being passed by value. Bug: 21586676 Change-Id: I2ec30b68c0ede47bf1ad78ec13beee93d0f8ab9d
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
a7077ee9b7482708fa7272837a527f64bb470988 |
|
28-Jul-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Use libbase's CHECK/DCHECK This upload pulls in libchrome to the test vendor library and uses CHECK and DCHECK from base/logging.h. Bug: 21586676 Change-Id: Ia88b4aa3728493d798e8d36076a351a00fad7c6b
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
3c0ea3e5a5aca269283854d8f2f584ad0699c951 |
|
16-Jun-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Use EPOLLOUT HciTransport checks for write-readiness before sending any packets back to the HCI. Packets are maintained on a queue and only written when the EPOLLOUT flag is set in the epoll_event. Bug: 21586676 Change-Id: Iebd9599286b62746e2be7e424c522058ae978bb1
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|
f3b1820e1676261886a6537e1f6abac6a35ed6d4 |
|
16-Jun-2015 |
Dennis Cheng <dennischeng@google.com> |
test_vendor_lib: Initial commit Basic vendor library for a test Bluetooth controller. Currently consists of mostly stub functions and objects and can only handle the reset command (by immediately responding with a command complete event). Implemented through a global EventDispatcher object which waits for data from the HCI and directly returns the appropriate response. Eventually, the dispatcher will manage a fake controller object that will provide callbacks to be executed whenever events are processed by the dispatcher. Unit tests are still in progress and will be in the next upload. Bug: 21586676 Change-Id: I1c6746f8b0f1732b89a1da13facecdd49b5ac1b6
/system/bt/vendor_libs/test_vendor_lib/src/packet_stream.cc
|