| 66ee277353c7e372ce5ad8a87d5591600fe284dd |
|
10-Mar-2017 |
Bowgo Tsai <bowgotsai@google.com> |
adb: replacing fs_mgr_read_fstab() with fs_mgr_read_fstab_default()
The original default /fstab.{ro.hardware} might be moved to
/vendor/etc/. or /odm/etc/. Use the new API to get the default
fstab instead of using the hard-coded /fstab.{ro.hardware}.
Bug: 35811655
Test: boot marlin with /vendor/etc/fstab.marlin, then run 'adb remount'
Change-Id: I927209ce3c5bea45c01ed631a7c4c320fe728c00
/system/core/adb/remount_service.cpp
|
| ffdec180176094dac0fb902263370dea1deb138f |
|
24-Sep-2016 |
Elliott Hughes <enh@google.com> |
Switch adb to <android-base/properties.h>.
Bug: http://b/23102347
Test: manual
Change-Id: Iffa66258c01f84f41b9af99ab5e768a0a2669106
/system/core/adb/remount_service.cpp
|
| b7b1edf974a93cc4bb9a2de7a5e9c9bce9ad178b |
|
12-Nov-2015 |
Josh Gao <jmgao@google.com> |
adb: remove exit-time destructors.
On exit, these destructors get invoked while other threads might
still be using them, potentially causing a crash, and definitely
causing tsan to report a race condition.
Bug: http://b/23384853
Change-Id: I94de55d22f97f4edd1d7cc1f34e8c1f8dfd56a5a
/system/core/adb/remount_service.cpp
|
| aed3c61c4437ebb05eadfb3bf85d6962c30b9935 |
|
23-Sep-2015 |
Yabin Cui <yabinc@google.com> |
Adb: use VLOG() to replace D() for verbose logging.
As there are too many D(), we can keep both VLOG() and D() now, and get
rid of D() gradually.
Change-Id: I2f1cb70bcab3e82c99fed939341d03f6b2216076
/system/core/adb/remount_service.cpp
|
| d6eba89f83a4028a4b25e44dc0f8bc59dd6ad70a |
|
30-Jun-2015 |
Daniel Rosenberg <drosen@google.com> |
Fix "adb remount" for when the root directory is in system.img
When the root directory has been built into system.img, it is
mounted at /.
Change-Id: If01d12efeaa53b4ae59e801a6e9b802a9ae5882d
/system/core/adb/remount_service.cpp
|
| 6ac5d7dc56a016718d2a26803435505e983e5d80 |
|
23-May-2015 |
Spencer Low <CompareAndSwap@gmail.com> |
adb: fix adb_close() vs. unix_close() usage
Document the differences between adb_*() and unix_*() in the function
prototypes in sysdeps.h. See the file for the details (CR/LF
translation, well-known file descriptors, etc.).
Fix adb_read(), adb_write(), and adb_close() calls that should really be
unix_read(), unix_write(), and unix_close(). Note that this should have
no impact on unix because on unix, unix_read/unix_write/unix_close are
macros that map to adb_read/adb_write/adb_close.
Improve sysdeps_win32.cpp file descriptor diagnostic logging to output
the name of the function that was passed a bad file descriptor.
Change-Id: I0a1d9c28772656c80bcc303ef8b61fccf4cd637c
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
/system/core/adb/remount_service.cpp
|
| 9aa4fda4e64c1882faf019cc2a483ee4917e0c85 |
|
11-May-2015 |
Elliott Hughes <enh@google.com> |
Failure to find an oem partition should not be a remount failure.
Many devices don't have an /oem partition, so find_mount should be
expected to fail, but shouldn't cause the overall remount to fail.
Also clean up all the error handling and reporting, and remove the
dead int* globals.
Bug: http://b/21024141
Change-Id: Ie31021b03c9cab8e972269d7d1ffe383cd30ee9e
/system/core/adb/remount_service.cpp
|
| 5677c23e8d0c085be8d8429a5d125147d11e9bb2 |
|
08-May-2015 |
Elliott Hughes <enh@google.com> |
Fix "adb remount" for devices without an oem partition.
On a device without an oem partition, we now have an /oem directory
anyway. This causes find_mount to fail, and that was returning nullptr
from a std::string-returning function. Boom!
Also clean up the bits of code I had to trace through between "adb remount"
on the host to the crash on the device as I debugged this.
The only other meaningful change is the error checking in
adb_connect_command --- adb_connect can also return -2.
Bug: http://b/20916855
Change-Id: I4c3b7858e13f3a3a8bbc7d30b3c0ee470bead587
/system/core/adb/remount_service.cpp
|
| ab52c181fa4c1c9891644635dc5653cda5b90e2b |
|
02-May-2015 |
Elliott Hughes <enh@google.com> |
Add WriteFdFmt and clean up more code.
Also say *which* device wasn't found.
Bug: http://b/20666660
Change-Id: I50e234ad89e39ae0a8995083c0b642c61275c5a3
/system/core/adb/remount_service.cpp
|
| e67f1f87d9b1188ec8617035db7006c37ee7b21e |
|
01-May-2015 |
Elliott Hughes <enh@google.com> |
More adb buffer fixes.
This patch factors out a lot of the basic protocol code: sending OKAY,
sending FAIL, and sending a length-prefixed string.
ADB_TRACE has been non-optional for a long time, so let's just remove
the #ifs.
Also actually build the device tracker test tool (and remove its duplicate).
Bug: http://b/20666660
Change-Id: I6c7d59f18707bdc62ca69dea45547617f9f31fc6
/system/core/adb/remount_service.cpp
|
| 5830577bd82fdb7c39555da20a4cf585b8bb376a |
|
17-Apr-2015 |
Elliott Hughes <enh@google.com> |
Fix more buffer overruns.
Also add some tests.
Bug: 20323050
Change-Id: I9eaf3dc04efd85206663c4cca4f8c1208620a89a
/system/core/adb/remount_service.cpp
|
| 454742392f72079dbdb0d23ea24e01b5703c1aa5 |
|
30-Mar-2015 |
Sami Tolvanen <samitolvanen@google.com> |
Set verity mode as the verified property value
Set the verity mode as the value for partition.%s.verified to make it
easier for userspace to determine in which mode dm-verity was started.
Change-Id: Icc635515f8a8ede941277aed196867351d8387cb
/system/core/adb/remount_service.cpp
|
| 3313426fad9eaaf53017cdbde889ebcec91358ec |
|
19-Mar-2015 |
Dan Albert <danalbert@google.com> |
File header cleanup.
* sysdeps.h should always be included first.
* TRACE_TAG needs to be defined before anything is included.
* Some files were missing copyright headers.
* Save precious bytes on my SSD by removing useless whitespace.
Change-Id: I88980e6e00b5be1093806cf286740d9e4a033b94
/system/core/adb/remount_service.cpp
|
| ec7a66713144a16361724fe88332b28bbf3f4b3c |
|
16-Mar-2015 |
Elliott Hughes <enh@google.com> |
Revert "Revert "adb: support /oem partition""
This reverts commit 6084a0124f868c7ec43f6c415a27a168f27ff694.
The original build breakage is fixed by (a) building the verity
code for eng builds as well as userdebug builds and (b) moving
the exported remount service functions into a new header file.
Change-Id: Ice0c4f97d4db38ab7eb333c7a6e56bbd11123f5b
/system/core/adb/remount_service.cpp
|
| 6084a0124f868c7ec43f6c415a27a168f27ff694 |
|
16-Mar-2015 |
Dan Albert <danalbert@google.com> |
Revert "adb: support /oem partition"
This is broken on userdebug builds, and it isn't completely clear why. The declaration for make_block-device_writable in adb.h wasn't updated to match the definition (which uses a std::string instead of a char*). adb.h is currently extern "C", and it isn't clear why this is only broken for userdebug, so I'd like to revert while we investigate.
This reverts commit 81416fdb186070fe4db3ca5fed2e713a4eecaac1.
Change-Id: I47f321574f9f21052e2c7332e8b0f6ef9ab98277
/system/core/adb/remount_service.cpp
|
| 81416fdb186070fe4db3ca5fed2e713a4eecaac1 |
|
03-Nov-2014 |
Mårten Kongstad <marten.kongstad@sonymobile.com> |
adb: support /oem partition
Add support for /oem partition in commands 'adb remount' and 'adb sync'.
Change-Id: I5defc74ccaa37feaef74b9268e22b4075f98a59f
/system/core/adb/remount_service.cpp
|
| bac3474a8256cb32a29e8d46f78cad95a5502692 |
|
26-Feb-2015 |
Dan Albert <danalbert@google.com> |
Move adb to C++.
I keep trying to clean things up and needing std::strings. Might as
well just do this now.
usb_linux_client.c is going to stay as C because GCC isn't smart
enough to deal with the designated initializers it uses (though for
some reason it is in C mode).
The Darwin files are staying as C because I don't have a way to test
that they build.
The Windows files are staying as C because while I can actually build
for them, it's slow and painful.
Change-Id: I75367d29205a9049d34460032b3bb36384f43941
/system/core/adb/remount_service.cpp
|