| 17b5b82d64686d482e6dcf96ee54fd62234d5f27 |
|
16-Sep-2016 |
Colin Cross <ccross@android.com> |
Fix warnings in libutils headers
system/core/include is included in the global include path using
-isystem, which hides all warnings. Fix warnings in libutils
headers in preparation for moving from -isystem to -I.
- Fix implicit cast from int64_t to long in Condition.h. Remove
the __LP64__ check and always compare against LONG_MAX before
casting.
- Fix implicit cast from size_t to ssize_t in KeyedVector.h
- Fix -Wshadow-field-in-constructor warnings in Looper.h and RefBase.h
- Move destructors for MessageHandler and LooperCallback to Looper.cpp
and ReferenceRenamer and VirtualLightRefBase to RefBase.cpp to prevent
vtables in every compilation unit.
- Declare template variables in Singleton.h
- Fix old-style casts in StrongPointer.h and TypeHelpers.h
- Use template metaprogramming in TypeHelpers.h to avoid warnings on
memmove on non-trivial types.
- Add an assignment operator to key_value_pair_t to complete
rule-of-three
- Use memcpy instead of dereferencing a reinterpret_casted pointer to
treat the bits of a float or double as int32_t or int64_t
- Escape unicode sequences inside doxygen comments between \code and
\endcode
- Remove WIN32 ZD definition in Compat.h, %zd works fine with mingw
- Fix WIN32 printf warnings in Filemap.cpp
- Initialize mNullValue with 0 in LruCache.h, some of the tests use a
non-pointer type for TValue.
Test: m -j native
Bug: 31492149
Change-Id: I385a05a3ca01258e44fe3b37ef77e4aaff547b26
/system/core/libutils/FileMap.cpp
|
| 6f8885bc143460d77f300a981169e0487ff923c1 |
|
23-Sep-2015 |
Adam Lesinski <adamlesinski@google.com> |
Implement C++11 move semantics for android::FileMap
FileMaps should be movable, thereby not requiring them to be only used
with a unique_ptr as they currently are.
Change-Id: I0fb8013bf398a2ced5420d85ba888c2a7fc5a496
/system/core/libutils/FileMap.cpp
|
| 6832a7a4e04c84192f0bafc6ac990fc79cd13882 |
|
23-Feb-2015 |
Narayan Kamath <narayan@google.com> |
Remove useless refCounting from FileMap.
Nobody ever called acquire() so release() was always
equivalent to delete. Just use delete instead so that
people can use unique_ptr directly (or shared_ptr if
they really want refcounts).
Change-Id: I9e3ad5e0f6a4fcc4e02e5a2ff7ef9514fe234415
/system/core/libutils/FileMap.cpp
|
| 5955a9f5e4dee9fdcad113943771e8f9a2138748 |
|
19-Feb-2015 |
Narayan Kamath <narayan@google.com> |
Remove reference to NOT_USING_KLIBC and cygwin.
The reference to NOT_USING_KLIBC appears to be the only one
in our codebase. This change also removes some cygwin specific
retry logic - all other supported platforms in this section
of the code should support mapping at an offset.
Note that i've reversed the sense of the check, we always sysconf
since that's recommended practice.
Change-Id: Ib985fb665193d7a07a282f7092cd77c0bc508a66
/system/core/libutils/FileMap.cpp
|
| 745c5f6ad01ece07b0163d0b5869994bceb26b1a |
|
19-Nov-2014 |
Yabin Cui <yabinc@google.com> |
kill HAVE_MADVISE
Change to avoid "unused parameter" warning.
Bug: 18397020
Change-Id: I4b26de55314c78237daead8e873385b97cafe4d4
/system/core/libutils/FileMap.cpp
|
| 819b480b935a99fc8114b622644f42dec9e3a177 |
|
19-Nov-2014 |
Yabin Cui <yabinc@google.com> |
kill HAVE_MADVISE
Bug: 18397020
Change-Id: Ibc8d886d729c51932a403531888214de4e541452
/system/core/libutils/FileMap.cpp
|
| 266092c52dea85daaa14c671c1a2f133330f0ed8 |
|
11-Nov-2014 |
Yabin Cui <yabinc@google.com> |
kill HAVE_POSIX_FILEMAP
Bug: 18315579
Change-Id: I0bd5fb946b12cb90e0c9c73a478df41609b8c3e2
/system/core/libutils/FileMap.cpp
|
| 1a55aa5e34f201b060da9a84ec9702401f05be18 |
|
16-Oct-2014 |
Xavier Ducrohet <xav@google.com> |
Fix windows specific behavior of FileMap
The implementation of the FileMap destructor would
close the file, only on Windows, which did not match
the behavior on mac/linux.
This is because calling munmap does not close the file
descriptor. It must be closed separately, before or after
munmap.
On Windows, the file must also be closed manually,
before or after closing the mappingFile.
The change basically removes the closing file from
the windows-specific part of the destructor, to
make behavior more consistent on all platforms
where the caller to FileMap is responsible for closing
its own file (since FileMap receives an opened file).
Change-Id: I5e3cfffbb870d5f3595802ccac57dbc1dbf1ce6e
/system/core/libutils/FileMap.cpp
|
| 5bed8036644f552210a7cfcbed2d6d20cf2981b0 |
|
30-Apr-2014 |
Mark Salyzyn <salyzyn@google.com> |
libutils: turn on -Werror
- Deal with some -Wunused issues
- Override PRI macros (windows)
- Revert use of PRI macros on off64_t (linux)
- Deal with a gnu++11 complaince issue
Change-Id: Ie66751293bd84477a5a6dfd8a57e700a16e36964
/system/core/libutils/FileMap.cpp
|
| b618576ff1dc0cf66e985a6204f83438c1dbcca0 |
|
17-Apr-2014 |
Mark Salyzyn <salyzyn@google.com> |
libutils: FileMap styling adjustments
Change-Id: I487ebe67a46a7b8f680e722141dd216bbd396f3e
/system/core/libutils/FileMap.cpp
|
| 15085a6a2cc958a45035d6ec1aa6669a743ada70 |
|
17-Apr-2014 |
Mark Salyzyn <salyzyn@google.com> |
libutils: FileMap 64 bit compile issues
Change-Id: Ie7a0aeb2a7e2d2a90aa2b97c657ea7ec566bf793
/system/core/libutils/FileMap.cpp
|
| d98e07fdf9c338589f263c47ce5c844ed43efad5 |
|
02-Aug-2013 |
Alex Ray <aray@google.com> |
move libs/utils to libutils
Change-Id: I6cf4268599460791414882f91eeb88a992fbd29d
/system/core/libutils/FileMap.cpp
|