| 558282bfe4650f7b249f5ba0a24d3a400d67b78b |
|
03-Apr-2017 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: introduce logcatd executable
logcatd is the same as logcat, except that the -L flag, if supplied,
runs once, then the command re-runs itself without the -L flag with
the same argument set. By introducing a logcatd daemon executable
we can solve the problem of the longish reads from pstore that
sometimes occur when the system is excessively busy, starving this
background cgroup daemon as we absorb the delay in a backgrounded
init "service", rather than in a forgrounded init "exec". This would
not have been efficiently possible without the introduction of
liblogcat.
There are no doubt many flags that make no sense to run twice with,
and without, the -L flag. In the general sense we expect the caller
to perform the correct set of operations and not pick these nonsense
operations. logcatd is only supplied on engineering and debug builds
for logpersist, and is only an automated aid to triage.
Test: gTest logcat-unit-tests
Test: manual confirm logpersist functions as expected, required reboot
Bug: 28788401
Bug: 30041146
Bug: 30612424
Bug: 35326290
Change-Id: I53ba31970749daf37eef42636f039f485932416f
/system/core/logcat/logcatd.rc
|
| c91c4446a6d24e439ff69f4a22fbd2e24bd18800 |
|
08-Aug-2016 |
Mark Salyzyn <salyzyn@google.com> |
resolve merge conflicts of 5f6dbd9 to nyc-mr1-dev-plus-aosp
Change-Id: Ia85ca9ea4c38d270229af394c351b7b31ea2057e
|
| 9b35df6517c9fbd1409e1a7ee0d2e021646fd38c |
|
04-Aug-2016 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: Add --id=${ro.build.id}
If a new build lands, this will automatically clear out old
logs in /data/misc/logd/ that may no longer be relevant.
Bug: 30591615
Change-Id: Iecf61bb2a4928ce4b2e8cc6a3b122b7ae598d268
/system/core/logcat/logcatd.rc
|
| 90a3f81c9e3d101d92ed99532b8f9a270894da7c |
|
15-Jun-2016 |
Ruchi Kandoi <kandoiruchi@google.com> |
logd: logcat -L takes longer causing vold to timeout.
Temporary fix to prevent device from getting stuck at boot.
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
Bug: 28788401
Bug: 30041146
Bug: 30612424
Bug: 30630936
Change-Id: Ie4246fc3c9eb7a3af2cb909546811c85997515da
/system/core/logcat/logcatd.rc
|
| df5d12850aa114c3cd5b2913762524c55d8d2b37 |
|
07-Jul-2016 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: trampoline persist.logd.logpersistd to logd.logpersistd
(cherry pick from 2591d483c83a09eb8689e6e7869b4ac0bfe418db)
Best practices so that device can set logd.logpersistd properties.
Values can be overriden with trampolines for persist.logd.logpersistd
values except as designed for empty content to keep out of the way.
This allows us to set logd.logpersistd* for a non-persistent collection
that does not survive a reboot, and to use persist.logd.logpersistd*
for persistent collection that does survive a reboot.
Added logd.logpersistd.enable to gate when logpersist service can be
run allowing the properties to be adjusted safely prior to this state
as is the case for device property.
NB: /init will complain when trying to trampoline an empty property,
this is acceptable for functionality, but may be considered
annoying from the logging perspective.
Bug: 28788401
Bug: 28813587
Bug: 28936216
Bug: 29831823
Change-Id: I97317e8eedfae4daa8e3ef39e64e7c5c23d8b573
/system/core/logcat/logcatd.rc
|
| 2d737011d6ba4389b15c7ac62b8964208391b884 |
|
06-Jun-2016 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: add stop and clear actions
(cherry pick from commit cd5118bf1edc257cfd4ff02ea1145b5d7b3153d9)
- add stop and clear (and stop) actions to logcatd.rc
- use stop and clear actions in logpersist script
Bug: 28788401
Bug: 28813587
Bug: 28936216
Change-Id: Id05118fb51e40609fd7b3a934cf9302f67ef6d1d
/system/core/logcat/logcatd.rc
|
| 515f091f5e7201ef5e4fef867f4ed29a8fda749a |
|
12-Apr-2016 |
Mark Salyzyn <salyzyn@google.com> |
logpersist: incorporate size and buffer tunables
- Add hidden -n and -b flags that propagate to the underlying
logcat command. Publish aliases in help as --size and --buffer.
- Add --clear for start command so it clears before starting
- shell script bloating up to deal with option validation and
provide ERROR: and WARNING: advice.
ToDo:
- Deprecate shell script and replace with Eng and Userdebug
only Developer Options, before it becomes too powerful
or bloated to force us to rewrite an expendable like this
into C++.
Bug: 28120456
Bug: 28788401
Change-Id: I0dff8acaa1e5c929454760cfa2801924956bc25d
/system/core/logcat/logcatd.rc
|
| aa3a56539dd753bafe676717bc1ae7e11e6d7a73 |
|
30-Jun-2016 |
Thierry Strudel <tstrudel@google.com> |
Revert "logd: logcat -L takes longer causing vold to timeout."
This reverts commit c1b26acae295034e7aab2414ba50047cc889cafe.
Bug: 28788401
Change-Id: I415530deb7587d1068f42971762b418b0524663c
/system/core/logcat/logcatd.rc
|
| 2591d483c83a09eb8689e6e7869b4ac0bfe418db |
|
07-Jul-2016 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: trampoline persist.logd.logpersistd to logd.logpersistd
Best practices so that device can set logd.logpersistd properties.
Values can be overriden with trampolines for persist.logd.logpersistd
values except as designed for empty content to keep out of the way.
This allows us to set logd.logpersistd* for a non-persistent collection
that does not survive a reboot, and to use persist.logd.logpersistd*
for persistent collection that does survive a reboot.
Added logd.logpersistd.enable to gate when logpersist service can be
run allowing the properties to be adjusted safely prior to this state
as is the case for device property.
NB: /init will complain when trying to trampoline an empty property,
this is acceptable for functionality, but may be considered
annoying from the logging perspective.
Bug: 28936216
Bug: 29831823
Change-Id: I97317e8eedfae4daa8e3ef39e64e7c5c23d8b573
/system/core/logcat/logcatd.rc
|
| c1b26acae295034e7aab2414ba50047cc889cafe |
|
15-Jun-2016 |
Ruchi Kandoi <kandoiruchi@google.com> |
logd: logcat -L takes longer causing vold to timeout.
Temporary fix to prevent device from getting stuck at boot.
Bug: 28788401
Change-Id: Ie4246fc3c9eb7a3af2cb909546811c85997515da
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
/system/core/logcat/logcatd.rc
|
| cd5118bf1edc257cfd4ff02ea1145b5d7b3153d9 |
|
06-Jun-2016 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: add stop and clear actions
- add stop and clear (and stop) actions to logcatd.rc
- use stop and clear actions in logpersist script
Bug: 28936216
Change-Id: Id05118fb51e40609fd7b3a934cf9302f67ef6d1d
/system/core/logcat/logcatd.rc
|
| 2e210e4650f3e1ce9be6c7933b4bcbbc12c8eeb7 |
|
12-Apr-2016 |
Mark Salyzyn <salyzyn@google.com> |
logpersist: incorporate size and buffer tunables
- Add hidden -n and -b flags that propagate to the underlying
logcat command. Publish aliases in help as --size and --buffer.
- Add --clear for start command so it clears before starting
- shell script bloating up to deal with option validation and
provide ERROR: and WARNING: advice.
ToDo:
- Deprecate shell script and replace with Eng and Userdebug
only Developer Options, before it becomes too powerful
or bloated to force us to rewrite an expendable like this
into C++.
Bug: 28120456
Change-Id: I0dff8acaa1e5c929454760cfa2801924956bc25d
/system/core/logcat/logcatd.rc
|
| 3cbc7e7eaa20877facfaa78f4dca247f335a2a6a |
|
22-Sep-2015 |
Mark Salyzyn <salyzyn@google.com> |
am 6e78a2c5: am 6eec17e3: Merge "logcatd: up size from 16MB to 256MB"
* commit '6e78a2c5b6a052043b01ba36de21e7aec49c8735':
logcatd: up size from 16MB to 256MB
|
| 984bd8323dcb5e494a04b2058ab7de40bf347ee5 |
|
21-Sep-2015 |
Tom Cherry <tomcherry@google.com> |
resolved conflicts for 5caca3dd to mnc-dr-dev-plus-aosp
Change-Id: I773e514a8232b77cdd566dc36c9efc4e15f206f0
|
| 3ffbdb9009087529e0da1d64ba5f61fbefc4a12f |
|
21-Sep-2015 |
Mark Salyzyn <salyzyn@google.com> |
logcatd: up size from 16MB to 256MB
Change-Id: Ic151d42151efdb3103470ba46c626a800cf29125
/system/core/logcat/logcatd.rc
|
| 20391b1de5aaa49657d625fe18a36d4484c6ac31 |
|
14-Aug-2015 |
Tom Cherry <tomcherry@google.com> |
bundle init.rc contents with its service
Bug: 23186545
Change-Id: I52616b8ab1165fdef716f9b8f958665f2308c12e
/system/core/logcat/logcatd.rc
|