History log of /system/media/camera/tests/camera_metadata_tests.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
0b47c6ef73b7ca796b506c9b3feb50343863ce9c 05-May-2017 Eino-Ville Talvala <etalvala@google.com> Camera metadata: Fix validation alignment check, add more unit tests

- Add unit test to ensure validate_camera_metadata_structure correctly
reports VALIDATION_SHIFTED for all shifts
- Fix alignment validation bug found by unit test - need to offset
pointer on both sides of align check.

Test: New unit test passes, no camera CTS regression
Bug: 37980415
Change-Id: I08379bf3792b57c4eae129acc7aa4f22ab960657
/system/media/camera/tests/camera_metadata_tests.cpp
4df5a2bb302fb5cb61ab48dff7fa2b1984b6ced8 10-Jan-2017 Mark Salyzyn <salyzyn@google.com> liblog: use log/log.h when utilizing ALOG macros

Test: compile
Bug: 30465923
Change-Id: I4329b7dc918b732b07662a27c52e3b431ffabd3d
/system/media/camera/tests/camera_metadata_tests.cpp
8198c3b752e2fb00acb15345496e2a03eefb5ffb 29-Sep-2016 Mark Salyzyn <salyzyn@google.com> media: Replace cutils/log.h with android/log.h or log/log.h

- replace cutils/log.h with android/log.h (main buffer logging)
- replace cutils/log.h with log.log.h (+SafetyNet logging)

Test: compile
Bug: 26552300
Bug: 32189077
Change-Id: Icda4d5ab7555c0b801fd362fdcfa65b1500612b4
/system/media/camera/tests/camera_metadata_tests.cpp
aa7948f4cba3db04dd42586f5d06711f443e0c56 18-Feb-2016 Eino-Ville Talvala <etalvala@google.com> Camera: Set warnings as errors, and fix a few of them

Bug: 27149500
Change-Id: Iddccb3bb7f0ca229d4c42f68d0c80fa91c3c4665
/system/media/camera/tests/camera_metadata_tests.cpp
8baea5c0846f99e9305ffddb174e6cbb2d100a55 03-Feb-2016 Dan Albert <danalbert@google.com> Fix warnings in system/media/camera.

Bug: http://b/26936282
Change-Id: Ibc4830838c471272ad25e78a0c1ea098175ac6cc
/system/media/camera/tests/camera_metadata_tests.cpp
21532655a531cf1168f10b8b974e2cef3061dd91 30-May-2014 Narayan Kamath <narayan@google.com> LP64 fixes for camera_metadata.

camera_metadata packets are transferred across process
boundaries with Parcel::readBlob / Parcel::writeBlob calls
so we should make sure they have a consistent layout across
32 and 64 bit processes. In this change :

- Replace size_t members with uint32_t members.
- Remove the "void*" user pointer which is no longer required

Change-Id: Ia0eada5d8358be21d725c05d6105705186b3d9c8
/system/media/camera/tests/camera_metadata_tests.cpp
9c13e191ea2d9622d00621d6acb009a9a759dc92 15-Feb-2014 Ruben Brunk <rubenbrunk@google.com> camera3: Pass vendor tags through binder.

Bug: 12134423

Change-Id: Icef3fe9e67160767bdb8244ac49c85b68b497123
/system/media/camera/tests/camera_metadata_tests.cpp
246a1adacce4854b91adc9635887453ba4f58e51 26-Nov-2013 Zhijun He <zhijunhe@google.com> camera_metadata: fix metadata clone bug

clone_camera_metadata fails at validation during camera start, then crashes
camera.

Bug: 11879762
Change-Id: I9437c6724dd290aec162ae8b68be898b2f9a5b9e
/system/media/camera/tests/camera_metadata_tests.cpp
7e59ded046175c20258be150cbc94be085924d28 14-Nov-2013 Zhijun He <zhijunhe@google.com> camera_metadata: update metadata type in metadata test

android.colorCorrection.transform was updated to rational type in metadata
change.

Also cleanup the code a little bit.

Bug: 11691467
Change-Id: I71daefdfdf733d65016c51c90e04d9ac0b4b1d4a
/system/media/camera/tests/camera_metadata_tests.cpp
d1cecc16420d1e210b0643530e552e3427b2bab2 01-May-2013 Igor Murashkin <iam@google.com> camera_metadata: add validation function to ensure structural sanity

This is particularly useful when accepting copied metadata from another process,
since it could put whatever it want into the binder parcel.

Bug: 8713951
Change-Id: I72b25b2bf96230eb995bb32e3bbd68de16e122cd
/system/media/camera/tests/camera_metadata_tests.cpp
f94330452c56b7f6a513f377d3fc20fabec389c1 05-Dec-2012 Eino-Ville Talvala <etalvala@google.com> Update camera metadata tests to new enums

Change-Id: I9474f34de3c8d780f8bdbc388ddd883c123b41b9
/system/media/camera/tests/camera_metadata_tests.cpp
08b8aadab1b04a4451d06f152580df2a3ac3afef 30-Nov-2012 Igor Murashkin <iam@google.com> Camera: Generate camera_metadata_tags and HTML docs from XML

Change-Id: Ib7e9bf4855adff91a317c910aaec960f1422302a
/system/media/camera/tests/camera_metadata_tests.cpp
555aac882ed63e70019c78ccc58032a5be0f58ec 15-Nov-2012 Igor Murashkin <iam@google.com> Camera2: Fix metadata alignment for double and int64 types

* camera_metadata_rational_t was only aligning to 4 bytes, we need to align to 8
* add an automated unit test to verify alignment for each type of data

Bug: 7498597
Change-Id: Ib5554d412e09b95d21933b6015db68d01a072f90
/system/media/camera/tests/camera_metadata_tests.cpp
b10d56ad43a91924d3666127963e5fdce725389c 13-Nov-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Actually make camera_metadata memcopyable

- Use internal offsets instead of pointers for the entry and data
arrays.
- Add test to verify memcpy works and doesn't alias data.
- Remove support for forward-compatible reserved space handling, given
that it's unlikely to be useful

Bug: 7546079
Change-Id: I439aa27fed8d243b7a04155daf5e58fa1c4c730e
/system/media/camera/tests/camera_metadata_tests.cpp
3154036acd2cc809388d08ff856198a8512f05f0 08-Nov-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Fix metadata data alignment, other minor bugs.

- When a metadata entry needs to overflow into the data buffer, make
sure the starting offset is aligned to the maximum needed by all the
metadata types.
- Bounds check the data buffer size when adding a new entry
- Add new test for the bounds check
- Print out doubles correctly.

Bug: 7498597

Change-Id: Ic8645a998c096f5b803839ee8076b97862127021
/system/media/camera/tests/camera_metadata_tests.cpp
98d02fd0be8cd09479262959a542dd2620bf6074 21-May-2012 Eino-Ville Talvala <etalvala@google.com> Camera: Add opaque user pointer to camera metadata buffer

This is useful for associating a metadata buffer handed off to a third
party with its parent object, when the buffer is returned.

Change-Id: I7e19708bb3adf4da26fc6101e78c276477276608
/system/media/camera/tests/camera_metadata_tests.cpp
f5fb8a5516876c5a48cc44b4f1c99504e0b9f245 10-May-2012 Eino-Ville Talvala <etalvala@google.com> Improvements to camera metadata handling.

- Cleaner interface to get/find
- Adds delete entry, an expensive O(n) operation
- Adds update entry, which is O(n) sometimes
- Minor bugfixes:
- Keep sorted state when appending empty buffers
- Misspelling of camera_metadata_type_size in header
- Missing entry in type name array

Bug: 6243944
Change-Id: I316507d6adcc22aff6e7c464c6c484f31ef1510d
/system/media/camera/tests/camera_metadata_tests.cpp
94c1901a96c268f55012809f8261f2ec89c16dea 05-Apr-2012 Eino-Ville Talvala <etalvala@google.com> Improvements to the camera metadata structure

- Add vendor_tag_query_ops_t as argument to methods inside it.

- Add version and flags fields

- Add sorted flag; additions and appends are not sorted, and thus
reset the flag.

- Add sort method, which sets the sorted flag.

- Add find-by-tag method, which uses a linear search on a non-sorted
buffer, and a binary search on a sorted buffer.

- Change dump method to take in a fd, like the HAL-level dump methods
do.

- Minor revisions to tag definitions, including a few enums for
enumerated-value tags.

Change-Id: I5f37e326519bda032cb3362da4ab3bf50eb98b4e
/system/media/camera/tests/camera_metadata_tests.cpp
d8afb4d1a4245b2a9d722cbb358a4d6febed89cf 10-Feb-2012 Eino-Ville Talvala <etalvala@google.com> Add a camera metadata structure and utility methods

Change-Id: I320cc33f31ebd8ce183572a447df8fae691eec0d
/system/media/camera/tests/camera_metadata_tests.cpp