History log of /system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
72de70c82f0a816b235c77288ccd23f17d2e74a7 27-Mar-2017 Ruchi Kandoi <kandoiruchi@google.com> isNxpConfigModified() is only used for debug purpose, removing it.

Test: compiles
Bug: 35710290
Change-Id: I56d30a2c0edd5969164227be3b1e28bee58a38f2
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
821e838a51486878fef08744464fe2a5a26ec801 30-Mar-2017 Love Khanna <love.khanna@nxp.com> Added check to avoid buffer overflow.

Bug: 36178213
Bug: 36646774
Test: Manual
Change-Id: I8282b24dabcfe44316db5b719f1e35713f353240
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
ccebad466e4fc69c63bb85d158d1ed3351393682 23-Mar-2017 Ruchi Kandoi <kandoiruchi@google.com> Revert "Fixed testcase for Nfc VTS"

This reverts commit c48bb5ff388c2c8947cbe402af72886caa794569.
Bug: 36561231
Change-Id: Id396ce3aa0f590a159bc519a8753f6cefad506b2
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
c48bb5ff388c2c8947cbe402af72886caa794569 02-Mar-2017 Love Khanna <love.khanna@nxp.com> Fixed testcase for Nfc VTS

- Call coreInitialized() with different data
For unexpected data coreInitialized() will return
non zero value.

Test: VTS test passes
Change-Id: Idc6d3cf4398cbf7940c4858dc048e9ff6144602f
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
63f0a64a173a498d11e559b83b7c681ce77f939e 08-Feb-2017 Manoj Gupta <manojgupta@google.com> Fix clang static analyzer warnings.

system/nfc/halimpl/pn54x/tml/phTmlNfc.c:545:17: warning: Access to field
'pDevHandle' results in a dereference of a null pointer (loaded from
variable 'gpphTmlNfc_Context') [clang-analyzer-core.NullDereference]

system/nfc/halimpl/pn54x/hal/phNxpNciHal.c:461:25: warning: Result of
'malloc' is converted to a pointer of type 'char', which is incompatible
with sizeof operand type 'char *'.

system/nfc/halimpl/pn54x/self-test/phNxpNciHal_SelfTest.c:1291:25:
warning: Result of 'malloc' is converted to a pointer of type 'char',
which is incompatible with sizeof operand type 'char *'

Test: Warnings no longer appears.
Change-Id: I7442d1b90670170c2bd179684156a934894411d0
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
17a5634495c4acea7d81222ecf13f232a1efb6a4 27-Feb-2017 Love Khanna <love.khanna@nxp.com> Fix HAL implementation to check for error cases

- Call close() after close()
- Call open() after open()
- Call powerCycle() after close()
- Call write() after close()
- Call coreInitialized() after close()

Test: VTS test passes
Change-Id: Icce0c264cfc9bafb42982ef910433eda36a05729
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
6fca02d5010de7bd31d83b853c32138021da5f29 30-Jan-2017 Ruchi Kandoi <kandoiruchi@google.com> Apply clang-format

find * | grep "\.[ch]" | xargs clang-format --style=file -i

Test: compiles
Change-Id: Id9b790d9685f7ba5ba1bcec1149619b63c2e679a
signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
4a179646f6d5567830a0383050aee7610a0222a6 04-Jan-2017 Ruchi Kandoi <kandoiruchi@google.com> Replace TRUE/FALSE directives with standard true/false

@@
expression E;
@@

(
-E = TRUE
+E = true
|
-E == TRUE
+E == true
|
-E != TRUE
+E != true
|
-E ? TRUE : FALSE
+E ? true : false
)

@@
@@

(
-return TRUE;
+return true;
)

@@
identifier fn;
@@

fn (...,
-TRUE,
+true,
...)

type T1;
identifier i1;
@@

T1 i1 = {
- TRUE,
+ true,
...};

Test: Compiles
Change-Id: I633924fe6bc6a4c3f50634c5e1c6d75fb1d3258f
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
512ee63c7cc8feb016863e507a5d33cd0f4242bf 03-Jan-2017 Ruchi Kandoi <kandoiruchi@google.com> Changes data types to standard types.

platform/system/bt/tools/scripts/change_types.sh was used to convert:
UINT8->uint8_t
UINT32->uint32_t
UINT16->uint16_t
INT8->int8_t
INT32->int32_t
INT16->int16_t

Test: Compiles
Change-Id: I7fce2cbff75a2087db46cda7527437a46a627c46
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
5b5f7b71d2d87ad7b4ec55138951b3ffbb5306bf 17-Jun-2016 Jizhou Liao <Jizhou.Liao@nxp.com> Fix warnings in HAL.

Fix warnings in HAL.

Change-Id: I65367c9d9d90b8cf0897880b01d4930f1a836294
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
36d7231ec9344bed2996be1293e97d082fa22294 01-Mar-2016 Jizhou Liao <Jizhou.Liao@nxp.com> Support NXP PN551 NFC controller

The changes to support PN551 controller:
- New firmware download sequence
- New build option&configuration file
- Remove all warnings
- Bug fix

Change-Id: Ic7cedf067d2f3c7fa554c93a07bbc1c056ec44cc
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
aeacb8fcb70d855f5f2ddb1d24f078538409966f 10-May-2016 Martijn Coenen <maco@google.com> Merge "Configure nfc device node through .conf file"
3118b0c2dc9cc66f8c8bde7ebfdb232ca5d59f7f 01-Mar-2016 Jizhou Liao <Jizhou.Liao@nxp.com> Configure nfc device node through .conf file

NXP_NFC_DEV_NODE is used to specify nfc device node name
in libnfc-nxp.conf.

Change-Id: I203249c355504a330891788ae7a4013a431d4cf0
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
b98e5975e665aedf5e786133cbf88986d03ac501 01-Mar-2016 Jizhou Liao <Jizhou.Liao@nxp.com> Abort NFC initialization if chip type doesn't match to HAL implemetation.

Compare firmware versions on chip and HAL implemetation,
if mismatch, abort nfc initialization.

Change-Id: I3594e7a94ee927155d92a4b56bf4c732a6aff70a
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
c22a07fdcd13c148c0d2db7317397da2a6345f0b 25-Sep-2015 Jizhou Liao <Jizhou.Liao@nxp.com> Fix fail to write RF parameters

Whenever receive invalid param respons during RF parameter update,
this recovery mechanism includes dummy firmware download
followed by firmware download and then re-update RF parameters.

Bug: 24196800
Change-Id: I8e47a86ff98a9ca8c30be52c231fd284cd825f4d
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
ae2234d1cdd7c35543a795dcb51a6537ffce2007 22-Aug-2015 Jizhou Liao <Jizhou.Liao@nxp.com> add recovery mechanism on CORE_RESET_NTF

The recovery re-init NFC by keeping configuration.
This recovers P2P issue while CORE_RESET_NTF is received.

Bug: 23520630
Change-Id: If2296558064029972b61823861d47e47400cc8dc
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
7b6b94cbca2aaf93afc4bb32094d143e46daf4ad 12-Aug-2015 Jizhou Liao <Jizhou.Liao@nxp.com> Fix stuck issue on Kovio barcode

Fix stack stuck issue if disabling Nfc when kovio barcode is just detecting.

Change-Id: I5e77e1772c3211436fea5279233f26c139e8313f
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
45bb89562aca92282c5929954e855596125c14c0 29-Jun-2015 Jizhou Liao <Jizhou.Liao@nxp.com> Update customized settings to eeprom after firmware download

The customized RF, clock settings have to be updated to eeprom after
firmware download

Change-Id: I5261590206b0cc15587fc8c6ea240b97b91da429
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c
121096a3511ea4ac559dea3ef7d39f0df00c97a6 19-May-2015 Jizhou Liao <Jizhou.Liao@nxp.com> Adding NXP NCI Hal implementation (DO NOT MERGE.)

This patch includes Hal implementation
of NXP's NCI based NFC controller.

Change-Id: I6ee7fac309aebb52ae3d7c197685df729751ee52
/system/nfc/halimpl/pn54x/hal/phNxpNciHal.c