History log of /external/autotest/client/common_lib/cros/network/ping_runner.py
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
187e24e6c560ebe70134ada818f123c6015f2d36 06-Feb-2016 Dane Pollock <danepollock@google.com> autotest: Refactor ping_runner for multi-platform.

There is a desire to add MacOS hosts to WiFi testbeds, so this is an attempt
to extend ping_runner functionality to support multiple platforms which require
different ping arguments and parsing logic, while still keeping the same
external interface. Repurposed PingConfig to only implement very basic input
validation, and command timeout calculation (common between platforms). Added
'PingDelegate' classes which know how to map a PingConfig to arguments, and
implement the (fairly similar) parsing logic of the output. The platform type
is selected when instantiating the ping_runner, and the external interface is
unchanged.

BUG=None
TEST=Ran jetstream_Connect to test linux/chromeos ping_runner behavior is
unaffected, stub test to verify MacOS ping_runner in a variety of
scenarios: simple ping, positive/negative test of pings on local subnet,
positive/negative test of pings to a different subnet.

Change-Id: I5be0a7517618572d03739cf966b17d5170d97025
Reviewed-on: https://chromium-review.googlesource.com/326501
Commit-Ready: Dane Pollock <danepollock@google.com>
Tested-by: Dane Pollock <danepollock@google.com>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
2d09970d172f20558d3d1ba40379cbe03ffc7d66 25-Jul-2014 Christopher Wiley <wiley@chromium.org> Wait up to 2 minutes for ping results

We've seen recent issues where ping/arping commands time out because
of overly strict timeouts on SSH processes. Given that we're not trying
to test the reliability of the lab network, give ourselves tons of room
for error.

TEST=network_WiFi_SimpleConnect.wifi_checkWPA_TKIP still passes.
network_WiFi_GTK also passes.
BUG=chromium:393359

Change-Id: I243cf4fff6be329098db93ab847c840c0866427b
Reviewed-on: https://chromium-review.googlesource.com/209856
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
607319ac3ad78457ae7f324f7fb00acba8562463 12-Jul-2014 Christopher Wiley <wiley@chromium.org> Increase margin for ping timeouts in WiFi tests

BUG=chromium:393359
TEST=None

Change-Id: I9249f3b62b060f1107be0ce08dec2c175355d2eb
Reviewed-on: https://chromium-review.googlesource.com/207696
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
9adeb2a17deb873553f654beddfa5750de80434d 19-Jun-2014 Christopher Wiley <wiley@chromium.org> Allow creation of WiFi router proxies outside of WiFi Tests

This enables us to construct just a LinuxRouter, instead of depending on
the WiFiTestContextManager and LinuxRouter to handle this process.

TEST=network_WiFi_SimpleConnect.wifi_checkWPA_TKIP still passes
BUG=chromium:365879

Change-Id: I3d79b84aafb7262801b3b93125025cab0ad17488
Reviewed-on: https://chromium-review.googlesource.com/204744
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
2461fe8a58dc190725be5b34d0e984edf9a5ce72 20-Feb-2014 Christopher Wiley <wiley@chromium.org> WiFi Attenuators are optional equipment for WiFi tests

Fix PingRunner to tolerate bad DNS names being passed for hostnames.
Fix WiFiTestContextManager to tolerate missing attenuator address
parameters when outside a test context.

BUG=chromium:345421
TEST=SimpleConnect tests pass in a lab context. When the check for
"is this host in a lab" is hacked to return False (and the router
address passed in via the command line), tests still pass.

Change-Id: Ie7b7347d85573513a98aaf02d485b1cb2d0bd887
Reviewed-on: https://chromium-review.googlesource.com/187309
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
3628d66f4fdf896acd8ae979a841f179624a844c 10-Feb-2014 Christopher Wiley <wiley@chromium.org> Ignore ping timeouts in WiFi tests

There appear to be situations where pings will timeout in WiFi
tests when every ping fails and ping waits for those failures.
Tolerate this by allowing timeouts and treating them as total
loss events.

While here, remove legacy method calls for old style WiFi tests.

TEST=network_WiFi_SimpleConnect.wifi_checkWPA_TKIP still passes.
BUG=chromium:342413

Change-Id: I138e16ad86b90083ef7eacedba42138f4b585ee3
Reviewed-on: https://chromium-review.googlesource.com/185953
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
e86b1c0bf64a168c9ba948a8355c6b27fe04f01a 26-Jul-2013 Christopher Wiley <wiley@chromium.org> autotest: Make ping transmission statistic parsing more robust

The discovery of another failure mode for ping transmission line parsing
implores us to parse in a more failure resistant way.

TEST=Ran test that utilize ping result parsing successfully.
BUG=None

Change-Id: I2d6b8aab2107f7dfca34bb61e415e2eb13fddc05
Reviewed-on: https://gerrit.chromium.org/gerrit/63417
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py
6aafdddb12ec6c324d6c9d4e931058effb083f0c 19-Jul-2013 Christopher Wiley <wiley@chromium.org> autotest: Refactor ping related logic into a delegate

Consolidate server and client related ping code into a centralized
delegate that we can reuse in both places. Removed dead logic to do
background pings, particularly since this logic was deemed dangerous
by the testlab team.

BUG=chromium:263197
TEST=Ran suite:wifi_matfunc with only unrelated test flake.

Change-Id: Iec07646639e5681886dd771a2dd7afb4b02e3aa7
Reviewed-on: https://gerrit.chromium.org/gerrit/62924
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/external/autotest/client/common_lib/cros/network/ping_runner.py