| 313f06f4ba1c3dc732959c42f694422305ef488e |
|
15-Dec-2015 |
David Haddock <dhaddock@chromium.org> |
Remove mentions of Biopic in the image comparison code.
Biopic is depreacted and we have switched to using pdiff and a generated
report over the biopic tool. This CL removes the biopic code and
references to it.
BUG=None
TEST=None
Change-Id: I8748ccb25c37eb63f4ea8d72987ea9d926702060
Reviewed-on: https://chromium-review.googlesource.com/317984
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Mussa Kiroga <mussa@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|
| df273ebb91deedcc4f6b18ab333e21b46a5deb90 |
|
11-Mar-2015 |
Mussa <mussa@chromium.org> |
Alert person looking at image comparison test results that tests
are UI based image comparison.
Because Image comparison video tests are based on pixel comparison,
typically warrant a second look when they fail.
Add message to test failure so that if the unfamiliar person can
understand that the results depend on UI.
BUG=None.
TEST=Local testing.
Change-Id: Ibb442ede051a944396a56833e4491725827be087
Reviewed-on: https://chromium-review.googlesource.com/255766
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
Commit-Queue: Mussa Kiroga <mussa@chromium.org>
Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|
| d44595f21206f15ee9fdc75f3bd765d0cec815f7 |
|
10-Nov-2014 |
Mussa <mussa@chromium.org> |
Remove new lines in TestFail message.
verifier.py has been formatting the test fail message
to include new lines. While that makes the message readable,
the message is cut of at the new line. To display the whole message
we need to remove new lines.
BUG=None.
TEST=Ran test_that <ip> ui_SystemTray. Observed that on failure
test_that outputs the full message that contains the biopic comparison link.
Change-Id: I15c1a8fe34e35c4f743c6d4ab9023abda2c6c560
Reviewed-on: https://chromium-review.googlesource.com/228901
Reviewed-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Kris Rambish <krisr@chromium.org>
Tested-by: Mussa Kiroga <mussa@chromium.org>
Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|
| c95277635c90ee616898d1f547440eff2dafc9cb |
|
26-Sep-2014 |
Mussa <mussa@chromium.org> |
Integrate Chameleon capturing into video tests.
Video tests have been using native linux 'import' command to capture
screenshots. We are now using chameleon to capture the screenshots.
This serves as a first step to integrate chameleon into our video test
suite. We will do so only with peach_pit and roll out to other devices.
With this change we are also putting the logic to find chameleon ports
into a seperate class that can then be reused.
BUG=chromium:418217
TEST=Ran test on peach_pi.
Change-Id: I38b9ea3311b53eda937f9eb685c0dd24a24af059
Reviewed-on: https://chromium-review.googlesource.com/220202
Reviewed-by: Hung-ying Tyan <tyanh@chromium.org>
Tested-by: Mussa Kiroga <mussa@chromium.org>
Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|
| 36aaa77cb66b9250d1da2759aa29ddb1bfcb07ab |
|
09-Sep-2014 |
Mussa <mussa@chromium.org> |
Improve test failure reporting.
For our video tests we use image comparison to compare several images
captured during a test run with golden images captured ahead of time.
Currently, if such a comparison fails, testers have to go dig out
comparison links in a series of clicks/logs scouring to examine the
failed comparison.
This CL puts comparison links and other comparison test results right on
the failure message so that it is visible in wmatrix for faster
triaging.
BUG=None.
TEST=Ran video_GlitchDetection.mp4.480p tests on link and observed the
report on failure.
Change-Id: I1aa038272b2dff6cd5b9724a6a45d34f18ef096f
Reviewed-on: https://chromium-review.googlesource.com/217163
Reviewed-by: Mussa Kiroga <mussa@chromium.org>
Tested-by: Mussa Kiroga <mussa@chromium.org>
Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|
| 5f938c237602fe3d2f427d95f5311c4e22eb4408 |
|
05-Sep-2014 |
Mussa <mussa@chromium.org> |
Create ImageComparison Factory.
Fall back to rgb comparison when bp is not available.
Video tests have longed used image comparison to detect glitches.
Recently we brought image comparison logic to ui/SystemTray. The
factory logic that was once used in video tests was coupled with
responsibilites that were specific to video tests. We couldn't
reuse the factory to create just image comparison objects in ui
tests.
This change extracts the image comparison object making
responsibility of the video test factory to its own factory:
image_comparison_factory.
We also modify the clients, both video and ui tests to use this
new lightweight image comparison factory.
Also, we have noticed that sometimes bp service is not available.
This causes the test to fail because when it tries to create the
bp_comparer an exception is thrown.
Add logic to the image comparison factory that returns an rgb
comparer when an attempt to create a bp_comparer fails.
BUG=chromium:410890
TEST=Ran video_GlitchDetection test on link, verify they passed.
Ran ui_SystemTray test on link, verify they also passed.
Made bp_comparer raise an exception in its __init__
(simulating what would happen if bp service were not available).
Ensured rgb_comparer was used although the test had asked
for bp_comparer.
Change-Id: I08a9a1d5b6a7fc25b2013ecc95204910f8871267
Reviewed-on: https://chromium-review.googlesource.com/216773
Commit-Queue: Mussa Kiroga <mussa@chromium.org>
Tested-by: Mussa Kiroga <mussa@chromium.org>
Reviewed-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/cros/image_comparison/verifier.py
|