| 7652073dc433f11d8ea7f9b836dc70ffd20c19dd |
|
12-Jul-2017 |
Josh Horwich <jhorwich@chromium.org> |
security_ASLR: More robust PID calculation.
security_ASLR test wants to find the PID of a single process by name
that is also a child of a named parent process. Unfortunately, the
selection of the PPID to filter the process list is currently
somewhat arbitrary - recently we added a "use the lowest PID"
heuristic to work around the fact that there could be multiple
'init' processes.
This change instead makes the code find all candidate PPIDs, then
filter the ps output to match any PPID, and only succeed if it
finds exactly one PID/PPID pair that match the names.
BUG=chromium:741110
TEST=test_that security_ASLR # passes with multiple 'init' processes
TEST=test_that security_ASLR # catches missing pid with \
update_engine stopped.
Change-Id: I8185248f2dc1b80f706f1f97c11a0ff7a4fd35fd
Reviewed-on: https://chromium-review.googlesource.com/568905
Commit-Ready: Josh Horwich <jhorwich@chromium.org>
Tested-by: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 2e9d07d7ab41de38d9f2e3e62fd92fee78e830ea |
|
12-Jul-2017 |
Jorge Lucangeli Obes <jorgelo@chromium.org> |
security_ASLR: Fix _pidof.
_pidof was getting confused when more than one process with the same
name existed, and in the case of 'init', it was returning the wrong
result. Fix by getting all the pids for a particular name, then
selecting the smallest one.
BUG=chromium:741110
TEST=Passes on minnie.
Change-Id: Ib29ee3662c5d62832ab17078bbaef4da3cfafdc2
Reviewed-on: https://chromium-review.googlesource.com/568358
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| e04cc7967aba1652f1922bb04bafa7d417870210 |
|
12-Dec-2016 |
Luis Hector Chavez <lhchavez@google.com> |
security_ASLR: Make finding processes more robust
There have been a few flaky runs where the first line of `pidof ${name}`
is not the process we were looking for and goes away before we are able
to look for /proc/${pid}/maps. This change removes the code path where
we only look at `pidof` and instead always requires that the parent
process is specified to reduce flake.
BUG=chromium:618382
TEST=test_that cyan security_ASLR
TEST=test_that lakitu security_ASLR
Change-Id: I5d296657da7c6561da86266724692f9659c15163
Reviewed-on: https://chromium-review.googlesource.com/419096
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Daniel Wang <wonderfly@google.com>
Reviewed-by: Andrey Ulanov <andreyu@google.com>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 0b23f4e12aded102b49a7ae4f177a88354fccd10 |
|
21-Sep-2016 |
Ke Wu <mikewu@google.com> |
Reset Systemd restart counter to avoid restart rate limiting
BUG=b:31549026
TEST="cbuildbot --remote -g 387727 lakitu_next-paladin" looks good
cbuildbot link:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/paladin/builds/1498
Change-Id: Iec4cd13080d647c9a1ff7fb950da3d8e9a691cd3
Reviewed-on: https://chromium-review.googlesource.com/387727
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Ke Wu <mikewu@google.com>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| d928ab545f8142a5d2e0d0f5a72272cebddfdb92 |
|
10-May-2016 |
Andrey Ulanov <andreyu@google.com> |
security_ASLR: add systemd-journald as the test process
After CL:*258563 start of update_engine on lakitu may be delayed.
This change adds journald as another process that the test can use.
BUG=None
TEST=security_ASLR passes
Change-Id: I340f8ec7c6e47794a5c55a728f7a5cebf067baa1
Reviewed-on: https://chromium-review.googlesource.com/343991
Commit-Ready: Andrey Ulanov <andreyu@google.com>
Tested-by: Andrey Ulanov <andreyu@google.com>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 545312dcb2b9ccfbf729df76b7929a8867095832 |
|
29-Jan-2016 |
Jorge Lucangeli Obes <jorgelo@google.com> |
security_ASLR: Fix error message.
BUG=chromium:582144
TEST=Passes on veyron_minnie, log line prints correctly on failure.
Change-Id: Ied938af89d7e5c2c58eb0147e82b7a3bad0d540a
Reviewed-on: https://chromium-review.googlesource.com/324621
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 85881df02e81f8533e9ee14f641f1180b6c3a2b8 |
|
13-Jan-2016 |
Jorge Lucangeli Obes <jorgelo@google.com> |
security_ASLR: make '_pidof' return a single PID.
The 'pidof' command can return multiple PIDs if there's more than one
process with the given name. Return only the first PID.
BUG=chromium:571884
TEST=Passes on veyron_minnie.
Change-Id: I36b890ed0db9cba6124cbd62f888fd0ea8e3a0c8
Reviewed-on: https://chromium-review.googlesource.com/321377
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Haixia Shi <hshi@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| bcb31deca5d42a7f00cfad0a900a0c0fa8e2ca76 |
|
28-Dec-2015 |
Jorge Lucangeli Obes <jorgelo@google.com> |
security_ASLR: Make _pidof() return an empty string on failure.
The code calling _pidof() assumes the function will return
an empty string on failure:
https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/client/site_tests/security_ASLR/security_ASLR.py&l=59
"""
ps_results = _pidof(self._name)
...
if ps_results != "":
return ps_results
# Retry...
"""
But by using system_output(), _pidof() is raising an uncaught exception
on failure, making the retry pointless. Fix by using 'ignore_status=True'.
BUG=571730
TEST=Still passes on veyron_minnie.
Change-Id: I2187dc68b92757dc1c653b095f73a31494344ecb
Reviewed-on: https://chromium-review.googlesource.com/319816
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Andrey Ulanov <andreyu@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| bcc64205abc88ee1ac91a7d4168020fe2f5ca5b2 |
|
15-Dec-2015 |
Andrey Ulanov <andreyu@google.com> |
security_ASLR: fix the test to pass on systemd systems
TEST=security_ASLR
BUG=b:26182668
BUG=chromium:569487
Change-Id: Ifd85357f68bcdef98437ff13a680c64941db878b
Reviewed-on: https://chromium-review.googlesource.com/318014
Commit-Ready: Andrey Ulanov <andreyu@google.com>
Tested-by: Andrey Ulanov <andreyu@google.com>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 4672de48afd807b4633d69009c2fbe18866baf16 |
|
15-Jul-2014 |
Jorge Lucangeli Obes <jorgelo@chromium.org> |
security_ASLR: don't run on ASan.
ASan bots are weird. There's no point in testing ASLR on ASan.
BUG=chromium:394036
TEST=Passes on gizmo.
Change-Id: I970c4c8db426618586b95e620615d44df7766618
Reviewed-on: https://chromium-review.googlesource.com/208127
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
Commit-Queue: Puthikorn Voravootivat <puthik@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 829c6de02152e6e8a3fe7ceb7d06f133b9dd3535 |
|
03-Jul-2014 |
Jorge Lucangeli Obes <jorgelo@chromium.org> |
security_ASLR: don't fail if some of the target programs are not available.
BUG=chromium:382282
TEST=Passes on daisy_spring and gizmo VM.
Change-Id: Ic965f94f95c03d13e92f62971f197303989bdae0
Reviewed-on: https://chromium-review.googlesource.com/206610
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 558a873d511386e0d6b7a5f69755815c6a45d1ca |
|
05-Jun-2014 |
Jorge Lucangeli Obes <jorgelo@chromium.org> |
security_ASLR: don't fail on x86-generic ASAN.
BUG=chromium:380735
TEST=Passes on bot.
Change-Id: I1d9ab361a526887f53834ef2040af20382dd4c22
Reviewed-on: https://chromium-review.googlesource.com/202619
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| bfcca23389d4df6452c3566a4499fe362b7a2627 |
|
03-Jun-2014 |
Jorge Lucangeli Obes <jorgelo@chromium.org> |
security_ASLR: skip on 32-bit ASan.
Also fix some style nits.
BUG=chromium:377600
TEST=Passes on daisy_spring, 'x86-generic ASAN' VM.
Change-Id: I394da8fb169a16dd22e231bc66018b4bff9f7765
Reviewed-on: https://chromium-review.googlesource.com/202393
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 83514ab7b8cdd32127ff35e988738f2d23406346 |
|
28-Jun-2013 |
Kees Cook <keescook@chromium.org> |
security_ASLR: fix moar typos
I should not upload while hungry. This fixes the additional typos in the
original CL.
BUG=None
TEST=security_ASLR passes normally, and when "ps" is forced to produce
empty output, actually fails correctly now
Change-Id: Icb43ca6183449f7b498789297912ae38e971160f
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/60472
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 20b86c372584a12736eafa47f83a45cf78ce3de3 |
|
27-Jun-2013 |
Kees Cook <keescook@chromium.org> |
security_ASLR: fix think-o with sleep()
Since triggering this bug has been a problem, I didn't test the failure
case very well. So badly, in fact, that I failed to notice that I needed
time.sleep(), not os.sleep(). Argh.
BUG=None
TEST=`python -c 'import time; time.sleep(1)'`
Change-Id: Ic227eacc9178d2648b0b1b551580fd90d35acec6
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/60226
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| dee8bdd0e08b7be19db1888136b6b7834bdd078a |
|
25-Jun-2013 |
Kees Cook <keescook@chromium.org> |
security_ASLR: wait for missing pids
If a process pid is not found, wait for it to appear. If it does not
appear, blow up the test and report who went missing. This also moves
documentation around to keep pylint happy.
BUG=None
TEST=security_ASLR passes
Change-Id: I6db9890cccb6a6946cb89f2781f66dbc5389eb11
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/59973
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 4646c161916ab21e6cdb218facc48c1ec0572897 |
|
27-Oct-2012 |
Elly Fong-Jones <ellyjones@chromium.org> |
[autotest] remove htpdate-related tests
htpdate is being removed, so these tests are as well. I will add appropriate
tlsdate tests once it's in the tree.
BUG=chromium-os:31505
TEST=yes
Change-Id: Iffc5c216c8ae421e6e298c94e5aca4d5ea4657c1
Signed-off-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/36734
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 699654d2fec0f3b9f715f40f1cdc3e006efc2769 |
|
15-Oct-2012 |
Jim Hebert <jimhebert@chromium.org> |
Stop checking debugd for ASLR pending fix of a blocker
BUG=chromium-os:35224
TEST=security_ASLR passes now on ToT/x86-zgb
Change-Id: I7bd085e830878b8616e36ad4e7bc672050904326
Reviewed-on: https://gerrit.chromium.org/gerrit/35618
Commit-Ready: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| e0c1c407ec593e8c4d963a835b5cdf5a506f230d |
|
18-Aug-2012 |
Jim Hebert <jimhebert@chromium.org> |
Fix a logging bug that led to false explanations for failures
Also add more verbose debug logging so we can troubleshoot
future failures better.
BUG=chromium-os:33527
TEST=run_remote_tests... security_ASLR
Change-Id: Ied9e5534576a892b44f2156f78d5fd26f60dc693
Reviewed-on: https://gerrit.chromium.org/gerrit/30782
Commit-Ready: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 5a0c0ad937b9a1a3bdb011ab8a575e340057ab70 |
|
24-Jul-2012 |
Matt Omori <momori@chromium.org> |
Reduce flake in security_ASLR
BUG=chromium-os:32264
TEST=./run_remote_tests.sh ... security_ASLR passes on x86-alex
Change-Id: Icaaf14bd8a0cb6ab8d51d3aadbcd851b005f14a2
Reviewed-on: https://gerrit.chromium.org/gerrit/28215
Tested-by: Matt Omori <momori@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Commit-Ready: Matt Omori <momori@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| 35b8dc603ffe3652592d10a9c8f35d2792c44c1f |
|
09-Jul-2012 |
Matt Omori <momori@chromium.org> |
Improve result logging for security_ASLR automated test
BUG=chromium-os:32264
TEST=run_remote_tests.sh ... security_ASLR passes on
x86-alex
Change-Id: I375f86d91b39fa5a7fbec62a7f948bf40070f2d6
Reviewed-on: https://gerrit.chromium.org/gerrit/26970
Reviewed-by: Matt Omori <momori@chromium.org>
Tested-by: Matt Omori <momori@chromium.org>
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Commit-Ready: Matt Omori <momori@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|
| c16e2173a73de4c8186d60f871f92f07d7c3f848 |
|
24-May-2012 |
Matt Omori <momori@chromium.org> |
Add automated ASLR test
BUG=none
TEST=run_remote_tests.sh ... security_ASLR passes on x86-alex/r21
Change-Id: Id348ac2b4e34aa68240105e2f3aefccaa782b700
Reviewed-on: https://gerrit.chromium.org/gerrit/23526
Tested-by: Matt Omori <momori@chromium.org>
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Matt Omori <momori@chromium.org>
Commit-Ready: Matt Omori <momori@chromium.org>
/external/autotest/client/site_tests/security_ASLR/security_ASLR.py
|