| 63cd76d6ac3bb7f90c583f240fc75e657610f2ea |
|
17-May-2015 |
Darrick J. Wong <darrick.wong@oracle.com> |
misc: fix Coverity bugs
Fix Coverity bugs 1297093, 1297096, 1297489, 1297491, 1297493,
1297506, 1297507, 1297514, 1297516, and 1297517.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 767183d45de9c53f841cc0fda0ff2eca9294cabe |
|
29-Mar-2014 |
Theodore Ts'o <tytso@mit.edu> |
logsave: make message when process has a non-zero exit code to be less scary
Addresses-Debian-Bug: #468821
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| f404167dda29a59d2be2882328aeb074b9899669 |
|
17-Dec-2013 |
Theodore Ts'o <tytso@mit.edu> |
Clean up sparse warnings
Mostly by adding static and removing excess extern qualifiers. Also
convert a few remaining non-ANSI function declarations to ANSI.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 53462aad719011c969e21fb039acd595ba027b9e |
|
24-Jul-2012 |
Theodore Ts'o <tytso@mit.edu> |
logsave: fix fd leak which could cause logsave to hang
The logsave program is leaking a file descriptor when it forks and
execs the program which forks a process which hangs around. In the
case of /etc/init.d/checkroot, this would be fsck. This file
descriptor never gets closed, so it's still present when fsck runs
e2fsck, and then if e2fsck has its own logging enabled using (in
/etc/e2fsck.conf):
[options]
log_dir = /mnt
log_filename = e2fsck-%N.%h.INFO.%D-%T
log_dir_wait = true
then e2fsck will fork off a process waiting for /mnt to get remounted
read/write. This causes logsave to never get an EOF from its pipe, so
it hangs waiting for the read to fail --- which won't happen due to
the file descriptor leak which is still being held open by e2fsck's
forked child process. And so /etc/init.d/checkroot hangs, and the
root file system never gets remounted read/write, and we deadlock.
Fix the problem by closing the pipe fd so the logsave program doesn't
end up leaking it to its descendent processes.
Addresses-Debian-Bug: #682592
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| d1154eb460efe588eaed3d439c1caaca149fa362 |
|
18-Sep-2011 |
Theodore Ts'o <tytso@mit.edu> |
Shorten compile commands run by the build system
The DEFS line in MCONFIG had gotten so long that it exceeded 4k, and
this was starting to cause some tools heartburn. It also made "make
V=1" almost useless, since trying to following the individual commands
run by make was lost in the noise of all of the defines.
So fix this by putting the configure-generated defines in lib/config.h
and the directory pathnames to lib/dirpaths.h.
In addition, clean up some vestigal defines in configure.in and in the
Makefiles to further shorten the cc command lines.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| fe65f1ecfc501b2470a20cfd9d07f4c9efa520d2 |
|
16-Sep-2011 |
Eric Sandeen <sandeen@redhat.com> |
e2fsprogs: Don't try to close an fd which is negative
These reflect either file descriptors which aren't tested
for failure, or closures of fd's which may have failed.
In setup_tdb(), test for failure of mkstemp and return
without trying to open the file (again).
In reserve_stdio_fds, rather than closing the "extra"
fd == 3 due to the way the loop is written, just
don't go that far by using while (fd <= 2).
In logsave, it forks and retries forever if open fails,
but at least make coverity happy by explicitly not
trying to close a negative file descriptor.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 05950620a807621e57008acb54602287ad768785 |
|
27-Mar-2011 |
Carsten Hey <carsten@debian.org> |
logsave: Update usage message so it is correct
Addresses-Debian-Bug: #619788
Signed-off-by: Carsten Hey <carsten@debian.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 427f95f87939e62b9903453a6b38b7f11c11d4c8 |
|
29-Jun-2009 |
Theodore Ts'o <tytso@mit.edu> |
logsave: Don't send the ^A and ^B delimiters to the console
Some terminal programs may print wierd characters when they see the
\001 or \002 characters. So filter them out if the -s option
(skip_mode) is enabled.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 6e6b71d697c9a66ab19e67ca2cad10168477a107 |
|
22-Apr-2009 |
Theodore Ts'o <tytso@mit.edu> |
logsave: Fix warn_unused_result warnings from gcc
Fixed a potential bug where by partial returns from the write(2)
system call could some bytes to be lost when writing to the log file.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| efc6f628e15de95bcd13e4f0ee223cb42115d520 |
|
28-Aug-2008 |
Theodore Ts'o <tytso@mit.edu> |
Remove trailing whitespace for the entire source tree
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| ebabf2ad6d19af5c674b624bafe619dedbc94403 |
|
13-Jul-2008 |
Theodore Ts'o <tytso@mit.edu> |
Define _XOPEN_SOURCE to 600 consistently for Solaris C99 support
Solaris's header files are very picky about which C compiler can be
used for SUSv3 conformance. Use of C99 is not compatible with SUSv2
(_XOPEN_SOURCE=500), and C89 is not compatible with SUSv3
(_XOPEN_SOURCE=600). Since we need some SUSv3 functions, consistently
use SUSv3 so that e2fsprogs will build on Solaris using c99.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 62653d99d823f5d73eba925885896d91ea8bab91 |
|
26-Mar-2008 |
Theodore Ts'o <tytso@mit.edu> |
logsave: Pass any SIGTERM or SIGINT signals to child process
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
/external/e2fsprogs/misc/logsave.c
|
| 5bec574043035397b190c01d1164940956f4d7b5 |
|
05-Mar-2004 |
Theodore Ts'o <tytso@mit.edu> |
logsave.c (main): Use setsid() to avoid getting killed by init
(run_program): Add a newline after reporting the exit code
or signal when the program exits.
/external/e2fsprogs/misc/logsave.c
|
| bc34d6be65cb93a65451ad209cfea2f98b03fd22 |
|
16-Apr-2003 |
Theodore Ts'o <tytso@mit.edu> |
* Add support for the -a and -s options to logsave.
* Change e2fsck to bracket its progress bar output with ctrl-A and ctrl-B
characters, so that logsave -s can omit writing the progress bar output
to the log file.
/external/e2fsprogs/misc/logsave.c
|
| f9ddad598237900e147e3095e7a1bde36f6a1d2f |
|
15-Apr-2003 |
Theodore Ts'o <tytso@mit.edu> |
Add logsave, a new program which saves the output of a command
in a log file, even if the containing directory hasn't been
mounted yet (in which case the it saves the output in
memory until it can write out the logfile).
/external/e2fsprogs/misc/logsave.c
|