| db6830162eca5b94e61d9825ec93306fc615d204 |
|
23-Nov-2016 |
Hal Canary <halcanary@google.com> |
SkImageEncoder: simplify API
(re-land 248ff02 & 2cb6cb7, with changes)
- Hide SkImageEncoder class in private header.
- SkImageEncoder::Type becomes SkEncodedImageFormat
- SkEncodedFormat becomes SkEncodedImageFormat
- SkImageEncoder static functions replaced with
single function EncodeImage()
- utility wrappers for EncodeImage() are in
sk_tool_utils.h
TODO: remove link-time registration mechanism.
TODO: clean up clients use of API and flip the flag.
TODO: implement EncodeImage() in chromeium/skia/ext
Change-Id: I47d451e50be4d5c6c130869c7fa7c2857243d9f0
Reviewed-on: https://skia-review.googlesource.com/4909
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-on: https://skia-review.googlesource.com/5186
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a2b4bdce8cfd1a91407595a25683ecff982af22e |
|
22-Nov-2016 |
Hal Canary <halcanary@google.com> |
Revert 248ff023 & 2cb6cb72
Revert "SkImageEncoder: simplify API"
This reverts commit 248ff02331d7f73ee4b6c5a7eabeae1080c16cd4.
Revert "Fix bug: can't convert nullptr -> bool"
This reverts commit 2cb6cb7218171b357bb5c934f032ba69c7b78401.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5151
NOTRY=true
Change-Id: I5f6414392d6545f74db0b5bb50608d04f053a8ec
Reviewed-on: https://skia-review.googlesource.com/5151
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 248ff02331d7f73ee4b6c5a7eabeae1080c16cd4 |
|
22-Nov-2016 |
Hal Canary <halcanary@google.com> |
SkImageEncoder: simplify API
- Hide SkImageEncoder class in private header.
- SkImageEncoder::Type becomes SkEncodedImageFormat
- SkEncodedFormat becomes SkEncodedImageFormat
- SkImageEncoder static functions replaced with
single function EncodeImage()
- utility wrappers for EncodeImage() are in
sk_tool_utils.h
TODO: remove link-time registration mechanism.
TODO: clean up clients use of API and flip the flag.
TODO: implement EncodeImage() in chromeium/skia/ext
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4909
Change-Id: Ib48b31fdc05cf23cda7f56ebfd67c841c149ce70
Reviewed-on: https://skia-review.googlesource.com/4909
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f530586c417800d086e6e727ecb1b31e678f4183 |
|
15-Nov-2016 |
Florin Malita <fmalita@chromium.org> |
Resurrect SkDebugger
Can't let go <sniffle>.
R=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4793
Change-Id: Ida5936d17af2ef60c3f50e27b4f4987a79165fa5
Reviewed-on: https://skia-review.googlesource.com/4793
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2db83612576d64935bd88747cf9855e79cad70d4 |
|
04-Nov-2016 |
Hal Canary <halcanary@google.com> |
bench, samples, etc: s/SkAutoTUnref/sk_sp/
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4437
Change-Id: Ice071684ac8a99e4bb405b4b9be8e8f42c7bac42
Reviewed-on: https://skia-review.googlesource.com/4437
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 145dbcd165d9d27298eb8888bc240e2d06a95464 |
|
03-Nov-2016 |
Ben Wagner <bungeman@google.com> |
Remove SkAutoTDelete.
Replace with std::unique_ptr.
Change-Id: I5806cfbb30515fcb20e5e66ce13fb5f3b8728176
Reviewed-on: https://skia-review.googlesource.com/4381
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 587ea71a522cd05601b401d17ad207c01f0ee0d6 |
|
25-Mar-2016 |
robertphillips <robertphillips@google.com> |
Fix old debugger for sk_sp changes
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827403002
Review URL: https://codereview.chromium.org/1827403002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ca2622ba051829fed5f30facd74c5b41cd4b931c |
|
18-Mar-2016 |
reed <reed@google.com> |
return pictures as sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811703002
Review URL: https://codereview.chromium.org/1811703002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9ea8acdf3ff8b7787e59de8c393e12a72b34ddc0 |
|
01-Mar-2016 |
robertphillips <robertphillips@google.com> |
Unbust the old debugger
AFAICT the recent STL changes have introduced some QT conflicts.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753813002
Review URL: https://codereview.chromium.org/1753813002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f42fca4027ed4f235ef927786813a5ed0e6652b9 |
|
27-Jan-2016 |
robertphillips <robertphillips@google.com> |
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
Review URL: https://codereview.chromium.org/1607253002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e429c88a811dfa05a26582a06fd53752768aa9f4 |
|
22-Jan-2016 |
robertphillips <robertphillips@google.com> |
Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/1607253002/ )
Reason for revert:
Overdraw Xfer mode using new fangled glsl features
Original issue's description:
> Add gpu implementation of OverdrawXfermode
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
>
> Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
TBR=egdaniel@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1626443002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 8bc3cf88bbf5e5d5724356f076931bb70a6117ba |
|
20-Jan-2016 |
robertphillips <robertphillips@google.com> |
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
Review URL: https://codereview.chromium.org/1607253002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f2848b60358deb23eca38a4587247c1d2e335d30 |
|
10-Dec-2015 |
halcanary <halcanary@google.com> |
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b
Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
Review URL: https://codereview.chromium.org/1507123002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a2e056773da8b029c9dccd5be265cb43615786c7 |
|
09-Dec-2015 |
halcanary <halcanary@google.com> |
Revert of default SkPixelSerializer (patchset #2 id:20001 of https://codereview.chromium.org/1507123002/ )
Reason for revert:
I was overconfident.
Original issue's description:
> default SkPixelSerializer
>
> Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
>
> Add SkImageEncoder::CreatePixelSerializer() to return a
> PixelSerializer that calls into SkImageEncoder::EncodeData.
>
> SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
>
> Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b
>
> Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
TBR=reed@google.com,scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1511183002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 808ce2886d732b1055f89c8fb0f1b11b47fcb0ce |
|
09-Dec-2015 |
halcanary <halcanary@google.com> |
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b
Review URL: https://codereview.chromium.org/1507123002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 290f00cd752b51f517b88c40bc89016fcaf5e477 |
|
08-Dec-2015 |
reed <reed@google.com> |
Revert of default SkPixelSerializer (patchset #1 id:1 of https://codereview.chromium.org/1507123002/ )
Reason for revert:
Breaking DEPS roll (linker error)
Original issue's description:
> default SkPixelSerializer
>
> Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
>
> Add SkImageEncoder::CreatePixelSerializer() to return a
> PixelSerializer that calls into SkImageEncoder::EncodeData.
>
> SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
>
> Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b
TBR=scroggo@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1505203003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| b0bd1516bff3f5afcbfd615e805867531657811b |
|
08-Dec-2015 |
halcanary <halcanary@google.com> |
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Review URL: https://codereview.chromium.org/1507123002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a745186c939ec641a861c74064155ec4aa3beb33 |
|
18-Nov-2015 |
djsollen <djsollen@google.com> |
Update debugger UI to auto-refresh the directory listing
Review URL: https://codereview.chromium.org/1462633002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 3f0424ff57f93666df7347d4787816b210233eb0 |
|
02-Nov-2015 |
fmalita <fmalita@chromium.org> |
[SkDebugger] Remove unneeded SkDebuggerGUI includes
R=robertphillips@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/1411963006
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 87ed6be0e4ea8b0a88915045f697d0fd734ed6f5 |
|
26-Oct-2015 |
robertphillips <robertphillips@google.com> |
Get debugger compiling again
Recent house cleaning has broken the debugger - mainly around the defunct profiling feature. This makes CL it even more defunct.
Review URL: https://codereview.chromium.org/1416723006
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 109a23d64ff9cf210e6b0aa8940b4fcea3f05a97 |
|
15-Jun-2015 |
fmalita <fmalita@chromium.org> |
Remove the SkCanvas comment API
No longer used in Chromium/Blink.
R=reed@google.com,robertphillips@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/1153593003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 160ebb2bfa0794d72d31a786793b13413289863d |
|
02-Apr-2015 |
fmalita <fmalita@chromium.org> |
[SkDebugger] Flatten drawPicture ops
Add two drawPicture bracketing ops (BeginDrawPicture, EndDrawPicture) to
replace the current DrawPicture op, and flatten picture contents.
Review URL: https://codereview.chromium.org/1048383002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 546db46a76ad5f7485cebeb27efaf8b4806fa914 |
|
26-Mar-2015 |
robertphillips <robertphillips@google.com> |
Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents)
Displaying the offset into an SkPicture hasn't worked for a while so this CL deletes the feature.
When "Save Layer" was renamed to "SaveLayer" the code that computes the indent in the list view was broken. This CL patches the problem.
Review URL: https://codereview.chromium.org/1034733004
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 3e5c2b1041b15641931638d1d78b30d3c435fc71 |
|
23-Mar-2015 |
robertphillips <robertphillips@google.com> |
Preserve texture compression when saving a revised skp from debugger
Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires.
Review URL: https://codereview.chromium.org/1020103005
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e7903c7397c694e343c2c0fcc5cabea351212f23 |
|
16-Mar-2015 |
reed <reed@google.com> |
FilterLevel -> SkFilterQuality
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/1010023002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2de59391157850b62ab5891aae349b64eb1d8a17 |
|
11-Feb-2015 |
robertphillips <robertphillips@google.com> |
Revert of Fix Chromium build (patchset #2 id:20001 of https://codereview.chromium.org/916763003/)
Reason for revert:
Chrome
Original issue's description:
> Fix Chromium build
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/f5e89c8f685ac8a5c4d117e087b4111d613106db
TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/916963002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f5e89c8f685ac8a5c4d117e087b4111d613106db |
|
11-Feb-2015 |
robertphillips <robertphillips@google.com> |
Fix Chromium build
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/916763003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a1193e4b0e34a7e4e1bd33e9708d7341679f8321 |
|
21-Jan-2015 |
scroggo <scroggo@google.com> |
Make SkStream *not* ref counted.
SkStream is a stateful object, so it does not make sense for it to have
multiple owners. Make SkStream inherit directly from SkNoncopyable.
Update methods which previously called SkStream::ref() (e.g.
SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(),
which required the existing owners to call SkStream::unref()) to take
ownership of their SkStream parameters and delete when done (including
on failure).
Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some
cases this means heap allocating streams that were previously stack
allocated.
Respect ownership rules of SkTypeface::CreateFromStream() and
SkImageDecoder::buildTileIndex().
Update the comments for exceptional methods which do not affect the
ownership of their SkStream parameters (e.g.
SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be
explicit about ownership.
Remove test_stream_life, which tested that buildTileIndex() behaved
correctly when SkStream was a ref counted object. The test does not
make sense now that it is not.
In SkPDFStream, remove the SkMemoryStream member. Instead of using it,
create a new SkMemoryStream to pass to fDataStream (which is now an
SkAutoTDelete).
Make other pdf rasterizers behave like SkPDFDocumentToBitmap.
SkPDFDocumentToBitmap delete the SkStream, so do the same in the
following pdf rasterizers:
SkPopplerRasterizePDF
SkNativeRasterizePDF
SkNoRasterizePDF
Requires a change to Android, which currently treats SkStreams as ref
counted objects.
Review URL: https://codereview.chromium.org/849103004
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| cfdc0e3fee69694e0f6b083d8455665b2a810589 |
|
14-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: SW rasterize the picture only when it changes
Rasterize the picture only when it changes, not every time
raster widget paints itself.
Removes include SkForceLinking.h while organizing the SkDebuggerGUI.cpp
includes.
This is part of the work trying to remove bugs that come from
SkDebugCanvas stateful draw. Part of the state comes from some
optimization that this tries to reproduce in a different way.
Review URL: https://codereview.chromium.org/839743003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0cfeaf3ac1e7edcf3b618c9f33f4b4bc30321324 |
|
07-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Update inspector view data consistently while paused
Make all fields of inspector view (details tab, clipstack tab, geometry
view) update the correct info when user selects a draw command. Also
update the info regardless if the painting is paused or not.
Current clip and matrix will not update consistently even after this
patch, as they depend on stateful debug canvas draw (may be fixed
later).
Review URL: https://codereview.chromium.org/835903002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f3a9e993399fcb8dae4bf6f1dd9674a72b289da3 |
|
05-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Remove few redundant variables
Use the GUI widget states instead of instance variables
reflecting the widget state.
Fixes the case where pause state would be left on when
switching files, but the image would change to the last
frame of newly loaded image.
Review URL: https://codereview.chromium.org/810033004
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 5caff917f5f217e3070762847e6934f714196afb |
|
02-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Move Skia initialization out of the GUI widget class
Move Skia initialization out of the GUI widget class to the
main function.
Before, Skia may have been already called before the SkGraphics::Init
was run.
Review URL: https://codereview.chromium.org/822583003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 7c339ae1e362e9f02cdfb9b32007f143dec0bc0e |
|
02-Jan-2015 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Make inspector widget smaller
Make inspector widget a bit smaller by letting the Qt widget system
layout the widgets.
Let the inspector widget calculate its own smallest size. Use stretch
factor of 0 for inspector, 1 for picture canvas.
Group the matrix and clip widgets in groups. Put the text edits in a grid
layout instead of a handwritted column layout containing row layouts.
This commit is part of work that tries to make the debugger window to be
a bit more resizeable, so that it would fit 1900x1200 screen.
Review URL: https://codereview.chromium.org/830743002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 63a470227beed0de553d769724e0108808391e42 |
|
31-Dec-2014 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Make draw command image widget resize
Make draw command image widget resize. The widget was not resizing,
effectively preventing the window from being resized smaller.
Make the rasterized draw command image be proportional to the widget
size. The draw rasterization canvas is still an equilateral rectangle
with dimensions of the smaller side of the widget.
Makes the widget re-rasterize the image only when the draw command
changes, not for each widget paint.
Renames the widget from "image widget" to "draw command geometry
widget".
Makes the background of the image black, similar to the raster widget
background.
Adds a tooltip saying "Command geometry" for the widget, so that user might
understand what the contents should be.
This commit is part of work that tries to make the debugger window to be
a bit more resizeable, so that it would fit 1900x1200 screen.
Review URL: https://codereview.chromium.org/787143004
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 41c79cc0ff3003ef77cb48590f7887221856f941 |
|
31-Dec-2014 |
kkinnunen <kkinnunen@nvidia.com> |
debugger: Make settings widget resizeable
The settings widget was laid out by hand, eg. the widths of most
elements were hardcoded. This prevented it from being laid out by the Qt
widget system. This in turn prevents the widget from shrinking to its
optimal size. This in turn causes cascading effect where the geometry of
many of the UI widgets has to be hard-coded. This in turn prevents
proper resizing of the UI.
Make Qt layout the settings widget by following changes:
a) Group settings in QGroupBox groups instead of hand-written
layouts and labels hardcoded in certain places.
b) Remove "Expanding" size policy from settings widget. The widget
calculates its own size based on the widgets inside. Thus "Preferred"
is the correct policy to use, as expanding the widget will not
bring any new content visible.
c) Remove maximum width 250 from Settings widget
d) Make "canvas settings and image layout", eg. the horizontal layout
holding the settings widget divide the space between the picture and
settings like so: settings uses up only as much as it needs (stretch
factor 0), while picture uses up everything else (stretch factor 1).
In order to do a) reasonably, reorganize the UI and the code a bit:
a1) Rename settings group "visual filter" to "Visualizations".
a2) Make "visual filter: on/off" combo box a checkbox in
"Visualizations".
a3) Move "Mega viz" setting checkbox from "raster" (or "render targets")
section to "Visualizations"
a4) Move "PathOps" setting checkbox from "raster" to "Visualizations"
a5) Make Raster and GL checkboxes use QGroupBox checkbox feature
a6) Move "current command", "command hitbox" and "zoom level" from
"Settings" widget to part of "Inspector" concept. These pieces of
information are now visualized as their own box in the right-hand
bar, below settings.
a7) Do not expose settings user selects through the UI widgets
state that record the user interacts with. Instead, expose it as state
of the "settings widget". Thus settings widget provides "raster settings
changed" signal, which the client hook to and then query the state
through the object API.
This makes the full window a bit shorter.
This commit is part of work that tries to make the
debugger window to be a bit more resizeable, so that it would fit
1900x1200 screen.
Review URL: https://codereview.chromium.org/829933002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 5037e9de94e57d36592cc596d831cc2b5ec45bd3 |
|
30-Dec-2014 |
kkinnunen <kkinnunen@nvidia.com> |
Change DebugCanvas API to not encourage memory leaks
Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.
This simplifies debugger leak investigations, as the app leaks less by
design.
Review URL: https://codereview.chromium.org/821663003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f0f14113431ace669f278fdd97b50950f2cf4c80 |
|
12-Dec-2014 |
mtklein <mtklein@chromium.org> |
Cull pushCull and popCull from Skia.
These calls are unused and going away. Waiting on crrev.com/796083002.
BUG=skia:
Review URL: https://codereview.chromium.org/794263002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| c6ad9eefa0f8d0c2ede9884b446c65dde9b04dd1 |
|
17-Nov-2014 |
mtklein <mtklein@chromium.org> |
More SkPicture cleanup
- move field declarations together and pack them a little tighter
- get rid of fData
- remove dead code in debugger, including unused SkPicturePlayback subclass
There are now no more long-lived SkPictureData! (Really, there never were,
but now we don't pretend to support them.)
BUG=skia:
No API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/725143002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 8c89c528f31dff25bce74aabe28abe23a772cb1e |
|
09-Nov-2014 |
fmalita <fmalita@chromium.org> |
Revert of Revert of SkDrawCommand scrubbing (patchset #1 id:1 of https://codereview.chromium.org/712683002/)
Reason for revert:
Chromium clients updated, this should be canary-proof now.
Original issue's description:
> Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/)
>
> Reason for revert:
> Canary borkage.
>
> Original issue's description:
> > SkDrawCommand scrubbing
> >
> > Remove unused ctor, constify, etc.
> >
> > R=robertphillips@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec
>
> TBR=robertphillips@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/9063ddd511f8e0d8c7454950cbc56e273678bf60
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/708333002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9063ddd511f8e0d8c7454950cbc56e273678bf60 |
|
07-Nov-2014 |
fmalita <fmalita@chromium.org> |
Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/)
Reason for revert:
Canary borkage.
Original issue's description:
> SkDrawCommand scrubbing
>
> Remove unused ctor, constify, etc.
>
> R=robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/712683002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 1931ec5b5dac68f1e452af0c65161bdce35b2dec |
|
07-Nov-2014 |
fmalita <fmalita@chromium.org> |
SkDrawCommand scrubbing
Remove unused ctor, constify, etc.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/706363002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 78c71272fb26852bf3d2ca31785e61d4a598af82 |
|
09-Oct-2014 |
robertphillips <robertphillips@google.com> |
Update old tools to allow MultiPictureDraw rendering
I'll post a separate patch for nanobench and dm
Review URL: https://codereview.chromium.org/639013003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 49f085dddff10473b6ebf832a974288300224e60 |
|
05-Sep-2014 |
bsalomon <bsalomon@google.com> |
"NULL !=" = NULL
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/544233002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 92432c7f7c0a878256f139ce6f73d71e1c202a16 |
|
08-Jul-2014 |
robertphillips <robertphillips@google.com> |
Fixed up SkTimedPicturePlayback
This was more motivated to remove the preDraw and postDraw virtuals from SkPicturePlayback.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/375943002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ce4dd3de38cd7c29bf5b9d8a8efb55c08ec9be47 |
|
07-Jul-2014 |
robertphillips <robertphillips@google.com> |
Split SkPicturePlayback out of SkPictureData
This splits the playback functionality out of SkPictureData. The old SkPictureData::draw method is pulled out along
with its supporting functions as verbatim as possible. Some follow on CLs will be required to:
re-enable profiling in the debugger (and remove the vestiges of SkTimedPicture)
re-enable display of command offsets in the picture (this should probably wait until we've switched to SkRecord though)
Clean up CachedOperationList (maybe fuse with SkPicture::OperationList)
Split SkPicturePlayback into a base class and two derived classes
Implement parallel version of GatherGPUInfo for SkRecord
Landing this is blocked on removing Android's use of the abortPlayback entry point.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/377623002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| db539905bb3af7bd05839a7d2558e97d5cb51ca2 |
|
01-Jul-2014 |
robertphillips <robertphillips@google.com> |
Rename SkPicturePlayback to SkPictureData
This is in preparation for splitting the playback portion of the new SkPictureData class into a new SkPicturePlayback class.
R=reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/362773002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 744fb7313f31069e9eceeca4c0ff33dbe2fe1737 |
|
23-Jun-2014 |
Mike Klein <mtklein@google.com> |
Enable basic drawing with SkRecord-based pictures.
I've tagged all the functions in SkPicture.cpp is // fRecord TODO or // fRecord
OK, depending on whether or not they're totally broken when used from an
SkRecord-based picture. Obviously next steps are to eliminate all the TODOs,
then clean up the notes.
I converted SkPicture over to smart pointers too. It's particularly helpful
that the smart pointers initialize to NULL by default.
For now I've got all the SkRecord-based code jammed in at the bottom of the file. I figure it'll help me keep things straight for a bit, then we can rearrange later.
BUG=skia:
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/333823007
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9ac68ee2594f28dfc1bd16a4bf004b1a4f6f228d |
|
20-Jun-2014 |
mtklein <mtklein@chromium.org> |
Move BenchTimer to tools as Timer
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
R=tfarina@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9e64b78ff687edd24c55c0e26942411468032d32 |
|
20-Jun-2014 |
mtklein <mtklein@google.com> |
Revert of Move BenchTimer to tools as Timer (https://codereview.chromium.org/344213003/)
Reason for revert:
GpuTimer broken
Original issue's description:
> Move BenchTimer to tools as Timer
>
> This breaks a bunch of circular dependencies between tools and gm and bench.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
R=tfarina@chromium.org, mtklein@chromium.org
TBR=mtklein@chromium.org, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/346753003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 4ed75287aed6371c6e4a41ffcc78c8a49c9810ed |
|
20-Jun-2014 |
mtklein <mtklein@chromium.org> |
Move BenchTimer to tools as Timer
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
R=tfarina@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e26e65e8f831f7a5626c92d11bbb8c2cec1f70de |
|
12-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove SkPicture pointer from SkPicturePlayback
This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/334493002
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2a67e123a3e559774a16a58cbe5106bc0fb86740 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate.
Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug.
R=robertphillips@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/282283002
git-svn-id: http://skia.googlecode.com/svn/trunk@14774 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 3f0451772109959fcb79bacf2c9a03e0eb39ff27 |
|
15-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
render_pictures: add --mismatchPath flag
When set, it will only write out images that don't match expectations.
BUG=skia:1942
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/283123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14748 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| b0430d024572b1a5e5d7b80e406c668e975e3030 |
|
24-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14346 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 8f831f262f5e57665587cb3033860eea39fe1621 |
|
24-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First step in pulling SkPicturePlayback & SkPictureRecord out of SkPicture
This CL begins the process of making SkPicturePlayback & SkPictureRecord independent of SkPicture. It just moves the PathHeap into SkPicture to get a feel for where all this is going to lead.
Some items of note:
SkTimedPicture (debugger/QT) should wind up being just an SkPicturePlayback-derived object.
All the flattening & unflattening should migrate out of SkPicturePlayback and into SkPicture.
SkPicture::initForPlayback should eventually become something just SkPictureRecorder::endRecording calls.
SkPicture is passed into SkPicturePlayback's & SkPictureRecord's constructors. SkPicturePlayback only
holds onto a "const SkPicture*". The SkPicturePlayback:: CreateFromStream & CreateFromBuffer methods pass a non-const
SkPicture* down the call stack.
BUG=skia:2315
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/249453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14341 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0943f5f58abcff15c7583faafe44549b9a44f47a |
|
28-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Thread picture version through to SkReadBuffer.
This will let code outside SkPicture* fork its read code based on the picture version.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/214413008
git-svn-id: http://skia.googlecode.com/svn/trunk@13984 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| db35dab49e0e6bf16ccad5052bf6e6826daad27d |
|
27-Mar-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13961 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 57f74e0aa931e7784d47cba3ecc83020aa8e72b2 |
|
26-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Debugger improvements
This CL:
improves the 'SaveAs' functionality
allows switching between # and offset indexing in the command list
minor nit cleanup
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/211383003
git-svn-id: http://skia.googlecode.com/svn/trunk@13950 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f5e315ccf1ae2941f7cf53fa53e5c8c4bb665fe1 |
|
19-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add --writeChecksumBasedFilenames flag to render_pictures
BUG=skia:1455,skia:2230
R=robertphillips@google.com, robertphillips@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/202983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13859 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 51c040ed1e8c50bec4297bbe25242f644b40b0b7 |
|
11-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Alter bench_pictures to "respect" the logPerIter flag.
When --logPerIters is set and --repeat is great then 2 then bench_pictures will run each test "repeat" times (to generate the correct number of timings) by rendering 5 times.
This CL also adds a swapBuffers in addition to the pre-existing flush calls.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/194973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13752 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 6f4fb0f1296422a44d5d0dac155d82595dc5ebec |
|
03-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Generating the 1M skps frequently yields truncated skps. This tool is intended to help automate weeding these out.
Please see skbug:1057
rmistry for tools, gyp
mtklein for src\core & include\core
BUG=skia:1057
R=rmistry@google.com, mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/176863004
git-svn-id: http://skia.googlecode.com/svn/trunk@13643 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 768ac85655017d4106444bf3ad044680a575ccaa |
|
03-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves).
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/185293007
git-svn-id: http://skia.googlecode.com/svn/trunk@13640 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 210ae2a42613b9048e8e8c4096c5bf4fe2ddf838 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Culling API
*** SKP format breaking change ***
Adding a couple of culling primitives: pushCull(SkRect) & popCull().
These are currently only plumbed for SKP playback quickreject.
At record time, we perform a couple of optimizations to trim down the
number of redundant culls:
* collapse empty pushCull/popCull pairs
* skip pushCull/popCull pairs nested within an identical cull rect
Things still missing/to consider:
* use an inlineable, simplified quickreject (Mike's old prototype)
* debugger visualization for cull boxes
* BBH integration: the initial prototype had some minimal BBH support,
but since the optimizations required expensive rewinds and culling
is expected to be a BBH alternative, it got dropped.
R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/138013009
git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 22d39332bdba4e2e36aa050220392dcd33d81c19 |
|
21-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Convert debugger settings controls to combo boxes.
This reduces the height of the settings panel significantly compared to
radio buttons.
With some luck, the debugger may now fit on non-4K monitors :)
R=bungeman@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/78843005
git-svn-id: http://skia.googlecode.com/svn/trunk@12342 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| bcd431e1778001990c4d877929b14959dc96a0d3 |
|
21-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make the debugger left panel resizable.
Use QSplitters to allow resizing the left debugger panels.
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/79573002
git-svn-id: http://skia.googlecode.com/svn/trunk@12336 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 32bbcf828d66ad244fa25b468bc3a229e531491f |
|
17-Oct-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add texture filtering override to debugger
https://codereview.chromium.org/27716003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11846 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 12705329d0807863d4d80cac0f02e543c26f24a1 |
|
01-Oct-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow creating a picture from skp to fail.
Replace the current constructor for creating an
SkPicturePlayback to a factory. In the factory,
check for incorrect data that would result in an invalid
playback. If the playback is invalid, return NULL, and
return NULL from SkPicture's factory as well.
Update SkTimedPicture(Playback) as well.
BUG=skia:1672
R=caryclark@google.com
Review URL: https://codereview.chromium.org/24826002
git-svn-id: http://skia.googlecode.com/svn/trunk@11554 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| fde1e7ccb4524aa2e0c42872e529ee25d09e7f34 |
|
02-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Support MSAA in the picture debugger
Add radio buttons for setting the GL sample count to 0 ("off"), 4 or
16.
Change the default mode of the GL widget to MSAA4. Previous behavior
corresponded to "off".
BUG=1459
R=robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/21752002
git-svn-id: http://skia.googlecode.com/svn/trunk@10509 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0d55dd7d2c07a77b22478bed9b30ff44ceecad68 |
|
02-Jul-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9856 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2ff6d1d1dc2c4668b0c587c55fd37407fb8d68ab |
|
01-Jul-2013 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Separate showing and hiding the debugger settings and inspector.
Internally the settings and inspector in the debugger are separate, but the
inspector button toggles both of them. This is unfortunate, because both of
these have large minimum vertical sizes. This means that those with vertical
resolutions less than ~1024 cannot see the the details tab.
This change separates the settings and inspector toggles into two so that
the interface is usable on screens of smaller size.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/18279002
git-svn-id: http://skia.googlecode.com/svn/trunk@9835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f1754ec69131801c1a6ed3c704501a9400bbf324 |
|
28-Jun-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Replace SkPicture(SkStream) constructors with a factory.
SkPicture:
Remove the constructors which take an SkStream as an argument. Rather
than having to check a variable for success, the factory will return
NULL on failure.
Add a protected function for determining if an SkStream is an SKP
to share code with SkTimedPicture.
In the factory, check for a NULL SkStream.
Use a default decoder (from BUG:
https://code.google.com/p/skia/issues/detail?id=1325)
SkDebuggerGUI:
Call SkPicture::CreateFromStream when necessary.
Write a factory for creating SkTimedPictures and use it.
Use the factory throughout tools.
Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
can reference SkImageDecoder.h which references SkBitmapFactory.h (in
include/lazy).
Changes code Chromium uses, so this will require a temporary Skia
and then a change to Chromium to use the new Skia code.
TODO: Create a decoder that does nothing to be used by pinspect,
lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.
R=reed@google.com
Review URL: https://codereview.chromium.org/17113004
git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 7def5e1630d47cdbfa4b58a9c86bc060693c4d79 |
|
31-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Separate core and images project.
SkImage calls functions on SkImageDecoder and SkImageEncoder. This
is desired behavior, and it is also desired to include SkImage as
a part of core. In order to keep core from depending on images,
update SkImageDecoder_empty.cpp to implement all of SkImageDecoder
and SkImageEncoder. This file will be built by chrome (in
https://codereview.chromium.org/15960015).
Move force_linking from SkImageDecoder.cpp to its own file. It must
be called to force linking with the image decoders if desired. Call
the function in tools that need it:
sk_image
render_pictures
render_pdfs
sk_hello
filter
bench_pictures
debugger
SkImageDecoder:
Derive from SkNoncopyable, instead of duplicating its
hiding of constructors.
skhello:
Return rather than trying to write a null SkData to the stream.
Revert "Hamfistedly removed core dependence on images"
(commit 0f05f682a90bc125323677abf3476e1027d174f5) and
"Move SkImage::encode to SkImage_Codec.cpp."
(commit 83e47a954d0bf65439f3d9c0c93213063dd70da3.)
These two commits were temporary fixes that this change
cleans up.
SkSnapshot.cpp:
Check for a NULL encoder returned by SkImageEncoder::Create.
BUG=https://code.google.com/p/skia/issues/detail?id=1275
R=djsollen@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/15806010
git-svn-id: http://skia.googlecode.com/svn/trunk@9364 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0a4805e33f8ddb445a2fd061462e715e1707f049 |
|
29-May-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First pass at Comment API
https://codereview.chromium.org/13957009/
git-svn-id: http://skia.googlecode.com/svn/trunk@9310 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 3e2345a8d56cb76bc43e4421a3e9e3681ecd9eba |
|
24-May-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9266 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 6d9c92b2f6e5be64dd5dd98e44d672877e4c9fbc |
|
23-May-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove offsetcanvas from debugger
https://codereview.chromium.org/15746003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9253 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 91274b99722d9be62e077ab979c630c23cdd04b1 |
|
13-Mar-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8120 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e428f9b1132c12299c204a333192495d7e748511 |
|
12-Mar-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix debugger build errors/warnings
https://codereview.appspot.com/7729045/
git-svn-id: http://skia.googlecode.com/svn/trunk@8105 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2d9dbd4f78314b4b36f67d6ebbf3e0f2d9a163e3 |
|
12-Mar-2013 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
NaCl Debugger: Implement overview and filters, cleanup
(SkipBuildbotRuns) since no bots build the debugger.
Review URL: https://codereview.chromium.org/12449006
git-svn-id: http://skia.googlecode.com/svn/trunk@8095 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 754a3eb73b796398062f09cc98eae224262a3bc8 |
|
08-Mar-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8033 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 20beb481ec72b9723c63f9ed5480adad0ff5a9a0 |
|
07-Mar-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Normalize the debugger's profile times by the repeat count
https://codereview.appspot.com/7520043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8025 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 12d588a7f28e18f87f5f9a6eb57fc1f5137a8d28 |
|
25-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove bogus ability for creating an SkPicturePlayback to fail.
Change SkPicturePlayback::parseBufferTag to return void, since
it can never return false.
Change SkPicturePlayback::parseStreamTag to return void, since
the only way it can return false is if parseBufferTag returns
false, or if creating a sub picture failed, both of which are
nonsensical.
Due to the above, there is no reason for creating an
SkPicturePlayback to fail, so remove the isValid parameter.
Update subclasses in SkDebuggerGUI.
Review URL: https://codereview.appspot.com/7388050
git-svn-id: http://skia.googlecode.com/svn/trunk@7844 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9f123162f7f65f414b674730d55bf5509fefd84b |
|
22-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix debugger build.
Review URL: https://codereview.appspot.com/7375050
git-svn-id: http://skia.googlecode.com/svn/trunk@7838 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f8d7d2731318cdf510ab68e6b3f5ec68ab22c8e2 |
|
22-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Create SkLazyPixelRef which performs lazy decoding.
The new pixel ref behaves similarly to SkImageRef, with some key differences:
It does not depend on the images project.
It requires an SkImageCache, which handles allocation and caching of the pixel
memory.
It takes a function signature for decoding which decodes into already allocated
pixel memory rather than into an SkBitmap.
Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache.
Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc,
and update sites that referenced it.
SkBitmapFactory now sets the pixel ref to a new object of the new
class SkLazyPixelRef, provided it has an SkImageCache for caching.
Provide an option to do lazy decodes in render_pictures and bench_pictures.
SkPicture:
Eliminate the default parameters in the constructor.
If a proc for decoding bitmaps is installed, use it to decode any encoded
data in subpictures.
When parsing deserializing subpictures, check for success.
When serializing subpictures, pass the picture's bitmap encoder to the
subpicture's call to serialize.
Update BitmapFactoryTest to test its new behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1008
BUG=https://code.google.com/p/skia/issues/detail?id=1009
Review URL: https://codereview.appspot.com/7060052
git-svn-id: http://skia.googlecode.com/svn/trunk@7835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e8fe4bc3efa8f18f5651c5d005fba1935a741be0 |
|
13-Feb-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow debugger to be compiled without Ganesh
https://codereview.appspot.com/7311084/
git-svn-id: http://skia.googlecode.com/svn/trunk@7710 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2d40ec4e9a3fb3540756fa45a6cffd541ada2c78 |
|
07-Feb-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Cleanup debugger's handling of bad input files
https://codereview.appspot.com/7308062/
git-svn-id: http://skia.googlecode.com/svn/trunk@7654 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f4741c1322944e194ca34a8f5cf8188fe2c0efe2 |
|
06-Feb-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add overdraw visualization to the debugger
https://codereview.appspot.com/7267043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7627 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0ac6f168f15393a3213c1c95f8adc4434132dcb2 |
|
05-Feb-2013 |
jvanverth@google.com <jvanverth@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix for issue 1029: Debugger opens files with ^O, but crashes when opening files through other methods
Don't append leading '/' if path is local
git-svn-id: http://skia.googlecode.com/svn/trunk@7593 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 1447aa3f3b9a4c23ac1fbc70c476828966980c9d |
|
30-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added option of profiling GPU backend to debugger
https://codereview.appspot.com/7248045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7471 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ade32668eb641dde914f9199b3209d9818828035 |
|
28-Jan-2013 |
jvanverth@google.com <jvanverth@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add missing params to renderer->resetState().
https://codereview.appspot.com/7234051/
git-svn-id: http://skia.googlecode.com/svn/trunk@7431 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e219baf74742ee5cda3c99fabe6acaa8f878fe00 |
|
28-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add data() to all QString::toASCII Qt calls to help out Linux compiler
https://codereview.appspot.com/7232052/
git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ff6e6bade36c34a4c4fce4c14b480b9d2435bcd5 |
|
28-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add command line options to debugger
https://codereview.appspot.com/7221048/
git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| dd4b74548accfbf42b8e6b8d7eefbfb8c8f17e00 |
|
22-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added multi-select deletion to debugger
https://codereview.appspot.com/7190043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7318 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 25bc2f86c2b94ee1f0921d90e6629d8cb22f69b7 |
|
22-Jan-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix saving modified skp from debugger
https://codereview.appspot.com/7181048/
git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e8cc6e8071935339a06548b13a0668b56a7540f5 |
|
17-Jan-2013 |
bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make navigating the picture view in debugger more functional.
https://codereview.appspot.com/7134049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7253 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ca47aae7ecfdafb5e88baee13737908b79a4c716 |
|
12-Dec-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Minor cleanup
https://codereview.appspot.com/6927054/
git-svn-id: http://skia.googlecode.com/svn/trunk@6756 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| c1f224ac07b1310211e0219a4d6bda41e49abe90 |
|
08-Dec-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6721 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 5f97114fd28e03e8c4c1c22c924d383b45cdced1 |
|
07-Dec-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make debugger profiling honor deleted commands
https://codereview.appspot.com/6906043/
git-svn-id: http://skia.googlecode.com/svn/trunk@6713 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e174a8bd74f35fafec1f740d9265efae092cea90 |
|
27-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Address debugger profiling issue in tile mode
https://codereview.appspot.com/6843113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6564 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 1c9c0d37111e6ff7a74a2908bf62a0d3954f2bb5 |
|
22-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6540 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 6dec8fcb4427c68649aede96864cff7c71df6393 |
|
21-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add drawing of paths to debugger
https://codereview.appspot.com/6850082/
git-svn-id: http://skia.googlecode.com/svn/trunk@6532 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 3458716b52aa25dcd1b270141c7628c380696e35 |
|
20-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6500 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 8a1cdaece7e1d009befb84f21bb82370025bf4d6 |
|
19-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Breakdown profile time by command type in the overview pane
https://codereview.appspot.com/6851073/
git-svn-id: http://skia.googlecode.com/svn/trunk@6492 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| d163636ec6914a95c7a8333dc94bc0cae68b226a |
|
19-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added Reload icon
https://codereview.appspot.com/6849079/
git-svn-id: http://skia.googlecode.com/svn/trunk@6486 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 8e41a168b0c4eedfcfb05d46f6a19895cc9459ec |
|
19-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add original resources back and update code to match
https://codereview.appspot.com/6842061/
git-svn-id: http://skia.googlecode.com/svn/trunk@6484 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e099bc403ca85be61cf23e67661e6a795fbcc40a |
|
19-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
3 minor fixes for debugger
https://codereview.appspot.com/6842062/
git-svn-id: http://skia.googlecode.com/svn/trunk@6480 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 884e60be30e20f38b3466a4697081187d2f1f814 |
|
16-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6447 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| fe830a46411a4f0fe6e3e81ce1817cefab788730 |
|
15-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix debugger crash when SK_PICTURE_PROFILING_STUBS isn't defined
https://codereview.appspot.com/6850060/
git-svn-id: http://skia.googlecode.com/svn/trunk@6433 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2bde91dcb6f2840e01216054897fe98a930e9104 |
|
15-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add profiling to debugger
https://codereview.appspot.com/6817114/
git-svn-id: http://skia.googlecode.com/svn/trunk@6430 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| c3c8216949146641222f7d2f7a464340627ae43a |
|
13-Nov-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix linux compiler error with the debugger app.
Review URL: https://codereview.appspot.com/6848045
git-svn-id: http://skia.googlecode.com/svn/trunk@6398 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| d26c70688fda9dd33369f5ea9da78f26c8666d63 |
|
12-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Update debugger GUI to have profile button & list widget to optionally display time
https://codereview.appspot.com/6813117/
git-svn-id: http://skia.googlecode.com/svn/trunk@6385 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| b4467e642e1c0772940cb266cae46f5fda399952 |
|
07-Nov-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Decode images during deserialization in the picture debugger.
Necessary now that our checked in SKPs have encoded bitmaps in them (since https://code.google.com/p/skia/source/detail?r=6317)
Review URL: https://codereview.appspot.com/6812093
git-svn-id: http://skia.googlecode.com/svn/trunk@6322 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 30d35f23ae390043462e2aa5fc6863a4621aa74d |
|
06-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Enhanced debugger with command indenting and Path Bound print out
https://codereview.appspot.com/6820099/
git-svn-id: http://skia.googlecode.com/svn/trunk@6309 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 4c7962e0a866b8416fa7046791c129eb5430b677 |
|
14-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested clips not being cleared.
Review URL: https://codereview.appspot.com/6462060
git-svn-id: http://skia.googlecode.com/svn/trunk@5095 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 6bd109a39370d21bfd4b48f5a28df8bcfc7f5ba2 |
|
14-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactored inspector widget such that creating custom tabs for information is straightforward for future developers.
Review URL: https://codereview.appspot.com/6463046
git-svn-id: http://skia.googlecode.com/svn/trunk@5093 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 686e68019374dca3692cac6d5f8d94515e53d6c8 |
|
14-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Bug Fix: Resets the users zoom and translation every picture load. Was acting inconsistently between different viewing widgets, now forces a redraw every new picture.
Review URL: https://codereview.appspot.com/6450130
git-svn-id: http://skia.googlecode.com/svn/trunk@5083 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| bbad34de3b117347bedea619feaf1685586d4202 |
|
13-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Effects Bug Fix
Certain compilers in an effort to optimize code chop off files that are never
used. By adding a flag to common conditions and variables we can force skia to
recompile with global static initializers off. By making a call to
SkGraphics::Init we now register all those functions that had been previously
automatically excluded by the compiler.
Review URL: https://codereview.appspot.com/6443112
git-svn-id: http://skia.googlecode.com/svn/trunk@5057 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 97cee9735350cb472249ce1a827ba1aa6b2a5f59 |
|
07-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia code
Review URL: https://codereview.appspot.com/6445088
git-svn-id: http://skia.googlecode.com/svn/trunk@4995 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 607357fde8a9c4c70549d4223e0bd1181b012e0e |
|
07-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactoring into a public facing facing SkDebugger class first pass.
Review URL: https://codereview.appspot.com/6450096
git-svn-id: http://skia.googlecode.com/svn/trunk@4986 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a9e937c7b712b024de108fa963f92d0e70e4a296 |
|
03-Aug-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Moved the ownership of the current clip and current matrix into the debug canvas as part of the upcoming general refactor to everything living in debug canvas.
Review URL: https://codereview.appspot.com/6447077
git-svn-id: http://skia.googlecode.com/svn/trunk@4950 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2d537a18f49cb492358c2b051f4786075dd9406c |
|
31-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed numerous mem errors
Review URL: https://codereview.appspot.com/6441070
git-svn-id: http://skia.googlecode.com/svn/trunk@4849 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 38b08ce020f451a66263110b32e70f5022df4f83 |
|
29-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added missing files to fix build.
TBR
Review URL: https://codereview.appspot.com/6455058
git-svn-id: http://skia.googlecode.com/svn/trunk@4822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 0ab03397afd3420ea8fd9323d78ddd562a7b7bdf |
|
28-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Skia Debugger can now save modified pictures.
Review URL: https://codereview.appspot.com/6442055
git-svn-id: http://skia.googlecode.com/svn/trunk@4821 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| a1226319b72df0fb4c8a9a6aae5e493a4e3527cb |
|
26-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Key Shortcuts for Zooming. Refactored some event propogation.
Review URL: https://codereview.appspot.com/6452052
git-svn-id: http://skia.googlecode.com/svn/trunk@4794 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ea5488b9655fc7d71345c3a823de85f8b74e3279 |
|
26-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GL Widget Alpha
Review URL: https://codereview.appspot.com/6422060
git-svn-id: http://skia.googlecode.com/svn/trunk@4789 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| ea79aba75b27bb16cb7226ad92d2d5393dd23b8d |
|
19-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed glaring typo in SkDebuggerGUI.cpp, unreviewed.
BUG=
TEST=
Review URL: https://codereview.appspot.com/6423052
git-svn-id: http://skia.googlecode.com/svn/trunk@4669 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| d3058f5fd8bb786c5b70a0dd222bde646502258a |
|
19-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Quick bug fix that was rendering debugger unusable.
Review URL: https://codereview.appspot.com/6422050
git-svn-id: http://skia.googlecode.com/svn/trunk@4668 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 7e4cfbf144af7d530d552946cee2a21d30b9b50f |
|
17-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added more features to deletes and breakpoints
Review URL: https://codereview.appspot.com/6406050
git-svn-id: http://skia.googlecode.com/svn/trunk@4637 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e504de0a50f268189399567f58183c8c6a27b2af |
|
16-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Cleaned up icons, added keyboard shortcuts to everything
Keyboard Shortcuts and Menu reordering
Review URL: https://codereview.appspot.com/6400051
git-svn-id: http://skia.googlecode.com/svn/trunk@4630 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 9ca9bfe9f6eaae41841446386e40be1013907e99 |
|
12-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Feature, HitBox selects current command
Review URL: https://codereview.appspot.com/6345091
git-svn-id: http://skia.googlecode.com/svn/trunk@4588 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 233e4b80e056b0529aadbcc9cf8fb8754433cde1 |
|
12-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Bug Fix: Delete redraws correctly when redraw command execution is paused
Review URL: https://codereview.appspot.com/6392053
git-svn-id: http://skia.googlecode.com/svn/trunk@4567 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e606d6e210b17dd9dd582d4d3ec70acb4f3213d5 |
|
12-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkHitBox added.
SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.
Review URL: https://codereview.appspot.com/6350098
git-svn-id: http://skia.googlecode.com/svn/trunk@4565 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| e565de4fad5598890124daadf385930043269415 |
|
12-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Seperated Space for displaying breakpoint and deletion icons
Review URL: https://codereview.appspot.com/6356094
git-svn-id: http://skia.googlecode.com/svn/trunk@4563 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| f927f44a29d999726aaa5792ee8a5e0e56bfa127 |
|
10-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Bug Fix: Pause drawing execution feature works due to fixed typo
Review URL: https://codereview.appspot.com/6349086
git-svn-id: http://skia.googlecode.com/svn/trunk@4505 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| c432f00a84e2b3d759b3f24ec687af7320121eea |
|
10-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Made everything in SkDebuggerGUI live on the stack
Review URL: https://codereview.appspot.com/6389043
git-svn-id: http://skia.googlecode.com/svn/trunk@4502 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 7dcae67cae277549accdd38d0496b72d00151239 |
|
09-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Added stubs for zoom info panel.
Review URL: https://codereview.appspot.com/6350071
git-svn-id: http://skia.googlecode.com/svn/trunk@4493 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 2f891793957252b0262276c957c67798c905be80 |
|
03-Jul-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adds functionality to the matrix and clip widget.
Review URL: https://codereview.appspot.com/6348058
git-svn-id: http://skia.googlecode.com/svn/trunk@4453 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|
| 902ebe5eb41a350b766238b3b103c22fe9fc0fb5 |
|
29-Jun-2012 |
chudy@google.com <chudy@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
clt debugger
Review URL: https://codereview.appspot.com/6267043
git-svn-id: http://skia.googlecode.com/svn/trunk@4404 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/debugger/QT/SkDebuggerGUI.cpp
|