| dbfd7ab10883f173f5c1b653a233e18dc6142002 |
|
01-Sep-2016 |
mtklein <mtklein@chromium.org> |
Replace a lot of 'static const' with 'constexpr' or 'const'.
'static const' means, there must be at most one of these, and initialize it at
compile time if possible or runtime if necessary. This leads to unexpected
code execution, and TSAN* will complain about races on the guard variables.
Generally 'constexpr' or 'const' are better choices. Neither can cause races:
they're either intialized at compile time (constexpr) or intialized each time
independently (const).
This CL prefers constexpr where possible, and uses const where not. It even
prefers constexpr over const where they don't make a difference... I want to have
lots of examples of constexpr for people to see and mimic.
The scoped-to-class static has nothing to do with any of this, and is not changed.
* Not yet on the bots, which use an older TSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005
Review-Url: https://codereview.chromium.org/2300623005
/external/skia/gm/circulararcs.cpp
|
| f71ab8f58b0a7abb7818cf665dfb116ef370d572 |
|
26-Aug-2016 |
caryclark <caryclark@google.com> |
avoid generating degenerate conic from arc
R=bsalomon@google.com
BUG=skia:5672
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281953002
Review-Url: https://codereview.chromium.org/2281953002
/external/skia/gm/circulararcs.cpp
|
| 21af9ca1b1f54d9ba1de055aa8475928d5c8ecdf |
|
25-Aug-2016 |
bsalomon <bsalomon@google.com> |
Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for oddball drawArcs
Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws
if the oval is empty or the sweep angle is 0.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002
Review-Url: https://codereview.chromium.org/2281653002
/external/skia/gm/circulararcs.cpp
|
| 4c261d0c1e46159d72b2a5351b3186f80bc69d91 |
|
22-Aug-2016 |
bsalomon <bsalomon@google.com> |
Add cap type variations to circular arcs GMs
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269723002
Review-Url: https://codereview.chromium.org/2269723002
/external/skia/gm/circulararcs.cpp
|
| ac1d0abfd89ded89d57ea5e985e04c81c3c8ebf2 |
|
22-Aug-2016 |
bsalomon <bsalomon@google.com> |
Add stroke-and-fill circular arc test, test near 180deg arc in all circular_arc_tests
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261233002
Review-Url: https://codereview.chromium.org/2261233002
/external/skia/gm/circulararcs.cpp
|
| 36da77122644c591a0fbe69291d2442018c060e2 |
|
22-Aug-2016 |
bsalomon <bsalomon@google.com> |
Adjust angles in circular arcs GMs to test smaller arcs
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267713002
Review-Url: https://codereview.chromium.org/2267713002
/external/skia/gm/circulararcs.cpp
|
| 4c54788e9298dce2b963ce288baf0d1695323e1f |
|
19-Aug-2016 |
bsalomon <bsalomon@google.com> |
Rename circular_arcs_circular_arcs_fill to circular_arcs_fill.
Also fix issue with second paint's alpha getting overwritten.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265643002
Review-Url: https://codereview.chromium.org/2265643002
/external/skia/gm/circulararcs.cpp
|
| 71c5eee9d55af9b93696b8825561f986cb3b7b9b |
|
19-Aug-2016 |
bsalomon <bsalomon@google.com> |
Add GMs for testing drawArc.
This is in preparation for virtualizing this on SkCanvas/SkDevice.
Tests the following variations:
aa and non-aa
stroke/hairline/fill
cap types
using center point and not
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002
Review-Url: https://codereview.chromium.org/2264593002
/external/skia/gm/circulararcs.cpp
|