f264e996838dffd28a5a733d8d804142125944e6 |
|
13-Jul-2017 |
Florin Malita <fmalita@chromium.org> |
Delete unread SkPicture mbox No longer read?! Change-Id: I6258a64590bb5ee16e02a7ad923ad41cc7bd8791 Reviewed-on: https://skia-review.googlesource.com/23043 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkPicture.h
|
da69944cbb9e561694716b8882d201d4f7f8790e |
|
11-Jul-2017 |
wutao <wutao@chromium.org> |
Serialize the new TileMode in SkBlurImageFilterImpl. Serialize the new TileMode in SkBlurImageFilterImpl. And also update the SkReadBuffer::Version and CURRENT_PICTURE_VERSION in SkPicture. Bug: 622128 Change-Id: I3b04be2a36406227c6d8112e943d7415566c0c42 Reviewed-on: https://skia-review.googlesource.com/22079 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/include/core/SkPicture.h
|
0bdaf05fc17ebe5d4ad01d70c80df2425e83c737 |
|
19-Jun-2017 |
Mike Reed <reed@google.com> |
remove unused mode parameter from SkMergeImageFilter Bug: skia: Change-Id: Iaa46aaef130a337987c3528685f59c56387d4a7d Reviewed-on: https://skia-review.googlesource.com/20210 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
01b2b83aba10bc3767d660cd619c1da58b5eb0b5 |
|
09-Jun-2017 |
Mike Reed <reed@google.com> |
Extend composeshader to support a lerp parameter Bug: skia: Change-Id: I3bbb2cb8d0a84fca0309654498548ebc94d8938f Reviewed-on: https://skia-review.googlesource.com/18460 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkPicture.h
|
70bc94f273224ed0755ae11dc479c57ff37e0436 |
|
08-Jun-2017 |
Mike Reed <reed@google.com> |
Bump min picture to 7+ months ago Delete lots of support code, including need for SkXfermode objects which are no longer used anywhere else. Bug: skia: Change-Id: Id6b7ef0f529691041ff2b206c35e336e8a4c974d Reviewed-on: https://skia-review.googlesource.com/19059 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkPicture.h
|
53f77bd4fdd76525b66b7f26d1c5c550858120df |
|
28-Apr-2017 |
Florin Malita <fmalita@chromium.org> |
Initial clip-mask-layer support SkBitmapDevice-only implementation. Will add A8 fast path specializations in a follow-up. Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 BUG=skia:6005 Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 Reviewed-on: https://skia-review.googlesource.com/14183 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
/external/skia/include/core/SkPicture.h
|
3a9a7a310c5cff72bc1c2388a496af1b82326355 |
|
13-Mar-2017 |
Florin Malita <fmalita@chromium.org> |
Remove run count field from SkTextBlob. We can flag the last run record instead. Run iteration is always sequential, so no penalty. As a side effect, we can no longer allow instantiation of zero-run text blobs - but that seems like a good idea anyway. Change-Id: I7ca80c4780623d5a188f92dfe6d6fe152f20f666 Reviewed-on: https://skia-review.googlesource.com/9149 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
19c22e946dd9f18de82f7728db80934efe262847 |
|
10-Feb-2017 |
Robert Phillips <robertphillips@google.com> |
Revert "Roll minimum picture version up to 44." This reverts commit e037d12625b1dbb7952ae8a6553d6830e8b3ebbf. Reason for revert: Checking to see if this broke the Chrome DEPS roll Original change's description: > Roll minimum picture version up to 44. > > This is the version produced by Chrome M54. M56 is stable now. > > I am most interested in deleting SkBitmapSourceDeserializer, > because it awkwardly calls from core into effects (SkImageSource). > > Change-Id: I58b8b990017ba43372ab3333a4ef8312e75abc61 > Reviewed-on: https://skia-review.googlesource.com/8286 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I9202591c7945c9421f335e544bf12461e38acdc6 Reviewed-on: https://skia-review.googlesource.com/8305 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/include/core/SkPicture.h
|
e037d12625b1dbb7952ae8a6553d6830e8b3ebbf |
|
09-Feb-2017 |
Mike Klein <mtklein@chromium.org> |
Roll minimum picture version up to 44. This is the version produced by Chrome M54. M56 is stable now. I am most interested in deleting SkBitmapSourceDeserializer, because it awkwardly calls from core into effects (SkImageSource). Change-Id: I58b8b990017ba43372ab3333a4ef8312e75abc61 Reviewed-on: https://skia-review.googlesource.com/8286 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/include/core/SkPicture.h
|
09d9435835f48b06954904f16d14c1c2eeaaad2e |
|
31-Oct-2016 |
Mike Reed <reed@google.com> |
remove lots of legacy flags BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4209 Change-Id: I49ae36a9b2bb51a6470638d3264923ff4a4dea0a Reviewed-on: https://skia-review.googlesource.com/4209 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
7d954ad797176afedb9262fdea4507d0fc60eb9d |
|
28-Oct-2016 |
Mike Reed <reed@google.com> |
remove xfermode from public api BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4020 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I19cd056f2af778f10e8c6c2b7b2735593b43dbac Reviewed-on: https://skia-review.googlesource.com/4020 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
374772bd61951f01bf84fe17bf53d8867681c9ae |
|
06-Oct-2016 |
reed <reed@google.com> |
Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit c245574ba3d0e2ade6c94b2812de3baa383bf4c4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2396953002 TBR= Review-Url: https://codereview.chromium.org/2396953002
/external/skia/include/core/SkPicture.h
|
c245574ba3d0e2ade6c94b2812de3baa383bf4c4 |
|
05-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[7] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8. Reason for revert: new assert from 100K bot Original change's description: > Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints" > > - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter > This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 > > Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 > Reviewed-on: https://skia-review.googlesource.com/2992 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I848e5a69c5cd67f2c14889f4f0a346652578c4ff Reviewed-on: https://skia-review.googlesource.com/3023 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
2b2fc7db4f8a4a4d4a51d7eb4df6aa62e309928d |
|
05-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints" - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 Reviewed-on: https://skia-review.googlesource.com/2992 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
3ed485f4249e17abb4b11f5018d03175fd1afb44 |
|
04-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[5] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit I0fa5c58af428f3da8565465d1219a34ef8417d9a. Reason for revert: failing to deserialize some of the 100K Original change's description: > Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints" > > This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 > > Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a > Reviewed-on: https://skia-review.googlesource.com/2924 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I1805a57eef5ebcac203da5989c8539345ecf806f Reviewed-on: https://skia-review.googlesource.com/2962 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
1834242ec6e3cd62669227d394bc79e1cd66dcfb |
|
04-Oct-2016 |
Mike Reed <reed@google.com> |
Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a Reviewed-on: https://skia-review.googlesource.com/2924 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
2cbcd12281ee807214df094964c584c78932e10b |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""" This reverts commit I86875511a13497112827cbaed1dbd7639e9e3d10. legacy (100K) skp failure Original change's description: > Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"" > > This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 > > Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 > Reviewed-on: https://skia-review.googlesource.com/2878 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=msarett@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ife6f0cf3a22b3e8cf885a188f7f44e1ff62e06a5 Reviewed-on: https://skia-review.googlesource.com/2881 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
70cdb396eb5ffbbed128b902532e9292b5ec0e9d |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"" This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 Reviewed-on: https://skia-review.googlesource.com/2878 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
ce02e7175872abde3721df9e5d3ec0ab8384cd8e |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
Revert "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit I4fb489ba6b3f77b458f7e4a99f79c7ad10859135. Reason for revert: <INSERT REASONING HERE> Original change's description: > replace SkXfermode obj with SkBlendMode enum in paints > > BUG=skia:5814 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 > > Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 > Reviewed-on: https://skia-review.googlesource.com/2714 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bsalomon@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I3e43f79ef5c1709929663fe63cc1f67cd78270b7 Reviewed-on: https://skia-review.googlesource.com/2871 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
0591897548c8fcb7d53cc94053e01702e58f1ac5 |
|
03-Oct-2016 |
Mike Reed <reed@google.com> |
replace SkXfermode obj with SkBlendMode enum in paints BUG=skia:5814 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 Reviewed-on: https://skia-review.googlesource.com/2714 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/core/SkPicture.h
|
d921dbb9b88327eef7b1fbd42e9d88bace4a65ff |
|
30-Sep-2016 |
reed <reed@google.com> |
Propagate validation errors from inner readbuffer when deserializing picture. Also allow null paints. BUG=skia:5812 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002 Review-Url: https://codereview.chromium.org/2379383002
/external/skia/include/core/SkPicture.h
|
e25d71ccbcdb47c7ee7bdf13235066092ae11af3 |
|
28-Sep-2016 |
brianosman <brianosman@google.com> |
Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace Added gradient shader factories that take SkColor4f + SkColorSpace. Modified Descriptor to only store SkColor4f + SkColorSpace. Existing factories make use of helper code to convert SkColor and forward to the new factories. Bumped SKP version to handle new gradient serialization format. I was toying with using half-float when serializing SkColor4f, despite my aggressive packing of flags, this format is significantly bigger. Also added GM to use 4f factories. This GM should (and does) look identical to the existing gradients GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002 Review-Url: https://codereview.chromium.org/2370063002
/external/skia/include/core/SkPicture.h
|
39eaf5f9fd71183da5c3531cf4ce27b3161fcd60 |
|
15-Sep-2016 |
reed <reed@google.com> |
add helpers for using SkData with picture serialization BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341693004 TBR= Review-Url: https://codereview.chromium.org/2341693004
/external/skia/include/core/SkPicture.h
|
4f0a23a8d54f5eb0fdacfff7c109b9045b548978 |
|
30-Aug-2016 |
halcanary <halcanary@google.com> |
SkTextBlob: Begin implementing Extended TextBlob API BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084533004 Review-Url: https://codereview.chromium.org/2084533004
/external/skia/include/core/SkPicture.h
|
a9ca05ca5e604b9ee18e9cce19b059085ca0e22c |
|
11-Aug-2016 |
reed <reed@google.com> |
Deserialize pictures with custom image-deserializer BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187613002 Review-Url: https://codereview.chromium.org/2187613002
/external/skia/include/core/SkPicture.h
|
27cdd947903a4262bb483e7d35153358f4541bf8 |
|
11-Aug-2016 |
robertphillips <robertphillips@google.com> |
Implement GPU occluded blur mask filter Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related to blur mask filters) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002 Review-Url: https://codereview.chromium.org/2201133002
/external/skia/include/core/SkPicture.h
|
b8113780c3cfed640016b263194b7f1531d43312 |
|
26-Jul-2016 |
bungeman <bungeman@google.com> |
Update typeface serialization style. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17 Review-Url: https://codereview.chromium.org/2030683002
/external/skia/include/core/SkPicture.h
|
45561a0b15fe045ba272c328684c3f7ae290785a |
|
07-Jul-2016 |
reed <reed@google.com> |
drawTextRSXform BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004 Review-Url: https://codereview.chromium.org/2130643004
/external/skia/include/core/SkPicture.h
|
f8f9c07c283a3204a38b4324c14597e644686428 |
|
13-Jun-2016 |
mtklein <mtklein@google.com> |
Revert of Update typeface serialization style. (patchset #3 id:40001 of https://codereview.chromium.org/2030683002/ ) Reason for revert: serialize-8888 broken for typefacestyles on Mac. (Bold weighting goes missing.) Original issue's description: > Update typeface serialization style. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 > > Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17 TBR=reed@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2067583002
/external/skia/include/core/SkPicture.h
|
7ae1c72e593823e6e300e4199558555765bcec17 |
|
13-Jun-2016 |
bungeman <bungeman@google.com> |
Update typeface serialization style. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 Review-Url: https://codereview.chromium.org/2030683002
/external/skia/include/core/SkPicture.h
|
796e365999220f53acc58ba91ed55bb35900c8bc |
|
13-May-2016 |
fmalita <fmalita@chromium.org> |
SkPictureGpuAnalyzer Stateful helper for gathering multi-picture GPU stats. Exposes the existing SkPicture GPU veto semantics, while preserving the SKP impl (which has some nice properties: lazy, hierarchical, cached per pic). R=reed@google.com,bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974833003 Review-Url: https://codereview.chromium.org/1974833003
/external/skia/include/core/SkPicture.h
|
1e2e33a74d707b918a0b1063047bbb25ee81ae67 |
|
12-May-2016 |
fmalita <fmalita@chromium.org> |
Remove SkPicture::hasText() No longer used in Chromium. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978533002 Review-Url: https://codereview.chromium.org/1978533002
/external/skia/include/core/SkPicture.h
|
99e20891a080f39113bd7a5dc202730f2a13fa07 |
|
22-Apr-2016 |
robertphillips <robertphillips@google.com> |
Optionally enable SkValidatingReadBuffer in SkPictureImageFilter The task here is to get the type of ReadBuffer being used in SkPicture::MakeFromBuffer mirrored in the down-stack SkPicturePlayback::draw call. BUG=skia:5208 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918433002 Review URL: https://codereview.chromium.org/1918433002
/external/skia/include/core/SkPicture.h
|
0576aa9c0722bba358a27f80cc134ea2cd4ca2c9 |
|
08-Apr-2016 |
mtklein <mtklein@chromium.org> |
Serialize invNormRotation in SkLightingShader. This fixes a serialize-8888 / 8888 GM mismatch. This requires a picture bump so we know not to bother trying to read the invNormRotation vector from older .SKPs. Any chance no one's ever made one? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870443002 Just bumping the picture version. TBR=reed@google.com Review URL: https://codereview.chromium.org/1870443002
/external/skia/include/core/SkPicture.h
|
41c409634cb9ac01afd1ead4442d7c10817b3e33 |
|
24-Mar-2016 |
fmalita <fmalita@chromium.org> |
Relocate SK_SUPPORT_LEGACY_PICTURE_PTR Move to platform-specific defines. (Chromium already has this guard) R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831053002 Review URL: https://codereview.chromium.org/1831053002
/external/skia/include/core/SkPicture.h
|
e8597a4dd07d78eb0e7a45d6502896c1b9a8bfeb |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkPicture.h
|
910f7ec7e79cd051f69b47c3e19d4fda2adbcef4 |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #9 id:150001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Roll still failing Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 > > Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb > > Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1830943002
/external/skia/include/core/SkPicture.h
|
f037fdebda2a2626e6512d7532063f2cd41a264d |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkPicture.h
|
041c870425eb0a3e2b0cbc46581b3da2f50571d9 |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #8 id:130001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Testing the roll - it's still failing Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 > > Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1828433004
/external/skia/include/core/SkPicture.h
|
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb |
|
24-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkPicture.h
|
39b54951c4e61c137d9911685600490da25470c1 |
|
23-Mar-2016 |
msarett <msarett@google.com> |
Revert of Delete SkImageDecoder (patchset #7 id:110001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Various problems Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1830723002
/external/skia/include/core/SkPicture.h
|
f799706656f2581c5bf5510d94df3fa17cce1607 |
|
23-Mar-2016 |
msarett <msarett@google.com> |
Delete SkImageDecoder This image decoding implementation has been replaced by SkCodec in Android. Additionally, we have replaced uses of SkImageDecoder in Skia and Google3 with uses of SkCodec. Now we can delete SkImageDecoder :). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1820503002
/external/skia/include/core/SkPicture.h
|
ca2622ba051829fed5f30facd74c5b41cd4b931c |
|
18-Mar-2016 |
reed <reed@google.com> |
return pictures as sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811703002 Review URL: https://codereview.chromium.org/1811703002
/external/skia/include/core/SkPicture.h
|
f70b531daaf47db1ee95c70da9843f1dd1f418d3 |
|
05-Mar-2016 |
reed <reed@google.com> |
Move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ )" Need to land chrome change first https://codereview.chromium.org/1766723003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758023003 TBR= Review URL: https://codereview.chromium.org/1758023003
/external/skia/include/core/SkPicture.h
|
1610835624a9658cc60940b80038b84f297e836f |
|
03-Mar-2016 |
reed <reed@google.com> |
Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) Reason for revert: need to update unittest in blink: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DV8_SHARED -DUSING_V8_SHARED -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../third_party/WebKit/public/web -I../../third_party/WebKit/Source/web -I../../third_party/WebKit/Source/web/src -I../../third_party/WebKit/public/web/mac -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/libwebp -I../../third_party/zlib -I../../v8/include -Igen/blink -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -fstack-protector-all -c ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp -o obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp:54:20: error: no member named 'getAnnotation' in 'SkPaint' if (!paint.getAnnotation()) ~~~~~ ^ Original issue's description: > move annotations to canvas virtual > > In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002 > > Committed: https://skia.googlesource.com/skia/+/0eda2587cc9233066cb3f3fec08f35c061780f8e TBR=halcanary@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1761793003
/external/skia/include/core/SkPicture.h
|
0eda2587cc9233066cb3f3fec08f35c061780f8e |
|
03-Mar-2016 |
reed <reed@google.com> |
move annotations to canvas virtual In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002 Review URL: https://codereview.chromium.org/1744103002
/external/skia/include/core/SkPicture.h
|
8715d47e247bf890ee78af0774ae7e8698146b67 |
|
17-Feb-2016 |
msarett <msarett@google.com> |
Make SkPicture/SkImageGenerator default to SkCodec Remove reference to SkImageDecoder from SkPicture. Make the default InstallPixelRefProc passed to CreateFromStream use SkImageGenerator::NewFromEncoded instead. Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator. Remove the old version that used SkImageDecoder. Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default now behaves lazily. Update all clients to use the default. Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly. This is a rebased version of: https://codereview.chromium.org/1671193002/ TBR=reed@google.com BUG=skia:4691 BUG=skia:4290 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699183004 Review URL: https://codereview.chromium.org/1699183004
/external/skia/include/core/SkPicture.h
|
1de415f2c33febbac668500afbbb0c9b120c125f |
|
10-Feb-2016 |
kjlubick <kjlubick@google.com> |
Revert of Make SkPicture/SkImageGenerator default to SkCodec (patchset #7 id:120001 of https://codereview.chromium.org/1671193002/ ) Reason for revert: Breaks Ubuntu and Mac CMAKE Original issue's description: > Make SkPicture/SkImageGenerator default to SkCodec > > Remove reference to SkImageDecoder from SkPicture. Make the default > InstallPixelRefProc passed to CreateFromStream use > SkImageGenerator::NewFromEncoded instead. > > Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator. > Remove the old version that used SkImageDecoder. > > Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default > now behaves lazily. > > Update all clients to use the default. > > Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly. > > BUG=skia:4691 > BUG=skia:4290 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002 > > Committed: https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6 TBR=msarett@google.com,reed@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4691 Review URL: https://codereview.chromium.org/1685963004
/external/skia/include/core/SkPicture.h
|
026388a01864c74208ad57d1ba4f711602d101c6 |
|
10-Feb-2016 |
scroggo <scroggo@google.com> |
Make SkPicture/SkImageGenerator default to SkCodec Remove reference to SkImageDecoder from SkPicture. Make the default InstallPixelRefProc passed to CreateFromStream use SkImageGenerator::NewFromEncoded instead. Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator. Remove the old version that used SkImageDecoder. Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default now behaves lazily. Update all clients to use the default. Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly. BUG=skia:4691 BUG=skia:4290 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002 Review URL: https://codereview.chromium.org/1671193002
/external/skia/include/core/SkPicture.h
|
2f5891ea6460675b3c8d08684e1fa8b239bc0a14 |
|
25-Sep-2015 |
fmalita <fmalita@chromium.org> |
Remove SkBitmapSource To avoid breaking existing SKPs, add a deserialization stub which unflattens SkBitmapSource records to SkImageSources. R=reed@google.com,mtklein@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/1363913002
/external/skia/include/core/SkPicture.h
|
c3470340b6658dea7baa3ac90d3b716c0afd7051 |
|
04-Sep-2015 |
fmalita <fmalita@chromium.org> |
Handle zero-length encoded images gracefully during deserialization Image encoding may fail during serialization, resulting in zero-length encoded data in the SKP. Instead of invalidating the stream (and preventing deserialization of the whole picture) we can instantiate placeholder images. BUG=skia:4285 R=reed@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/1308273011
/external/skia/include/core/SkPicture.h
|
0c263fa9f80b9a20b6f6161a2e9a263c2c586a9b |
|
18-Aug-2015 |
mtklein <mtklein@chromium.org> |
Deduplicate typefaces across sub-pictures Old flow to serialize a picture: 1) serialize picture ops 2) serialize all sub pictures recursively 3) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go 4) serialize the factories and typefaces 5) serialize the bytes from 3) This allows the data in step 5) to refer to the deduplicated factories and typefaces from step 4). But, each sub picture in step 2) is completely siloed, so they can't dedup with the parent picture or each other. New flow: 1) serialize picture ops 2) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go 3) dummy-serialize sub pictures into /dev/null, with the effect of adding any new typefaces to our dedup set 4) serialize the factories and typefaces 5) serialize the bytes from 2) 6) serialize all sub pictures recursively, with perfect deduplication because of step 3). Now all typefaces in the top-level picture and all sub pictures recursively should end up deduplicated in the top-level typeface set. Decoding changes are similar: we just thread through the top-level typefaces to the sub pictures. What's convenient / surprising is that this new code correctly reads old pictures if we just have each picture prefer its local typeface set over the top-level one: old pictures always just use their own typefaces, and new pictures always use the top-level ones. BUG=skia:4092 Review URL: https://codereview.chromium.org/1233953004
/external/skia/include/core/SkPicture.h
|
95dd17737d0fa0401782f7fa72e5d69bb5686f67 |
|
18-Aug-2015 |
reed <reed@chromium.org> |
Revert[8] "move some public headers into private" This reverts commit fb28cd2b13d76c324570341e1155aaadc1b532b6. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1298833002
/external/skia/include/core/SkPicture.h
|
fb28cd2b13d76c324570341e1155aaadc1b532b6 |
|
15-Aug-2015 |
reed <reed@chromium.org> |
Revert[7] "move some public headers into private" This reverts commit e02716908fe82c7c4ae9b415793277620a22bcd6. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1300523002
/external/skia/include/core/SkPicture.h
|
e02716908fe82c7c4ae9b415793277620a22bcd6 |
|
15-Aug-2015 |
reed <reed@chromium.org> |
Revert[6] "move some public headers into private" This reverts commit cc1229c9d5e57b45305ba8f99ae33e92db0032bc. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1295003002
/external/skia/include/core/SkPicture.h
|
cc1229c9d5e57b45305ba8f99ae33e92db0032bc |
|
13-Aug-2015 |
reed <reed@chromium.org> |
Revert "Revert[4] "move some public headers into private"" This reverts commit 33e00db73d5f1836481cf4053c64e4ed20537662. BUG=skia: TBR= NOTREECHECKS=True FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/user_manager/user_manager_test_support.fake_user_manager.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=242792-1 -DCOMPONENT_BUILD -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../.. -I../../skia/config -I../../testing/gmock/include -I../../testing/gtest/include -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/linux_chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -B/b/build/slave/linux_chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -O0 -g -funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -g0 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../components/user_manager/fake_user_manager.cc -o obj/components/user_manager/user_manager_test_support.fake_user_manager.o In file included from ../../components/user_manager/fake_user_manager.cc:5: In file included from ../../components/user_manager/fake_user_manager.h:12: In file included from ../../components/user_manager/user.h:14: In file included from ../../components/user_manager/user_image/user_image.h:12: In file included from ../../ui/gfx/image/image_skia.h:15: In file included from ../../ui/gfx/image/image_skia_rep.h:8: In file included from ../../third_party/skia/include/core/SkBitmap.h:11: In file included from ../../third_party/skia/include/core/SkColor.h:11: In file included from ../../third_party/skia/include/core/SkScalar.h:12: ../../third_party/skia/include/core/../private/SkFloatingPoint.h:13:10: fatal error: 'SkTypes.h' file not found #include "SkTypes.h" ninja -w dupbuild=err -C /b/build/slave/linux_chromeos/build/src/out/Debug accessibility_unittests accessibility_unittests_run app_list_unittests app_list_unittests_run app_shell_unittests app_shell_unittests_run ash_unittests ash_unittests_run aura_builder aura_unittests aura_unittests_run base_unittests base_unittests_run browser_tests browser_tests_run cacheinvalidation_unittests cacheinvalidation_unittests_run chromeos_unittests chromeos_unittests_run components_unittests components_unittests_run compositor_unittests compositor_unittests_run content_browsertests content_browsertests_run content_unittests content_unittests_run crypto_unittests crypto_unittests_run dbus_unittests device_unittests device_unittests_run display_unittests display_unittests_run events_unittests events_unittests_run extensions_browsertests extensions_browsertests_run extensions_unittests extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests gfx_unittests_run google_apis_unittests google_apis_unittests_run gpu_unittests gpu_unittests_run interactive_ui_tests interactive_ui_tests_run ipc_tests ipc_tests_run jingle_unittests jingle_unittests_run media_unittests media_unittests_run message_center_unittests message_center_unittests_run midi_unittests midi_unittests_run nacl_helper_nonsfi_unittests nacl_loader_unittests nacl_loader_unittests_run net_unittests net_unittests_run ppapi_unittests printing_unittests printing_unittests_run remoting_unittests remoting_unittests_run sandbox_linux_unittests sandbox_linux_unittests_run skia_unittests skia_unittests_run sql_unittests sql_unittests_run sync_unit_tests sync_unit_tests_run ui_base_unittests ui_base_unittests_run ui_chromeos_unittests ui_touch_selection_unittests ui_touch_selection_unittests_run unit_tests unit_tests_run url_unittests url_unittests_run views_unittests wm_unittests wm_unittests_run -j50 ninja: Entering directory `/b/build/slave/linux_chromeos/build/src/out/Debug' Review URL: https://codereview.chromium.org/1288863002
/external/skia/include/core/SkPicture.h
|
33e00db73d5f1836481cf4053c64e4ed20537662 |
|
12-Aug-2015 |
reed <reed@google.com> |
Revert[4] "move some public headers into private" This reverts commit 9cdcabefa33d49febfdb45e388e762b4dee8dd6f. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1291613007
/external/skia/include/core/SkPicture.h
|
9cdcabefa33d49febfdb45e388e762b4dee8dd6f |
|
12-Aug-2015 |
reed <reed@chromium.org> |
Revert[3] "move some public headers into private" This reverts commit 9d20ee57d72a3850a6b51f2f2b00e00978be3864. BUG=skia: TBR= failures here: https://codereview.chromium.org/1286103004 Review URL: https://codereview.chromium.org/1290733002
/external/skia/include/core/SkPicture.h
|
9d20ee57d72a3850a6b51f2f2b00e00978be3864 |
|
12-Aug-2015 |
reed <reed@chromium.org> |
Revert[2] "move some public headers into private" This reverts commit 4cf9e7e14797f87f08b2078fa1afaf731cbf8f52. BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/1284173002
/external/skia/include/core/SkPicture.h
|
4cf9e7e14797f87f08b2078fa1afaf731cbf8f52 |
|
11-Aug-2015 |
reed <reed@google.com> |
Revert "move some public headers into private" This reverts commit eedf0fb20489bc6c3706539dd6ab499f41cbe048. BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/1270313005
/external/skia/include/core/SkPicture.h
|
eedf0fb20489bc6c3706539dd6ab499f41cbe048 |
|
11-Aug-2015 |
reed <reed@chromium.org> |
move some public headers into private BUG=skia: Review URL: https://codereview.chromium.org/1289483002
/external/skia/include/core/SkPicture.h
|
871872f3f247f6b699617f6d9ef50ef5da6fbe74 |
|
22-Jun-2015 |
reed <reed@google.com> |
change old picture serialization to really handle images BUG=skia:3965 Review URL: https://codereview.chromium.org/1199473002
/external/skia/include/core/SkPicture.h
|
446ee67fda73b11281b8e28a68edec811347c0c5 |
|
16-Jun-2015 |
hendrikw <hendrikw@chromium.org> |
skia: Add runtime option to disable picture IO security precautions Replaced the compile time file IO security setting with a runtime setting. Unfortunately the setting is global. Review URL: https://codereview.chromium.org/1183853003
/external/skia/include/core/SkPicture.h
|
109a23d64ff9cf210e6b0aa8940b4fcea3f05a97 |
|
15-Jun-2015 |
fmalita <fmalita@chromium.org> |
Remove the SkCanvas comment API No longer used in Chromium/Blink. R=reed@google.com,robertphillips@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1153593003
/external/skia/include/core/SkPicture.h
|
76be9c8dc0e5306ef81c2987848088cdec7ccd3f |
|
20-May-2015 |
mtklein <mtklein@chromium.org> |
Don't serialize SkPictures in SkPictureShaders when in untrusted mode. This requires we "first" add a has-picture bool to SkPictureShader serialized format. BUG=chromium:486947, billions and billions of others. Review URL: https://codereview.chromium.org/1151663002
/external/skia/include/core/SkPicture.h
|
fd6a07b1e835f692b7dcb837027db6d5cc253618 |
|
20-May-2015 |
mtklein <mtklein@chromium.org> |
Have SkPicture inherit from SkRefCnt. This re-enables adoption tracking for SkPictures in Blink, which should be green now that crrev.com/1136123011 has landed. BUG=skia:3847 Review URL: https://codereview.chromium.org/1145153002
/external/skia/include/core/SkPicture.h
|
9db912c2ac2ab53bc24f2d50a3e5a80162051dcc |
|
19-May-2015 |
mtklein <mtklein@chromium.org> |
Sketch splitting SkPicture into an interface and SkBigPicture. Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b Latest blink_linux_rel: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 Committed: https://skia.googlesource.com/skia/+/15877b6eae33a9282458bdb904a6d00440eca0ec http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/62015 Review URL: https://codereview.chromium.org/1112523006
/external/skia/include/core/SkPicture.h
|
72743b165424efc4ef6f6614add9033ea1ef31db |
|
18-May-2015 |
mtklein <mtklein@google.com> |
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #25 id:480001 of https://codereview.chromium.org/1112523006/) Reason for revert: win_chromium_compile_dbg_ng FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\skia\src\core\skia.SkBitmapHeap.obj.rsp /c ..\..\third_party\skia\src\core\SkBitmapHeap.cpp /Foobj\third_party\skia\src\core\skia.SkBitmapHeap.obj /Fdobj\skia\skia.cc.pdb e:\b\build\slave\win\build\src\third_party\skia\include\core\skpicture.h(176) : error C2487: 'CURRENT_PICTURE_VERSION' : member of dll interface class may not be declared with dll interface Original issue's description: > Sketch splitting SkPicture into an interface and SkBigPicture. > > Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). > These cover about 89% of draw calls from Blink SKPs, > and about 25% of draw calls from our GMs. > > SkPicture handles: > - serialization and deserialization > - unique IDs > > Everything else is left to the subclasses: > - playback(), cullRect() > - hasBitmap(), hasText(), suitableForGPU(), etc. > - LayerInfo / AccelData if applicable. > > The time to record a 1-op picture improves a good chunk > (2 mallocs to 1), and the time to record a 0-op picture > greatly improves (2 mallocs to none): > > picture_overhead_draw: 450ns -> 350ns > picture_overhead_nodraw: 300ns -> 90ns > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b > > Latest blink_linux_rel: > > http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 > > Committed: https://skia.googlesource.com/skia/+/15877b6eae33a9282458bdb904a6d00440eca0ec TBR=reed@google.com,robertphillips@google.com,fmalita@chromium.org,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1130283004
/external/skia/include/core/SkPicture.h
|
15877b6eae33a9282458bdb904a6d00440eca0ec |
|
18-May-2015 |
mtklein <mtklein@chromium.org> |
Sketch splitting SkPicture into an interface and SkBigPicture. Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b Latest blink_linux_rel: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 Review URL: https://codereview.chromium.org/1112523006
/external/skia/include/core/SkPicture.h
|
c30806f9f16e6400036fdc25842b73a9d2a41cb3 |
|
14-May-2015 |
mtklein <mtklein@chromium.org> |
Perform SkPicture analysis lazily. I realized when writing the comment on https://crrev.com/1135363002/ that I'd really just sketched out the entire thing, so I couldn't help but actually write up a working CL. How does this do for your benchmark? BUG=chromium:487075 Review URL: https://codereview.chromium.org/1130123006
/external/skia/include/core/SkPicture.h
|
b7ed856fadae52401d3bbcac22cfc3391780ace8 |
|
08-May-2015 |
reed <reed@chromium.org> |
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/1112523006/) Reason for revert: speculative revert to fix failures in DEPS roll Original issue's description: > Sketch splitting SkPicture into an interface and SkBigPicture. > > Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). > These cover about 89% of draw calls from Blink SKPs, > and about 25% of draw calls from our GMs. > > SkPicture handles: > - serialization and deserialization > - unique IDs > > Everything else is left to the subclasses: > - playback(), cullRect() > - hasBitmap(), hasText(), suitableForGPU(), etc. > - LayerInfo / AccelData if applicable. > > The time to record a 1-op picture improves a good chunk > (2 mallocs to 1), and the time to record a 0-op picture > greatly improves (2 mallocs to none): > > picture_overhead_draw: 450ns -> 350ns > picture_overhead_nodraw: 300ns -> 90ns > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1130333002
/external/skia/include/core/SkPicture.h
|
c92c129ff85b05a714bd1bf921c02d5e14651f8b |
|
07-May-2015 |
mtklein <mtklein@chromium.org> |
Sketch splitting SkPicture into an interface and SkBigPicture. Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Review URL: https://codereview.chromium.org/1112523006
/external/skia/include/core/SkPicture.h
|
2420e10d5a86da1964a05a749ab9bb625ae9f13e |
|
29-Apr-2015 |
mtklein <mtklein@chromium.org> |
Straighten out SkPicture::AccelData APIs. Must have been we needed them to be weird (mutable, const setter) before. It doesn't look like that's necessary now... we can just pass it to the constructor. BUG=skia: Review URL: https://codereview.chromium.org/1112833003
/external/skia/include/core/SkPicture.h
|
00c2af8b731085a7fe456e689b70f019a34ef7dd |
|
27-Apr-2015 |
mtklein <mtklein@chromium.org> |
Reduce ref counting in SkPictureRecorder. This may be a small help to slimming paint: picture_overhead_draw 1.25us -> 1.22us 0.98x picture_overhead_nodraw 318ns -> 276ns 0.87x It certainly cannot hurt performance. BUG=chromium:470553 TBR=reed@google.com No public API changes. Review URL: https://codereview.chromium.org/1098183003
/external/skia/include/core/SkPicture.h
|
de8667b81f2fed2fbecba68e751756a48df5e0dd |
|
27-Apr-2015 |
jbroman <jbroman@chromium.org> |
Reduce sizeof(SkPicture::Analysis) from 24 bytes to 2 bytes. This saves "up to" 22 bytes per SkPicture. Due to alignment, this reduces sizeof(SkPicture): - from 88 to 72 bytes on Linux x64 - from 68 to 48 bytes on Android (with Chrome's build settings) It also somewhat simplifies the GPU veto logic. BUG=skia: [mtklein] No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1060863004
/external/skia/include/core/SkPicture.h
|
91df6c273a310479af7c1c97e38cb0752d401cc6 |
|
24-Apr-2015 |
robertphillips <robertphillips@google.com> |
Fix some lingering typos Review URL: https://codereview.chromium.org/1101293003
/external/skia/include/core/SkPicture.h
|
98b8485a4cc911420e20af2670d21a5478a06264 |
|
22-Apr-2015 |
mtklein <mtklein@chromium.org> |
O(1) SkPictureUtils::ApproxBytesUsed() Chrome wants to call this more often, and it's quite slow today. Seems like this could be clearer if SkPictureUtils::ApproxBytesUsed() were SkPicture::approxBytesUsed(). BUG=chromium:471873 Review URL: https://codereview.chromium.org/1090943004
/external/skia/include/core/SkPicture.h
|
9d911d5a9323bda1e4a77c46a0c28708dcc2ad38 |
|
17-Apr-2015 |
bungeman <bungeman@google.com> |
Remove filename from SkFontDescriptor. No one actually uses it, so remove it. Keep the string id for backward compatibility. TBR=reed@google.com This doesn't change any public API. Review URL: https://codereview.chromium.org/1057413005
/external/skia/include/core/SkPicture.h
|
25c40d25d75c8ee5d9632608ba09eb2c5fb765d2 |
|
10-Apr-2015 |
robertphillips <robertphillips@google.com> |
Add serialization of SkBitmapSource's new filterQuality member variable Missed this in https://codereview.chromium.org/1072603002/ (Add GM to repro crbug.com/472795) Review URL: https://codereview.chromium.org/1078113002
/external/skia/include/core/SkPicture.h
|
e35268ef4cdaa29600671cdf9d0ebb43b622d1a3 |
|
07-Apr-2015 |
mtklein <mtklein@chromium.org> |
Send SkPicture deletion message lazily. If no one has read the picture's unique ID, there's no point invalidating it. This is the same trick we pull with SkPixelRefs. Before: 26M 1 1.49µs 1.6µs 1.77µs 6.25µs 42% picture_overhead_draw 13M 32 742ns 749ns 756ns 823ns 2% picture_overhead_nodraw After: 26M 1 1.27µs 1.33µs 1.49µs 5.51µs 45% picture_overhead_draw 14M 43 677ns 680ns 681ns 701ns 1% picture_overhead_nodraw BUG=skia: Review URL: https://codereview.chromium.org/1061283002
/external/skia/include/core/SkPicture.h
|
4a22a433bfb972dcd96f76e3d3b0613c26d8fc86 |
|
18-Mar-2015 |
senorblanco <senorblanco@chromium.org> |
Bump picture version for uniqueID-less SkImageFilter. Remove writing of the uniqueID, and put reading behind a version check. BUG=skia:3559 Review URL: https://codereview.chromium.org/1010433003
/external/skia/include/core/SkPicture.h
|
8c92dc1dc281649f9e6b0ff534c25bc89dded3ea |
|
20-Feb-2015 |
halcanary <halcanary@google.com> |
Remove unused parameters to SkDocument::CreatePDF All image compression currently uses (losseless) Deflate, not Jpeg. All clients simply use SkDocument::CreatePDF(stream). SampleApp and SkLua still use SkDocument::CreatePDF(path). Review URL: https://codereview.chromium.org/935843007
/external/skia/include/core/SkPicture.h
|
9e447c08deb30b26a2101cb20b8a04aa230f09c4 |
|
15-Feb-2015 |
reed <reed@chromium.org> |
remove unneeded preroll BUG=skia: TBR=robertphilips Review URL: https://codereview.chromium.org/927443006
/external/skia/include/core/SkPicture.h
|
96a857ef5a40b3d0751ec9ebaaa96d9f20b82b21 |
|
25-Jan-2015 |
reed <reed@chromium.org> |
initial preroll api BUG=skia: Review URL: https://codereview.chromium.org/855473002
/external/skia/include/core/SkPicture.h
|
a1193e4b0e34a7e4e1bd33e9708d7341679f8321 |
|
21-Jan-2015 |
scroggo <scroggo@google.com> |
Make SkStream *not* ref counted. SkStream is a stateful object, so it does not make sense for it to have multiple owners. Make SkStream inherit directly from SkNoncopyable. Update methods which previously called SkStream::ref() (e.g. SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(), which required the existing owners to call SkStream::unref()) to take ownership of their SkStream parameters and delete when done (including on failure). Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some cases this means heap allocating streams that were previously stack allocated. Respect ownership rules of SkTypeface::CreateFromStream() and SkImageDecoder::buildTileIndex(). Update the comments for exceptional methods which do not affect the ownership of their SkStream parameters (e.g. SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be explicit about ownership. Remove test_stream_life, which tested that buildTileIndex() behaved correctly when SkStream was a ref counted object. The test does not make sense now that it is not. In SkPDFStream, remove the SkMemoryStream member. Instead of using it, create a new SkMemoryStream to pass to fDataStream (which is now an SkAutoTDelete). Make other pdf rasterizers behave like SkPDFDocumentToBitmap. SkPDFDocumentToBitmap delete the SkStream, so do the same in the following pdf rasterizers: SkPopplerRasterizePDF SkNativeRasterizePDF SkNoRasterizePDF Requires a change to Android, which currently treats SkStreams as ref counted objects. Review URL: https://codereview.chromium.org/849103004
/external/skia/include/core/SkPicture.h
|
783fe16b8ed1cd1cff34eacc33296874a32f293b |
|
07-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c Review URL: https://codereview.chromium.org/829983003
/external/skia/include/core/SkPicture.h
|
8ea6dabbb15ef276645b7a6ebab44a4a532ac990 |
|
07-Jan-2015 |
reed <reed@chromium.org> |
Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset #2 id:20001 of https://codereview.chromium.org/829983003/) Reason for revert: speculative revert to unblock DEPS roll Original issue's description: > Rename SkDrawPictureCallback to SkPicture::AbortCallback > > Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c TBR=reed@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/824013004
/external/skia/include/core/SkPicture.h
|
7ef197255deb4e2fa64c03c7130d56ddf164e83c |
|
06-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback Review URL: https://codereview.chromium.org/829983003
/external/skia/include/core/SkPicture.h
|
16c8f14cd481b78673a33450a1395958e3e10e62 |
|
22-Dec-2014 |
scroggo <scroggo@google.com> |
Remove last trace of SK_LEGACY_ENCODE_BITMAP Review URL: https://codereview.chromium.org/819173002
/external/skia/include/core/SkPicture.h
|
5e8b1688eeaa343848d255daee2b1fc26eb54f57 |
|
21-Dec-2014 |
reed <reed@chromium.org> |
remove dead SK_LEGACY_ENCODE_BITMAP flag BUG=skia: TBR= Review URL: https://codereview.chromium.org/820903002
/external/skia/include/core/SkPicture.h
|
b64e56941c9e88490ffdaf825ee25f7d830c6350 |
|
19-Dec-2014 |
scroggo <scroggo@google.com> |
Remove legacy Picture defines. No longer needed by Android. Review URL: https://codereview.chromium.org/788903006
/external/skia/include/core/SkPicture.h
|
895c43b28b27bb3124db3d32efd0c7219eb4a3cb |
|
11-Dec-2014 |
scroggo <scroggo@google.com> |
Replace EncodeBitmap with an interface. Gives more flexibility to the caller to decide whether to use the encoded data returned by refEncodedData(). Provides an implementation that supports the old version of SkPicture::serialize(). TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely BUG=skia:3190 Review URL: https://codereview.chromium.org/784643002
/external/skia/include/core/SkPicture.h
|
f3c78ccf5694d22d2e4a7061a80399a7e69b59db |
|
09-Dec-2014 |
junov <junov@chromium.org> |
Adding an option for pixelated rendering in SkPictureImageFilter BUG=skia:3209 Review URL: https://codereview.chromium.org/787073003
/external/skia/include/core/SkPicture.h
|
303044579913eacc177d4b28a674121725c565bb |
|
09-Dec-2014 |
scroggo <scroggo@google.com> |
Revert of Replace EncodeBitmap with an interface. (patchset #12 id:210001 of https://codereview.chromium.org/784643002/) Reason for revert: Failing serialization tasks in DM: http://build.chromium.org/p/client.skia/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/352/steps/dm/logs/stdio Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 > > Committed: https://skia.googlesource.com/skia/+/02b217f80b01a7dda8493422e5257c36a9ce8464 TBR=reed@google.com,rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Review URL: https://codereview.chromium.org/783393004
/external/skia/include/core/SkPicture.h
|
02b217f80b01a7dda8493422e5257c36a9ce8464 |
|
09-Dec-2014 |
scroggo <scroggo@google.com> |
Replace EncodeBitmap with an interface. Gives more flexibility to the caller to decide whether to use the encoded data returned by refEncodedData(). Provides an implementation that supports the old version of SkPicture::serialize(). TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely BUG=skia:3190 Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 Review URL: https://codereview.chromium.org/784643002
/external/skia/include/core/SkPicture.h
|
c0708cb7bcc22a6ad14fc3c2198d8e00d71c6754 |
|
09-Dec-2014 |
robertphillips <robertphillips@google.com> |
Revert of Replace EncodeBitmap with an interface. (patchset #11 id:190001 of https://codereview.chromium.org/784643002/) Reason for revert: Compilation is failing on some bots Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 TBR=reed@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Review URL: https://codereview.chromium.org/787833002
/external/skia/include/core/SkPicture.h
|
0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 |
|
09-Dec-2014 |
scroggo <scroggo@google.com> |
Replace EncodeBitmap with an interface. Gives more flexibility to the caller to decide whether to use the encoded data returned by refEncodedData(). Provides an implementation that supports the old version of SkPicture::serialize(). TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely BUG=skia:3190 Review URL: https://codereview.chromium.org/784643002
/external/skia/include/core/SkPicture.h
|
8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb |
|
04-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d. BUG=skia: TBR= Review URL: https://codereview.chromium.org/783493002
/external/skia/include/core/SkPicture.h
|
af641a1c10f176cb9617026d3cc93c117a85d13d |
|
03-Dec-2014 |
reed <reed@chromium.org> |
Revert "Change clear() to respect the clip" This reverts commit 3729469d6a12266037b697c2192768545e097ab0. BUG=skia: TBR= Review URL: https://codereview.chromium.org/778563002
/external/skia/include/core/SkPicture.h
|
5234075b1c6bcada4ad17ed5a83bfcb53df66b7f |
|
02-Dec-2014 |
Justin Novosad <junov@chromium.org> |
Adding a PictureResolution option to SkPictureImageFilter This change adds an option to SkPictureImageFilter to make it rasterize SkPicture in a resolution that matches the local coordinate space (equivalent to the record-time device space). BUG=skia:3176 R=reed@google.com, senorblanco@chromium.org Review URL: https://codereview.chromium.org/753073010
/external/skia/include/core/SkPicture.h
|
3729469d6a12266037b697c2192768545e097ab0 |
|
02-Dec-2014 |
reed <reed@google.com> |
Change clear() to respect the clip patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/772533004
/external/skia/include/core/SkPicture.h
|
88fd0fbcccea615f2d2cd61a121ac9e3185adfe4 |
|
01-Dec-2014 |
mtklein <mtklein@chromium.org> |
Bump min picture version. Chrome Stable is M39, which produces picture format v35: https://chromium.googlesource.com/skia/+/chrome/m39/include/core/SkPicture.h We don't need any code to deal with pictures older than v35. (When M40 goes stable, we can step up to v37, the current latest version.) BUG=skia: Review URL: https://codereview.chromium.org/770703002
/external/skia/include/core/SkPicture.h
|
1bdfd3f4f09e47364f76d3f08177b1ce844ac786 |
|
24-Nov-2014 |
reed <reed@google.com> |
option to return drawable from recording patch from issue 747033005 at patchset 80001 (http://crrev.com/747033005#ps80001) BUG=skia: Review URL: https://codereview.chromium.org/732653004
/external/skia/include/core/SkPicture.h
|
04c96950554b4e416755c5bc23022674518a6e8b |
|
24-Nov-2014 |
mtklein <mtklein@chromium.org> |
Remove Picture deletion listeners. Looks like we can just have ~SkPicture put the message on the bus directly. BUG=skia:3144 Review URL: https://codereview.chromium.org/751663002
/external/skia/include/core/SkPicture.h
|
735f548c51d3824724b621fa836ca828a195d307 |
|
24-Nov-2014 |
reed <reed@chromium.org> |
use int instead of size_t to match skia convention BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/753903002
/external/skia/include/core/SkPicture.h
|
19ac76753ec9f71a8eb0b58cf0450fd4e59f2a7c |
|
21-Nov-2014 |
mtklein <mtklein@chromium.org> |
SkPicture::SnapshotArray doesn't really stand to benefit from refcounting. BUG=skia: Review URL: https://codereview.chromium.org/748803005
/external/skia/include/core/SkPicture.h
|
04038eba9f4e09724031c69146699f9c6e15748e |
|
21-Nov-2014 |
mtklein <mtklein@chromium.org> |
public SkNVRefCnt<SnapshotArray> Should fix broken build. NOTRY=true TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/748143002
/external/skia/include/core/SkPicture.h
|
b7ee349f108040fbd5cb71d891d5b74a1843b0bc |
|
21-Nov-2014 |
mtklein <mtklein@chromium.org> |
SkData -> SkPicture::SnapshotArray Restores type safety with all the same features. (Also note, less code: 29 insertions, 50 deletions.) BUG=skia: Review URL: https://codereview.chromium.org/746553002
/external/skia/include/core/SkPicture.h
|
41d2c2e434d11e73f66c597913c29ea1fb3fa879 |
|
21-Nov-2014 |
reed <reed@google.com> |
simplify uniqueID code in picture patch from issue 750003002 at patchset 1 (http://crrev.com/750003002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/752573002
/external/skia/include/core/SkPicture.h
|
08d1fccf6eeec0a9fd5421e59e4d05daccf6e339 |
|
20-Nov-2014 |
mtklein <mtklein@chromium.org> |
Add SkNVRefCnt, prune down SkPicture's size SkNVRefCnt is a variant of SkRefCnt that's Not Virtual, so weighs 4 bytes instead of 8 or 16. There's only benefit to doing this if the deriving class does not otherwise need a vtable, e.g. SkPicture. I've stripped out some cruft from SkPicture, rearranged fields to pack tightly, and added compile asserts for the sizes of SkPicture, SkRecord, and SkVarAlloc. BUG=skia:3144 Review URL: https://codereview.chromium.org/741793002
/external/skia/include/core/SkPicture.h
|
158fcaa031d105dc999d9813fee8927db56a871c |
|
19-Nov-2014 |
tomhudson <tomhudson@chromium.org> |
Implement SkPicture::bytesUsed() for SkRecord backend BUG=chromium:230419 R=mtklein@google.com,reed@google.com Review URL: https://codereview.chromium.org/490253003
/external/skia/include/core/SkPicture.h
|
78e276889795454891cbba48ab11927968114953 |
|
19-Nov-2014 |
reed <reed@google.com> |
Allow pictures to have a full bounds This reverts commit 7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264. BUG=skia: Review URL: https://codereview.chromium.org/738083002
/external/skia/include/core/SkPicture.h
|
7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264 |
|
19-Nov-2014 |
reed <reed@google.com> |
Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/736583004/) Reason for revert: needed to update legacy width() helpers Original issue's description: > allow pictures to have a full bounds > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/722043005
/external/skia/include/core/SkPicture.h
|
7e76bff26e7c74902841ca4f607eb0b24a833a4a |
|
19-Nov-2014 |
reed <reed@google.com> |
allow pictures to have a full bounds BUG=skia: Review URL: https://codereview.chromium.org/736583004
/external/skia/include/core/SkPicture.h
|
6be2aa9a251bf6022570a03140f956655b3ef1da |
|
18-Nov-2014 |
reed <reed@google.com> |
wip for drawables Idea: 1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list. 2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc) 3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture. Review URL: https://codereview.chromium.org/727363003
/external/skia/include/core/SkPicture.h
|
c6ad9eefa0f8d0c2ede9884b446c65dde9b04dd1 |
|
17-Nov-2014 |
mtklein <mtklein@chromium.org> |
More SkPicture cleanup - move field declarations together and pack them a little tighter - get rid of fData - remove dead code in debugger, including unused SkPicturePlayback subclass There are now no more long-lived SkPictureData! (Really, there never were, but now we don't pretend to support them.) BUG=skia: No API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/725143002
/external/skia/include/core/SkPicture.h
|
82365915476caedc130d0e36012a1ce0c007c4ae |
|
12-Nov-2014 |
robertphillips <robertphillips@google.com> |
Rename GrAccelData to SkLayerInfo and move it to src/core Review URL: https://codereview.chromium.org/719133002
/external/skia/include/core/SkPicture.h
|
4e8e3421aa919a82eb1dd287fecbd079f5a320b4 |
|
12-Nov-2014 |
robertphillips <robertphillips@chromium.org> |
Move SkRecordComputeLayers and CollectLayers into SkRecordDraw.cpp Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering. Review URL: https://codereview.chromium.org/716913003
/external/skia/include/core/SkPicture.h
|
6beeb8f3cc323dabed0905920a336ed77aa5c46d |
|
10-Nov-2014 |
robertphillips <robertphillips@google.com> |
Small refactoring of layer discovery code This CL removes CollectLayers' reliance on having the top most picture (by removing the unused fPictureID member). This then allows making CollectLayers' API closer to that of SkRecordFillBounds in order to facilitate using them interchangeably. Review URL: https://codereview.chromium.org/714533002
/external/skia/include/core/SkPicture.h
|
f7007b023d03de0693a39cba45ecdcc63eb9950d |
|
04-Nov-2014 |
jvanverth <jvanverth@google.com> |
Enable distance field path rendering in Chrome. - Add stat tracking for df-renderable paths - Modify GPU rasterization veto to account for df-renderable paths - Remove #define hiding df paths from Chromium and Android BUG=skia:2935 Review URL: https://codereview.chromium.org/685113003
/external/skia/include/core/SkPicture.h
|
d8aa7b74c8ef0cb8ed3f6b03beb7ee5013624372 |
|
31-Oct-2014 |
robertphillips <robertphillips@google.com> |
Upgrade GPUOptimize This will be a bit hairy to review. The FillBounds and CollectLayers code has diverged significantly resulting in the rendering path seeing different bounds than the hoisting path. This CL merges the FillBounds changes into CollectLayers. A follow on CL will, hopefully, find a way to layer CollectLayers on top of FillBounds. The only code in CollectLayers that is different from FillBounds is bracketed by "LAYER HOISTING" comments. NOTREECHECKS=true Review URL: https://codereview.chromium.org/685263004
/external/skia/include/core/SkPicture.h
|
234f036b3e731e06e616c5291157d3bb4fbfdee2 |
|
23-Oct-2014 |
sugoi <sugoi@chromium.org> |
Adding an option to render only the shadow in SkDropShadowImageFilter This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here. BUG=skia: Review URL: https://codereview.chromium.org/646213004
/external/skia/include/core/SkPicture.h
|
8e12656096fceeed8b3cc4284d57dea04893b455 |
|
01-Oct-2014 |
mtklein <mtklein@chromium.org> |
Remove DEPRECATED_beginRecording(). This removes: 1) ability to record old pictures with SkPictureRecorder; 2) a couple tests specific to the old backend. The functionality of DEPRECATED_beginRecording() now lives in (private) SkPicture::Backport(), which is the only place we need it now. BUG=skia: TBR=reed@google.com Review URL: https://codereview.chromium.org/618303002
/external/skia/include/core/SkPicture.h
|
68cd2aa797f707a9847f8eba0758787cafd43e43 |
|
01-Oct-2014 |
robertphillips <robertphillips@google.com> |
Update GrRecordReplaceDraw to use SkTDynamicHash & add ReplaceDraw Having hoisted layers from different pictures invalidates the assumptions of the old GrReplacements object. This is fixed by switching to a SkTDynamicHash-based back-end. Sub-picture-layers also require that the replacement drawing occur for the sub-pictures too. The ReplaceDraw object is added to make this happen and limit the replacement lookup to saveLayer draw commands. This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/). BUG=skia:2315 Review URL: https://codereview.chromium.org/607763008
/external/skia/include/core/SkPicture.h
|
46616af01b412ea984a516fda1ed8ec08e689f29 |
|
30-Sep-2014 |
mtklein <mtklein@chromium.org> |
Strip old backend recording down to essentials Feature-wise, this removes: 1) BBH support; 2) peephole optimizations; 3) record-time text op specializations; 4) the guarantee that SkPaints are flattened. This deletes the optimizations GM, which only exists to test the peepholes of the old backend. SkRecord optimizations are unit tested, and if that ever fails we can think about adding another GM like this, but they're different enough we'd want to start from scratch anyway. We need to keep the code that plays back the specialized text ops around for a while for compatibility with existing .SKPs that have those ops recorded. BUG=skia: CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/617953002
/external/skia/include/core/SkPicture.h
|
5bc760a6a6a61ff462a204e0c051ad6147760223 |
|
30-Sep-2014 |
mtklein <mtklein@chromium.org> |
Remove support for SkPicture::clone(). This folds SK_SUPPORT_LEGACY_PICTURE_CLONE through as undefined. Chrome's not used clone() for a month or two, and we don't use it ourselves. Don't think Android ever did. CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot BUG=skia: R=reed@google.com, mtklein@google.com, robertphillips@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/620533002
/external/skia/include/core/SkPicture.h
|
c5e15a1afab2621e860a251c3fcf5917867ad49f |
|
29-Sep-2014 |
reed <reed@google.com> |
remove alphatype from colortable the owning bitmap is (already) responsible for knowing the alphatype BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/611093002
/external/skia/include/core/SkPicture.h
|
ee6631ef90fb5a9c80de6eacd37632f11367a088 |
|
29-Sep-2014 |
robertphillips <robertphillips@google.com> |
Update RecordReplaceDrawTest to generate and pass pictures This CL splits the unit test changes out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/). For various reasons GrRecordReplaceDraw now needs to take an SkPicture (rather than an SkRecord and a BBH). R=egdaniel@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/608823002
/external/skia/include/core/SkPicture.h
|
c5ba71d2e5cd426def66fa49dcf003e5b2c98dc7 |
|
04-Sep-2014 |
robertphillips <robertphillips@google.com> |
Change SkPicture::draw to playback R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/540963002
/external/skia/include/core/SkPicture.h
|
274b4ba6bde67bb8b6d8f1721ef5d6d4294f2aa8 |
|
04-Sep-2014 |
robertphillips <robertphillips@google.com> |
Switch Layer Hoisting over to SkRecord backend R=bsalomon@google.com TBR=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/540543002
/external/skia/include/core/SkPicture.h
|
2ed8a75c284fd8e74912de67691acf97bfb7a7b7 |
|
03-Sep-2014 |
robertphillips <robertphillips@google.com> |
Remove use of EXPERIMENTAL_getActiveOps from layer hoisting code This is getting in the way of switching to the SkRecord backend and is of questionable value. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/539693002
/external/skia/include/core/SkPicture.h
|
5ee785d9c7a39b9b8d3ae48b5da170dcef848e11 |
|
02-Sep-2014 |
djsollen <djsollen@google.com> |
Remove legacy (and also broken) SkPicture constructor. R=robertphillips@google.com, reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/532703004
/external/skia/include/core/SkPicture.h
|
98d709bc8d0761df8e0ad35e92c06e500f0be50d |
|
02-Sep-2014 |
robertphillips <robertphillips@google.com> |
Reorganize Layer Hoisting code With the new MultiPictureDraw API the GrContext will be performing the layer hoisting (instead of the SkGpuDevice). This CL being moving the layer hoisting functionality to GrLayerHoister rather then dumping it straight into GrContext. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/531733003
/external/skia/include/core/SkPicture.h
|
a8d7f0b13cd4c6d773fcf055fe17db75d260fa05 |
|
29-Aug-2014 |
robertphillips <robertphillips@google.com> |
Try out scalar picture sizes This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect. R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/513983002
/external/skia/include/core/SkPicture.h
|
d62833079fc36e28e65692f9a0c7dbdb124519c6 |
|
27-Aug-2014 |
robertphillips <robertphillips@google.com> |
Switch GPU Optimization code to SkRecord R=mtklein@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/504393002
/external/skia/include/core/SkPicture.h
|
533eb782edaa0b6fece6166d3001edf72ec39f11 |
|
27-Aug-2014 |
mtklein <mtklein@chromium.org> |
Convert BBH APIs to use SkRect. Still TODO: convert internals of SkTileGrid.cpp and SkRTree.cpp to work in floats too. NOTREECHECKS=true BUG=skia:1021 R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/511613002
/external/skia/include/core/SkPicture.h
|
b7425173f96e93b090787e2386ba5f022b6c2869 |
|
26-Aug-2014 |
fmalita <fmalita@chromium.org> |
SkTextBlob plumbing Add SkTextBlob serialization + drawTextBlob() overrides. R=mtklein@google.com, reed@google.com, robertphillips@google.com BUG=269080 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/499413002
/external/skia/include/core/SkPicture.h
|
53fecfb15d254397ab03032b888daa9d15c487b6 |
|
21-Aug-2014 |
mtklein <mtklein@chromium.org> |
Our SkPicture::Analysis visitors should recurse into nested pictures. BUG=skia: R=tomhudson@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/495793002
/external/skia/include/core/SkPicture.h
|
9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187 |
|
21-Aug-2014 |
reed <reed@google.com> |
Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc). Refactoring pattern: 1. guard the existing constructor(readbuffer) with the legacy build-flag 2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL). If you're a shader subclass 1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it. R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395603002
/external/skia/include/core/SkPicture.h
|
7b705bb17e09508e3761b54f59833b1ceb4ce9a6 |
|
20-Aug-2014 |
mtklein <mtklein@chromium.org> |
Always read .skp files and other serialized pictures into SkRecord. This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.) Also, deletes the old SkPicture::clone() path. return this or die. BUG=skia: R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481743003
/external/skia/include/core/SkPicture.h
|
c551d9fcae98ff7b9d56f315947e89a26632aeec |
|
20-Aug-2014 |
mtklein <mtklein@chromium.org> |
Implement SkPicture::hasText() for SkRecord backend. Plus, some small tweaks to the existing code surrounding it. Just proposals, will undo whatever you don't like. BUG=skia: R=mtklein@google.com, tomhudson@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/494683003
/external/skia/include/core/SkPicture.h
|
3a0f27916712bb3226874aeaa268e30f565880de |
|
20-Aug-2014 |
tomhudson <tomhudson@chromium.org> |
Move the code over using the same template type approach previously used for willPlayBackBitmaps in http://skbug.com/2702. Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test. BUG=skia:2700 R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/60c2a79cfa8ceebcbafc243407564dc71f5e3b4f Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/364823009
/external/skia/include/core/SkPicture.h
|
27dc17c2972421ce9c6331662fee6389b1e795a7 |
|
19-Aug-2014 |
Mike Klein <mtklein@google.com> |
Revert "Move the code over using the same template type approach previously used for willPlayBackBitmaps in http://skbug.com/2702." This reverts commit 60c2a79cfa8ceebcbafc243407564dc71f5e3b4f. BUG=skia: Review URL: https://codereview.chromium.org/481173003
/external/skia/include/core/SkPicture.h
|
60c2a79cfa8ceebcbafc243407564dc71f5e3b4f |
|
19-Aug-2014 |
tomhudson <tomhudson@chromium.org> |
Move the code over using the same template type approach previously used for willPlayBackBitmaps in http://skbug.com/2702. Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test. BUG=skia:2700 R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/364823009
/external/skia/include/core/SkPicture.h
|
750ae26745d261183001a78d24251f6392e96b27 |
|
18-Aug-2014 |
ajuma <ajuma@chromium.org> |
Expose API for whether an SkPicture contains text BUG=chromium:399728 R=reed@google.com, nduca@chromium.org Author: ajuma@chromium.org Review URL: https://codereview.chromium.org/478673002
/external/skia/include/core/SkPicture.h
|
5a246bb48708cfdbf5b63f8df7e2b09b3704cae4 |
|
15-Aug-2014 |
mtklein <mtklein@chromium.org> |
int SkPicture::approximateOpCount() NOTREECHECKS=true BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/470333002
/external/skia/include/core/SkPicture.h
|
3b6255493e458c6b2c1412af908581f0bf3f6b70 |
|
14-Aug-2014 |
djsollen <djsollen@google.com> |
Remove SkPaintOptionsAndroid Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b R=reed@google.com, mtklein@google.com, tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/447873003
/external/skia/include/core/SkPicture.h
|
c15e28a5224a3a0e977d6b2da44ce89302d01186 |
|
14-Aug-2014 |
bsalomon <bsalomon@google.com> |
Revert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium.org/447873003/) Reason for revert: Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio Original issue's description: > Remove SkPaintOptionsAndroid > > Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/473543004
/external/skia/include/core/SkPicture.h
|
f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b |
|
13-Aug-2014 |
djsollen <djsollen@google.com> |
Remove SkPaintOptionsAndroid R=reed@google.com, mtklein@google.com, tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/447873003
/external/skia/include/core/SkPicture.h
|
5ad6ee1b2ce54f8e59b9f5a337c688a98a4b0f2a |
|
11-Aug-2014 |
mtklein <mtklein@chromium.org> |
Plumbing for using a BBH in SkRecordDraw. For now this only creates a degenerate bounding box hierarchy where all ops just have maximal bounds. I will flesh out FillBounds in future CL(s). Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even looked at the diffs yet---so I've disabled those test modes for now. RTree seems fine, so that'll at least get us coverage for all this new plumbing. BUG=skia: R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/454123003
/external/skia/include/core/SkPicture.h
|
da7a944e293d27ec5c7be06b224921ae0058d35a |
|
06-Aug-2014 |
Derek Sollenberger <djsollen@google.com> |
Revert "Remove SkPaintOptionsAndroid" This reverts commit 27fb94999b8eec448423884e1d071e563c4c95d9. Review URL: https://codereview.chromium.org/450513002
/external/skia/include/core/SkPicture.h
|
27fb94999b8eec448423884e1d071e563c4c95d9 |
|
06-Aug-2014 |
Derek Sollenberger <djsollen@google.com> |
Remove SkPaintOptionsAndroid Review URL: https://codereview.chromium.org/447873003
/external/skia/include/core/SkPicture.h
|
55b6d8be997a447ef9ce0f029697677a940bfc24 |
|
30-Jul-2014 |
senorblanco <senorblanco@chromium.org> |
Implement a persistent uniqueID-based cache for SkImageFilter. Add a unique ID to SkImageFilter, and use it as part of a persistent cache of image-filtered results. This is used for caching frame-to-frame coherent filters. We also keep track of which filter subtrees do not reference the src input, and use a GenID of zero for the src input in that case. That way, subtrees which are not dependent on the filter input can be cached independently of it. This gives approximately a 4X speedup on letmespellitoutforyou.com/samples/svg/filter_terrain.svg on Z620 and Nexus10. The cache key consists of the uniqueID of the filter, the clip bounds, the CTM and the genID of the input bitmap. Since this does not yet handle the case where the input primitives (and part of the resulting filter tree) are unchanged, we have to keep around the external cache for that painting case. When the work to cache unchanging input primitives is done, the old cache can be removed, and the new UniqueIDCache will be renamed to Cache. R=bsalomon@google.com, mtklein@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/414483003
/external/skia/include/core/SkPicture.h
|
d771f6bc273457bc7aa95938ac326dfbbf876e1a |
|
22-Jul-2014 |
robertphillips <robertphillips@google.com> |
Add auto purging for SkPicture-related Ganesh resources (esp. layers) This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/408923002
/external/skia/include/core/SkPicture.h
|
cfaeec446d06058cacef068b09f58ae2c78338fa |
|
13-Jul-2014 |
Robert Phillips <robertphillips@google.com> |
Remove Skia's use of the default SkPicture constructor and multi-clone This cannot be landed until (Chrome: Switch to one-at-a-time SkPicture::clone interface - https://codereview.chromium.org/380323002/) has landed. R=mtklein@google.com TBR=reed@google.com Review URL: https://codereview.chromium.org/388833003
/external/skia/include/core/SkPicture.h
|
dd528967fc3eea54c8d10937b0100192d0722f4e |
|
13-Jul-2014 |
robertphillips <robertphillips@google.com> |
Remove SkPicture copy constructor Given where we're heading with SkPicture why would you need to make a copy? R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/381133002
/external/skia/include/core/SkPicture.h
|
c870d494dd0dc88f3f4155a0d6257a1be8280880 |
|
11-Jul-2014 |
scroggo <scroggo@google.com> |
Use SkShader's localMat for SkLocalMatrixShader. Instead of setting SkShader::fLocalMatrix to Identity and storing a separate SkMatrix inside SkLocalMatrixShader, reuse SkShader::fLocalMatrix. R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/386693003
/external/skia/include/core/SkPicture.h
|
ffc75efc1a4c231286c773ff090ec84fc16e9422 |
|
11-Jul-2014 |
robertphillips <robertphillips@google.com> |
Revert of Add alternate SkPicture::clone (https://codereview.chromium.org/381193002/) Reason for revert: Going to try to just remove the many-at-once clone interface Original issue's description: > Add alternate SkPicture::clone > > This adds an alternate version of SkPicture::clone for two reasons: > > 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor) > > 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely. > > Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/) > > Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9 R=mtklein@google.com, reed@google.com TBR=mtklein@google.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/386933004
/external/skia/include/core/SkPicture.h
|
e372e78223a8ce916d276d6e0420d552fb0267e9 |
|
10-Jul-2014 |
robertphillips <robertphillips@google.com> |
Add alternate SkPicture::clone This adds an alternate version of SkPicture::clone for two reasons: 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor) 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely. Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/) R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/381193002
/external/skia/include/core/SkPicture.h
|
6142609b22814283210f79d698182b651a93136c |
|
10-Jul-2014 |
robertphillips <robertphillips@google.com> |
Cleanup SkPicture* classes a bit This is an attempt to reduce the number of friends the various SkPicture* classes have. Probably the only controversial part is making getBitmap, getPath, getPicture and getPaint public on SkPictureData (and adding a new initIterator entry point). R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/384753004
/external/skia/include/core/SkPicture.h
|
c26d991bf2d85bb1843a21b0a4f861212b0eaced |
|
10-Jul-2014 |
robertphillips <robertphillips@google.com> |
Split SkPictureReplacementPlayback out of SkPicturePlayback R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/383733002
/external/skia/include/core/SkPicture.h
|
004522f91ceb7f9ba11be91b4f2eb018853a67ec |
|
08-Jul-2014 |
Robert Phillips <robertphillips@google.com> |
Back off from SkPicture API hardening a bit Sigh - Chromium still relies on the old clone functionality TBR=reed@google.com Review URL: https://codereview.chromium.org/371273006
/external/skia/include/core/SkPicture.h
|
6daadc7481b11655c77569eb0720fe037027cb30 |
|
08-Jul-2014 |
robertphillips <robertphillips@google.com> |
Harden SkPicture interface a bit With the removal of SkTimedPicture we can now make more of SkPicture private. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/377833007
/external/skia/include/core/SkPicture.h
|
3afef1f75f710b8f183113cdc5188416f7d01f28 |
|
08-Jul-2014 |
robertphillips <robertphillips@google.com> |
Clean up a bit after SkPictureData/SkPicturePlayback split This CL begins setting up the SkPicturePlayback split by simplifying the class and componentizing it a bit. It: fuses SkPictureData::OperationList into SkPicture::OperationList adds a handleOp method to SkPicturePlayback that can be reused by derived classes removes a couple debugging tools (ENABLE_TIME_DRAW & SPEW_CLIP_SKIPPING) R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/378703002
/external/skia/include/core/SkPicture.h
|
ce4dd3de38cd7c29bf5b9d8a8efb55c08ec9be47 |
|
07-Jul-2014 |
robertphillips <robertphillips@google.com> |
Split SkPicturePlayback out of SkPictureData This splits the playback functionality out of SkPictureData. The old SkPictureData::draw method is pulled out along with its supporting functions as verbatim as possible. Some follow on CLs will be required to: re-enable profiling in the debugger (and remove the vestiges of SkTimedPicture) re-enable display of command offsets in the picture (this should probably wait until we've switched to SkRecord though) Clean up CachedOperationList (maybe fuse with SkPicture::OperationList) Split SkPicturePlayback into a base class and two derived classes Implement parallel version of GatherGPUInfo for SkRecord Landing this is blocked on removing Android's use of the abortPlayback entry point. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/377623002
/external/skia/include/core/SkPicture.h
|
d930511ee73bf0ddc8bdf570ec23a17dd3e19709 |
|
05-Jul-2014 |
tomhudson <tomhudson@chromium.org> |
Linear-time implementation of willPlaybackBitmaps(), computed & cached on construction in SkPicture. Unit test. Template trickery thanks to mtklein@. BUG=skia:2702 R=mtklein@google.com, reed@android.com, reed@google.com, tomhudson@google.com, mtklein, reed Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/366443002
/external/skia/include/core/SkPicture.h
|
db539905bb3af7bd05839a7d2558e97d5cb51ca2 |
|
01-Jul-2014 |
robertphillips <robertphillips@google.com> |
Rename SkPicturePlayback to SkPictureData This is in preparation for splitting the playback portion of the new SkPictureData class into a new SkPicturePlayback class. R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/362773002
/external/skia/include/core/SkPicture.h
|
5f6102d07982043542343ff0a6c67b1319ac9fc7 |
|
30-Jun-2014 |
Florin Malita <fmalita@chromium.org> |
SaveFlags be-gone Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/340403003
/external/skia/include/core/SkPicture.h
|
d3e474e20c6f0f24ddb6b2643e92975d60190daa |
|
27-Jun-2014 |
mtklein <mtklein@chromium.org> |
Deprecate SkPicture::clone(). Chrome will need -DSK_SUPPORT_LEGACY_PICTURE_CLONE. This removes the modes from our tools that use clone(). No bots run these. DM used clone() in a way that we can just share the picture now. I plan to bring back the ability to test multithreaded picture rendering soon. BUG=skia:2378 R=robertphillips@google.com, mtklein@google.com, bsalomon@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/338633011
/external/skia/include/core/SkPicture.h
|
c11530ea73b2a2fcb431df0f5c1887d08ac9113c |
|
24-Jun-2014 |
Mike Klein <mtklein@google.com> |
Tick off some TODOs: - support fRecord in copy constructor - support SkDrawPictureCallback Moved SkDrawPictureCallback to its own header so SkRecordDraw can include it without pulling in all of SkPicture. Adding an SkAutoSaveRestore to SkRecordDraw was the easiest way to match the balance guarantees of the callback, and probably not a bad idea in general. Updated its tests. BUG=skia: R=robertphillips@google.com Review URL: https://codereview.chromium.org/349973008
/external/skia/include/core/SkPicture.h
|
6fc763e3c2b1e539510cb18ece8b97e183099ab1 |
|
23-Jun-2014 |
Mike Klein <mtklein@google.com> |
No one uses SkPicture::swap. BUG=skia: R=robertphillips@google.com Review URL: https://codereview.chromium.org/349313004
/external/skia/include/core/SkPicture.h
|
744fb7313f31069e9eceeca4c0ff33dbe2fe1737 |
|
23-Jun-2014 |
Mike Klein <mtklein@google.com> |
Enable basic drawing with SkRecord-based pictures. I've tagged all the functions in SkPicture.cpp is // fRecord TODO or // fRecord OK, depending on whether or not they're totally broken when used from an SkRecord-based picture. Obviously next steps are to eliminate all the TODOs, then clean up the notes. I converted SkPicture over to smart pointers too. It's particularly helpful that the smart pointers initialize to NULL by default. For now I've got all the SkRecord-based code jammed in at the bottom of the file. I figure it'll help me keep things straight for a bit, then we can rearrange later. BUG=skia: R=robertphillips@google.com Review URL: https://codereview.chromium.org/333823007
/external/skia/include/core/SkPicture.h
|
02830f0448ce1af077cedc552e913f464834e455 |
|
12-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag Chromium/Blink should no longer need this flag after: Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/322123002/ Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/326953002/ R=mtklein@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/328343002
/external/skia/include/core/SkPicture.h
|
e26e65e8f831f7a5626c92d11bbb8c2cec1f70de |
|
12-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove SkPicture pointer from SkPicturePlayback This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/334493002
/external/skia/include/core/SkPicture.h
|
0bdbea75ff1a6f3c313c18cab0139728967cb93e |
|
11-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove picture pre-allocation from SkPictureRecorder This CL improves the separation of the SkPicture and SkPictureRecord classes. It delays creation of the SkPicture (in SkPictureRecorder) until recording is actually completed. To accomplish this the SkRecord-derived classes now get SkPathHeap and SkPictureContentInfo members that are absorbed by the SkPicture when it is constructed. As an ancillary change, this CL also moves the SkPictureContentInfo object from SkPicture to SkPicturePlayback. This is intended to centralize all the data in the SkPicturePlayback object. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324293004
/external/skia/include/core/SkPicture.h
|
6de27127c4d50ef90b5435aefaeef47fa84b819d |
|
10-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove unused 'deepCopy' parameter This is split out of https://codereview.chromium.org/316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor. R=scroggo@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324093003
/external/skia/include/core/SkPicture.h
|
9f1c241e0d8a756fca1ec2dacb565eec83166d5f |
|
09-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003
/external/skia/include/core/SkPicture.h
|
643b8bd6617e333f7a970a57ad9166f3d6675d1a |
|
08-Jun-2014 |
robertphillips <robertphillips@google.com> |
First pass at splitting out SkPictureRecord from SkPicture This patch begins the process of splitting apart SkPicture, SkPicturePlayback and SkPictureRecord. This is still a bit messy. In a follow up CL I hope to delay the creation of SkPictureRecorder's SkPicture until endRecording time. R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/318763004
/external/skia/include/core/SkPicture.h
|
9b14f26d0f3a974f3dd626c8354e1db1cfcd322f |
|
04-Jun-2014 |
robertphillips <robertphillips@google.com> |
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004
/external/skia/include/core/SkPicture.h
|
dcf9ab14a194be0cbea896e1dc44a2a04106a38b |
|
03-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove legacy picture recording This is unblocked now that Android no longer uses the old interface. This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio. R=bsalomon@google.com, reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613002
/external/skia/include/core/SkPicture.h
|
a1ff26a64a0cfc337a321e6e923684bfdcadc2ec |
|
30-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a way for the gpu veto to report back the reason why it said no BUG=2334 R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/301423002 git-svn-id: http://skia.googlecode.com/svn/trunk@15012 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
968edcafa61442dc4f7f8ed8f89523d0f353e9fb |
|
23-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
stop calling SkBitmap::flatten BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/295793002 git-svn-id: http://skia.googlecode.com/svn/trunk@14867 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
83f23d87f1d67e6e73873e1ef7cda621c43703a0 |
|
22-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove unused (by clients) SkUnitMapper This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98. TBR=scroggo Author: reed@google.com Review URL: https://codereview.chromium.org/288313009 git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
3339ac54a5ed75f2872ab16e9052a8b9ff3564bf |
|
22-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/) Reason for revert: required blink change failed to land Original issue's description: > Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) > > This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14830 R=scroggo@google.com, reed@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/296823008 git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
4b8f8022550daa7458ed3de207d1300917d4a8cb |
|
21-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/288343009 git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
2ee3c2ce6499cb7ce15b59420dd4514ad01d0318 |
|
19-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add choke point for performing a fake endRecording My goal here was to add a single location where we could patch up the created PicturePlayback. Unfortunately, the complexity of the recording process (e.g., the BBH) makes this quite complex. I will investigate altering the behavior of SkPicturePlayback to account for a potentially unbalanced set of saves/saveLayers. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/283333007 git-svn-id: http://skia.googlecode.com/svn/trunk@14773 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e2b193ca5c76f01f8e12b4a92e9bd6ccb3ed4280 |
|
16-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) Reason for revert: does not address all legacy callsites in chrome. e.g. [13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’ [13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL)); Original issue's description: > remove unused (by clients) SkUnitMapper > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14761 R=robertphillips@google.com, scroggo@google.com, george@mozilla.com TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/287063009 git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ee0cac336c6a3a357ae3cb18be8ef4b3cb5edddb |
|
16-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove unused (by clients) SkUnitMapper BUG=skia: R=robertphillips@google.com, scroggo@google.com, george@mozilla.com Author: reed@google.com Review URL: https://codereview.chromium.org/283273002 git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
beb1af2f34b5c538fc08d849b132355160b4c93f |
|
07-May-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First pass at pre-rendering saveLayers for GPU https://codereview.chromium.org/261663003/ git-svn-id: http://skia.googlecode.com/svn/trunk@14632 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
cc9dbfb1d21098c267d8b398b51a1db95e5099b5 |
|
25-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14372 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e2cb12a82ad924f7b134a9459b190213485c6a50 |
|
24-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First pass at GPU veto As a short term solution this CL collects information during the recording process for use in suitableForGpuRasterization. BUG=366495 R=bsalomon@google.com, reed@google.com, alokp@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/251533004 git-svn-id: http://skia.googlecode.com/svn/trunk@14368 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
76a3b2abd02841c4ae786ac4cf59c3a51c545f73 |
|
24-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove support for inheriting the paint color from SkColorShader BUG=skia:2453 R=reed@google.com, mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/248033003 git-svn-id: http://skia.googlecode.com/svn/trunk@14355 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8f831f262f5e57665587cb3033860eea39fe1621 |
|
24-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
First step in pulling SkPicturePlayback & SkPictureRecord out of SkPicture This CL begins the process of making SkPicturePlayback & SkPictureRecord independent of SkPicture. It just moves the PathHeap into SkPicture to get a feel for where all this is going to lead. Some items of note: SkTimedPicture (debugger/QT) should wind up being just an SkPicturePlayback-derived object. All the flattening & unflattening should migrate out of SkPicturePlayback and into SkPicture. SkPicture::initForPlayback should eventually become something just SkPictureRecorder::endRecording calls. SkPicture is passed into SkPicturePlayback's & SkPictureRecord's constructors. SkPicturePlayback only holds onto a "const SkPicture*". The SkPicturePlayback:: CreateFromStream & CreateFromBuffer methods pass a non-const SkPicture* down the call stack. BUG=skia:2315 R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/249453002 git-svn-id: http://skia.googlecode.com/svn/trunk@14341 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
aec143824c9be4e4af6e2cb7cce3d2d2268c0b15 |
|
22-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add asADash entry point into SkPathEffect to allow extracting Dash info from PathEffects BUG=skia: R=bsalomon@google.com, reed@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/212103010 git-svn-id: http://skia.googlecode.com/svn/trunk@14297 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
44d83c1e81b0555efa94f78e2a53b862208cdd06 |
|
21-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add flipped gradient branch to two point conical gradient BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14235 R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/227623004 git-svn-id: http://skia.googlecode.com/svn/trunk@14271 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
770963f23f4fc313db0fa3bac18b1b8aafb55f17 |
|
18-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Staging for cleanup of SkPicture-related headers https://codereview.chromium.org/243173002 git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
60bd7519a9db4ddddd95e490f93165e5676f90f5 |
|
18-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14252 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5fb2ce38b3dcb8e60e9e112df23c9d42456d7069 |
|
18-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Staged removal of SkPicture-derived classes This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted). The only interesting bits are in SkPicture* and Sk*Picture.* R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/238273012 git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
7518ff2d7e2a3f63b8d60f8ccacd7ca5e6b525b7 |
|
17-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Add flipped gradient branch to two point conical gradient (https://codereview.chromium.org/227623004/) Reason for revert: Breaking all CompareGMs Original issue's description: > Add flipped gradient branch to two point conical gradient > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14235 R=bsalomon@google.com, mtklein@google.com TBR=bsalomon@google.com, mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/239993006 git-svn-id: http://skia.googlecode.com/svn/trunk@14236 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
cf41935735544a412ea66afd31470b418a586213 |
|
17-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add flipped gradient branch to two point conical gradient BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/227623004 git-svn-id: http://skia.googlecode.com/svn/trunk@14235 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8121c6cb70d89552455f1a03df4dc98ea3e9af71 |
|
16-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://codereview.chromium.org/237673017/) due to compiler complaints git-svn-id: http://skia.googlecode.com/svn/trunk@14226 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
a387db29051d106dddc4bc2a34f46360f75d05de |
|
16-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling https://codereview.chromium.org/237673017/ git-svn-id: http://skia.googlecode.com/svn/trunk@14225 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
d393b17cf3427bd6f6255f8670067d9aa529e409 |
|
16-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag from the public API (more work needs to be done in Blink & Chrome). In the new world the only way to set this flag (and thus instantiate an SkPicture-derived class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and do away with the SkPicture-derived classes. BUG=skia:2315 R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/239703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
85faf50875fcf6008880a98aaa05d12ae8dad343 |
|
16-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove legacy filter-flags, and store FilterLevel directly BUG=skia: R=robertphillips@google.com, humper@google.com, jvanverth@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/239393002 git-svn-id: http://skia.googlecode.com/svn/trunk@14217 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5199701acbf386cdc315de440eeafcc10fd0cdc3 |
|
14-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14172 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
84b18c7e3e042bf206e1ace3d1b6ea5bb929fe51 |
|
13-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
split SkPictureRecorder out of SkPicture https://codereview.chromium.org/214953003/ git-svn-id: http://skia.googlecode.com/svn/trunk@14171 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e3beb6bd7de7fa211681abbb0be58e80b19885e0 |
|
07-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
SkNonCopyable should be used with private inheritance. This is mostly s/public SkNoncopyable/SkNoncopyable/g. Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor. I added SkNoncopyableVirtual to make them work as intended. Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/226183018 git-svn-id: http://skia.googlecode.com/svn/trunk@14081 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
2b4e370a2fe00168838e43f5a78ccc3b371609f5 |
|
07-Apr-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Convert SkPicture's generation ID to a unique ID This CL addresses linger code review comments on r14037 (Add generation ID to SkPicture https://codereview.chromium.org/222683002/) R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/225283014 git-svn-id: http://skia.googlecode.com/svn/trunk@14079 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
a9157727f7ac11dffe5780a0cfdb6d2bbb179373 |
|
03-Apr-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@14039 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
d5500886a29a20733c559c0167a6ae9946704de2 |
|
03-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add generation ID to SkPicture https://codereview.chromium.org/222683002/ git-svn-id: http://skia.googlecode.com/svn/trunk@14037 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
75cf29be4d3bcda4ce4118facec574242d4cc106 |
|
24-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add new experimental API to SkPicture to get "id" of current op When gathering information about a picture (in the new SkDevice::EXPERIMENTAL_optimize entry point) it is necessary to be able to correlate the gathered information with the command in the SkPicture (so the information can later be combined with the similarly indexed information from the BBH). This entry point exposes that information to friend classes. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/206853003 git-svn-id: http://skia.googlecode.com/svn/trunk@13919 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
eb9547c1d6a7bcc02778a7d26b7d05283c4074fa |
|
19-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
stub for ganesh veto BUG=skia: R=bsalomon@google.com, nduca@chromium.org Author: humper@google.com Review URL: https://codereview.chromium.org/197803002 git-svn-id: http://skia.googlecode.com/svn/trunk@13866 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
70512af9dd7a6b2c0a3f5971fd6e103dc577a400 |
|
18-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a means of extracting active operations from SkPicture For the "pull forward" task I will be comparing the two cases: analyze the whole skp and use the BBH information analyze only the active portion of the skp In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it. Committed: http://code.google.com/p/skia/source/detail?r=13836 R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/195793010 git-svn-id: http://skia.googlecode.com/svn/trunk@13853 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
14bdd527eebb3616227ef37a9ed23bc450a8bb5a |
|
18-Mar-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of r13836 due to Chromium cc_unittests failures https://codereview.chromium.org/203333005/ git-svn-id: http://skia.googlecode.com/svn/trunk@13850 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ecb745dba75dde72e5edde72e4b309120e66033b |
|
17-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a means of extracting active operations from SkPicture For the "pull forward" task I will be comparing the two cases: analyze the whole skp and use the BBH information analyze only the active portion of the skp In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it. R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/195793010 git-svn-id: http://skia.googlecode.com/svn/trunk@13836 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1c556dba153f880cad1f3e2996a320d61435f3c2 |
|
17-Mar-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r13831 (Add a means of extracting active operations from SkPicture) due to Mac compiler issue git-svn-id: http://skia.googlecode.com/svn/trunk@13832 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
0b23f9e15f87363249cb66db2dd9918bc42d72ab |
|
17-Mar-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add a means of extracting active operations from SkPicture https://codereview.chromium.org/195793010/ git-svn-id: http://skia.googlecode.com/svn/trunk@13831 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
eb849e5fd10cbe00cbc31307ba97fd9efca0b41b |
|
17-Mar-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13825 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
145d1c0fdcef63991d7f910cc067a653a8aa2c4c |
|
16-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Proposed SkCanvas API for preLoading textures to VRAM v2.0 This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)). Committed: http://code.google.com/p/skia/source/detail?r=13810 R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197123003 git-svn-id: http://skia.googlecode.com/svn/trunk@13822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5ed01d1f8fa3fa38105c252929f02dd7603271e3 |
|
14-Mar-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0) git-svn-id: http://skia.googlecode.com/svn/trunk@13811 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1ab85c8719ef46a8f2de9912b3f84f387bddf0d1 |
|
14-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Proposed SkCanvas API for preLoading textures to VRAM v2.0 This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)). R=reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197123003 git-svn-id: http://skia.googlecode.com/svn/trunk@13810 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
9e5f85e89d03a850d435fc951e74e9861a0c1bdd |
|
12-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixing SkPicture serialization Fixed a few issues while attempting to use the new serialization path for SkPicture inside a fuzzer: - SkReadBuffer and SkValidatingReadBuffer both had a fReader member instead of sharing the same member, which leads to problems if a base class function is used - In SkPicture, a header is now written as a single chunk of data, so it also has to be read as a single chunk of data - In the SkPicturePlayback destructor, a bad deserialization would lead to a crash if we don't safely unref fOpData - Also in SkPicturePlayback, if we only use a ReadBuffer for the whole deserialization, additional tags must be added to parseBufferTag() - SkValidatingReadBuffer::readBitmap() was broken, but this path wasn't usen't since the only use case for SkValidatingReadBuffer is currently image filters and bitmaps are unflattened as part of the deserialization of SkBitmapSource - SkPictureImageFilter was not deserializable. Added it to SkGlobalInitialization* - Added a test that exercises the SkPicture serialization / deserialization code BUG=skia: R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, robertphillips@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/195223003 git-svn-id: http://skia.googlecode.com/svn/trunk@13764 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
dcb8e54ffdc9194744c0ec839969102bd0f582c6 |
|
05-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This CL is motivated by the desire to make the skpinfo tool work a bit better. The main concern is that the assumptions made w.r.t. written bytes may not be valid for all SkWStream sub-classes. R=bungeman@gmail.com, bungeman@google.com, reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/182733008 git-svn-id: http://skia.googlecode.com/svn/trunk@13673 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e494dbdec36f0ffa4affeac1c3f405b58ac41220 |
|
04-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
The motivation for this CL is to de-clutter SkPicture's beginRecording method. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/186813003 git-svn-id: http://skia.googlecode.com/svn/trunk@13658 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ade9a3485e78d471f5f0902e9e50a2ec74c88e76 |
|
04-Mar-2014 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@13651 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
6f4fb0f1296422a44d5d0dac155d82595dc5ebec |
|
03-Mar-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Generating the 1M skps frequently yields truncated skps. This tool is intended to help automate weeding these out. Please see skbug:1057 rmistry for tools, gyp mtklein for src\core & include\core BUG=skia:1057 R=rmistry@google.com, mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/176863004 git-svn-id: http://skia.googlecode.com/svn/trunk@13643 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
210ae2a42613b9048e8e8c4096c5bf4fe2ddf838 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Culling API *** SKP format breaking change *** Adding a couple of culling primitives: pushCull(SkRect) & popCull(). These are currently only plumbed for SKP playback quickreject. At record time, we perform a couple of optimizations to trim down the number of redundant culls: * collapse empty pushCull/popCull pairs * skip pushCull/popCull pairs nested within an identical cull rect Things still missing/to consider: * use an inlineable, simplified quickreject (Mike's old prototype) * debugger visualization for cull boxes * BBH integration: the initial prototype had some minimal BBH support, but since the optimizations required expensive rewinds and culling is expected to be a BBH alternative, it got dropped. R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/138013009 git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e8d9614cd187c7a2aa474f9ca7aac208ded71400 |
|
25-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This is intended to make it easier for us to be backwards compatible. R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/178383003 git-svn-id: http://skia.googlecode.com/svn/trunk@13575 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
d281c9240c7bd51ce0c29c6d4de27819e359e1d1 |
|
18-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add link to how to generate new SKPs when increasing the picture version BUG=skia:2041 R=robertphillips@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/170923003 git-svn-id: http://skia.googlecode.com/svn/trunk@13493 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5e0995e4b36178e1e4465a9f50114ed39f038c27 |
|
07-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/153583007/) Reason for revert: New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22 Original issue's description: > Revert "Serialization of SkPictureImageFilter" > > This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. > > Revert "Sanitizing source files in Housekeeper-Nightly" > > This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. > > TBR=robertphillips@google.com,sugoi@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13356 R=robertphillips@google.com, sugoi@google.com, fmalita@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, fmalita@google.com, robertphillips@google.com, sugoi@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/143163005 git-svn-id: http://skia.googlecode.com/svn/trunk@13357 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
7713c38dc0182c8f6a685dace5101c49301de00d |
|
07-Feb-2014 |
fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Serialization of SkPictureImageFilter" This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. Revert "Sanitizing source files in Housekeeper-Nightly" This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. TBR=robertphillips@google.com,sugoi@google.com Review URL: https://codereview.chromium.org/153583007 git-svn-id: http://skia.googlecode.com/svn/trunk@13356 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
4f6318d2e64c96fba955ea9154829aee37e155b8 |
|
07-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Serialization of SkPictureImageFilter BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13347 R=senorblanco@google.com, reed@google.com, mtklein@google.com, sugoi@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/138063005 git-svn-id: http://skia.googlecode.com/svn/trunk@13354 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8b4799a98b05d626432b11115b5c2f0e0bb1772d |
|
06-Feb-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of r13347 (Serialization of SkPictureImageFilter - https://codereview.chromium.org/138063005) due to bump in skp file format git-svn-id: http://skia.googlecode.com/svn/trunk@13348 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
670b98ea5df48daef5d23e2bb7570d408207c333 |
|
06-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Serialization of SkPictureImageFilter BUG=skia: R=senorblanco@google.com, reed@google.com, mtklein@google.com, sugoi@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/138063005 git-svn-id: http://skia.googlecode.com/svn/trunk@13347 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8b0e8ac5f582de80356019406e2975079bf0829d |
|
30-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactor read and write buffers. Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
fed2ab648341ec153ad2af746a31d368963171e4 |
|
23-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
No deduping dictionaries for matrices and regions. There's little benefit to deduping matrices and regions: they're infrequently used, and doubly infrequently reused. Their use-weighted byte cost is tiny. There is some downside to deduping matrices and regions. Even when they're not used, we prepare dictionaries for deduping them for every picture. Each of these dictionaries costs 160 bytes, so two unused dictionaries make a big chunk of the ~1100 bytes it takes to allocate an SkPictureRecord. (~330 come from parent class SkCanvas, 768 from SkPictureRecord itself, here reduced to 448). One side benefit of not deduping these guys is that the change weighs -140 lines of code. It may go without saying, but this breaks the picture format. Testing: out/Debug/tests && out/Debug/dm (which runs all picture modes by default) BUG=skia:1850 R=reed@google.com, bensong@google.com, robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/143883006 git-svn-id: http://skia.googlecode.com/svn/trunk@13149 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
672588b684d484dce6ae251e9e163e4a46924322 |
|
08-Jan-2014 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change offset to xy for pixelref subsetting BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/105893012 git-svn-id: http://skia.googlecode.com/svn/trunk@12958 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e132f5031fb700e34af1ea08b575b2c774393047 |
|
13-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bump picture format to 17 to go with PixelRef Info CL BUG= Review URL: https://codereview.chromium.org/106763004 git-svn-id: http://skia.googlecode.com/svn/trunk@12678 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
0daa1adb03b4b1fc11d854cb7754416ac05a31e8 |
|
13-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r12665 & r12666 (Remove duplicate impl for SkImageInfo flattening) due to Chromium/Blink compilation errors https://codereview.chromium.org/112603003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12667 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
93b40594b78ab40170b5a7fa0811fa95ab8fc30f |
|
13-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remvoe duplicate impl for SkImageInfo flattening Add onNewLockPixels This reverts commit bb8eff6a70c52b7644391cfd4f4d21bf7294a6bf. BUG= Review URL: https://codereview.chromium.org/111323005 git-svn-id: http://skia.googlecode.com/svn/trunk@12665 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
398337b3a5d66a7db5d36a3b5182e4407e2292f7 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "remvoe duplicate impl for SkImageInfo flattening" Reason: breaks chrome_mac_tests which still have non-imageinfo constructors This reverts commit a06b8cf60b39bda93e9ef1a73579007b2b930d29. BUG= Review URL: https://codereview.chromium.org/103033005 git-svn-id: http://skia.googlecode.com/svn/trunk@12631 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
a0d183d89160e31962e99475abe8a77c30626a40 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert of https://codereview.chromium.org/108773003/" This reverts commit 947e6a3142af66b750f1247ef933b11ed8455dd4. BUG= Review URL: https://codereview.chromium.org/112963003 git-svn-id: http://skia.googlecode.com/svn/trunk@12630 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ff9c6c92e5f962b34f7421e67ac112f81a018bd3 |
|
11-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of https://codereview.chromium.org/108773003/ Reason for revert: breaks chrome-mac-tests TBR= NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/113193003 git-svn-id: http://skia.googlecode.com/svn/trunk@12629 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
f3aead2829fa515f790631ee65784a7b9b073343 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remvoe duplicate impl for SkImageInfo flattening Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""""" This reverts commit eabd6b2ed4e494b323c08f32358f45950a0368c3. BUG= Review URL: https://codereview.chromium.org/108773003 git-svn-id: http://skia.googlecode.com/svn/trunk@12624 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
6a32add491cc736aab95561d137909cd7c5d65ef |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""" This reverts commit d08eca87a0bef10112a211de540f89656a80b86a. BUG= Review URL: https://codereview.chromium.org/108303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12623 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
6965a0a2df9d35cd0a25e1738f0388272d03f399 |
|
11-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""" BUG= Review URL: https://codereview.chromium.org/110503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12622 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
2ebc10dd12a6fe55fda37a9bd5b1e0c1c1e08232 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""" This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7. Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg. BUG= Review URL: https://codereview.chromium.org/108993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12551 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
473f0aa2bb218e50fce5e19063f8c8fdaf57fad4 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."" This reverts commit 4174afb18a9746bbad2a06c0ec2d4ad35f72d790. BUG= Review URL: https://codereview.chromium.org/108723003 git-svn-id: http://skia.googlecode.com/svn/trunk@12547 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5b132b28da61e89cdcb84e95f30a58f8184739fc |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap." This reverts commit 154e08b2f5904ef533da694e3510befcb9a3f3e2. revert due to warnings Review URL: https://codereview.chromium.org/108513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12538 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
3e89524e747b513986abfeeea00b6fac79593f26 |
|
06-Dec-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap. R=mtklein@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/68973005 git-svn-id: http://skia.googlecode.com/svn/trunk@12537 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
11e055518a0cbe5329232a55fe2cd177e83836d8 |
|
03-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Code cleanup following recapture of skps https://codereview.chromium.org/88233003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12472 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
466310dbd3073add2ec934e336c30deaaf702eae |
|
03-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move fIsOval from SkPath to SkPathRef https://codereview.chromium.org/89123002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12463 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ca316f576eaa925157575985eac425206308aaf4 |
|
03-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of r12450 (Move fIsOval from SkPath to SkPathRef) git-svn-id: http://skia.googlecode.com/svn/trunk@12452 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
31f0ffc9c38b377c60979e18c6fd898ba08c8faf |
|
03-Dec-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move fIsOval from SkPath to SkPathRef https://codereview.chromium.org/89123002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12450 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
d6bab0238655dbab24dfe92bd0b16b464310a8c7 |
|
02-Dec-2013 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r12427 git-svn-id: http://skia.googlecode.com/svn/trunk@12428 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5b39f5ba9c339d1e4dae391fee9ec1396feec180 |
|
02-Dec-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@12427 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
11f392ed531f05e8de6b6af6ae607f90aeb080c6 |
|
26-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Revert "remove kA1_Config, as it is no longer supported"" This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e. BUG= R=rmistry@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/86483002 git-svn-id: http://skia.googlecode.com/svn/trunk@12392 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
e61a86cfa00ea393ecc4a71fca94e1d476a37ecc |
|
18-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Guard against most unintentionally ephemeral SkAutoFoo instantiations. I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
381010e5501a8d681f8f059486da74f4924f81e5 |
|
24-Oct-2013 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Expose SkPicture::willPlayBackBitmaps() This returns true if (1) the picture has finished recording and (2) this picture or any picture drawn into it refers to any bitmaps. It allows clients doing complicated manipulations of the picture to early-out when there are no bitmaps present. BUG=303281 R=reed@google.com git-svn-id: http://skia.googlecode.com/svn/trunk@11935 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ca0c8389e2fd1c7f528869beb77a6c8587d59f29 |
|
26-Sep-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Move bound and isFinite into pathref https://codereview.chromium.org/24350006/ git-svn-id: http://skia.googlecode.com/svn/trunk@11467 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
7ce661d19c5cf4484305a1b20c44bd111f129847 |
|
27-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Blur refactoring https://codereview.chromium.org/21835004/ git-svn-id: http://skia.googlecode.com/svn/trunk@10936 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
eed779d866e1e239bfb9ebc6a225b7345a41adf9 |
|
16-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://chromiumcodereview.appspot.com/20806003 git-svn-id: http://skia.googlecode.com/svn/trunk@10765 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
056dab300d3649763f30f799bc55038d124acad1 |
|
08-Jul-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Temporary change to keep chrome happy." Now that chrome has https://chromiumcodereview.appspot.com/18078003/, this is no longer needed. Fully switched over to using CreateFromStream! Review URL: https://codereview.chromium.org/18655008 git-svn-id: http://skia.googlecode.com/svn/trunk@9911 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
0e0180a176b22fe0b6f8015aa234b8571242f761 |
|
28-Jun-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Temporary change to keep chrome happy. Add back in a version of the constructor taking a stream so that chrome can build until we switch chrome to using the factory. Will be reverted once chrome switches to using the factory. R=robertphillips@google.com Review URL: https://codereview.chromium.org/17916003 git-svn-id: http://skia.googlecode.com/svn/trunk@9823 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
f1754ec69131801c1a6ed3c704501a9400bbf324 |
|
28-Jun-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Replace SkPicture(SkStream) constructors with a factory. SkPicture: Remove the constructors which take an SkStream as an argument. Rather than having to check a variable for success, the factory will return NULL on failure. Add a protected function for determining if an SkStream is an SKP to share code with SkTimedPicture. In the factory, check for a NULL SkStream. Use a default decoder (from BUG: https://code.google.com/p/skia/issues/detail?id=1325) SkDebuggerGUI: Call SkPicture::CreateFromStream when necessary. Write a factory for creating SkTimedPictures and use it. Use the factory throughout tools. Add include/lazy to utils and effects gyp include_dirs so SkPicture.h can reference SkImageDecoder.h which references SkBitmapFactory.h (in include/lazy). Changes code Chromium uses, so this will require a temporary Skia and then a change to Chromium to use the new Skia code. TODO: Create a decoder that does nothing to be used by pinspect, lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer. R=reed@google.com Review URL: https://codereview.chromium.org/17113004 git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
277c3f87656c44e0a651ed0dd56efa16c0ab07b4 |
|
31-May-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
bump picture version since SkPath has changed (conics) enable conics in SkPath git-svn-id: http://skia.googlecode.com/svn/trunk@9370 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
24287c15d6c80560fc023b7924ff0bc41ad7f587 |
|
24-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Patch to prevent chromium breakage until the DEPS." This reverts commit d2a284728d30082d46b02c39d916294c6d36e11f. Review URL: https://codereview.chromium.org/16019005 git-svn-id: http://skia.googlecode.com/svn/trunk@9275 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
be879bcda3218df6e80d2a792b538f9a289ae1e0 |
|
22-May-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Mark SkDrawPictureCallback with SK_API, so that it can be derived from by SK_API classes R=reed@google.com Author: vmpstr@chromium.org Review URL: https://chromiumcodereview.appspot.com/15745015 git-svn-id: http://skia.googlecode.com/svn/trunk@9249 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
edef4aa8d84f9d0cfa49e9b7c761bb986af63142 |
|
21-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Patch to prevent chromium breakage until the DEPS. Once https://codereview.chromium.org/15489004/ is submitted to Skia, a DEPS roll into chrome will break due to a change in the API. A long term fix for chrome to use the new API is at https://codereview.chromium.org/15496006/, but since it depends on the earlier Skia change, this patch fills in the gap. Will be reverted once https://codereview.chromium.org/15496006/ is submitted to chrome. R=djsollen@google.com Review URL: https://codereview.chromium.org/15538005 git-svn-id: http://skia.googlecode.com/svn/trunk@9228 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1b1bcc3ceac9b4adbb4de68429903a5f721ffe62 |
|
21-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
New API for encoding bitmaps during serialization. This change gives more flexibility to the implementation of EncodeBitmap to prefer calling refEncodedData, doing its own encode, or even doing both and making a decision about which to use. The new function signature also allows the implementation to tell the ordered write buffer whether to store the pixel offset, in the case where the encoded bitmap represents the larger bitmap, or to ignore the pixel offset, in the case where the implementation only encoded the subset that is used. Requires changes to chromium to use the new function signature. (https://codereview.chromium.org/15496006/) SkPicture: New API for EncodeBitmap. SkOrderedReadBuffer: Ifdef'd out addition of reading the offset. SkOrderedWriteBuffer: Never call refEncodedData. Allow the user to call that from their EncodeBitmap function, if desired. This addresses https://code.google.com/p/skia/issues/detail?id=1239 Add in ifdef'd out code to record the offset. PictureTest and PictureRenderer: Implement the new definition of EncodeBitmap. Also update the name of the function to meet coding style guidelines. BUG=https://code.google.com/p/skia/issues/detail?id=1239 R=reed@google.com Review URL: https://codereview.chromium.org/15489004 git-svn-id: http://skia.googlecode.com/svn/trunk@9226 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
3e50e99fe7e6d5dbc3f3f834c8c312474d3ad057 |
|
21-May-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Housekeeper-Nightly git-svn-id: http://skia.googlecode.com/svn/trunk@9207 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
74babdfce524f478b9177834fe51d0394e42de6a |
|
20-May-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SkDrawPictureCallback optional parameter to drawPicture(), which can abort the picture drawing. R=bsalomon@google.com Review URL: https://codereview.chromium.org/14598023 git-svn-id: http://skia.googlecode.com/svn/trunk@9197 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
2983ddd4b57a05e3262fe2c1964a34f1717a5a1c |
|
07-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Allow supporting 1 older PICTURE_VERSION." This reverts commit deb9d6990ef2d153230340d960d86b0966f261e1. That change was just to allow us to bump the PICTURE_VERSION without changing the SKPs to the new one. Since it is not entirely reliable, I am removing it. R=rmistry@google.com Review URL: https://codereview.chromium.org/14741007 git-svn-id: http://skia.googlecode.com/svn/trunk@9035 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
0cb7df97185d5fc8780e225c912e2bc99a26aa8d |
|
30-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow supporting 1 older PICTURE_VERSION. Allows https://codereview.chromium.org/14230022/ to be submitted without breaking bench_pictures and render_pictures. After DEPS roll and SKP capture, this will be reverted. Review URL: https://codereview.chromium.org/14158015 git-svn-id: http://skia.googlecode.com/svn/trunk@8918 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
74b7ffda687c66d46ac3cfa4f2baedd4c62e3fbe |
|
30-Apr-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixes for piping bitmaps with encoded data. Similar goals as https://codereview.chromium.org/14437012. Builds on patch set 1 from that issue (https://codereview.chromium.org/14437012/#ps1). Instead of the changes in patch set 2 from that issue, this changes SkOrderedWriteBuffer::writeBitmap to store whether an SkBitmapHeap was used when to store the index of the SkBitmap. SkOrderedReadBuffer::readBitmap now uses that information to distinguish between using the heap and unflattening. In addition, writeBitmap now records the width/height first in all cases. If now SkBitmapHeapReader is attached, but an SkBitmapHeap was used to record the bitmap, reading will fail and provide the same red SkBitmap as in the case where the SkBitmap was encoded but could not be decoded. Updates the PICTURE_VERSION as well. The key differences in this CL to look at are in: SkOrderedWriteBuffer, SkOrderedReadBuffer, and SkPicture. BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/14230022 git-svn-id: http://skia.googlecode.com/svn/trunk@8917 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
4bb50b22fce5c4031549976cf7b04d63cc22e624 |
|
13-Apr-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@8670 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ad7d481ea9839e0f4c497e58cabe209ffc1e4683 |
|
12-Apr-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add testing of optimizations to GM https://codereview.chromium.org/12843028/ git-svn-id: http://skia.googlecode.com/svn/trunk@8658 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
07a8ea00027ccdc7aa5a92d77bed3dbef697194a |
|
12-Apr-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r8654 git-svn-id: http://skia.googlecode.com/svn/trunk@8655 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
c10531b50259049bd7238e85df17e8c2c09a062c |
|
12-Apr-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add testing of optimizations to GM https://codereview.chromium.org/12843028/ git-svn-id: http://skia.googlecode.com/svn/trunk@8654 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
32ef131f5279da0850f865dece4935aeddddb40a |
|
22-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkSerializationHelpers. Move the function definition for EncodeBitmap to SkPicture, where InstallPixelRefProc has already moved (and where it is relevant). Review URL: https://codereview.appspot.com/7386053 git-svn-id: http://skia.googlecode.com/svn/trunk@7837 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
f8d7d2731318cdf510ab68e6b3f5ec68ab22c8e2 |
|
22-Feb-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Create SkLazyPixelRef which performs lazy decoding. The new pixel ref behaves similarly to SkImageRef, with some key differences: It does not depend on the images project. It requires an SkImageCache, which handles allocation and caching of the pixel memory. It takes a function signature for decoding which decodes into already allocated pixel memory rather than into an SkBitmap. Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache. Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc, and update sites that referenced it. SkBitmapFactory now sets the pixel ref to a new object of the new class SkLazyPixelRef, provided it has an SkImageCache for caching. Provide an option to do lazy decodes in render_pictures and bench_pictures. SkPicture: Eliminate the default parameters in the constructor. If a proc for decoding bitmaps is installed, use it to decode any encoded data in subpictures. When parsing deserializing subpictures, check for success. When serializing subpictures, pass the picture's bitmap encoder to the subpicture's call to serialize. Update BitmapFactoryTest to test its new behavior. BUG=https://code.google.com/p/skia/issues/detail?id=1008 BUG=https://code.google.com/p/skia/issues/detail?id=1009 Review URL: https://codereview.appspot.com/7060052 git-svn-id: http://skia.googlecode.com/svn/trunk@7835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
d9b0f480be398cb37c447605109c419e8314cf61 |
|
01-Feb-2013 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Only support SkPicture abort for Android due to the fragility of the existing API Review URL: https://codereview.appspot.com/7225083 git-svn-id: http://skia.googlecode.com/svn/trunk@7515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
4ed0fb768409bf97b79899c3990d8c15f5e9d784 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6766, thereby re-landing 6762-6763 now that the bots are ready git-svn-id: http://skia.googlecode.com/svn/trunk@6770 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
25c1408c3da9ca90509b84f21a1161ef40052bd1 |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
revert 6762-6763, since those require new skps to be generated, and we can't do that immediately right now... will re-submit when we can. git-svn-id: http://skia.googlecode.com/svn/trunk@6766 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
68d61ed83ec7b6e98e9623c2f5c9e7b1a32d25bb |
|
12-Dec-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
make RRect and Oval first-class drawing primitives in SkCanvas. add RRect as a first-class clip primitive. Review URL: https://codereview.appspot.com/6923058 git-svn-id: http://skia.googlecode.com/svn/trunk@6762 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
459e6623f1c014136f2a8df34c4af80f994eccf0 |
|
14-Nov-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove a warning for comparing signed and unsigned integers. Review URL: https://codereview.appspot.com/6851050 git-svn-id: http://skia.googlecode.com/svn/trunk@6420 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
fbb0ed959de64f16d236d2f0d81ddf5cb318e1fe |
|
13-Nov-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@6409 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
9a5b570e5cbf907fabd69a5ffef94ef135e4066f |
|
13-Nov-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Allow SkPicture-derived classes install their own SkPicturePlayback-derived object https://codereview.appspot.com/6851048/ git-svn-id: http://skia.googlecode.com/svn/trunk@6405 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
35ac048e357aefa6289485c8f6a50fadce23c0d2 |
|
01-Nov-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Refactoring RTree integration to support SkBBoxHierarchy polymorphism in SkPicture. This moves the rtree creation into a virtual method. Review URL: https://codereview.appspot.com/6811057 git-svn-id: http://skia.googlecode.com/svn/trunk@6242 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
27b40e9f36f567a57ae92860052b36cedacdd4fd |
|
26-Oct-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@6133 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
831c726f83ab3146a573f483438c1a461b2ba465 |
|
25-Oct-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Correctly set width & height in filtered SkPictures https://codereview.appspot.com/6772047/ git-svn-id: http://skia.googlecode.com/svn/trunk@6103 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
63f1127a70428dca12141c0ad12e1103ae8db35f |
|
24-Oct-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make filter tool actually filter the read in SkPicture https://codereview.appspot.com/6765046/ git-svn-id: http://skia.googlecode.com/svn/trunk@6080 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
5a7c6be72b940dde8ff6ad2485a09aecd56a2660 |
|
04-Oct-2012 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add the ability to provide function pointers to SkPicture serialization and deserialization for encoding and decoding bitmaps. Remove kForceFlattenBitmapPixels_Flag, which is no longer used. When an SkOrderedReadBuffer needs to read a bitmap, if it does not have an image decoder, use a dummy bitmap. In GM, add a tolerance option for color differences, used when testing picture serialization, so it can assume two images are the same even though PNG encoding/decoding may have resulted in small differences. Create dummy implementations for SkImageDecoder and SkImageEncoder functions in SkImageDecoder_empty so that a project that does not want to include the images project it can still build. Allow ports to build without images project. In Mac's image encoder, copy 4444 to 8888 before encoding. Add SkWriter32::reservePad, to provide a pointer to write non 4 byte aligned data, padded with zeroes. In bench_ and render_ pictures, pass decode function to SkPicture creation from a stream. BUG=https://code.google.com/p/skia/issues/detail?id=842 Review URL: https://codereview.appspot.com/6551071 git-svn-id: http://skia.googlecode.com/svn/trunk@5818 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
66bcbd12bf075145e0c38f3e36c9f13e65f5e10e |
|
17-Sep-2012 |
borenet@google.com <borenet@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Check for invalid SkPictures - Remove hasRecorded() since nobody uses it. - Add "success" boolean to SkPicture stream constructor - Track failures in render_pictures and bench_pictures Review URL: https://codereview.appspot.com/6493105 git-svn-id: http://skia.googlecode.com/svn/trunk@5573 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1c6307e36fd96894bd11727c995f9cf9991a7be1 |
|
14-Sep-2012 |
rileya@google.com <rileya@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix some nits from http://codereview.appspot.com/6506103/ git-svn-id: http://skia.googlecode.com/svn/trunk@5547 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1d225f2b3352bb8f24661f62d2bd1cc7386a2f86 |
|
14-Sep-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@5539 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8515e79a7699922e0f95f93e8cc11d4c88657c58 |
|
13-Sep-2012 |
rileya@google.com <rileya@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add R-Tree record flag to SkPicture, plus some cleanup/fixes in associated classes. Review URL: https://codereview.appspot.com/6506103 git-svn-id: http://skia.googlecode.com/svn/trunk@5537 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
a27096b4740775ae141fd0abaf456d706065c5ee |
|
30-Aug-2012 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Nightly_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@5346 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
c9ab987efcb7e8b69237d565f73c28c137610232 |
|
29-Aug-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implement multi-threaded picture playback via cloning. The CL adds SkPicture.clone() which produces a thread-safe copy by creating a shallow copy of the thread-safe data within the picture and a deep copy of the data that is not (e.g. SkPaint). This implementation re-flattens the paints when cloning instead of retaining the flattened paints from the recording process. Changes were also needed to various classes to ensure thread safety Review URL: https://codereview.appspot.com/6459105 git-svn-id: http://skia.googlecode.com/svn/trunk@5335 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 |
|
23-Aug-2012 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) This CL is part I of IV (I broke down the 1280 files into 4 CLs). Review URL: https://codereview.appspot.com/6485054 git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
7dade42e6f2e35dd27b4090fd7894322d755d4db |
|
27-Jul-2012 |
djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Always store pixels of mutable bitmaps when recording a SkPicture. Prior to this CL mutable bitmaps only saved a copy of their pixels if a flag was set at recording time. That flag has been removed and the default behavior when recording a mutable bitmap is to make a copy of it's pixels. This is the only way to ensure that the pixels are not manipulated before we playback their contents. However, enabling this behavior breaks the recording of extracted bitmaps in SkPicture. This is because we currently cache bitmaps within a picture based only on their pixelRef. This results in false positive cache hit when drawing an extracted bitmap as it shares a pixelRef with its orginating bitmap. Therefore we must update the index of the bitmap cache to be both the pixelRef AND the size and offset of the bitmap using those pixels. BUG= TEST=extractbitmap.cpp Review URL: https://codereview.appspot.com/6439043 git-svn-id: http://skia.googlecode.com/svn/trunk@4809 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
34342f6f5127122ecc32166dcffa7f3d2a45c387 |
|
25-Jun-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
export flags on the state of the world when a picture was serialized. e.g. don't read/write functionptrs in that case (sizeof may be different for one) Review URL: https://codereview.appspot.com/6331050 git-svn-id: http://skia.googlecode.com/svn/trunk@4318 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
15e9d3e66e161ce23df30bc13f8a0c87d196b463 |
|
21-Jun-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Expanded distribution of instance counting http://codereview.appspot.com/6300114/ git-svn-id: http://skia.googlecode.com/svn/trunk@4291 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
4866cc0afb7571309d9fdecb221d919f663054c0 |
|
01-Jun-2012 |
junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Adding option to serialize mutable bitmaps in SkPicture BUG=http://code.google.com/p/chromium/issues/detail?id=115654 REVIEW=http://codereview.appspot.com/6221066/ git-svn-id: http://skia.googlecode.com/svn/trunk@4130 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e |
|
28-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Automatic update of all copyright notices to reflect new license terms. I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
1a32d4aed2534337556d452c545444551f0a780c |
|
25-Apr-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add SK_API git-svn-id: http://skia.googlecode.com/svn/trunk@1178 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
ae814c809e1c4e02a1876c39065775c8c7d00f96 |
|
13-Feb-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add picture-record option to speedup complex clips remove hack that stopped picture-playback from culling on clipPath() result git-svn-id: http://skia.googlecode.com/svn/trunk@92 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|
8a1c16ff38322f0210116fa7293eb8817c7e477e |
|
17-Dec-2008 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
grab from latest android git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/core/SkPicture.h
|