| 65a9344120049140ba79ce30c638a9f0b038cbc2 |
|
09-Jun-2017 |
Mike Reed <reed@google.com> |
remove unneeded include
Bug: skia:
Change-Id: If8c689c008438efed398d018782021195f6d0274
Reviewed-on: https://skia-review.googlesource.com/19261
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/include/ports/SkFontConfigInterface.h
|
| 9adfef8680c22ce8980031b4bcb9f1fadd066a80 |
|
20-Jan-2017 |
Herb Derby <herb@google.com> |
Remove public APIs that use SkDataTable.
Change-Id: Ibb8f987efc585713a6f8061c72fb416d07be13b1
Reviewed-on: https://skia-review.googlesource.com/7352
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/include/ports/SkFontConfigInterface.h
|
| 1ae0e01accbca4b96a10b8a8c21917dd7bf27dc3 |
|
19-Sep-2016 |
bungeman <bungeman@google.com> |
Split SkFontConfigInterface globals and factory.
Chromium needs to be able to set up their build such that the globals
continue existing but the SkFontMgr::Factory can be defined separately.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review-Url: https://codereview.chromium.org/2346333002
/external/skia/include/ports/SkFontConfigInterface.h
|
| feb3c1a57faee39dc10ac904f6b215ba50e286b4 |
|
05-Aug-2016 |
bungeman <bungeman@google.com> |
Move to SkDataTable::MakeXXX and sk_sp.
Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
Review-Url: https://codereview.chromium.org/2211143002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 69df0206252ce0e6293c60274a1dfc363bb2e3b5 |
|
03-Jun-2016 |
bungeman <bungeman@google.com> |
Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR.
Some of the deprecated signatures are no longer used by any known
client, so remove them now to prevent future use.
TBR=reed
This doesn't add API, it just removes it.
Review-Url: https://codereview.chromium.org/2036993003
/external/skia/include/ports/SkFontConfigInterface.h
|
| 13b9c95295f4c5732e34574789e721a6bc08f7b4 |
|
12-May-2016 |
bungeman <bungeman@google.com> |
Move SkTypeface to sk_sp.
Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933393002
Review-Url: https://codereview.chromium.org/1933393002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 9a9a7b29e5e5916a7b6453cd124ca437f14b9da4 |
|
12-May-2016 |
scroggo <scroggo@google.com> |
Revert of Move SkTypeface to sk_sp. (patchset #5 id:80001 of https://codereview.chromium.org/1933393002/ )
Reason for revert:
fontmgr_iterAndroid failing to draw emoji. E.g. https://gold.skia.org/search2?blame=6296da736fbf40aae881650c239420f64e576c3f&unt=true&head=true&query=source_type%3Dgm
Original issue's description:
> Move SkTypeface to sk_sp.
>
> Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
TBR=reed@google.com,fmalita@chromium.org,tomhudson@google.com,bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1974783002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 6296da736fbf40aae881650c239420f64e576c3f |
|
11-May-2016 |
bungeman <bungeman@google.com> |
Move SkTypeface to sk_sp.
Review-Url: https://codereview.chromium.org/1933393002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 42846ed43767740993f6eb1cdb62f208713304c9 |
|
05-May-2016 |
mtklein <mtklein@chromium.org> |
Modernize SkMutex and SkSemaphore.
- use <atomic>
- fuse SkMutex and SkBaseMutex
- fuse SkSemaphore and SkBaseSemaphore
Still TODO:
- replace SK_DECLARE_STATIC_MUTEX(name) with static SkMutex name
I just didn't want to bother fixing all that up until I know this CL sticks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947153002
No public API changes.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/427c2819d9237d7d7729c59238036cfc73c072ea
Review-Url: https://codereview.chromium.org/1947153002
/external/skia/include/ports/SkFontConfigInterface.h
|
| d9f5d20f81b15190fa858eda1f536deae21e8e78 |
|
05-May-2016 |
sclittle <sclittle@chromium.org> |
Revert of Modernize SkMutex and SkSemaphore. (patchset #2 id:20001 of https://codereview.chromium.org/1947153002/ )
Reason for revert:
This CL seems to have broken the Linux x64 and Mac
bots, e.g.
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052
https://build.chromium.org/p/chromium/builders/Mac/builds/15151
The error appears to have something to do with new static initializers being
added.
Original issue's description:
> Modernize SkMutex and SkSemaphore.
>
> - use <atomic>
> - fuse SkMutex and SkBaseMutex
> - fuse SkSemaphore and SkBaseSemaphore
>
> Still TODO:
> - replace SK_DECLARE_STATIC_MUTEX(name) with static SkMutex name
>
> I just didn't want to bother fixing all that up until I know this CL sticks.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947153002
>
> No public API changes.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/427c2819d9237d7d7729c59238036cfc73c072ea
TBR=herb@google.com,mtklein@chromium.org,reed@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609340
Review-Url: https://codereview.chromium.org/1945343003
/external/skia/include/ports/SkFontConfigInterface.h
|
| 427c2819d9237d7d7729c59238036cfc73c072ea |
|
04-May-2016 |
mtklein <mtklein@chromium.org> |
Modernize SkMutex and SkSemaphore.
- use <atomic>
- fuse SkMutex and SkBaseMutex
- fuse SkSemaphore and SkBaseSemaphore
Still TODO:
- replace SK_DECLARE_STATIC_MUTEX(name) with static SkMutex name
I just didn't want to bother fixing all that up until I know this CL sticks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947153002
No public API changes.
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/1947153002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 0265707c191a31dfde08dd1cd7011c1fe5b8e643 |
|
02-May-2016 |
bungeman <bungeman@google.com> |
Clean up SkFontConfigInterface implementation.
Renames some classes to avoid confusion with FontConfig.
Removed direct calls to FontConfig instead of calling FCI.
Moves the globals and factory to one (optional) file.
Moves font management code from typeface to font manager.
Adds index to fonts created from streams.
Associates FCI typefaces with the FCI instance which provides its identity.
Simplifies the singleton initialization.
Review-Url: https://codereview.chromium.org/1936213002
/external/skia/include/ports/SkFontConfigInterface.h
|
| ed2edabd07086bbf60df17ca0bf52d8ba49f2273 |
|
13-Apr-2016 |
bungeman <bungeman@google.com> |
Remove SK_VERY_LEGACY_CREATE_TYPEFACE.
The flag and code it guards are no longer used.
TBR=reed
This just removes dead code.
Review URL: https://codereview.chromium.org/1882803002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 11a77c6e0634e2feb6fe4e74806db2fdd2a799ec |
|
12-Apr-2016 |
bungeman <bungeman@google.com> |
Begin switch to SkFontStyle for legacy calls.
This adds SK_VERY_LEGACY_CREATE_TYPEFACE which, when defined, provides
only the old interface.
Ideally, everyone would switch directly to SkFontMgr and use one of the
newer calls, but there is currently no path for current users to get
there. This updates all the internals to use SkFontStyle, after
switching these over the higher level APIs can be switched.
The Chromium follow on patch can be seen at https://crrev.com/1877673002
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873923002
TBR=reed
This doesn't really change API, just modernizes it.
Review URL: https://codereview.chromium.org/1873923002
/external/skia/include/ports/SkFontConfigInterface.h
|
| bf521ff9415b3bdb1acde7b8d18139df176236e5 |
|
17-Feb-2016 |
bungeman <bungeman@google.com> |
Move SkTArray to include/private.
TBR=reed
Agreed moving to private is good.
Review URL: https://codereview.chromium.org/1702073002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 9b137dc54e668ca5552bab8a1c550edc02214db4 |
|
20-Nov-2015 |
fmalita <fmalita@chromium.org> |
SkFontConfigInterface::createTypeface()
BUG=524578
R=bungeman@google.com,reed@google.com
Review URL: https://codereview.chromium.org/1454343003
/external/skia/include/ports/SkFontConfigInterface.h
|
| 2766c00fc0b6a07d46e5f74cdad45da2ef625237 |
|
26-Jun-2015 |
mtklein <mtklein@chromium.org> |
remove SkInstCnt
It's been outclassed by Valgrind and leak sanitizer,
and it seems to be causing problems for external folks building Skia.
I'm not sure why our own builds seem unaffected.
Latest thread:
https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0
BUG=skia:
Review URL: https://codereview.chromium.org/1217573002
/external/skia/include/ports/SkFontConfigInterface.h
|
| 7be2eb89cc85fc9fc05814957d152f3d20613657 |
|
23-Feb-2015 |
bungeman <bungeman@google.com> |
Remove SkFontHost includes and friends.
SkFontHost no longer exists as a class, so remove the includes and stop
making it a friend.
Review URL: https://codereview.chromium.org/943333004
/external/skia/include/ports/SkFontConfigInterface.h
|
| 5f213d9627d2eefa7da81cd97f36754f75eb4ae9 |
|
27-Jan-2015 |
bungeman <bungeman@google.com> |
SkTypeface to use SkStreamAsset.
SkTypeface already requires typeface streams to support SkStreamAsset
in practice, and in practice all users are already supplying them.
Review URL: https://codereview.chromium.org/869763002
/external/skia/include/ports/SkFontConfigInterface.h
|
| c87dd2ce965cd1bbc8a74abe0c141658a469d7f2 |
|
14-Nov-2014 |
djsollen <djsollen@google.com> |
Enable unused param checking for public includes.
This CL cleans up the existing violations and enables the
build time check to ensure that we don't regress.
The motiviation behind this change is to allow clients who include
our headers to be able to build with this warning enabled.
Review URL: https://codereview.chromium.org/726923002
/external/skia/include/ports/SkFontConfigInterface.h
|
| e438ddbc7451ec80f953266409fea4695e78c8c2 |
|
02-Jul-2014 |
tomhudson <tomhudson@chromium.org> |
Uses optional mutex to guard construction of the singleton, which
initializes the non-threadsafe libfontconfig. Without this change,
Skia's parallel path ops test runner crashes 6/10 and hangs 2/10 on
startup; with this change, 0/10 problems.
BUG=skia:2693
R=mtklein@google.com, bungeman@google.com, reed@google.com
Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8
Committed: https://skia.googlesource.com/skia/+/60b08a0adfe73f593af62c8d3f55958438360e1b
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/355573006
/external/skia/include/ports/SkFontConfigInterface.h
|
| e41f3886ead65550cdbfa99b8f4b7c1831ec3221 |
|
01-Jul-2014 |
mtklein <mtklein@google.com> |
Revert of Fix race condition in parallel font initialization. (https://codereview.chromium.org/355573006/)
Reason for revert:
canaries still slightly broken
Original issue's description:
> Fix race condition in parallel font initialization.
>
> Uses a mutex to guard construction of the singleton, which initialies
> the non-threadsafe libfontconfig. Without this change, the parallel
> path ops test runner crashes 6/10 and hangs 2/10 on startup; with this
> change, 0/10 problems.
>
> BUG=skia:2693
> R=mtklein@google.com,bungeman@google.com
>
> Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8
>
> Committed: https://skia.googlesource.com/skia/+/60b08a0adfe73f593af62c8d3f55958438360e1b
R=bungeman@google.com, reed@google.com, tomhudson@google.com, tomhudson@chromium.org
TBR=bungeman@google.com, reed@google.com, tomhudson@chromium.org, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2693
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/354133004
/external/skia/include/ports/SkFontConfigInterface.h
|
| 60b08a0adfe73f593af62c8d3f55958438360e1b |
|
01-Jul-2014 |
tomhudson <tomhudson@chromium.org> |
Fix race condition in parallel font initialization.
Uses a mutex to guard construction of the singleton, which initialies
the non-threadsafe libfontconfig. Without this change, the parallel
path ops test runner crashes 6/10 and hangs 2/10 on startup; with this
change, 0/10 problems.
BUG=skia:2693
R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com
Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/355573006
/external/skia/include/ports/SkFontConfigInterface.h
|
| 50a7b0e6212cfad02e356f9d0bd82b6eadf31f96 |
|
01-Jul-2014 |
reed <reed@chromium.org> |
Revert of Fix race condition in parallel font initialization. (https://codereview.chromium.org/355573006/)
Reason for revert:
breaks chrome builds
Original issue's description:
> Fix race condition in parallel font initialization.
>
> Uses a mutex to guard construction of the singleton, which initialies
> the non-threadsafe libfontconfig. Without this change, the parallel
> path ops test runner crashes 6/10 and hangs 2/10 on startup; with this
> change, 0/10 problems.
>
> BUG=skia:2693
> R=mtklein@google.com,bungeman@google.com
>
> Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8
R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com, tomhudson@chromium.org
TBR=bungeman@google.com, mtklein@google.com, reed@google.com, tomhudson@chromium.org, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2693
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/365503003
/external/skia/include/ports/SkFontConfigInterface.h
|
| df022f5972ae6a2a1d96d15c50eca52cade3abd8 |
|
30-Jun-2014 |
tomhudson <tomhudson@chromium.org> |
Fix race condition in parallel font initialization.
Uses a mutex to guard construction of the singleton, which initialies
the non-threadsafe libfontconfig. Without this change, the parallel
path ops test runner crashes 6/10 and hangs 2/10 on startup; with this
change, 0/10 problems.
BUG=skia:2693
R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/355573006
/external/skia/include/ports/SkFontConfigInterface.h
|
| ab1c13864df34aecfd4840ea7d1e4f8730b44f4e |
|
05-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix compilation with SK_ENABLE_INST_COUNT=1
Add INHERITED declarations to class declarations that prevent
compilation with the flag.
Remove SK_DEFINE_INST_COUNT from all class implementations. Instead,
use function-local static variables in the reference count helper
classes to create the global instances to store the needed info. The
accessor functions are defined inline in the helper classes, so
definitions are not needed. The initialization point of the variables
should be as well defined as previously.
Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT
instead. This avoids possible future compilation errors further.
For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member
function to all classes that use SK_DECLARE_INST_COUNT and
SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes
contain public INHERITED typedef. This member function seems to be
compiled away. This shouĺd ensure that part of the compilation errors
are caught earlier.
Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses.
R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/98703002
git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| ef284a84f503adfd08ee52b5aee142c548698ea4 |
|
12-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
The two leaks are:
missing unrefs in megalooper GM
missing reset capability in oval renderer
This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet)
R=bsalomon@google.com, jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/18461007
git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| e36a168d132a70d04eb696d8b50e2aea5c725bff |
|
23-Apr-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8819 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| f55061fd8453e8d2b33f1f05060fc443deee3222 |
|
22-Apr-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
check-point for linux fontmgr impl
Review URL: https://codereview.chromium.org/14305007
git-svn-id: http://skia.googlecode.com/svn/trunk@8808 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 027fd204ad09fe3160c7319b1e55c4ae44747947 |
|
19-Apr-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use SkDataTable to return familyNames for fontmgr
git-svn-id: http://skia.googlecode.com/svn/trunk@8781 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 21db1dbbce8de9d1205a4fac1c3b15975807a7e7 |
|
10-Apr-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Temporary patch to get Chrome Windows compiling
git-svn-id: http://skia.googlecode.com/svn/trunk@8583 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 54c69147f96eedb10e430df72d71419795e81d3a |
|
09-Apr-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
extend FontConfigInterface to start to match new fontmgr design
Review URL: https://codereview.chromium.org/13297004
git-svn-id: http://skia.googlecode.com/svn/trunk@8575 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 8c9737e114f13ce393f2c582b2567ac4b3e530e7 |
|
06-Mar-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
change FontIdentity to explicitly hold ttcIndex and ID, so we can use both in the
IPC version in chrome.
git-svn-id: http://skia.googlecode.com/svn/trunk@8005 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| d66045ec7d37720309dae4879efc01793c3e746a |
|
04-Mar-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
export getter for global instance of fontconfiginterfacedirect
git-svn-id: http://skia.googlecode.com/svn/trunk@7963 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 86a44b89c5bd6345790c03fba63969cd1c19e66b |
|
04-Mar-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
export api with SK_API
git-svn-id: http://skia.googlecode.com/svn/trunk@7962 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| f71a2335f9b64442c65b45d1f703cd4ffb84129d |
|
27-Feb-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use fontconfig fonthost for skia (in prep for using in chrome)
Review URL: https://codereview.chromium.org/12319150
git-svn-id: http://skia.googlecode.com/svn/trunk@7887 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| 80f5465083bdc5449223f5875b401648616e8e09 |
|
25-Feb-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
git-svn-id: http://skia.googlecode.com/svn/trunk@7856 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|
| d71fe99fe4d54230572223915166bea8efd67d85 |
|
25-Feb-2013 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
check-point: skiafy SkFontHost_fontconfig from chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@7852 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/include/ports/SkFontConfigInterface.h
|