| 1a325d25b941ef801b3e9b2c0342da43cf35cdba |
|
14-Jul-2017 |
Chris Dalton <csmartdalton@google.com> |
Coverage counting path renderer
Initial implementation of a GPU path renderer that draws antialiased
paths by counting coverage in an offscreen buffer.
Initially disabled until it has had time to soak.
Bug: skia:
Change-Id: I003d8cfdf8dc62641581b5ea2dc4f0aa00108df6
Reviewed-on: https://skia-review.googlesource.com/21541
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 80a82dff82d11c229d33e87453e8510cbd1603b9 |
|
12-Jul-2017 |
Brian Osman <brianosman@google.com> |
On Windows, always re-create window for GL or Vulkan
On at least one machine, I've seen SetPixelFormat fail after Vulkan was
used to render to a window, preventing us from creating a GL context.
This is ham-fisted, but solves the problem.
Bug: skia:
Change-Id: I76d0cb26e181304846aa06109c1af768f8363a18
Reviewed-on: https://skia-review.googlesource.com/22740
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 2ac96dc82c45b4425c288dedbf3d35d70ac36928 |
|
23-Jun-2017 |
Brian Osman <brianosman@google.com> |
Hack to fix MSAA GL -> Vk transition on Windows Viewer
Bug: skia:
Change-Id: I49417789ab43734a1cbb4010281482970579971d
Reviewed-on: https://skia-review.googlesource.com/20505
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| b53f48cfec64830fa506267487a1037d27acb474 |
|
07-Jun-2017 |
Brian Osman <brianosman@google.com> |
Touch input support for Windows
Had to add some logic to avoid touch and mouse cross-talk, because
(at least on my laptop), the touch screen generates both kinds of
events.
This seems really useful [1] for the many [2] Skia developers with
touch-enabled Windows devices.
----------
1: No, not really.
2: N = 1?
Bug: skia:
Change-Id: Ib888bf4198f2cc0a29a31581ec4b64d3d9008c33
Reviewed-on: https://skia-review.googlesource.com/18920
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 42bb6acf56471e7308926e6b242fbbdd4103f306 |
|
05-Jun-2017 |
Brian Osman <brianosman@google.com> |
Simplify some Viewer code, and fix a few bugs
The content rect was always identical to the window rect,
so most of the related code did nothing. The translation
limit code is always useful (to avoid dragging the slide
way off-screen with the mouse), so always include it.
The auto-scaling to fit the screen is also still useful,
but just base it on the window rect.
The zoom code has four state variables, only used two of
them, and one was a trivially derived computation. Fold
most of that work into computeMatrix. (The translation
was always zero -- we never changed the zoom center.)
Include fDefaultMatrix in the matrix from computeMatrix,
rather than needing to apply it specially to the canvas.
Don't apply the inverse default matrix to touch or mouse
points. The absolute positions of those touch points is
not important, but because that matrix includes scale
(and sometimes very large or very small scale), it just
had the effect of greatly amplifying or damping the drag
speed. Without it, the slide always pans at the speed of
the touch/mouse drag -- which seems more desirable.
The use of the inverse default matrix was a clever trick,
but it caused the translation (applied to the global mtx)
to be scaled, so the slide was always pinned incorrectly.
Instead, supply the unmodified window rect and the default
matrix, so the trans limit code can do the obvious correct
thing: xform the slide bounds completely, then limit the
translation that will be applied after that. Slides are
now correctly pinned to screen edge regardless of how
much zoom is present in the default matrix.
Note: There are still several bugs related to all of this
code, but given the web of xform state, it's hard to
unravel. The touch gesture still doesn't know about
viewer's zoom, so that's ignored when doing the pinning.
Beyond that, it doesn't even know about window resize -
it only configures the translation limit when setting up
a slide. I had a fix for all of this (doing the
translation limiting in computeMatrix), but then the touch
gesture doesn't know about it, and can accumulate drag
motion that needs to be un-dragged to get back on-screen,
even though the slide is never really translated that far.
SkTouchGesture is in include. No one uses it except viewer:
TBR=bsalomon@google.com
Bug: skia:
Change-Id: I460cc07c3de6d36e63826f57d359faf1facf5ab3
Reviewed-on: https://skia-review.googlesource.com/18524
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 96789b31f2bca5e02f512cd273073b5707006990 |
|
26-May-2017 |
Brian Salomon <bsalomon@google.com> |
Fix resource and skp paths in Android viewer
Docs-Preview: https://skia.org/?cl=18037
Change-Id: If92e561c6c24de1f51f81477d89b927e10308f13
Reviewed-on: https://skia-review.googlesource.com/18037
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 175f588831c3d9f76349af8c27c64ceaa4460871 |
|
12-May-2017 |
Brian Salomon <bsalomon@google.com> |
Modify SkEventTracer::SetInstance to fail rather than assert if a tracer has already been installed.
Chromium usually calls SetInstance once per process. However, when run in single process more renderer threads will try to set the instance after the browser process already has done so. This allows them to fail gracefully without asserting.
Bug: skia:6603
Change-Id: Ic8a35422d787335aa67eefc07d0658f0fbe73db4
Reviewed-on: https://skia-review.googlesource.com/16664
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/tools/viewer/Viewer.cpp
|
| e7705780c9450bb190abddc47a78b8b89784ed79 |
|
04-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Add ShadowUtils sample.
Also enables mouse support in Viewer.
Change-Id: Iaed08d42a64f591f0cd9b24684b3aee43404ed94
Reviewed-on: https://skia-review.googlesource.com/15313
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| fbdc080d3cae3695544ffbc05c6ff6f5b4514c02 |
|
02-May-2017 |
Jim Van Verth <jvanverth@google.com> |
Add wireframe mode to Viewer.
Change-Id: I0ff11088465a4702acf9841a791d76f286ddbaf1
Reviewed-on: https://skia-review.googlesource.com/15147
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 0acd7954a9e654d7e9c11a532eeeeb2f18a76152 |
|
28-Apr-2017 |
Mike Reed <reed@google.com> |
add helper makeShader for the common Clamp case
Bug: skia:
Change-Id: I22cac56f35fed16daede0cf1b3e34dfa6f5ae3ea
Reviewed-on: https://skia-review.googlesource.com/14625
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 887cdf112809727c51890ba8b98b3ddce22249f0 |
|
03-Apr-2017 |
Mike Reed <reed@google.com> |
move vertex-mode enum into SkVertices
BUG=skia:6366
Change-Id: I3c0bf96cce6d32c9b8d12d16a772aaa6f18981aa
Reviewed-on: https://skia-review.googlesource.com/11062
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 830104632fd79eb5ac5bf8755a1c0271d13acb22 |
|
16-Mar-2017 |
Jim Van Verth <jvanverth@google.com> |
Rename GrAADistanceFieldPathRenderer to GrSmallPathRenderer
Also disables use of small distance fields in Android framework.
Change-Id: I1ba40ce85aa34d067608587e1fbe1d42e8a42868
Reviewed-on: https://skia-review.googlesource.com/9731
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| e0d4fbac00f240603e725b50d58d89048fd8b21f |
|
15-Mar-2017 |
Brian Osman <brianosman@google.com> |
Viewer's nonlinear blend mode uses SkColorSpaceXformCanvas
Also avoid asserting when untagged images are being transformed.
BUG=skia:
Change-Id: If712f39b5f588b2bc3dc318a5b782badb7662ccf
Reviewed-on: https://skia-review.googlesource.com/9695
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 28b1252bab2915a028a3c9da3e8a64c89e3b8d9d |
|
08-Mar-2017 |
Brian Osman <brianosman@google.com> |
Added MSAA selection to viewer GUI
On Windows, we need to reconstruct the window to allow setting a new
pixel format with a different sample count.
Added some code that maintains window size/position across these changes.
Previously, just cycling through backends would cause the window to move,
as the "default" position would cycle across the screen. Now it's pinned.
BUG=skia:
Change-Id: Iecbe7a490577382043ffe5a88c910b4c0be2ed5c
Reviewed-on: https://skia-review.googlesource.com/9085
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 41eac798f8ae5bb0fd3af3c16390d75501259f8d |
|
08-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Add instanced rendering command line flag to viewer.
Previously this could only be turned on at runtime.
Change-Id: I1b626584fba17fcf8ff64135dd93f98c7f40821d
Reviewed-on: https://skia-review.googlesource.com/9445
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 99a339069cc55c45dc8d7dcd0b1c9ed04427ab4a |
|
07-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Add viewer GUI options for desktop and Android to toggle instanced rendering.
BUG=skia:
Change-Id: I42674abfb7ee764f676100ac0e84cc0f07620bec
Reviewed-on: https://skia-review.googlesource.com/9396
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 92004807f2dffea2d4a694e49434ce4c0bcfb28d |
|
06-Mar-2017 |
Brian Osman <brianosman@google.com> |
Add legacy++ to viewer (sRGB w/nonlinear blending)
BUG=skia:6242
Change-Id: I696de8eac61aebaf5cb07d8874bde3c7bd470277
Reviewed-on: https://skia-review.googlesource.com/9299
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/tools/viewer/Viewer.cpp
|
| 42c456fd20bd45dd02f6d5eb0af7acf04341b1ee |
|
06-Mar-2017 |
Brian Salomon <bsalomon@google.com> |
Remove PLS path renderer
Change-Id: Ib727b0749a5a7da95832970e79804417e8b6a247
Reviewed-on: https://skia-review.googlesource.com/9300
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 8a9de3d828a7bb042c31aa52a2338c70716a590a |
|
01-Mar-2017 |
Brian Osman <brianosman@google.com> |
Add path renderer options to viewer GUI
BUG=skia:
Change-Id: I248ba081f0229d7fcf2071009076acc88b80b076
Reviewed-on: https://skia-review.googlesource.com/9088
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 621491e07eb66aee428db06173e27bbae7e9086a |
|
28-Feb-2017 |
Brian Osman <brianosman@google.com> |
Add backend selection to viewer's GUI
BUG=skia:
Change-Id: I3314013538792c2aa82cc49f3f072aab2cdc4a55
Reviewed-on: https://skia-review.googlesource.com/9079
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 585dba831c83447861c1977c2e4896d65d449858 |
|
28-Feb-2017 |
Brian Osman <brianosman@google.com> |
Fix crash switching to Vulkan in viewer on Windows
BUG=skia:
Change-Id: I626aa6a1571311600a6208c42a8c3e9509d037de
Reviewed-on: https://skia-review.googlesource.com/9078
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 61cd31a5d3cacb13ff3bbc3ada7e25fa98c6810c |
|
28-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
viewer: Add a "Path renderer" dropdown menu
BUG=skia:
Change-Id: Ia3ed812d24f0f83631ab238bc418a3c95d49b9dc
Reviewed-on: https://skia-review.googlesource.com/9000
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 578f064a60b63ddfb00831e9e59a47060bfcefe0 |
|
25-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Add msaa flag and UI to viewer
BUG=skia:
Change-Id: I0a24d5e6a4271f84ea5c82eb6d9ede9a1e63f86a
Reviewed-on: https://skia-review.googlesource.com/8787
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 443ec1b794ec5ec8a155a9cdc641e95a95914533 |
|
24-Feb-2017 |
Christopher Dalton <csmartdalton@google.com> |
Add onBackendCreated callback to Viewer
Also removes fWidth and fHeight from Window and instead
calls into WindowContent to get these values.
BUG=skia:
Change-Id: I72ee506004b7da73db9abb607a3bc82edfcf7d43
Reviewed-on: https://skia-review.googlesource.com/8795
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| fd8f4d502d7c7e861de7b361c8e13aacfbc49fb2 |
|
24-Feb-2017 |
Brian Osman <brianosman@google.com> |
Fix some viewer crashes when switching color mode
The whole idea of immediate mode GUIs is to put your GUI code and the
resulting action close together. Unfortunately, for actions that tear
down the backend (possibly freeing the surfaces we're drawing to), we
can't do that. So defer that action until the next frame (really, the
next idle). Only required when an action might call setDisplayParams.
BUG=skia:
Change-Id: I3eb95fdb462526cb6d95819612ad2725c6f1050b
Reviewed-on: https://skia-review.googlesource.com/8953
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| a109e3926ed2fbbb41471a140b64297ea8554357 |
|
24-Feb-2017 |
Brian Osman <brianosman@google.com> |
ImGui color space controls
Adds radio buttons for switching among legacy, sRGB and F16.
Also adds a list of primaries you can pick from, as well as
a gamut diagram showing the primaries. The primaries can be
dragged around to alter the working space.
BUG=skia:
Change-Id: Ibd8c67dfe085594c0d7462f0efe4d79d73999919
Reviewed-on: https://skia-review.googlesource.com/8311
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| bf52e3df2987219783372d181ce1b5a7f32c77f8 |
|
22-Feb-2017 |
Brian Salomon <bsalomon@google.com> |
Viewer: balance save/restores and draw offscreen to window in src mode
Change-Id: I9a9bff1c950aaeda095ee49b4860c6fee04ea731
Reviewed-on: https://skia-review.googlesource.com/8887
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 008b9d80ab9adbf2656eceaf54d11cd15e4dda05 |
|
22-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Add the ability to enable/disable GPU path renderers
Adds a bitfield to GrContextOptions that masks out path renderers.
Adds commandline flags support to set this bitfield in tools apps.
Removes GrGLInterfaceRemoveNVPR since we can now accomplish the same
thing in the context options.
BUG=skia:
Change-Id: Icf2a4df36374b3ba2f69ebf0db56e8aedd6cf65f
Reviewed-on: https://skia-review.googlesource.com/8786
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 3661bc997620899695041010a750d11dbe8a972d |
|
22-Feb-2017 |
Mike Reed <reed@google.com> |
hide trivial helpers on canvas
BUG=skia:
Change-Id: I42d4ca92897bde5bd8e0575a0104b12b83134cef
Reviewed-on: https://skia-review.googlesource.com/8852
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 6f449692c148c6b36d65c4bfa2941e3b09e25c38 |
|
14-Feb-2017 |
Jim Van Verth <jvanverth@google.com> |
Add more SampleApp support to viewer.
Fixes loading a Sample as first slide.
Adds char input.
Adds --slide and --list options.
Change-Id: I34b66818e3673fcfdc649443e7d9dfb74b478062
Reviewed-on: https://skia-review.googlesource.com/8445
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| f6877090114c002d02bef3804dbcd6be52b23cfc |
|
13-Feb-2017 |
Brian Osman <brianosman@google.com> |
Pixel zoomer in viewer
Made it a separate ImGui window (rather than part of the debug window).
Bring it up with 'z'. Draggable/resizable. Variable zoom scale. Enjoy.
BUG=skia:
Change-Id: I949ab398126c892c8d353aaebcc8403765f42841
Reviewed-on: https://skia-review.googlesource.com/8357
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 29d871554b195206e35e2d5837d1073ddccc1b6b |
|
10-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Enable threaded SkTaskGroup in Viewer
BUG=skia:
Change-Id: I7f467c094fb0bcb983bd86d07cb9bd7be34666b3
Reviewed-on: https://skia-review.googlesource.com/8332
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/tools/viewer/Viewer.cpp
|
| 79086b94eda7c46c37e1cf4395eb75ef54807e3c |
|
10-Feb-2017 |
Brian Osman <brianosman@google.com> |
Integrate the ImGui library with viewer
Code and docs are at: https://github.com/ocornut/imgui
ImGui is an open source immediate mode GUI library that's
lightweight and fairly simply to integrate. Widget functions
return their state, and the library emits vertex and index
data to render everything. It's got a huge set of built-in
widgets and really robust layout control.
For the initial integration, I had to fix up event handling
in the viewer's app framework (to get mouse wheel and more
keys, etc...).
The new viewer 'Debug' window is toggled with the space bar.
For this change, I've added one feature to that window: the
slide picker. It's got a list of all slides, with filtering
support, and the ability to click to switch slides.
I also included the ImGui 'Demo' window (toggled with 'g').
This is nicely laid out, and includes examples of pretty
much everything the library can do. It also serves as good
documentation - find something that looks like what you want,
and then go look at the corresponding code (all of it is in
imgui_demo.cpp).
I have other CLs with other features (like directly editing
the primaries of the working color space), but I wanted to
land this chunk first, then start adding more features.
Other than adding new debugging features, there are few
more outstanding work items:
1) Raster doesn't render the GUI correctly, due to non-
invertible pos -> UV matrices. Florin is working on that.
2) Touch inputs aren't being routed yet, so the GUI isn't
usable on Android yet. Might also be tough to work with,
given the size.
3) ImGui has clipboard integration (that's why it wants
the C, X, and V keys), but we need to wire it up to the
OS' clipboard functions.
4) Draw commands can carry a void* payload to support
drawing images (using whatever mechanism the engine has).
I'd like to set that up (probably using SkImage*), which
makes it really easy to add visualization of off-screen
images in GMs, etc...
BUG=skia:
Change-Id: Iac2a63e37228d33141cb55b7e4d60bf11b7e9ae1
Reviewed-on: https://skia-review.googlesource.com/7702
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 1df161ab8a6aac3ca528fd5ffdecd08438889d97 |
|
09-Feb-2017 |
Brian Osman <brianosman@google.com> |
Improve viewer stats collection and display
Measure the time taken for animation and flush. Exclude UI and stats logic
from the timing. Use stacked bars to visualize the breakdown of time
within a frame.
BUG=skia:
Change-Id: I7ef84442a68147f02f65b6aa4452768fd3314de2
Reviewed-on: https://skia-review.googlesource.com/8227
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 462334ebc16beb2c223e806561440b2b0f86c236 |
|
09-Feb-2017 |
Brian Osman <brianosman@google.com> |
Fix viewer on Android
We need libandroid in all scenarios, not just vulkan.
Also, the logic for making an off-screen surface was
wrong - causing us to try and make one in legacy mode.
BUG=skia:
Change-Id: I5ef2e3e2d46de96e9824f6a12a13f6310ea04f81
Reviewed-on: https://skia-review.googlesource.com/8252
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| f750fbcb699fff2bdd264969515fc4045a1248be |
|
08-Feb-2017 |
Brian Osman <brianosman@google.com> |
Simplify viewer's handling of backbuffer surface and color space
WindowContext still supports color spaces, but not other color
types. Any off-screen rendering is the app's responsibility.
This change also adds (working) F16 support to viewer. Note that
the previous 10-bit and FP16 support in WindowContext was broken.
There was no code to push the off-screen canvas to the window.
If you ever made it to the unreachable off-screen code path in
createSurface, it would have simply stopped drawing.
The decision to limit the window's gamut to sRGB is mostly driven
by my desire to add real-time editing of gamut. This design lets
us do that, without tearing down and rebuilding the window for
every change. An application could still supply a different gamut
via setDisplayParams and render directly to the back buffer with
proper color correction.
BUG=skia:
Change-Id: I94df35c7a42faee396009acc83683e40bb3c284d
Reviewed-on: https://skia-review.googlesource.com/8153
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 77a7a1b57c16c97f056c1e50c03bdc954947778c |
|
07-Feb-2017 |
Matt Sarett <msarett@google.com> |
SkColorSpace: remove named API, add gamut API
Reland from: https://skia-review.googlesource.com/c/8021/
BUG=skia:
Change-Id: I18985f130587b15fccbc86b76b2bb5c49ba5ba8a
Reviewed-on: https://skia-review.googlesource.com/8136
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 1f2fff2544a9dc6a0f169a017d374eca9f04c6b5 |
|
07-Feb-2017 |
Matt Sarett <msarett@google.com> |
Revert "SkColorSpace: remove named API, add gamut API"
This reverts commit ecaaf6f1c156e5690200322fc2636380c1f63dd8.
Reason for revert: Breaks everything
Original change's description:
> SkColorSpace: remove named API, add gamut API
>
> BUG=skia:
>
> Change-Id: I01c5e1874c9a034febc64e25b3aaafb5050393a6
> Reviewed-on: https://skia-review.googlesource.com/8021
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Matt Sarett <msarett@google.com>
>
TBR=msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Change-Id: Ief5a0a4eeabe75a21f7512e23fc15309151066c4
Reviewed-on: https://skia-review.googlesource.com/8127
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| ecaaf6f1c156e5690200322fc2636380c1f63dd8 |
|
06-Feb-2017 |
Matt Sarett <msarett@google.com> |
SkColorSpace: remove named API, add gamut API
BUG=skia:
Change-Id: I01c5e1874c9a034febc64e25b3aaafb5050393a6
Reviewed-on: https://skia-review.googlesource.com/8021
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| d63c10225c008cec541024fd9468a5faf2db1fbc |
|
05-Jan-2017 |
Jim Van Verth <jvanverth@google.com> |
Minor fixes for the Linux viewer
BUG=skia:6091
Change-Id: Ia954c16610634e34f10bfe4273efc6677ca9563e
Reviewed-on: https://skia-review.googlesource.com/6618
Reviewed-by: Greg Daniel <egdaniel@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 9fcc743a5c82d6799ae8e5f37901810ee0b46ebf |
|
29-Nov-2016 |
Greg Daniel <egdaniel@google.com> |
Add support for resources on android Viewer
BUG=skia:
Change-Id: I1acc3e4fe6d0ce8bf29c52dd7280dff029a3abc2
Reviewed-on: https://skia-review.googlesource.com/5322
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| bf111d7bc9ba3857433e30eae27f0272c34ed0fb |
|
08-Nov-2016 |
Ben Wagner <bungeman@google.com> |
Move SkOSPath out of include/core.
It is moved to src/utils. It is almost a tool, but has two uses in
src/ports.
The existing SkOSFile.cpp is left empty for the time being since it is
mentioned in Chromium's BUILD.gn for Skia.
Change-Id: I3bb7f7c4214359eb6ab906bfe76737d20bf1d6c7
Reviewed-on: https://skia-review.googlesource.com/4536
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 145dbcd165d9d27298eb8888bc240e2d06a95464 |
|
03-Nov-2016 |
Ben Wagner <bungeman@google.com> |
Remove SkAutoTDelete.
Replace with std::unique_ptr.
Change-Id: I5806cfbb30515fcb20e5e66ce13fb5f3b8728176
Reviewed-on: https://skia-review.googlesource.com/4381
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
/external/skia/tools/viewer/Viewer.cpp
|
| 526972ecb5411b84ba2f5e20252f178f9ee2151f |
|
24-Oct-2016 |
Brian Osman <brianosman@google.com> |
Rename all color space factories from New* to Make*
Matches our naming convention for all other types - factories that
return sk_sp (or any type that intelligently manages its own
lifetime) are named Make.
Previous factories are still around, assuming
SK_SUPPORT_LEGACY_COLOR_SPACE_FACTORIES is defined. Enable that
define for Android, etc.
See also: https://codereview.chromium.org/2442053002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3822
Change-Id: Iaea9376490736b494e8ffc820831f052bbe1478d
Reviewed-on: https://skia-review.googlesource.com/3822
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 2dd9693432b319c18a12c8a0deab5e1af5330e95 |
|
18-Oct-2016 |
Brian Osman <brianosman@google.com> |
GN builds viewer on Linux, too
BUG=skia:
Change-Id: Ia0c10db49905fc5a3bdf424c38576e1a6cf09ecf
Reviewed-on: https://skia-review.googlesource.com/3606
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 16adfa39330b7b1c6ac16b8127843e55f4233a29 |
|
18-Oct-2016 |
Brian Osman <brianosman@google.com> |
Viewer builds (for Windows) with GN
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3599
Change-Id: Id6a142f90f544bef266d78e385f22e17288d5064
Reviewed-on: https://skia-review.googlesource.com/3599
Reviewed-by: Mike Klein <mtklein@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 285db44562da7136686e6d34a8443c6c6e0b942c |
|
14-Oct-2016 |
Greg Daniel <egdaniel@google.com> |
Add support for Atrace and hook into SkEventTracer framework.
This change is a different version of:
https://skia-review.googlesource.com/c/3269/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3345
Change-Id: I49d4f2987740d3ad1307f6aba3add0d63a46b22d
Reviewed-on: https://skia-review.googlesource.com/3345
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@google.com>
/external/skia/tools/viewer/Viewer.cpp
|
| 8c67ebe4c48028635e7fe34542344e0ca7006b23 |
|
11-Aug-2016 |
jvanverth <jvanverth@google.com> |
Clean up Xlib viewer
* Make event handling closer to GLFW's
* Fix Vulkan refreshing
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226413002
Review-Url: https://codereview.chromium.org/2226413002
/external/skia/tools/viewer/Viewer.cpp
|
| a489e3f1fb94554cfba03e9966df1cc37dd97f70 |
|
09-Aug-2016 |
jvanverth <jvanverth@google.com> |
Add RasterWindowContext_mac
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2228883003
Review-Url: https://codereview.chromium.org/2228883003
/external/skia/tools/viewer/Viewer.cpp
|
| b8794ccea2163c780760b6e0f7ebd022f2c85d33 |
|
27-Jul-2016 |
jvanverth <jvanverth@google.com> |
Enable backend switching for Windows Viewer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184163003
Review-Url: https://codereview.chromium.org/2184163003
/external/skia/tools/viewer/Viewer.cpp
|
| 6c471f75b28ba8c7127875277ae27799f57a3ddc |
|
26-Jul-2016 |
bsalomon <bsalomon@google.com> |
Add sw support to viewer on Linux.
This doesn't yet do anything with srgb/colorspace.
Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
Review-Url: https://codereview.chromium.org/2165813002
/external/skia/tools/viewer/Viewer.cpp
|
| e1d2007924e7c3ec6f349c326249ba5eb9a9d70c |
|
12-Jul-2016 |
brianosman <brianosman@google.com> |
Respect --match for samples and jpgs in viewer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144643002
Review-Url: https://codereview.chromium.org/2144643002
/external/skia/tools/viewer/Viewer.cpp
|
| 2edb0f4a02fd1dbb8d6cb628b84048bcc875f72f |
|
06-Jul-2016 |
liyuqian <liyuqian@google.com> |
More accurate render time and continuous fresh
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129613002
Review-Url: https://codereview.chromium.org/2129613002
/external/skia/tools/viewer/Viewer.cpp
|
| 063ece71848fadc963cbac5c978cd48262138131 |
|
17-Jun-2016 |
jvanverth <jvanverth@google.com> |
Enable viewer in non-Vulkan builds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
Review-Url: https://codereview.chromium.org/2067023002
/external/skia/tools/viewer/Viewer.cpp
|
| ed330c8755044822ec536ce8eb0a98a8627302bd |
|
17-Jun-2016 |
liyuqian <liyuqian@google.com> |
Quickly fix the Compile Problem of Unused kkImageColorXformMetaData
TBR=msarett@google.com
I don't know why the compiler is complaining that since ImageSlide.cpp is still
using it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075873003
Review-Url: https://codereview.chromium.org/2075873003
/external/skia/tools/viewer/Viewer.cpp
|
| 74959a1471cd3b20e2dd79fc0c685e7205a25cd9 |
|
16-Jun-2016 |
liyuqian <liyuqian@google.com> |
Use Offscreen Surface for Split Screen
A dashed line is also added to split the screen. Currently, drawing
images with sRGB seems to still have bugs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069653002
Review-Url: https://codereview.chromium.org/2069653002
/external/skia/tools/viewer/Viewer.cpp
|
| b109b8c5ec40a7dd85a0a2951a1f98fa63b805aa |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Lots of progress on switching to SkColorSpace rather than SkColorProfileType
Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
Review-Url: https://codereview.chromium.org/2069173002
/external/skia/tools/viewer/Viewer.cpp
|
| ab8241880d09eb1774b4993ca6df048a27b7020c |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (patchset #10 id:180001 of https://codereview.chromium.org/2069173002/ )
Reason for revert:
Mac crashes in GrUploadPixmapToTexture
Original issue's description:
> Lots of progress on switching to SkColorSpace rather than SkColorProfileType
>
> Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
>
> Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170
TBR=reed@google.com,herb@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2072813002
/external/skia/tools/viewer/Viewer.cpp
|
| 6a61a875467646f8dbc37cfecf49e12d1f475170 |
|
16-Jun-2016 |
brianosman <brianosman@google.com> |
Lots of progress on switching to SkColorSpace rather than SkColorProfileType
Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002
Review-Url: https://codereview.chromium.org/2069173002
/external/skia/tools/viewer/Viewer.cpp
|
| c7027ab03f2e8bab4c74bc1b047642622d3d682b |
|
16-Jun-2016 |
jvanverth <jvanverth@google.com> |
Add samples to Viewer.
This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
Review-Url: https://codereview.chromium.org/2056343004
/external/skia/tools/viewer/Viewer.cpp
|
| 963632f686cd642344429f64e6a53262fe592828 |
|
15-Jun-2016 |
egdaniel <egdaniel@google.com> |
Revert of Enable viewer in non-Vulkan builds (patchset #2 id:20001 of https://codereview.chromium.org/2067023002/ )
Reason for revert:
breaking compile bots
Original issue's description:
> Enable viewer in non-Vulkan builds
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
>
> Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
TBR=djsollen@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2072563002
/external/skia/tools/viewer/Viewer.cpp
|
| 746b792a9aad1230ab69158a51c49b2e5437d95b |
|
15-Jun-2016 |
jvanverth <jvanverth@google.com> |
Enable viewer in non-Vulkan builds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Review-Url: https://codereview.chromium.org/2067023002
/external/skia/tools/viewer/Viewer.cpp
|
| 401cf48631acd9a24a542f9bd6b6bb1c16168070 |
|
13-Jun-2016 |
liyuqian <liyuqian@google.com> |
Quickly fix 0f to 0.0f
TBR=egdaniel@google.com
So Visual Studio won't complain.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064863002
Review-Url: https://codereview.chromium.org/2064863002
/external/skia/tools/viewer/Viewer.cpp
|
| d06693d9088f741c48a0b3b8449b3695447a86bc |
|
13-Jun-2016 |
liyuqian <liyuqian@google.com> |
Quickly fix the double to SkScalar issue
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060823004
Review-Url: https://codereview.chromium.org/2060823004
/external/skia/tools/viewer/Viewer.cpp
|
| 6f163d29438cefaaa10c5cd68e3b77c3cb9a6b79 |
|
13-Jun-2016 |
liyuqian <liyuqian@google.com> |
Display JPGs in Viewer with Split Screen and ColorSpaceXform
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058753002
Review-Url: https://codereview.chromium.org/2058753002
/external/skia/tools/viewer/Viewer.cpp
|
| f533f116e6324ee8592fbb49b8fca096c7fe926e |
|
13-Jun-2016 |
egdaniel <egdaniel@google.com> |
Revert of Add samples to Viewer. (patchset #4 id:60001 of https://codereview.chromium.org/2056343004/ )
Reason for revert:
breaking on android compile
Original issue's description:
> Add samples to Viewer.
>
> This adds support with animation, assuming the sample has
> implemented onAnimate. Event handling has not been
> implemented.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
>
> Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
TBR=bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2063883002
/external/skia/tools/viewer/Viewer.cpp
|
| 76963e73704a42a18c29d6fbdcccb566e5c67658 |
|
13-Jun-2016 |
jvanverth <jvanverth@google.com> |
Add samples to Viewer.
This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
Review-Url: https://codereview.chromium.org/2056343004
/external/skia/tools/viewer/Viewer.cpp
|
| 71491dc14cff017e175ae5eb555490559de67914 |
|
09-Jun-2016 |
liyuqian <liyuqian@google.com> |
Support resize in Android Viewer App
Previously, we took out resize because Vulkan didn't support it in
Android. Now Android nyc-dev builds >= 2937079 and nyc-release builds >=
NRD66 supports it so we add it back.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050613003
Review-Url: https://codereview.chromium.org/2050613003
/external/skia/tools/viewer/Viewer.cpp
|
| d94ad5823b7da7f115e997d12828314e290981f6 |
|
07-Jun-2016 |
liyuqian <liyuqian@google.com> |
Implement Raster Backend on Android Viewer App
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041193004
Review-Url: https://codereview.chromium.org/2041193004
/external/skia/tools/viewer/Viewer.cpp
|
| 1f508fd0fed5a91c0fccde8ba1c81a91e7fbe7d2 |
|
07-Jun-2016 |
liyuqian <liyuqian@google.com> |
Show FPS in UI state
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043793002
Review-Url: https://codereview.chromium.org/2043793002
/external/skia/tools/viewer/Viewer.cpp
|
| 814e38d5c11e4b71b2c87d1e1fe7bc8e8d688288 |
|
06-Jun-2016 |
jvanverth <jvanverth@google.com> |
Use intptr_t for onTouch argument.
On 64-bit platforms, casting int to void* is not valid.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047443002
Review-Url: https://codereview.chromium.org/2047443002
/external/skia/tools/viewer/Viewer.cpp
|
| b73c24b01a411843a98d4ccab7a39341d927e7fd |
|
03-Jun-2016 |
liyuqian <liyuqian@google.com> |
Add Softkey UIState to Viewer
We can use this to simulate any key/command on Android UI.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035923002
Review-Url: https://codereview.chromium.org/2035923002
/external/skia/tools/viewer/Viewer.cpp
|
| 6cb70251829a467b146da9bc8925064f33608e48 |
|
02-Jun-2016 |
liyuqian <liyuqian@google.com> |
Implement OpenGL backend in Android viewer app
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2032623002
Review-Url: https://codereview.chromium.org/2032623002
/external/skia/tools/viewer/Viewer.cpp
|
| 1e305ba0d6a4237020d36234e9e286d3b0489401 |
|
01-Jun-2016 |
jvanverth <jvanverth@google.com> |
Add offset to memory allocations
This is setting up for suballocations within one large
allocation
BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018933004
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/2018933004
/external/skia/tools/viewer/Viewer.cpp
|
| e5a6cd9832eaa7011dee162283ff6470f82a3fdc |
|
27-May-2016 |
liyuqian <liyuqian@google.com> |
Now we can use drawer to view the state information of the native app, and set its state using the spinner.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
Review-Url: https://codereview.chromium.org/2004633002
/external/skia/tools/viewer/Viewer.cpp
|
| 85f758c33446eaccfadc12292fa5a0e71d7661b9 |
|
27-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL support to Linux viewer
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
Review-Url: https://codereview.chromium.org/2011473003
/external/skia/tools/viewer/Viewer.cpp
|
| 9ad094933817800a2f700d261909000aca762fbe |
|
27-May-2016 |
kjlubick <kjlubick@google.com> |
Revert of Add drawer with state information (patchset #8 id:140001 of https://codereview.chromium.org/2004633002/ )
Reason for revert:
Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan. See https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan/builds/134/steps/compile_skia%20on%20Ubuntu/logs/stdio.
Original issue's description:
> Now we can use drawer to view the state information of the native app, and set its state using the spinner.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
>
> Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
TBR=djsollen@google.com,jvanverth@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2016343002
/external/skia/tools/viewer/Viewer.cpp
|
| 0248bfd8d25575cdfe6f45b74d5b485839b805a9 |
|
27-May-2016 |
kjlubick <kjlubick@google.com> |
Revert of Add OpenGL support to Linux viewer (patchset #5 id:80001 of https://codereview.chromium.org/2011473003/ )
Reason for revert:
Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan is broken and this patch prevents the revert of the culprit
Original issue's description:
> Add OpenGL support to Linux viewer
>
> Also adds a command line option (--vulkan) to choose between
> Vulkan and OpenGL.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
>
> Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2015213002
/external/skia/tools/viewer/Viewer.cpp
|
| 10b3815a11c39b154ec7b74a2af43e019b50d48c |
|
27-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL support to Linux viewer
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Review-Url: https://codereview.chromium.org/2011473003
/external/skia/tools/viewer/Viewer.cpp
|
| 4e4e30823fba0047b93a56bfcf05c04ca57e82ec |
|
26-May-2016 |
liyuqian <liyuqian@google.com> |
Now we can use drawer to view the state information of the native app, and set its state using the spinner.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
Review-Url: https://codereview.chromium.org/2004633002
/external/skia/tools/viewer/Viewer.cpp
|
| beb1c67c9d332b41b306b292bb77a0e1566c32a8 |
|
20-May-2016 |
liyuqian <liyuqian@google.com> |
Use SkASSERTResult to avoid unused local variables
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002
Review-Url: https://codereview.chromium.org/2003653002
/external/skia/tools/viewer/Viewer.cpp
|
| e46e4f075bfa8acf038aa68a8e7da282d4c1015b |
|
20-May-2016 |
liyuqian <liyuqian@google.com> |
Correct gesture scale and translation
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1996613002
Review-Url: https://codereview.chromium.org/1996613002
/external/skia/tools/viewer/Viewer.cpp
|
| af236b5aa9e7d71d59bee6533d16deb76e9d098b |
|
20-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
Review-Url: https://codereview.chromium.org/1978573003
/external/skia/tools/viewer/Viewer.cpp
|
| 2884e9c0bd2cc9634a4b932d4142840c67227a78 |
|
18-May-2016 |
jvanverth <jvanverth@google.com> |
Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of https://codereview.chromium.org/1978573003/ )
Reason for revert:
sk_app/WindowContext.cpp is missing. Need to add file and resubmit.
Original issue's description:
> Add OpenGL context to Viewer.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
>
> Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/1990893002
/external/skia/tools/viewer/Viewer.cpp
|
| d3cdbcad65673596ae37e65fec842d8d4d81c5a7 |
|
17-May-2016 |
liyuqian <liyuqian@google.com> |
Implement touch control
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1982643004
Review-Url: https://codereview.chromium.org/1982643004
/external/skia/tools/viewer/Viewer.cpp
|
| 56a11e4d6f3d436a3c2497c9c9e71a117d78a93f |
|
17-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
Review-Url: https://codereview.chromium.org/1978573003
/external/skia/tools/viewer/Viewer.cpp
|
| 622c8d5de12f264e496e8d4664a2eea9333922d0 |
|
10-May-2016 |
brianosman <brianosman@google.com> |
Add flexible keybinding/command system to sk_app.
Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.
CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).
Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955293002
Review-Url: https://codereview.chromium.org/1955293002
/external/skia/tools/viewer/Viewer.cpp
|
| 05de216ffb864cb1f3a4fa37a2c3a772be38a0c9 |
|
06-May-2016 |
brianosman <brianosman@google.com> |
Add sRGB mode toggle to Viewer.
Unlike SampleApp, this just switches out the format of the window
surface (and then adjusts the gamma-correct flag on the SkSurfaces).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950983007
Review-Url: https://codereview.chromium.org/1950983007
/external/skia/tools/viewer/Viewer.cpp
|
| a8d0d6c8bad00e713bc33e5f0d47ca4fec104433 |
|
05-May-2016 |
jvanverth <jvanverth@google.com> |
More refactoring for Viewer
* Move support files into sk_app and main files up to top directory
* Rename VulkanTestContext and create WindowContext parent class
* Place VulkanWindowContext et al. in sk_app namespace.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1944413005
Review-Url: https://codereview.chromium.org/1944413005
/external/skia/tools/viewer/Viewer.cpp
|