| 67e94fb6f2a84cad97ba96abce3506c29f8ebb24 |
|
12-Jan-2016 |
jackychen <jackychen@webrtc.org> |
Add unit test for stand-alone denoiser and fixed some bugs.
The unit test will run the pure C denoiser and SSE2/NEON denoiser (based
on the CPU detection) and compare the denoised frames to ensure the bit
exact.
TBR=tommi@webrtc.org
BUG=webrtc:5255
Review URL: https://codereview.webrtc.org/1492053003
Cr-Commit-Position: refs/heads/master@{#11216}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 13f61dfea59a546e4e0081eb79e38c542ec51cf6 |
|
04-Jan-2016 |
Peter Boström <pbos@webrtc.org> |
Move fake-handle frame creation into test target.
Renames CreateFakeNativeHandleFrame to FakeNativeHandle::CreateFrame and
moves into test.gyp target 'fake_video_frames' which contains previous
frame_generator target.
Removes unused warnings from includers of
webrtc/test/fake_texture_frame.h which did not use the function above.
BUG=webrtc:5398
R=kjellander@webrtc.org
TBR=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1554223002 .
Cr-Commit-Position: refs/heads/master@{#11149}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 0f2e939a92fc1a70a67a9fc141d1f1d006bcded9 |
|
10-Dec-2015 |
jbauch <jbauch@webrtc.org> |
Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.
This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.
Review URL: https://codereview.webrtc.org/1511603004
Cr-Commit-Position: refs/heads/master@{#10967}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| eb66e800d1f5f74ab366715d2618fbede8cf3e12 |
|
05-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Re-land "Convert native handles to buffers before encoding."
This reverts commit a67675506c9057bd9ffd4d76aae8b743343d434d.
BUG=webrtc:4081
TBR=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1158273010
Cr-Commit-Position: refs/heads/master@{#9381}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 308d163c715df7b4348a1e00bf2a6761c0adb689 |
|
02-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Revert "Convert native handles to buffers before encoding."
This reverts commit a831dc3a7d10a1fbaa258ee6b1ca6cfc7e91c5ca to unblock
rolling into Chromium.
BUG=4081
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/55549004
Cr-Commit-Position: refs/heads/master@{#9354}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| a831dc3a7d10a1fbaa258ee6b1ca6cfc7e91c5ca |
|
01-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Convert native handles to buffers before encoding.
Required to permit conversion of NV12 handles on iOS to I420 for VP8
software encoding, which blocks texture-based capture. This change
enforces that all texture-based input provides a method for converting
native handles to I420 if they are ever used with software encoders that
do not understand the native handles.
BUG=4081
R=emircan@chromium.org, glaznev@webrtc.org, hbos@webrtc.org, magjed@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, tkchin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50909005
Cr-Commit-Position: refs/heads/master@{#9347}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 4765070b8d6f024509c717c04d9b708750666927 |
|
30-May-2015 |
Miguel Casas-Sanchez <mcasas@webrtc.org> |
Rename I420VideoFrame to VideoFrame.
This is a mechanical change since it affects so many
files.
I420VideoFrame -> VideoFrame
and reformatted.
Rationale: in the next CL I420VideoFrame will
get an indication of Pixel Format (I420 for
starters) and of storage type: usually
UNOWNED, could be SHMEM, and in the near
future will be possibly TEXTURE. See
https://codereview.chromium.org/1154153003
for the change that happened in Cr.
BUG=4730, chromium:440843
R=jiayl@webrtc.org, niklas.enbom@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/52629004
Cr-Commit-Position: refs/heads/master@{#9339}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 9bfe3daf7349b62647997ced9389baa8ab043afe |
|
10-Apr-2015 |
Thiago Farina <tfarina@chromium.org> |
Cleanup: Remove i420_video_frame.h header.
It is just a pass through to webrtc/video_frame.h. Updated the callers
to include webrtc/video_frame.h instead and removed i420_video_frame.h.
This should fix pbos' TODO in i420_video_frame.h.
Tested on Linux with the following command lines:
$ rm -rf out/
$ ./webrtc/build/gyp_webrtc
$ ninja -C out/Debug
BUG=None
TEST=see above
R=magjed@webrtc.org, pbos@webrtc.org, tommi@webrtc.org
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46819004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#8973}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 9b3f56ea055934a5d5416db0386c857494410acc |
|
09-Apr-2015 |
Per <perkj@chromium.org> |
Reland "Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection.""
This reverts commit e41d774c4d0a60066866fc2d0ae48dd0e839ff23.
Original code review: https://webrtc-codereview.appspot.com/43999004/
Reason for reland: There was nothing wrong with this cl as is, but it breaks chrome compatibility. We will now reland this and fix Chrome during roll.
Patset 1: Original cl.
Patchset 2: Removed more code that is no longer needed.
R=magjed@webrtc.org, pbos@webrtc.org
TBR=mflodman@webrtc.org
BUG=1128
Review URL: https://webrtc-codereview.appspot.com/45049004
Cr-Commit-Position: refs/heads/master@{#8956}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| e41d774c4d0a60066866fc2d0ae48dd0e839ff23 |
|
07-Apr-2015 |
Per <perkj@chromium.org> |
Revert "Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection."
This reverts commit 75db8612588b4fabdf1b05f4ab145f7737093b45.
Revert "Fix build breakage in WrappedI420Buffer::native_handle()"
This reverts commit 3211934ebf7cac3e6df2cb4aacb6e47cc1cffe2b.
Reason for revert: Breaks chrome build and tests on clank, See https://codereview.chromium.org/1067803002/
BUG=1128
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43079004
Cr-Commit-Position: refs/heads/master@{#8940}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 75db8612588b4fabdf1b05f4ab145f7737093b45 |
|
07-Apr-2015 |
Per <perkj@chromium.org> |
Remove usage of webrtc::NativeHandle since is just adds an extra level of indirection.
BUG=1128
R=magjed@webrtc.org, pbos@webrtc.org
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43999004
Cr-Commit-Position: refs/heads/master@{#8932}
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| deafa7b3c9a247106ad190a14c823b053eb13cf5 |
|
24-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Remove I420VideoFrame::SwapFrame
The few remaining uses of this function are replaced with I420VideoFrame assignment, similar to scoped_refptr assignment.
BUG=1128
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42889004
Cr-Commit-Position: refs/heads/master@{#8844}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8844 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 2d2a30c2e22c16580193a8767bb4e7a2a3b30c00 |
|
24-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Remove I420VideoFrame::CloneFrame
This function is not needed anymore.
BUG=1128
R=stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42899004
Cr-Commit-Position: refs/heads/master@{#8843}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8843 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 6231fb6dac8276581e4ed0f7cb70712d6b6711aa |
|
20-Mar-2015 |
pbos@webrtc.org <pbos@webrtc.org> |
Prevent crashes when copying a zero-size frame.
BUG=4451
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44749004
Cr-Commit-Position: refs/heads/master@{#8802}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8802 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 5a477a0bc6fd3657eb7173d2c8a2e1a01a88dbb3 |
|
18-Mar-2015 |
pbos@webrtc.org <pbos@webrtc.org> |
DCHECK frame parameters instead of return codes.
We should never be creating video frames without width/height. If these
DCHECKs fire we should be fixing the calling code instead.
BUG=4359
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46639004
Cr-Commit-Position: refs/heads/master@{#8779}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8779 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| af612d5e0769571544952cbe55e675748afa9bdd |
|
18-Mar-2015 |
perkj@webrtc.org <perkj@webrtc.org> |
Reland "Make the entry point for VideoFrames to webrtc const ref I420VideoFrame.""
Original cl description:
This removes the none const pointer entry and SwapFrame.
Since frames delivered using VideoSendStream no longer use the external capture module, VideoSendStream will not get an incoming framerate callback. VideoSendStream now uses a rtc::RateTracker.
Also, the video engine must ensure that time stamps are always increasing.
With this, time stamps (ntp, render_time and rtp timestamps ) are checked and set in ViECapturer::OnIncomingCapturedFrame
This cl was previously reverted in https://webrtc-codereview.appspot.com/46549004/.
Patchset 1 contains the original patch after rebase.
Patshet 2 fix webrtc_perf_tests reported in chromium:465306
Note that chromium:465287 is being fixed in https://webrtc-codereview.appspot.com/43829004/
BUG=1128
R=magjed@webrtc.org, mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47629004
Cr-Commit-Position: refs/heads/master@{#8776}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8776 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 2056ee3e3c7683ae4b2c4b12da99c3105c4f46a9 |
|
16-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Revert "Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*."
This reverts commit r8731.
Reason for revert: Breakes Chromium FYI bots.
TBR=hbos, tommi
Review URL: https://webrtc-codereview.appspot.com/40359004
Cr-Commit-Position: refs/heads/master@{#8733}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8733 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 93d9d6503e2bf2526af2b1c2cc46ef242b9843aa |
|
16-Mar-2015 |
hbos@webrtc.org <hbos@webrtc.org> |
I420VideoFrame.CreateFrame: Removed unnecessary buffer size arguments.
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45629004
Cr-Commit-Position: refs/heads/master@{#8732}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8732 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 2dc5fa69b2baef2ece158c9e1285516087faaa53 |
|
16-Mar-2015 |
hbos@webrtc.org <hbos@webrtc.org> |
Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*.
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40299004
Cr-Commit-Position: refs/heads/master@{#8731}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8731 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 0d9bb8e499f52a53292fdb6dfa7dc956f6bff85b |
|
11-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Remove the need for scoped_ptr<I420VideoFrame> in VieCapturer.
Remove the need for scoped_ptr<I420VideoFrame> in VieCapturer.
This adds the method I420VideoFrame::Reset and replace the use of scoped_ptr in ViECapturer.
Also, a unittest is added to check that ViECapturer does not retain a frame after it has been delivered.
BUG=1128
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43669004
Cr-Commit-Position: refs/heads/master@{#8678}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8678 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| d7452a016812ab1de69c3d7a53caca5b06c64990 |
|
10-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Revert "Make the entry point for VideoFrames to webrtc const ref I420VideoFrame."
This reverts commit r8633.
Reason for revert: Performance regressions in browser_tests_new_vie and webrtc_perf_tests.
BUG=1128,chromium:465287,chromium:465306
TBR=pbos,mflodman,perkj
Review URL: https://webrtc-codereview.appspot.com/46549004
Cr-Commit-Position: refs/heads/master@{#8670}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8670 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| bcead305a2f27c30c72c6a3824fdf12f4b83c2eb |
|
06-Mar-2015 |
perkj@webrtc.org <perkj@webrtc.org> |
Make the entry point for VideoFrames to webrtc const ref I420VideoFrame.
This removes the none const pointer entry and SwapFrame.
Since frames delivered using VideoSendStream no longer use the external capture module, VideoSendStream will not get an incoming framerate callback. VideoSendStream now uses a rtc::RateTracker.
Also, the video engine must ensure that time stamps are always increasing.
With this, time stamps (ntp, render_time and rtp timestamps ) are checked and set in ViECapturer::OnIncomingCapturedFrame
BUG=1128
R=magjed@webrtc.org, mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46429004
Cr-Commit-Position: refs/heads/master@{#8633}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8633 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 45cdcce5f5c34d9321915473d8a0daafcf3abf78 |
|
06-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Remove TextureVideoFrame
TextureVideoFrame is currently an empty shell that only provides a convenience constructor of I420VideoFrame with a texture buffer. This CL moves that constructor, and all unittests, of TextureVideoFrame into the base class. Then it's possible to completely remove TextureVideoFrame and all its files. Also, there is no point in having I420VideoFrame virtual anymore.
R=pbos@webrtc.org, perkj@webrtc.org, stefan@webrtc.org
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/40229004
Cr-Commit-Position: refs/heads/master@{#8629}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8629 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 2386d6dd92f10a715f131b5ad408b1babc1f35b0 |
|
05-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Revert 8599 "Revert 8580 "Unify underlying frame buffer in I420VideoFrame and...""
It's possible to build Chrome on Windows with this patch now.
BUG=1128
> This is unfortunately causing build problems in Chrome on Windows.
>> Unify underlying frame buffer in I420VideoFrame and WebRtcVideoFrame
>>
>> Currently, I420VideoFrame uses three webrtc::Plane to store pixel data, and WebRtcVideoFrame uses WebRtcVideoFrame::FrameBuffer/webrtc::VideoFrame. The two subclasses WebRtcTextureVideoFrame and TextureVideoFrame use a NativeHandle to store pixel data, and there is also a class WebRtcVideoRenderFrame that wraps an I420VideoFrame.
>>
>> This CL replaces these classes with a new interface VideoFrameBuffer that provides the common functionality. This makes it possible to remove deep frame copies between cricket::VideoFrame and I420VideoFrame.
>>
>> Some additional minor changes are:
>> * Disallow creation of 0x0 texture frames.
>> * Remove the half-implemented ref count functions in I420VideoFrame.
>> * Remove the Alias functionality in WebRtcVideoFrame
>>
>> The final goal is to eliminate all frame copies, but to limit the scope of this CL, some planned changes are postponed to follow-up CL:s (see planned changes in https://webrtc-codereview.appspot.com/38879004, or https://docs.google.com/document/d/1bxoJZNmlo-Z9GnQwIaWpEG6hDlL_W-bzka8Zb_K2NbA/preview). Specifically, this CL:
>> * Keeps empty subclasses WebRtcTextureVideoFrame and TextureVideoFrame, and just delegates the construction to the superclass.
>> * Keeps the deep copies from cricket::VideoFrame to I420VideoFrame.
>>
>> BUG=1128
>> R=mflodman@webrtc.org, pbos@webrtc.org, perkj@webrtc.org, tommi@webrtc.org
>>
>> Review URL: https://webrtc-codereview.appspot.com/42469004
R=pbos@webrtc.org
TBR=mflodman, pbos, perkj, tommi
Review URL: https://webrtc-codereview.appspot.com/45489004
Cr-Commit-Position: refs/heads/master@{#8616}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8616 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 1f94407319f85abc286c993774a4ea93807ec32e |
|
04-Mar-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Revert 8580 "Unify underlying frame buffer in I420VideoFrame and..."
This is unfortunately causing build problems in Chrome on Windows.
> Unify underlying frame buffer in I420VideoFrame and WebRtcVideoFrame
>
> Currently, I420VideoFrame uses three webrtc::Plane to store pixel data, and WebRtcVideoFrame uses WebRtcVideoFrame::FrameBuffer/webrtc::VideoFrame. The two subclasses WebRtcTextureVideoFrame and TextureVideoFrame use a NativeHandle to store pixel data, and there is also a class WebRtcVideoRenderFrame that wraps an I420VideoFrame.
>
> This CL replaces these classes with a new interface VideoFrameBuffer that provides the common functionality. This makes it possible to remove deep frame copies between cricket::VideoFrame and I420VideoFrame.
>
> Some additional minor changes are:
> * Disallow creation of 0x0 texture frames.
> * Remove the half-implemented ref count functions in I420VideoFrame.
> * Remove the Alias functionality in WebRtcVideoFrame
>
> The final goal is to eliminate all frame copies, but to limit the scope of this CL, some planned changes are postponed to follow-up CL:s (see planned changes in https://webrtc-codereview.appspot.com/38879004, or https://docs.google.com/document/d/1bxoJZNmlo-Z9GnQwIaWpEG6hDlL_W-bzka8Zb_K2NbA/preview). Specifically, this CL:
> * Keeps empty subclasses WebRtcTextureVideoFrame and TextureVideoFrame, and just delegates the construction to the superclass.
> * Keeps the deep copies from cricket::VideoFrame to I420VideoFrame.
>
> BUG=1128
> R=mflodman@webrtc.org, pbos@webrtc.org, perkj@webrtc.org, tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/42469004
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42199005
Cr-Commit-Position: refs/heads/master@{#8599}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8599 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| f82109cb4d638826f8c795a9bcf41a51c258ba2d |
|
04-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Initialize memory in I420VideoFrame unittest
Previously, when CreateEmptyFrame was called with a smaller size than before, we would reuse the allocation. Now, we allocate a new tight frame. The CL that made this change is https://webrtc-codereview.appspot.com/42469004/. This exposed an uninitialized memory problem in a I420VideoFrame unittest. This CL fixes that unittest.
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42619004
Cr-Commit-Position: refs/heads/master@{#8593}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8593 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| c8895aa2f31e05d3bd4d29507af3bbfcaa638499 |
|
03-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Unify underlying frame buffer in I420VideoFrame and WebRtcVideoFrame
Currently, I420VideoFrame uses three webrtc::Plane to store pixel data, and WebRtcVideoFrame uses WebRtcVideoFrame::FrameBuffer/webrtc::VideoFrame. The two subclasses WebRtcTextureVideoFrame and TextureVideoFrame use a NativeHandle to store pixel data, and there is also a class WebRtcVideoRenderFrame that wraps an I420VideoFrame.
This CL replaces these classes with a new interface VideoFrameBuffer that provides the common functionality. This makes it possible to remove deep frame copies between cricket::VideoFrame and I420VideoFrame.
Some additional minor changes are:
* Disallow creation of 0x0 texture frames.
* Remove the half-implemented ref count functions in I420VideoFrame.
* Remove the Alias functionality in WebRtcVideoFrame
The final goal is to eliminate all frame copies, but to limit the scope of this CL, some planned changes are postponed to follow-up CL:s (see planned changes in https://webrtc-codereview.appspot.com/38879004, or https://docs.google.com/document/d/1bxoJZNmlo-Z9GnQwIaWpEG6hDlL_W-bzka8Zb_K2NbA/preview). Specifically, this CL:
* Keeps empty subclasses WebRtcTextureVideoFrame and TextureVideoFrame, and just delegates the construction to the superclass.
* Keeps the deep copies from cricket::VideoFrame to I420VideoFrame.
BUG=1128
R=mflodman@webrtc.org, pbos@webrtc.org, perkj@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42469004
Cr-Commit-Position: refs/heads/master@{#8580}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8580 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 97ed2a4b70eb3f78bb2e1f51a14bbdfeb1783502 |
|
02-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
I420VideoFrame: Remove function ResetSize
This is a partial reland of https://webrtc-codereview.appspot.com/39939004/.
The original CL was reverted because ViECapturer use ResetSize/IsZeroSize on |captured_frame_| as a check to make sure each captured frame is only delivered once. Removing ResetSize introduced a race condition where a captured frame could be delivered multiple times.
I have fixed this problem in this CL by replacing ResetSize with scoped_ptr::release.
BUG=4352
R=perkj@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39359004
Cr-Commit-Position: refs/heads/master@{#8561}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8561 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| fd33293d58aa9e715000477dae3fdc0cfa394f42 |
|
02-Mar-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
I420VideoFrame: Remove functions set_width and set_height
This is a partial reland of https://webrtc-codereview.appspot.com/39939004/.
The functions set_width and set_height in I420VideoFrame are not needed and just add complexity.
R=perkj@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41009004
Cr-Commit-Position: refs/heads/master@{#8556}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8556 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 7400e0b87609af0295ca123ad38d01fb7b430329 |
|
27-Feb-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Revert "I420VideoFrame: Remove functions set_width, set_height, and ResetSize"
This reverts commit r8434.
Reason for revert: Introduced a race condition. If ViECaptureProcess() -> SwapCapturedAndDeliverFrameIfAvailable() is called twice without a call to OnIncomingCapturedFrame() in between (with both captured_frame_ and deliver_frame_ populated), an old frame will be delivered again, since captured_frame_->IsZeroSize() will never be true.
BUG=4352
TBR=perkj@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40129004
Cr-Commit-Position: refs/heads/master@{#8530}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8530 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 00b8f6b3643332cce1ee711715f7fbb824d793ca |
|
26-Feb-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| be29b3b4c6f711f6aa2902863c69a1978b6613a5 |
|
19-Feb-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
I420VideoFrame: Remove functions set_width, set_height, and ResetSize
The functions set_width, set_height, and ResetSize in I420VideoFrame are not needed and just add complexity.
R=perkj@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39939004
Cr-Commit-Position: refs/heads/master@{#8434}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8434 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 88828e77d9dd0d92848384bffccbc507ef8598d8 |
|
18-Feb-2015 |
magjed@webrtc.org <magjed@webrtc.org> |
Fix I420VideoFrame unittests
* Only compare actual pixel data, not the padding between width and stride.
* When creating a frame from raw buffers with excessive size, do not assume that the frame’s allocated size will be as excessive as the input buffers.
* The arrays in TestI420VideoFrame.CopyFrame and TestI420VideoFrame.CloneFrame are too small, and we currently memcpy out of bounds.
I think this CL should land regardless, but the main purpose is to pave the way for for planned changes to I420VideoFrame. See https://review.webrtc.org/38879004.
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34199004
Cr-Commit-Position: refs/heads/master@{#8416}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8416 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 1226e926e6104322d9b99026b98f515cb4d40fd4 |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Committed: https://code.google.com/p/webrtc/source/detail?r=8338
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8339}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8339 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| dc7b02277cc1666dfc13b636c2ecfe53b12c9d2a |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8338}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8338 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 20e8f227664a6747cea11e1fc1de4c018ebcc8e9 |
|
11-Feb-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org, pthatcher@webrtc.org, stefan@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8337}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8337 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 637c55f45be7a56478f399c7e62e9be06947cd80 |
|
28-May-2014 |
wuchengli@chromium.org <wuchengli@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add support of texture frames for video capturer.
This is a reland of r6252. The video_capture_tests failure on
builder Android Chromium-APK Tests should be flaky.
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding, video_engine_core_unittests,
common_video_unittests and video_capture_tests_apk.
TBR=fischman@webrtc.org, perkj@webrtc.org, stefan@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6258 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 89e8ffb3956ca7cdaa9c1d225eefaf2e3616503f |
|
27-May-2014 |
wuchengli@chromium.org <wuchengli@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert "Add support of texture frames for video capturer."
This reverts commit 83c89cd003be75d7d06ef9a2b139588f08d280ca.
Reason: The Buildbot has detected a new failure on builder
Android Chromium-APK Tests.
BUG=chromium:362437
TBR=fischman@webrtc.org, perkj@webrtc.org, stefan@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6253 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| efe15355eece265f76c8e60d00b2690b3f6f124a |
|
27-May-2014 |
wuchengli@chromium.org <wuchengli@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add support of texture frames for video capturer.
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding. Run video_engine_core_unittests and common_video_unittests.
R=fischman@webrtc.org, perkj@webrtc.org, stefan@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6252 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 6c75c989648018a1537bb29d41fbcb730b143c15 |
|
15-Apr-2014 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Propagate capture ntp timestamp from rtp to renderer.
Mostly the interface changes, the real implementation of ntp timestamp will come in a follow up cl.
TEST=new tests and try bots
BUG=3111
R=niklas.enbom@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5911 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 5dd2ecb32df9643575ec2110a3aa05061f1e2a66 |
|
01-Nov-2013 |
sheu@chromium.org <sheu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert "Remove extra copy in VideoCaptureImpl::IncomingFrameI420"
This reverts commit f4ca3808bd9ec2293ec205f2f4a7d9739ce1f2df.
TBR=niklas.emblom@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/3269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5071 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 74e6e8458e78a3b684bd7a07677ad8ac9c5b360e |
|
31-Oct-2013 |
sheu@chromium.org <sheu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Remove extra copy in VideoCaptureImpl::IncomingFrameI420
Add support for aliasing a I420VideoFrame (and internally, a Plane) to an
existing memory buffer without taking ownership. Use this to remove an extra
copy in VideoCaptureImpl::IncomingFrameI420.
BUG=1128
BUG=chromium:310271
TEST=local build, run Chromium on ARM, build, run Chromium/unittests on Linux
TBR=fischman@webrtc.org, mflodman@webrtc.org, mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3239005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5070 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| d705649edf3d4a1b9e0cd22e646af7a6e0324b74 |
|
31-Oct-2013 |
sheu@chromium.org <sheu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert "Remove extra copy in VideoCaptureImpl::IncomingFrameI420"
This reverts commit 99f9743fe39066ba93b41f2b0a417696cbbd06fb.
Revert while build breakage is fixed.
BUG=None
TBR=niklas.emblom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5069 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 1a4ed0d70cd5a1a6b5b1402371654e16b2ebd57b |
|
31-Oct-2013 |
sheu@chromium.org <sheu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Remove extra copy in VideoCaptureImpl::IncomingFrameI420
Add support for aliasing a I420VideoFrame (and internally, a Plane) to an
existing memory buffer without taking ownership. Use this to remove an extra
copy in VideoCaptureImpl::IncomingFrameI420.
BUG=1128
TEST=local build, run Chromium on ARM, build, run Chromium/unittests on Linux
R=fischman@webrtc.org, mflodman@webrtc.org, mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5068 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| c69ae69d0b25c03173fdca000c81545987ba78ce |
|
04-Jun-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Include files from webrtc/.. paths in common_video/
BUG=1662
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1546004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4167 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| e239bf094041baf816e7f6e1f867fece19e1718f |
|
19-Dec-2012 |
mikhal@webrtc.org <mikhal@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Making I420VideoFrame ref-counted
BUG=937
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/1009004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3312 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|
| 14b43beb7ce4440b30dcea31196de5b4a529cb6b |
|
22-Oct-2012 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/common_video/i420_video_frame_unittest.cc
|