384194369b4be41912353631a68689129a49e58c |
|
16-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Consolidate constructormagic macros with Chromium version and remove Chromium override. Part of work removing dependency on Chromium's base. Only adds "= delete". From https://codereview.chromium.org/1151443003 : "This will guarantee the error to be at compile time, and not rely on the call visibility (private)." In consequence of that change, fixed an illegal copy and removed a bunch of unused variables. Depends on https://codereview.webrtc.org/1345433002/ BUG=chromium:468375 (in particular comment #37) NOTRY=true Review URL: https://codereview.webrtc.org/1342543004 Cr-Commit-Position: refs/heads/master@{#9954}
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
3c089d751ede283e21e186885eaf705c3257ccd2 |
|
16-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to contructormagic macros. We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition. * DISALLOW_ASSIGN -> RTC_DISALLOW_ASSIGN * DISALLOW_COPY_AND_ASSIGN -> RTC_DISALLOW_COPY_AND_ASSIGN * DISALLOW_IMPLICIT_CONSTRUCTORS -> RTC_DISALLOW_IMPLICIT_CONSTRUCTORS Related CL: https://codereview.webrtc.org/1335923002/ BUG=chromium:468375 NOTRY=true Review URL: https://codereview.webrtc.org/1345433002 Cr-Commit-Position: refs/heads/master@{#9953}
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
9a78d22822880884f9fa495e4cbe33f5224296c4 |
|
10-Sep-2015 |
tommi <tommi@webrtc.org> |
Revert of Consolidate constructormagic macros with Chromium version and remove Chromium override. (patchset #4 id:60001 of https://codereview.webrtc.org/1316363005/ ) Reason for revert: Had to revert since FYI bots stopped compiling. Example failure: [94/9470] CXX obj\third_party\webrtc\modules\video_processing\main\source\video_processing_sse2.content_analysis_sse2.obj FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\video_coding\codecs\h264\webrtc_h264.h264.obj.rsp /c ..\..\third_party\webrtc\modules\video_coding\codecs\h264\h264.cc /Foobj\third_party\webrtc\modules\video_coding\codecs\h264\webrtc_h264.h264.obj /Fdobj\third_party\webrtc\modules\webrtc_h264.cc.pdb e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN' FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\base\rtc_base_approved.bitbuffer.obj.rsp /c ..\..\third_party\webrtc\base\bitbuffer.cc /Foobj\third_party\webrtc\base\rtc_base_approved.bitbuffer.obj /Fdobj\third_party\webrtc\base\rtc_base_approved.cc.pdb e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN' FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\audio_processing\logging\audio_processing.aec_logging_file_handling.obj.rsp /c ..\..\third_party\webrtc\modules\audio_processing\logging\aec_logging_file_handling.cc /Foobj\third_party\webrtc\modules\audio_processing\logging\audio_processing.aec_logging_file_handling.obj /Fdobj\third_party\webrtc\modules\audio_processing.cc.pdb e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN' FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\audio_processing\beamformer\audio_processing.nonlinear_beamformer.obj.rsp /c ..\..\third_party\webrtc\modules\audio_processing\beamformer\nonlinear_beamformer.cc /Foobj\third_party\webrtc\modules\audio_processing\beamformer\audio_processing.nonlinear_beamformer.obj /Fdobj\third_party\webrtc\modules\audio_processing.cc.pdb e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN' Original issue's description: > Consolidate constructormagic macros with Chromium version and remove Chromium override. > > Part of work removing dependency on Chromium's base. > > Only adds "= delete". From https://codereview.chromium.org/1151443003 : > "This will guarantee the error to be at compile time, and not rely on the call visibility (private)." > > In consequence of that change, fixed an illegal copy and removed a bunch of unused variables. > > BUG=chromium:468375 (in particular comment #37) > NOTRY=true > > Committed: https://crrev.com/0de8ff488d92e0bc6b7b65662898ff5e955cda93 > Cr-Commit-Position: refs/heads/master@{#9913} TBR=andrew@webrtc.org,henrikg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468375 (in particular comment #37) Review URL: https://codereview.webrtc.org/1330283002 Cr-Commit-Position: refs/heads/master@{#9914}
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
0de8ff488d92e0bc6b7b65662898ff5e955cda93 |
|
10-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Consolidate constructormagic macros with Chromium version and remove Chromium override. Part of work removing dependency on Chromium's base. Only adds "= delete". From https://codereview.chromium.org/1151443003 : "This will guarantee the error to be at compile time, and not rely on the call visibility (private)." In consequence of that change, fixed an illegal copy and removed a bunch of unused variables. BUG=chromium:468375 (in particular comment #37) NOTRY=true Review URL: https://codereview.webrtc.org/1316363005 Cr-Commit-Position: refs/heads/master@{#9913}
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
14665ff7d4024d07e58622f498b23fd980001871 |
|
04-Mar-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro Clang version changed 223108:230914 Details: https://chromium.googlesource.com/chromium/src/+/e144d30..6fdb142/tools/clang/scripts/update.sh Removes the OVERRIDE macro defined in: * webrtc/base/common.h * webrtc/typedefs.h The majority of the source changes were done by running this in src/: perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"` which converted all: virtual Foo() OVERRIDE functions to: Foo() override Then I manually edited: * talk/media/webrtc/fakewebrtccommon.h * webrtc/test/fake_common.h Remaining uses of OVERRIDE was fixed by search+replace. Manual edits were done to fix virtual destructors that were overriding inherited ones. Finally a build error related to the pure virtual definitions of Read, Write and Rewind in common_types.h required a bit of refactoring in: * webrtc/common_types.cc * webrtc/common_types.h * webrtc/system_wrappers/interface/file_wrapper.h * webrtc/system_wrappers/source/file_impl.cc This roll should make it possible for us to finally re-enable deadlock detection for TSan on the buildbots. BUG=4106 R=pbos@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/41069004 Cr-Commit-Position: refs/heads/master@{#8596} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
730d2707713c4240070af17e56edd10d039bafd2 |
|
29-Sep-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Remove callback from RtpDepacketizer::Parse(). BUG= R=pbos@webrtc.org, stefan@webrtc.org Review URL: https://webrtc-codereview.appspot.com/30489004 Patch from Changbin Shao <changbin.shao@intel.com>. git-svn-id: http://webrtc.googlecode.com/svn/trunk@7318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
315669939afc8461b40612c905eaec95c2ee645d |
|
25-Sep-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Fix typo from RtpPacketizerH264. BUG= R=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/27609004 Patch from Changbin Shao <changbin.shao@intel.com>. git-svn-id: http://webrtc.googlecode.com/svn/trunk@7295 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
b5e6bfc76a32a588da2400636688d34a71a2f47d |
|
12-Sep-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Make RTPSender/RTPReceiver generic. Changes include, 1) Introduce class RtpPacketizerGeneric & RtpDePacketizerGeneric. 2) Introduce class RtpDepacketizerVp8. 3) Make RTPSenderVideo::SendH264 generic and used by all packetizers. 4) Move codec specific functions from RTPSenderVideo/RTPReceiverVideo to RtpPacketizer/RtpDePacketizer sub-classes. R=pbos@webrtc.org, stefan@webrtc.org Review URL: https://webrtc-codereview.appspot.com/26399004 Patch from Changbin Shao <changbin.shao@intel.com>. git-svn-id: http://webrtc.googlecode.com/svn/trunk@7163 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|
2ec560606be6519dc4e32a1e6855b0f362ca498d |
|
31-Jul-2014 |
stefan@webrtc.org <stefan@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add H.264 packetization. This also includes: - Creating new packetizer and depacketizer interfaces. - Moved VP8 packetization was H264 packetization and depacketization to these interfaces. This is a work in progress and should be continued to get this 100% generic. This also required changing the return type for RtpFormatVp8::NextPacket(), which now returns bool instead of the index of the first partition. - Created a Create() factory method for packetizers and depacketizers. R=niklas.enbom@webrtc.org, pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/21009004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6804 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
|