| 0eb15ed7b806125774bd13fb214aeb403e2c6857 |
|
17-Dec-2015 |
kwiberg <kwiberg@webrtc.org> |
Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector
We can now use std::move instead!
This CL leaves the Pass methods in place; a follow-up CL will add deprecation annotations to them.
Review URL: https://codereview.webrtc.org/1460043002
Cr-Commit-Position: refs/heads/master@{#11064}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 2935e0141939adc642d73da6d8048a4e918a8382 |
|
18-Nov-2015 |
thaloun <thaloun@google.com> |
Several Tick counter improvements try #2."
This reverts commit c91d1738709b038fee84d569180cba2bbcbfe5d7.
BUG=
Review URL: https://codereview.webrtc.org/1452843003
Cr-Commit-Position: refs/heads/master@{#10682}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| c91d1738709b038fee84d569180cba2bbcbfe5d7 |
|
17-Nov-2015 |
thaloun <thaloun@chromium.org> |
Revert of Several Tick counter improvements. (patchset #8 id:140001 of https://codereview.webrtc.org/1415923010/ )
Reason for revert:
Potentially breaks a threading test under DrMemory. Rolling back while I investigate.
Original issue's description:
> Several Tick counter improvements.
>
> Move logic into cc file
> Simplify interval calculation
> Remove unused QUERY_PERFORMANCE_COUNTER windows implementation
> Remove double divide on each ::Now() invocation on mac
>
> Move TickTime and TickInterval funcitons to cc file in prep for refactoring.
>
> BUG=
> R=mflodman@webrtc.org, pbos@webrtc.org
>
> Committed: https://crrev.com/4c27e4b62da2047063d88eedfeec3e939fea7843
> Cr-Commit-Position: refs/heads/master@{#10661}
TBR=pbos@webrtc.org,mflodman@webrtc.org,noahric@chromium.org,thaloun@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1450203002
Cr-Commit-Position: refs/heads/master@{#10663}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 4c27e4b62da2047063d88eedfeec3e939fea7843 |
|
16-Nov-2015 |
Tim Haloun <thaloun@chromium.org> |
Several Tick counter improvements.
Move logic into cc file
Simplify interval calculation
Remove unused QUERY_PERFORMANCE_COUNTER windows implementation
Remove double divide on each ::Now() invocation on mac
Move TickTime and TickInterval funcitons to cc file in prep for refactoring.
BUG=
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1415923010 .
Cr-Commit-Position: refs/heads/master@{#10661}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| ff761fba8274d93bd73e76c8b8a1f2d0776dd840 |
|
04-Nov-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
modules: more interface -> include renames
This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface
To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in include. This is required to avoid getting redefinitions in the not-yet-updated downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
"use webrtc/modules/include")
5. Search for all source references to webrtc/modules/interface and update them to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
6. Update all GYP+GN files. This required manual inspection since many subdirectories of webrtc/modules referenced the interface dir using ../interface etc(*.gyp*,*.gn*)
BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc
R=stefan@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1417683006 .
Cr-Commit-Position: refs/heads/master@{#10500}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 98f53510b222f71fdd8b799b2f33737ceeb28c61 |
|
28-Oct-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1413333002 .
Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 847855b865987524be768c7771959f927db25808 |
|
11-Sep-2015 |
stefan <stefan@webrtc.org> |
Add a name to the ProcessThread constructor.
Helps differentiate between different instances when debugging.
Review URL: https://codereview.webrtc.org/1337003003
Cr-Commit-Position: refs/heads/master@{#9927}
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 03054486f52d80b69af787c3ef8d855a72349203 |
|
05-Mar-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Adding basic support for posting tasks to a process thread.
BUG=
R=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41099004
Cr-Commit-Position: refs/heads/master@{#8614}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8614 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 3985f0151aff9b91418733795a98140079c19a73 |
|
27-Feb-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
ProcessThread improvements.
* Added a way to notify a Module that it's been attached to a ProcessThread.
The benefit of this is to give the module a way to wake up the thread
when it needs work to happen on the worker thread, immediately.
Today, module instances are typically registered with a process thread
outside the control of the modules themselves. I.e. they typically
don't know about the process thread they're attached to.
* Improve ProcessThread's WakeUp algorithm to not call TimeUntilNextProcess
when a WakeUp call is requested. This is an optimization for the above
case which avoids the module having to acquire a lock or do an interlocked
operation before calling WakeUp(), which would ensure the module's
TimeUntilNextProcess() implementation would return 0.
BUG=2822
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39239004
Cr-Commit-Position: refs/heads/master@{#8527}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8527 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 11426dc719f24ece3246fd8fb24ae073c49b42ed |
|
11-Feb-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Don't rely on webrtc/base/scoped_ptr.h to include stuff for you
webrtc/base/scoped_ptr.h doesn't need to include webrtc/base/common.h
anymore, but a couple of its users were relying on it to pull in other
things for them. Fix that, and remove the now really unnecessary
webrtc/base/common.h include.
R=andrew@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37169004
Cr-Commit-Position: refs/heads/master@{#8333}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8333 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 1d4830a077f6cd3a0fd1d062a93a244118b83e9b |
|
07-Feb-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Disable ProcessThread tests that are dependent on timing.
Some of the bots are too slow for the tests to make much sense as they are.
TBR=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39869004
Cr-Commit-Position: refs/heads/master@{#8281}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8281 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| bc3241a8cc525e7b666af60d175cda89994796d5 |
|
06-Feb-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Update ProcessCallAfterXms to better match the performance of our faster bots. Previously I had made sure these tests didn't flake out on our slow trybots, but apparently I need to do the same for the fast bots :)
TBR=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40659004
Cr-Commit-Position: refs/heads/master@{#8262}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8262 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|
| 0c3e12b7bfb26b9060be67ded53068acd3444ab8 |
|
06-Feb-2015 |
tommi@webrtc.org <tommi@webrtc.org> |
Revamp the ProcessThreadImpl implementation.
* Add a new WakeUp method that gives a module a chance to be called back right away on the worker thread.
* Wrote unit tests for the class.
* Significantly reduce the amount of locking.
- ProcessThreadImpl itself does a lot less locking.
- Reimplemented the way we keep track of when to make calls to Process.
This reduces the amount of calls to TimeUntilNextProcess and since most implementations of that function grab a lock, this means less locking.
* Renamed ProcessThread::CreateProcessThread to ProcessThread::Create.
* Added thread checks for Start/Stop. Threading model of other functions is now documented.
* We now log an error if an implementation of TimeUntilNextProcess returns a negative value (some implementations do, but the method should only return a positive nr of ms).
* Removed the DestroyProcessThread method and instead force callers to use scoped_ptr<> to maintain object lifetime.
BUG=2822
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35999004
Cr-Commit-Position: refs/heads/master@{#8261}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8261 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/utility/source/process_thread_impl_unittest.cc
|