History log of /frameworks/base/core/java/android/app/TimePickerDialog.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
553303fac18598c2209f89e3174d94d55e6fa91f 01-Jun-2017 Aurimas Liutikas <aurimas@google.com> Fix TimePickerDialog positive button clicks.

With my TimePickerDialog change to support keyboard based input I
accidentally broke TimePickerDialog#onClick as it was no longer being
called, instead it was calling TimeSetListener directly. This CL changes
the logic back to use onClick again.

Bug: 36042834
Test: Locally tested FitBit app.
Change-Id: I47d5563c99cc46eaaf2b1d4a96483d6825fc5805
/frameworks/base/core/java/android/app/TimePickerDialog.java
9a28a0970dacb5957fea4b4e32659e9edaffe931 14-Mar-2017 Aurimas Liutikas <aurimas@google.com> Restore TimePickerDialog#onClick behavior.

onClick used to dismiss the dialog recording the set time.
In ag/1831151 I removed handling of BUTTON_POSITIVE as the button
clicks were now handled via click listener set in show(). However,
onClick can be also called programatically and not just via clicking
the button. This CL restores that behavior. It will skip validation
and use the last valid hour and minute.

Bug: 36037351
Test: TimePickerDialogTest#testOnClick now passes
Change-Id: I15952dadab0c7b73ae5fecb1539edf5ebddec68c
/frameworks/base/core/java/android/app/TimePickerDialog.java
ab14d825c3eb2a337de02af93333e8302c08c732 25-Jan-2017 Aurimas Liutikas <aurimas@google.com> Adding text input mode to TimePicker.

Test: Tests will have a follow up CL.
Bug:30044800

Change-Id: I71a0fba97026da76251768016edf1b159617abb9
/frameworks/base/core/java/android/app/TimePickerDialog.java
8817aa93392b7a46402eacd7a3b252d1da6c7225 22-Sep-2016 Alan Viverette <alanv@google.com> Allow developer to override Material-style modes in picker dialogs

A recent fix prevented developers from specifying Holo-style mode when
displaying a date or time picker dialog. This CL also cleans up unused
code in TimePickerDialog and documents how themeResId will be used.

Adds hidden @TestApi methods for use in CTS tests. These may be made
public later, but it's too late in MR1 for API changes.

Bug: 31586821
Test: Ice2e203983769f1ea1cfa93105eb97b6fa5176b9
Change-Id: I1b7512b7647ddd7ab987beac2c0aef4fe7cc16bc
/frameworks/base/core/java/android/app/TimePickerDialog.java
4420ae875de711a91dc10f7f4dd5a9cc62221ac8 16-Nov-2015 Alan Viverette <alanv@google.com> Clean up TimePicker

No functional changes, only refactoring:
- shorten method and variable names
- remove unused validation callback
- avoid using return in setters

Change-Id: Ie7c19cfe3c5cb515695f943c534899d37ad032bb
/frameworks/base/core/java/android/app/TimePickerDialog.java
62c79e9a64c3b2cafd5500ed3064977dff7b7da3 26-Feb-2015 Alan Viverette <alanv@google.com> Implement landscape layout for time picker dialog

Adds support overriding default alert dialog panel elements by including
them in the dialog's custom content view, but no public API (yet!) since
the panel IDs have never been public. Some minor cleanup and refactoring
in TimePickerDialog. Removes Holo styles for "clock" and "calendar" style
pickers since they are new in Material. If the new styles are used against
Holo they will match Material but with Holo primary/accent colors.

Also implements themed color state lists to resolve TODOs in both time
and date pickers.

Bug: 19431361
Change-Id: I095fd8d653e02d9e5d20d66611432a08a7a5685e
/frameworks/base/core/java/android/app/TimePickerDialog.java
d26276d9e39ed9d96102d41977de972d884bb7cd 27-Nov-2014 Alan Viverette <alanv@google.com> Cancel dialog when TimePickerDialog's BUTTON_NEGATIVE is clicked

BUG: 18541882
Change-Id: I2ba4611e08ba08667ef5ee4fb556d1c9075ca6d2
/frameworks/base/core/java/android/app/TimePickerDialog.java
fd4bc4cdca85963d3685471c87ba4f252e981184 13-Aug-2014 Craig Stout <cstout@google.com> Fix alert, date picker, time picker dialogs for TV.

b/15194230

Change-Id: I85bcef86332acb041e5c3b1f8c515d981486c3d1
/frameworks/base/core/java/android/app/TimePickerDialog.java
518ff0de95e64116ecb07706fc564d4c19197ca7 15-Aug-2014 Alan Viverette <alanv@google.com> Fix date and time picker styling

Removes done buttons from widgets, fixes date picker day selection, fixes
dialog layouts in landscape, updates colors. Adds API on AlertDialog for
setting the view by resource ID, which is necessary to correctly inflate
the view against the dialog's parent view.

BUG: 16941550
BUG: 16852521
BUG: 16878697
BUG: 16838659
BUG: 17047435
Change-Id: I138858ce06cd4abf68a2c3361ec170370236b33b
/frameworks/base/core/java/android/app/TimePickerDialog.java
abdd154334eced2595d42e17a9dbac242a9af7da 17-Jul-2014 Craig Stout <cstout@google.com> Fix timepicker double done buttons.

Leanback theme uses a legacy layout with a done button, but
apps won't necessarily have target apilevel L.

Change-Id: Ib38b08df1fe07bd8fb4e64e93633ce0b7eb12567
/frameworks/base/core/java/android/app/TimePickerDialog.java
5134478151d8aa3d776f8d4f368dbcdbc501a92a 17-Jul-2014 Alan Viverette <alanv@google.com> Add public attributes for TimePicker styling

BUG: 11218747
Change-Id: Ifdf981280ebe20a9066f219c9a4505d0d7486b2e
/frameworks/base/core/java/android/app/TimePickerDialog.java
278387fb5f68812b51ee98523397108ef2cd66c7 16-Jul-2014 Fabrice Di Meglio <fdimeglio@google.com> Fix bug #16309454 Broken recent button after dismissing set time dialog

- correct set and use the Canceled state

Change-Id: Id60ae14c493254193ee677b66388a64a49618273
/frameworks/base/core/java/android/app/TimePickerDialog.java
dfaa6c7439d1506b2450005a6c1e0be6771eb9e5 11-Jul-2014 Fabrice Di Meglio <fdimeglio@google.com> Fix TimePicker behavior

- use Alert Theme and make the TimePickerDialog show its done button
in the legacy mode
- if targetSdkVersion < L or if TV UI show the legacy TimePicker

Change-Id: I19ca6dbbcb50599c7e230262a23956c185f53a5c
/frameworks/base/core/java/android/app/TimePickerDialog.java
59c7b4b04f8f69b1c03bd26b289d805d7e23498f 23-Jun-2014 Craig Stout <cstout@google.com> TimePickerDialog does not force new ui on TV.

Add support for done button in LegacyTimePickerDelegate.
Provide leanback themed legacy time picker layout with buttons
on the side.

b/15194230

Change-Id: Ie05c1cf45b334e9642095d63c682aba314ff3c6b
/frameworks/base/core/java/android/app/TimePickerDialog.java
4c0cb8a526eec87fdba6dc371e21abfa4e993ea0 04-Apr-2014 Craig Stout <cstout@google.com> AlertDialog and AppError themes for TV.

Leanback themes override AlertDialog styles from other themes.
Makes system alert dialogs, and alert dialogs from games running on ATV,
have a style more appropriate to television.

Final visuals pending.

Side button layout fixes DatePickerDialog and TimePickerDialog with
dpad navigation.

TODO: consider using side button layout for other AlertDialog cases
(long messages and lists).

Change-Id: I74e4e04d16d6854377580be95a87684a0385b04b
/frameworks/base/core/java/android/app/TimePickerDialog.java
eeff63a5c347f282b5c8c3ae6a0924bf03fbce8f 05-Aug-2013 Fabrice Di Meglio <fdimeglio@google.com> Update TimePicker widget and its related dialog

- the old TimePicker widget is still there for obvious layout compatibility reasons
- add a new delegate implementation for having a new UI based on a radial picker
- use the new delegate only for the TimePickerDialog (which does not need to be
the same)
- added support for Theming and light/dark Themes
- added support for I18N (hour formatting and time separator and also position of
AM/PM indicator coming from Unicode CLDR)
- added support for RTL
- verified support for Keyboard
- verified that CTS tests for TimePicker are passing (for both the legacy and the
new widgets)

Also added a new HapticFeedbackConstants.CLOCK_TICK and its related code for
enabling ticks vibration.

Change-Id: Ib9b53a152bd9e97383dc391ef8c26da91217298f
/frameworks/base/core/java/android/app/TimePickerDialog.java
4c359b76f9a030f92a302ba74a528faa170bad4e 25-Jul-2012 Scott Main <smain@google.com> docs: fix a bunch of links from javadocs to api guides
and add some attributes to Spinner and Switch

Change-Id: If015ad000c1a36e19904c132e98ebff1ceaf718b
/frameworks/base/core/java/android/app/TimePickerDialog.java
fe41ce4ef97e7da585fdbf06988da8047e72b9f6 03-Apr-2012 Svetoslav Ganov <svetoslavganov@google.com> Polish the Number/Date/Pickers per UX request.

1. Now the NumberPicker max height is a bit smaller.

2. The Time/Date picker add top and bottom margin to
compensate for the shorter NumberPickers.

3. The Time/DatePicker dialogs have only "Done" button
and tapping onside saves the current state.

bug:6277808

Change-Id: I4c5928debb1c3b7fe126d6cd6745e3c5eb980901
/frameworks/base/core/java/android/app/TimePickerDialog.java
9f086d812ff04703de4b14e02a7702ba7c8acb33 30-Nov-2011 Svetoslav Ganov <svetoslavganov@google.com> NumberPicker incorrectly shown for the old theme.

1. NumberPicker is trying to greedily grow to its max size
but if the max size is not specified the default value
was the max integer which makes the widget get quite
tall in some cases. Now the widget tries to reach the
max size only if it has been specified.

2. NumberPicker was not computing its min width when the array
of display values is set.

3. DatePicker' layout for the old Theme was adding a margin on
the right of the group of spinners and if the calendar view
is not shown the spinners were not centered. Added the spinners
right margin to the left margin of the calendar view.

4. TimePickerDialog was using the wrong conext and was not dismissable
on an outside touch. Same for the DatePickerDialog context.

bug:5646161

Change-Id: Ic15f9b3e6291b76493604230ceb4f783a04d4ac7
/frameworks/base/core/java/android/app/TimePickerDialog.java
87879e8ef99e3e57b6c317e8579ebc39174327f7 02-Feb-2011 Brian Muramatsu <btmura@google.com> Fix Incorrect Times in TimePickerDialog

Bug 3414311

TimePicker#setCurrentHour subtracts 12 from the given hour if
is24HourView returns false. TimePickerDialog calls setCurrentHour before
setIs24HourView, so the 12 will always be substracted from the time.
Reorder the statements so that TimePickerDialog sets is24HourView,
before setting the hour and time.

Change-Id: Ib997397b04dbdd767e67806aea7614426019e938
/frameworks/base/core/java/android/app/TimePickerDialog.java
bf80562d22b2bbe7944d80d0524c69d0238010cb 18-Dec-2010 Svetoslav Ganov <svetoslavganov@google.com> Bug 3191746. atePicker TimePicker: Dark theme is used in a Light theme app

Change-Id: I20d0cca3b78af9db80854a57c88d6cab3b00f555
/frameworks/base/core/java/android/app/TimePickerDialog.java
206316a61f904ea0a6b106137dd7715a2c246d4c 19-Nov-2010 Svetoslav Ganov <svetoslavganov@google.com> New Number picker widget

Change-Id: I834e725b58682e7a48cc3f3302c93c57b35d4e27
/frameworks/base/core/java/android/app/TimePickerDialog.java
c63806d852a550d82bbe6cadff8a2139d78ed559 24-Sep-2010 Adam Powell <adamp@google.com> Holo themes and assets in progress

Change-Id: Ic10480dc1c771d0ccd10f1d4014c945480fd6c0d
/frameworks/base/core/java/android/app/TimePickerDialog.java
bb8d314b6c5ff9b51af29daa687d66dfd996914f 20-Aug-2010 Scott Main <smain@google.com> am 70c9ffbc: am 11a72482: Merge "docs: add links from widget classes to tutorials" into froyo

Merge commit '70c9ffbc838271f0ea27a4780eb146287de53ef6' into gingerbread-plus-aosp

* commit '70c9ffbc838271f0ea27a4780eb146287de53ef6':
docs: add links from widget classes to tutorials
41ec65355bd6ded652769725b276d47c54a0d913 20-Aug-2010 Scott Main <smain@google.com> docs: add links from widget classes to tutorials

Change-Id: I817e885524951853182b0458df4a32dea1614243
/frameworks/base/core/java/android/app/TimePickerDialog.java
a47130783b386df4a371d9b6898eaae5720260f6 25-Jun-2010 Christian Mehlmauer <FireFart@gmail.com> Replaced deprecated calls to setButton and setButton2

Change-Id: Ifcc3f3afc1689406a3298dab7b00a8edb83c115e
/frameworks/base/core/java/android/app/TimePickerDialog.java
9066cfe9886ac131c34d59ed0e2d287b0e3c0087 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/frameworks/base/core/java/android/app/TimePickerDialog.java
d83a98f4ce9cfa908f5c54bbd70f03eec07e7553 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/frameworks/base/core/java/android/app/TimePickerDialog.java
f013e1afd1e68af5e3b868c26a653bbfb39538f8 18-Dec-2008 The Android Open Source Project <initial-contribution@android.com> Code drop from //branches/cupcake/...@124589
/frameworks/base/core/java/android/app/TimePickerDialog.java
54b6cfa9a9e5b861a9930af873580d6dc20f773c 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/frameworks/base/core/java/android/app/TimePickerDialog.java